)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"f74ad60e6ee8b80d86748355a62a7af27a82161f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ae0c41f7_661e31b9","updated":"2024-01-31 14:55:14.000000000","message":"@dalees, what do you think?","commit_id":"339a7715879acc08b3d7aee2fe76e6aad3fca1fc"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"d6d9fb51ccd2a24adb5c937d73df87f0b8b385d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d59cb35f_a9fc0715","updated":"2024-02-01 08:00:38.000000000","message":"LGTM","commit_id":"339a7715879acc08b3d7aee2fe76e6aad3fca1fc"}],"magnum/drivers/heat/driver.py":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"3b1c6dd2506cf44b699012ed3598f3467b554c3e","unresolved":true,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"            if stack.stack_status in (fields.ClusterStatus.CREATE_COMPLETE,"},{"line_number":427,"context_line":"                                      fields.ClusterStatus.CREATE_FAILED,"},{"line_number":428,"context_line":"                                      fields.ClusterStatus.CREATE_IN_PROGRESS,"},{"line_number":429,"context_line":"                                      fields.ClusterStatus.UPDATE_COMPLETE):"},{"line_number":430,"context_line":"                # Resolve all outputs if the stack is COMPLETE"},{"line_number":431,"context_line":"                stack \u003d self.openstack_client.heat().stacks.get("}],"source_content_type":"text/x-python","patch_set":8,"id":"2ebf221f_ba5c7a3e","line":428,"updated":"2024-01-15 22:22:14.000000000","message":"What is the impact on Heat of doing these extra `resolve_outputs\u003dTrue` requests?\n\nIf we merge this, how many more requests and load are we going to have, here?\n\nIt benefits the CI, no doubt, but I want to understand if we\u0027re going to cause a performance regression with this.","commit_id":"569615a49439e39a4d2e4afa0b8ad32c1c97e94b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d36df0deea54193ae9d1f975d5a2de4cec8f67a4","unresolved":true,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"            if stack.stack_status in (fields.ClusterStatus.CREATE_COMPLETE,"},{"line_number":427,"context_line":"                                      fields.ClusterStatus.CREATE_FAILED,"},{"line_number":428,"context_line":"                                      fields.ClusterStatus.CREATE_IN_PROGRESS,"},{"line_number":429,"context_line":"                                      fields.ClusterStatus.UPDATE_COMPLETE):"},{"line_number":430,"context_line":"                # Resolve all outputs if the stack is COMPLETE"},{"line_number":431,"context_line":"                stack \u003d self.openstack_client.heat().stacks.get("}],"source_content_type":"text/x-python","patch_set":8,"id":"9823ab5d_d05510d4","line":428,"in_reply_to":"2ebf221f_ba5c7a3e","updated":"2024-01-31 09:25:52.000000000","message":"I think we need a variable to enable/disable this and use it in CI, let me rework.","commit_id":"569615a49439e39a4d2e4afa0b8ad32c1c97e94b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ad9b3451e335ca169b21b093c1ae2c3a458b8537","unresolved":true,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"            if stack.stack_status in (fields.ClusterStatus.CREATE_COMPLETE,"},{"line_number":427,"context_line":"                                      fields.ClusterStatus.CREATE_FAILED,"},{"line_number":428,"context_line":"                                      fields.ClusterStatus.CREATE_IN_PROGRESS,"},{"line_number":429,"context_line":"                                      fields.ClusterStatus.UPDATE_COMPLETE):"},{"line_number":430,"context_line":"                # Resolve all outputs if the stack is COMPLETE"},{"line_number":431,"context_line":"                stack \u003d self.openstack_client.heat().stacks.get("}],"source_content_type":"text/x-python","patch_set":8,"id":"dded2912_b06162d0","line":428,"in_reply_to":"3b2af2e9_b8363372","updated":"2024-01-31 11:06:36.000000000","message":"let\u0027s check create_failed and manage the create timeout properly in CI","commit_id":"569615a49439e39a4d2e4afa0b8ad32c1c97e94b"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"fc65295d603875d18e77f70aa34bcf90c0b4624a","unresolved":true,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"            if stack.stack_status in (fields.ClusterStatus.CREATE_COMPLETE,"},{"line_number":427,"context_line":"                                      fields.ClusterStatus.CREATE_FAILED,"},{"line_number":428,"context_line":"                                      fields.ClusterStatus.CREATE_IN_PROGRESS,"},{"line_number":429,"context_line":"                                      fields.ClusterStatus.UPDATE_COMPLETE):"},{"line_number":430,"context_line":"                # Resolve all outputs if the stack is COMPLETE"},{"line_number":431,"context_line":"                stack \u003d self.openstack_client.heat().stacks.get("}],"source_content_type":"text/x-python","patch_set":8,"id":"3b2af2e9_b8363372","line":428,"in_reply_to":"9823ab5d_d05510d4","updated":"2024-01-31 10:28:20.000000000","message":"so I traced this back to periodic task[1], which only gets run (every 100s) when a cluster is in one of the *_IN_PROGRESS state.\n\nTo ensure we don\u0027t keep doing `resolve_outputs\u003dTrue`, we need to limit it to when the cluster is in a final state. So adding CREATE_FAILED is OK, but CREATE_IN_PROGRESS isn\u0027t.\n\n[1] https://opendev.org/openstack/magnum/src/branch/stable/2023.2/magnum/service/periodic.py#L167-L169","commit_id":"569615a49439e39a4d2e4afa0b8ad32c1c97e94b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"498a0c6e7a80392fcb817d177d9501f6c6acd158","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"            if stack.stack_status in (fields.ClusterStatus.CREATE_COMPLETE,"},{"line_number":427,"context_line":"                                      fields.ClusterStatus.CREATE_FAILED,"},{"line_number":428,"context_line":"                                      fields.ClusterStatus.CREATE_IN_PROGRESS,"},{"line_number":429,"context_line":"                                      fields.ClusterStatus.UPDATE_COMPLETE):"},{"line_number":430,"context_line":"                # Resolve all outputs if the stack is COMPLETE"},{"line_number":431,"context_line":"                stack \u003d self.openstack_client.heat().stacks.get("}],"source_content_type":"text/x-python","patch_set":8,"id":"bcbde7b1_01dc3264","line":428,"in_reply_to":"dded2912_b06162d0","updated":"2024-02-02 09:44:42.000000000","message":"Done","commit_id":"569615a49439e39a4d2e4afa0b8ad32c1c97e94b"}]}