)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"14a2fabce943fb0cce450baf3a154be8c4d80399","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15d090e1_e007a01d","updated":"2024-01-15 21:48:32.000000000","message":"Thanks Oleksandr!\n\nThis seems like a fairly reasonable change, even if the in-tree Heat driver doesn\u0027t support Cilium. The alternative change would be to either remove this validation entirely, delegate the validation into the driver or make it part of the driver selection[1] - but these are much larger changes. Magnum should consider these if we find ourselves having to change this often for out-of-tree drivers.\n\nThe only change I would suggest is to ensure the in-tree Heat driver fails sensibly with \u0027cilium\u0027 selected; which may simply mean defaulting the value of \u0027kubernetes_allowed_network_drivers\u0027 to [\u0027flannel\u0027,\u0027calico\u0027] so we error on this value by default.\n\nThen it can be configured as allowed, intentionally - and a CAPI driver could set this to [\u0027calico\u0027, \u0027cilium\u0027] and have the desired support.\n\n\n[1] As proposed initially in https://review.opendev.org/c/openstack/magnum/+/904835","commit_id":"7306be1ce0a6a216b70eacc48d2e45f58125a244"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"18ee0949d9f0cf684a9b7657f2d0baa068b6e4b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78536734_364bf834","in_reply_to":"15d090e1_e007a01d","updated":"2024-02-02 14:51:30.000000000","message":"Thanks for your feedback Dale.\nI did changed the default value of kubernetes_allowed_network_drivers in the last patch. Also I reverted the user doc change. I think adding cilium in the suported network driver list in doc could lead some confusion to users because in-tree heat driver doesn\u0027t support Cilium. So IMH, we can just make a proper note in the code snippet where cilium is added for now, and will update the user doc properly once we implement the changes which let conductor fetches supported net driver list from the cluster driver implementation.","commit_id":"7306be1ce0a6a216b70eacc48d2e45f58125a244"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"bede91ea267bc90ca57eb02029cc203f31a9071b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fa9cce5_4ed2c0c6","in_reply_to":"78536734_364bf834","updated":"2024-02-09 08:43:06.000000000","message":"Done","commit_id":"7306be1ce0a6a216b70eacc48d2e45f58125a244"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"1e6bd67f57f0d6b41aa8ad721a2a7af00ff36350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"33c7970c_5655ed36","updated":"2024-02-07 19:38:23.000000000","message":"Discussed in weekly meeting, I\u0027m happy with this as is. (please address the CI comment, though)","commit_id":"23b06862514e6b3b85b130f313a0a5777939daa7"}]}