)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"a0d797aa66c98329e34a43a49cef586b779e6347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd416701_c53b232f","updated":"2024-02-19 09:36:42.000000000","message":"Thanks for this. Can we also have a reno for this please?","commit_id":"a12262b8ba6a016c5575c427138e5d773d73cab2"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"78438f241a12598d508643c238bbf047e0c06c8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39686269_c33667a2","updated":"2024-02-21 22:53:03.000000000","message":"Looks ok, calico 3.3 is untested on all recent k8s versions. \n\nI\u0027ll upgrade to +2 with release note addition, as Jake noted.","commit_id":"bf49694da74114e275014afe85cf2f9bafca4030"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"a0d797aa66c98329e34a43a49cef586b779e6347","unresolved":true,"context_lines":[{"line_number":1424,"context_line":"            - if:"},{"line_number":1425,"context_line":"                - calico_v3_3"},{"line_number":1426,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1427,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service.sh"},{"line_number":1428,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1429,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1430,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b9d3641c_1020f133","side":"PARENT","line":1427,"range":{"start_line":1427,"start_character":0,"end_line":1427,"end_character":89},"updated":"2024-02-19 09:36:42.000000000","message":"don\u0027t we still need this?","commit_id":"48fbd623742599156416745fe07a93e870a4029a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f408d016fc12cb92cd6ba99aa42b9498948074ad","unresolved":false,"context_lines":[{"line_number":1424,"context_line":"            - if:"},{"line_number":1425,"context_line":"                - calico_v3_3"},{"line_number":1426,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1427,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service.sh"},{"line_number":1428,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1429,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1430,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a2a738fe_d52aa439","side":"PARENT","line":1427,"range":{"start_line":1427,"start_character":0,"end_line":1427,"end_character":89},"in_reply_to":"07f2dbcd_55b46f7c","updated":"2024-02-21 10:01:59.000000000","message":"True that - fixed.","commit_id":"48fbd623742599156416745fe07a93e870a4029a"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"139e886545ff09d0f6c597b48cc8526ec1d136d1","unresolved":true,"context_lines":[{"line_number":1424,"context_line":"            - if:"},{"line_number":1425,"context_line":"                - calico_v3_3"},{"line_number":1426,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1427,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service.sh"},{"line_number":1428,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1429,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1430,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"07f2dbcd_55b46f7c","side":"PARENT","line":1427,"range":{"start_line":1427,"start_character":0,"end_line":1427,"end_character":89},"in_reply_to":"b9d3641c_1020f133","updated":"2024-02-21 09:58:34.000000000","message":"Yes this doesn\u0027t seem intentional in this patchset - this line is the \u0027else\u0027 clause.\n\nThis patch appears to be dropping installation of both `calico-v3-3-x.sh` and `calico-service.sh`","commit_id":"48fbd623742599156416745fe07a93e870a4029a"}]}