)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7014500b5f63ee9d0ef5e564172c50c056fc0de5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e490b177_1980c295","updated":"2024-02-19 14:47:26.000000000","message":"Added depends on to get kubectl describe pod output","commit_id":"635751419e07eec470765a80169e578d7ca530af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2be7cfab8de56f764230046a30133e1d4c90909c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2e7d7de6_a53df889","updated":"2024-02-20 08:06:29.000000000","message":"recheck","commit_id":"32d45385693958d5c64db58f8e2603d3f8031fdf"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"11b0746ed72a4ae8ffa3a2f00e553e7fdd7461d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6c4b0475_95ddfbbb","updated":"2024-02-28 23:38:52.000000000","message":"A few notes on internet dependencies; perhaps these are acceptable for most?\n\nThoughts welcomed on how Magnum should treat these; I don\u0027t need to block progress for Gold Standard solutions; we\u0027re functional enough with static manifests in Magnum Heat.","commit_id":"e75b58e0391f0fa96d4e78b89d74826ef8b0ec62"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8539afb57334eb7b4f35562285e4f2d22b3118f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f480373b_e3366d73","updated":"2024-02-28 09:19:38.000000000","message":"Agreed on the meeting 28/Feb/2024 to not merge it in favour of updating the manifest","commit_id":"e75b58e0391f0fa96d4e78b89d74826ef8b0ec62"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"21cadb87730852e8ecc778077c5cf03d15200890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1a83848f_1968886f","updated":"2024-02-28 11:00:59.000000000","message":"recheck - flannel failed with etcdmain: failed to join discovery cluster (client: response is invalid json. The endpoint is probably not valid etcd cluster endpoint)","commit_id":"e75b58e0391f0fa96d4e78b89d74826ef8b0ec62"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"84600393d6080c8d9891e2122f402eba86147977","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"40f38af2_7c69d1cc","in_reply_to":"3206be95_ad32f0f9","updated":"2024-03-11 12:58:47.000000000","message":"I think basically Kubernetes clusters have connectivity to the internet - but I\u0027ll follow up as mentioned in another thread with an option to override to a local Helm chart store.","commit_id":"e75b58e0391f0fa96d4e78b89d74826ef8b0ec62"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9a98cef3bcdf2efa7cc46cbb5233a97ce0fb4bb1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3206be95_ad32f0f9","in_reply_to":"6c4b0475_95ddfbbb","updated":"2024-03-05 20:09:02.000000000","message":"Clarification: by \"we\u0027re functional enough\", I mean my company rather than speaking for the Magnum project.","commit_id":"e75b58e0391f0fa96d4e78b89d74826ef8b0ec62"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"337802e97cc9da73f1b8e134f4e9684e68b8900f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9661343f_c2229eab","in_reply_to":"f480373b_e3366d73","updated":"2024-03-05 16:26:24.000000000","message":"Done","commit_id":"e75b58e0391f0fa96d4e78b89d74826ef8b0ec62"}],"magnum/drivers/common/templates/kubernetes/helm/calico-service.sh":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"11b0746ed72a4ae8ffa3a2f00e553e7fdd7461d3","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    done"},{"line_number":38,"context_line":"    kubectl create namespace ${CHART_NAME}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    helm_prepare_cmd\u003d\"helm repo add projectcalico https://docs.tigera.io/calico/charts\""},{"line_number":41,"context_line":"    helm_install_cmd\u003d\"helm upgrade --install calico projectcalico/tigera-operator --version ${CALICO_TAG} -f values.yaml --namespace tigera-operator\""},{"line_number":42,"context_line":"    helm_history_cmd\u003d\"helm history calico --namespace tigera-operator\""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"c462b4a2_f4f57947","line":40,"updated":"2024-02-28 23:38:52.000000000","message":"Noting that this reaches out to the internet for helm charts. Other addons do the same, but they are optional, whereas calico CNI is fundamental in having a functional cluster.\n\nPerhaps this is okay, and alternatives can be added later (like referencing self-hosted OCI registries). No need to block on this merging.","commit_id":"b29d6a1ab3445eb683e48dbdb9a13cc26eee14a4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"baf9f3a943413eef9236056d3f517a3422d6d10a","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    done"},{"line_number":38,"context_line":"    kubectl create namespace ${CHART_NAME}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    helm_prepare_cmd\u003d\"helm repo add projectcalico https://docs.tigera.io/calico/charts\""},{"line_number":41,"context_line":"    helm_install_cmd\u003d\"helm upgrade --install calico projectcalico/tigera-operator --version ${CALICO_TAG} -f values.yaml --namespace tigera-operator\""},{"line_number":42,"context_line":"    helm_history_cmd\u003d\"helm history calico --namespace tigera-operator\""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"afced87d_05bcab47","line":40,"in_reply_to":"c462b4a2_f4f57947","updated":"2024-03-11 12:57:01.000000000","message":"I think I\u0027d prefer to follow up on this - because other charts locations\u0027 also can\u0027t be overridden.","commit_id":"b29d6a1ab3445eb683e48dbdb9a13cc26eee14a4"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"11b0746ed72a4ae8ffa3a2f00e553e7fdd7461d3","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        done"},{"line_number":53,"context_line":"        popd"},{"line_number":54,"context_line":"    fi"},{"line_number":55,"context_line":"    curl -L https://github.com/projectcalico/calico/releases/download/${CALICO_TAG}/calicoctl-linux-amd64 -o /srv/magnum/bin/kubectl-calico"},{"line_number":56,"context_line":"    chmod +x /srv/magnum/bin/kubectl-calico"},{"line_number":57,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"65eb8bd9_ec2d928a","line":55,"updated":"2024-02-28 23:38:52.000000000","message":"Noting this pulls from the internet with no option for overriding the url to local hosting. This will break airgapping.","commit_id":"b29d6a1ab3445eb683e48dbdb9a13cc26eee14a4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"337802e97cc9da73f1b8e134f4e9684e68b8900f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        done"},{"line_number":53,"context_line":"        popd"},{"line_number":54,"context_line":"    fi"},{"line_number":55,"context_line":"    curl -L https://github.com/projectcalico/calico/releases/download/${CALICO_TAG}/calicoctl-linux-amd64 -o /srv/magnum/bin/kubectl-calico"},{"line_number":56,"context_line":"    chmod +x /srv/magnum/bin/kubectl-calico"},{"line_number":57,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"0b0c3de3_894cf4b3","line":55,"in_reply_to":"65eb8bd9_ec2d928a","updated":"2024-03-05 16:26:24.000000000","message":"Ack, removed that for now.","commit_id":"b29d6a1ab3445eb683e48dbdb9a13cc26eee14a4"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9a98cef3bcdf2efa7cc46cbb5233a97ce0fb4bb1","unresolved":true,"context_lines":[{"line_number":583,"context_line":"  calico_tag:"},{"line_number":584,"context_line":"    type: string"},{"line_number":585,"context_line":"    description: tag of the calico containers used to provision the calico node"},{"line_number":586,"context_line":"    default: v3.25.2"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"  calico_kube_controllers_tag:"},{"line_number":589,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"05691086_e096cc91","line":586,"updated":"2024-03-05 20:09:02.000000000","message":"Without `calico_helm` set (the default), this version won\u0027t work with the other static manifests we have (updated in https://review.opendev.org/c/openstack/magnum/+/910551).\n\nThey support:\n* 3.26.* if this minor version matches\n* For all other versions, use 3.21.* manifest. This will not function for version 3.25.\n\nIs it functional for helm to bump this to 3.26.* instead?","commit_id":"92ac15e7c336027943e1d1708d30e847ebbdd671"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"baf9f3a943413eef9236056d3f517a3422d6d10a","unresolved":false,"context_lines":[{"line_number":583,"context_line":"  calico_tag:"},{"line_number":584,"context_line":"    type: string"},{"line_number":585,"context_line":"    description: tag of the calico containers used to provision the calico node"},{"line_number":586,"context_line":"    default: v3.25.2"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"  calico_kube_controllers_tag:"},{"line_number":589,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"757f8eda_57383584","line":586,"in_reply_to":"05691086_e096cc91","updated":"2024-03-11 12:57:01.000000000","message":"Let\u0027s not bump at all - at least in C cycle.","commit_id":"92ac15e7c336027943e1d1708d30e847ebbdd671"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9a98cef3bcdf2efa7cc46cbb5233a97ce0fb4bb1","unresolved":true,"context_lines":[{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"  calico_helm:"},{"line_number":1005,"context_line":"    type: boolean"},{"line_number":1006,"context_line":"    description: If true, use Helm for Calico deployment"},{"line_number":1007,"context_line":"    default: false"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"f588011c_b77521c4","line":1006,"updated":"2024-03-05 20:09:02.000000000","message":"Suggestion: Add \u0027otherwise, use static Calico manifest\u0027 to the end of description.","commit_id":"92ac15e7c336027943e1d1708d30e847ebbdd671"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"baf9f3a943413eef9236056d3f517a3422d6d10a","unresolved":false,"context_lines":[{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"  calico_helm:"},{"line_number":1005,"context_line":"    type: boolean"},{"line_number":1006,"context_line":"    description: If true, use Helm for Calico deployment"},{"line_number":1007,"context_line":"    default: false"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1c02d4ea_156cfece","line":1006,"in_reply_to":"f588011c_b77521c4","updated":"2024-03-11 12:57:01.000000000","message":"Done","commit_id":"92ac15e7c336027943e1d1708d30e847ebbdd671"}]}