)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35572,"name":"Pawel Kubica","email":"pawel.kubica@comarch.com","username":"pawcykca"},"change_message_id":"b8d50778a3f1b4450fd7551b798af5f6ad721709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa2d4f11_43f058cb","updated":"2024-02-29 08:01:34.000000000","message":"We have been using Calico v3.26 with Magnum for some time now based on a very similar implementation - my observations in the comments.","commit_id":"2ed069349ba4910a5c54db09f62f6919ffc71ce6"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"8d13f83159855768a2074c2ac8ee61ab5af484a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d77c5dfe_de388497","updated":"2024-03-07 02:55:48.000000000","message":"recheck calico pods fail to init","commit_id":"0fdec721283018c06d0f8548c66ffef83ca9c5d8"}],"magnum/drivers/common/templates/kubernetes/fragments/calico-service-v3-26-x.sh":[{"author":{"_account_id":35572,"name":"Pawel Kubica","email":"pawel.kubica@comarch.com","username":"pawcykca"},"change_message_id":"b8d50778a3f1b4450fd7551b798af5f6ad721709","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c812678_8a67e3a7","side":"PARENT","line":4214,"range":{"start_line":4212,"start_character":0,"end_line":4214,"end_character":50},"updated":"2024-02-29 08:01:34.000000000","message":"Why Node IP autodetection method was changed to \u0027first-found\u0027 (default) method?","commit_id":"a41c8844635f02500e7c20f358ea24fb47de288a"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"626652540eeae78dd12cfef9da02ab72d3abb2c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42119dc2_64d9ddba","side":"PARENT","line":4214,"range":{"start_line":4212,"start_character":0,"end_line":4214,"end_character":50},"in_reply_to":"0c812678_8a67e3a7","updated":"2024-02-29 23:08:55.000000000","message":"Thank you, that is not intentional. I\u0027ll post a new patch with this option restored.","commit_id":"a41c8844635f02500e7c20f358ea24fb47de288a"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"07f709ff124c5db3b702689e73e77c5542ade8e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b10ab052_307a1fd9","side":"PARENT","line":4214,"range":{"start_line":4212,"start_character":0,"end_line":4214,"end_character":50},"in_reply_to":"42119dc2_64d9ddba","updated":"2024-03-01 01:55:04.000000000","message":"Done","commit_id":"a41c8844635f02500e7c20f358ea24fb47de288a"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"7324cfe4dd5d3840b5cb240dfff2ef41fb1d6731","unresolved":true,"context_lines":[{"line_number":1431,"context_line":"            - if:"},{"line_number":1432,"context_line":"                - calico_v3_21"},{"line_number":1433,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-21-x.sh"},{"line_number":1434,"context_line":"                - \"\""},{"line_number":1435,"context_line":"            - if:"},{"line_number":1436,"context_line":"                - calico_v3_26"},{"line_number":1437,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-26-x.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d0ff9b0e_22b6c75f","line":1434,"updated":"2024-02-28 22:14:53.000000000","message":"If we want to avoid breaking others with `calico_tag` specified, we could make this instead say:\n\n```\n- if:\n  - calico_v3_26\n  - get_file calico-service-v3-26-x.sh\n  - get_file calico-service-v3-21-x.sh\n```\n\nThen there is no change to the current state except when using calico_tag 3.26.*. I prefer the proposed only in that it makes the supported tags explicit, and it is clear how to add a third supported calico version (needs documentation update?)","commit_id":"2ed069349ba4910a5c54db09f62f6919ffc71ce6"},{"author":{"_account_id":35572,"name":"Pawel Kubica","email":"pawel.kubica@comarch.com","username":"pawcykca"},"change_message_id":"f3af075b00eef728bf328b8c035bab82363a2e32","unresolved":true,"context_lines":[{"line_number":1431,"context_line":"            - if:"},{"line_number":1432,"context_line":"                - calico_v3_21"},{"line_number":1433,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-21-x.sh"},{"line_number":1434,"context_line":"                - \"\""},{"line_number":1435,"context_line":"            - if:"},{"line_number":1436,"context_line":"                - calico_v3_26"},{"line_number":1437,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-26-x.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b321ce95_13c5b984","line":1434,"in_reply_to":"59d948a2_da9a382a","updated":"2024-03-01 08:21:36.000000000","message":"I recommend using the solution below\n```\n- if:\n  - calico_v3_26\n  - get_file calico-service-v3-26-x.sh\n  - get_file calico-service-v3-21-x.sh\n```\nThis avoids creating of a new cluster without Calico CNI - of course if defined Calico version (`calito_tag`) won\u0027t match K8S version (`kube_tag`) this cluster won\u0027t be working correctly.","commit_id":"2ed069349ba4910a5c54db09f62f6919ffc71ce6"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"daa84383aaf1032229b0b62618f8a90103937eb1","unresolved":true,"context_lines":[{"line_number":1431,"context_line":"            - if:"},{"line_number":1432,"context_line":"                - calico_v3_21"},{"line_number":1433,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-21-x.sh"},{"line_number":1434,"context_line":"                - \"\""},{"line_number":1435,"context_line":"            - if:"},{"line_number":1436,"context_line":"                - calico_v3_26"},{"line_number":1437,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-26-x.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"59d948a2_da9a382a","line":1434,"in_reply_to":"62da94c6_8f58da3d","updated":"2024-03-01 01:57:55.000000000","message":"Thanks for the review and comments, Pawel! Which do you prefer?\n\nIt\u0027s good to find another interested party for Calico, and I\u0027m fine with submitting either if anyone has a preference.","commit_id":"2ed069349ba4910a5c54db09f62f6919ffc71ce6"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"3685e52c4bdb2bb95cf396f87682be3f8eb1bab7","unresolved":false,"context_lines":[{"line_number":1431,"context_line":"            - if:"},{"line_number":1432,"context_line":"                - calico_v3_21"},{"line_number":1433,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-21-x.sh"},{"line_number":1434,"context_line":"                - \"\""},{"line_number":1435,"context_line":"            - if:"},{"line_number":1436,"context_line":"                - calico_v3_26"},{"line_number":1437,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-26-x.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"08f67c9e_cd425211","line":1434,"in_reply_to":"b321ce95_13c5b984","updated":"2024-03-03 20:52:56.000000000","message":"Done","commit_id":"2ed069349ba4910a5c54db09f62f6919ffc71ce6"},{"author":{"_account_id":35572,"name":"Pawel Kubica","email":"pawel.kubica@comarch.com","username":"pawcykca"},"change_message_id":"b8d50778a3f1b4450fd7551b798af5f6ad721709","unresolved":true,"context_lines":[{"line_number":1431,"context_line":"            - if:"},{"line_number":1432,"context_line":"                - calico_v3_21"},{"line_number":1433,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-21-x.sh"},{"line_number":1434,"context_line":"                - \"\""},{"line_number":1435,"context_line":"            - if:"},{"line_number":1436,"context_line":"                - calico_v3_26"},{"line_number":1437,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-26-x.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"62da94c6_8f58da3d","line":1434,"in_reply_to":"d0ff9b0e_22b6c75f","updated":"2024-02-29 08:01:34.000000000","message":"This is what we implemented on our side and works correctly.","commit_id":"2ed069349ba4910a5c54db09f62f6919ffc71ce6"}]}