)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"660c75f376da14bc912714868fb9aa5ef304215e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3236b38_cded5755","updated":"2024-04-29 13:55:06.000000000","message":"0","commit_id":"efe397493f0c03da952b2cecd4dcdc3188bfa378"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"452826bddf2830ec9638dbb64fd7cbaac404ec36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a675d09_87352a17","updated":"2024-04-29 20:52:59.000000000","message":"This change would be a bit more challenging if upgrading existing clusters in place was still present.\n\nNow it\u0027s gone, this change should just mean K8s prior to v1.20 will no longer work as expected (which is fine!)\n\nIt\u0027s worth noting that I **expect** existing clusters should still be able to resize and continue to get the `master` labels, as the Heat stack will have all these old scripts embedded. Only newly built clusters should be affected by this change. Jake, have you tested this scenario?","commit_id":"efe397493f0c03da952b2cecd4dcdc3188bfa378"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"869698e851bbd92ed81352062f0868e61e85781b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db99db3c_368bb3e2","in_reply_to":"6a675d09_87352a17","updated":"2024-04-30 01:50:13.000000000","message":"I haven\u0027t tested resizing of control-plane nodes. The code for that[1] hasn\u0027t merged yet :P\n\n[1] https://review.opendev.org/c/openstack/magnum/+/906086","commit_id":"efe397493f0c03da952b2cecd4dcdc3188bfa378"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"2c9d8ac506ed8508a9fecd85404b713399001837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42a52d8b_0dd7169f","in_reply_to":"db99db3c_368bb3e2","updated":"2024-04-30 02:24:40.000000000","message":"Oh - good point; I was thinking of workers. Doh. We don\u0027t (and won\u0027t) support resizing control plane nodes in the Heat driver.\n\n(I need to get back to that patchset; it\u0027s high on my list...)","commit_id":"efe397493f0c03da952b2cecd4dcdc3188bfa378"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9641fd15288be561e942b4c3fa5336c2ad8cf6e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"78b87bd2_1e1f3ffa","updated":"2024-05-01 21:11:32.000000000","message":"LGTM! Discussed in meeting.\n\nMinor typo if you want to fix: The release note says breaking change is \u003c\u003d1.20, but it should be \u003c\u003d1.19, or \u003e1.20, as it was first deprecated in 1.20?","commit_id":"29765c96935767b7897b3569029c55d8e6651ee6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fcb514a5567f0fa6664ec7fccded22ca8af33b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e35908cf_9afc96c2","updated":"2024-05-07 05:33:57.000000000","message":"only reno changed and accounting for previous +2","commit_id":"f9e13270eee987c076952e286a99a09c8e32f6af"}],"magnum/drivers/common/templates/kubernetes/fragments/calico-service-v3-26-x.sh":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"452826bddf2830ec9638dbb64fd7cbaac404ec36","unresolved":true,"context_lines":[{"line_number":4965,"context_line":"        # Mark the pod as a critical add-on for rescheduling."},{"line_number":4966,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":4967,"context_line":"          operator: Exists"},{"line_number":4968,"context_line":"        - key: node-role.kubernetes.io/control-plane"},{"line_number":4969,"context_line":"          effect: NoSchedule"},{"line_number":4970,"context_line":"        - key: node-role.kubernetes.io/control-plane"},{"line_number":4971,"context_line":"          effect: NoSchedule"}],"source_content_type":"text/x-sh","patch_set":1,"id":"418c630e_ab435275","line":4968,"updated":"2024-04-29 20:52:59.000000000","message":"Remove duplicate toleration","commit_id":"efe397493f0c03da952b2cecd4dcdc3188bfa378"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9641fd15288be561e942b4c3fa5336c2ad8cf6e8","unresolved":false,"context_lines":[{"line_number":4965,"context_line":"        # Mark the pod as a critical add-on for rescheduling."},{"line_number":4966,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":4967,"context_line":"          operator: Exists"},{"line_number":4968,"context_line":"        - key: node-role.kubernetes.io/control-plane"},{"line_number":4969,"context_line":"          effect: NoSchedule"},{"line_number":4970,"context_line":"        - key: node-role.kubernetes.io/control-plane"},{"line_number":4971,"context_line":"          effect: NoSchedule"}],"source_content_type":"text/x-sh","patch_set":1,"id":"c97acba1_237aa39f","line":4968,"in_reply_to":"418c630e_ab435275","updated":"2024-05-01 21:11:32.000000000","message":"Done","commit_id":"efe397493f0c03da952b2cecd4dcdc3188bfa378"}]}