)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ef1aae977fa6d0c7255cb50e2f6625fcf81ae33f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d16930a_30514184","updated":"2025-06-27 08:03:02.000000000","message":"You probably want a test for this also?","commit_id":"c4c08b3b39e075cf9cc2c0b8d95e9e11786af9a1"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"a8da6e846277451a970b49d606c97c43da6a3d02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56647afb_7b100b04","in_reply_to":"2d16930a_30514184","updated":"2025-07-03 01:59:09.000000000","message":"Indeed; done.","commit_id":"c4c08b3b39e075cf9cc2c0b8d95e9e11786af9a1"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"b37eda8c5c2fe050bba80964d9f15f2f7b2ae5c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf1c555c_402d7620","updated":"2025-07-10 07:48:41.000000000","message":"This is prob ok. However, I notice that the python client defaults this to a value [1], but openstacksdk doesn\u0027t.\n\nI think the original intention was this can be None and fallback to the heat template [2], but this comment doesn\u0027t make sense now.\n\nI think it\u0027s safe to accept None. If we accept this, this decision probably should trigger a bug to update python-magnumclient with the same assumption.\n\nI\u0027ll +1 for now and discuss about this in next meeting before +W\n\n[1] https://opendev.org/openstack/python-magnumclient/src/branch/stable/2025.1/magnumclient/v1/cluster_templates_shell.py#L117\n\n[2] https://opendev.org/openstack/magnum/src/branch/master/magnum/api/attr_validator.py#L50-L51","commit_id":"c440b198c41578cb929af52238f6c0785fd488af"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"99d3a1cce2b5b65c451b0646cebe1ffda52b5dcf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a581a746_7a3ccf98","in_reply_to":"354f493b_58e7a4be","updated":"2025-07-21 04:57:28.000000000","message":"I prefer removing that too.","commit_id":"c440b198c41578cb929af52238f6c0785fd488af"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"192153aaf0d1191f3337683d15dcd0472fbccffd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"354f493b_58e7a4be","in_reply_to":"cf1c555c_402d7620","updated":"2025-07-10 22:33:13.000000000","message":"Hmm, `m1.medium` is not a great default as it won\u0027t exist in all clouds. I\u0027d prefer removing that to avoid confusion as to where this mystery hardcoded value came from.\n\nCreating a Cluster Template with no value here seems reasonable as long as during the creation of the Cluster the final NodeGroup flavor is validated (ideally, during api post, rather than async).","commit_id":"c440b198c41578cb929af52238f6c0785fd488af"}]}