)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"a1c64dd3aab4c7d61011b8f96f8d97ca39bd2e16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5df0c1cc_69d27d24","updated":"2025-10-28 08:09:08.000000000","message":"Your style is clear, which is nice. I\u0027ve noticed that there are many different styles used in different tests. As discussed, we could also change it to follow one of the other styles in use [1], and gradually move to one style so it is easier for future devs.\n\n[1] https://opendev.org/openstack/magnum/src/branch/master/magnum/tests/unit/api/controllers/v1/test_nodegroup.py#L471","commit_id":"9c889a5d3a809f00ea9c4090b415124a9f9f2df7"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"c6e70643510f5f86ec74d7620a43f65d617f1cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c659069d_f95ec7db","in_reply_to":"5df0c1cc_69d27d24","updated":"2025-10-28 22:57:29.000000000","message":"Thanks for the feedback and discussion, Jake. I\u0027ve updated this patchset with a more succinct version.\n\nI opted not to use tuple unpacking here, as the existing tests don\u0027t need the other 3 positional args:\n```\n(cluster, master_count, node_count, create_timeout), _ \u003d self.mock_cluster_create.call_args\n```\nor\n```\n(cluster, _, _, _), _ \u003d self.mock_cluster_create.call_args\n```\n\n\nI\u0027d suggest in the linked `test_nodegroup.py` we could remove a little complexity for the reader by using:\n```\ncluster, ng \u003d self.mock_ng_create.call_args.args\n```\ninstead of the existing, which requires slightly more consideration about the syntax:\n```\n(cluster, ng), _ \u003d self.mock_ng_create.call_args\n```\n\n\nLet me know if you agree. Bringing the tests and usages closer together is a worthwhile goal.","commit_id":"9c889a5d3a809f00ea9c4090b415124a9f9f2df7"}],"magnum/tests/unit/api/controllers/v1/test_cluster.py":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"74b7ca2e3666042d8563f5dcd4eceb5e33d20b38","unresolved":true,"context_lines":[{"line_number":959,"context_line":"        response \u003d self.post_json(\u0027/clusters\u0027, bdict)"},{"line_number":960,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":961,"context_line":"        self.assertEqual(202, response.status_int)"},{"line_number":962,"context_line":"        args, kwargs \u003d self.mock_cluster_create.call_args"},{"line_number":963,"context_line":"        cluster \u003d args[0]"},{"line_number":964,"context_line":"        self.assertEqual(\u0027keypair2\u0027, cluster.keypair)"},{"line_number":965,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3518d9bd_c7665a0a","line":962,"updated":"2025-10-28 07:58:36.000000000","message":"Jakes notes consider doing it with tuples; https://opendev.org/openstack/magnum/src/branch/master/magnum/tests/unit/api/controllers/v1/test_nodegroup.py#L471","commit_id":"9c889a5d3a809f00ea9c4090b415124a9f9f2df7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"05a831ea9390eecd4bb570a444de3095b6ac05a9","unresolved":false,"context_lines":[{"line_number":959,"context_line":"        response \u003d self.post_json(\u0027/clusters\u0027, bdict)"},{"line_number":960,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":961,"context_line":"        self.assertEqual(202, response.status_int)"},{"line_number":962,"context_line":"        args, kwargs \u003d self.mock_cluster_create.call_args"},{"line_number":963,"context_line":"        cluster \u003d args[0]"},{"line_number":964,"context_line":"        self.assertEqual(\u0027keypair2\u0027, cluster.keypair)"},{"line_number":965,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1114e8d3_2354fb07","line":962,"in_reply_to":"3518d9bd_c7665a0a","updated":"2026-03-02 14:06:50.000000000","message":"Done","commit_id":"9c889a5d3a809f00ea9c4090b415124a9f9f2df7"}]}