)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ae35d18405a6af5ef1661e97f0dbbf1954194ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0cdc22ab_bba11342","updated":"2025-09-01 15:19:58.000000000","message":"I didn\u0027t think we are allowed to change existing migrations, because it makes old and new deployments inconsistent.\n\nWould it be better to modify any tables that are missing the UTF-8 declaration, to make things more consistent across all deployments?","commit_id":"19774bd3464acdd2b1ce2a4f4ecb82d56288b797"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"680b2c10a40be66e398e2df2e6beb0477dede902","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb278baf_b43e4c0c","updated":"2025-09-01 15:03:56.000000000","message":"yup, this works for me as well.\n\nJust to have that said, I\u0027ve looked through cinder/nova default migration, and they do have charset defined, but they just do it consistently indeed.","commit_id":"19774bd3464acdd2b1ce2a4f4ecb82d56288b797"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"6fea705ba8e730970d19d2494df50df6d5a0fe7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b9628f9_86afce22","in_reply_to":"0cdc22ab_bba11342","updated":"2025-09-01 15:25:14.000000000","message":"On a second thought, I think you\u0027re right. Perhaps this can cause problem with existing deployments? I\u0027ll instead add charset definitions to all other tables that are missing this.","commit_id":"19774bd3464acdd2b1ce2a4f4ecb82d56288b797"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"5a2fdb1ea5412348204674888b65443ee02507ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a6fe4d3_cdb3c11a","in_reply_to":"bb278baf_b43e4c0c","updated":"2025-09-01 15:09:41.000000000","message":"You\u0027re right. It\u0027s either we define charset everytime we create a table or we never do it.","commit_id":"19774bd3464acdd2b1ce2a4f4ecb82d56288b797"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4470fc054e2ae07a77e7a5ee716a5da94c70bcae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f6fc1158_e07545a2","updated":"2025-09-02 07:26:20.000000000","message":"Another question to this would possibility of upgrades and backports...\n\nI think upgrades should be fine, as old migrations will not be re-attempted just by how alembic works.\n\nBut regarding backports - I can imagine things going not as expected on some older release if mariadb\u003e\u003d11.5 will be attempted.","commit_id":"9c089551a3535f7b05a0a1f5d9497e699dfce3ca"},{"author":{"_account_id":37313,"name":"Alma MAILLET-CONTOZ","display_name":"Alma MAILLET-CONTOZ","email":"alma.maillet-contoz@infomaniak.com","username":"nicolasmc","status":"Intern SRE at Infomaniak"},"change_message_id":"08fbfc475f3f609113d749bb6bfcc5982dfc2691","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"122455f8_876b1aea","updated":"2026-05-10 20:56:50.000000000","message":"I had the problem and found this patch while debugging. LGTM!","commit_id":"9c089551a3535f7b05a0a1f5d9497e699dfce3ca"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"557e284775437e34c4ff074b7eb548602a358c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b45dcf7_beadf3c6","updated":"2026-06-19 02:00:49.000000000","message":"I think this may have broader implications because of the mariadb \u003e\u003d 11.5 change. I looked into previously and summarised some findings at https://bugs.launchpad.net/magnum/+bug/2121797/comments/6\n\nI think TC was looking into this also because it affects multiple projects, so I wasn\u0027t keen to push a change that may be opposite of TC\u0027s decision.\n\nMy inclination is to NOT specify charset at all, falling back to deployment default. The major deployment tools are (luckily) consistent with each other. In the future, we can also tackle any charset / collation migrations together if needed.\n\nI will bring this topic up again in Magnum Meeting.","commit_id":"9c089551a3535f7b05a0a1f5d9497e699dfce3ca"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4cf8e9f50c2517212e91f9f60b32ba49b49a14a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5951495_31b850e8","updated":"2026-06-18 06:53:33.000000000","message":"Wouldn\u0027t that fix only the deployments that didn\u0027t run those alembic migrations in the past?","commit_id":"9c089551a3535f7b05a0a1f5d9497e699dfce3ca"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2a824cd63567ee36cb72bc6b690fd3df70994024","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b414caa8_067bde83","in_reply_to":"d5951495_31b850e8","updated":"2026-06-18 07:01:12.000000000","message":"If yes - these migrations are Liberty, Queens and Train material...","commit_id":"9c089551a3535f7b05a0a1f5d9497e699dfce3ca"}],"magnum/db/sqlalchemy/alembic/versions/27ad304554e2_adding_magnum_service_functionality.py":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"45a271ded49880b354adcb27a6e3d94b2b3d369f","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":51,"context_line":"        sa.UniqueConstraint(\u0027host\u0027, \u0027binary\u0027,"},{"line_number":52,"context_line":"                            name\u003d\u0027uniq_magnum_service0host0binary\u0027),"},{"line_number":53,"context_line":"        mysql_DEFAULT_CHARSET\u003d\u0027UTF8\u0027"},{"line_number":54,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b4a5845_95c2926f","line":53,"updated":"2025-09-02 07:22:41.000000000","message":"Maybe we should also add `mysql_ENGINE\u003d\u0027InnoDB\u0027` for consistency as well?","commit_id":"9c089551a3535f7b05a0a1f5d9497e699dfce3ca"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"f35b0dcb93d76ee5888fc14fdef04be259c939b9","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":51,"context_line":"        sa.UniqueConstraint(\u0027host\u0027, \u0027binary\u0027,"},{"line_number":52,"context_line":"                            name\u003d\u0027uniq_magnum_service0host0binary\u0027),"},{"line_number":53,"context_line":"        mysql_DEFAULT_CHARSET\u003d\u0027UTF8\u0027"},{"line_number":54,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7acb2a79_a905163d","line":53,"in_reply_to":"6b4a5845_95c2926f","updated":"2025-09-02 09:00:16.000000000","message":"I was thinking the same but this doesn\u0027t seem directly related to this bug. Maybe in a follow up patch?","commit_id":"9c089551a3535f7b05a0a1f5d9497e699dfce3ca"}]}