)]}'
{"id":"openstack%2Fmagnum~998921","triplet_id":"openstack%2Fmagnum~master~Ie24190c671a6028c0a69f4d1ffe0670bf4974086","project":"openstack/magnum","branch":"master","hashtags":[],"change_id":"Ie24190c671a6028c0a69f4d1ffe0670bf4974086","subject":"Add unit tests for DB migration dispatch and periodic tasks","status":"NEW","created":"2026-07-28 12:01:43.000000000","updated":"2026-07-28 12:56:59.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6b902c8c488d0e3b75ad4f88de568a7e8016f9cb","_number":998921,"virtual_id_number":998921,"owner":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-07-28 12:56:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-28 12:56:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"975606e5a8f7b294b00cebc370308f73860518d0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2026-07-28 12:01:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6b902c8c488d0e3b75ad4f88de568a7e8016f9cb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-28 12:56:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2065b6c1453a4c9d83cdf60831f64b6e\n\n- magnum-capi-helm-tests-cluster-calico-v1-34 https://zuul.opendev.org/t/openstack/build/f656f33ac7dd4188940d0afb1de2800b : SUCCESS in 46m 22s\n- magnum-capi-helm-tests-cluster-cilium-v1-34 https://zuul.opendev.org/t/openstack/build/950b1a02b50e44d59fd208e958d4315e : SUCCESS in 51m 58s\n- magnum-capi-helm-tests-cluster-calico-v1-35 https://zuul.opendev.org/t/openstack/build/1ca349953498475190de39859f1648a6 : SUCCESS in 48m 03s\n- magnum-capi-helm-tests-cluster-cilium-v1-35 https://zuul.opendev.org/t/openstack/build/b6f1927e42a94f2eb1a67209f18dec73 : SUCCESS in 49m 19s\n- magnum-cluster-api-v1.35-calico https://zuul.opendev.org/t/openstack/build/df2cbfad79574ec7b2a10b183aad25cc : SUCCESS in 37m 49s\n- magnum-cluster-api-v1.35-cilium https://zuul.opendev.org/t/openstack/build/165c314422a14dbb8bfb72e287c2c976 : SUCCESS in 36m 42s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2f0ae5e8150a4e74a29cbec797c948f9 : SUCCESS in 7m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/813c957190f54ce28266146d9f342829 : SUCCESS in 4m 15s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/297ec8f408bc42a280bf989b7c9dce84 : SUCCESS in 5m 59s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/783f9114fc9042a99b1553ff67d60328 : SUCCESS in 6m 11s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/a5068a2cfc054d9cb6a24e2c975559be : SUCCESS in 6m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b53456cd368b4a89b69f6c7219fd8b05 : SUCCESS in 7m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/513174d98d464811bba06a0d30cd688f : SUCCESS in 4m 14s\n- magnum-tempest-plugin-tests-api https://zuul.opendev.org/t/openstack/build/a2ca5d43b4a943c1b0c5125da89bc9fe : SUCCESS in 22m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7894676bb1bd2fee35d941ea4513eaabc96271b3","revisions":{"7894676bb1bd2fee35d941ea4513eaabc96271b3":{"kind":"REWORK","_number":1,"created":"2026-07-28 12:01:43.000000000","uploader":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"ref":"refs/changes/21/998921/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/magnum","ref":"refs/changes/21/998921/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/magnum refs/changes/21/998921/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/magnum refs/changes/21/998921/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/magnum refs/changes/21/998921/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/magnum refs/changes/21/998921/1"}}},"commit":{"parents":[{"commit":"31b03d99feb3ee1e9edb6f69c508bc8c8aaca86d","subject":"Add unit tests for conductor helpers and the driver base class","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/magnum/commit/31b03d99feb3ee1e9edb6f69c508bc8c8aaca86d"}]}],"author":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2026-07-28 11:55:39.000000000","tz":120},"committer":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2026-07-28 11:55:39.000000000","tz":120},"subject":"Add unit tests for DB migration dispatch and periodic tasks","message":"Add unit tests for DB migration dispatch and periodic tasks\n\nCover the DB migration entry points and the periodic cluster/health\nsync jobs:\n\n- db/migration.py (50% -\u003e 100%) and db/sqlalchemy/migration.py\n  (86% -\u003e 100%): get_backend() caching, upgrade()/version()/stamp()/\n  revision() dispatch (including the default-version-to-\u0027head\u0027\n  substitution), all via mocked stevedore/alembic/enginefacade so no\n  real DB or alembic operations run.\n- service/periodic.py (87% -\u003e 100%): sync_cluster_status() and\n  sync_cluster_health_status()\u0027s empty-cluster-list and exception-\n  swallowing paths (asserting the correct status filters are queried\n  and no per-cluster job is started), and ClusterHealthUpdateJob\u0027s\n  no-monitor, poll-failure, no-health-data, and successful-update\n  branches.\n\nAssisted-By: Claude Sonnet 5 \u003cnoreply@anthropic.com\u003e\nChange-Id: Ie24190c671a6028c0a69f4d1ffe0670bf4974086\nSigned-off-by: Michal Nasiadka \u003cmnasiadka@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/magnum/commit/7894676bb1bd2fee35d941ea4513eaabc96271b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/magnum/commit/7894676bb1bd2fee35d941ea4513eaabc96271b3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}