)]}'
{".gitignore":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cb9b36d156d0d9ab1ddf7c6a79af7ba85c86b1aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.py[co]"},{"line_number":2,"context_line":"*.egg"},{"line_number":3,"context_line":"*.egg-info"},{"line_number":4,"context_line":"*.swp"},{"line_number":5,"context_line":"dist"},{"line_number":6,"context_line":"build"},{"line_number":7,"context_line":"eggs"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"5a5ae5dd_8b1d96bf","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":5},"updated":"2016-02-03 12:47:08.000000000","message":"Should be removed, it already exists on line 17","commit_id":"673929328177fc1717e75f3714b90af8d219924f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d5c5f67538af2f6da98b10d00b20ff73a31e8585","unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.py[co]"},{"line_number":2,"context_line":"*.egg"},{"line_number":3,"context_line":"*.egg-info"},{"line_number":4,"context_line":"*.swp"},{"line_number":5,"context_line":"dist"},{"line_number":6,"context_line":"build"},{"line_number":7,"context_line":"eggs"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"5a5ae5dd_495c8525","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":5},"in_reply_to":"5a5ae5dd_8b1d96bf","updated":"2016-02-03 13:32:57.000000000","message":"Done","commit_id":"673929328177fc1717e75f3714b90af8d219924f"}],"bin/manila-image-create":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"aa3f4edf6f924209dd5fc246bd5a895cb25ada22","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    # Compress rootfs"},{"line_number":244,"context_line":"    echo \"Compressing rootfs package...\""},{"line_number":245,"context_line":"    xz $_PREFIX/$MANILA_IMG_NAME.tar"},{"line_number":246,"context_line":"    echo \"Done.\""},{"line_number":247,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"da6ed579_0ea1ab94","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":36},"updated":"2016-01-12 13:25:11.000000000","message":"Better to use \"-f\" flag that will delete existing file after previous run.\n\n\"\"\"\nxz -f $_PREFIX/$MANILA_IMG_NAME.tar\n\"\"\"","commit_id":"aa2b70ff216b693bd970761b35698a13661ecaa1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"368d59b398879ecee5cded1440e3b3e0b1ce6465","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    # Compress rootfs"},{"line_number":244,"context_line":"    echo \"Compressing rootfs package...\""},{"line_number":245,"context_line":"    xz $_PREFIX/$MANILA_IMG_NAME.tar"},{"line_number":246,"context_line":"    echo \"Done.\""},{"line_number":247,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a68dd71_f7755e63","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":36},"in_reply_to":"da6ed579_0ea1ab94","updated":"2016-01-25 10:34:43.000000000","message":"Done","commit_id":"aa2b70ff216b693bd970761b35698a13661ecaa1"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d4134083fc73e8ed2e030fea502dfda55f965c0a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"if [ \"$MANILA_IMG_OS\" \u003d \"manila-ubuntu-core\" ] \u0026\u0026 [ \"$MANILA_IMG_OS_VER\" !\u003d \"trusty\" ]; then"},{"line_number":98,"context_line":"    echo -e \"manila-ubuntu-core doesn\u0027t support \u0027$MANILA_IMG_OS_VER\u0027 release.\""},{"line_number":99,"context_line":"    echo -e \"Change MANILA_IMG_OS to \u0027ubuntu\u0027 if you need another release.\""},{"line_number":100,"context_line":"fi"},{"line_number":101,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"9a68dd71_509e9463","line":98,"updated":"2016-01-25 21:09:23.000000000","message":"I don\u0027t see any reason to add -e here.","commit_id":"c622d0c3366a0bdefdeaf2866bbbdc273de86381"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"b8a29171df4bce43f68e817518be1bd26dc3d9c0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"if [ \"$MANILA_IMG_OS\" \u003d \"manila-ubuntu-core\" ] \u0026\u0026 [ \"$MANILA_IMG_OS_VER\" !\u003d \"trusty\" ]; then"},{"line_number":98,"context_line":"    echo -e \"manila-ubuntu-core doesn\u0027t support \u0027$MANILA_IMG_OS_VER\u0027 release.\""},{"line_number":99,"context_line":"    echo -e \"Change MANILA_IMG_OS to \u0027ubuntu\u0027 if you need another release.\""},{"line_number":100,"context_line":"fi"},{"line_number":101,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"9a68dd71_d6802a4c","line":98,"in_reply_to":"9a68dd71_509e9463","updated":"2016-01-26 08:56:03.000000000","message":"Done","commit_id":"c622d0c3366a0bdefdeaf2866bbbdc273de86381"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d4134083fc73e8ed2e030fea502dfda55f965c0a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    if [ -n \"$DIB_UPDATE_REQUESTED\" ]; then"},{"line_number":168,"context_line":"        case \"$platform\" in"},{"line_number":169,"context_line":"            \"ubuntu\")"},{"line_number":170,"context_line":"                sudo apt-get update"},{"line_number":171,"context_line":"                sudo apt-get install $package_list -y"},{"line_number":172,"context_line":"                ;;"},{"line_number":173,"context_line":"            \"opensuse\")"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"9a68dd71_1007bc82","line":170,"range":{"start_line":170,"start_character":29,"end_line":170,"end_character":35},"updated":"2016-01-25 21:09:23.000000000","message":"Note: this change is also in\nhttps://review.openstack.org/#/c/271309/","commit_id":"c622d0c3366a0bdefdeaf2866bbbdc273de86381"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"b8a29171df4bce43f68e817518be1bd26dc3d9c0","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    if [ -n \"$DIB_UPDATE_REQUESTED\" ]; then"},{"line_number":168,"context_line":"        case \"$platform\" in"},{"line_number":169,"context_line":"            \"ubuntu\")"},{"line_number":170,"context_line":"                sudo apt-get update"},{"line_number":171,"context_line":"                sudo apt-get install $package_list -y"},{"line_number":172,"context_line":"                ;;"},{"line_number":173,"context_line":"            \"opensuse\")"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"9a68dd71_fb63d73f","line":170,"range":{"start_line":170,"start_character":29,"end_line":170,"end_character":35},"in_reply_to":"9a68dd71_1007bc82","updated":"2016-01-26 08:56:03.000000000","message":"Yes, apparently I have ran into https://bugs.launchpad.net/manila-image-elements/+bug/1537011 at some point and inadvertently fixed it here. Since it is fixed now I\u0027ll remove this change in the next patch set.","commit_id":"c622d0c3366a0bdefdeaf2866bbbdc273de86381"}],"data/lxd/meta/templates/hosts.tpl":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f76c2f6f7d80ef69c82819a901cdd1a831a386f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"127.0.0.1   localhost"},{"line_number":2,"context_line":"127.0.1.1   {{ container.name }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# The following lines are desirable for IPv6 capable hosts"}],"source_content_type":"text/x-smarty","patch_set":22,"id":"5a5ae5dd_cbff0e33","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":21},"updated":"2016-02-03 12:56:07.000000000","message":"Need to add also \"localhost.localdomain\", it is very likely to be picked up by default for VM.","commit_id":"673929328177fc1717e75f3714b90af8d219924f"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d5c5f67538af2f6da98b10d00b20ff73a31e8585","unresolved":false,"context_lines":[{"line_number":1,"context_line":"127.0.0.1   localhost"},{"line_number":2,"context_line":"127.0.1.1   {{ container.name }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# The following lines are desirable for IPv6 capable hosts"}],"source_content_type":"text/x-smarty","patch_set":22,"id":"5a5ae5dd_89791d96","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":21},"in_reply_to":"5a5ae5dd_cbff0e33","updated":"2016-02-03 13:32:57.000000000","message":"Done","commit_id":"673929328177fc1717e75f3714b90af8d219924f"}],"elements/manila-ganesha-nfs/install.d/nfs-ganesha":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"6971a3e094d82e0b7ca61d880f24350fddb505ee","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PATHPROG\u003d/usr/bin/ganesha.nfsd"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Default HPSS options"},{"line_number":12,"context_line":"LOGFILE\u003d/var/log/ganesha.log"},{"line_number":13,"context_line":"CONFFILE\u003d/etc/ganesha/ganesha.conf"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"9a68dd71_b00a7024","line":11,"updated":"2016-01-25 21:13:01.000000000","message":"What is HPSS? Copy/paste error?","commit_id":"c622d0c3366a0bdefdeaf2866bbbdc273de86381"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"b8a29171df4bce43f68e817518be1bd26dc3d9c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PATHPROG\u003d/usr/bin/ganesha.nfsd"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Default HPSS options"},{"line_number":12,"context_line":"LOGFILE\u003d/var/log/ganesha.log"},{"line_number":13,"context_line":"CONFFILE\u003d/etc/ganesha/ganesha.conf"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"9a68dd71_9ba97b93","line":11,"in_reply_to":"9a68dd71_b00a7024","updated":"2016-01-26 08:56:03.000000000","message":"Apparently yes. Will remove in the next patch set.","commit_id":"c622d0c3366a0bdefdeaf2866bbbdc273de86381"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"6971a3e094d82e0b7ca61d880f24350fddb505ee","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[ -f /etc/sysconfig/ganesha ] \u0026\u0026 . /etc/sysconfig/ganesha"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[ -z \"$NOFILE\" ] \u0026\u0026 NOFILE\u003d1048576"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"OPTIONS\u003d\"-L $LOGFILE -f $CONFFILE -N NIV_EVENT\""},{"line_number":24,"context_line":"RETVAL\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"9a68dd71_33a1aaf8","line":21,"updated":"2016-01-25 21:13:01.000000000","message":"NOFILE seems to be unused...","commit_id":"c622d0c3366a0bdefdeaf2866bbbdc273de86381"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"b8a29171df4bce43f68e817518be1bd26dc3d9c0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[ -f /etc/sysconfig/ganesha ] \u0026\u0026 . /etc/sysconfig/ganesha"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[ -z \"$NOFILE\" ] \u0026\u0026 NOFILE\u003d1048576"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"OPTIONS\u003d\"-L $LOGFILE -f $CONFFILE -N NIV_EVENT\""},{"line_number":24,"context_line":"RETVAL\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"9a68dd71_96a39200","line":21,"in_reply_to":"9a68dd71_33a1aaf8","updated":"2016-01-26 08:56:03.000000000","message":"Yes, it looks like a leftover from some other script.","commit_id":"c622d0c3366a0bdefdeaf2866bbbdc273de86381"}],"tools/gate/build-images":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9073d670fa5286d1a199a6de57337797ce417daa","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    tox -v -e buildimage"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ \"$IMAGE\" \u003d \"lxd\" ]; then"},{"line_number":10,"context_line":"    tox -v -e buildimage-lxd"},{"line_number":11,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5a5ae5dd_49a48556","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":2},"updated":"2016-02-03 13:41:12.000000000","message":"It will work but better to make it \"elif\"","commit_id":"d186f28f48518223472ba2e8026bc70572ddfea1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"d25ff8e679a1ac0ff1764fabe5c8baee7c6212f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    tox -v -e buildimage"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ \"$IMAGE\" \u003d \"lxd\" ]; then"},{"line_number":10,"context_line":"    tox -v -e buildimage-lxd"},{"line_number":11,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5a5ae5dd_6cd06f54","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":2},"in_reply_to":"5a5ae5dd_49a48556","updated":"2016-02-03 13:47:51.000000000","message":"Good point!","commit_id":"d186f28f48518223472ba2e8026bc70572ddfea1"}],"tools/run_bashate.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c346f43bb1098f5f753c79c6efd975e6a703bc27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -xe"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# NOTE(aovchinnikov): E040 has to be added to exceptions since it gets"},{"line_number":4,"context_line":"# triggered by certain configs."},{"line_number":5,"context_line":"find ./ -not -wholename \\*.tox/\\* -and \\( -name \\*.sh -or -wholename \\*.d/\\* -and -not -name \\*.md -and -not -name \\*.rst -and -not -name \\*.py \\) -print0 | xargs -0 bashate -v --ignore\u003dE040"}],"source_content_type":"text/x-sh","patch_set":27,"id":"7af24918_6197b790","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":31},"updated":"2016-03-02 13:28:03.000000000","message":"It should be separate gate fix with bug report.","commit_id":"dae5e9fa0bb53f8d299150f5e57b358cc4aebe33"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"bfd4fcc6cd7c069f2b5e7d3f550f60f973c34df9","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# NOTE(aovchinnikov): E040 has to be added to exceptions since it gets"},{"line_number":4,"context_line":"# triggered by certain configs."},{"line_number":5,"context_line":"find ./ -not -wholename \\*.tox/\\* -and \\( -name \\*.sh -or -wholename \\*.d/\\* -and -not -name \\*.md -and -not -name \\*.rst -and -not -name \\*.py \\) -print0 | xargs -0 bashate -v --ignore\u003dE040"}],"source_content_type":"text/x-sh","patch_set":27,"id":"7af24918_d1d636f0","line":5,"updated":"2016-03-02 21:58:47.000000000","message":"Ignoring E040 just masks the underlying problem, which is that bashate shouldn\u0027t be looking at config files at all...","commit_id":"dae5e9fa0bb53f8d299150f5e57b358cc4aebe33"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"95ff9f974623d34881e1b7df8b49aaced4fe6dbe","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# NOTE(aovchinnikov): E040 has to be added to exceptions since it gets"},{"line_number":4,"context_line":"# triggered by certain configs."},{"line_number":5,"context_line":"find ./ -not -wholename \\*.tox/\\* -and \\( -name \\*.sh -or -wholename \\*.d/\\* -and -not -name \\*.md -and -not -name \\*.rst -and -not -name \\*.py \\) -print0 | xargs -0 bashate -v --ignore\u003dE040"}],"source_content_type":"text/x-sh","patch_set":27,"id":"7af24918_4519ae21","line":5,"in_reply_to":"7af24918_d1d636f0","updated":"2016-03-03 05:31:02.000000000","message":"Also, I\u0027ve already fixed the error with another change so this is no longer necessary","commit_id":"dae5e9fa0bb53f8d299150f5e57b358cc4aebe33"}]}