)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"10dc55186ac6535fac349f4e0d2c444b97f4ab75","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This change slightly affects the current behavior of the script."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If an image is created using tox -e buildimage (as stated by current"},{"line_number":14,"context_line":"docs) an Ubuntu Trusty Minimal image with NFS will be created."},{"line_number":15,"context_line":"If a container image is created specifying the tox -e buildimage-lxd,"},{"line_number":16,"context_line":"a containers compatible image with NFS-Ganesha+UNFS3 will be created."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a74a57a_65a80978","line":14,"range":{"start_line":14,"start_character":42,"end_line":14,"end_character":45},"updated":"2016-11-28 18:11:26.000000000","message":"kernel NFS server?","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"5b7d3e326fcda1ec3d05a05c41aa1ae28f1d3ce5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If an image is created using tox -e buildimage (as stated by current"},{"line_number":14,"context_line":"docs) an Ubuntu Trusty Minimal image with NFS will be created."},{"line_number":15,"context_line":"If a container image is created specifying the tox -e buildimage-lxd,"},{"line_number":16,"context_line":"a containers compatible image with NFS-Ganesha+UNFS3 will be created."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Now, calling manila-image-create with params, will generate an image with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a74a57a_6511d203","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":68},"updated":"2016-11-29 07:16:00.000000000","message":"Have you guys decided to give LXC/LXD another try?","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"243ff03aae7373d4f3e8929420b841dd9abfa351","unresolved":false,"context_lines":[{"line_number":13,"context_line":"If an image is created using tox -e buildimage (as stated by current"},{"line_number":14,"context_line":"docs) an Ubuntu Trusty Minimal image with NFS will be created."},{"line_number":15,"context_line":"If a container image is created specifying the tox -e buildimage-lxd,"},{"line_number":16,"context_line":"a containers compatible image with NFS-Ganesha+UNFS3 will be created."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Now, calling manila-image-create with params, will generate an image with"},{"line_number":19,"context_line":"the filesystem protocol desired."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a74a57a_af98406b","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":52},"updated":"2016-11-28 17:36:50.000000000","message":"I thought one userspace Ganesha server is good enough. NFS-Ganesha supports NFSv3 and v4, right? Why do we need UNFS3?","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"243ff03aae7373d4f3e8929420b841dd9abfa351","unresolved":false,"context_lines":[{"line_number":13,"context_line":"If an image is created using tox -e buildimage (as stated by current"},{"line_number":14,"context_line":"docs) an Ubuntu Trusty Minimal image with NFS will be created."},{"line_number":15,"context_line":"If a container image is created specifying the tox -e buildimage-lxd,"},{"line_number":16,"context_line":"a containers compatible image with NFS-Ganesha+UNFS3 will be created."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Now, calling manila-image-create with params, will generate an image with"},{"line_number":19,"context_line":"the filesystem protocol desired."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a74a57a_4f724c12","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":12},"updated":"2016-11-28 17:36:50.000000000","message":"container","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"}],"README.rst":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b40708575086875117055ea3393b16551c63dd9d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Before building the image, make sure all system dependencies"},{"line_number":17,"context_line":"listed in other-requirements.txt file, are installed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Default generic"},{"line_number":20,"context_line":"---------------"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Script for creating Ubuntu based image with our elements and default parameters."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a74a57a_4f7c0cb5","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":15},"updated":"2016-11-28 17:40:37.000000000","message":"Can we give explicit details somewhere in the doc about \"generic\" image. It\u0027s a QCOW2 VM image built for generic driver?","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"09b7c4dfd7730949ad58f9e7d1a1eb83faa1d8b6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Before building the image, make sure all system dependencies"},{"line_number":17,"context_line":"listed in other-requirements.txt file, are installed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Default generic"},{"line_number":20,"context_line":"---------------"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Script for creating Ubuntu based image with our elements and default parameters."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_4437a54c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":15},"in_reply_to":"5a74a57a_4f7c0cb5","updated":"2016-12-12 14:30:26.000000000","message":"Good point. I\u0027ll add more specs. The term \"generic\" here was used to differentiate from containers.","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"10dc55186ac6535fac349f4e0d2c444b97f4ab75","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    tox -e buildimage"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"On completion, an Ubuntu minimal image with NFS will be available for use."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Default LXD"},{"line_number":33,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a74a57a_a5e301d8","line":30,"range":{"start_line":30,"start_character":44,"end_line":30,"end_character":47},"updated":"2016-11-28 18:11:26.000000000","message":"kernel NFS server?","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"09b7c4dfd7730949ad58f9e7d1a1eb83faa1d8b6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    tox -e buildimage"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"On completion, an Ubuntu minimal image with NFS will be available for use."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Default LXD"},{"line_number":33,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_a41dd9bf","line":30,"range":{"start_line":30,"start_character":44,"end_line":30,"end_character":47},"in_reply_to":"5a74a57a_a5e301d8","updated":"2016-12-12 14:30:26.000000000","message":"Default builds a QCOW2 VM image with Ubuntu trusty and kernel NFS server. I\u0027ll add it.","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"fa5ece32ade3dc457fa73f620bcba8bc6df0e393","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"On completion, an Ubuntu minimal image with NFS will be available for use."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Default LXD"},{"line_number":42,"context_line":"-----------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Script for creating an Ubuntu based image containers-compatible with our elements"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5201f7_11aba68a","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":11},"updated":"2017-01-10 13:52:18.000000000","message":"LXD?  should this be \u0027buildimage\u0027?","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7d18f8a5938c03169880aba8b3ddea1614b46553","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"On completion, an Ubuntu minimal image with NFS will be available for use."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Default LXD"},{"line_number":42,"context_line":"-----------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Script for creating an Ubuntu based image containers-compatible with our elements"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5201f7_b4be3662","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":7},"updated":"2017-01-10 22:25:21.000000000","message":"nit: Seems like there should be only one \"default\".  Maybe this is just LXD?","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ff75917610c9f08b40237aeb79210655c2a68808","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"On completion, an Ubuntu minimal image with NFS will be available for use."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Default LXD"},{"line_number":42,"context_line":"-----------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Script for creating an Ubuntu based image containers-compatible with our elements"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5201f7_43660852","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":7},"in_reply_to":"ba5201f7_b4be3662","updated":"2017-01-11 14:47:18.000000000","message":"This section has to be removed.","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"fa5ece32ade3dc457fa73f620bcba8bc6df0e393","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. sourcecode:: bash"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    tox -e buildimage-lxd"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"When finished, an Ubuntu minimal image containers-compatible with NFS-Ganesha and UNFS3"},{"line_number":54,"context_line":"will be available for use."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5201f7_f18aa219","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":25},"updated":"2017-01-10 13:52:18.000000000","message":"just \u0027tox -e buildimage\u0027?\n\nWe\u0027re cleaning out the lxc-lxd stuff, right?","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ff75917610c9f08b40237aeb79210655c2a68808","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. sourcecode:: bash"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    tox -e buildimage-lxd"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"When finished, an Ubuntu minimal image containers-compatible with NFS-Ganesha and UNFS3"},{"line_number":54,"context_line":"will be available for use."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5201f7_63578c5a","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":25},"in_reply_to":"ba5201f7_74a5ae45","updated":"2017-01-11 14:47:18.000000000","message":"Ditto.","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7d18f8a5938c03169880aba8b3ddea1614b46553","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. sourcecode:: bash"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    tox -e buildimage-lxd"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"When finished, an Ubuntu minimal image containers-compatible with NFS-Ganesha and UNFS3"},{"line_number":54,"context_line":"will be available for use."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5201f7_74a5ae45","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":25},"in_reply_to":"ba5201f7_f18aa219","updated":"2017-01-10 22:25:21.000000000","message":"is this section just going away?","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7d18f8a5938c03169880aba8b3ddea1614b46553","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Will generate an Ubuntu based image with NFS."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"In future changes, support for other distros and share-protocols will be added."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5201f7_d43adae6","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":79},"updated":"2017-01-10 22:25:21.000000000","message":"nit: I trust you to do it, but sometimes comments about future changes look bad after they don\u0027t happen -- So I\u0027d leave this out and just add them when they are added.","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ff75917610c9f08b40237aeb79210655c2a68808","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Will generate an Ubuntu based image with NFS."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"In future changes, support for other distros and share-protocols will be added."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5201f7_a355f450","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":79},"in_reply_to":"ba5201f7_d43adae6","updated":"2017-01-11 14:47:18.000000000","message":"Done","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1725704454f4b24288992f2e9850a232ee1f7557","unresolved":false,"context_lines":[{"line_number":23,"context_line":"~~~~~~~~~~~~~~~~~~"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Before building the image, make sure all system dependencies"},{"line_number":26,"context_line":"listed in other-requirements.txt file, are installed."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Default generic"},{"line_number":29,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5201f7_b573627f","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":32},"updated":"2017-01-11 16:20:06.000000000","message":"s/other-requirements.txt/bindep.txt/","commit_id":"6ff10518e220eaca04739c17512dbe5f73c20ec3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"3d6563d3da1840d190f087a7d0db196663410e64","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. sourcecode:: bash"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"     manila-image-create -s \u003cshare-protocol\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Where \u003cshare-protocol\u003e can be nfs, cifs or zfs."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_3e91fcf1","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":44},"updated":"2017-01-12 01:48:25.000000000","message":"I get ./manila-image-create: line 231: disk-image-create: command not found.  But if you add {posargs} after manila-image-create in the tox.ini then the command works with \"tox -e buildimage -- -s nfs\".","commit_id":"6934134fcf5c87c546df39c2b063e1a23cdab6fb"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a94c931de81a68b758c57a9f9e866b7129c4e335","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. sourcecode:: bash"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"     manila-image-create -s \u003cshare-protocol\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Where \u003cshare-protocol\u003e can be nfs, cifs or zfs."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7a3c09a3_b164da49","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":44},"in_reply_to":"ba5201f7_3e91fcf1","updated":"2017-01-12 21:27:34.000000000","message":"Maybe tell people both ways to do it:\n\n1) source .tox/buildimage/bin/activate\n   manila-image-create -s \u003cshare-protocol\u003e\n\nand modify tox.ini as Mark suggests and tell them they can\n\n2) tox -e buildimage -- -s nfs","commit_id":"6934134fcf5c87c546df39c2b063e1a23cdab6fb"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"0aa0d8f711c0b3310ea1071718aec86bd20cf786","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    virtualenv buildimage"},{"line_number":72,"context_line":"    source buildimage/bin/activate"},{"line_number":73,"context_line":"    pip install -r requirements.txt"},{"line_number":74,"context_line":"    manila-image-create -s cifs"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_d1ca094f","line":74,"updated":"2017-01-14 02:04:03.000000000","message":"manila-image-create: command not found\n\nIt\u0027s in bin/","commit_id":"e1cfefc1860e7c7fff7e03274acc88ba92f6b694"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b3ed5e208b2cf52a7d9076955ad1ee7ca2ee4042","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    virtualenv buildimage"},{"line_number":72,"context_line":"    source buildimage/bin/activate"},{"line_number":73,"context_line":"    pip install -r requirements.txt"},{"line_number":74,"context_line":"    manila-image-create -s cifs"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_7b7d84e6","line":74,"in_reply_to":"7a3c09a3_d1ca094f","updated":"2017-01-16 14:10:52.000000000","message":"I think the issue here is that manila-image-create is not getting installed in buildimage/bin.","commit_id":"e1cfefc1860e7c7fff7e03274acc88ba92f6b694"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2a436abbbd96bf1f643d7019b42fbbbee5f4039a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    tox -e buildimage -- -s cifs"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Will generate an Ubuntu based image with CIFS."}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a3c09a3_5cfb29c1","line":59,"updated":"2017-01-17 13:17:57.000000000","message":"How to build image with more than one protocol?","commit_id":"ac84122598432fa1030a345e2b3b8caa193d6c96"}],"bin/manila-image-create":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"abd4ff432c2dc129e757a1606cc9779c0e793d3a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"MANILA_IMG_OS\u003d${MANILA_IMG_OS:-\"manila-ubuntu-minimal\"}"},{"line_number":23,"context_line":"MANILA_IMG_OS_VER\u003d${MANILA_IMG_OS_VER:-\"trusty\"}"},{"line_number":24,"context_line":"MANILA_IMG_NAME\u003d${MANILA_IMG_NAME:-\"manila-service-image\"}"},{"line_number":25,"context_line":"MANILA_IMG_TYPE\u003d${MANILA_IMG_TYPE:-\"generic\"}"},{"line_number":26,"context_line":"MANILA_SHARE_PROTO\u003d${MANILA_SHARE_PROTO:-\"nfs\"}"},{"line_number":27,"context_line":"MANILA_LXD_METADATA_PACKAGE_NAME\u003d${MANILA_LXD_METADATA_PACKAGE_NAME:-\"manila-lxd-meta\"}"},{"line_number":28,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a74a57a_0ae1222d","line":25,"updated":"2016-11-28 17:46:37.000000000","message":"This seems more like driver type rather image type.\nWould it be better for IMG_TYPE to be \u0027VM\u0027 or \u0027Container\u0027?","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9032c85b61ed71ef4880395a300be3fd3269518e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"MANILA_IMG_OS\u003d${MANILA_IMG_OS:-\"manila-ubuntu-minimal\"}"},{"line_number":23,"context_line":"MANILA_IMG_OS_VER\u003d${MANILA_IMG_OS_VER:-\"trusty\"}"},{"line_number":24,"context_line":"MANILA_IMG_NAME\u003d${MANILA_IMG_NAME:-\"manila-service-image\"}"},{"line_number":25,"context_line":"MANILA_IMG_TYPE\u003d${MANILA_IMG_TYPE:-\"generic\"}"},{"line_number":26,"context_line":"MANILA_SHARE_PROTO\u003d${MANILA_SHARE_PROTO:-\"nfs\"}"},{"line_number":27,"context_line":"MANILA_LXD_METADATA_PACKAGE_NAME\u003d${MANILA_LXD_METADATA_PACKAGE_NAME:-\"manila-lxd-meta\"}"},{"line_number":28,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a71b18c_e460b137","line":25,"in_reply_to":"5a74a57a_0ae1222d","updated":"2016-12-12 14:31:11.000000000","message":"I ended up removing this since we are not differentiating anymore.","commit_id":"e27b262ab0ffb385d9962442819927eea3949a2c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"1f5df4b0828552a7cba11274d357ddecefe52b9e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    OPTIONAL_ELEMENTS\u003d"},{"line_number":100,"context_line":"    OPTIONAL_DIB_ARGS\u003d"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if [ \"$MANILA_SHARE_PROTO\" \u003d \"nfs\" ]; then"},{"line_number":103,"context_line":"        OPTIONAL_ELEMENTS\u003d\"$OPTIONAL_ELEMENTS manila-nfs\""},{"line_number":104,"context_line":"    elif [ \"$MANILA_SHARE_PROTO\" \u003d \"cifs\" ]; then"},{"line_number":105,"context_line":"        OPTIONAL_ELEMENTS\u003d\"$OPTIONAL_ELEMENTS manila-cifs\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3a71b18c_00cb5573","line":102,"updated":"2016-12-08 14:15:11.000000000","message":"undefined variable.","commit_id":"50fc68760acff41eb5d581c2d88c3bb79755536e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7d18f8a5938c03169880aba8b3ddea1614b46553","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"print_usage() {"},{"line_number":56,"context_line":"    echo \"Usage: ${0##*/} [-s share-proto] [-t image-type] [-h]\""},{"line_number":57,"context_line":"    echo \"Options:\""},{"line_number":58,"context_line":"    echo \" -s | --share-proto: name of the share protocol. Possible options are nfs, cifs or zfs\""},{"line_number":59,"context_line":"    echo \" -h | --help: print this usage message and exit\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ba5201f7_7a81148f","line":56,"range":{"start_line":56,"start_character":43,"end_line":56,"end_character":58},"updated":"2017-01-10 22:25:21.000000000","message":"no -t implemented","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ff75917610c9f08b40237aeb79210655c2a68808","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"print_usage() {"},{"line_number":56,"context_line":"    echo \"Usage: ${0##*/} [-s share-proto] [-t image-type] [-h]\""},{"line_number":57,"context_line":"    echo \"Options:\""},{"line_number":58,"context_line":"    echo \" -s | --share-proto: name of the share protocol. Possible options are nfs, cifs or zfs\""},{"line_number":59,"context_line":"    echo \" -h | --help: print this usage message and exit\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ba5201f7_43cd2830","line":56,"range":{"start_line":56,"start_character":43,"end_line":56,"end_character":58},"in_reply_to":"ba5201f7_7a81148f","updated":"2017-01-11 14:47:18.000000000","message":"Done","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7d18f8a5938c03169880aba8b3ddea1614b46553","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                exit 1"},{"line_number":86,"context_line":"            ;;"},{"line_number":87,"context_line":"            *)"},{"line_number":88,"context_line":"                break"},{"line_number":89,"context_line":"            ;;"},{"line_number":90,"context_line":"         esac"},{"line_number":91,"context_line":"    done"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ba5201f7_556341dd","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":21},"updated":"2017-01-10 22:25:21.000000000","message":"shouldn\u0027t this be an err?","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ff75917610c9f08b40237aeb79210655c2a68808","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                exit 1"},{"line_number":86,"context_line":"            ;;"},{"line_number":87,"context_line":"            *)"},{"line_number":88,"context_line":"                break"},{"line_number":89,"context_line":"            ;;"},{"line_number":90,"context_line":"         esac"},{"line_number":91,"context_line":"    done"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ba5201f7_c3d918f5","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":21},"in_reply_to":"ba5201f7_556341dd","updated":"2017-01-11 14:47:18.000000000","message":"Yeah, good point.","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7d18f8a5938c03169880aba8b3ddea1614b46553","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                    fi"},{"line_number":209,"context_line":"                    ;;"},{"line_number":210,"context_line":"                *)"},{"line_number":211,"context_line":"                    echo -e \"Unknown platform \u0027$platform\u0027 for installing packages.\\nAborting\""},{"line_number":212,"context_line":"                    exit 2"},{"line_number":213,"context_line":"                    ;;"},{"line_number":214,"context_line":"            esac"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ba5201f7_95e2092e","line":211,"range":{"start_line":211,"start_character":20,"end_line":211,"end_character":28},"updated":"2017-01-10 22:25:21.000000000","message":"why isn\u0027t err() doing echo -e and reused?","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ff75917610c9f08b40237aeb79210655c2a68808","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                    fi"},{"line_number":209,"context_line":"                    ;;"},{"line_number":210,"context_line":"                *)"},{"line_number":211,"context_line":"                    echo -e \"Unknown platform \u0027$platform\u0027 for installing packages.\\nAborting\""},{"line_number":212,"context_line":"                    exit 2"},{"line_number":213,"context_line":"                    ;;"},{"line_number":214,"context_line":"            esac"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ba5201f7_a3033441","line":211,"range":{"start_line":211,"start_character":20,"end_line":211,"end_character":28},"in_reply_to":"ba5201f7_95e2092e","updated":"2017-01-11 14:47:18.000000000","message":"Done","commit_id":"a3b55d0d514594ca781baa48c0e1126199120ec5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1725704454f4b24288992f2e9850a232ee1f7557","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                print_usage"},{"line_number":81,"context_line":"                exit 0"},{"line_number":82,"context_line":"            ;;"},{"line_number":83,"context_line":"            -*)"},{"line_number":84,"context_line":"                err \"Error: Unknown option: $1.\""},{"line_number":85,"context_line":"                exit 1"},{"line_number":86,"context_line":"            ;;"},{"line_number":87,"context_line":"            *)"},{"line_number":88,"context_line":"                err \"Error: Unknown option: $1.\""},{"line_number":89,"context_line":"                exit 1"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba5201f7_fa69598d","line":86,"range":{"start_line":83,"start_character":0,"end_line":86,"end_character":14},"updated":"2017-01-11 16:20:06.000000000","message":"This not needed. The * does the same thing.","commit_id":"6ff10518e220eaca04739c17512dbe5f73c20ec3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1725704454f4b24288992f2e9850a232ee1f7557","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            package_list\u003d\"qemu-kvm qemu-img kpartx\""},{"line_number":155,"context_line":"            ;;"},{"line_number":156,"context_line":"        *)"},{"line_number":157,"context_line":"            err \"Unknown platform \u0027$platform\u0027 for the package list.\\nAborting\""},{"line_number":158,"context_line":"            exit 2"},{"line_number":159,"context_line":"            ;;"},{"line_number":160,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba5201f7_7aad6983","line":157,"range":{"start_line":157,"start_character":67,"end_line":157,"end_character":69},"updated":"2017-01-11 16:20:06.000000000","message":"Sorry, but you lost the -e which allows the \\n to work. To re-use err() you need it to do echo -e.","commit_id":"6ff10518e220eaca04739c17512dbe5f73c20ec3"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f56f10b4dcc80a1f38b6abe31c17d466481d8421","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            package_list\u003d\"qemu-kvm qemu-img kpartx\""},{"line_number":155,"context_line":"            ;;"},{"line_number":156,"context_line":"        *)"},{"line_number":157,"context_line":"            err \"Unknown platform \u0027$platform\u0027 for the package list.\\nAborting\""},{"line_number":158,"context_line":"            exit 2"},{"line_number":159,"context_line":"            ;;"},{"line_number":160,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba5201f7_72d10657","line":157,"range":{"start_line":157,"start_character":67,"end_line":157,"end_character":69},"in_reply_to":"ba5201f7_7aad6983","updated":"2017-01-11 18:52:12.000000000","message":"Added -e in err(), that should do it :)","commit_id":"6ff10518e220eaca04739c17512dbe5f73c20ec3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1725704454f4b24288992f2e9850a232ee1f7557","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                platform\u003dcentos"},{"line_number":182,"context_line":"                ;;"},{"line_number":183,"context_line":"            *)"},{"line_number":184,"context_line":"                err \"Unknown value in /etc/system-release. Impossible to build images.\\nAborting\""},{"line_number":185,"context_line":"                exit 2"},{"line_number":186,"context_line":"                ;;"},{"line_number":187,"context_line":"        esac"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba5201f7_dac81558","line":184,"range":{"start_line":184,"start_character":86,"end_line":184,"end_character":88},"updated":"2017-01-11 16:20:06.000000000","message":"same and more below.","commit_id":"6ff10518e220eaca04739c17512dbe5f73c20ec3"}]}