)]}'
{"id":"openstack%2Fmanila-image-elements~804060","triplet_id":"openstack%2Fmanila-image-elements~master~I08ee3e643bb0c6208bda7caadc11f865617163f3","project":"openstack/manila-image-elements","branch":"master","topic":"sec","hashtags":[],"change_id":"I08ee3e643bb0c6208bda7caadc11f865617163f3","subject":"Allow empty MANILA_PASSWORD to harden security","status":"MERGED","created":"2021-08-10 10:26:46.000000000","updated":"2021-08-11 10:45:00.000000000","submitted":"2021-08-11 10:45:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"804060-sec","meta_rev_id":"188489a5d14de32947dafead294ef8cd7a941a98","_number":804060,"virtual_id_number":804060,"owner":{"_account_id":30238,"name":"George Melikov","email":"mail@gmelikov.ru","username":"gmelikov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-08-11 10:45:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"all":[{"value":2,"date":"2021-08-11 10:28:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":2,"date":"2021-08-11 00:29:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"all":[{"value":1,"date":"2021-08-11 10:28:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-10 11:17:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-11 00:29:46.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2021-08-11 00:29:56.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"state":"REVIEWER"}],"messages":[{"id":"38be4e764c9470f27b24035e64ca4b2743c49229","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":30238,"name":"George Melikov","email":"mail@gmelikov.ru","username":"gmelikov"},"date":"2021-08-10 10:26:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d49c8526a40f91cb65ec8334e5d4d1893c928d90","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-10 11:17:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ea5585eb0cc94abf842e3be950c76a9d : SUCCESS in 4m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/321caba10799469887b3c94ba71932f2 : SUCCESS in 4m 47s\n- manila-image-elements-buildimages https://zuul.opendev.org/t/openstack/build/1439b3f96f8d4010a2bafb3320fc20e8 : SUCCESS in 14m 33s\n- manila-image-elements-buildimage-docker https://zuul.opendev.org/t/openstack/build/ad6fd3a7c8ea4bb2b92fe6c964684c5d : SUCCESS in 10m 18s\n- manila-image-elements-container-scenario https://zuul.opendev.org/t/openstack/build/92ffb0c53ae540b0849c1c7cb086ded2 : SUCCESS in 41m 22s (non-voting)\n- manila-image-elements-generic-scenario https://zuul.opendev.org/t/openstack/build/418ae3db8d344f7f98f229088d52eab1 : SUCCESS in 48m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f2de3409c39b4aff9be198fa19abfdb0b1a5a463","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-08-11 00:29:46.000000000","message":"Patch Set 1: Code-Review+2\n\nMakes sense, thanks!","accounts_in_message":[],"_revision_number":1},{"id":"6e09dee92915d724d219849f4f357da0ec34bcb5","author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"date":"2021-08-11 10:28:59.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM. Thank you, George!","accounts_in_message":[],"_revision_number":1},{"id":"4da05135a351dbefac772a2d48d2f70d69c4b396","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-11 10:29:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"076d66e21a13342788fca2852e9144fa46f4663b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-11 10:45:00.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ff4bab5ea144540a563fe8fdce9090c : SUCCESS in 4m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/76757ab41b3f40e8b7d48809d6cff030 : SUCCESS in 4m 18s\n- manila-image-elements-buildimages https://zuul.opendev.org/t/openstack/build/12789a3945be41d7b6b6ad36da848473 : SUCCESS in 15m 09s","accounts_in_message":[],"_revision_number":1},{"id":"188489a5d14de32947dafead294ef8cd7a941a98","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-11 10:45:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"93957d68ef0f99736ea766c5b56f2be620b18bfa","revisions":{"93957d68ef0f99736ea766c5b56f2be620b18bfa":{"kind":"REWORK","_number":1,"created":"2021-08-10 10:26:46.000000000","uploader":{"_account_id":30238,"name":"George Melikov","email":"mail@gmelikov.ru","username":"gmelikov"},"ref":"refs/changes/60/804060/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila-image-elements","ref":"refs/changes/60/804060/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila-image-elements refs/changes/60/804060/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila-image-elements refs/changes/60/804060/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila-image-elements refs/changes/60/804060/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila-image-elements refs/changes/60/804060/1"}}},"commit":{"parents":[{"commit":"9c00e86d17a3487c9467dbedfe09a0d5623974b5","subject":"Merge \"Add OpenLDAP to manila-docker-container\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-image-elements/commit/9c00e86d17a3487c9467dbedfe09a0d5623974b5"}]}],"author":{"name":"George Melikov","email":"mail@gmelikov.ru","date":"2021-08-10 10:05:53.000000000","tz":180},"committer":{"name":"George Melikov","email":"mail@gmelikov.ru","date":"2021-08-10 10:26:31.000000000","tz":180},"subject":"Allow empty MANILA_PASSWORD to harden security","message":"Allow empty MANILA_PASSWORD to harden security\n\nThere is a check for empty value of\n`DIB_MANILA_USER_PASSWORD` in\n`elements/manila-ssh/install.d/50-manila-user` already.\n\nJust allow to set MANILA_PASSWORD empty.\n\nChange-Id: I08ee3e643bb0c6208bda7caadc11f865617163f3\nSigned-off-by: George Melikov \u003cmail@gmelikov.ru\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-image-elements/commit/93957d68ef0f99736ea766c5b56f2be620b18bfa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-image-elements/commit/93957d68ef0f99736ea766c5b56f2be620b18bfa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}