)]}'
{"specs/newton/share-network-multiple-subnets.rst":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7a55d0469932c949381e559c8461ce81ded400d9","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Manila can be deployed with share drivers that handle the creation and"},{"line_number":14,"context_line":"management of share servers. In such a deployment, users create share"},{"line_number":15,"context_line":"networks by specifying network information from either nova-network or"},{"line_number":16,"context_line":"neutron. If the share driver is configured accordingly, a share server"},{"line_number":17,"context_line":"will be created with network information from the specified share network."},{"line_number":18,"context_line":"This network information includes the IP addresses for the share server"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_03ad5588","line":15,"range":{"start_line":15,"start_character":48,"end_line":15,"end_character":70},"updated":"2016-06-02 21:11:58.000000000","message":"I wouldn\u0027t mention this since it is about to be removed.","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2063943132f3eb34ab0daff2cac1bf997ebebf50","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Manila can be deployed with share drivers that handle the creation and"},{"line_number":14,"context_line":"management of share servers. In such a deployment, users create share"},{"line_number":15,"context_line":"networks by specifying network information from either nova-network or"},{"line_number":16,"context_line":"neutron. If the share driver is configured accordingly, a share server"},{"line_number":17,"context_line":"will be created with network information from the specified share network."},{"line_number":18,"context_line":"This network information includes the IP addresses for the share server"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_a0e8ba17","line":15,"range":{"start_line":15,"start_character":48,"end_line":15,"end_character":70},"in_reply_to":"9abb7d3a_03ad5588","updated":"2016-06-02 21:23:56.000000000","message":"Yeah, I just came over here to make the same remark.","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6cd56e582aa52b44bf1f46e8146843a6a0fe439f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Manila can be deployed with share drivers that handle the creation and"},{"line_number":14,"context_line":"management of share servers. In such a deployment, users create share"},{"line_number":15,"context_line":"networks by specifying network information from either nova-network or"},{"line_number":16,"context_line":"neutron. If the share driver is configured accordingly, a share server"},{"line_number":17,"context_line":"will be created with network information from the specified share network."},{"line_number":18,"context_line":"This network information includes the IP addresses for the share server"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_89031a76","line":15,"range":{"start_line":15,"start_character":48,"end_line":15,"end_character":70},"in_reply_to":"9abb7d3a_a0e8ba17","updated":"2016-06-03 01:38:15.000000000","message":"Done","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7a55d0469932c949381e559c8461ce81ded400d9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":117,"context_line":"  network by adding and removing subnets (with pre-conditions"},{"line_number":118,"context_line":"  related to existing shares and share servers)."},{"line_number":119,"context_line":"- Users need to pick the share network (and optionally an AZ) during share"},{"line_number":120,"context_line":"  creation. They only need to pick the AZ during share replica creation."},{"line_number":121,"context_line":"- A share can only be associated with one share network."},{"line_number":122,"context_line":"- Security service associations would continue to remain per share network."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_7e5794ca","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":38},"updated":"2016-06-02 21:11:58.000000000","message":"do you mean subnet? they currently pick the share network already.","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6cd56e582aa52b44bf1f46e8146843a6a0fe439f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":117,"context_line":"  network by adding and removing subnets (with pre-conditions"},{"line_number":118,"context_line":"  related to existing shares and share servers)."},{"line_number":119,"context_line":"- Users need to pick the share network (and optionally an AZ) during share"},{"line_number":120,"context_line":"  creation. They only need to pick the AZ during share replica creation."},{"line_number":121,"context_line":"- A share can only be associated with one share network."},{"line_number":122,"context_line":"- Security service associations would continue to remain per share network."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_29ef8eb1","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":38},"in_reply_to":"9abb7d3a_7e5794ca","updated":"2016-06-03 01:38:15.000000000","message":"changed the wording.. i meant share network and AZ if they wanted to select a particular subnet","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7a55d0469932c949381e559c8461ce81ded400d9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  related to existing shares and share servers)."},{"line_number":119,"context_line":"- Users need to pick the share network (and optionally an AZ) during share"},{"line_number":120,"context_line":"  creation. They only need to pick the AZ during share replica creation."},{"line_number":121,"context_line":"- A share can only be associated with one share network."},{"line_number":122,"context_line":"- Security service associations would continue to remain per share network."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_be71fc79","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":56},"updated":"2016-06-02 21:11:58.000000000","message":"this is already true","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6cd56e582aa52b44bf1f46e8146843a6a0fe439f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  related to existing shares and share servers)."},{"line_number":119,"context_line":"- Users need to pick the share network (and optionally an AZ) during share"},{"line_number":120,"context_line":"  creation. They only need to pick the AZ during share replica creation."},{"line_number":121,"context_line":"- A share can only be associated with one share network."},{"line_number":122,"context_line":"- Security service associations would continue to remain per share network."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_89115ab2","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":56},"in_reply_to":"9abb7d3a_be71fc79","updated":"2016-06-03 01:38:15.000000000","message":"clarified..","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7a55d0469932c949381e559c8461ce81ded400d9","unresolved":false,"context_lines":[{"line_number":171,"context_line":"------------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"We can keep the existing design of share networks, but allow related"},{"line_number":174,"context_line":"resources to be created in multiple share networks. A share networks will"},{"line_number":175,"context_line":"not span subnets or AZs, and users would require to use a different share"},{"line_number":176,"context_line":"network for each instance of a share. They would have to configure security"},{"line_number":177,"context_line":"services to each of these networks. For share replication, effectively, the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_1e7da8e7","line":174,"range":{"start_line":174,"start_character":60,"end_line":174,"end_character":68},"updated":"2016-06-02 21:11:58.000000000","message":"network","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6cd56e582aa52b44bf1f46e8146843a6a0fe439f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"------------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"We can keep the existing design of share networks, but allow related"},{"line_number":174,"context_line":"resources to be created in multiple share networks. A share networks will"},{"line_number":175,"context_line":"not span subnets or AZs, and users would require to use a different share"},{"line_number":176,"context_line":"network for each instance of a share. They would have to configure security"},{"line_number":177,"context_line":"services to each of these networks. For share replication, effectively, the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_895f9a74","line":174,"range":{"start_line":174,"start_character":60,"end_line":174,"end_character":68},"in_reply_to":"9abb7d3a_1e7da8e7","updated":"2016-06-03 01:38:15.000000000","message":"Done","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7a55d0469932c949381e559c8461ce81ded400d9","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        }"},{"line_number":247,"context_line":"    }"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"The subnet details: ``neutron_subnet_id`` and ``neutron_net_id`` can be"},{"line_number":250,"context_line":"replaced by ``nova_net_id``. You may also create the share network without"},{"line_number":251,"context_line":"any of these subnet details."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"``availability_zone_id`` is optional if ``manila-share`` services are only"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_791fae5b","line":250,"range":{"start_line":249,"start_character":0,"end_line":250,"end_character":26},"updated":"2016-06-02 21:11:58.000000000","message":"why replace?","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6cd56e582aa52b44bf1f46e8146843a6a0fe439f","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        }"},{"line_number":247,"context_line":"    }"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"The subnet details: ``neutron_subnet_id`` and ``neutron_net_id`` can be"},{"line_number":250,"context_line":"replaced by ``nova_net_id``. You may also create the share network without"},{"line_number":251,"context_line":"any of these subnet details."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"``availability_zone_id`` is optional if ``manila-share`` services are only"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_c959a290","line":250,"range":{"start_line":249,"start_character":0,"end_line":250,"end_character":26},"in_reply_to":"9abb7d3a_791fae5b","updated":"2016-06-03 01:38:15.000000000","message":"I meant the option of using nova-net-id exists today.. but i removed all references..","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7a55d0469932c949381e559c8461ce81ded400d9","unresolved":false,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"Security services are still associated with share networks, but the"},{"line_number":546,"context_line":"coverage of the share network is increasing to span multiple subnets. So for"},{"line_number":547,"context_line":"an external user, the only visible change is that the share network could now"},{"line_number":548,"context_line":"\"bigger\" than it previously was. Hence, due care must be taken in adding"},{"line_number":549,"context_line":"subnets to existing share networks. Users may assign as many subnets to a"},{"line_number":550,"context_line":"particular share network as there are availability zones in a deployment."},{"line_number":551,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_b9947644","line":548,"range":{"start_line":547,"start_character":74,"end_line":548,"end_character":8},"updated":"2016-06-02 21:11:58.000000000","message":"could now \"be\" or \"become\" bigger","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6cd56e582aa52b44bf1f46e8146843a6a0fe439f","unresolved":false,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"Security services are still associated with share networks, but the"},{"line_number":546,"context_line":"coverage of the share network is increasing to span multiple subnets. So for"},{"line_number":547,"context_line":"an external user, the only visible change is that the share network could now"},{"line_number":548,"context_line":"\"bigger\" than it previously was. Hence, due care must be taken in adding"},{"line_number":549,"context_line":"subnets to existing share networks. Users may assign as many subnets to a"},{"line_number":550,"context_line":"particular share network as there are availability zones in a deployment."},{"line_number":551,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9abb7d3a_e950e660","line":548,"range":{"start_line":547,"start_character":74,"end_line":548,"end_character":8},"in_reply_to":"9abb7d3a_b9947644","updated":"2016-06-03 01:38:15.000000000","message":"Done","commit_id":"2d0b19954e51f069bc9b037b9f17ecb479f6a927"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7f7bb891f2678c12381690a80803c4e4003885af","unresolved":false,"context_lines":[{"line_number":111,"context_line":"- Users will have the ability to assign one subnet per configured storage"},{"line_number":112,"context_line":"  availability zone per share network. They can assign the same subnet to"},{"line_number":113,"context_line":"  different AZs if their setup permits, but they cannot have more than one"},{"line_number":114,"context_line":"  subnet serving an AZ per share network."},{"line_number":115,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":116,"context_line":"  network by adding and removing subnets (with pre-conditions"},{"line_number":117,"context_line":"  related to existing shares and share servers)."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_67a6dbc2","line":114,"updated":"2016-06-06 14:43:17.000000000","message":"What is the reasoning for not allowing multiple subnets for an AZ? What if I need more ips so I want to add another subnet for the az?","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dafeb481bd026b7b82fa1808c1270d587bc303d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"- Users will have the ability to assign one subnet per configured storage"},{"line_number":112,"context_line":"  availability zone per share network. They can assign the same subnet to"},{"line_number":113,"context_line":"  different AZs if their setup permits, but they cannot have more than one"},{"line_number":114,"context_line":"  subnet serving an AZ per share network."},{"line_number":115,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":116,"context_line":"  network by adding and removing subnets (with pre-conditions"},{"line_number":117,"context_line":"  related to existing shares and share servers)."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_5058a932","line":114,"in_reply_to":"7aa08908_67a6dbc2","updated":"2016-06-06 19:14:33.000000000","message":"What you propose is a valid use case.. but, the cost of supporting multiple subnets in an AZ is that:\n\n* When a user specifies an AZ and a share network, you would need a deterministic way of figuring out which subnet from the share_network you really want to use","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7f7bb891f2678c12381690a80803c4e4003885af","unresolved":false,"context_lines":[{"line_number":133,"context_line":"**Creating a share network**"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Users can continue to create a share network with a single subnet, but they"},{"line_number":136,"context_line":"would have to provide an availability zone to assign the subnet to. The"},{"line_number":137,"context_line":"manila API service can assign the default availability zone if only one exists."},{"line_number":138,"context_line":"Alternatively, users can also create \"empty\" share networks, as is the case"},{"line_number":139,"context_line":"today."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_87602737","line":136,"range":{"start_line":136,"start_character":25,"end_line":136,"end_character":37},"updated":"2016-06-06 14:43:17.000000000","message":"What is the problem with having a subnet with no AZ?","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dafeb481bd026b7b82fa1808c1270d587bc303d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"**Creating a share network**"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Users can continue to create a share network with a single subnet, but they"},{"line_number":136,"context_line":"would have to provide an availability zone to assign the subnet to. The"},{"line_number":137,"context_line":"manila API service can assign the default availability zone if only one exists."},{"line_number":138,"context_line":"Alternatively, users can also create \"empty\" share networks, as is the case"},{"line_number":139,"context_line":"today."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_d04c9972","line":136,"range":{"start_line":136,"start_character":25,"end_line":136,"end_character":37},"in_reply_to":"7aa08908_87602737","updated":"2016-06-06 19:14:33.000000000","message":"Thanks for seeding this discussion. We\u0027ll allow it.","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7f7bb891f2678c12381690a80803c4e4003885af","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Users can continue to create a share network with a single subnet, but they"},{"line_number":136,"context_line":"would have to provide an availability zone to assign the subnet to. The"},{"line_number":137,"context_line":"manila API service can assign the default availability zone if only one exists."},{"line_number":138,"context_line":"Alternatively, users can also create \"empty\" share networks, as is the case"},{"line_number":139,"context_line":"today."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_872b07eb","line":137,"updated":"2016-06-06 14:43:17.000000000","message":"only if*?","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7f7bb891f2678c12381690a80803c4e4003885af","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Users can provide the share network to create the share with, as before."},{"line_number":149,"context_line":"However, if there is more than one subnet associated with the share network,"},{"line_number":150,"context_line":"they would ideally provide an availability zone as well to create it on a"},{"line_number":151,"context_line":"particular subnet (perhaps for co-location purposes with other resources"},{"line_number":152,"context_line":"they care about on their OpenStack cloud)."},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_c7834fcb","line":150,"range":{"start_line":150,"start_character":11,"end_line":150,"end_character":18},"updated":"2016-06-06 14:43:17.000000000","message":"It\u0027s not really ideally, its just if they want to specify one they would do so via an AZ.","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dafeb481bd026b7b82fa1808c1270d587bc303d","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Users can provide the share network to create the share with, as before."},{"line_number":149,"context_line":"However, if there is more than one subnet associated with the share network,"},{"line_number":150,"context_line":"they would ideally provide an availability zone as well to create it on a"},{"line_number":151,"context_line":"particular subnet (perhaps for co-location purposes with other resources"},{"line_number":152,"context_line":"they care about on their OpenStack cloud)."},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_d063f9da","line":150,"range":{"start_line":150,"start_character":11,"end_line":150,"end_character":18},"in_reply_to":"7aa08908_c7834fcb","updated":"2016-06-06 19:14:33.000000000","message":"allowing a subnet with no AZ would warrant that this is an ideal situation","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7f7bb891f2678c12381690a80803c4e4003885af","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    {"},{"line_number":245,"context_line":"        \"share_network\": {"},{"line_number":246,"context_line":"            \"neutron_net_id\": \"998b42ee-2cee-4d36-8b95-67b5ca1f2109\","},{"line_number":247,"context_line":"            \"neutron_subnet_id\": \"53482b62-2c84-4a53-b6ab-30d9d9800d06\","},{"line_number":248,"context_line":"            \"name\": \"my_network\","},{"line_number":249,"context_line":"            \"description\": \"This is my share network\""},{"line_number":250,"context_line":"            \"availability_zone_id\": \"131ee394-aeaa-462f-9096-faa14b660a8a\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_872ca74b","line":247,"updated":"2016-06-06 14:43:17.000000000","message":"We dont want to allow adding all the subnets on the create request?","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dafeb481bd026b7b82fa1808c1270d587bc303d","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    {"},{"line_number":245,"context_line":"        \"share_network\": {"},{"line_number":246,"context_line":"            \"neutron_net_id\": \"998b42ee-2cee-4d36-8b95-67b5ca1f2109\","},{"line_number":247,"context_line":"            \"neutron_subnet_id\": \"53482b62-2c84-4a53-b6ab-30d9d9800d06\","},{"line_number":248,"context_line":"            \"name\": \"my_network\","},{"line_number":249,"context_line":"            \"description\": \"This is my share network\""},{"line_number":250,"context_line":"            \"availability_zone_id\": \"131ee394-aeaa-462f-9096-faa14b660a8a\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_10eaa10f","line":247,"in_reply_to":"7aa08908_872ca74b","updated":"2016-06-06 19:14:33.000000000","message":"I tried to make the API as simple as it is today.. We could add all subnets here, but users could also use the add/remove APIs below.. :)","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7f7bb891f2678c12381690a80803c4e4003885af","unresolved":false,"context_lines":[{"line_number":652,"context_line":"AZ awareness will be coded into the tests, with fall-backs like the share"},{"line_number":653,"context_line":"replication tempest tests."},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"Setting up multiple AZs on the gate is not in the scope of this work."},{"line_number":656,"context_line":"However, these tests can be run manually with multi-AZ configurations."},{"line_number":657,"context_line":""},{"line_number":658,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_ea93b2a1","line":655,"updated":"2016-06-06 14:43:17.000000000","message":"If we allow multiple subnets on an AZ or do not require an AZ we could test this in the gate.","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dafeb481bd026b7b82fa1808c1270d587bc303d","unresolved":false,"context_lines":[{"line_number":652,"context_line":"AZ awareness will be coded into the tests, with fall-backs like the share"},{"line_number":653,"context_line":"replication tempest tests."},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"Setting up multiple AZs on the gate is not in the scope of this work."},{"line_number":656,"context_line":"However, these tests can be run manually with multi-AZ configurations."},{"line_number":657,"context_line":""},{"line_number":658,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_305cfdec","line":655,"in_reply_to":"7aa08908_ea93b2a1","updated":"2016-06-06 19:14:33.000000000","message":"Gate testing for ``DHSS\u003dTrue`` is currently with the generic driver; the generic driver ignores any share network related information and uses network information configured in the config file.. So, apart from API AZ related validation, we can\u0027t test much on the gate today.. \n\nThere\u0027s a good chance there will be no gate driver that can support replication and be DHSS\u003dTrue for a long time, so, i wanted to suggest that vendor CIs can do the right thing and set up AZs in their environments..","commit_id":"3dd7e16bac78bde74c4be311ea996fad77c05875"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"dd9b60c35271fa1eda046935b60fc3e7a9c12e6b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"``ip_version``. These keys will be part of a new model ``manila.db"},{"line_number":238,"context_line":".sqlalchemy.models.ShareNetworkSubnet`` which has a primary key: ``id``"},{"line_number":239,"context_line":"(we\u0027ll refer to this as ``share_network_subnet_id`` for the purposes of this"},{"line_number":240,"context_line":" document) and foreign keys, ``availability_zone_id`` and"},{"line_number":241,"context_line":" ``share_network_id``. A share network subnet is only associated with"},{"line_number":242,"context_line":" exactly one share network and one availability zone."},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7aa08908_fe184677","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":1},"updated":"2016-06-07 17:26:36.000000000","message":"The space here throws off formatting","commit_id":"58829a37ff2921512b2062ac05bc80f9968631ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61d3bbba957be71ac58899985c635b2f35982285","unresolved":false,"context_lines":[{"line_number":237,"context_line":"``ip_version``. These keys will be part of a new model ``manila.db"},{"line_number":238,"context_line":".sqlalchemy.models.ShareNetworkSubnet`` which has a primary key: ``id``"},{"line_number":239,"context_line":"(we\u0027ll refer to this as ``share_network_subnet_id`` for the purposes of this"},{"line_number":240,"context_line":" document) and foreign keys, ``availability_zone_id`` and"},{"line_number":241,"context_line":" ``share_network_id``. A share network subnet is only associated with"},{"line_number":242,"context_line":" exactly one share network and one availability zone."},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7aa08908_794f506b","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":1},"in_reply_to":"7aa08908_fe184677","updated":"2016-06-07 17:32:33.000000000","message":"Done","commit_id":"58829a37ff2921512b2062ac05bc80f9968631ce"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"dd9b60c35271fa1eda046935b60fc3e7a9c12e6b","unresolved":false,"context_lines":[{"line_number":574,"context_line":"an external user, the only visible change is that the share network could now"},{"line_number":575,"context_line":"be \"bigger\" than it previously was. Hence, due care must be taken in adding"},{"line_number":576,"context_line":"subnets to existing share networks. Users may assign as many subnets to a"},{"line_number":577,"context_line":"particular share network as there are availability zones in a deployment."},{"line_number":578,"context_line":""},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7aa08908_9e5662cc","line":577,"updated":"2016-06-07 17:26:36.000000000","message":"They could add more subnets than that now right?","commit_id":"58829a37ff2921512b2062ac05bc80f9968631ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61d3bbba957be71ac58899985c635b2f35982285","unresolved":false,"context_lines":[{"line_number":574,"context_line":"an external user, the only visible change is that the share network could now"},{"line_number":575,"context_line":"be \"bigger\" than it previously was. Hence, due care must be taken in adding"},{"line_number":576,"context_line":"subnets to existing share networks. Users may assign as many subnets to a"},{"line_number":577,"context_line":"particular share network as there are availability zones in a deployment."},{"line_number":578,"context_line":""},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7aa08908_1e571227","line":577,"in_reply_to":"7aa08908_9e5662cc","updated":"2016-06-07 17:32:33.000000000","message":"Done","commit_id":"58829a37ff2921512b2062ac05bc80f9968631ce"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"dd9b60c35271fa1eda046935b60fc3e7a9c12e6b","unresolved":false,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"- End users will have to specify an availability zone parameter during"},{"line_number":591,"context_line":"  share network creation unless they would like to use the default"},{"line_number":592,"context_line":"  availability zone from ``manila.conf``."},{"line_number":593,"context_line":"- End users would have to add new subnets to an existing network iteratively"},{"line_number":594,"context_line":"  to extend the share network across AZs."},{"line_number":595,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7aa08908_1ec71265","line":592,"updated":"2016-06-07 17:26:36.000000000","message":"Did we decide it should instead have *no* AZ?","commit_id":"58829a37ff2921512b2062ac05bc80f9968631ce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"61d3bbba957be71ac58899985c635b2f35982285","unresolved":false,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"- End users will have to specify an availability zone parameter during"},{"line_number":591,"context_line":"  share network creation unless they would like to use the default"},{"line_number":592,"context_line":"  availability zone from ``manila.conf``."},{"line_number":593,"context_line":"- End users would have to add new subnets to an existing network iteratively"},{"line_number":594,"context_line":"  to extend the share network across AZs."},{"line_number":595,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7aa08908_deb2aa93","line":592,"in_reply_to":"7aa08908_1ec71265","updated":"2016-06-07 17:32:33.000000000","message":"Done","commit_id":"58829a37ff2921512b2062ac05bc80f9968631ce"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0062c01e337bf5273c9b25dad2db7d21cdce87a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"between the configured and user specified networks in such cases."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Users use share networks to create shares. A share is associated with a"},{"line_number":29,"context_line":"single share network and is exported off of a share server that is also"},{"line_number":30,"context_line":"associated with the share network. Users can also associate security"},{"line_number":31,"context_line":"services such as LDAP, Active Directory or Kerberos with a share network,"},{"line_number":32,"context_line":"thereby affecting all the shares on the share network."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_2465741d","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":43},"updated":"2016-06-08 10:00:36.000000000","message":"s/ off of /off","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf4cf8c70fc8f4a5b6729d5cfd918d934e0cfbd6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"between the configured and user specified networks in such cases."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Users use share networks to create shares. A share is associated with a"},{"line_number":29,"context_line":"single share network and is exported off of a share server that is also"},{"line_number":30,"context_line":"associated with the share network. Users can also associate security"},{"line_number":31,"context_line":"services such as LDAP, Active Directory or Kerberos with a share network,"},{"line_number":32,"context_line":"thereby affecting all the shares on the share network."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_dadb5220","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":43},"in_reply_to":"7aa08908_2465741d","updated":"2016-06-09 14:55:09.000000000","message":"Done","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0062c01e337bf5273c9b25dad2db7d21cdce87a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"single share network and is exported off of a share server that is also"},{"line_number":30,"context_line":"associated with the share network. Users can also associate security"},{"line_number":31,"context_line":"services such as LDAP, Active Directory or Kerberos with a share network,"},{"line_number":32,"context_line":"thereby affecting all the shares on the share network."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_ff32d9a5","line":32,"range":{"start_line":32,"start_character":53,"end_line":32,"end_character":54},"updated":"2016-06-08 10:00:36.000000000","message":"How about add the relationship between AZs and subnet/share network in this?","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf4cf8c70fc8f4a5b6729d5cfd918d934e0cfbd6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"single share network and is exported off of a share server that is also"},{"line_number":30,"context_line":"associated with the share network. Users can also associate security"},{"line_number":31,"context_line":"services such as LDAP, Active Directory or Kerberos with a share network,"},{"line_number":32,"context_line":"thereby affecting all the shares on the share network."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_c48b771d","line":32,"range":{"start_line":32,"start_character":53,"end_line":32,"end_character":54},"in_reply_to":"7aa08908_ff32d9a5","updated":"2016-06-09 14:55:09.000000000","message":"That\u0027s explained below in the problem description..","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0062c01e337bf5273c9b25dad2db7d21cdce87a","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    To avoid any indeterminate (and hence wrong) behavior, there will be a"},{"line_number":140,"context_line":"    limitation of not allowing more than one ``default`` subnet per share"},{"line_number":141,"context_line":"    network; and similarly, more than one subnet per availability zone."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":144,"context_line":"  network by adding and removing subnets (with pre-conditions"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_e5fa4642","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":70},"updated":"2016-06-08 10:00:36.000000000","message":"Why we not specify a particular AZ and a particular subnet when a user requests to create a resource? \nAs the Alex Meade said, What if I need more ips so I want to add another subnet for the az? or In this case, we need to create another a new share network?","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9a19b722e035d37d87271c81fde4247e4430259e","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    To avoid any indeterminate (and hence wrong) behavior, there will be a"},{"line_number":140,"context_line":"    limitation of not allowing more than one ``default`` subnet per share"},{"line_number":141,"context_line":"    network; and similarly, more than one subnet per availability zone."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":144,"context_line":"  network by adding and removing subnets (with pre-conditions"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_53825a95","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":70},"in_reply_to":"7aa08908_52b57b7c","updated":"2016-06-10 19:56:10.000000000","message":"I understand that there is not value in having multiple subnets per AZ, but then there is no limitation. The description inaccurately states that there is a limitation, while you could just allow the user to select the subnet.","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"64fe374d866c385c1192439787affa0604a323f8","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    To avoid any indeterminate (and hence wrong) behavior, there will be a"},{"line_number":140,"context_line":"    limitation of not allowing more than one ``default`` subnet per share"},{"line_number":141,"context_line":"    network; and similarly, more than one subnet per availability zone."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":144,"context_line":"  network by adding and removing subnets (with pre-conditions"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_52b57b7c","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":70},"in_reply_to":"7aa08908_7f8cd07f","updated":"2016-06-09 17:26:48.000000000","message":"+1 goutham explained to me that neutron subnets aren\u0027t exactly the same as IP subnets as they can have multiple allocation pools within them.","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf4cf8c70fc8f4a5b6729d5cfd918d934e0cfbd6","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    To avoid any indeterminate (and hence wrong) behavior, there will be a"},{"line_number":140,"context_line":"    limitation of not allowing more than one ``default`` subnet per share"},{"line_number":141,"context_line":"    network; and similarly, more than one subnet per availability zone."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":144,"context_line":"  network by adding and removing subnets (with pre-conditions"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_7f8cd07f","line":141,"range":{"start_line":141,"start_character":28,"end_line":141,"end_character":70},"in_reply_to":"7aa08908_e5fa4642","updated":"2016-06-09 14:55:09.000000000","message":"Yes, this is an imminent problem with this design, however, there\u0027s no current perceived value of allowing more subnets per AZ per share network.. Running out of IPs can happen today, and you would create another share network; or update your subnet\u0027s allocation pool.. (which is possible, with neutron or whichever other network provider you choose).","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0062c01e337bf5273c9b25dad2db7d21cdce87a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":144,"context_line":"  network by adding and removing subnets (with pre-conditions"},{"line_number":145,"context_line":"  related to existing shares and share servers)."},{"line_number":146,"context_line":"- Users would need to pick the share network and an AZ during share"},{"line_number":147,"context_line":"  creation if they expect a share to be provisioned with a specific subnet."},{"line_number":148,"context_line":"  They only need to pick the AZ during share replica creation."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_375ac52a","line":146,"range":{"start_line":146,"start_character":48,"end_line":146,"end_character":55},"updated":"2016-06-08 10:00:36.000000000","message":"If we not pick an AZ during share creation. Does we will choose \u0027default\u0027 subnet?","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf4cf8c70fc8f4a5b6729d5cfd918d934e0cfbd6","unresolved":false,"context_lines":[{"line_number":143,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":144,"context_line":"  network by adding and removing subnets (with pre-conditions"},{"line_number":145,"context_line":"  related to existing shares and share servers)."},{"line_number":146,"context_line":"- Users would need to pick the share network and an AZ during share"},{"line_number":147,"context_line":"  creation if they expect a share to be provisioned with a specific subnet."},{"line_number":148,"context_line":"  They only need to pick the AZ during share replica creation."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_ba8be61d","line":146,"range":{"start_line":146,"start_character":48,"end_line":146,"end_character":55},"in_reply_to":"7aa08908_375ac52a","updated":"2016-06-09 14:55:09.000000000","message":"Interesting question.. the scheduler provisions the share on a favorable backend.. and if the request doesn\u0027t ask for an AZ, the share can end up anywhere.. so, you would need to have a default subnet (like today) if you don\u0027t have subnets serving that AZ; then the case is as it is today.. a failure at the share manager to allocate IPs and create a share server.","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0062c01e337bf5273c9b25dad2db7d21cdce87a","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Things that will not change:"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"- A share would still only be associated with one share network."},{"line_number":153,"context_line":"- A security service would continue to be associated with the share"},{"line_number":154,"context_line":"  network. When share servers are created on new subnets, they will derive"},{"line_number":155,"context_line":"  all the security server information from the share network."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_1707c9ca","line":152,"range":{"start_line":152,"start_character":63,"end_line":152,"end_character":64},"updated":"2016-06-08 10:00:36.000000000","message":"How about add \"A share server would still only be associated with one subnet.\" ?","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf4cf8c70fc8f4a5b6729d5cfd918d934e0cfbd6","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Things that will not change:"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"- A share would still only be associated with one share network."},{"line_number":153,"context_line":"- A security service would continue to be associated with the share"},{"line_number":154,"context_line":"  network. When share servers are created on new subnets, they will derive"},{"line_number":155,"context_line":"  all the security server information from the share network."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_5c3d9fba","line":152,"range":{"start_line":152,"start_character":63,"end_line":152,"end_character":64},"in_reply_to":"7aa08908_1707c9ca","updated":"2016-06-09 14:55:09.000000000","message":"Done","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0062c01e337bf5273c9b25dad2db7d21cdce87a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  all the security server information from the share network."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Work-flows affected"},{"line_number":159,"context_line":"-------------------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"**Creating a share network**"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_9779f9ca","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":19},"updated":"2016-06-08 10:00:36.000000000","message":"How about add \u0027managing shares\u0027 affect? It already added in message.","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cf4cf8c70fc8f4a5b6729d5cfd918d934e0cfbd6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  all the security server information from the share network."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Work-flows affected"},{"line_number":159,"context_line":"-------------------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"**Creating a share network**"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_5ac9225a","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":19},"in_reply_to":"7aa08908_9779f9ca","updated":"2016-06-09 14:55:09.000000000","message":"you mean \u0027manage\u0027 API? it isn\u0027t supported for DHSS\u003dTrue drivers..","commit_id":"ae8c3ff275990a1c07209b390b89d86762897797"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"18b5cd109f5e556e557c97dbabd5eb98e2ebcffa","unresolved":false,"context_lines":[{"line_number":15,"context_line":"networks by specifying network and subnet IDs from neutron. If the share driver"},{"line_number":16,"context_line":"is configured accordingly, a share server will be created with network"},{"line_number":17,"context_line":"information from the specified neutron subnet. This network information"},{"line_number":18,"context_line":"includes the IP addresses for the share server creation which reflect in the"},{"line_number":19,"context_line":"export locations of shares created by such drivers."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"If the share driver is configured with a ``standalone`` network or with a"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_2d300de8","line":18,"updated":"2016-06-10 20:57:46.000000000","message":"s/reflect/are reflected?","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"networks by specifying network and subnet IDs from neutron. If the share driver"},{"line_number":16,"context_line":"is configured accordingly, a share server will be created with network"},{"line_number":17,"context_line":"information from the specified neutron subnet. This network information"},{"line_number":18,"context_line":"includes the IP addresses for the share server creation which reflect in the"},{"line_number":19,"context_line":"export locations of shares created by such drivers."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"If the share driver is configured with a ``standalone`` network or with a"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_936a9018","line":18,"in_reply_to":"7aa08908_2d300de8","updated":"2016-06-15 00:23:47.000000000","message":"Done","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"18b5cd109f5e556e557c97dbabd5eb98e2ebcffa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"If the share driver is configured with a ``standalone`` network or with a"},{"line_number":22,"context_line":"``single`` network configuration [1], the share server is created with the"},{"line_number":23,"context_line":"network details from the ``manila.conf`` file. Network information from the"},{"line_number":24,"context_line":"user specified share network are (currently) ignored in this case. There is"},{"line_number":25,"context_line":"future work envisioned to provide network tunneling and hence, connectivity"},{"line_number":26,"context_line":"between the configured and user specified networks in such cases."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_edaa85d1","line":24,"updated":"2016-06-10 20:57:46.000000000","message":"s/are/is","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"If the share driver is configured with a ``standalone`` network or with a"},{"line_number":22,"context_line":"``single`` network configuration [1], the share server is created with the"},{"line_number":23,"context_line":"network details from the ``manila.conf`` file. Network information from the"},{"line_number":24,"context_line":"user specified share network are (currently) ignored in this case. There is"},{"line_number":25,"context_line":"future work envisioned to provide network tunneling and hence, connectivity"},{"line_number":26,"context_line":"between the configured and user specified networks in such cases."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_7358c48a","line":24,"in_reply_to":"7aa08908_edaa85d1","updated":"2016-06-15 00:23:47.000000000","message":"Done","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"18b5cd109f5e556e557c97dbabd5eb98e2ebcffa","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  associated with any particular availability zone, this ``default`` subnet"},{"line_number":121,"context_line":"  is meant to service all availability zones."},{"line_number":122,"context_line":"- Each share network can have no more than one ``default`` subnet."},{"line_number":123,"context_line":"- A share network need not have a ``default`` subnet."},{"line_number":124,"context_line":"- Users will have the ability to assign one subnet per configured storage"},{"line_number":125,"context_line":"  availability zone per share network. They can assign the same subnet to"},{"line_number":126,"context_line":"  different AZs if their setup permits, but they cannot have more than one"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_999b43c9","line":123,"updated":"2016-06-10 20:57:46.000000000","message":"Why not make this a requirement?","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  associated with any particular availability zone, this ``default`` subnet"},{"line_number":121,"context_line":"  is meant to service all availability zones."},{"line_number":122,"context_line":"- Each share network can have no more than one ``default`` subnet."},{"line_number":123,"context_line":"- A share network need not have a ``default`` subnet."},{"line_number":124,"context_line":"- Users will have the ability to assign one subnet per configured storage"},{"line_number":125,"context_line":"  availability zone per share network. They can assign the same subnet to"},{"line_number":126,"context_line":"  different AZs if their setup permits, but they cannot have more than one"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_13f34074","line":123,"in_reply_to":"7aa08908_999b43c9","updated":"2016-06-15 00:23:47.000000000","message":"Currently share networks can be empty... For the use case specified in the second paragraph of the introduction.. So, we shouldn\u0027t require a default subnet to be specified..","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"09f56f157d6ff3d59c848001b170812c65f71ddd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    manila will then have no way of picking the right subnet of the choices"},{"line_number":137,"context_line":"    it would have."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    To avoid any indeterminate (and hence wrong) behavior, there will be a"},{"line_number":140,"context_line":"    limitation of not allowing more than one ``default`` subnet per share"},{"line_number":141,"context_line":"    network; and similarly, more than one subnet per availability zone."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":144,"context_line":"  network by adding and removing subnets (with pre-conditions"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_33022e0c","line":141,"range":{"start_line":139,"start_character":4,"end_line":141,"end_character":71},"updated":"2016-06-10 19:57:57.000000000","message":"See comment in PS #10, I believe this should be reworded stating that there is no value at the moment instead of saying this is a limitation.","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    manila will then have no way of picking the right subnet of the choices"},{"line_number":137,"context_line":"    it would have."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    To avoid any indeterminate (and hence wrong) behavior, there will be a"},{"line_number":140,"context_line":"    limitation of not allowing more than one ``default`` subnet per share"},{"line_number":141,"context_line":"    network; and similarly, more than one subnet per availability zone."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"- API changes would involve extending the ability to modify a share"},{"line_number":144,"context_line":"  network by adding and removing subnets (with pre-conditions"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_53e9487e","line":141,"range":{"start_line":139,"start_character":4,"end_line":141,"end_character":71},"in_reply_to":"7aa08908_33022e0c","updated":"2016-06-15 00:23:47.000000000","message":"I agree. Changed.","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"18b5cd109f5e556e557c97dbabd5eb98e2ebcffa","unresolved":false,"context_lines":[{"line_number":183,"context_line":"However, if there is more than one subnet associated with the share network,"},{"line_number":184,"context_line":"they would ideally provide an availability zone as well to create it on a"},{"line_number":185,"context_line":"particular subnet (perhaps for co-location purposes with other resources"},{"line_number":186,"context_line":"they care about on their OpenStack cloud)."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Creating a share replica**"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_b9aeff95","line":186,"updated":"2016-06-10 20:57:46.000000000","message":"availability-zone is already an optional input in create share.  Are you going to make it mandatory?  What additional validation are you going to do?","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"However, if there is more than one subnet associated with the share network,"},{"line_number":184,"context_line":"they would ideally provide an availability zone as well to create it on a"},{"line_number":185,"context_line":"particular subnet (perhaps for co-location purposes with other resources"},{"line_number":186,"context_line":"they care about on their OpenStack cloud)."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"**Creating a share replica**"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_0bc2e452","line":186,"in_reply_to":"7aa08908_b9aeff95","updated":"2016-06-15 00:23:47.000000000","message":"That\u0027s an interesting question. No, AZ will not be mandatory for creating shares. If not specified, the behavior is as of today, the scheduler will pick a backend and send it, and we fill in the AZ based on where the backend \"lives\". \n\n\nBut this change gives us room to validate prior to the scheduler if the share network has a valid subnet in the AZ, when an AZ is specified; but what do we do in case of empty share networks?","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"09f56f157d6ff3d59c848001b170812c65f71ddd","unresolved":false,"context_lines":[{"line_number":255,"context_line":"to the ``manila.db.sqlalchemy.models.ShareNetwork`` model."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"The database upgrade step will create a new share network subnet per"},{"line_number":258,"context_line":"existing share network. The ``availability_zone_id`` field will be ``null``"},{"line_number":259,"context_line":"indicating that these are ``default`` subnets, unconfined to a given"},{"line_number":260,"context_line":"availability zone."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_1340d2a4","line":258,"range":{"start_line":258,"start_character":67,"end_line":258,"end_character":75},"updated":"2016-06-10 19:57:57.000000000","message":"not very friendly I would say, sometimes it is hard to guess that \"null\" means \"default\".","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"to the ``manila.db.sqlalchemy.models.ShareNetwork`` model."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"The database upgrade step will create a new share network subnet per"},{"line_number":258,"context_line":"existing share network. The ``availability_zone_id`` field will be ``null``"},{"line_number":259,"context_line":"indicating that these are ``default`` subnets, unconfined to a given"},{"line_number":260,"context_line":"availability zone."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_7d987175","line":258,"range":{"start_line":258,"start_character":67,"end_line":258,"end_character":75},"in_reply_to":"7aa08908_1340d2a4","updated":"2016-06-15 00:23:47.000000000","message":"In the database? Why not?\n\nIf there\u0027s a foreign key constraint, you can only have a key from the availability zones table, or null as your values...","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"18b5cd109f5e556e557c97dbabd5eb98e2ebcffa","unresolved":false,"context_lines":[{"line_number":262,"context_line":"The database downgrade step will collapse existing share network subnets"},{"line_number":263,"context_line":"into the share network table. This step may result in loss of information"},{"line_number":264,"context_line":"if multiple subnets exist per share network. Hence, it is not recommended in a"},{"line_number":265,"context_line":"production cloud."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"REST API impact"},{"line_number":268,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_24730282","line":265,"updated":"2016-06-10 20:57:46.000000000","message":"Will there be any impact to the Service table which has a relationship with AZ?","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":262,"context_line":"The database downgrade step will collapse existing share network subnets"},{"line_number":263,"context_line":"into the share network table. This step may result in loss of information"},{"line_number":264,"context_line":"if multiple subnets exist per share network. Hence, it is not recommended in a"},{"line_number":265,"context_line":"production cloud."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"REST API impact"},{"line_number":268,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_3d79c92f","line":265,"in_reply_to":"7aa08908_24730282","updated":"2016-06-15 00:23:47.000000000","message":"No, AZs are not altered; share-network-subnets will be like the services table in the sense that it will have a reference to an availability_zone.","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"18b5cd109f5e556e557c97dbabd5eb98e2ebcffa","unresolved":false,"context_lines":[{"line_number":291,"context_line":"``availability_zone_id`` is optional if one of the following conditions are"},{"line_number":292,"context_line":"met:"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* user is creating a subnet that is meant to span all availability zones."},{"line_number":295,"context_line":"* ``manila-share`` services are only configured with a single availability"},{"line_number":296,"context_line":"  zone, or,"},{"line_number":297,"context_line":"* when subnet details are not provided."}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_e499fa6f","line":294,"updated":"2016-06-10 20:57:46.000000000","message":"Does the API validate this?","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":291,"context_line":"``availability_zone_id`` is optional if one of the following conditions are"},{"line_number":292,"context_line":"met:"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* user is creating a subnet that is meant to span all availability zones."},{"line_number":295,"context_line":"* ``manila-share`` services are only configured with a single availability"},{"line_number":296,"context_line":"  zone, or,"},{"line_number":297,"context_line":"* when subnet details are not provided."}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_1d97ad3a","line":294,"in_reply_to":"7aa08908_e499fa6f","updated":"2016-06-15 00:23:47.000000000","message":"Do you mean validating that the subnet is valid? (see line 305)\n\nor that the subnet can service a given storage availability zone? then, no... that would be a failure on the part of the user to not provide manila valid network details..","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8f05220c5185b9adf1e6292e61128076480f4306","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                \"id\": \"77eb3421-4549-4789-ac39-0d5185d68c29\","},{"line_number":417,"context_line":"                \"project_id\": \"e10a683c20da41248cfd5e1ab3d88c62\","},{"line_number":418,"context_line":"                \"description\": \"This is my share network\","},{"line_number":419,"context_line":"                \"updated_at\": null"},{"line_number":420,"context_line":"                \"share_network_subnets\": ["},{"line_number":421,"context_line":"                    {"},{"line_number":422,"context_line":"                        \"created_at\": \"2016-06-01T21:12:14.843836\","}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_d38bd166","line":419,"range":{"start_line":419,"start_character":30,"end_line":419,"end_character":34},"updated":"2016-06-12 14:42:48.000000000","message":"Add \u0027,\u0027 in the end.","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9aa6738087f7d9742bb333b6c7194ac379a0d8c","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                \"id\": \"77eb3421-4549-4789-ac39-0d5185d68c29\","},{"line_number":417,"context_line":"                \"project_id\": \"e10a683c20da41248cfd5e1ab3d88c62\","},{"line_number":418,"context_line":"                \"description\": \"This is my share network\","},{"line_number":419,"context_line":"                \"updated_at\": null"},{"line_number":420,"context_line":"                \"share_network_subnets\": ["},{"line_number":421,"context_line":"                    {"},{"line_number":422,"context_line":"                        \"created_at\": \"2016-06-01T21:12:14.843836\","}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_bdbad9bd","line":419,"range":{"start_line":419,"start_character":30,"end_line":419,"end_character":34},"in_reply_to":"7aa08908_d38bd166","updated":"2016-06-15 00:23:47.000000000","message":"Done","commit_id":"8711dd2515ace1bf6b2ccafa4cc1c5e0407920cc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"88f0d69e350b194cec7bdfba86ec07a67e5ee897","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            \"neutron_subnet_id\": \"53482b62-2c84-4a53-b6ab-30d9d9800d06\","},{"line_number":289,"context_line":"            \"name\": \"my_network\","},{"line_number":290,"context_line":"            \"description\": \"This is my share network\","},{"line_number":291,"context_line":"            \"availability_zone_id\": \"131ee394-aeaa-462f-9096-faa14b660a8a\","},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"    }"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7aa08908_c7a3049d","line":291,"range":{"start_line":291,"start_character":37,"end_line":291,"end_character":73},"updated":"2016-06-17 10:24:36.000000000","message":"Why not name for AZ?","commit_id":"a4f8a6e3ce18406fa1fd9d887b02ba28a79c490e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8b24d58e4e63e26fb26a347b409416102b9ed774","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            \"neutron_subnet_id\": \"53482b62-2c84-4a53-b6ab-30d9d9800d06\","},{"line_number":289,"context_line":"            \"name\": \"my_network\","},{"line_number":290,"context_line":"            \"description\": \"This is my share network\","},{"line_number":291,"context_line":"            \"availability_zone_id\": \"131ee394-aeaa-462f-9096-faa14b660a8a\","},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"    }"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7aa08908_d20c6444","line":291,"range":{"start_line":291,"start_character":37,"end_line":291,"end_character":73},"in_reply_to":"7aa08908_b26f1891","updated":"2016-06-17 10:46:47.000000000","message":"I would say \"yes\".","commit_id":"a4f8a6e3ce18406fa1fd9d887b02ba28a79c490e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f87e65356153bbbfde1fea8f93296175a02f36bd","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            \"neutron_subnet_id\": \"53482b62-2c84-4a53-b6ab-30d9d9800d06\","},{"line_number":289,"context_line":"            \"name\": \"my_network\","},{"line_number":290,"context_line":"            \"description\": \"This is my share network\","},{"line_number":291,"context_line":"            \"availability_zone_id\": \"131ee394-aeaa-462f-9096-faa14b660a8a\","},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"    }"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7aa08908_b26f1891","line":291,"range":{"start_line":291,"start_character":37,"end_line":291,"end_character":73},"in_reply_to":"7aa08908_c7a3049d","updated":"2016-06-17 10:30:36.000000000","message":"Good point. the primary key is AZ ID, however, the name is non-nullable as well. We\u0027re returning name with the other APIs (shares, share-instances, share-replicas.. Do we need to switch this to name?","commit_id":"a4f8a6e3ce18406fa1fd9d887b02ba28a79c490e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"88f0d69e350b194cec7bdfba86ec07a67e5ee897","unresolved":false,"context_lines":[{"line_number":559,"context_line":"Response::"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    Code: 202 Accepted"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7aa08908_8708dc81","line":562,"updated":"2016-06-17 10:24:36.000000000","message":"\"List of subnets\" API is absent here. But it is expected to exist according to \"delete share network\" approach.","commit_id":"a4f8a6e3ce18406fa1fd9d887b02ba28a79c490e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0908c7074f4c6dcdc7c1206b977a0c1354f56249","unresolved":false,"context_lines":[{"line_number":559,"context_line":"Response::"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    Code: 202 Accepted"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7aa08908_ad6fb990","line":562,"in_reply_to":"7aa08908_12038c11","updated":"2016-06-17 11:10:08.000000000","message":"Ah, a variant of: GET /v2/​{tenant_id}​/share-networks/{share_network_id}\n\nWe can discuss this further in the code review.. As I mentioned, there\u0027s an ongoing discussion here: https://review.openstack.org/#/c/322194/","commit_id":"a4f8a6e3ce18406fa1fd9d887b02ba28a79c490e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f87e65356153bbbfde1fea8f93296175a02f36bd","unresolved":false,"context_lines":[{"line_number":559,"context_line":"Response::"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    Code: 202 Accepted"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7aa08908_f2440048","line":562,"in_reply_to":"7aa08908_8708dc81","updated":"2016-06-17 10:30:36.000000000","message":"A generic list of subnets? Or specific to a share network?","commit_id":"a4f8a6e3ce18406fa1fd9d887b02ba28a79c490e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8b24d58e4e63e26fb26a347b409416102b9ed774","unresolved":false,"context_lines":[{"line_number":559,"context_line":"Response::"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    Code: 202 Accepted"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7aa08908_12038c11","line":562,"in_reply_to":"7aa08908_f2440048","updated":"2016-06-17 10:46:47.000000000","message":"GET /v2/​{tenant_id}​/share-networks/{share_network_id}/subnets","commit_id":"a4f8a6e3ce18406fa1fd9d887b02ba28a79c490e"}]}