)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36768005748cf11e15fd628ad7eeb30b7b484cd0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"create_share_from_snapshot_support, which removes the overload"},{"line_number":11,"context_line":"from snapshot_support. This is needed prior to the addition of"},{"line_number":12,"context_line":"new snapshot semantics, such as revert-to-snapshot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Partially implements: blueprint add-create-share-from-snapshot-extra-spec"},{"line_number":16,"context_line":"Change-Id: I4d95fe3609b7728ea7d9ed8be6e96241307f0002"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_70152d9a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2016-11-03 02:11:32.000000000","message":"APIImpact","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6ac37b4c1ed774f1168f2469a92cdc21c9f432f4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"create_share_from_snapshot_support, which removes the overload"},{"line_number":11,"context_line":"from snapshot_support. This is needed prior to the addition of"},{"line_number":12,"context_line":"new snapshot semantics, such as revert-to-snapshot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Partially implements: blueprint add-create-share-from-snapshot-extra-spec"},{"line_number":16,"context_line":"Change-Id: I4d95fe3609b7728ea7d9ed8be6e96241307f0002"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_f26bdaee","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"in_reply_to":"ba5da102_70152d9a","updated":"2016-11-03 20:15:24.000000000","message":"Done","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"}],"doc/source/index.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36768005748cf11e15fd628ad7eeb30b7b484cd0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   specs/newton/*"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Ocata approved specs"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. toctree::"},{"line_number":19,"context_line":"   :glob:"},{"line_number":20,"context_line":"   :maxdepth: 1"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"   specs/ocata/*"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"manila-specs Repository Information"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_d037d94a","line":22,"range":{"start_line":15,"start_character":0,"end_line":22,"end_character":16},"updated":"2016-11-03 02:11:32.000000000","message":"Ocata should be above Newton","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6ac37b4c1ed774f1168f2469a92cdc21c9f432f4","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   specs/newton/*"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Ocata approved specs"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. toctree::"},{"line_number":19,"context_line":"   :glob:"},{"line_number":20,"context_line":"   :maxdepth: 1"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"   specs/ocata/*"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"manila-specs Repository Information"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_72e42aab","line":22,"range":{"start_line":15,"start_character":0,"end_line":22,"end_character":16},"in_reply_to":"ba5da102_d037d94a","updated":"2016-11-03 20:15:24.000000000","message":"Done","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"}],"specs/ocata/create-share-from-snapshot-extra-spec.rst":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"95311305749d72b4d8735a20c903c936e78231fd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  creation. Because snapshot_support is now optional, if snapshot_support is"},{"line_number":73,"context_line":"  not present on the share type, set the corresponding value on the share to"},{"line_number":74,"context_line":"  False."},{"line_number":75,"context_line":"* Ensure create_share_from_snapshot_support is True when creating shares from"},{"line_number":76,"context_line":"  snapshots."},{"line_number":77,"context_line":"* Ensure that previous microversions cannot delete the snapshot_support extra"},{"line_number":78,"context_line":"  spec from share types."},{"line_number":79,"context_line":"* Ensure that previous microversions continue setting a default value of True"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_7d363d53","line":76,"range":{"start_line":75,"start_character":2,"end_line":76,"end_character":12},"updated":"2016-11-01 02:57:36.000000000","message":"create_share_from_snapshot_support here is referencing the spec from share type specified while creating, or the added field in  share record which is the snapshot\u0027s parent share?\nAnd what\u0027ll happen if the create_share_from_snapshot_supports from share record and share type are inconsistent?","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b6e45556a4eab834e2ec542525725da67865ec6b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  creation. Because snapshot_support is now optional, if snapshot_support is"},{"line_number":73,"context_line":"  not present on the share type, set the corresponding value on the share to"},{"line_number":74,"context_line":"  False."},{"line_number":75,"context_line":"* Ensure create_share_from_snapshot_support is True when creating shares from"},{"line_number":76,"context_line":"  snapshots."},{"line_number":77,"context_line":"* Ensure that previous microversions cannot delete the snapshot_support extra"},{"line_number":78,"context_line":"  spec from share types."},{"line_number":79,"context_line":"* Ensure that previous microversions continue setting a default value of True"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_cfd05ef9","line":76,"range":{"start_line":75,"start_character":2,"end_line":76,"end_character":12},"in_reply_to":"ba5da102_7d363d53","updated":"2016-11-01 14:43:47.000000000","message":"This references the added field in the share record.  The value of this field is taken from the share type at the time the share is created.  The values can diverge later if the share type is changed, which is precisely why we preserve the value in the share record.","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"1ea91301f84a60ee73f0feffe5e44ffa7371e936","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  creation. Because snapshot_support is now optional, if snapshot_support is"},{"line_number":73,"context_line":"  not present on the share type, set the corresponding value on the share to"},{"line_number":74,"context_line":"  False."},{"line_number":75,"context_line":"* Ensure create_share_from_snapshot_support is True when creating shares from"},{"line_number":76,"context_line":"  snapshots."},{"line_number":77,"context_line":"* Ensure that previous microversions cannot delete the snapshot_support extra"},{"line_number":78,"context_line":"  spec from share types."},{"line_number":79,"context_line":"* Ensure that previous microversions continue setting a default value of True"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_0401426a","line":76,"range":{"start_line":75,"start_character":2,"end_line":76,"end_character":12},"in_reply_to":"ba5da102_cfd05ef9","updated":"2016-11-02 07:07:27.000000000","message":"I see. Thanks for your explanation.","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36768005748cf11e15fd628ad7eeb30b7b484cd0","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"At the microversion for this change:"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* The snapshot_support extra spec becomes deletable, as are the new"},{"line_number":109,"context_line":"  snapshot-related extra specs."},{"line_number":110,"context_line":"* Default values for snapshot_support are no longer provided."},{"line_number":111,"context_line":"* The value of create_share_from_snapshot_support is checked on a share prior"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_b0598590","line":108,"range":{"start_line":108,"start_character":34,"end_line":108,"end_character":51},"updated":"2016-11-03 02:11:32.000000000","message":":D","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36768005748cf11e15fd628ad7eeb30b7b484cd0","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* The snapshot_support extra spec becomes deletable, as are the new"},{"line_number":109,"context_line":"  snapshot-related extra specs."},{"line_number":110,"context_line":"* Default values for snapshot_support are no longer provided."},{"line_number":111,"context_line":"* The value of create_share_from_snapshot_support is checked on a share prior"},{"line_number":112,"context_line":"  to creating a share from a snapshot (else HTTPBadRequest is returned)."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_50e02996","line":110,"range":{"start_line":110,"start_character":2,"end_line":110,"end_character":61},"updated":"2016-11-03 02:11:32.000000000","message":"Could you detail what exactly changes in the share types API?\n\n- administrators see no keys\n- users see snapshot_support and create_share_from_snapshot_support *always* because these are public extra specs.","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6ac37b4c1ed774f1168f2469a92cdc21c9f432f4","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* The snapshot_support extra spec becomes deletable, as are the new"},{"line_number":109,"context_line":"  snapshot-related extra specs."},{"line_number":110,"context_line":"* Default values for snapshot_support are no longer provided."},{"line_number":111,"context_line":"* The value of create_share_from_snapshot_support is checked on a share prior"},{"line_number":112,"context_line":"  to creating a share from a snapshot (else HTTPBadRequest is returned)."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_52d9e6f1","line":110,"range":{"start_line":110,"start_character":2,"end_line":110,"end_character":61},"in_reply_to":"ba5da102_50e02996","updated":"2016-11-03 20:15:24.000000000","message":"Done","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"95311305749d72b4d8735a20c903c936e78231fd","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Documentation Impact"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Minimal doc impact.  The devref will be updated to describe the new or"},{"line_number":189,"context_line":"changed standard extra specs."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_9d395144","line":188,"range":{"start_line":188,"start_character":20,"end_line":188,"end_character":21},"updated":"2016-11-01 02:57:36.000000000","message":"redundant space","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b6e45556a4eab834e2ec542525725da67865ec6b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Documentation Impact"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Minimal doc impact.  The devref will be updated to describe the new or"},{"line_number":189,"context_line":"changed standard extra specs."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_8f01066d","line":188,"range":{"start_line":188,"start_character":20,"end_line":188,"end_character":21},"in_reply_to":"ba5da102_9d395144","updated":"2016-11-01 14:43:47.000000000","message":"Will fix if I have to push another patch set.","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36768005748cf11e15fd628ad7eeb30b7b484cd0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Documentation Impact"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Minimal doc impact.  The devref will be updated to describe the new or"},{"line_number":189,"context_line":"changed standard extra specs."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_f08cdddb","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":29},"updated":"2016-11-03 02:11:32.000000000","message":"Not really, \n\nAPI Ref: Add content about the API\nUser Guide: Add content about the share types\nAdmin Guide: Add content regarding the common capabilities and the don\u0027t care behavior\nDeveloper Ref: Add csfss to common capabilities and the infamous driver matrix...","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6ac37b4c1ed774f1168f2469a92cdc21c9f432f4","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Documentation Impact"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Minimal doc impact.  The devref will be updated to describe the new or"},{"line_number":189,"context_line":"changed standard extra specs."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_d2c176e5","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":29},"in_reply_to":"ba5da102_f08cdddb","updated":"2016-11-03 20:15:24.000000000","message":"Thanks, I\u0027ve used your text verbatim.","commit_id":"fc5c6fe367c20f2806de98dd4dd01f8bec94717e"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"b032853f3ee9461a0eccebe976d90081e3a56f4c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Create share from snapshot extra spec"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/manila/+spec/add-create-share-from-snapshot-extra-spec"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_3626faba","line":11,"updated":"2016-11-07 20:06:58.000000000","message":"Remove this line","commit_id":"0c614509650ba4f7ac8f107ec374a5f5caf3d736"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"b032853f3ee9461a0eccebe976d90081e3a56f4c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"For a long time, manila has had the \u0027snapshot_support\u0027 standard extra spec,"},{"line_number":25,"context_line":"which has been overloaded to mean *two* things:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* a driver can take a snapshot of a share, and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_f63482df","line":24,"updated":"2016-11-07 20:06:58.000000000","message":"s/manila/Manila/","commit_id":"0c614509650ba4f7ac8f107ec374a5f5caf3d736"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"06bcb99c7bf14b574df22d08480029fd3aa78231","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"For a long time, manila has had the \u0027snapshot_support\u0027 standard extra spec,"},{"line_number":25,"context_line":"which has been overloaded to mean *two* things:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* a driver can take a snapshot of a share, and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_39ffcb02","line":24,"in_reply_to":"9a629dbe_f63482df","updated":"2016-11-07 20:28:35.000000000","message":"I personally like to use caps for proper nouns like \u0027Manila\u0027, but the governance docs tell us to do otherwise:\n\nhttps://governance.openstack.org/reference/service-project-naming.html","commit_id":"0c614509650ba4f7ac8f107ec374a5f5caf3d736"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1653efe02d8710c5f20a022f4370b094281e2591","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Data model impact"},{"line_number":92,"context_line":"-----------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* Add create_share_from_snapshot_support field to share table, and copy value"},{"line_number":95,"context_line":"  of snapshot_support to the new create_share_from_snapshot_support field for"},{"line_number":96,"context_line":"  each share."},{"line_number":97,"context_line":"* Add create_share_from_snapshot_support rows to the share_type_extra_specs"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_50d52941","line":94,"updated":"2016-11-08 04:17:56.000000000","message":"Why is it necessary to add create_share_from_snapshot_support field to share table?  A share has a share type and share type has extra specs that already has create_share_from_snapshot_support.","commit_id":"8c936deeed484c8831318aaa57fe4a1bfc352e11"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8924e1d85d5b5a58813f9569347167558fb23ad2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Data model impact"},{"line_number":92,"context_line":"-----------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* Add create_share_from_snapshot_support field to share table, and copy value"},{"line_number":95,"context_line":"  of snapshot_support to the new create_share_from_snapshot_support field for"},{"line_number":96,"context_line":"  each share."},{"line_number":97,"context_line":"* Add create_share_from_snapshot_support rows to the share_type_extra_specs"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_d48cb281","line":94,"in_reply_to":"9a629dbe_3318ad1d","updated":"2016-11-08 14:44:24.000000000","message":"Xing\u0027s question is definitely valid.\n\nA share type may be changed *after* a share of that type is created.  For example, a share type with \"snapshot_support\" \u003d True will cause that share to be placed on a backend that can do snapshots; if the share type is later modified with \"snapshot_support\" \u003d False, the share should still be able to be snapshotted because that was the original contract with the tenant.  Saving the capabilities from the share type on the share object preserves that behavior.","commit_id":"8c936deeed484c8831318aaa57fe4a1bfc352e11"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a824c727de4908a28d6a9b01b0d838627b3bfae5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Data model impact"},{"line_number":92,"context_line":"-----------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* Add create_share_from_snapshot_support field to share table, and copy value"},{"line_number":95,"context_line":"  of snapshot_support to the new create_share_from_snapshot_support field for"},{"line_number":96,"context_line":"  each share."},{"line_number":97,"context_line":"* Add create_share_from_snapshot_support rows to the share_type_extra_specs"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_f0f1ddce","line":94,"in_reply_to":"9a629dbe_50d52941","updated":"2016-11-08 04:19:23.000000000","message":"share types are mutable..","commit_id":"8c936deeed484c8831318aaa57fe4a1bfc352e11"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9d51f26f3607c919f35690fcbbfa7b8f32b07fad","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Data model impact"},{"line_number":92,"context_line":"-----------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* Add create_share_from_snapshot_support field to share table, and copy value"},{"line_number":95,"context_line":"  of snapshot_support to the new create_share_from_snapshot_support field for"},{"line_number":96,"context_line":"  each share."},{"line_number":97,"context_line":"* Add create_share_from_snapshot_support rows to the share_type_extra_specs"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_08960ef0","line":94,"in_reply_to":"9a629dbe_d48cb281","updated":"2016-11-08 15:02:50.000000000","message":"Thanks Clinton.  If we need to create a new field on the shares table to preserve every attribute of a share type, how many fields do we need to create?  I think we should take another look of how share type works (yes, it is inherited from Cinder).  Maybe we should not allow share types to be modified if there are already shares created from them?  Maybe we should introduce a version for share types which allows us to modify them but still preserve previously defined share types?  Something to think about in the future.  Out of scope for this spec.","commit_id":"8c936deeed484c8831318aaa57fe4a1bfc352e11"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3222f23146c9109f9a9e7e471c95036f25427fca","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Data model impact"},{"line_number":92,"context_line":"-----------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* Add create_share_from_snapshot_support field to share table, and copy value"},{"line_number":95,"context_line":"  of snapshot_support to the new create_share_from_snapshot_support field for"},{"line_number":96,"context_line":"  each share."},{"line_number":97,"context_line":"* Add create_share_from_snapshot_support rows to the share_type_extra_specs"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_3318ad1d","line":94,"in_reply_to":"9a629dbe_f0f1ddce","updated":"2016-11-08 12:26:54.000000000","message":"Goutham,\neach valid share always has relation to some share type. It is not mutable from design point of view. Question of Xing is valid and still unanswered.","commit_id":"8c936deeed484c8831318aaa57fe4a1bfc352e11"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1653efe02d8710c5f20a022f4370b094281e2591","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* Default values for snapshot_support are no longer provided. If not specified"},{"line_number":109,"context_line":"  on a share type, snapshot_support and create_share_from_snapshot_support are"},{"line_number":110,"context_line":"  not returned from the share types API for admin contexts.  However, users see"},{"line_number":111,"context_line":"  both values with a nominal value of False so that they know show shares of"},{"line_number":112,"context_line":"  that type will behave."},{"line_number":113,"context_line":"* The value of create_share_from_snapshot_support is checked on a share prior"},{"line_number":114,"context_line":"  to creating a share from a snapshot (else HTTPBadRequest is returned)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_f06c7d9e","line":111,"updated":"2016-11-08 04:17:56.000000000","message":"\"know show\"?  Do you mean \"know how\"?","commit_id":"8c936deeed484c8831318aaa57fe4a1bfc352e11"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8924e1d85d5b5a58813f9569347167558fb23ad2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* Default values for snapshot_support are no longer provided. If not specified"},{"line_number":109,"context_line":"  on a share type, snapshot_support and create_share_from_snapshot_support are"},{"line_number":110,"context_line":"  not returned from the share types API for admin contexts.  However, users see"},{"line_number":111,"context_line":"  both values with a nominal value of False so that they know show shares of"},{"line_number":112,"context_line":"  that type will behave."},{"line_number":113,"context_line":"* The value of create_share_from_snapshot_support is checked on a share prior"},{"line_number":114,"context_line":"  to creating a share from a snapshot (else HTTPBadRequest is returned)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_74e846e3","line":111,"in_reply_to":"9a629dbe_b314bdf5","updated":"2016-11-08 14:44:24.000000000","message":"Fixed.\n\nI\u0027m glad my typos are high-quality ones, such that they lead to mass confusion until fixed. :-)","commit_id":"8c936deeed484c8831318aaa57fe4a1bfc352e11"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3222f23146c9109f9a9e7e471c95036f25427fca","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* Default values for snapshot_support are no longer provided. If not specified"},{"line_number":109,"context_line":"  on a share type, snapshot_support and create_share_from_snapshot_support are"},{"line_number":110,"context_line":"  not returned from the share types API for admin contexts.  However, users see"},{"line_number":111,"context_line":"  both values with a nominal value of False so that they know show shares of"},{"line_number":112,"context_line":"  that type will behave."},{"line_number":113,"context_line":"* The value of create_share_from_snapshot_support is checked on a share prior"},{"line_number":114,"context_line":"  to creating a share from a snapshot (else HTTPBadRequest is returned)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_b314bdf5","line":111,"in_reply_to":"9a629dbe_f06c7d9e","updated":"2016-11-08 12:26:54.000000000","message":"This kind of typo causes confusion. Better to fix it.","commit_id":"8c936deeed484c8831318aaa57fe4a1bfc352e11"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"87675ac95aac379224cad436cbd53b4947cdffab","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Create share from snapshot extra spec"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/manila/+spec/add-create-share-from-snapshot-extra-spec"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a629dbe_683f8ad6","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":44},"updated":"2016-11-08 15:06:04.000000000","message":"Did you mean to put this line back in?","commit_id":"85103654f113bf7067d6675b9d65f42e7bbe6f3c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f1b0961614dac4f0d27c540e7fb415260767618a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Create share from snapshot extra spec"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/manila/+spec/add-create-share-from-snapshot-extra-spec"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a629dbe_2b62ecad","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":44},"in_reply_to":"9a629dbe_683f8ad6","updated":"2016-11-08 15:10:47.000000000","message":"Thanks, Tom  That\u0027s the danger of editing things directly in Gerrit!  Fixed.","commit_id":"85103654f113bf7067d6675b9d65f42e7bbe6f3c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"87675ac95aac379224cad436cbd53b4947cdffab","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  snapshot_support for each type to the new create_share_from_snapshot_support"},{"line_number":64,"context_line":"  extra spec."},{"line_number":65,"context_line":"* Add a database migration to add the new create_share_from_snapshot_support"},{"line_number":66,"context_line":"  capability to the share record, so that Manila has a record of each share\u0027s"},{"line_number":67,"context_line":"  relevant snapshot capability at the time the share was created."},{"line_number":68,"context_line":"* Copy the value of create_share_from_snapshot_support to each share upon"},{"line_number":69,"context_line":"  share creation. If create_share_from_snapshot_support is not present on the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a629dbe_a808c22e","line":66,"range":{"start_line":66,"start_character":42,"end_line":66,"end_character":43},"updated":"2016-11-08 15:06:04.000000000","message":"Did you mean to upcase this?","commit_id":"85103654f113bf7067d6675b9d65f42e7bbe6f3c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f1b0961614dac4f0d27c540e7fb415260767618a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  snapshot_support for each type to the new create_share_from_snapshot_support"},{"line_number":64,"context_line":"  extra spec."},{"line_number":65,"context_line":"* Add a database migration to add the new create_share_from_snapshot_support"},{"line_number":66,"context_line":"  capability to the share record, so that Manila has a record of each share\u0027s"},{"line_number":67,"context_line":"  relevant snapshot capability at the time the share was created."},{"line_number":68,"context_line":"* Copy the value of create_share_from_snapshot_support to each share upon"},{"line_number":69,"context_line":"  share creation. If create_share_from_snapshot_support is not present on the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a629dbe_8b73f87f","line":66,"range":{"start_line":66,"start_character":42,"end_line":66,"end_character":43},"in_reply_to":"9a629dbe_a808c22e","updated":"2016-11-08 15:10:47.000000000","message":"Nope.  Fixed.","commit_id":"85103654f113bf7067d6675b9d65f42e7bbe6f3c"}]}
