)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"de21b26824be8f58b0fb1f715eecf2f87eaa4285","unresolved":false,"context_lines":[{"line_number":14,"context_line":"were, originally, consistency-groups in older than Ocata releases."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So, propose spec with description of new quota resource."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APIImpact"},{"line_number":19,"context_line":"Change-Id: I83be271679df97f681c5419b864b06b7fcbd77bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_1fe5bca8","line":17,"updated":"2017-04-06 22:20:16.000000000","message":"Please reference the blueprint here.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":14,"context_line":"were, originally, consistency-groups in older than Ocata releases."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So, propose spec with description of new quota resource."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APIImpact"},{"line_number":19,"context_line":"Change-Id: I83be271679df97f681c5419b864b06b7fcbd77bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_3c71660d","line":17,"in_reply_to":"bff0334d_1fe5bca8","updated":"2017-04-10 09:43:57.000000000","message":"Done","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"07e5e45d8e51ce4d4ae79dd90763a81d199668d4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add spec for share_groups quota resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila is able to create several different kinds of resources, which use"},{"line_number":10,"context_line":"real back-end resources. Since real resources are always endful, it is"},{"line_number":11,"context_line":"practical to have different kinds of limits/quotas for them."},{"line_number":12,"context_line":"And one of not covered resources by limits is amount of share groups that"},{"line_number":13,"context_line":"user is able to create. Share Groups were added in Ocata timeframe and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bff0334d_b26a0517","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":63},"updated":"2017-04-11 16:50:02.000000000","message":"finite","commit_id":"e2df00aa26754c64be304f202559adb3cd535830"}],"specs/pike/add-share-groups-quota.rst":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"84eef3ba150a072be5f3b8c8a03bcd7fddd48249","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/add-share-groups-quota"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Manila is able to create several different kinds of resources, which use"},{"line_number":14,"context_line":"real back-end resources. Since real resources are always endful, it is"},{"line_number":15,"context_line":"practical to have different kinds of limits/quotas for them."},{"line_number":16,"context_line":"And one of not covered resources by limits is amount of share groups that"},{"line_number":17,"context_line":"user is able to create. Share Groups were added in Ocata timeframe and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_b49908c5","line":14,"range":{"start_line":14,"start_character":57,"end_line":14,"end_character":63},"updated":"2017-04-04 22:14:27.000000000","message":"finite ?","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/add-share-groups-quota"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Manila is able to create several different kinds of resources, which use"},{"line_number":14,"context_line":"real back-end resources. Since real resources are always endful, it is"},{"line_number":15,"context_line":"practical to have different kinds of limits/quotas for them."},{"line_number":16,"context_line":"And one of not covered resources by limits is amount of share groups that"},{"line_number":17,"context_line":"user is able to create. Share Groups were added in Ocata timeframe and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_7c548e53","line":14,"range":{"start_line":14,"start_character":57,"end_line":14,"end_character":63},"in_reply_to":"dfeb2761_b49908c5","updated":"2017-04-10 09:43:57.000000000","message":"Done","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"84eef3ba150a072be5f3b8c8a03bcd7fddd48249","unresolved":false,"context_lines":[{"line_number":23,"context_line":"The problem is in possibility to schedule creation of unlimited amount of"},{"line_number":24,"context_line":"share groups, that can lead to 2 bad things:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* garbaging of DB with any amount of DB table records;"},{"line_number":27,"context_line":"* waste of real back-end resources."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"So, implementation of quotas for share_group resource will solve above"},{"line_number":30,"context_line":"mentioned problems."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_94c4c492","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":35},"updated":"2017-04-04 22:14:27.000000000","message":"I think we need to protect against the first mostly as DOS protection.  The second is also a protection against greedy but not nasty users.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":23,"context_line":"The problem is in possibility to schedule creation of unlimited amount of"},{"line_number":24,"context_line":"share groups, that can lead to 2 bad things:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* garbaging of DB with any amount of DB table records;"},{"line_number":27,"context_line":"* waste of real back-end resources."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"So, implementation of quotas for share_group resource will solve above"},{"line_number":30,"context_line":"mentioned problems."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_3c29669a","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":35},"in_reply_to":"bff0334d_ffa69853","updated":"2017-04-10 09:43:57.000000000","message":"Tom, DOS attacks can be avoided by enabling \"absolute\" limits in config of manila API. But, garbaging of DB cannot be avoided with that mechanism, only quota can do it.\n\nThen, about the need for quota:\n- presence of this mechanism only makes manila more flexible, not adding new restrictions. Quota can be \"unlimited\", so, don\u0027t see any problems here.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"de21b26824be8f58b0fb1f715eecf2f87eaa4285","unresolved":false,"context_lines":[{"line_number":23,"context_line":"The problem is in possibility to schedule creation of unlimited amount of"},{"line_number":24,"context_line":"share groups, that can lead to 2 bad things:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* garbaging of DB with any amount of DB table records;"},{"line_number":27,"context_line":"* waste of real back-end resources."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"So, implementation of quotas for share_group resource will solve above"},{"line_number":30,"context_line":"mentioned problems."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_ffa69853","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":35},"in_reply_to":"dfeb2761_94c4c492","updated":"2017-04-06 22:20:16.000000000","message":"Although I did not like to have quota on groups in Cinder at first, I was told that some backends have a limitation on how many consistency groups can be created.  Not sure if there is such a limitation in share groups, but it is possible.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"84eef3ba150a072be5f3b8c8a03bcd7fddd48249","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implement new quota resource called \"share_groups\" in existing quota mechanism."},{"line_number":42,"context_line":"This quota will track amount of created share groups resources and restrict"},{"line_number":43,"context_line":"creation of them after exceedance of limit."},{"line_number":44,"context_line":"Make default value be equal to amount of shares."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_94496432","line":43,"range":{"start_line":43,"start_character":22,"end_line":43,"end_character":43},"updated":"2017-04-04 22:14:27.000000000","message":"limits are exceeded.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implement new quota resource called \"share_groups\" in existing quota mechanism."},{"line_number":42,"context_line":"This quota will track amount of created share groups resources and restrict"},{"line_number":43,"context_line":"creation of them after exceedance of limit."},{"line_number":44,"context_line":"Make default value be equal to amount of shares."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_7c0c8e40","line":43,"range":{"start_line":43,"start_character":22,"end_line":43,"end_character":43},"in_reply_to":"dfeb2761_94496432","updated":"2017-04-10 09:43:57.000000000","message":"Done","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"84eef3ba150a072be5f3b8c8a03bcd7fddd48249","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Implement new quota resource called \"share_groups\" in existing quota mechanism."},{"line_number":42,"context_line":"This quota will track amount of created share groups resources and restrict"},{"line_number":43,"context_line":"creation of them after exceedance of limit."},{"line_number":44,"context_line":"Make default value be equal to amount of shares."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_146794bf","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":48},"updated":"2017-04-04 22:14:27.000000000","message":"Seems like a high default ?","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Implement new quota resource called \"share_groups\" in existing quota mechanism."},{"line_number":42,"context_line":"This quota will track amount of created share groups resources and restrict"},{"line_number":43,"context_line":"creation of them after exceedance of limit."},{"line_number":44,"context_line":"Make default value be equal to amount of shares."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_02207c9a","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":48},"in_reply_to":"bff0334d_5f0ea43b","updated":"2017-04-10 09:43:57.000000000","message":"Yes, you have some other proposal? I consider this one and \"unlimited\". But, since this one is more restrictive, I would prefer this one.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"de21b26824be8f58b0fb1f715eecf2f87eaa4285","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Implement new quota resource called \"share_groups\" in existing quota mechanism."},{"line_number":42,"context_line":"This quota will track amount of created share groups resources and restrict"},{"line_number":43,"context_line":"creation of them after exceedance of limit."},{"line_number":44,"context_line":"Make default value be equal to amount of shares."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_5f0ea43b","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":48},"in_reply_to":"dfeb2761_146794bf","updated":"2017-04-06 22:20:16.000000000","message":"Do you mean make the default quota for groups the same as the default quota for shares?","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"de21b26824be8f58b0fb1f715eecf2f87eaa4285","unresolved":false,"context_lines":[{"line_number":47,"context_line":"------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Do not implement quotas for share groups. In this case any user will be able"},{"line_number":50,"context_line":"to create unlimited amount of share groups."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Data model impact"},{"line_number":53,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_0218c372","line":50,"updated":"2017-04-06 22:20:16.000000000","message":"They can create unlimited empty share groups, but they won\u0027t be able to add unlimited number of shares to the groups which will be controlled by the quota for shares.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":47,"context_line":"------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Do not implement quotas for share groups. In this case any user will be able"},{"line_number":50,"context_line":"to create unlimited amount of share groups."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Data model impact"},{"line_number":53,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_e2591835","line":50,"in_reply_to":"bff0334d_0218c372","updated":"2017-04-10 09:43:57.000000000","message":"It is obvious and does not contradict commented statement.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"445a82d5c151ff40b6e79aedf4ff59af2d78f45b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"REST API impact"},{"line_number":60,"context_line":"---------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Only one (1) API will be changed it is \"quota-update\". It will be able to"},{"line_number":63,"context_line":"handle one more key provided in POST data, called \"share_groups\"."},{"line_number":64,"context_line":"Also, \"quota-show\" command will return dict with quota resources [and usages]"},{"line_number":65,"context_line":"for this key too. Both these changes require bump of microversion and will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_a3d027cb","line":62,"range":{"start_line":62,"start_character":9,"end_line":62,"end_character":12},"updated":"2017-04-06 03:12:48.000000000","message":"What\u0027s this?","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":59,"context_line":"REST API impact"},{"line_number":60,"context_line":"---------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Only one (1) API will be changed it is \"quota-update\". It will be able to"},{"line_number":63,"context_line":"handle one more key provided in POST data, called \"share_groups\"."},{"line_number":64,"context_line":"Also, \"quota-show\" command will return dict with quota resources [and usages]"},{"line_number":65,"context_line":"for this key too. Both these changes require bump of microversion and will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_227dc07e","line":62,"range":{"start_line":62,"start_character":9,"end_line":62,"end_character":12},"in_reply_to":"bff0334d_a3d027cb","updated":"2017-04-10 09:43:57.000000000","message":"It is anti-typo clarification. Integer variant of previous word.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"84eef3ba150a072be5f3b8c8a03bcd7fddd48249","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Other end user impact"},{"line_number":98,"context_line":"---------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Users will now be restricted in amount of share groups compared to previous"},{"line_number":101,"context_line":"behavior."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Manila client will have additional following optional key to \"quota-update\""},{"line_number":104,"context_line":"command::"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ manila quota-update \u003ctenant_id\u003e --share-groups %amount_as_integer_value%"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Performance Impact"},{"line_number":109,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_74194020","line":106,"range":{"start_line":100,"start_character":0,"end_line":106,"end_character":78},"updated":"2017-04-04 22:14:27.000000000","message":"Maybe just cover what happens if an admin attempts to set this quota and it has already been exceeded.  And what happens if the cloud is upgraded to a new version and more quota groups have been used already then the default value?","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Other end user impact"},{"line_number":98,"context_line":"---------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Users will now be restricted in amount of share groups compared to previous"},{"line_number":101,"context_line":"behavior."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Manila client will have additional following optional key to \"quota-update\""},{"line_number":104,"context_line":"command::"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ manila quota-update \u003ctenant_id\u003e --share-groups %amount_as_integer_value%"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Performance Impact"},{"line_number":109,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_02cabc9f","line":106,"range":{"start_line":100,"start_character":0,"end_line":106,"end_character":78},"in_reply_to":"dfeb2761_74194020","updated":"2017-04-10 09:43:57.000000000","message":"Added comment.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"84eef3ba150a072be5f3b8c8a03bcd7fddd48249","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Performance Impact"},{"line_number":109,"context_line":"------------------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Resource usages will be checked each time we create/delete resources, but"},{"line_number":112,"context_line":"it is relatively cheap operation."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Other deployer impact"},{"line_number":115,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_340738cd","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":33},"updated":"2017-04-04 22:14:27.000000000","message":"Agree.","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"445a82d5c151ff40b6e79aedf4ff59af2d78f45b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"---------------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployers will be able to set quotas for share groups using either"},{"line_number":118,"context_line":"configuration file or \"quota-update\" API. It is optional possibility,"},{"line_number":119,"context_line":"not a mandatory action."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_9e0e98e3","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":18},"updated":"2017-04-06 03:12:48.000000000","message":"How about add the description about what option we will add in configuration file. such as:\n\n# Number of share groups allowed per project. (integer value)\n#quota_groups \u003d 50\nhttps://docs.openstack.org/ocata/config-reference/shared-file-systems/samples/manila.conf.html","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":115,"context_line":"---------------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployers will be able to set quotas for share groups using either"},{"line_number":118,"context_line":"configuration file or \"quota-update\" API. It is optional possibility,"},{"line_number":119,"context_line":"not a mandatory action."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_02263c69","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":18},"in_reply_to":"bff0334d_9e0e98e3","updated":"2017-04-10 09:43:57.000000000","message":"Done","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"445a82d5c151ff40b6e79aedf4ff59af2d78f45b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"* unit tests in \u0027manila\u0027, \u0027python-manilaclient\u0027 and \u0027manila-ui\u0027 projects"},{"line_number":152,"context_line":"* functional tests in \u0027manila\u0027 and \u0027python-manilaclient\u0027 projects"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Documentation Impact"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* admin guide: add new \u0027--share-groups\u0027 parameter to \u0027update-quota\u0027 command."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_dea0a0a8","line":154,"range":{"start_line":154,"start_character":0,"end_line":154,"end_character":20},"updated":"2017-04-06 03:12:48.000000000","message":"How about config-reference?\nhttps://docs.openstack.org/ocata/config-reference/shared-file-systems/samples/manila.conf.html","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"847ef4f65962d6242c2f735d12e944094aab9624","unresolved":false,"context_lines":[{"line_number":151,"context_line":"* unit tests in \u0027manila\u0027, \u0027python-manilaclient\u0027 and \u0027manila-ui\u0027 projects"},{"line_number":152,"context_line":"* functional tests in \u0027manila\u0027 and \u0027python-manilaclient\u0027 projects"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Documentation Impact"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* admin guide: add new \u0027--share-groups\u0027 parameter to \u0027update-quota\u0027 command."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_a268b0b8","line":154,"range":{"start_line":154,"start_character":0,"end_line":154,"end_character":20},"in_reply_to":"bff0334d_dea0a0a8","updated":"2017-04-10 09:43:57.000000000","message":"What about this?","commit_id":"884563dd63bd9c51989f8a58078347ba82dbc7b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"affc2c1528655d10253bb9a911d397618a2b2426","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Only one (1) API will be changed it is \"quota-update\". It will be able to"},{"line_number":63,"context_line":"handle one more key provided in POST data, called \"share_groups\"."},{"line_number":64,"context_line":"Also, \"quota-show\" command will return dict with quota resources [and usages]"},{"line_number":65,"context_line":"for this key too. Both these changes require bump of microversion and will be"},{"line_number":66,"context_line":"available only with this or later one microverisons."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Update quotas"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_582096ac","line":66,"range":{"start_line":65,"start_character":18,"end_line":66,"end_character":52},"updated":"2017-04-11 02:16:47.000000000","message":"With the experimental header?","commit_id":"47da91950972e421c09a6a43b68796d8e31ab983"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"edca5dab956c2714d755bf9bf4a82bf78a5d9448","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Only one (1) API will be changed it is \"quota-update\". It will be able to"},{"line_number":63,"context_line":"handle one more key provided in POST data, called \"share_groups\"."},{"line_number":64,"context_line":"Also, \"quota-show\" command will return dict with quota resources [and usages]"},{"line_number":65,"context_line":"for this key too. Both these changes require bump of microversion and will be"},{"line_number":66,"context_line":"available only with this or later one microverisons."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Update quotas"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_6f8024c0","line":66,"range":{"start_line":65,"start_character":18,"end_line":66,"end_character":52},"in_reply_to":"bff0334d_582096ac","updated":"2017-04-11 11:42:06.000000000","message":"Just following current approach. This spec has nothing to do about \"experimental\" part of API.","commit_id":"47da91950972e421c09a6a43b68796d8e31ab983"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3b13df0278fd8ca4afa465c36024a1acbce529fc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Only one (1) API will be changed it is \"quota-update\". It will be able to"},{"line_number":63,"context_line":"handle one more key provided in POST data, called \"share_groups\"."},{"line_number":64,"context_line":"Also, \"quota-show\" command will return dict with quota resources [and usages]"},{"line_number":65,"context_line":"for this key too. Both these changes require bump of microversion and will be"},{"line_number":66,"context_line":"available only with this or later one microverisons."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Update quotas"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_1c530d19","line":66,"range":{"start_line":65,"start_character":18,"end_line":66,"end_character":52},"in_reply_to":"bff0334d_6a0b727c","updated":"2017-04-11 14:16:55.000000000","message":"Added clarification.","commit_id":"47da91950972e421c09a6a43b68796d8e31ab983"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10d48bf681186c2057c6b0f25d77733cc879ab38","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Only one (1) API will be changed it is \"quota-update\". It will be able to"},{"line_number":63,"context_line":"handle one more key provided in POST data, called \"share_groups\"."},{"line_number":64,"context_line":"Also, \"quota-show\" command will return dict with quota resources [and usages]"},{"line_number":65,"context_line":"for this key too. Both these changes require bump of microversion and will be"},{"line_number":66,"context_line":"available only with this or later one microverisons."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Update quotas"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_6a0b727c","line":66,"range":{"start_line":65,"start_character":18,"end_line":66,"end_character":52},"in_reply_to":"bff0334d_6f8024c0","updated":"2017-04-11 12:16:06.000000000","message":"I\u0027m saying that it should... What\u0027s the behavior promised with and without the header?","commit_id":"47da91950972e421c09a6a43b68796d8e31ab983"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"affc2c1528655d10253bb9a911d397618a2b2426","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        {"},{"line_number":77,"context_line":"          \u0027quotas\u0027: {"},{"line_number":78,"context_line":"            \u0027share_groups\u0027: 100,"},{"line_number":79,"context_line":"          }"},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_18168e56","line":78,"range":{"start_line":78,"start_character":28,"end_line":78,"end_character":31},"updated":"2017-04-11 02:16:47.000000000","message":"what is the default proposed?","commit_id":"47da91950972e421c09a6a43b68796d8e31ab983"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"edca5dab956c2714d755bf9bf4a82bf78a5d9448","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        {"},{"line_number":77,"context_line":"          \u0027quotas\u0027: {"},{"line_number":78,"context_line":"            \u0027share_groups\u0027: 100,"},{"line_number":79,"context_line":"          }"},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_af63cc41","line":78,"range":{"start_line":78,"start_character":28,"end_line":78,"end_character":31},"in_reply_to":"bff0334d_18168e56","updated":"2017-04-11 11:42:06.000000000","message":"Line 44.","commit_id":"47da91950972e421c09a6a43b68796d8e31ab983"}]}