)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f442af6f837ab83f197024af08d74731988cd38","unresolved":false,"context_lines":[{"line_number":10,"context_line":"approved spec:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Update statement about User messages"},{"line_number":13,"context_line":"* Update assignes"},{"line_number":14,"context_line":"* Update error cases when creating a share network"},{"line_number":15,"context_line":"* Fix typo and improved wording"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f7f7fa5a","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":17},"updated":"2018-11-12 23:53:39.000000000","message":"assignees","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"}],"specs/stein/share-network-multiple-subnet.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f442af6f837ab83f197024af08d74731988cd38","unresolved":false,"context_lines":[{"line_number":183,"context_line":"However, if there is more than one subnet associated with the share network,"},{"line_number":184,"context_line":"they would ideally provide an availability zone as well to create it on a"},{"line_number":185,"context_line":"particular subnet (perhaps for co-location purposes with other resources"},{"line_number":186,"context_line":"they care about on their OpenStack cloud), otherwise the ``default``"},{"line_number":187,"context_line":"subnet will be used if it exists, else the API will respond with a"},{"line_number":188,"context_line":"``400 BadRequest``."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"If the user provides a share network and an availability zone to create the"},{"line_number":191,"context_line":"share within, the API will validate that the share network supports that AZ"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b7f18267","line":188,"range":{"start_line":186,"start_character":41,"end_line":188,"end_character":19},"updated":"2018-11-12 23:53:39.000000000","message":"This is what the statement below says","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9346b3d3667c9471bbfbf1a91a9f5dc085728e7b","unresolved":false,"context_lines":[{"line_number":183,"context_line":"However, if there is more than one subnet associated with the share network,"},{"line_number":184,"context_line":"they would ideally provide an availability zone as well to create it on a"},{"line_number":185,"context_line":"particular subnet (perhaps for co-location purposes with other resources"},{"line_number":186,"context_line":"they care about on their OpenStack cloud), otherwise the ``default``"},{"line_number":187,"context_line":"subnet will be used if it exists, else the API will respond with a"},{"line_number":188,"context_line":"``400 BadRequest``."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"If the user provides a share network and an availability zone to create the"},{"line_number":191,"context_line":"share within, the API will validate that the share network supports that AZ"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_cec800a9","line":188,"range":{"start_line":186,"start_character":41,"end_line":188,"end_character":19},"in_reply_to":"3f79a3b5_b7f18267","updated":"2018-11-15 08:54:49.000000000","message":"oh right","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f442af6f837ab83f197024af08d74731988cd38","unresolved":false,"context_lines":[{"line_number":252,"context_line":"exactly one share network and one availability zone."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"The ``manila.db.sqlalchemy.models.ShareServer`` model will stop having a"},{"line_number":255,"context_line":"foreign key binding to ``share_network_id`` and switch to having a nullable"},{"line_number":256,"context_line":"foreign key reference to ``share_network_subnet_id`` instead."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"No key changes are going to be made to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_d77f5ebb","line":255,"range":{"start_line":255,"start_character":67,"end_line":255,"end_character":75},"updated":"2018-11-12 23:53:39.000000000","message":"? what circumstance will you want to NULL this field?","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9346b3d3667c9471bbfbf1a91a9f5dc085728e7b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"exactly one share network and one availability zone."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"The ``manila.db.sqlalchemy.models.ShareServer`` model will stop having a"},{"line_number":255,"context_line":"foreign key binding to ``share_network_id`` and switch to having a nullable"},{"line_number":256,"context_line":"foreign key reference to ``share_network_subnet_id`` instead."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"No key changes are going to be made to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4eb4f01d","line":255,"range":{"start_line":255,"start_character":67,"end_line":255,"end_character":75},"in_reply_to":"3f79a3b5_d77f5ebb","updated":"2018-11-15 08:54:49.000000000","message":"oops, it is not here. Thanks.","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f442af6f837ab83f197024af08d74731988cd38","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":"We will asynchronously validate the network information during share creation,"},{"line_number":585,"context_line":"and if there is a mismatch with what is specified in the configured network"},{"line_number":586,"context_line":"plugin, we will send an error user message."},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"Other end user impact"},{"line_number":589,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_9777a6d3","line":586,"range":{"start_line":586,"start_character":16,"end_line":586,"end_character":20},"updated":"2018-11-12 23:53:39.000000000","message":"raise/record","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9346b3d3667c9471bbfbf1a91a9f5dc085728e7b","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":"We will asynchronously validate the network information during share creation,"},{"line_number":585,"context_line":"and if there is a mismatch with what is specified in the configured network"},{"line_number":586,"context_line":"plugin, we will send an error user message."},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"Other end user impact"},{"line_number":589,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_8eba080a","line":586,"range":{"start_line":586,"start_character":16,"end_line":586,"end_character":20},"in_reply_to":"3f79a3b5_9777a6d3","updated":"2018-11-15 08:54:49.000000000","message":"Done","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f442af6f837ab83f197024af08d74731988cd38","unresolved":false,"context_lines":[{"line_number":619,"context_line":"  availability_zone_hints. Deployers must ensure that neutron services are"},{"line_number":620,"context_line":"  running in the desired availability_zones to allow for the network creation"},{"line_number":621,"context_line":"  to succeed."},{"line_number":622,"context_line":"* All existing share networks will have its subnet (if existing) designated"},{"line_number":623,"context_line":"  as ``default`` after the database upgrade to this version of the"},{"line_number":624,"context_line":"  database changes."},{"line_number":625,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_d7567e2d","line":622,"range":{"start_line":622,"start_character":40,"end_line":622,"end_character":43},"updated":"2018-11-12 23:53:39.000000000","message":"their","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9346b3d3667c9471bbfbf1a91a9f5dc085728e7b","unresolved":false,"context_lines":[{"line_number":619,"context_line":"  availability_zone_hints. Deployers must ensure that neutron services are"},{"line_number":620,"context_line":"  running in the desired availability_zones to allow for the network creation"},{"line_number":621,"context_line":"  to succeed."},{"line_number":622,"context_line":"* All existing share networks will have its subnet (if existing) designated"},{"line_number":623,"context_line":"  as ``default`` after the database upgrade to this version of the"},{"line_number":624,"context_line":"  database changes."},{"line_number":625,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_2eb73425","line":622,"range":{"start_line":622,"start_character":40,"end_line":622,"end_character":43},"in_reply_to":"3f79a3b5_d7567e2d","updated":"2018-11-15 08:54:49.000000000","message":"Done","commit_id":"50833ad35a0b575b027641b743b4ac08acbb03dd"}]}