)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"237eada208d55ed648f5d7e707f0e223faed1833","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Felipe Rodrigues \u003cfelipefuty01@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-16 13:28:50 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for multiple subnet share servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes changes to Manila with the purpose of"},{"line_number":10,"context_line":"addressing the need for having share servers with network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"27d3917b_28b2f52f","line":7,"updated":"2021-12-20 16:41:42.000000000","message":"suggestion: add spec for adding multiple subnet share networks to a same share server","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"237eada208d55ed648f5d7e707f0e223faed1833","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for multiple subnet share servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes changes to Manila with the purpose of"},{"line_number":10,"context_line":"addressing the need for having share servers with network"},{"line_number":11,"context_line":"allocations on multiple subnets."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"cecc9a61_14b50ba1","line":9,"updated":"2021-12-20 16:41:42.000000000","message":"IIRC we already implemented it for subnets in different AZs. That spec could be mentioned here so it would be clear we are talking about extending it to subnets in a same AZ.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"237eada208d55ed648f5d7e707f0e223faed1833","unresolved":true,"context_lines":[{"line_number":13,"context_line":"The spec is splitted in three phases, targeting to more"},{"line_number":14,"context_line":"than one release:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. Multiple subnets in same network and IPv4 only (yoga release)"},{"line_number":17,"context_line":"2. Multiple subnets in same network and IPv4/IPv6"},{"line_number":18,"context_line":"3. Multiple subnets different network and IPv4/IPv6"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"53984073_7d40ee26","line":16,"updated":"2021-12-20 16:41:42.000000000","message":"suggestion:\n1. Multiple IPv4 subnets in a same network (Targeted to Yoga release)\n2. Multiple IPv6 subnets in a same network\n3. Multiple IPv4/IPv6 subnets in different networks","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"237eada208d55ed648f5d7e707f0e223faed1833","unresolved":true,"context_lines":[{"line_number":20,"context_line":"This patch also renames the spec release directory name"},{"line_number":21,"context_line":"\"release_independent\" to \"\"multi-release\"."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implements: bp multiple-subnet-share-servers"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e84efae5_fb4855f8","line":23,"updated":"2021-12-20 16:41:42.000000000","message":"I couldn\u0027t find that blueprint in launchpad but created a new one for it\n\nhttps://blueprints.launchpad.net/manila/+spec/multiple-share-network-subnets","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"f1592b6738a7a4e0d22a70a3362e1d19b958a4df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4afdc522_d495d5db","updated":"2021-12-17 11:57:37.000000000","message":"Good job, LGTM!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"74707640_08c62e7b","updated":"2021-12-20 14:02:15.000000000","message":"Hi Felipe, thank you for the effort to write this spec. I added only a few comments with suggestions and also some questions.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"237eada208d55ed648f5d7e707f0e223faed1833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"43ea9d80_07befbbb","updated":"2021-12-20 16:41:42.000000000","message":"I\u0027m wondering if using git move would keep previous history of\nspecs/multi-release/share-server-multiple-subnet.rst\n","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c6e6b1f6_2941207a","updated":"2021-12-23 04:20:49.000000000","message":"Thank you Carlos and Fernando to review it. Uploaded a new patch set fixing some comments. Repling\nothers. Please, review again.","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9c95d075_d56056c6","updated":"2021-12-21 14:23:32.000000000","message":"Thank you Nahim, angiolucci, Andre and Fernando! I uplodaded a new patchset\naddressing your comments. See the replies.","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"206c0ad9_a03b7aa4","updated":"2021-12-21 21:37:57.000000000","message":"Thanks for updating this change, Felipe!\nPlease check the questions and concerns inline :)","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4b6ca5a2_442e3011","updated":"2021-12-23 19:15:07.000000000","message":"Thank you for reviving this change, Felipe. I\u0027ve added a few comments inline, please take a look!","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"163817cc_771b4a00","updated":"2021-12-28 17:15:27.000000000","message":"Thanks all for reviewing! Please, see comments.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"daa3730c539a8ffd2d795a6b1d898f8736728d15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3e38824d_60c577cd","updated":"2021-12-23 19:54:52.000000000","message":"Thanks for updating this spec Felipe. Please, take a look on some comments regarding alternative solutions. Thanks!","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4085822b_7a2528cb","updated":"2022-01-06 01:19:35.000000000","message":"Awesome, no major disagreements. just a bunch of suggestions. Thanks for your updates on this spec Felipe!","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d037d1e6_f7030df2","updated":"2022-01-06 23:14:46.000000000","message":"Thank you all! See the replies, the next patch will address the points.","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"515f79ba2b0297b5bc77a130fe3ec113513e510f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8355d995_32e62d20","updated":"2022-01-06 20:25:57.000000000","message":"Thanks for providing this spec, Felipe! I left some comments, mostly nitpicks, but the change LGTM overall.","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"70f37bb5_2aa03f32","updated":"2022-01-04 18:41:12.000000000","message":"Thanks for the updates, Felipe! Followed up on some discussions. Please check the answers inline","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47466fcd5115d698d30018a3b0c6166f32b26ab2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"22a7004a_9d0b072a","updated":"2022-01-12 15:52:31.000000000","message":"Lets get this in and discuss further in code reviews..Thanks Felipe!","commit_id":"1e968b3e6b66df1caa2847be88d8049f5dbe70f0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4f2d64200c6c9321eb93e5e8451ea80153ea502d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"08f3c73d_7c57f2ac","updated":"2022-01-07 12:22:23.000000000","message":"Thanks for updating this spec Felipe. Don\u0027t see any point that we can\u0027t further discuss during the reviews. Looks good to me.","commit_id":"1e968b3e6b66df1caa2847be88d8049f5dbe70f0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9400eebff86b1c718c84c538d1f2c9dbb5daec01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d777019e_096655e4","updated":"2022-01-07 12:00:34.000000000","message":"Thanks for working through the comments, Felipe.\nGood job!","commit_id":"1e968b3e6b66df1caa2847be88d8049f5dbe70f0"}],"doc/source/index.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":12,"context_line":".. toctree::"},{"line_number":13,"context_line":"   :glob:"},{"line_number":14,"context_line":"   :maxdepth: 1"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"   specs/multi-release/*"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Xena approved specs"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ffa9df6a_780b8293","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":24},"updated":"2021-12-23 19:15:07.000000000","message":"we\u0027ll need to add redirects as well for this rename... i would suggest putting up a .htaccess file to do this. Example here: https://opendev.org/openstack/cinder-specs/src/branch/master/doc/source/_extra/.htaccess","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":12,"context_line":".. toctree::"},{"line_number":13,"context_line":"   :glob:"},{"line_number":14,"context_line":"   :maxdepth: 1"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"   specs/multi-release/*"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Xena approved specs"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"15053338_71797924","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":24},"in_reply_to":"a2e43e53_12db8cf0","updated":"2022-01-06 23:14:46.000000000","message":"agree, I\u0027ll keep it as before.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":true,"context_lines":[{"line_number":12,"context_line":".. toctree::"},{"line_number":13,"context_line":"   :glob:"},{"line_number":14,"context_line":"   :maxdepth: 1"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"   specs/multi-release/*"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Xena approved specs"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"a2e43e53_12db8cf0","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":24},"in_reply_to":"ffa9df6a_780b8293","updated":"2022-01-06 01:19:35.000000000","message":"Pinging on this again, i suggest we split the renaming and the redirecting into a separate patch.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"}],"specs/multi-release/share-server-multiple-subnet.rst":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"37a3ab740ae8bd0737e7a75e66fe836b6ba479e4","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/multiple-subnet-share-servers"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes changes to Manila with the purpose of addressing the need"},{"line_number":14,"context_line":"for having share servers with network allocations on multiple subnets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"13ca3a35_fe690470","line":14,"updated":"2021-12-20 19:26:55.000000000","message":"Does it worth to mention it comprehends multiple subnets in a same AZ?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/multiple-subnet-share-servers"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes changes to Manila with the purpose of addressing the need"},{"line_number":14,"context_line":"for having share servers with network allocations on multiple subnets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d10ef185_12898663","line":14,"in_reply_to":"13ca3a35_fe690470","updated":"2021-12-21 14:23:32.000000000","message":"done!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/multiple-subnet-share-servers"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes changes to Manila with the purpose of addressing the need"},{"line_number":14,"context_line":"for having share servers with network allocations on multiple subnets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8a2603c0_40eb7cf7","line":14,"in_reply_to":"d10ef185_12898663","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":24,"context_line":"some limitations became apparent, namely that a share server could not serve"},{"line_number":25,"context_line":"shares with IPv4 and IPv6 export locations at the same time."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."}],"source_content_type":"text/x-rst","patch_set":8,"id":"95a69e38_3a87198a","line":28,"range":{"start_line":27,"start_character":68,"end_line":28,"end_character":62},"updated":"2021-12-20 14:02:15.000000000","message":"Hi Felipe, a small concern about this phrase. I suppose you mean that the equipment will need to support both IP versions. However, when you said \"connectivity in both address families\", can be interpreted as IPv4 communicating with IPv6 which is not possible.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"some limitations became apparent, namely that a share server could not serve"},{"line_number":25,"context_line":"shares with IPv4 and IPv6 export locations at the same time."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."}],"source_content_type":"text/x-rst","patch_set":8,"id":"95b80294_ecd15e24","line":28,"range":{"start_line":27,"start_character":68,"end_line":28,"end_character":62},"in_reply_to":"29c86c3f_75a4294b","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"37a3ab740ae8bd0737e7a75e66fe836b6ba479e4","unresolved":true,"context_lines":[{"line_number":24,"context_line":"some limitations became apparent, namely that a share server could not serve"},{"line_number":25,"context_line":"shares with IPv4 and IPv6 export locations at the same time."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ef69c6d8_9de0d9fc","line":28,"range":{"start_line":27,"start_character":68,"end_line":28,"end_character":62},"in_reply_to":"95a69e38_3a87198a","updated":"2021-12-20 19:26:55.000000000","message":"Hi Andre, I believe Felipe meant to say that nowadays is common to have environments with IPs in both address families.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":24,"context_line":"some limitations became apparent, namely that a share server could not serve"},{"line_number":25,"context_line":"shares with IPv4 and IPv6 export locations at the same time."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."}],"source_content_type":"text/x-rst","patch_set":8,"id":"29c86c3f_75a4294b","line":28,"range":{"start_line":27,"start_character":68,"end_line":28,"end_character":62},"in_reply_to":"ef69c6d8_9de0d9fc","updated":"2021-12-21 21:37:57.000000000","message":"Fernando +1 :)","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":24,"context_line":"some limitations became apparent, namely that a share server could not serve"},{"line_number":25,"context_line":"shares with IPv4 and IPv6 export locations at the same time."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."}],"source_content_type":"text/x-rst","patch_set":8,"id":"c03527f3_a21c91a8","line":28,"range":{"start_line":27,"start_character":68,"end_line":28,"end_character":62},"in_reply_to":"ef69c6d8_9de0d9fc","updated":"2021-12-21 14:23:32.000000000","message":"Yeah, that\u0027s what ganso meant Fernando (it was not written by me). At least from my view, what he wrote is not ambiguous, \"in both\" does not mean \"between both\".","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Manila drivers implement support for share servers by receiving a list of"}],"source_content_type":"text/x-rst","patch_set":8,"id":"828a5645_2cf76f76","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":72},"updated":"2021-12-20 14:02:15.000000000","message":"I can understand what you said with \"address families\" but in my opinion will be better to refer as \"IP versions (IPv4 or IPv6)\". Only a suggestion.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"fcc872e39271aa57c07f682e906b5915019b54b7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Manila drivers implement support for share servers by receiving a list of"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fc7e83e4_d8767e4c","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":72},"in_reply_to":"828a5645_2cf76f76","updated":"2021-12-20 20:03:06.000000000","message":"I Don\u0027t know but address families seems fine to me. Maybe he could just make it more explicit? \nsomething like: \"from both IPv4 and IPv6 address families\"","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Manila drivers implement support for share servers by receiving a list of"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f21f3b8c_f51fdfaa","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":72},"in_reply_to":"cb53093b_cfbd32ac","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":27,"context_line":"In a world that has transitioning infrastructure from IPv4 to IPv6, it is no"},{"line_number":28,"context_line":"longer unusual to expect connectivity in both address families. The fundamental"},{"line_number":29,"context_line":"concept of file services is to have data shared across multiple hosts, thus it"},{"line_number":30,"context_line":"is sensible to expect shares to be accessible from both address families"},{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Manila drivers implement support for share servers by receiving a list of"}],"source_content_type":"text/x-rst","patch_set":8,"id":"cb53093b_cfbd32ac","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":72},"in_reply_to":"fc7e83e4_d8767e4c","updated":"2021-12-21 14:23:32.000000000","message":"done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Manila drivers implement support for share servers by receiving a list of"},{"line_number":34,"context_line":"network allocations that the back end should create. The amount of network"},{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"}],"source_content_type":"text/x-rst","patch_set":8,"id":"2c3732c6_2f4e70ae","line":36,"range":{"start_line":34,"start_character":53,"end_line":36,"end_character":66},"updated":"2021-12-20 14:02:15.000000000","message":"Hi Felipe, this phrase is a little bit confused in my opinion. You mean that: the network information will be retrieved from Neutron, and the drivers will be responsible for reporting the number of networks supported, once each driver has different values for that. That is it?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Manila drivers implement support for share servers by receiving a list of"},{"line_number":34,"context_line":"network allocations that the back end should create. The amount of network"},{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f70c76a1_6a840ddf","line":36,"range":{"start_line":34,"start_character":53,"end_line":36,"end_character":66},"in_reply_to":"2c3732c6_2f4e70ae","updated":"2021-12-21 21:37:57.000000000","message":"I think this statement covers nicely what the current process is. Manila will ask the drivers how many addresses the driver will need to set up the share server. When the driver answers the amount, then Manila will ask neutron to allocate that exact amount of addresses.\nFor example the NetApp driver: it will check how many nodes are there in the cluster and will request one interface for each one of the nodes, and when that is answered to Manila, it will ask neutron to provide x amount of interfaces.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Manila drivers implement support for share servers by receiving a list of"},{"line_number":34,"context_line":"network allocations that the back end should create. The amount of network"},{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d02bef82_4da85102","line":36,"range":{"start_line":34,"start_character":53,"end_line":36,"end_character":66},"in_reply_to":"2c3732c6_2f4e70ae","updated":"2021-12-21 14:23:32.000000000","message":"No Andre, there is no \"will\" sentence. This sentence is just explaining how manila works, see: \"Manila drivers implement\", \"each driver reports\" and so on.. all senteces are \"present\", no \"future\" or proposing something.\n\nIt is exlained the driver interface \"get_network_allocations_number\". That\u0027s how Manila works!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"simultaneously as well, as storage back ends are capable of accomplishing that."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Manila drivers implement support for share servers by receiving a list of"},{"line_number":34,"context_line":"network allocations that the back end should create. The amount of network"},{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1cc87343_9a816706","line":36,"range":{"start_line":34,"start_character":53,"end_line":36,"end_character":66},"in_reply_to":"f70c76a1_6a840ddf","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."}],"source_content_type":"text/x-rst","patch_set":8,"id":"0a5f31b7_6c173c23","line":38,"range":{"start_line":38,"start_character":26,"end_line":38,"end_character":31},"updated":"2021-12-20 14:02:15.000000000","message":"nit: and?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7d6519ea_b9a2c273","line":38,"range":{"start_line":38,"start_character":26,"end_line":38,"end_character":31},"in_reply_to":"0a5f31b7_6c173c23","updated":"2021-12-21 14:23:32.000000000","message":"done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."}],"source_content_type":"text/x-rst","patch_set":8,"id":"84c48c0d_d6511247","line":38,"range":{"start_line":38,"start_character":26,"end_line":38,"end_character":31},"in_reply_to":"7d6519ea_b9a2c273","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"96f7f647_671fbaf3","line":39,"range":{"start_line":39,"start_character":48,"end_line":39,"end_character":55},"updated":"2021-12-21 21:37:57.000000000","message":"\"a subnet\"? We are still currently supporting only one subnet to be attached to the share server","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"171d4777_87d627b5","line":39,"range":{"start_line":38,"start_character":65,"end_line":39,"end_character":56},"updated":"2021-12-21 21:37:57.000000000","message":"A share network was associated with neutron network and subnets even before the implementation of [1]... What changed since [1] is: A share server is associated with a share network subnet, which now withholds information of neutron. So in [1], the neutron fields were removed from share networks to share network subnets.\nA suggestion to this paragraph would be:\nPrior to the implementation of `[1]_`, the share network entity held information from Neutron networks and subnets, and Manila referred to its data when trying to dynamically allocate addresses.\nSince the implementation of `[1]_`, the share network entity was modified to do not hold Neutron information, it was instead modified to span multiple share network subnets in different availability zones. Since then, share servers are created and associated with a single share network subnet, which contains neutron network and subnet information.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7cdf4ab4_7d3f4ab8","line":39,"range":{"start_line":38,"start_character":65,"end_line":39,"end_character":56},"in_reply_to":"08934edb_6fa5351e","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":35,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"08934edb_6fa5351e","line":39,"range":{"start_line":38,"start_character":65,"end_line":39,"end_character":56},"in_reply_to":"171d4777_87d627b5","updated":"2021-12-23 04:20:49.000000000","message":"ack, done!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"c54f0d35_5f054530","line":39,"range":{"start_line":39,"start_character":48,"end_line":39,"end_character":55},"in_reply_to":"54bdd686_5c6e8742","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":36,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Share servers are created while associated with a share network, which since"},{"line_number":39,"context_line":"`[1]`_ is associated with a neutron network and subnets. Association of neutron"},{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"54bdd686_5c6e8742","line":39,"range":{"start_line":39,"start_character":48,"end_line":39,"end_character":55},"in_reply_to":"96f7f647_671fbaf3","updated":"2021-12-23 04:20:49.000000000","message":"ack, done!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"}],"source_content_type":"text/x-rst","patch_set":8,"id":"afbaf246_2a12aedd","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":15},"updated":"2021-12-21 21:37:57.000000000","message":"share network subnet?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"}],"source_content_type":"text/x-rst","patch_set":8,"id":"202fe6b5_6b39bfd6","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":15},"in_reply_to":"94154989_3c0ceedb","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":40,"context_line":"subnets is restricted to one per availability zone (AZ), therefore a share"},{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"}],"source_content_type":"text/x-rst","patch_set":8,"id":"94154989_3c0ceedb","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":15},"in_reply_to":"afbaf246_2a12aedd","updated":"2021-12-23 04:20:49.000000000","message":"ack, done!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"},{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"}],"source_content_type":"text/x-rst","patch_set":8,"id":"192c6403_fbda5fcd","line":45,"range":{"start_line":44,"start_character":48,"end_line":45,"end_character":78},"updated":"2021-12-21 21:37:57.000000000","message":"IMHO this is kind of repeating what was already said in the paragraph above, so I think this could be removed","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"},{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fbb68726_a8e07aff","line":45,"range":{"start_line":44,"start_character":48,"end_line":45,"end_character":78},"in_reply_to":"192c6403_fbda5fcd","updated":"2021-12-23 04:20:49.000000000","message":"Agree, done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"server will always create their network allocations in only one subnet."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"},{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"}],"source_content_type":"text/x-rst","patch_set":8,"id":"55059abc_a12f779f","line":45,"range":{"start_line":44,"start_character":48,"end_line":45,"end_character":78},"in_reply_to":"fbb68726_a8e07aff","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"},{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"},{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0b06b469_bc15cb9e","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":10},"updated":"2021-12-20 14:02:15.000000000","message":"nit: Therefore,","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"},{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"},{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"}],"source_content_type":"text/x-rst","patch_set":8,"id":"34b14de4_7d8a7584","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":10},"in_reply_to":"0b06b469_bc15cb9e","updated":"2021-12-23 04:20:49.000000000","message":"done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"A share network is created by the cloud-user and its neutron network and subnet"},{"line_number":44,"context_line":"associations are also defined at creation time. Share networks were originally"},{"line_number":45,"context_line":"designed allowing association with only one neutron subnet (regardless of AZ)."},{"line_number":46,"context_line":"Therefore no driver implementation was required to handle more than one. The"},{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"},{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f9c4cf03_0625263f","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":10},"in_reply_to":"34b14de4_7d8a7584","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"},{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"}],"source_content_type":"text/x-rst","patch_set":8,"id":"25b13f17_e40eee60","line":50,"range":{"start_line":50,"start_character":14,"end_line":50,"end_character":30},"updated":"2021-12-20 14:02:15.000000000","message":"nit: IP versions. If you choose to change this term.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"},{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"}],"source_content_type":"text/x-rst","patch_set":8,"id":"2a52d9d4_827a573a","line":50,"range":{"start_line":50,"start_character":14,"end_line":50,"end_character":30},"in_reply_to":"168256c7_25a80be3","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":47,"context_line":"result is that, if more than the expected amount of allocations are provided,"},{"line_number":48,"context_line":"all drivers as currently implemented would fail to handle the additional"},{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"}],"source_content_type":"text/x-rst","patch_set":8,"id":"168256c7_25a80be3","line":50,"range":{"start_line":50,"start_character":14,"end_line":50,"end_character":30},"in_reply_to":"25b13f17_e40eee60","updated":"2021-12-21 14:23:32.000000000","message":"done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"},{"line_number":54,"context_line":"subnet associations still cannot be changed, which could result in scenarios"},{"line_number":55,"context_line":"where users end up creating subnets to just serve shares, while resources"}],"source_content_type":"text/x-rst","patch_set":8,"id":"2f1ff743_f878e5e5","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":79},"updated":"2021-12-20 14:02:15.000000000","message":"I not recall if the share network will be changed in this operation or will be only updated with new share network information (e.g. security service info). Because, if it\u0027s the second option you can replace the highlighted to \"to update the share network and share server information\", otherwise, you can ignore this comment.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"},{"line_number":54,"context_line":"subnet associations still cannot be changed, which could result in scenarios"},{"line_number":55,"context_line":"where users end up creating subnets to just serve shares, while resources"}],"source_content_type":"text/x-rst","patch_set":8,"id":"46772bc0_c6bab704","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":28},"updated":"2021-12-21 21:37:57.000000000","message":"nit: Since the implementation of `[2]_`,","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"},{"line_number":54,"context_line":"subnet associations still cannot be changed, which could result in scenarios"},{"line_number":55,"context_line":"where users end up creating subnets to just serve shares, while resources"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9169fda2_a8d8becc","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":79},"in_reply_to":"1733c7a3_960d5b59","updated":"2021-12-23 04:20:49.000000000","message":"done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"},{"line_number":54,"context_line":"subnet associations still cannot be changed, which could result in scenarios"},{"line_number":55,"context_line":"where users end up creating subnets to just serve shares, while resources"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1733c7a3_960d5b59","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":79},"in_reply_to":"2f1ff743_f878e5e5","updated":"2021-12-21 21:37:57.000000000","message":"We can\u0027t actually change the share network of a share server, we can only modify the security services for a given share network.\nA suggestion for the phrase would be:\nManila has the ability to change the share networks\u0027 security services even if such networks were being used by share servers.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"},{"line_number":54,"context_line":"subnet associations still cannot be changed, which could result in scenarios"},{"line_number":55,"context_line":"where users end up creating subnets to just serve shares, while resources"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5811205b_4be0cc05","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":79},"in_reply_to":"2f1ff743_f878e5e5","updated":"2021-12-21 14:23:32.000000000","message":"agree, done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"},{"line_number":54,"context_line":"subnet associations still cannot be changed, which could result in scenarios"},{"line_number":55,"context_line":"where users end up creating subnets to just serve shares, while resources"}],"source_content_type":"text/x-rst","patch_set":8,"id":"04f7529b_90641969","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":28},"in_reply_to":"42d0a3fd_bada9d61","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"},{"line_number":54,"context_line":"subnet associations still cannot be changed, which could result in scenarios"},{"line_number":55,"context_line":"where users end up creating subnets to just serve shares, while resources"}],"source_content_type":"text/x-rst","patch_set":8,"id":"42d0a3fd_bada9d61","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":28},"in_reply_to":"46772bc0_c6bab704","updated":"2021-12-23 04:20:49.000000000","message":"done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"allocations, which would be needed to meet the requirements for serving a"},{"line_number":50,"context_line":"share in both address families."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Since the `[2]`_ change, the Manila has the ability to change the share network"},{"line_number":53,"context_line":"and its share servers, but only for the security service configuration. The"},{"line_number":54,"context_line":"subnet associations still cannot be changed, which could result in scenarios"},{"line_number":55,"context_line":"where users end up creating subnets to just serve shares, while resources"}],"source_content_type":"text/x-rst","patch_set":8,"id":"88cd95b8_2bc33de3","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":79},"in_reply_to":"9169fda2_a8d8becc","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":65,"context_line":"* Ability to serve shares with both IPv4 and IPv6 export locations"},{"line_number":66,"context_line":"  simultaneously."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Ability to serve shares in multiple different subnets. In an overloaded"},{"line_number":69,"context_line":"  environment, the Neutron subnet may be running out of IPs (to assign to"},{"line_number":70,"context_line":"  clients), requiring a new subnet to client access, instead of:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"042a8e74_90f52f5b","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":48},"updated":"2021-12-20 14:02:15.000000000","message":"nit: I think this is redundant.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"fcc872e39271aa57c07f682e906b5915019b54b7","unresolved":true,"context_lines":[{"line_number":65,"context_line":"* Ability to serve shares with both IPv4 and IPv6 export locations"},{"line_number":66,"context_line":"  simultaneously."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Ability to serve shares in multiple different subnets. In an overloaded"},{"line_number":69,"context_line":"  environment, the Neutron subnet may be running out of IPs (to assign to"},{"line_number":70,"context_line":"  clients), requiring a new subnet to client access, instead of:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"626a9eab_6c3e0a22","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":48},"in_reply_to":"042a8e74_90f52f5b","updated":"2021-12-20 20:03:06.000000000","message":"agree","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"* Ability to serve shares with both IPv4 and IPv6 export locations"},{"line_number":66,"context_line":"  simultaneously."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Ability to serve shares in multiple different subnets. In an overloaded"},{"line_number":69,"context_line":"  environment, the Neutron subnet may be running out of IPs (to assign to"},{"line_number":70,"context_line":"  clients), requiring a new subnet to client access, instead of:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"14e8e4f4_86175261","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":48},"in_reply_to":"0c23b101_50cc2673","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":65,"context_line":"* Ability to serve shares with both IPv4 and IPv6 export locations"},{"line_number":66,"context_line":"  simultaneously."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Ability to serve shares in multiple different subnets. In an overloaded"},{"line_number":69,"context_line":"  environment, the Neutron subnet may be running out of IPs (to assign to"},{"line_number":70,"context_line":"  clients), requiring a new subnet to client access, instead of:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"0c23b101_50cc2673","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":48},"in_reply_to":"626a9eab_6c3e0a22","updated":"2021-12-21 14:23:32.000000000","message":"done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":34304,"name":"Vinicius Reis","display_name":"angiolucci","email":"angiolucci@gmail.com","username":"angiolucci"},"change_message_id":"3f885f10b701fced54978fe2ffac4b0ebac8a866","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  * Having to route data between them."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ec7ca983_6d91c9ab","line":75,"updated":"2021-12-17 13:52:35.000000000","message":"Hi, is \u0027share serves\u0027 a typo? Did you mean \u0027servers\u0027 instead of \u0027serves\u0027 ?\nThanks!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  * Having to route data between them."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."}],"source_content_type":"text/x-rst","patch_set":8,"id":"4544f7b4_53e68aa3","line":75,"in_reply_to":"132faad2_290485ae","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  * Having to route data between them."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."}],"source_content_type":"text/x-rst","patch_set":8,"id":"132faad2_290485ae","line":75,"in_reply_to":"ec7ca983_6d91c9ab","updated":"2021-12-21 21:37:57.000000000","message":"+1","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  * Having to route data between them."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."}],"source_content_type":"text/x-rst","patch_set":8,"id":"8adcb2fb_ed4830a0","line":75,"in_reply_to":"ec7ca983_6d91c9ab","updated":"2021-12-21 14:23:32.000000000","message":"thks, done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"74dc7ec7_e4894444","line":77,"range":{"start_line":77,"start_character":41,"end_line":77,"end_character":53},"updated":"2021-12-21 21:37:57.000000000","message":"share servers\nI was thinking about this and removing share network neutron subnet allocations will possibly be very disruptive...  Should we really allow share networks subnets to be removed when we know there are share servers using it?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"c9b64575_cc3be3a5","line":77,"range":{"start_line":77,"start_character":41,"end_line":77,"end_character":53},"in_reply_to":"35639baf_d42a8055","updated":"2022-01-04 18:41:12.000000000","message":"Maybe with the use of an argument called --force... For example: if you try to remove a consumed one without --force, then the operation would fail","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9400eebff86b1c718c84c538d1f2c9dbb5daec01","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"d1646e9a_096ae3e5","line":77,"range":{"start_line":77,"start_character":41,"end_line":77,"end_character":53},"in_reply_to":"423ff7a4_398c7fbb","updated":"2022-01-07 12:00:34.000000000","message":"\u003e A minimal solution in my opinion is to only allow removing share subnets that are not in-use\n+1\nYeah, sounds good... But dunno if there´s need to a lite spec for that. We can discuss it when the time comes :)","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"35639baf_d42a8055","line":77,"range":{"start_line":77,"start_character":41,"end_line":77,"end_character":53},"in_reply_to":"74dc7ec7_e4894444","updated":"2021-12-23 04:20:49.000000000","message":"That\u0027s a good concern, I think if you have the ability to add, you should have the ability to remove. I totally agree with you that this operation should be used with care. At same time, what if the admin add a subnet to an existent share sevrver wrongly ?! should he/she be able to undo the operation ?! \n\nActually, adding a new subnet might not be disruptive in some scenarios. Example:\n\nTime 0: share S1 is created, causing the creation of share server SS1 in a subnet \u003cSUB\u003e, with IP X\nTime 1: share S2 is created in the same share server SS1\nTime 2: user A has the IP Y in the same subnet \u003cSUB\u003e connecting to share S1\nTime 3: user B  cannot connect to share S2 because the subnet \u003cSUB\u003e has no more IPs to be assigned to him.\nTime 4: add a new subnet \u003cSUB_2\u003e to the share server. \nTime 5: Ops, \u003cSUB_2\u003e has been wrongly configured. So, let\u0027s remove it and add the correct one.\n\nThe remove operation in the \"time 5\" won\u0027t cause any disruption, since the connected users are using the other subnet.\n\nTherefore, the remove subnets MAY cause a disruption, depending on the setup, It\u0027s up to the user taking the risk. The point is, how should we mitigate misremove ?!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"423ff7a4_398c7fbb","line":77,"range":{"start_line":77,"start_character":41,"end_line":77,"end_character":53},"in_reply_to":"8defb948_859b8135","updated":"2022-01-06 23:14:46.000000000","message":"So, we could keep as the update security service, only implementing the update by \"adding\". The update remove part, if requested, will be addressed by a light spec later. This way, if the admin wants to remove a subnet, the share net must have no allocations on it (not in-use state).","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"4f8f7d0015b8c536bfde02ff2cbf36b415c84e5f","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"8defb948_859b8135","line":77,"range":{"start_line":77,"start_character":41,"end_line":77,"end_character":53},"in_reply_to":"c9b64575_cc3be3a5","updated":"2022-01-06 18:26:57.000000000","message":"What is the behavior when we try to delete a subnet that have Nova instances attached to it? I need to confirm but my guess is that the behavior for deleting in-use subnets in Neutron is to deny the operation in case there are ports created from it, and leave to the cloud operator the responsibility to manually delete any ports associated to the subnet. A minimal solution in my opinion is to only allow removing share subnets that are not in-use, and may be cover the possibility of including a force flag in a separate light spec after we proper identify the use case.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"625f4a7ab9f95d4d936a3a439adc35fbd397f026","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"8842cfa9_27a377bb","line":77,"range":{"start_line":77,"start_character":41,"end_line":77,"end_character":53},"in_reply_to":"d1646e9a_096ae3e5","updated":"2022-01-07 12:07:15.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f16a8ef3_ac43885e","line":78,"range":{"start_line":77,"start_character":0,"end_line":78,"end_character":44},"updated":"2021-12-20 14:02:15.000000000","message":"With in-use share networks in this case? Or whatever?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ce2351c3_1b798115","line":78,"range":{"start_line":77,"start_character":0,"end_line":78,"end_character":44},"in_reply_to":"90d84a21_8fc68a64","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  * Having to create one share network for each subnet, which will result in"},{"line_number":75,"context_line":"    spawning new share serves each with their own shares."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Update network allocations of existing share server by adding or removing"},{"line_number":78,"context_line":"  share network neutron subnet associations."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"90d84a21_8fc68a64","line":78,"range":{"start_line":77,"start_character":0,"end_line":78,"end_character":44},"in_reply_to":"f16a8ef3_ac43885e","updated":"2021-12-21 14:23:32.000000000","message":"If it is an existent share server, the share network is in-use","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."}],"source_content_type":"text/x-rst","patch_set":8,"id":"511b3ca8_f19127a3","line":86,"range":{"start_line":86,"start_character":6,"end_line":86,"end_character":42},"updated":"2021-12-21 21:37:57.000000000","message":"maybe: share_server_supports_multiple_subnets?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."}],"source_content_type":"text/x-rst","patch_set":8,"id":"d9993520_65474a53","line":86,"range":{"start_line":86,"start_character":6,"end_line":86,"end_character":42},"in_reply_to":"511b3ca8_f19127a3","updated":"2021-12-23 04:20:49.000000000","message":"agree, done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."}],"source_content_type":"text/x-rst","patch_set":8,"id":"4ae0ad07_2bd44de8","line":86,"range":{"start_line":86,"start_character":6,"end_line":86,"end_character":42},"in_reply_to":"d9993520_65474a53","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f6013e6_1d89a436","line":87,"range":{"start_line":87,"start_character":31,"end_line":87,"end_character":59},"updated":"2021-12-21 21:37:57.000000000","message":"setup_multiple_subnets_for_share_server?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"c4937d0f_4388a199","line":87,"range":{"start_line":87,"start_character":31,"end_line":87,"end_character":59},"in_reply_to":"3f6013e6_1d89a436","updated":"2021-12-23 04:20:49.000000000","message":"Please, see the discussion with Fernando. We are pending to remove this new interface, only changing the existent \"setup_server\" interface passing the \"netwok_info\" param with the subnets.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ebce501_4a47bd60","line":87,"range":{"start_line":87,"start_character":31,"end_line":87,"end_character":59},"in_reply_to":"c4937d0f_4388a199","updated":"2022-01-04 18:41:12.000000000","message":"Ack","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The purpose of the new capability is so that the scheduler can determine the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8780b1cd_ab714f3f","line":88,"range":{"start_line":87,"start_character":70,"end_line":88,"end_character":45},"updated":"2021-12-21 21:37:57.000000000","message":"the driver should set it to ``True``?\nwith  \"automatically\" I imagine this being as a default when a driver implements a feature.\nBut if \"automatically\" means that the driver must report a new capability (as it is for security_service_update_support), I think we should rather say that drivers must report it than say it is automatic.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The purpose of the new capability is so that the scheduler can determine the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"22b2f471_3a45cca1","line":88,"range":{"start_line":87,"start_character":70,"end_line":88,"end_character":45},"in_reply_to":"0d0ad634_1f6f02b4","updated":"2022-01-04 18:41:12.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The purpose of the new capability is so that the scheduler can determine the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"db3cbcb1_5dfb4061","line":88,"range":{"start_line":87,"start_character":70,"end_line":88,"end_character":45},"in_reply_to":"8780b1cd_ab714f3f","updated":"2021-12-23 04:20:49.000000000","message":"I think the original idea was to check the driver implementation of the interface, if it is implemented, it would report it as `True`, otherwise `False`. The driver would not report anything, just implementing the interface. So, the check would be done for all drivers.\n\nI think that we could follow the update security service approach, forcing the driver to report this capability, instead of doing it automatically checking the interface implementation.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The purpose of the new capability is so that the scheduler can determine the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0d0ad634_1f6f02b4","line":88,"range":{"start_line":87,"start_character":70,"end_line":88,"end_character":45},"in_reply_to":"aa5aaf41_bc57743b","updated":"2021-12-28 17:15:27.000000000","message":"agree, done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"daa3730c539a8ffd2d795a6b1d898f8736728d15","unresolved":true,"context_lines":[{"line_number":84,"context_line":"A new boolean driver capability will be introduced:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* **``multiple_subnet_share_server_support``**: determines whether the driver"},{"line_number":87,"context_line":"  implements a new interface ``setup_multiple_subnet_server``. If so, this"},{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The purpose of the new capability is so that the scheduler can determine the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"aa5aaf41_bc57743b","line":88,"range":{"start_line":87,"start_character":70,"end_line":88,"end_character":45},"in_reply_to":"db3cbcb1_5dfb4061","updated":"2021-12-23 19:54:52.000000000","message":"I think that we usually let the driver provide that information, it is easy to maintain, easier to enable/disable a specific feature.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The purpose of the new capability is so that the scheduler can determine the"},{"line_number":92,"context_line":"proper back end when creating new shares in share networks that already have"},{"line_number":93,"context_line":"more than one subnet per AZ."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Another new driver interface will be introduced named"},{"line_number":96,"context_line":"``update_share_server_network_allocations`` so that drivers can update share"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8e12ded1_bcb912ab","line":93,"range":{"start_line":91,"start_character":0,"end_line":93,"end_character":28},"updated":"2021-12-21 21:37:57.000000000","message":"In case there aren\u0027t back ends that can hold multiple subnets and a share network that contains multiple subnets was provided, the creation wouldn\u0027t fail, right?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The purpose of the new capability is so that the scheduler can determine the"},{"line_number":92,"context_line":"proper back end when creating new shares in share networks that already have"},{"line_number":93,"context_line":"more than one subnet per AZ."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Another new driver interface will be introduced named"},{"line_number":96,"context_line":"``update_share_server_network_allocations`` so that drivers can update share"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d5c77430_05c9ae86","line":93,"range":{"start_line":91,"start_character":0,"end_line":93,"end_character":28},"in_reply_to":"7d8c3d1a_9c63f4d3","updated":"2022-01-04 18:41:12.000000000","message":"I see, thanks","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":88,"context_line":"  capability is automatically set to ``True``. Otherwise, the value"},{"line_number":89,"context_line":"  is ``False``."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The purpose of the new capability is so that the scheduler can determine the"},{"line_number":92,"context_line":"proper back end when creating new shares in share networks that already have"},{"line_number":93,"context_line":"more than one subnet per AZ."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Another new driver interface will be introduced named"},{"line_number":96,"context_line":"``update_share_server_network_allocations`` so that drivers can update share"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7d8c3d1a_9c63f4d3","line":93,"range":{"start_line":91,"start_character":0,"end_line":93,"end_character":28},"in_reply_to":"8e12ded1_bcb912ab","updated":"2021-12-23 04:20:49.000000000","message":"Sorry, didn\u0027t get your point.\n\nI think that ganso mentioned here that the capability would be used to check which backend can hold the share. If the share\u0027s share network contains more than one subnet per AZ, only back ends that have the capability as \"True\" would be considered.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":96,"context_line":"``update_share_server_network_allocations`` so that drivers can update share"},{"line_number":97,"context_line":"server network allocations whenever neutron subnets are added or removed from"},{"line_number":98,"context_line":"share networks. Also, the interface must return the new share\u0027s export"},{"line_number":99,"context_line":"locations, since they may change together with share server subnet change."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"A new boolean column ``network_allocation_update_support`` will be added to the"},{"line_number":102,"context_line":"share server model to distinguish existing share servers that can support this"}],"source_content_type":"text/x-rst","patch_set":8,"id":"675ee4d8_83be7cb4","line":99,"range":{"start_line":99,"start_character":22,"end_line":99,"end_character":25},"updated":"2021-12-21 21:37:57.000000000","message":"will...\nIf a new subnet is being added, for sure a new allocation would be consumed, and if another one is removed, for sure an allocation would be withdrawn, so in both cases we have at least one change in the export locations, right?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"``update_share_server_network_allocations`` so that drivers can update share"},{"line_number":97,"context_line":"server network allocations whenever neutron subnets are added or removed from"},{"line_number":98,"context_line":"share networks. Also, the interface must return the new share\u0027s export"},{"line_number":99,"context_line":"locations, since they may change together with share server subnet change."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"A new boolean column ``network_allocation_update_support`` will be added to the"},{"line_number":102,"context_line":"share server model to distinguish existing share servers that can support this"}],"source_content_type":"text/x-rst","patch_set":8,"id":"4cdbd1e9_f3f1a9f5","line":99,"range":{"start_line":99,"start_character":22,"end_line":99,"end_character":25},"in_reply_to":"168ba56c_34272552","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":96,"context_line":"``update_share_server_network_allocations`` so that drivers can update share"},{"line_number":97,"context_line":"server network allocations whenever neutron subnets are added or removed from"},{"line_number":98,"context_line":"share networks. Also, the interface must return the new share\u0027s export"},{"line_number":99,"context_line":"locations, since they may change together with share server subnet change."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"A new boolean column ``network_allocation_update_support`` will be added to the"},{"line_number":102,"context_line":"share server model to distinguish existing share servers that can support this"}],"source_content_type":"text/x-rst","patch_set":8,"id":"168ba56c_34272552","line":99,"range":{"start_line":99,"start_character":22,"end_line":99,"end_character":25},"in_reply_to":"675ee4d8_83be7cb4","updated":"2021-12-23 04:20:49.000000000","message":"Right! Fixed","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"A new boolean column ``network_allocation_update_support`` will be added to the"},{"line_number":102,"context_line":"share server model to distinguish existing share servers that can support this"},{"line_number":103,"context_line":"functionality."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The workflows affected by this proposal are:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"94cab001_2fefe074","line":103,"updated":"2021-12-21 21:37:57.000000000","message":"Will the current share servers default this new column to false?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"A new boolean column ``network_allocation_update_support`` will be added to the"},{"line_number":102,"context_line":"share server model to distinguish existing share servers that can support this"},{"line_number":103,"context_line":"functionality."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The workflows affected by this proposal are:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"e022c88a_58ba9e0a","line":103,"in_reply_to":"94cab001_2fefe074","updated":"2021-12-23 04:20:49.000000000","message":"Yeah, `False` as default in the database upgrade. See \"Data model Impact\" section.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"A new boolean column ``network_allocation_update_support`` will be added to the"},{"line_number":102,"context_line":"share server model to distinguish existing share servers that can support this"},{"line_number":103,"context_line":"functionality."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The workflows affected by this proposal are:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7c8dc308_ebbb36fa","line":103,"in_reply_to":"e022c88a_58ba9e0a","updated":"2022-01-04 18:41:12.000000000","message":"Ack","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The workflows affected by this proposal are:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* When adding neutron subnets to existing share networks that results in more"},{"line_number":108,"context_line":"  than one subnet per AZ (or more than one ``default`` subnet), the restriction"},{"line_number":109,"context_line":"  of one subnet per AZ will only exist if there are any existing associated"},{"line_number":110,"context_line":"  share servers that have ``network_allocation_update_support`` field set to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8c1eb1cf_8ef872c4","line":107,"range":{"start_line":107,"start_character":14,"end_line":107,"end_character":29},"updated":"2021-12-21 21:37:57.000000000","message":"Could be: share network subnets with different neutron networks or subnets?\nSince you will not be adding neutron networks directly, you\u0027ll be creating new share network subnets","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The workflows affected by this proposal are:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* When adding neutron subnets to existing share networks that results in more"},{"line_number":108,"context_line":"  than one subnet per AZ (or more than one ``default`` subnet), the restriction"},{"line_number":109,"context_line":"  of one subnet per AZ will only exist if there are any existing associated"},{"line_number":110,"context_line":"  share servers that have ``network_allocation_update_support`` field set to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b3e3c8bf_65d81860","line":107,"range":{"start_line":107,"start_character":14,"end_line":107,"end_character":29},"in_reply_to":"8c1eb1cf_8ef872c4","updated":"2021-12-23 04:20:49.000000000","message":"agree, done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The workflows affected by this proposal are:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* When adding neutron subnets to existing share networks that results in more"},{"line_number":108,"context_line":"  than one subnet per AZ (or more than one ``default`` subnet), the restriction"},{"line_number":109,"context_line":"  of one subnet per AZ will only exist if there are any existing associated"},{"line_number":110,"context_line":"  share servers that have ``network_allocation_update_support`` field set to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f925c39b_797400a5","line":107,"range":{"start_line":107,"start_character":14,"end_line":107,"end_character":29},"in_reply_to":"b3e3c8bf_65d81860","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  case, the request will result in ``No valid host`` scheduling error."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":121,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"},{"line_number":122,"context_line":"share servers to be created on empty multiple subnet share networks, but the"},{"line_number":123,"context_line":"share network will not be allowed to have subnets added or removed. If the"},{"line_number":124,"context_line":"share network is not empty, the scheduler will ensure the back end is not a"},{"line_number":125,"context_line":"valid candidate."}],"source_content_type":"text/x-rst","patch_set":8,"id":"0aaa8a3b_7a01cb31","line":122,"range":{"start_line":121,"start_character":55,"end_line":122,"end_character":67},"updated":"2021-12-21 21:37:57.000000000","message":"is there a reason to force the subnets to be empty? What would be the prolem to have the networking set up but only not allowing it to be removed or new interfaces to be added?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  case, the request will result in ``No valid host`` scheduling error."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":121,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"},{"line_number":122,"context_line":"share servers to be created on empty multiple subnet share networks, but the"},{"line_number":123,"context_line":"share network will not be allowed to have subnets added or removed. If the"},{"line_number":124,"context_line":"share network is not empty, the scheduler will ensure the back end is not a"},{"line_number":125,"context_line":"valid candidate."}],"source_content_type":"text/x-rst","patch_set":8,"id":"6279ed33_aaa3c3d1","line":122,"range":{"start_line":121,"start_character":55,"end_line":122,"end_character":67},"in_reply_to":"0aaa8a3b_7a01cb31","updated":"2021-12-23 04:20:49.000000000","message":"The points here are:\n\n1. Drivers could only implement multiple subnets on creation time, not updating them. \n2. The scheduler would guarantee that the driver support multiple subnets on creation time.\n3. The check of updating support is done by scheduler. Actually, I think we could do in the share API layer, though.\n\nWhat do you think ?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  case, the request will result in ``No valid host`` scheduling error."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":121,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"},{"line_number":122,"context_line":"share servers to be created on empty multiple subnet share networks, but the"},{"line_number":123,"context_line":"share network will not be allowed to have subnets added or removed. If the"},{"line_number":124,"context_line":"share network is not empty, the scheduler will ensure the back end is not a"},{"line_number":125,"context_line":"valid candidate."}],"source_content_type":"text/x-rst","patch_set":8,"id":"8f757f9c_2570b13f","line":122,"range":{"start_line":121,"start_character":55,"end_line":122,"end_character":67},"in_reply_to":"6279ed33_aaa3c3d1","updated":"2022-01-04 18:41:12.000000000","message":"Yeah, the points you said makes sense... I\u0027m curious on what \"empty multiple subnet share network\" means though... For example: does it mean that the share networks can\u0027t contain a neutron net/subnet on it and should consume allocations in a different way?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  case, the request will result in ``No valid host`` scheduling error."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":121,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"},{"line_number":122,"context_line":"share servers to be created on empty multiple subnet share networks, but the"},{"line_number":123,"context_line":"share network will not be allowed to have subnets added or removed. If the"},{"line_number":124,"context_line":"share network is not empty, the scheduler will ensure the back end is not a"},{"line_number":125,"context_line":"valid candidate."}],"source_content_type":"text/x-rst","patch_set":8,"id":"a53f2804_03908ffa","line":122,"range":{"start_line":121,"start_character":55,"end_line":122,"end_character":67},"in_reply_to":"8f757f9c_2570b13f","updated":"2022-01-06 23:14:46.000000000","message":"I changed this paragraph as goutham has suggested, please, check it.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":131,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":134,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":135,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":136,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7be9af8b_128ae0d7","line":134,"range":{"start_line":134,"start_character":2,"end_line":134,"end_character":33},"updated":"2021-12-21 21:37:57.000000000","message":"this wasn\u0027t mentioned above, with the capabilities that were mentioned :) \ncould you please add a mention to it?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":134,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":135,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":136,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"574582fb_f543af37","line":134,"range":{"start_line":134,"start_character":2,"end_line":134,"end_character":33},"in_reply_to":"5d593fc6_23508e24","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":131,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":134,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":135,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":136,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5d593fc6_23508e24","line":134,"range":{"start_line":134,"start_character":2,"end_line":134,"end_character":33},"in_reply_to":"7be9af8b_128ae0d7","updated":"2021-12-23 04:20:49.000000000","message":"ops, updated.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":138,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":139,"context_line":"later releases, after the ``network_allocation_update_support`` field has"},{"line_number":140,"context_line":"already been set to either ``True`` or ``False``, the share server\u0027s"},{"line_number":141,"context_line":"``network_allocation_update_support`` will need to be reset using the"},{"line_number":142,"context_line":"``manila-manage`` tool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Share network updates can be an one-to-many operation, which might trigger"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5d046a16_6f6da788","line":141,"range":{"start_line":141,"start_character":37,"end_line":141,"end_character":38},"updated":"2021-12-21 21:37:57.000000000","message":"field","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":139,"context_line":"later releases, after the ``network_allocation_update_support`` field has"},{"line_number":140,"context_line":"already been set to either ``True`` or ``False``, the share server\u0027s"},{"line_number":141,"context_line":"``network_allocation_update_support`` will need to be reset using the"},{"line_number":142,"context_line":"``manila-manage`` tool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Share network updates can be an one-to-many operation, which might trigger"}],"source_content_type":"text/x-rst","patch_set":8,"id":"4d8902f4_5b56fe31","line":141,"range":{"start_line":141,"start_character":37,"end_line":141,"end_character":38},"in_reply_to":"01b54469_ae6bd0e3","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":138,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":139,"context_line":"later releases, after the ``network_allocation_update_support`` field has"},{"line_number":140,"context_line":"already been set to either ``True`` or ``False``, the share server\u0027s"},{"line_number":141,"context_line":"``network_allocation_update_support`` will need to be reset using the"},{"line_number":142,"context_line":"``manila-manage`` tool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Share network updates can be an one-to-many operation, which might trigger"}],"source_content_type":"text/x-rst","patch_set":8,"id":"01b54469_ae6bd0e3","line":141,"range":{"start_line":141,"start_character":37,"end_line":141,"end_character":38},"in_reply_to":"5d046a16_6f6da788","updated":"2021-12-23 04:20:49.000000000","message":"done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":139,"context_line":"later releases, after the ``network_allocation_update_support`` field has"},{"line_number":140,"context_line":"already been set to either ``True`` or ``False``, the share server\u0027s"},{"line_number":141,"context_line":"``network_allocation_update_support`` will need to be reset using the"},{"line_number":142,"context_line":"``manila-manage`` tool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Share network updates can be an one-to-many operation, which might trigger"},{"line_number":145,"context_line":"multiple share server updates, for different back ends in different share"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3bb03cc2_681f5b10","line":142,"range":{"start_line":142,"start_character":18,"end_line":142,"end_character":23},"updated":"2021-12-21 21:37:57.000000000","message":"is a new command being introduced to that? Or currently there is another one that can be reused?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":139,"context_line":"later releases, after the ``network_allocation_update_support`` field has"},{"line_number":140,"context_line":"already been set to either ``True`` or ``False``, the share server\u0027s"},{"line_number":141,"context_line":"``network_allocation_update_support`` will need to be reset using the"},{"line_number":142,"context_line":"``manila-manage`` tool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Share network updates can be an one-to-many operation, which might trigger"},{"line_number":145,"context_line":"multiple share server updates, for different back ends in different share"}],"source_content_type":"text/x-rst","patch_set":8,"id":"6c0139b2_5f9b8533","line":142,"range":{"start_line":142,"start_character":18,"end_line":142,"end_character":23},"in_reply_to":"3bb03cc2_681f5b10","updated":"2021-12-23 04:20:49.000000000","message":"new command, see https://specs.openstack.org/openstack/manila-specs/specs/wallaby/security-service-updates-in-use-share-network.html#manila-manage","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"daa3730c539a8ffd2d795a6b1d898f8736728d15","unresolved":true,"context_lines":[{"line_number":139,"context_line":"later releases, after the ``network_allocation_update_support`` field has"},{"line_number":140,"context_line":"already been set to either ``True`` or ``False``, the share server\u0027s"},{"line_number":141,"context_line":"``network_allocation_update_support`` will need to be reset using the"},{"line_number":142,"context_line":"``manila-manage`` tool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Share network updates can be an one-to-many operation, which might trigger"},{"line_number":145,"context_line":"multiple share server updates, for different back ends in different share"}],"source_content_type":"text/x-rst","patch_set":8,"id":"986d3736_2d579c96","line":142,"range":{"start_line":142,"start_character":18,"end_line":142,"end_character":23},"in_reply_to":"6c0139b2_5f9b8533","updated":"2021-12-23 19:54:52.000000000","message":"iirc, you can use the command implemented, you will just need to add the new capability to it. But it is a implementation detail.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":139,"context_line":"later releases, after the ``network_allocation_update_support`` field has"},{"line_number":140,"context_line":"already been set to either ``True`` or ``False``, the share server\u0027s"},{"line_number":141,"context_line":"``network_allocation_update_support`` will need to be reset using the"},{"line_number":142,"context_line":"``manila-manage`` tool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Share network updates can be an one-to-many operation, which might trigger"},{"line_number":145,"context_line":"multiple share server updates, for different back ends in different share"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c8e4b27d_eaca8252","line":142,"range":{"start_line":142,"start_character":18,"end_line":142,"end_character":23},"in_reply_to":"986d3736_2d579c96","updated":"2021-12-28 17:15:27.000000000","message":"nice, thanks.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"later releases, after the ``network_allocation_update_support`` field has"},{"line_number":140,"context_line":"already been set to either ``True`` or ``False``, the share server\u0027s"},{"line_number":141,"context_line":"``network_allocation_update_support`` will need to be reset using the"},{"line_number":142,"context_line":"``manila-manage`` tool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Share network updates can be an one-to-many operation, which might trigger"},{"line_number":145,"context_line":"multiple share server updates, for different back ends in different share"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0201f729_e3a33c51","line":142,"range":{"start_line":142,"start_character":18,"end_line":142,"end_character":23},"in_reply_to":"c8e4b27d_eaca8252","updated":"2022-01-04 18:41:12.000000000","message":"Ack","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If the ``setup_multiple_subnet_server`` fails to configure the server for one"},{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"e363441c_2f1bd910","line":154,"range":{"start_line":153,"start_character":51,"end_line":154,"end_character":63},"updated":"2021-12-21 21:37:57.000000000","message":"I think we have a tricky scenario here... If you are adding a new subnet and it fails, is it going to cause a disruption? We possibly should collect more opinions on this matter, but it won\u0027t possibly cause any harm, differently from the removal operation. So I understand the reasoning to want to set it to error, but I don\u0027t think the entire share server will be errored out and the clients won\u0027t be able to access it.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4f2d64200c6c9321eb93e5e8451ea80153ea502d","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If the ``setup_multiple_subnet_server`` fails to configure the server for one"},{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a362736_cdc04278","line":154,"range":{"start_line":153,"start_character":51,"end_line":154,"end_character":63},"in_reply_to":"04826114_f040f008","updated":"2022-01-07 12:22:23.000000000","message":"Sorry, my last comment wans\u0027t so clear. But, from pov, at least share server and access rules should be in error state. At the end, share network will be always Active and updated with the new network association, so will never be sent to error. But if the driver raises an error on SN updates, you don\u0027t known if the share server final state is aligned with the current share network configuration, so sending it to error, will force admin to check that.\nNot sure if access rules are easily recovered from Error state, so one option is to set the affected share instances to error too. Which will make admin validate them and reset their status. But this is something that we can further discuss, with the implementation. Thanks!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If the ``setup_multiple_subnet_server`` fails to configure the server for one"},{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"896d374e_fe3ef4f5","line":154,"range":{"start_line":153,"start_character":51,"end_line":154,"end_character":63},"in_reply_to":"757e3eae_a4c42aa7","updated":"2021-12-28 17:15:27.000000000","message":"Douglas, what do you mean by \"everything to erro\" ?! Does it mean \"share server\", \"share network\", \"shares instances\" and \"acess rules\" ?!\n\nI think we could keep the same approach as the security service update for three reasons:\n\n\n1. Keeping the same approach for both settings network update, so the user does not have different behavior for same type of operations\n2. As douglas mentioned, error on update requires an admin manual check the state of everything before reset-status of the resources\n3. The code strategy follows the same pattern in both update operations","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ebffb3926b6f7d4c3a0d283b9085011df88a22f1","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If the ``setup_multiple_subnet_server`` fails to configure the server for one"},{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"f46f6a22_affb8c1f","line":154,"range":{"start_line":153,"start_character":51,"end_line":154,"end_character":63},"in_reply_to":"757e3eae_a4c42aa7","updated":"2021-12-28 15:01:23.000000000","message":"I believe we should at least expect a few exceptions in manager coming from the driver like invalid configuration to avoid always moving the state to error. A driver might initially check for thinks like support to IPv6 and max subnets allowed and return a proper exception to the manager in case something can\u0027t be done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If the ``setup_multiple_subnet_server`` fails to configure the server for one"},{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"04826114_f040f008","line":154,"range":{"start_line":153,"start_character":51,"end_line":154,"end_character":63},"in_reply_to":"78661ce5_ca480796","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"daa3730c539a8ffd2d795a6b1d898f8736728d15","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If the ``setup_multiple_subnet_server`` fails to configure the server for one"},{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"757e3eae_a4c42aa7","line":154,"range":{"start_line":153,"start_character":51,"end_line":154,"end_character":63},"in_reply_to":"7e8716a3_275517d4","updated":"2021-12-23 19:54:52.000000000","message":"I think that the right thing is to move everything to error. We had some discussions about that in the past. If the driver raises an error, we don\u0027t have any idea of the current status of its resources at storage level. If you don\u0027t set to error, new shares may land and fail to be configured on it. Error state will make admin check if everything is ok with the share server before triggering a reset-status operation. The share network will be updated and active again, but this associated share server will not be in sync with share network`s config.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If the ``setup_multiple_subnet_server`` fails to configure the server for one"},{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"78661ce5_ca480796","line":154,"range":{"start_line":153,"start_character":51,"end_line":154,"end_character":63},"in_reply_to":"896d374e_fe3ef4f5","updated":"2022-01-04 18:41:12.000000000","message":"Yeah, if we are to follow this pattern of moving everything to error, makes sense to move the access rules, share network and share server to error... And there would be more complexity to implement two different approaches for add and remove, so I\u0027m okay with erroring out these resources.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"If the ``setup_multiple_subnet_server`` fails to configure the server for one"},{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7e8716a3_275517d4","line":154,"range":{"start_line":153,"start_character":51,"end_line":154,"end_character":63},"in_reply_to":"e363441c_2f1bd910","updated":"2021-12-23 04:20:49.000000000","message":"makes sense. It only failed to set the new interface, the previous ones still working normally. So, nothing will go to error state, right ?\n\nThat\u0027s tricky!","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"daa3730c539a8ffd2d795a6b1d898f8736728d15","unresolved":true,"context_lines":[{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Manila Manage"},{"line_number":159,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ad82cdfe_8871c92d","line":156,"range":{"start_line":155,"start_character":62,"end_line":156,"end_character":64},"updated":"2021-12-23 19:54:52.000000000","message":"share network will be active and its resources will be updated (subnets added/removed)","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Manila Manage"},{"line_number":159,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b49add30_21141398","line":156,"range":{"start_line":155,"start_character":62,"end_line":156,"end_character":64},"in_reply_to":"ad82cdfe_8871c92d","updated":"2021-12-28 17:15:27.000000000","message":"done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":153,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":154,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":155,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":156,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Manila Manage"},{"line_number":159,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"25f3f000_9ae89b77","line":156,"range":{"start_line":155,"start_character":62,"end_line":156,"end_character":64},"in_reply_to":"b49add30_21141398","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":175,"context_line":"Data model impact"},{"line_number":176,"context_line":"-----------------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"A new ``network_allocation_update_support`` capability field will be added to"},{"line_number":179,"context_line":"``manila.db.sqlalchemy.models.ShareServer`` indicating if the driver and the"},{"line_number":180,"context_line":"back end where this share server resides support the update multiple subnet per"},{"line_number":181,"context_line":"AZ operations. In database migration upgrade, the new column will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"036fa2c7_eea48995","line":178,"range":{"start_line":178,"start_character":44,"end_line":178,"end_character":60},"updated":"2021-12-21 21:37:57.000000000","message":"column","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":175,"context_line":"Data model impact"},{"line_number":176,"context_line":"-----------------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"A new ``network_allocation_update_support`` capability field will be added to"},{"line_number":179,"context_line":"``manila.db.sqlalchemy.models.ShareServer`` indicating if the driver and the"},{"line_number":180,"context_line":"back end where this share server resides support the update multiple subnet per"},{"line_number":181,"context_line":"AZ operations. In database migration upgrade, the new column will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7bef65f7_1ade1724","line":178,"range":{"start_line":178,"start_character":44,"end_line":178,"end_character":60},"in_reply_to":"036fa2c7_eea48995","updated":"2021-12-23 04:20:49.000000000","message":"done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"Data model impact"},{"line_number":176,"context_line":"-----------------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"A new ``network_allocation_update_support`` capability field will be added to"},{"line_number":179,"context_line":"``manila.db.sqlalchemy.models.ShareServer`` indicating if the driver and the"},{"line_number":180,"context_line":"back end where this share server resides support the update multiple subnet per"},{"line_number":181,"context_line":"AZ operations. In database migration upgrade, the new column will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"aec6580c_daa4c65c","line":178,"range":{"start_line":178,"start_character":44,"end_line":178,"end_character":60},"in_reply_to":"7bef65f7_1ade1724","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":212,"context_line":"There are no new API introduced, but the changes to the existing APIs will be"},{"line_number":213,"context_line":"microversioned. Namely:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* **Displaying a share server**: after the microversion bump, the share server"},{"line_number":216,"context_line":"  view will include the field ``network_allocation_update_support``. Also, the"},{"line_number":217,"context_line":"  ``share_network_subnet_id`` will be a list of IDs."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* **Adding a neutron subnet to a share network**: after the microversion bump,"},{"line_number":220,"context_line":"  this API will no longer always return an error when the operation result"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d54a0f35_1db1c220","line":217,"range":{"start_line":215,"start_character":0,"end_line":217,"end_character":52},"updated":"2021-12-20 14:02:15.000000000","message":"The share_network_subnet_id will be not removed from share server view?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":212,"context_line":"There are no new API introduced, but the changes to the existing APIs will be"},{"line_number":213,"context_line":"microversioned. Namely:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* **Displaying a share server**: after the microversion bump, the share server"},{"line_number":216,"context_line":"  view will include the field ``network_allocation_update_support``. Also, the"},{"line_number":217,"context_line":"  ``share_network_subnet_id`` will be a list of IDs."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* **Adding a neutron subnet to a share network**: after the microversion bump,"},{"line_number":220,"context_line":"  this API will no longer always return an error when the operation result"}],"source_content_type":"text/x-rst","patch_set":8,"id":"e39a404e_5b53f91e","line":217,"range":{"start_line":215,"start_character":0,"end_line":217,"end_character":52},"in_reply_to":"a62c5a05_b1a93e71","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":212,"context_line":"There are no new API introduced, but the changes to the existing APIs will be"},{"line_number":213,"context_line":"microversioned. Namely:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* **Displaying a share server**: after the microversion bump, the share server"},{"line_number":216,"context_line":"  view will include the field ``network_allocation_update_support``. Also, the"},{"line_number":217,"context_line":"  ``share_network_subnet_id`` will be a list of IDs."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* **Adding a neutron subnet to a share network**: after the microversion bump,"},{"line_number":220,"context_line":"  this API will no longer always return an error when the operation result"}],"source_content_type":"text/x-rst","patch_set":8,"id":"a62c5a05_b1a93e71","line":217,"range":{"start_line":215,"start_character":0,"end_line":217,"end_character":52},"in_reply_to":"bbd5b5ce_ba08ab33","updated":"2021-12-23 04:20:49.000000000","message":"right","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c92988a29ccb0e95a207782e36616618d4ad989","unresolved":true,"context_lines":[{"line_number":212,"context_line":"There are no new API introduced, but the changes to the existing APIs will be"},{"line_number":213,"context_line":"microversioned. Namely:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* **Displaying a share server**: after the microversion bump, the share server"},{"line_number":216,"context_line":"  view will include the field ``network_allocation_update_support``. Also, the"},{"line_number":217,"context_line":"  ``share_network_subnet_id`` will be a list of IDs."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* **Adding a neutron subnet to a share network**: after the microversion bump,"},{"line_number":220,"context_line":"  this API will no longer always return an error when the operation result"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bbd5b5ce_ba08ab33","line":217,"range":{"start_line":215,"start_character":0,"end_line":217,"end_character":52},"in_reply_to":"d54a0f35_1db1c220","updated":"2021-12-21 21:37:57.000000000","message":"IMO it shouldn\u0027t... But as per Felipe\u0027s statement it sounds good.. As I understood it will continue, but it will be a list of IDs, right?","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":212,"context_line":"There are no new API introduced, but the changes to the existing APIs will be"},{"line_number":213,"context_line":"microversioned. Namely:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* **Displaying a share server**: after the microversion bump, the share server"},{"line_number":216,"context_line":"  view will include the field ``network_allocation_update_support``. Also, the"},{"line_number":217,"context_line":"  ``share_network_subnet_id`` will be a list of IDs."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* **Adding a neutron subnet to a share network**: after the microversion bump,"},{"line_number":220,"context_line":"  this API will no longer always return an error when the operation result"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a1edf4d_e9565eef","line":217,"range":{"start_line":215,"start_character":0,"end_line":217,"end_character":52},"in_reply_to":"d54a0f35_1db1c220","updated":"2021-12-21 14:23:32.000000000","message":"No, it will be a list of IDs, but it keep with the same field name. The ones that don\u0027t support multiple subnets, will have the list with single item.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"5e2211012ce0bf20a778528b72ae6d11e5d1fa65","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"a414f25b_ac70efd3","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"updated":"2021-12-20 14:02:15.000000000","message":"We need to see if the focus will be only IPv4 in this first implementation or if will implemented and tested with IPv6 also. I believe, the implementation will be valid for both IP versions, but this need to be tested.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4f2d64200c6c9321eb93e5e8451ea80153ea502d","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"a60a06b3_c447b574","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"in_reply_to":"12149ab2_fde25051","updated":"2022-01-07 12:22:23.000000000","message":"The check operation in sec service update was designed thinking on other operations like share network updates. Share network update is as dangerous as sec service updates and share migration, because can end up on backend errors which may even cause loss of access since you are changing network configurations.\nThe check operation can be useful to admins since it provides information of which backends supports or not the operation. \nBut it is not mandatory to implement and you should analise if make sense or not to have this operation for this operation.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ff2a1a4a571a90bfaba0c555212d6e74ce7d8562","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"acd52114_b0028bbf","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"in_reply_to":"351223ac_abfe22fb","updated":"2021-12-21 14:23:32.000000000","message":"agree Fernando, done.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ca1cf647a27e35601c34d9b641e3d086011f99bc","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"c9523f95_8b92668d","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"in_reply_to":"4eb4df6e_1cc1e678","updated":"2021-12-28 15:20:53.000000000","message":"Actually, there is a situation where having a check operation might be useful. Changing a share network may impact more then one backend at the same time and it would be more difficult to handle a scenario where you want to add a new IPv6 subnet and a backend A supports IPv6 but a backend B doesn\u0027t.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"fcc872e39271aa57c07f682e906b5915019b54b7","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"df3f653a_c024f3a7","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"in_reply_to":"a414f25b_ac70efd3","updated":"2021-12-20 20:03:06.000000000","message":"Focus will be IPv4 in a same broadcast domain for Yoga. A suggestion is to change to the following:\n\n1. Multiple IPv4 subnets in a same network (Targeted to Yoga release)\n2. Multiple IPv6 subnets in a same network\n3. Multiple IPv4/IPv6 subnets in different networks","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"daa3730c539a8ffd2d795a6b1d898f8736728d15","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"d12973d1_3349ec2f","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"in_reply_to":"acd52114_b0028bbf","updated":"2021-12-23 19:54:52.000000000","message":"This is a driver implementation detail, and shouldn\u0027t be treat in manila.\n\nIf you take a look on security service update implementation, you will see a solution for that kind of issues.\n\nIn security service udpate, we have a check operation that validates with the driver if the operation is supported. You can use that check to validate if IPv4/Ipv6 operations are supported. The benefit is that we can check (like we do in migration) if a share network update is possible before triggering in share manager, and also give admins a tool to check if a share network update is valid. In the next releases you can improve your driver to support other protocol versions without changing nothing in core code.\nThe base implementation is already there (async check), you will be able to extend that to cover your scenario.\n\nNote that this driver check is made only if all share servers supports such capability. So there is a API check (capability) and a driver check (new driver method).","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"a5931cc6b9bf039c9c7efc866ba8ed28e95f02b3","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"4eb4df6e_1cc1e678","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"in_reply_to":"d12973d1_3349ec2f","updated":"2021-12-28 14:24:31.000000000","message":"Agree with Douglas that the support of IPv6 and decisions like that are more like a driver thing and shouldn\u0027t be delegated to manager. My only concern is about adding one more check operation for a operation that is really simple. IMOH, it is more simple to maintain and common to expect a fail directly from a update operation (with a proper message) than be required to first execute a check before executing the update itself. For migration and even security options I think the solution with a new check is just fine since there is many more steps in those ops and they both can be disruptive, but updating share networks to include new subnets shouldn\u0027t be something complex and I don\u0027t think it should be evaluated in the same way.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"12149ab2_fde25051","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"in_reply_to":"d12973d1_3349ec2f","updated":"2021-12-28 17:15:27.000000000","message":"The way that securtiy service update was designed, the user must run a check before running the actual update [1]. Do you mean reuse the same approach for subnet updates ? \n\nIf so, it seems less usable to the end user, it must firstly check the operation, then trigging the actual update. For migration, it makes sense because it is a complex and long operation that moves data. For updating settings, I am not totally sure. What do you think ?\n\n\n[1] https://github.com/openstack/manila/blob/master/manila/share/api.py#L3154","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"95fc17c94c24f1ff77af50ea3960219d6b79d933","unresolved":true,"context_lines":[{"line_number":425,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":426,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"1. Multiple subnets in same network and same IP version (yoga release);"},{"line_number":429,"context_line":"2. Multiple subnets in different network and same IP version;"},{"line_number":430,"context_line":"3. Multiple subnets in different network and different IP version."},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"351223ac_abfe22fb","line":428,"range":{"start_line":428,"start_character":3,"end_line":428,"end_character":71},"in_reply_to":"df3f653a_c024f3a7","updated":"2021-12-20 20:14:25.000000000","message":"The reference to the Yoga release could be removed. IMHO there is no need to specify in which release a spec will be implemented since we can\u0027t guarantee it is going to be merged.","commit_id":"2391652f4f013d66f058b98e83a6866973835f24"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"daa3730c539a8ffd2d795a6b1d898f8736728d15","unresolved":true,"context_lines":[{"line_number":115,"context_line":"  Otherwise, the API call will succeed and the share manager will be invoked"},{"line_number":116,"context_line":"  to update the share server network allocations."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* When creating shares in share networks with more than one subnet per AZ, the"},{"line_number":119,"context_line":"  scheduler will attempt to find a valid back end that has"},{"line_number":120,"context_line":"  ``multiple_subnet_share_server_support`` set to ``True``. If that is not the"},{"line_number":121,"context_line":"  case, the request will result in ``No valid host`` scheduling error."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":124,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"}],"source_content_type":"text/x-rst","patch_set":9,"id":"880347f3_10bf0468","line":121,"range":{"start_line":118,"start_character":0,"end_line":121,"end_character":70},"updated":"2021-12-23 19:54:52.000000000","message":"Do you plan to create a new filter? Do you plan to provide all info on request_spec?","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":115,"context_line":"  Otherwise, the API call will succeed and the share manager will be invoked"},{"line_number":116,"context_line":"  to update the share server network allocations."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* When creating shares in share networks with more than one subnet per AZ, the"},{"line_number":119,"context_line":"  scheduler will attempt to find a valid back end that has"},{"line_number":120,"context_line":"  ``multiple_subnet_share_server_support`` set to ``True``. If that is not the"},{"line_number":121,"context_line":"  case, the request will result in ``No valid host`` scheduling error."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":124,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"}],"source_content_type":"text/x-rst","patch_set":9,"id":"74f193a3_52353962","line":121,"range":{"start_line":118,"start_character":0,"end_line":121,"end_character":70},"in_reply_to":"880347f3_10bf0468","updated":"2021-12-28 17:15:27.000000000","message":"yes","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"c00fec6ae134309f4518a574b5335ea93ddd8e0d","unresolved":true,"context_lines":[{"line_number":133,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":134,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":137,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":138,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":139,"context_line":"once implemented, will always be invoked in favor of the old ones."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a75db96_4268f726","line":136,"updated":"2021-12-22 13:27:01.000000000","message":"I have a concern on creating new setup interfaces but I may be overthinking or just completely wrong... so feel free to push back if it doesn\u0027t make much sense. \n\nCreating multiple setup interfaces may lead to scenarios where we would need to have interfaces for every possible combination, as a driver could have support to multiple subnet but not to some other feature we decide to implement in the future. I guess the idea of implementing a new setup interface is to avoid making changes to other drivers, but we could still do that by checking if driver supports the capability in share manager and if so, we pass a list of network info instead of a single network info dict. \n\nThis alternative I\u0027ve proposed would impact a future effort to use type checking with mypy since the network info could be a list or a dict depending on the driver that will receive it, but if that is a big deal we could just change the other drivers a bit just to consume the new list.","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":133,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":134,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":137,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":138,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":139,"context_line":"once implemented, will always be invoked in favor of the old ones."}],"source_content_type":"text/x-rst","patch_set":9,"id":"b225a080_34c9567a","line":136,"in_reply_to":"115704d3_2c377e6e","updated":"2021-12-28 17:15:27.000000000","message":"Please, see the discussion: https://review.opendev.org/c/openstack/manila-specs/+/619925/comment/e6074e6c_4e05c8bd/","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"67c2e5c1675f877807b7a58bfc232c584f555ad8","unresolved":true,"context_lines":[{"line_number":133,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":134,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":137,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":138,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":139,"context_line":"once implemented, will always be invoked in favor of the old ones."}],"source_content_type":"text/x-rst","patch_set":9,"id":"ca2fc852_cbd40ea4","line":136,"in_reply_to":"9a75db96_4268f726","updated":"2021-12-23 04:20:49.000000000","message":"I definitely agree with you Fernando. Thinking the driver interfaces in a long term, having two interface to do the same work just changing the parameters wouldn\u0027t be good choice to code maintenence. \n\nAs you mentioned, passing the param as a list or dict depending on the driver support is not a good choice, though.\n\nActually, the passed param \"network_info\" is a dict that contains some allocations for a given subnet. We could only change the fields that are subnet related, they are four:\n\n1.\"subnet_id\": string id\n2.\"allocations\": list of dict allocations\n3.\"admin_network_allocations\": list of dict allocations\n4.\"cidr\": string notation subnet cidr\n  \nThey would become for multiple subnets:\n\n1.\"subnet_id\": LIST of string id\n2.\"cidr\": LIST of dict, where the key is the \"subnet_id\" and the value is the  string notation subnet cidr\n\nThe \"allocations\" and \"admin_network_allocations\" are already a list, so we can keep them. Other parameters are not subnet related.","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"daa3730c539a8ffd2d795a6b1d898f8736728d15","unresolved":true,"context_lines":[{"line_number":133,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":134,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":137,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":138,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":139,"context_line":"once implemented, will always be invoked in favor of the old ones."}],"source_content_type":"text/x-rst","patch_set":9,"id":"115704d3_2c377e6e","line":136,"in_reply_to":"ca2fc852_cbd40ea4","updated":"2021-12-23 19:54:52.000000000","message":"yes, we should avoid new driver interfaces. WDYT about just duplicating info inside \"network_info\", you can continue with subnet_id as backward compatibility and add a new attribute with \u0027subnet_id_list\u0027 that must be consumed by drivers that implement that feature.\nWe will need to update driver\u0027s interface documentation to avoid confusion, but won\u0027t break any driver.","commit_id":"11b34b7afd974e700bea16c862e3887cd65cd5c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":97,"context_line":"proper back end when creating new shares in share networks that already have"},{"line_number":98,"context_line":"more than one subnet per AZ."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Another new driver interface will be introduced named"},{"line_number":101,"context_line":"``update_share_server_network_allocations`` so that drivers can update share"},{"line_number":102,"context_line":"server network allocations whenever neutron subnets are added or removed from"},{"line_number":103,"context_line":"share networks. Also, the interface must return the new share\u0027s export"},{"line_number":104,"context_line":"locations, since they will change together with share server subnet change."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"A new boolean column ``network_allocation_update_support`` will be added to the"},{"line_number":107,"context_line":"share server model to distinguish existing share servers that can support this"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8d127762_3a67a057","line":104,"range":{"start_line":100,"start_character":0,"end_line":104,"end_character":75},"updated":"2021-12-23 19:15:07.000000000","message":"Will this also be an implied driver capability? I think you\u0027d want users to be able to know before hand if a share network modification is possible or not.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":97,"context_line":"proper back end when creating new shares in share networks that already have"},{"line_number":98,"context_line":"more than one subnet per AZ."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Another new driver interface will be introduced named"},{"line_number":101,"context_line":"``update_share_server_network_allocations`` so that drivers can update share"},{"line_number":102,"context_line":"server network allocations whenever neutron subnets are added or removed from"},{"line_number":103,"context_line":"share networks. Also, the interface must return the new share\u0027s export"},{"line_number":104,"context_line":"locations, since they will change together with share server subnet change."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"A new boolean column ``network_allocation_update_support`` will be added to the"},{"line_number":107,"context_line":"share server model to distinguish existing share servers that can support this"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8eeae1a3_0e75d001","line":104,"range":{"start_line":100,"start_character":0,"end_line":104,"end_character":75},"in_reply_to":"8d127762_3a67a057","updated":"2021-12-28 17:15:27.000000000","message":"agree. Actually, there is a Share Server boolean `network_allocation_update_support` to this end, but this spec is not saying that it is a capability too. Added!","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":126,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"},{"line_number":127,"context_line":"share servers to be created on empty multiple subnet share networks, but the"},{"line_number":128,"context_line":"share network will not be allowed to have subnets added or removed. If the"},{"line_number":129,"context_line":"share network is not empty, the scheduler will ensure the back end is not a"},{"line_number":130,"context_line":"valid candidate."}],"source_content_type":"text/x-rst","patch_set":10,"id":"f9f9fd78_a10ab0b5","line":127,"range":{"start_line":127,"start_character":28,"end_line":127,"end_character":67},"updated":"2021-12-23 19:15:07.000000000","message":"what does this mean?","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":126,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"},{"line_number":127,"context_line":"share servers to be created on empty multiple subnet share networks, but the"},{"line_number":128,"context_line":"share network will not be allowed to have subnets added or removed. If the"},{"line_number":129,"context_line":"share network is not empty, the scheduler will ensure the back end is not a"},{"line_number":130,"context_line":"valid candidate."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ef20b18_152643db","line":127,"range":{"start_line":127,"start_character":28,"end_line":127,"end_character":67},"in_reply_to":"f9f9fd78_a10ab0b5","updated":"2021-12-28 17:15:27.000000000","message":"It was written by ganso, what I got from it:\n\nby empty it means no share server related to that share network. So, the point here is: if the driver has no support\nfor updating share server allocations, it will only be a valid scheduler cadidate in case the multiple share network has no associated share server. Otherwise, the share netwok will lose the update support because of this new share server.\n\nExample: I have two backends B1 and B2. B1 has support for multiple subnets, but no support for updating. B2 has support for both, updating and setup multiple subnets. I also have a multiple subnet share network called SN:\n\n1. New share is created using SN. It is allocated to B2.\n2. Another share is created using SN, the scheduler won\u0027t allow it to be created in the B1, because this would make\nthe entire share network without updating support. In another words, adding a share server without updating support to a share network with update support will lose the net update support.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":135,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":136,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":139,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":140,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":141,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":144,"context_line":"later releases, after the ``network_allocation_update_support`` field has"}],"source_content_type":"text/x-rst","patch_set":10,"id":"e6074e6c_4e05c8bd","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":66},"updated":"2021-12-23 19:15:07.000000000","message":"instead of adding brand new interfaces, can we add a new optional kwarg to distinguish this?","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":true,"context_lines":[{"line_number":135,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":136,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":139,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":140,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":141,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":144,"context_line":"later releases, after the ``network_allocation_update_support`` field has"}],"source_content_type":"text/x-rst","patch_set":10,"id":"395e1683_26e625ee","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":66},"in_reply_to":"01f4d9a9_e664db79","updated":"2022-01-06 01:19:35.000000000","message":"Yes, lets fix with option 1, and edit these drivers to process network_info[0]","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"8f3d98dc2ef9a649595625e743429aad0329a2c4","unresolved":true,"context_lines":[{"line_number":135,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":136,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":139,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":140,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":141,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":144,"context_line":"later releases, after the ``network_allocation_update_support`` field has"}],"source_content_type":"text/x-rst","patch_set":10,"id":"a63fe13f_ab88ea5c","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":66},"in_reply_to":"395e1683_26e625ee","updated":"2022-01-06 14:08:14.000000000","message":"+1 to option 1. The change we are going to make to the drivers is trivial + communicating in mailing list to the driver maintainers out-of-tree about the change appears to be enough.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":135,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":136,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":139,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":140,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":141,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":144,"context_line":"later releases, after the ``network_allocation_update_support`` field has"}],"source_content_type":"text/x-rst","patch_set":10,"id":"d210dc6a_e5d66f2d","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":66},"in_reply_to":"99760185_3491a29d","updated":"2021-12-28 17:15:27.000000000","message":"We all agree that adding new interface is not a good idea. We need to agree with the solution. There are 2:\n\n1. Change the \"network_info\" to be a list of dict, instead of a dict \u003d\u003e could break other drivers\n2. Let the \"network_info\" as legacy param. Add a new param as kwargs \"network_info_list\u003dNone\" which would contain\nthe list of \"network_info\". So, no drivers would break, but the code is a bit mess, requiring a good code documentation.\n\nParticularly, I prefer the approach \"1\", since thinking in a long term, the mess code could cause bugs and harder to maintain. The problem with breaking drivers can be solved with announcements in the email list and change the manila drivers to consume the first item from the list, in a long term, this would not be a problem anymore.\n\nWDYT ? Douglas, Carlos, Fernando, Goutham and all folks ????","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4f2d64200c6c9321eb93e5e8451ea80153ea502d","unresolved":true,"context_lines":[{"line_number":135,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":136,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":139,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":140,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":141,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":144,"context_line":"later releases, after the ``network_allocation_update_support`` field has"}],"source_content_type":"text/x-rst","patch_set":10,"id":"156aa853_1f1342cb","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":66},"in_reply_to":"9d40266e_96833c05","updated":"2022-01-07 12:22:23.000000000","message":"Fine by me too, +1","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":135,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":136,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":139,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":140,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":141,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":144,"context_line":"later releases, after the ``network_allocation_update_support`` field has"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9d40266e_96833c05","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":66},"in_reply_to":"a63fe13f_ab88ea5c","updated":"2022-01-06 23:14:46.000000000","message":"ack, changed.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16fbf4e9365624d9b0a0fd849db198a1619a2b4a","unresolved":true,"context_lines":[{"line_number":135,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":136,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":139,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":140,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":141,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":144,"context_line":"later releases, after the ``network_allocation_update_support`` field has"}],"source_content_type":"text/x-rst","patch_set":10,"id":"01f4d9a9_e664db79","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":66},"in_reply_to":"d210dc6a_e5d66f2d","updated":"2022-01-04 18:41:12.000000000","message":"I also think approach 1 sounds better. We could let other driver maintainers know. Also, most of them are not handling DHSS\u003dTrue. The drivers that support it are:\nGeneric, Container, NetApp, EMC (VMAX, VNX and Unity), Hpe, Huawei, Windows... See [1]\n[1] https://docs.openstack.org/manila/xena/admin/share_back_ends_feature_support_mapping.html#mapping-of-share-drivers-and-common-capabilities","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9b4aeb71f371d69c803af1181fcba0c11e869750","unresolved":true,"context_lines":[{"line_number":135,"context_line":"one subnet per AZ. New shares will be allowed to be scheduled to them only when"},{"line_number":136,"context_line":"the associated share network does not have more than one neutron subnet per AZ."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Any driver that implements ``setup_multiple_subnet_server`` and"},{"line_number":139,"context_line":"``teardown_multiple_subnet_server`` can remove the implementations of"},{"line_number":140,"context_line":"``setup_server`` and ``teardown_server``, as the new driver interfaces,"},{"line_number":141,"context_line":"once implemented, will always be invoked in favor of the old ones."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If a driver decides to implement ``update_share_server_network_allocations`` in"},{"line_number":144,"context_line":"later releases, after the ``network_allocation_update_support`` field has"}],"source_content_type":"text/x-rst","patch_set":10,"id":"99760185_3491a29d","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":66},"in_reply_to":"e6074e6c_4e05c8bd","updated":"2021-12-23 19:20:19.000000000","message":"Reigniting the conversation here from https://review.opendev.org/c/openstack/manila-specs/+/619925/comment/9a75db96_4268f726/\n\nif network_info is a list now instead of being a dictionary, couldn\u0027t we modify existing driver interfaces to just consume network_info[0]? The concern would be the impact on out-of-tree drivers - we could communicate this via the openstack-discuss email list which out-of-tree driver maintainers should be subscribed to; and we could add appropriate release notes. WDYT?","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":157,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":158,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":159,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":160,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":161,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Manila Manage"},{"line_number":164,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ee92d821_fd573ba2","line":161,"range":{"start_line":160,"start_character":63,"end_line":161,"end_character":64},"updated":"2021-12-23 19:15:07.000000000","message":"if updates are occurring across multiple share servers/backends - how/when is the end of the update signalled?","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":true,"context_lines":[{"line_number":157,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":158,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":159,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":160,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":161,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Manila Manage"},{"line_number":164,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fe689467_79ea2d88","line":161,"range":{"start_line":160,"start_character":63,"end_line":161,"end_character":64},"in_reply_to":"5933675c_4185d722","updated":"2022-01-06 01:19:35.000000000","message":"great thanks!","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":157,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":158,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":159,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":160,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":161,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Manila Manage"},{"line_number":164,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5933675c_4185d722","line":161,"range":{"start_line":160,"start_character":63,"end_line":161,"end_character":64},"in_reply_to":"ee92d821_fd573ba2","updated":"2021-12-28 17:15:27.000000000","message":"We can approach the same way as the security service update did, check in the manager if all share servers from the share network have finished their update status [1].\n\n[1] https://github.com/openstack/manila/blob/master/manila/share/manager.py#L5700","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"of the given subnets, the entire setup will fail. Likewise, if the"},{"line_number":158,"context_line":"``update_share_server_network_allocations`` fails, the share server status will"},{"line_number":159,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":160,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":161,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Manila Manage"},{"line_number":164,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"f29e35ed_477bd5ac","line":161,"range":{"start_line":160,"start_character":63,"end_line":161,"end_character":64},"in_reply_to":"fe689467_79ea2d88","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":159,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":160,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":161,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Manila Manage"},{"line_number":164,"context_line":"-------------"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"985f6c0f_e6a53ae4","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":0},"updated":"2021-12-23 19:15:07.000000000","message":"During an update in the share manager, if network allocations are not possible on one of the possible subnets, what happens?","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":159,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":160,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":161,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Manila Manage"},{"line_number":164,"context_line":"-------------"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1bdfeb4e_ca1425dd","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":0},"in_reply_to":"1277571e_4603d613","updated":"2022-01-06 23:14:46.000000000","message":"It\u0027s already there, see: https://review.opendev.org/c/openstack/manila-specs/+/619925/10..11/specs/multi-release/share-server-multiple-subnet.rst#161","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":159,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":160,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":161,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Manila Manage"},{"line_number":164,"context_line":"-------------"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"aff55cad_04be129d","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":0},"in_reply_to":"985f6c0f_e6a53ae4","updated":"2021-12-28 17:15:27.000000000","message":"The update fails, the allocations must be available in all subnets.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":true,"context_lines":[{"line_number":159,"context_line":"be set to ``error`` along with all affected shares access rules. The network"},{"line_number":160,"context_line":"status won\u0027t be affected by errors raised by back end drivers, and will have"},{"line_number":161,"context_line":"its status updated to ``active`` again at the end of the update."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Manila Manage"},{"line_number":164,"context_line":"-------------"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1277571e_4603d613","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":0},"in_reply_to":"aff55cad_04be129d","updated":"2022-01-06 01:19:35.000000000","message":"I\u0027d like this mentioned in this spec please...","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":241,"context_line":"--------------------"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"There are no new notifications introduced. The existing notifications already"},{"line_number":244,"context_line":"contemplate the changes proposed."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Other end user impact"},{"line_number":247,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"e0940669_c035abfb","line":244,"range":{"start_line":244,"start_character":0,"end_line":244,"end_character":11},"updated":"2021-12-23 19:15:07.000000000","message":"accommodate","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":241,"context_line":"--------------------"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"There are no new notifications introduced. The existing notifications already"},{"line_number":244,"context_line":"contemplate the changes proposed."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Other end user impact"},{"line_number":247,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"91d0c6a7_7a742c27","line":244,"range":{"start_line":244,"start_character":0,"end_line":244,"end_character":11},"in_reply_to":"e0940669_c035abfb","updated":"2021-12-28 17:15:27.000000000","message":"done.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        raise NotImplementedError()"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"Drivers should expect to receive multiple network allocations. The total number"},{"line_number":396,"context_line":"should be the number of subnets associated with the same AZ multiplied by the"},{"line_number":397,"context_line":"number of allocations reported by the driver. The network allocations entry in"},{"line_number":398,"context_line":"the dictionary ``network_info`` will now be a list of key-value pairs where"},{"line_number":399,"context_line":"they key is the neutron subnet and the value is the list of allocations in that"},{"line_number":400,"context_line":"subnet."}],"source_content_type":"text/x-rst","patch_set":10,"id":"c19bd3de_0b3cfccc","line":397,"range":{"start_line":395,"start_character":0,"end_line":397,"end_character":45},"updated":"2021-12-23 19:15:07.000000000","message":"This feels like math the share manager should perform. The drivers can report how many allocations they want from each subnet.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        raise NotImplementedError()"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"Drivers should expect to receive multiple network allocations. The total number"},{"line_number":396,"context_line":"should be the number of subnets associated with the same AZ multiplied by the"},{"line_number":397,"context_line":"number of allocations reported by the driver. The network allocations entry in"},{"line_number":398,"context_line":"the dictionary ``network_info`` will now be a list of key-value pairs where"},{"line_number":399,"context_line":"they key is the neutron subnet and the value is the list of allocations in that"},{"line_number":400,"context_line":"subnet."}],"source_content_type":"text/x-rst","patch_set":10,"id":"667947fc_bc5b7394","line":397,"range":{"start_line":395,"start_character":0,"end_line":397,"end_character":45},"in_reply_to":"5cdfd36e_24c426f0","updated":"2022-01-06 01:19:35.000000000","message":"yes, just a small change of wording --- s/should/will:\n\n The total number *will* be the number of subnets associated with the same AZ multiplied by the","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        raise NotImplementedError()"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"Drivers should expect to receive multiple network allocations. The total number"},{"line_number":396,"context_line":"should be the number of subnets associated with the same AZ multiplied by the"},{"line_number":397,"context_line":"number of allocations reported by the driver. The network allocations entry in"},{"line_number":398,"context_line":"the dictionary ``network_info`` will now be a list of key-value pairs where"},{"line_number":399,"context_line":"they key is the neutron subnet and the value is the list of allocations in that"},{"line_number":400,"context_line":"subnet."}],"source_content_type":"text/x-rst","patch_set":10,"id":"f461fc53_16ffe284","line":397,"range":{"start_line":395,"start_character":0,"end_line":397,"end_character":45},"in_reply_to":"667947fc_bc5b7394","updated":"2022-01-06 23:14:46.000000000","message":"done","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        raise NotImplementedError()"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"Drivers should expect to receive multiple network allocations. The total number"},{"line_number":396,"context_line":"should be the number of subnets associated with the same AZ multiplied by the"},{"line_number":397,"context_line":"number of allocations reported by the driver. The network allocations entry in"},{"line_number":398,"context_line":"the dictionary ``network_info`` will now be a list of key-value pairs where"},{"line_number":399,"context_line":"they key is the neutron subnet and the value is the list of allocations in that"},{"line_number":400,"context_line":"subnet."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5cdfd36e_24c426f0","line":397,"range":{"start_line":395,"start_character":0,"end_line":397,"end_character":45},"in_reply_to":"c19bd3de_0b3cfccc","updated":"2021-12-28 17:15:27.000000000","message":"Yeah, this math is done by share manager and passed down to drivers. Do you want to edit ?","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ed77badfd02a010f1acab4979585080f589a8aa","unresolved":true,"context_lines":[{"line_number":430,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":431,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"1. Multiple IPv4 subnets in a same network"},{"line_number":434,"context_line":"2. Multiple IPv6 subnets in a same network"},{"line_number":435,"context_line":"3. Multiple IPv4/IPv6 subnets in different networks"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"This deliverable approach would split the test and validation effort a long"},{"line_number":438,"context_line":"the releases."}],"source_content_type":"text/x-rst","patch_set":10,"id":"c704d909_309b3ef9","line":435,"range":{"start_line":433,"start_character":0,"end_line":435,"end_character":51},"updated":"2021-12-23 19:15:07.000000000","message":"Nothing in this spec regarding the user experience seems to distinguish ip address families, so i\u0027m unsure what work would be left when you implement this spec. I rather see two distinct workflows in the spec:\n\n- Add ability to define multiple subnets in the same share network AZ\n- Add ability to \"update\" subnets in a share network AZ","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"8f3d98dc2ef9a649595625e743429aad0329a2c4","unresolved":true,"context_lines":[{"line_number":430,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":431,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"1. Multiple IPv4 subnets in a same network"},{"line_number":434,"context_line":"2. Multiple IPv6 subnets in a same network"},{"line_number":435,"context_line":"3. Multiple IPv4/IPv6 subnets in different networks"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"This deliverable approach would split the test and validation effort a long"},{"line_number":438,"context_line":"the releases."}],"source_content_type":"text/x-rst","patch_set":10,"id":"a0675be2_69079083","line":435,"range":{"start_line":433,"start_character":0,"end_line":435,"end_character":51},"in_reply_to":"6377f49b_32fbe47b","updated":"2022-01-06 14:08:14.000000000","message":"+1 to have both ipv4 and ipv6 in manager and choose what to support in the driver.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":430,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":431,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"1. Multiple IPv4 subnets in a same network"},{"line_number":434,"context_line":"2. Multiple IPv6 subnets in a same network"},{"line_number":435,"context_line":"3. Multiple IPv4/IPv6 subnets in different networks"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"This deliverable approach would split the test and validation effort a long"},{"line_number":438,"context_line":"the releases."}],"source_content_type":"text/x-rst","patch_set":10,"id":"a618ea18_e7b7f70d","line":435,"range":{"start_line":433,"start_character":0,"end_line":435,"end_character":51},"in_reply_to":"a0675be2_69079083","updated":"2022-01-06 23:14:46.000000000","message":"ack","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":true,"context_lines":[{"line_number":430,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":431,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"1. Multiple IPv4 subnets in a same network"},{"line_number":434,"context_line":"2. Multiple IPv6 subnets in a same network"},{"line_number":435,"context_line":"3. Multiple IPv4/IPv6 subnets in different networks"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"This deliverable approach would split the test and validation effort a long"},{"line_number":438,"context_line":"the releases."}],"source_content_type":"text/x-rst","patch_set":10,"id":"6377f49b_32fbe47b","line":435,"range":{"start_line":433,"start_character":0,"end_line":435,"end_character":51},"in_reply_to":"ab8beeb5_a48a5d1a","updated":"2022-01-06 01:19:35.000000000","message":"+1 \nit\u0027s pretty straightforward to add ipv4 and ipv6 addresses to LIFs on the same interfaces on ONTAP :) but i\u0027ll leave the implementation plan up to you","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0c04a3299dd1eb899a49abab03c5bad87d14badd","unresolved":true,"context_lines":[{"line_number":430,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":431,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"1. Multiple IPv4 subnets in a same network"},{"line_number":434,"context_line":"2. Multiple IPv6 subnets in a same network"},{"line_number":435,"context_line":"3. Multiple IPv4/IPv6 subnets in different networks"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"This deliverable approach would split the test and validation effort a long"},{"line_number":438,"context_line":"the releases."}],"source_content_type":"text/x-rst","patch_set":10,"id":"ab8beeb5_a48a5d1a","line":435,"range":{"start_line":433,"start_character":0,"end_line":435,"end_character":51},"in_reply_to":"c704d909_309b3ef9","updated":"2021-12-28 17:15:27.000000000","message":"Even they are the same code, they are different settings that must be tested in order to deliver the spec with IPv6/IPv4\nsupport. The idea is to initially only delivering the IPv4, so we could skip the IPv6 test part, since we are more worried about adding new subnets than adding IPv6. \n\nAnyway, I agree with you. We could leave the workflow as you mentioned and just in our driver level we block IPv6 updates.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ebffb3926b6f7d4c3a0d283b9085011df88a22f1","unresolved":true,"context_lines":[{"line_number":430,"context_line":"This spec may require more than one release to be delivered covering all use"},{"line_number":431,"context_line":"cases. So, it can be splitted in three major deliverables, being:"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"1. Multiple IPv4 subnets in a same network"},{"line_number":434,"context_line":"2. Multiple IPv6 subnets in a same network"},{"line_number":435,"context_line":"3. Multiple IPv4/IPv6 subnets in different networks"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"This deliverable approach would split the test and validation effort a long"},{"line_number":438,"context_line":"the releases."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9fe64e4e_9888e43d","line":435,"range":{"start_line":433,"start_character":0,"end_line":435,"end_character":51},"in_reply_to":"c704d909_309b3ef9","updated":"2021-12-28 15:01:23.000000000","message":"I Agree. The idea of having phases was to focus our tests based on specific scenarios that are more important for us right now as we don\u0027t have time to test every possible scenario for Yoga, but the change we are planning in fact would work for both ip address families since there is no additional handling for IPv6. Moving the IPv6 validation to the driver as Douglas suggested might be a way as we could use a test driver like the dummy driver to validate the manager\u0027s code and have address families supported in phases in the ONTAP driver for instance.","commit_id":"4b54a30e36eeeff3e28b559d17b601842574766e"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"515f79ba2b0297b5bc77a130fe3ec113513e510f","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes changes to Manila with the purpose of addressing the need"},{"line_number":14,"context_line":"for having share servers with network allocations on multiple subnets. To do"},{"line_number":15,"context_line":"so, the spec is proposing allowing share network span multiple subnets"},{"line_number":16,"context_line":"in the same AZ."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":11,"id":"8938b06c_80bdec4a","line":15,"range":{"start_line":15,"start_character":35,"end_line":15,"end_character":53},"updated":"2022-01-06 20:25:57.000000000","message":"Nit: share networks to span","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes changes to Manila with the purpose of addressing the need"},{"line_number":14,"context_line":"for having share servers with network allocations on multiple subnets. To do"},{"line_number":15,"context_line":"so, the spec is proposing allowing share network span multiple subnets"},{"line_number":16,"context_line":"in the same AZ."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dda6db77_8d8097f1","line":15,"range":{"start_line":15,"start_character":35,"end_line":15,"end_character":53},"in_reply_to":"8938b06c_80bdec4a","updated":"2022-01-06 23:14:46.000000000","message":"done","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"515f79ba2b0297b5bc77a130fe3ec113513e510f","unresolved":true,"context_lines":[{"line_number":38,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":39,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Prior to the implementation of `[1]_`, the share network entity held"},{"line_number":42,"context_line":"information from Neutron networks and subnets, and Manila referred to its data"},{"line_number":43,"context_line":"when trying to dynamically allocate addresses. Since the implementation of"},{"line_number":44,"context_line":"`[1]_`, the share network entity was modified to do not hold Neutron"}],"source_content_type":"text/x-rst","patch_set":11,"id":"92b84c3d_9ea33422","line":41,"range":{"start_line":41,"start_character":31,"end_line":41,"end_character":37},"updated":"2022-01-06 20:25:57.000000000","message":"`[1]`_\n\nIf you inspect the docs-html.tar.gz file [1] from the openstack-tox-docs job you\u0027ll notice that this hyperlink wasn\u0027t properly rendered. I believe you should put the underscore after the second grave accent, not before, since that worked for the \u0027`[2]`_\u0027 reference further below.\n\n[1] https://9221391e161e12b0e4a8-0445deb902ee905c6acad95b9b7016b4.ssl.cf1.rackcdn.com/619925/11/check/openstack-tox-docs/7e17f1a/docs-html.tar.gz","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":38,"context_line":"allocations supplied varies by driver, as each driver reports the amount it"},{"line_number":39,"context_line":"needs before the allocation definitions are obtained from Neutron."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Prior to the implementation of `[1]_`, the share network entity held"},{"line_number":42,"context_line":"information from Neutron networks and subnets, and Manila referred to its data"},{"line_number":43,"context_line":"when trying to dynamically allocate addresses. Since the implementation of"},{"line_number":44,"context_line":"`[1]_`, the share network entity was modified to do not hold Neutron"}],"source_content_type":"text/x-rst","patch_set":11,"id":"354e0008_f7fd7b7d","line":41,"range":{"start_line":41,"start_character":31,"end_line":41,"end_character":37},"in_reply_to":"92b84c3d_9ea33422","updated":"2022-01-06 23:14:46.000000000","message":"done","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"515f79ba2b0297b5bc77a130fe3ec113513e510f","unresolved":true,"context_lines":[{"line_number":41,"context_line":"Prior to the implementation of `[1]_`, the share network entity held"},{"line_number":42,"context_line":"information from Neutron networks and subnets, and Manila referred to its data"},{"line_number":43,"context_line":"when trying to dynamically allocate addresses. Since the implementation of"},{"line_number":44,"context_line":"`[1]_`, the share network entity was modified to do not hold Neutron"},{"line_number":45,"context_line":"information, it was instead modified to span multiple share network subnets in"},{"line_number":46,"context_line":"different availability zones. Since then, share servers are created and"},{"line_number":47,"context_line":"associated with a single share network subnet, which contains neutron network"}],"source_content_type":"text/x-rst","patch_set":11,"id":"991c8afe_19103689","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":6},"updated":"2022-01-06 20:25:57.000000000","message":"`[1]`_\n\nSee comment in line 41.","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":41,"context_line":"Prior to the implementation of `[1]_`, the share network entity held"},{"line_number":42,"context_line":"information from Neutron networks and subnets, and Manila referred to its data"},{"line_number":43,"context_line":"when trying to dynamically allocate addresses. Since the implementation of"},{"line_number":44,"context_line":"`[1]_`, the share network entity was modified to do not hold Neutron"},{"line_number":45,"context_line":"information, it was instead modified to span multiple share network subnets in"},{"line_number":46,"context_line":"different availability zones. Since then, share servers are created and"},{"line_number":47,"context_line":"associated with a single share network subnet, which contains neutron network"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e1eb57cb_0602b066","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":6},"in_reply_to":"991c8afe_19103689","updated":"2022-01-06 23:14:46.000000000","message":"done","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New boolean driver capabilities will be introduced:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* **``share_server_supports_multiple_subnets``**: determines whether the driver"},{"line_number":92,"context_line":"  implements a new interface ``setup_multiple_subnet_server`` and"},{"line_number":93,"context_line":"  ``teardown_multiple_subnet_server``. If so, this capability is reported as"},{"line_number":94,"context_line":"  ``True``. Otherwise, the value is ``False``."}],"source_content_type":"text/x-rst","patch_set":11,"id":"29060761_bd9ebd4a","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":44},"updated":"2022-01-06 01:19:35.000000000","message":"``share_server_multiple_subnet_support``\n\nto be consistent with the rest of the boolean capabilities","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New boolean driver capabilities will be introduced:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* **``share_server_supports_multiple_subnets``**: determines whether the driver"},{"line_number":92,"context_line":"  implements a new interface ``setup_multiple_subnet_server`` and"},{"line_number":93,"context_line":"  ``teardown_multiple_subnet_server``. If so, this capability is reported as"},{"line_number":94,"context_line":"  ``True``. Otherwise, the value is ``False``."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ee318a85_1731df52","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":44},"in_reply_to":"29060761_bd9ebd4a","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9f6a7f3f512e3ca7aef52ca5cba3b3aed815e","unresolved":true,"context_lines":[{"line_number":127,"context_line":"  ``share_server_supports_multiple_subnets`` set to ``True``. If that is not"},{"line_number":128,"context_line":"  the case, the request will result in ``No valid host`` scheduling error."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":131,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"},{"line_number":132,"context_line":"share servers to be created on empty multiple subnet share networks, but the"},{"line_number":133,"context_line":"share network will not be allowed to have subnets added or removed. If the"},{"line_number":134,"context_line":"share network is not empty, the scheduler will ensure the back end is not a"},{"line_number":135,"context_line":"valid candidate."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Existing share servers whose drivers implement neither interface will continue"},{"line_number":138,"context_line":"to work without changes. The API will never allow their associated share"}],"source_content_type":"text/x-rst","patch_set":11,"id":"94b13fe3_22124254","line":135,"range":{"start_line":130,"start_character":0,"end_line":135,"end_character":16},"updated":"2022-01-06 01:19:35.000000000","message":"Thanks for your response on PS 10; Based on your response, i wanted to suggest a rewrite. \n\nIt is possible for a driver to support these capabilities independent of each other. If a driver reports ``share_server_multiple_subnet_support\u003dTrue`` and  ``network_allocation_update_support\u003dFalse``, the share\nnetwork will be immutable after the first share server has been provisioned on it. \nSo if a cloud administrator wants both capabilities they must explicitly request each via share type extra specifications.","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  ``share_server_supports_multiple_subnets`` set to ``True``. If that is not"},{"line_number":128,"context_line":"  the case, the request will result in ``No valid host`` scheduling error."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"If a driver implements ``setup_multiple_subnet_server`` interface but does not"},{"line_number":131,"context_line":"implement ``update_share_server_network_allocations``, manila will only allow"},{"line_number":132,"context_line":"share servers to be created on empty multiple subnet share networks, but the"},{"line_number":133,"context_line":"share network will not be allowed to have subnets added or removed. If the"},{"line_number":134,"context_line":"share network is not empty, the scheduler will ensure the back end is not a"},{"line_number":135,"context_line":"valid candidate."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Existing share servers whose drivers implement neither interface will continue"},{"line_number":138,"context_line":"to work without changes. The API will never allow their associated share"}],"source_content_type":"text/x-rst","patch_set":11,"id":"a1cb42a3_9b84fe20","line":135,"range":{"start_line":130,"start_character":0,"end_line":135,"end_character":16},"in_reply_to":"94b13fe3_22124254","updated":"2022-01-06 23:14:46.000000000","message":"Done","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"515f79ba2b0297b5bc77a130fe3ec113513e510f","unresolved":true,"context_lines":[{"line_number":472,"context_line":"References"},{"line_number":473,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"_`[1]`:  https://specs.openstack.org/openstack/manila-specs/specs/train/share-network-multiple-subnets.html"},{"line_number":476,"context_line":"_`[2]`: https://specs.openstack.org/openstack/manila-specs/specs/wallaby/security-service-updates-in-use-share-network.html"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5ad4ec30_57375f48","line":476,"range":{"start_line":475,"start_character":0,"end_line":476,"end_character":123},"updated":"2022-01-06 20:25:57.000000000","message":"Nit: Not sure if this was intended, but in the rendered HTML document [1] there\u0027s a space between these two lines instead of a new line. To render a new line in the HTML document you must either add one extra new line in the source file [2] or add one pipe character plus a space in the beginning of each line. [3]\n\n[1] https://9221391e161e12b0e4a8-0445deb902ee905c6acad95b9b7016b4.ssl.cf1.rackcdn.com/619925/11/check/openstack-tox-docs/7e17f1a/docs-html.tar.gz\n[2] https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#paragraphs\n[3] https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#lists-and-quote-like-blocks","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4dc26d4dd6d8d11bbb78cf087a76aeef7612a92f","unresolved":true,"context_lines":[{"line_number":472,"context_line":"References"},{"line_number":473,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"_`[1]`:  https://specs.openstack.org/openstack/manila-specs/specs/train/share-network-multiple-subnets.html"},{"line_number":476,"context_line":"_`[2]`: https://specs.openstack.org/openstack/manila-specs/specs/wallaby/security-service-updates-in-use-share-network.html"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"47e56d93_beeb1766","line":476,"range":{"start_line":475,"start_character":0,"end_line":476,"end_character":123},"in_reply_to":"5ad4ec30_57375f48","updated":"2022-01-06 23:14:46.000000000","message":"nice catch, thks! :)","commit_id":"f1c0f382d8c090877d1a829070e926c253df2d98"}],"specs/train/share-server-multiple-subnet.rst":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"9dcdc66438fe9763448f4f9c586ad7e0573bd29b","unresolved":false,"context_lines":[{"line_number":207,"context_line":"Driver impact"},{"line_number":208,"context_line":"-------------"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Drivers that wish to support this functionality need to implement three new"},{"line_number":211,"context_line":"driver interfaces::"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def setup_multiple_subnet_server(self, network_info, metadata\u003dNone):"},{"line_number":214,"context_line":"    \"\"\"Setup a share server with network allocations on multiple subnets."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    :param network_info: Dictionary containing network parameters for share"},{"line_number":217,"context_line":"        server creation, with the map of network allocations and security"},{"line_number":218,"context_line":"        services among them."},{"line_number":219,"context_line":"    :param metadata: a dictionary, for now containing a key \u0027request_host\u0027."},{"line_number":220,"context_line":"    :return Dictionary with back end details to be saved in the database."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        Example::"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            {\u0027server_name\u0027: \u0027my_share_server\u0027}"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        raise NotImplementedError()"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def teardown_multiple_subnet_server("},{"line_number":230,"context_line":"        self, server_details, security_services\u003dNone):"},{"line_number":231,"context_line":"    \"\"\"Tears down a share server with network allocations on multiple subnets."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    :param server_details: Back end details for share server being torn down."},{"line_number":234,"context_line":"    :param security_services: Security services associated with the share"},{"line_number":235,"context_line":"        server being torn down."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    \"\"\""},{"line_number":238,"context_line":"    raise NotImplementedError()"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def update_share_server_network_allocations("},{"line_number":241,"context_line":"        self, network_info, server_details):"},{"line_number":242,"context_line":"    \"\"\"Updates a share server\u0027s network allocations."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    :param network_info: Dictionary containing network parameters for share"},{"line_number":245,"context_line":"        server creation, with the map of network allocations and security"},{"line_number":246,"context_line":"        services among them."},{"line_number":247,"context_line":"    :param server_details: Back end details for share server being torn down."},{"line_number":248,"context_line":"    :return Dictionary with updated back end details to be saved in the"},{"line_number":249,"context_line":"            database."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        Example::"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            {\u0027server_name\u0027: \u0027my_share_server\u0027}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        \"\"\""},{"line_number":256,"context_line":"        raise NotImplementedError()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Drivers should expect to receive multiple network allocations. The total number"},{"line_number":260,"context_line":"should be the number of subnets associated with the same AZ multiplied by the"},{"line_number":261,"context_line":"number of allocations reported by the driver. The network allocations entry in"},{"line_number":262,"context_line":"the dictionary ``network_info`` will now be a list of key-value pairs where"},{"line_number":263,"context_line":"they key is the neutron subnet and the value is the list of allocations in that"},{"line_number":264,"context_line":"subnet."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_64735650","line":264,"range":{"start_line":210,"start_character":0,"end_line":264,"end_character":7},"updated":"2018-11-27 20:56:09.000000000","message":"I\u0027d prefer that the implementation in the base class call the old methods (for backwards compatibility). This enables drivers that override these new methods with a new implementation to drop the old methods.","commit_id":"3dc7aae2bddefb02a99fba002873ca5a428278e1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d23d7bff33dfa6afacad8b4a33398a1b6749070e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"Driver impact"},{"line_number":208,"context_line":"-------------"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Drivers that wish to support this functionality need to implement three new"},{"line_number":211,"context_line":"driver interfaces::"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def setup_multiple_subnet_server(self, network_info, metadata\u003dNone):"},{"line_number":214,"context_line":"    \"\"\"Setup a share server with network allocations on multiple subnets."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    :param network_info: Dictionary containing network parameters for share"},{"line_number":217,"context_line":"        server creation, with the map of network allocations and security"},{"line_number":218,"context_line":"        services among them."},{"line_number":219,"context_line":"    :param metadata: a dictionary, for now containing a key \u0027request_host\u0027."},{"line_number":220,"context_line":"    :return Dictionary with back end details to be saved in the database."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        Example::"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            {\u0027server_name\u0027: \u0027my_share_server\u0027}"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        raise NotImplementedError()"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def teardown_multiple_subnet_server("},{"line_number":230,"context_line":"        self, server_details, security_services\u003dNone):"},{"line_number":231,"context_line":"    \"\"\"Tears down a share server with network allocations on multiple subnets."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    :param server_details: Back end details for share server being torn down."},{"line_number":234,"context_line":"    :param security_services: Security services associated with the share"},{"line_number":235,"context_line":"        server being torn down."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    \"\"\""},{"line_number":238,"context_line":"    raise NotImplementedError()"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def update_share_server_network_allocations("},{"line_number":241,"context_line":"        self, network_info, server_details):"},{"line_number":242,"context_line":"    \"\"\"Updates a share server\u0027s network allocations."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    :param network_info: Dictionary containing network parameters for share"},{"line_number":245,"context_line":"        server creation, with the map of network allocations and security"},{"line_number":246,"context_line":"        services among them."},{"line_number":247,"context_line":"    :param server_details: Back end details for share server being torn down."},{"line_number":248,"context_line":"    :return Dictionary with updated back end details to be saved in the"},{"line_number":249,"context_line":"            database."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        Example::"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            {\u0027server_name\u0027: \u0027my_share_server\u0027}"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        \"\"\""},{"line_number":256,"context_line":"        raise NotImplementedError()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Drivers should expect to receive multiple network allocations. The total number"},{"line_number":260,"context_line":"should be the number of subnets associated with the same AZ multiplied by the"},{"line_number":261,"context_line":"number of allocations reported by the driver. The network allocations entry in"},{"line_number":262,"context_line":"the dictionary ``network_info`` will now be a list of key-value pairs where"},{"line_number":263,"context_line":"they key is the neutron subnet and the value is the list of allocations in that"},{"line_number":264,"context_line":"subnet."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_a82855ec","line":264,"range":{"start_line":210,"start_character":0,"end_line":264,"end_character":7},"in_reply_to":"3f79a3b5_64735650","updated":"2018-11-28 12:54:07.000000000","message":"I think you got it backwards. All drivers that implement the new interface can get rid of the old one. What we can do is have the new driver interface invoked, and in case of \"NotImplementedError\" fallback to the older one, that all the old drivers have implemented.\n\nAlternatively, we could have the old driver interface renamed to something like \"setup_server_single_subnet\", and the new ones would have the same name. But for this to make sense we would need to rename all current driver implementations to \"setup_server_single_subnet\". Is this what you meant?","commit_id":"3dc7aae2bddefb02a99fba002873ca5a428278e1"}]}