)]}'
{"specs/train/update-share-type-name-or-description.rst":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"743a70cd97504d62cd355f60b73e748d9e5234ca","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposed to update the name and/or description of ``share-type``"},{"line_number":14,"context_line":"after create an share type, that support update the name and/or description of"},{"line_number":15,"context_line":"share-type without change other attribute."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_35061022","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":61},"updated":"2019-05-30 00:34:47.000000000","message":"s/``name`` and/or ``description``","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2cd8a0838b1009fd456c07f9caea5eeb4c7fdcaf","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposed to update the name and/or description of ``share-type``"},{"line_number":14,"context_line":"after create an share type, that support update the name and/or description of"},{"line_number":15,"context_line":"share-type without change other attribute."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_fb786990","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":61},"in_reply_to":"bfb3d3c7_35061022","updated":"2019-05-30 03:08:56.000000000","message":"Done","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"743a70cd97504d62cd355f60b73e748d9e5234ca","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposed to update the name and/or description of ``share-type``"},{"line_number":14,"context_line":"after create an share type, that support update the name and/or description of"},{"line_number":15,"context_line":"share-type without change other attribute."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_55014405","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":15},"updated":"2019-05-30 00:34:47.000000000","message":"s/a","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"743a70cd97504d62cd355f60b73e748d9e5234ca","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposed to update the name and/or description of ``share-type``"},{"line_number":14,"context_line":"after create an share type, that support update the name and/or description of"},{"line_number":15,"context_line":"share-type without change other attribute."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_f8014f06","line":14,"range":{"start_line":14,"start_character":33,"end_line":14,"end_character":75},"updated":"2019-05-30 00:34:47.000000000","message":"supporting update the ``name`` and/or ``description``","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2cd8a0838b1009fd456c07f9caea5eeb4c7fdcaf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposed to update the name and/or description of ``share-type``"},{"line_number":14,"context_line":"after create an share type, that support update the name and/or description of"},{"line_number":15,"context_line":"share-type without change other attribute."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_db71e5a9","line":14,"range":{"start_line":14,"start_character":33,"end_line":14,"end_character":75},"in_reply_to":"bfb3d3c7_f8014f06","updated":"2019-05-30 03:08:56.000000000","message":"Done","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"743a70cd97504d62cd355f60b73e748d9e5234ca","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":"Currently, only the name and description and public access of share-type is"},{"line_number":20,"context_line":"set when the share-type is created, and not allowed to be edited after the"},{"line_number":21,"context_line":"share-type is created. We can only set extra spec for share-type. But not"},{"line_number":22,"context_line":"name or description or public access for share-type."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_d5477476","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":58},"updated":"2019-05-30 00:34:47.000000000","message":"s/``name``, ``description`` and/or ``share_type_access:is_public``","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2cd8a0838b1009fd456c07f9caea5eeb4c7fdcaf","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":"Currently, only the name and description and public access of share-type is"},{"line_number":20,"context_line":"set when the share-type is created, and not allowed to be edited after the"},{"line_number":21,"context_line":"share-type is created. We can only set extra spec for share-type. But not"},{"line_number":22,"context_line":"name or description or public access for share-type."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_5b8bb566","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":58},"in_reply_to":"bfb3d3c7_d5477476","updated":"2019-05-30 03:08:56.000000000","message":"Done","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"743a70cd97504d62cd355f60b73e748d9e5234ca","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Currently, only the name and description and public access of share-type is"},{"line_number":20,"context_line":"set when the share-type is created, and not allowed to be edited after the"},{"line_number":21,"context_line":"share-type is created. We can only set extra spec for share-type. But not"},{"line_number":22,"context_line":"name or description or public access for share-type."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_35585054","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":36},"updated":"2019-05-30 00:34:47.000000000","message":"ditto.","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2cd8a0838b1009fd456c07f9caea5eeb4c7fdcaf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Currently, only the name and description and public access of share-type is"},{"line_number":20,"context_line":"set when the share-type is created, and not allowed to be edited after the"},{"line_number":21,"context_line":"share-type is created. We can only set extra spec for share-type. But not"},{"line_number":22,"context_line":"name or description or public access for share-type."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_5be09526","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":36},"in_reply_to":"bfb3d3c7_35585054","updated":"2019-05-30 03:08:56.000000000","message":"Done","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"743a70cd97504d62cd355f60b73e748d9e5234ca","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"---------"},{"line_number":26,"context_line":"As a user, I would like to update the attribute of share-type, and I can set"},{"line_number":27,"context_line":"the name or description or public access of share-type after created. I would"},{"line_number":28,"context_line":"prefer this when I need  a new share-type and do not have to create a new one."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_d53c54e2","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":40},"updated":"2019-05-30 00:34:47.000000000","message":"ditto.","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2cd8a0838b1009fd456c07f9caea5eeb4c7fdcaf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"---------"},{"line_number":26,"context_line":"As a user, I would like to update the attribute of share-type, and I can set"},{"line_number":27,"context_line":"the name or description or public access of share-type after created. I would"},{"line_number":28,"context_line":"prefer this when I need  a new share-type and do not have to create a new one."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_1bd8dd78","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":40},"in_reply_to":"bfb3d3c7_d53c54e2","updated":"2019-05-30 03:08:56.000000000","message":"Done","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"743a70cd97504d62cd355f60b73e748d9e5234ca","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  - Add ``update`` method to ``ShareTypesController`` class."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  - Add ``name``, ``description`` and ``share_type_access:is_public``"},{"line_number":39,"context_line":"    parameters to ``share_type`` of the request body."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - Make the ``name`` and ``description`` parameters optional. And their"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_352db0a7","line":38,"range":{"start_line":38,"start_character":34,"end_line":38,"end_character":37},"updated":"2019-05-30 00:34:47.000000000","message":"s/and/or","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2cd8a0838b1009fd456c07f9caea5eeb4c7fdcaf","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  - Add ``update`` method to ``ShareTypesController`` class."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  - Add ``name``, ``description`` and ``share_type_access:is_public``"},{"line_number":39,"context_line":"    parameters to ``share_type`` of the request body."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - Make the ``name`` and ``description`` parameters optional. And their"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_db42450f","line":38,"range":{"start_line":38,"start_character":34,"end_line":38,"end_character":37},"in_reply_to":"bfb3d3c7_352db0a7","updated":"2019-05-30 03:08:56.000000000","message":"Done","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c1b7afcce1472345756fd57cd8f9a9e01eb0400d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"----------"},{"line_number":132,"context_line":"* Add update share-type API to the **Share types**."},{"line_number":133,"context_line":"* Add update share-type API to manilaclient, and it will be supported"},{"line_number":134,"context_line":"  by \u0027manila type-update\u0027."},{"line_number":135,"context_line":"* Add functional tests"},{"line_number":136,"context_line":"* Add units tests."},{"line_number":137,"context_line":"* Add tempest tests."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_187c6381","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":26},"updated":"2019-05-30 00:53:39.000000000","message":"Can you consider adding support in the manila-ui project as well?","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2cd8a0838b1009fd456c07f9caea5eeb4c7fdcaf","unresolved":false,"context_lines":[{"line_number":131,"context_line":"----------"},{"line_number":132,"context_line":"* Add update share-type API to the **Share types**."},{"line_number":133,"context_line":"* Add update share-type API to manilaclient, and it will be supported"},{"line_number":134,"context_line":"  by \u0027manila type-update\u0027."},{"line_number":135,"context_line":"* Add functional tests"},{"line_number":136,"context_line":"* Add units tests."},{"line_number":137,"context_line":"* Add tempest tests."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_1b669dc2","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":26},"in_reply_to":"bfb3d3c7_187c6381","updated":"2019-05-30 03:08:56.000000000","message":"Done","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6b5b29c469022ab6a18c2446f43b140c1f3c99fd","unresolved":false,"context_lines":[{"line_number":131,"context_line":"----------"},{"line_number":132,"context_line":"* Add update share-type API to the **Share types**."},{"line_number":133,"context_line":"* Add update share-type API to manilaclient, and it will be supported"},{"line_number":134,"context_line":"  by \u0027manila type-update\u0027."},{"line_number":135,"context_line":"* Add functional tests"},{"line_number":136,"context_line":"* Add units tests."},{"line_number":137,"context_line":"* Add tempest tests."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_d8a00b45","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":26},"in_reply_to":"bfb3d3c7_187c6381","updated":"2019-05-30 02:09:09.000000000","message":"Good idea. This implementation will be added to manila-ui after the update share-type API code is completed.","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6b5b29c469022ab6a18c2446f43b140c1f3c99fd","unresolved":false,"context_lines":[{"line_number":132,"context_line":"* Add update share-type API to the **Share types**."},{"line_number":133,"context_line":"* Add update share-type API to manilaclient, and it will be supported"},{"line_number":134,"context_line":"  by \u0027manila type-update\u0027."},{"line_number":135,"context_line":"* Add functional tests"},{"line_number":136,"context_line":"* Add units tests."},{"line_number":137,"context_line":"* Add tempest tests."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_788b1fc2","line":135,"updated":"2019-05-30 02:09:09.000000000","message":"* Add update share-type API to **manila-ui** project","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2cd8a0838b1009fd456c07f9caea5eeb4c7fdcaf","unresolved":false,"context_lines":[{"line_number":132,"context_line":"* Add update share-type API to the **Share types**."},{"line_number":133,"context_line":"* Add update share-type API to manilaclient, and it will be supported"},{"line_number":134,"context_line":"  by \u0027manila type-update\u0027."},{"line_number":135,"context_line":"* Add functional tests"},{"line_number":136,"context_line":"* Add units tests."},{"line_number":137,"context_line":"* Add tempest tests."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_fb62a9ad","line":135,"in_reply_to":"bfb3d3c7_788b1fc2","updated":"2019-05-30 03:08:56.000000000","message":"Done","commit_id":"f474fad3a39f271e88e21e060a489bf8639b08d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"acb78a15d02372a58d0a4f5d3cb697e152e6aabe","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Update share-type\u0027s name and/or description in Stein"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_8255fdfc","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":52},"updated":"2019-06-18 04:10:52.000000000","message":"\"metadata\"\n\nsince it involves all the modifiable fields now. Also, don\u0027t need the release name in the heading.","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a8f20cfe3e709b2ea139feeef63bc77fa39c40e","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Update share-type\u0027s name and/or description in Stein"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_82b41df4","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":52},"in_reply_to":"9fb8cfa7_8255fdfc","updated":"2019-06-18 04:12:56.000000000","message":"Also, the current release is \"Train\"","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c9571d2e632eb92ee4f76657138ad8ca37572070","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Update share-type\u0027s name and/or description in Stein"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_c5821f53","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":52},"in_reply_to":"9fb8cfa7_8255fdfc","updated":"2019-06-18 06:40:34.000000000","message":"Done","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c9571d2e632eb92ee4f76657138ad8ca37572070","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Update share-type\u0027s name and/or description in Stein"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_e5872361","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":52},"in_reply_to":"9fb8cfa7_82b41df4","updated":"2019-06-18 06:40:34.000000000","message":"sorry, i am ignore this.","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"acb78a15d02372a58d0a4f5d3cb697e152e6aabe","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposed to update the ``name`` and/or ``description`` of"},{"line_number":14,"context_line":"``share-type`` after create a share type, that support update the ``name``"},{"line_number":15,"context_line":"and/or ``description`` of share-type without change other attribute."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_623c89bf","line":13,"range":{"start_line":13,"start_character":69,"end_line":13,"end_character":70},"updated":"2019-06-18 04:10:52.000000000","message":"and ``is_public`` attribute","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c9571d2e632eb92ee4f76657138ad8ca37572070","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/update-share-type-name-or-description"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposed to update the ``name`` and/or ``description`` of"},{"line_number":14,"context_line":"``share-type`` after create a share type, that support update the ``name``"},{"line_number":15,"context_line":"and/or ``description`` of share-type without change other attribute."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_85f18704","line":13,"range":{"start_line":13,"start_character":69,"end_line":13,"end_character":70},"in_reply_to":"9fb8cfa7_623c89bf","updated":"2019-06-18 06:40:34.000000000","message":"Done","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"acb78a15d02372a58d0a4f5d3cb697e152e6aabe","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":"Add a new function API to the **Share types**."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Add a update share-type API:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  - Add ``update`` method to ``ShareTypesController`` class."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_a27361b1","line":36,"range":{"start_line":36,"start_character":29,"end_line":36,"end_character":30},"updated":"2019-06-18 04:10:52.000000000","message":"\", available in a new micro version of the manila API:\"","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c9571d2e632eb92ee4f76657138ad8ca37572070","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":"Add a new function API to the **Share types**."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Add a update share-type API:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  - Add ``update`` method to ``ShareTypesController`` class."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_65f493d0","line":36,"range":{"start_line":36,"start_character":29,"end_line":36,"end_character":30},"in_reply_to":"9fb8cfa7_a27361b1","updated":"2019-06-18 06:40:34.000000000","message":"Done","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"88634f99d42688a234cc688f51f56a6dc297f778","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":50,"context_line":"    not updated."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":53,"context_line":"    share type will not updated."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    If ``name`` is \"\", the name of share type is not valid."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_4d58d454","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":32},"updated":"2019-05-30 14:21:07.000000000","message":"Updating this field from \"false\" to \"true\" (private to public) will require that there are no share type accesses granted. \n\nUpdating this field from \"true\" to \"false\" (public to private) will require that there are no shares of this share type.","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"acb78a15d02372a58d0a4f5d3cb697e152e6aabe","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":50,"context_line":"    not updated."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":53,"context_line":"    share type will not updated."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    If ``name`` is \"\", the name of share type is not valid."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_e29e39b7","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":32},"in_reply_to":"9fb8cfa7_4410a857","updated":"2019-06-18 04:10:52.000000000","message":"Great, thanks for reverting here with the tests. As accepted in the Manila meeting on the 13th of June [1], this sounds like a good plan.\n\n\n[1] http://eavesdrop.openstack.org/meetings/manila/2019/manila.2019-06-13-15.00.log.html#l-43","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b24a345b549ca49b99a3dc9126d04dae4a1a9596","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":50,"context_line":"    not updated."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":53,"context_line":"    share type will not updated."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    If ``name`` is \"\", the name of share type is not valid."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_97740b6a","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":32},"in_reply_to":"9fb8cfa7_8999b020","updated":"2019-06-06 22:27:10.000000000","message":"Thanks for the detailed explanation Haixin. For transition from private to public, your views for retaining the share type accesses makes sense. We do not allow retrieving accesses granted to a public share type, so the behavior you outlined should work.\n\n\nHowever, going from public to private *might* break the Manila API; we might want to confirm this behavior. \n\nI want to propose we discuss this specific thing in the weekly community meeting, and see what other contributors think.\n\nhttps://wiki.openstack.org/wiki/Manila/Meetings","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ce32cd49cc33c33aa78b935c90f48a30148ead79","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":50,"context_line":"    not updated."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":53,"context_line":"    share type will not updated."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    If ``name`` is \"\", the name of share type is not valid."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_9747a777","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":32},"in_reply_to":"bfb3d3c7_4d58d454","updated":"2019-05-31 06:39:33.000000000","message":"Updating this field from \"false\" to \"true\" (private to public) will require that there are no share type accesses granted. \n\n-- IMO, even if the share-type in the \u0027private\u0027 state and has accesses granted, it is possible to directly make this field from \"false\" to \"true\" (private to public), because of the share-type already exist and accesses granted does not affect other project user to create **share** with this share-type. At this point, the purpose of the share-type set \u0027public\u0027 has been achieved.\nAccesses grant information for this share-type can be manually updated when it is subsequently required to go back to \u0027private\u0027. In short, it is not necessary to make sure there are no share-type accesses granted as long as the purpose of set \u0027public\u0027 is achieved.\n\n\nUpdating this field from \"true\" to \"false\" (public to private) will require that there are no shares of this share type.\n\n-- IMO, even if some shares created with this share-type, you can still updating this field from \"true\" to \"false\" (public to private), because the share-type from  \u0027public\u0027 to \u0027private\u0027, only means that project with no granted, will not be able to use the share-type to create share again, but previously created shares with this share-type will not be affected in any way. Because at the database level, these shares have been associated with the share-type, and still keep the characteristics of the share-type, does not affect the other share operations.\nFor example, the administrator started to let all users use one storage backend, the the share-type belongs to this storage backend, and users used this share-type to create many share instances. Later, the administrator wants to reclaim the use rights of some users. At this time, the administrator should be able to directly set the share-type to \u0027private\u0027, and only granted project(users) can continue to use it. If the administrator cannot set the share-type to \u0027private\u0027 at this time, it\u0027s obviously unreasonable.","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a101f810023510cf7faf44398ffdcaf1df3dd672","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":50,"context_line":"    not updated."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":53,"context_line":"    share type will not updated."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    If ``name`` is \"\", the name of share type is not valid."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_8999b020","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":32},"in_reply_to":"bfb3d3c7_9747a777","updated":"2019-06-02 06:39:27.000000000","message":"Emm...yes, if we want to update \u0027is_public\u0027, we have to accept this change.","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a25147f0249290578b15f14dcce5c54ef7a50126","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":50,"context_line":"    not updated."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":53,"context_line":"    share type will not updated."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    If ``name`` is \"\", the name of share type is not valid."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_4410a857","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":32},"in_reply_to":"bfb3d3c7_9747a777","updated":"2019-06-14 02:32:08.000000000","message":"I\u0027ve tried to set share type from public to private，then test some manila api of share with that share type,i found everything is normal, we should just make sure that the share type doc mentions that people need to be careful when changing anything significant about a share type","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a8f20cfe3e709b2ea139feeef63bc77fa39c40e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Assignee(s)"},{"line_number":125,"context_line":"-----------"},{"line_number":126,"context_line":"Primary assignee:"},{"line_number":127,"context_line":"  haixin"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Other contributors:"},{"line_number":130,"context_line":"  Brin Zhang"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_62e24904","line":127,"range":{"start_line":127,"start_character":2,"end_line":127,"end_character":8},"updated":"2019-06-18 04:12:56.000000000","message":"Is this the implementer\u0027s name as well as IRC nick?\n\nIf not, can you add your Name as well?","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c9571d2e632eb92ee4f76657138ad8ca37572070","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Assignee(s)"},{"line_number":125,"context_line":"-----------"},{"line_number":126,"context_line":"Primary assignee:"},{"line_number":127,"context_line":"  haixin"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Other contributors:"},{"line_number":130,"context_line":"  Brin Zhang"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_e5d64328","line":127,"range":{"start_line":127,"start_character":2,"end_line":127,"end_character":8},"in_reply_to":"9fb8cfa7_62e24904","updated":"2019-06-18 06:40:34.000000000","message":"yes,this is my IRC nick.","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a8f20cfe3e709b2ea139feeef63bc77fa39c40e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  haixin"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Other contributors:"},{"line_number":130,"context_line":"  Brin Zhang"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Work Items"},{"line_number":133,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_c2ba15e0","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":12},"updated":"2019-06-18 04:12:56.000000000","message":"Would be useful to provide an IRC nick here, along with the name.","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c9571d2e632eb92ee4f76657138ad8ca37572070","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  haixin"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Other contributors:"},{"line_number":130,"context_line":"  Brin Zhang"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Work Items"},{"line_number":133,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_45e5cf09","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":12},"in_reply_to":"9fb8cfa7_c2ba15e0","updated":"2019-06-18 06:40:34.000000000","message":"s/Brin Zhang/brinzhang","commit_id":"525aca644b9cb5eb41a54089fa16ecbbda76bcb8"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c0d078fa6a12a245284a9fb6c0aebda7e850ba39","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As a user, I would like to update the attribute of share-type, and I can"},{"line_number":29,"context_line":"set the ``name``, ``description`` and/or ``share_type_access:is_public``"},{"line_number":30,"context_line":"of share-type after created. I would prefer this when I need a new share-type"},{"line_number":31,"context_line":"and do not have to create a new one."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_6a8e6528","line":30,"range":{"start_line":28,"start_character":11,"end_line":30,"end_character":28},"updated":"2019-06-21 01:53:01.000000000","message":"This phrase is a little bit ambiguous, sounds like currently I\u0027m able to set these attributes after share-type creation (but I\u0027m not, if I understood correctly).\n\n\"I would like to update the ..., and to update its ``name``, ``description`` and/or ``share_type_access:is_public`` after created.\"\nwould sound better.","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75940152c3f3896975a725d1aa3722a859434bf9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Use Cases"},{"line_number":27,"context_line":"---------"},{"line_number":28,"context_line":"As a user, I would like to update the attribute of share-type, and I can"},{"line_number":29,"context_line":"set the ``name``, ``description`` and/or ``share_type_access:is_public``"},{"line_number":30,"context_line":"of share-type after created. I would prefer this when I need a new share-type"},{"line_number":31,"context_line":"and do not have to create a new one."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_d7591635","line":30,"range":{"start_line":28,"start_character":11,"end_line":30,"end_character":28},"in_reply_to":"9fb8cfa7_6a8e6528","updated":"2019-06-24 06:51:34.000000000","message":"Done","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c0d078fa6a12a245284a9fb6c0aebda7e850ba39","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    length not more than 255. ``share_type_access:is_public`` parameters"},{"line_number":47,"context_line":"    is also optional, but it\u0027s a **boolean** type."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    If ``name`` is **NULL**, the name of share type will not updated."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":52,"context_line":"    not updated."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_8ac079e2","line":49,"range":{"start_line":49,"start_character":61,"end_line":49,"end_character":68},"updated":"2019-06-21 01:53:01.000000000","message":"be updated","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75940152c3f3896975a725d1aa3722a859434bf9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    length not more than 255. ``share_type_access:is_public`` parameters"},{"line_number":47,"context_line":"    is also optional, but it\u0027s a **boolean** type."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    If ``name`` is **NULL**, the name of share type will not updated."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":52,"context_line":"    not updated."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_973b9ec6","line":49,"range":{"start_line":49,"start_character":61,"end_line":49,"end_character":68},"in_reply_to":"9fb8cfa7_8ac079e2","updated":"2019-06-24 06:51:34.000000000","message":"Done","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c0d078fa6a12a245284a9fb6c0aebda7e850ba39","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    If ``name`` is **NULL**, the name of share type will not updated."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":52,"context_line":"    not updated."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":55,"context_line":"    share type will not updated."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_2ab70d89","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":15},"updated":"2019-06-21 01:53:01.000000000","message":"be updated","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75940152c3f3896975a725d1aa3722a859434bf9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    If ``name`` is **NULL**, the name of share type will not updated."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    If ``description`` is **NULL**, the description of share type will"},{"line_number":52,"context_line":"    not updated."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":55,"context_line":"    share type will not updated."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_374af254","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":15},"in_reply_to":"9fb8cfa7_2ab70d89","updated":"2019-06-24 06:51:34.000000000","message":"Done","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c0d078fa6a12a245284a9fb6c0aebda7e850ba39","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    not updated."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":55,"context_line":"    share type will not updated."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    If ``name`` is \"\", the name of share type is not valid."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_0aac8933","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":31},"updated":"2019-06-21 01:53:01.000000000","message":"be updated","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75940152c3f3896975a725d1aa3722a859434bf9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    not updated."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    If ``share_type_access:is_public`` is **NULL**, the public access of"},{"line_number":55,"context_line":"    share type will not updated."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    If ``name`` is \"\", the name of share type is not valid."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_57452642","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":31},"in_reply_to":"9fb8cfa7_0aac8933","updated":"2019-06-24 06:51:34.000000000","message":"Done","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c0d078fa6a12a245284a9fb6c0aebda7e850ba39","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  * 400(Bad Request), 401(Unauthorized), 403(Forbidden),"},{"line_number":82,"context_line":"  404(Not Found), 409(Conflict)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The config of update share-type attribute will be able to add"},{"line_number":85,"context_line":"to request payload ::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    {"},{"line_number":88,"context_line":"        \"share_type\": {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_95909a97","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":19},"updated":"2019-06-21 01:53:01.000000000","message":"This phrase is a little bit confusing. Does it mean\n\"Update share-type request will accept the following payload: \"?","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75940152c3f3896975a725d1aa3722a859434bf9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  * 400(Bad Request), 401(Unauthorized), 403(Forbidden),"},{"line_number":82,"context_line":"  404(Not Found), 409(Conflict)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The config of update share-type attribute will be able to add"},{"line_number":85,"context_line":"to request payload ::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    {"},{"line_number":88,"context_line":"        \"share_type\": {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_b7a4a209","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":19},"in_reply_to":"9fb8cfa7_95909a97","updated":"2019-06-24 06:51:34.000000000","message":"Done","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c0d078fa6a12a245284a9fb6c0aebda7e850ba39","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Other end user impact"},{"line_number":104,"context_line":"---------------------"},{"line_number":105,"context_line":"User will be able to update share-type attribute after created. Manila client"},{"line_number":106,"context_line":"may add help to inform users this new function."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Performance Impact"},{"line_number":109,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_156fcac5","line":106,"range":{"start_line":106,"start_character":16,"end_line":106,"end_character":46},"updated":"2019-06-21 01:53:01.000000000","message":"\"inform users about this new function\" or\n\"inform users of this new function\".","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75940152c3f3896975a725d1aa3722a859434bf9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Other end user impact"},{"line_number":104,"context_line":"---------------------"},{"line_number":105,"context_line":"User will be able to update share-type attribute after created. Manila client"},{"line_number":106,"context_line":"may add help to inform users this new function."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Performance Impact"},{"line_number":109,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_37b8b228","line":106,"range":{"start_line":106,"start_character":16,"end_line":106,"end_character":46},"in_reply_to":"9fb8cfa7_156fcac5","updated":"2019-06-24 06:51:34.000000000","message":"Done","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c0d078fa6a12a245284a9fb6c0aebda7e850ba39","unresolved":false,"context_lines":[{"line_number":162,"context_line":"History"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":".. list-table:: Revisions"},{"line_number":165,"context_line":"      :header-rows: 1"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"   * - Release Name"},{"line_number":168,"context_line":"     - Description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_754f266a","line":165,"range":{"start_line":165,"start_character":6,"end_line":165,"end_character":21},"updated":"2019-06-21 01:53:01.000000000","message":"Seems like this instruction is not being parsed correctly. It\u0027s being printed literally[0].\n\n[0]http://logs.openstack.org/09/661209/3/check/openstack-tox-docs/123475a/html/specs/train/update-share-type-name-or-description.html#history","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75940152c3f3896975a725d1aa3722a859434bf9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"History"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":".. list-table:: Revisions"},{"line_number":165,"context_line":"      :header-rows: 1"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"   * - Release Name"},{"line_number":168,"context_line":"     - Description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_17080ed7","line":165,"range":{"start_line":165,"start_character":6,"end_line":165,"end_character":21},"in_reply_to":"9fb8cfa7_754f266a","updated":"2019-06-24 06:51:34.000000000","message":"i think it is OK.","commit_id":"c864d85a9652ecf6450ca7073acef171bc671aec"}]}