)]}'
{"specs/ussuri/spec-lite-limit-max-replica-amount.rst":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b675750b7bc76fb75c79656117c084647b877fb8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"           able to specify the max number of replicas that a given share is able"},{"line_number":11,"context_line":"           to have according to the backend capacity."},{"line_number":12,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":13,"context_line":"           called ``max_replica_per_share``, then, when creating a share\\"},{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_6c557dc0","line":13,"range":{"start_line":13,"start_character":72,"end_line":13,"end_character":73},"updated":"2020-01-29 13:18:30.000000000","message":"remove","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec83d7753ddb8c4f8116fb215cf507a7b9950fa1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"           able to specify the max number of replicas that a given share is able"},{"line_number":11,"context_line":"           to have according to the backend capacity."},{"line_number":12,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":13,"context_line":"           called ``max_replica_per_share``, then, when creating a share\\"},{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_8cb8f9e7","line":13,"range":{"start_line":13,"start_character":72,"end_line":13,"end_character":73},"in_reply_to":"3fa7e38b_6c557dc0","updated":"2020-01-29 13:33:13.000000000","message":"Done","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b675750b7bc76fb75c79656117c084647b877fb8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. A database migration will be created in order to update all"},{"line_number":18,"context_line":"           the existent share types, adding them the new extra spec. In the"},{"line_number":19,"context_line":"           database update, a default of 2 replicas will be set due to some"},{"line_number":20,"context_line":"           backends capability. All administrators will need to update the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_cc6591b1","line":17,"updated":"2020-01-29 13:18:30.000000000","message":"If so, it will deny the new share replica creation.","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec83d7753ddb8c4f8116fb215cf507a7b9950fa1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. A database migration will be created in order to update all"},{"line_number":18,"context_line":"           the existent share types, adding them the new extra spec. In the"},{"line_number":19,"context_line":"           database update, a default of 2 replicas will be set due to some"},{"line_number":20,"context_line":"           backends capability. All administrators will need to update the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_2cc78567","line":17,"in_reply_to":"3fa7e38b_cc6591b1","updated":"2020-01-29 13:33:13.000000000","message":"Done","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b675750b7bc76fb75c79656117c084647b877fb8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. A database migration will be created in order to update all"},{"line_number":18,"context_line":"           the existent share types, adding them the new extra spec. In the"},{"line_number":19,"context_line":"           database update, a default of 2 replicas will be set due to some"},{"line_number":20,"context_line":"           backends capability. All administrators will need to update the"},{"line_number":21,"context_line":"           share type according to their backend capacity, and will set the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_ccfa71b9","line":18,"range":{"start_line":17,"start_character":64,"end_line":18,"end_character":67},"updated":"2020-01-29 13:18:30.000000000","message":"to add the new share type extra spec for all the existent share types.","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec83d7753ddb8c4f8116fb215cf507a7b9950fa1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. A database migration will be created in order to update all"},{"line_number":18,"context_line":"           the existent share types, adding them the new extra spec. In the"},{"line_number":19,"context_line":"           database update, a default of 2 replicas will be set due to some"},{"line_number":20,"context_line":"           backends capability. All administrators will need to update the"},{"line_number":21,"context_line":"           share type according to their backend capacity, and will set the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_ec140d9b","line":18,"range":{"start_line":17,"start_character":64,"end_line":18,"end_character":67},"in_reply_to":"3fa7e38b_ccfa71b9","updated":"2020-01-29 13:33:13.000000000","message":"Done","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b675750b7bc76fb75c79656117c084647b877fb8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. A database migration will be created in order to update all"},{"line_number":18,"context_line":"           the existent share types, adding them the new extra spec. In the"},{"line_number":19,"context_line":"           database update, a default of 2 replicas will be set due to some"},{"line_number":20,"context_line":"           backends capability. All administrators will need to update the"},{"line_number":21,"context_line":"           share type according to their backend capacity, and will set the"},{"line_number":22,"context_line":"           extra spec according to the number of replicas that shares created"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_ac2db545","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":26},"updated":"2020-01-29 13:18:30.000000000","message":"migration","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec83d7753ddb8c4f8116fb215cf507a7b9950fa1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. A database migration will be created in order to update all"},{"line_number":18,"context_line":"           the existent share types, adding them the new extra spec. In the"},{"line_number":19,"context_line":"           database update, a default of 2 replicas will be set due to some"},{"line_number":20,"context_line":"           backends capability. All administrators will need to update the"},{"line_number":21,"context_line":"           share type according to their backend capacity, and will set the"},{"line_number":22,"context_line":"           extra spec according to the number of replicas that shares created"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_ac7855f6","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":26},"in_reply_to":"3fa7e38b_ac2db545","updated":"2020-01-29 13:33:13.000000000","message":"Done","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b675750b7bc76fb75c79656117c084647b877fb8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"           value. A database migration will be created in order to update all"},{"line_number":18,"context_line":"           the existent share types, adding them the new extra spec. In the"},{"line_number":19,"context_line":"           database update, a default of 2 replicas will be set due to some"},{"line_number":20,"context_line":"           backends capability. All administrators will need to update the"},{"line_number":21,"context_line":"           share type according to their backend capacity, and will set the"},{"line_number":22,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":23,"context_line":"           under the given share type are able to have. When creating a new"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_6c233d58","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":30},"updated":"2020-01-29 13:18:30.000000000","message":"capacity","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec83d7753ddb8c4f8116fb215cf507a7b9950fa1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"           value. A database migration will be created in order to update all"},{"line_number":18,"context_line":"           the existent share types, adding them the new extra spec. In the"},{"line_number":19,"context_line":"           database update, a default of 2 replicas will be set due to some"},{"line_number":20,"context_line":"           backends capability. All administrators will need to update the"},{"line_number":21,"context_line":"           share type according to their backend capacity, and will set the"},{"line_number":22,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":23,"context_line":"           under the given share type are able to have. When creating a new"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_4c7be1f1","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":30},"in_reply_to":"3fa7e38b_6c233d58","updated":"2020-01-29 13:33:13.000000000","message":"Done","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b675750b7bc76fb75c79656117c084647b877fb8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":23,"context_line":"           under the given share type are able to have. When creating a new"},{"line_number":24,"context_line":"           share type, if the user does not specify the new extra spec, the"},{"line_number":25,"context_line":"           service will automatically set this value to 2 and in case the"},{"line_number":26,"context_line":"           administrators needs to change the value, they will need to update"},{"line_number":27,"context_line":"           the extra spec."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_acd29531","line":25,"range":{"start_line":25,"start_character":56,"end_line":25,"end_character":57},"updated":"2020-01-29 13:18:30.000000000","message":"``2``?","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec83d7753ddb8c4f8116fb215cf507a7b9950fa1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":23,"context_line":"           under the given share type are able to have. When creating a new"},{"line_number":24,"context_line":"           share type, if the user does not specify the new extra spec, the"},{"line_number":25,"context_line":"           service will automatically set this value to 2 and in case the"},{"line_number":26,"context_line":"           administrators needs to change the value, they will need to update"},{"line_number":27,"context_line":"           the extra spec."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_cc6ef12b","line":25,"range":{"start_line":25,"start_character":56,"end_line":25,"end_character":57},"in_reply_to":"3fa7e38b_acd29531","updated":"2020-01-29 13:33:13.000000000","message":"Done","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b675750b7bc76fb75c79656117c084647b877fb8","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":timeline: Include in Ussusri release."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":":link: https://review.opendev.org/#/c/696136/"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_0c472920","line":31,"range":{"start_line":31,"start_character":22,"end_line":31,"end_character":29},"updated":"2020-01-29 13:18:30.000000000","message":"Ussuri","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec83d7753ddb8c4f8116fb215cf507a7b9950fa1","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":timeline: Include in Ussusri release."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":":link: https://review.opendev.org/#/c/696136/"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_acbb75e1","line":31,"range":{"start_line":31,"start_character":22,"end_line":31,"end_character":29},"in_reply_to":"3fa7e38b_0c472920","updated":"2020-01-29 13:33:13.000000000","message":"Done","commit_id":"0c5ba74f6907eba5417a441eea4f7fc9f4d16f15"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"39d6246349c8b02bae4281fda291f9d60acf410a","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":":problem: Currently, Manila allows the creation of unlimited share replicas of"},{"line_number":5,"context_line":"          a given share. This it is a problem for both ``DHSS\u003dTrue`` and"},{"line_number":6,"context_line":"          ``DHSS\u003dFalse`` modes. It makes the user able to deplete the storage"},{"line_number":7,"context_line":"          resources and have troubles depending on the configured backend."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":":solution: We should handle with this issue in a way where the administrator is"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_ecf08d62","line":6,"range":{"start_line":6,"start_character":35,"end_line":6,"end_character":57},"updated":"2020-01-29 13:37:55.000000000","message":"nit: \"it lets the user deplete\" or \"it allows the user to deplete\"","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a81b066da9e0d39448dbc1f15b2041bf6d69d88","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":":problem: Currently, Manila allows the creation of unlimited share replicas of"},{"line_number":5,"context_line":"          a given share. This it is a problem for both ``DHSS\u003dTrue`` and"},{"line_number":6,"context_line":"          ``DHSS\u003dFalse`` modes. It makes the user able to deplete the storage"},{"line_number":7,"context_line":"          resources and have troubles depending on the configured backend."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":":solution: We should handle with this issue in a way where the administrator is"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_2c1c6579","line":6,"range":{"start_line":6,"start_character":35,"end_line":6,"end_character":57},"in_reply_to":"3fa7e38b_ecf08d62","updated":"2020-01-29 14:17:07.000000000","message":"Done","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"39d6246349c8b02bae4281fda291f9d60acf410a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"          ``DHSS\u003dFalse`` modes. It makes the user able to deplete the storage"},{"line_number":7,"context_line":"          resources and have troubles depending on the configured backend."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":":solution: We should handle with this issue in a way where the administrator is"},{"line_number":10,"context_line":"           able to specify the max number of replicas that a given share is"},{"line_number":11,"context_line":"           able to have according to the backend capacity."},{"line_number":12,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":13,"context_line":"           called ``max_replica_per_share``, then, when creating a share"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_ac94d5e7","line":10,"range":{"start_line":9,"start_character":21,"end_line":10,"end_character":26},"updated":"2020-01-29 13:37:55.000000000","message":"nit: \"let the administrator specify\"","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a81b066da9e0d39448dbc1f15b2041bf6d69d88","unresolved":false,"context_lines":[{"line_number":6,"context_line":"          ``DHSS\u003dFalse`` modes. It makes the user able to deplete the storage"},{"line_number":7,"context_line":"          resources and have troubles depending on the configured backend."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":":solution: We should handle with this issue in a way where the administrator is"},{"line_number":10,"context_line":"           able to specify the max number of replicas that a given share is"},{"line_number":11,"context_line":"           able to have according to the backend capacity."},{"line_number":12,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":13,"context_line":"           called ``max_replica_per_share``, then, when creating a share"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_ec216db3","line":10,"range":{"start_line":9,"start_character":21,"end_line":10,"end_character":26},"in_reply_to":"3fa7e38b_ac94d5e7","updated":"2020-01-29 14:17:07.000000000","message":"Done","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"39d6246349c8b02bae4281fda291f9d60acf410a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":13,"context_line":"           called ``max_replica_per_share``, then, when creating a share"},{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. If so, the request to create a new replica will be denied."},{"line_number":18,"context_line":"           A database migration will be created in order to to add the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_4c9761eb","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":24},"updated":"2020-01-29 13:37:55.000000000","message":"nit: \"source\"","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a81b066da9e0d39448dbc1f15b2041bf6d69d88","unresolved":false,"context_lines":[{"line_number":12,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":13,"context_line":"           called ``max_replica_per_share``, then, when creating a share"},{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. If so, the request to create a new replica will be denied."},{"line_number":18,"context_line":"           A database migration will be created in order to to add the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_8c16b957","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":24},"in_reply_to":"3fa7e38b_4c9761eb","updated":"2020-01-29 14:17:07.000000000","message":"Done","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"39d6246349c8b02bae4281fda291f9d60acf410a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"           called ``max_replica_per_share``, then, when creating a share"},{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. If so, the request to create a new replica will be denied."},{"line_number":18,"context_line":"           A database migration will be created in order to to add the"},{"line_number":19,"context_line":"           new share type extra spec for all existent share types. In the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_cc8a71bb","line":16,"range":{"start_line":16,"start_character":31,"end_line":16,"end_character":62},"updated":"2020-01-29 13:37:55.000000000","message":"nit: \"does not exceed\"","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a81b066da9e0d39448dbc1f15b2041bf6d69d88","unresolved":false,"context_lines":[{"line_number":13,"context_line":"           called ``max_replica_per_share``, then, when creating a share"},{"line_number":14,"context_line":"           replica, Manila will check the value of ``max_replica_per_share``"},{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. If so, the request to create a new replica will be denied."},{"line_number":18,"context_line":"           A database migration will be created in order to to add the"},{"line_number":19,"context_line":"           new share type extra spec for all existent share types. In the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_6c0fbd37","line":16,"range":{"start_line":16,"start_character":31,"end_line":16,"end_character":62},"in_reply_to":"3fa7e38b_cc8a71bb","updated":"2020-01-29 14:17:07.000000000","message":"If it somehow exceeds is only in the case where the user had for instance 10 replicas of a given share and the database migration was applied. Other than the mentioned case, it would never exceed. So I think I\u0027ll rephrase it in another way. Thanks for pointing this out, so I can improve the sentence :)","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"39d6246349c8b02bae4281fda291f9d60acf410a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. If so, the request to create a new replica will be denied."},{"line_number":18,"context_line":"           A database migration will be created in order to to add the"},{"line_number":19,"context_line":"           new share type extra spec for all existent share types. In the"},{"line_number":20,"context_line":"           database migration, a default of two replicas will be set due to"},{"line_number":21,"context_line":"           some backends capacity. All administrators will need to update the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_4cb0c18d","line":18,"range":{"start_line":18,"start_character":57,"end_line":18,"end_character":62},"updated":"2020-01-29 13:37:55.000000000","message":"to","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a81b066da9e0d39448dbc1f15b2041bf6d69d88","unresolved":false,"context_lines":[{"line_number":15,"context_line":"           of the parent share\u0027s share type and also will check if the number"},{"line_number":16,"context_line":"           of existent replicas is not bigger than or equal to the max replica"},{"line_number":17,"context_line":"           value. If so, the request to create a new replica will be denied."},{"line_number":18,"context_line":"           A database migration will be created in order to to add the"},{"line_number":19,"context_line":"           new share type extra spec for all existent share types. In the"},{"line_number":20,"context_line":"           database migration, a default of two replicas will be set due to"},{"line_number":21,"context_line":"           some backends capacity. All administrators will need to update the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_0c0ac925","line":18,"range":{"start_line":18,"start_character":57,"end_line":18,"end_character":62},"in_reply_to":"3fa7e38b_4cb0c18d","updated":"2020-01-29 14:17:07.000000000","message":"Done","commit_id":"bb82d3730d0ce94004b10592dc1f2834654a4db4"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"6d6e4d2644fdbb9a12fb3bca11e309fb9a5ecd56","unresolved":false,"context_lines":[{"line_number":2,"context_line":"-----------------------------------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":":problem: Currently, Manila allows the creation of unlimited share replicas of"},{"line_number":5,"context_line":"          a given share. This it is a problem for both ``DHSS\u003dTrue`` and"},{"line_number":6,"context_line":"          ``DHSS\u003dFalse`` modes. It allows the user to deplete the storage"},{"line_number":7,"context_line":"          resources and have troubles depending on the configured backend."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_47973aeb","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":35},"updated":"2020-01-29 14:36:19.000000000","message":"\"This is\" or \"It is\"","commit_id":"d77d2efea4d692395c3a83126954a7ae7e486ba3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a880a8247520f713d54456f49c3a4246528cb7ba","unresolved":false,"context_lines":[{"line_number":2,"context_line":"-----------------------------------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":":problem: Currently, Manila allows the creation of unlimited share replicas of"},{"line_number":5,"context_line":"          a given share. This it is a problem for both ``DHSS\u003dTrue`` and"},{"line_number":6,"context_line":"          ``DHSS\u003dFalse`` modes. It allows the user to deplete the storage"},{"line_number":7,"context_line":"          resources and have troubles depending on the configured backend."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_5952be12","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":35},"in_reply_to":"3fa7e38b_47973aeb","updated":"2020-01-29 14:39:26.000000000","message":"Done","commit_id":"d77d2efea4d692395c3a83126954a7ae7e486ba3"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"6d6e4d2644fdbb9a12fb3bca11e309fb9a5ecd56","unresolved":false,"context_lines":[{"line_number":24,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":25,"context_line":"           under the given share type are able to have. When creating a new"},{"line_number":26,"context_line":"           share type, if the user does not specify the new extra spec, the"},{"line_number":27,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":28,"context_line":"           administrators needs to change the value, they will need to update"},{"line_number":29,"context_line":"           the extra spec."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_075ce249","line":28,"range":{"start_line":27,"start_character":66,"end_line":28,"end_character":31},"updated":"2020-01-29 14:36:19.000000000","message":"\"if the administrator needs\" or \"if the administrators need\"","commit_id":"d77d2efea4d692395c3a83126954a7ae7e486ba3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a880a8247520f713d54456f49c3a4246528cb7ba","unresolved":false,"context_lines":[{"line_number":24,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":25,"context_line":"           under the given share type are able to have. When creating a new"},{"line_number":26,"context_line":"           share type, if the user does not specify the new extra spec, the"},{"line_number":27,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":28,"context_line":"           administrators needs to change the value, they will need to update"},{"line_number":29,"context_line":"           the extra spec."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_396822ba","line":28,"range":{"start_line":27,"start_character":66,"end_line":28,"end_character":31},"in_reply_to":"3fa7e38b_075ce249","updated":"2020-01-29 14:39:26.000000000","message":"Done","commit_id":"d77d2efea4d692395c3a83126954a7ae7e486ba3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f40dce4b5b5c6ccfddf6362a120b13505141308b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Spec Lite: Limit amount of allowed replicas per share"},{"line_number":2,"context_line":"-----------------------------------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":":problem: Currently, Manila allows the creation of unlimited share replicas of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_edc16482","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":23},"updated":"2020-01-29 19:49:42.000000000","message":"number","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a725f64a5561936f94908f6df4382ace06e45c84","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Spec Lite: Limit amount of allowed replicas per share"},{"line_number":2,"context_line":"-----------------------------------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":":problem: Currently, Manila allows the creation of unlimited share replicas of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_5221ec4e","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":23},"in_reply_to":"3fa7e38b_edc16482","updated":"2020-02-06 14:19:16.000000000","message":"Done","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f40dce4b5b5c6ccfddf6362a120b13505141308b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"          a given share. It is a problem for both ``DHSS\u003dTrue`` and"},{"line_number":6,"context_line":"          ``DHSS\u003dFalse`` modes. It allows the user to deplete the storage"},{"line_number":7,"context_line":"          resources and have troubles depending on the configured backend."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":":solution: We should let the administrator specify the max number of replicas"},{"line_number":10,"context_line":"           that a given share is able to have according to the backend"},{"line_number":11,"context_line":"           capacity."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_cdf588ca","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":0},"updated":"2020-01-29 19:49:42.000000000","message":"Another problem that we have currently is the lack of end user visibility when it comes to what backends support. \n\nFor example, with ZFSOnLinux or NetApp, the user can have as many replicas for a given share as there are pools that support replication between them. However, for Huawei, the user can only have two replicas. There\u0027s no mechanism to convey this currently - for example, if there are 3 NetApp pools, the user can have one primary share and two replicas - creating a fourth one will fail asynchronously. This isn\u0027t desirable - if we\u0027re going to make a tenant visible extra-spec, users can be better informed; and since the extra-spec will be checked at teh API, we\u0027ll be able to fail fast and early, providing synchronous errors as opposed to a vague asynchronous failure.","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a725f64a5561936f94908f6df4382ace06e45c84","unresolved":false,"context_lines":[{"line_number":5,"context_line":"          a given share. It is a problem for both ``DHSS\u003dTrue`` and"},{"line_number":6,"context_line":"          ``DHSS\u003dFalse`` modes. It allows the user to deplete the storage"},{"line_number":7,"context_line":"          resources and have troubles depending on the configured backend."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":":solution: We should let the administrator specify the max number of replicas"},{"line_number":10,"context_line":"           that a given share is able to have according to the backend"},{"line_number":11,"context_line":"           capacity."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_19a85b89","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":0},"in_reply_to":"3fa7e38b_cdf588ca","updated":"2020-02-06 14:19:16.000000000","message":"Done","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f40dce4b5b5c6ccfddf6362a120b13505141308b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":13,"context_line":"           called ``max_replica_per_share``. Then, when creating a share"},{"line_number":14,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":15,"context_line":"           of the source share\u0027s share type, and will verify if the number"},{"line_number":16,"context_line":"           of existent replicas of the source share. If the amount of existent"},{"line_number":17,"context_line":"           share replicas has already reached the ``max_replica_per_share``"},{"line_number":18,"context_line":"           value, the request to create a new replica will be denied."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_2d39bca0","line":15,"range":{"start_line":15,"start_character":61,"end_line":15,"end_character":64},"updated":"2020-01-29 19:49:42.000000000","message":"remove \"if\"","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a725f64a5561936f94908f6df4382ace06e45c84","unresolved":false,"context_lines":[{"line_number":12,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":13,"context_line":"           called ``max_replica_per_share``. Then, when creating a share"},{"line_number":14,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":15,"context_line":"           of the source share\u0027s share type, and will verify if the number"},{"line_number":16,"context_line":"           of existent replicas of the source share. If the amount of existent"},{"line_number":17,"context_line":"           share replicas has already reached the ``max_replica_per_share``"},{"line_number":18,"context_line":"           value, the request to create a new replica will be denied."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_121b741d","line":15,"range":{"start_line":15,"start_character":61,"end_line":15,"end_character":64},"in_reply_to":"3fa7e38b_2d39bca0","updated":"2020-02-06 14:19:16.000000000","message":"Done","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f40dce4b5b5c6ccfddf6362a120b13505141308b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"           called ``max_replica_per_share``. Then, when creating a share"},{"line_number":14,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":15,"context_line":"           of the source share\u0027s share type, and will verify if the number"},{"line_number":16,"context_line":"           of existent replicas of the source share. If the amount of existent"},{"line_number":17,"context_line":"           share replicas has already reached the ``max_replica_per_share``"},{"line_number":18,"context_line":"           value, the request to create a new replica will be denied."},{"line_number":19,"context_line":"           A database migration will be created in order to add the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_ad4ccc3f","line":16,"range":{"start_line":16,"start_character":60,"end_line":16,"end_character":66},"updated":"2020-01-29 19:49:42.000000000","message":"nit: number","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a725f64a5561936f94908f6df4382ace06e45c84","unresolved":false,"context_lines":[{"line_number":13,"context_line":"           called ``max_replica_per_share``. Then, when creating a share"},{"line_number":14,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":15,"context_line":"           of the source share\u0027s share type, and will verify if the number"},{"line_number":16,"context_line":"           of existent replicas of the source share. If the amount of existent"},{"line_number":17,"context_line":"           share replicas has already reached the ``max_replica_per_share``"},{"line_number":18,"context_line":"           value, the request to create a new replica will be denied."},{"line_number":19,"context_line":"           A database migration will be created in order to add the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_f20fb8d1","line":16,"range":{"start_line":16,"start_character":60,"end_line":16,"end_character":66},"in_reply_to":"3fa7e38b_ad4ccc3f","updated":"2020-02-06 14:19:16.000000000","message":"Done","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7ef43f5dd39dfea39d084d13ae855603d6b12cda","unresolved":false,"context_lines":[{"line_number":19,"context_line":"           A database migration will be created in order to add the"},{"line_number":20,"context_line":"           new share type extra spec for all existent share types. In the"},{"line_number":21,"context_line":"           database migration, a default of two replicas will be set due to"},{"line_number":22,"context_line":"           some backends capacity. All administrators will need to update the"},{"line_number":23,"context_line":"           share type according to their backend capacity, and will set the"},{"line_number":24,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":25,"context_line":"           under the given share type are able to have. When creating a new"},{"line_number":26,"context_line":"           share type, if the user does not specify the new extra spec, the"},{"line_number":27,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":28,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":29,"context_line":"           the extra spec."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_6e5800fc","line":29,"range":{"start_line":22,"start_character":35,"end_line":29,"end_character":26},"updated":"2020-01-30 13:18:43.000000000","message":"Don\u0027t think that admins that don\u0027t have this limitation will fill about that, since they are will need to update all already created share-types to an specific value. Do you plan to provide a config option for this parameter?","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a725f64a5561936f94908f6df4382ace06e45c84","unresolved":false,"context_lines":[{"line_number":19,"context_line":"           A database migration will be created in order to add the"},{"line_number":20,"context_line":"           new share type extra spec for all existent share types. In the"},{"line_number":21,"context_line":"           database migration, a default of two replicas will be set due to"},{"line_number":22,"context_line":"           some backends capacity. All administrators will need to update the"},{"line_number":23,"context_line":"           share type according to their backend capacity, and will set the"},{"line_number":24,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":25,"context_line":"           under the given share type are able to have. When creating a new"},{"line_number":26,"context_line":"           share type, if the user does not specify the new extra spec, the"},{"line_number":27,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":28,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":29,"context_line":"           the extra spec."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_3922f7a7","line":29,"range":{"start_line":22,"start_character":35,"end_line":29,"end_character":26},"in_reply_to":"3fa7e38b_6e5800fc","updated":"2020-02-06 14:19:16.000000000","message":"Yes, I do, it was also discussed a long time ago. Thanks for bringing this up.","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f40dce4b5b5c6ccfddf6362a120b13505141308b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":28,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":29,"context_line":"           the extra spec."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":":timeline: Include in Ussuri release."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_239d4bb9","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":0},"updated":"2020-01-29 19:49:42.000000000","message":"What\u0027s the error code and message and API impact?","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a725f64a5561936f94908f6df4382ace06e45c84","unresolved":false,"context_lines":[{"line_number":27,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":28,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":29,"context_line":"           the extra spec."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":":timeline: Include in Ussuri release."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_b90ca73a","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":0},"in_reply_to":"3fa7e38b_239d4bb9","updated":"2020-02-06 14:19:16.000000000","message":"Done","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"50826e296ecc6a8c2ce6b65eff27a38cbf9a095d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":29,"context_line":"           the extra spec."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":":timeline: Include in Ussuri release."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_99a34745","line":31,"updated":"2020-01-30 12:07:36.000000000","message":"Add sth talking about the admin intervention need","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a725f64a5561936f94908f6df4382ace06e45c84","unresolved":false,"context_lines":[{"line_number":28,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":29,"context_line":"           the extra spec."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":":timeline: Include in Ussuri release."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_593493ab","line":31,"in_reply_to":"3fa7e38b_99a34745","updated":"2020-02-06 14:19:16.000000000","message":"Done","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"40d7126fdcb2e40279e7d51cf33ac9e98cffc2b4","unresolved":false,"context_lines":[{"line_number":31,"context_line":":impacts: DocImpact, APIImpact"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":":timeline: Include in Ussuri release."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":":link: https://review.opendev.org/#/c/696136/"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":":assignee: carloss"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_3faa306d","line":34,"updated":"2020-01-30 15:56:37.000000000","message":"add an \u0027alternatives\u0027 session talking about the solution using the quota system.","commit_id":"a144f0c2a999e9cee4b28a44f86e804e61cedae2"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"5777848b48c755965240d2e238afbaf0fd07cf31","unresolved":false,"context_lines":[{"line_number":56,"context_line":"           - REST API Impact."},{"line_number":57,"context_line":"               - When creating a share replica, if the share has already reached"},{"line_number":58,"context_line":"                 the number of allowed share replicas, the API will return"},{"line_number":59,"context_line":"                 ``404 BadRequest`` with the following message: \"The share with"},{"line_number":60,"context_line":"                 the id \u0027share_id\u0027 already reached the limit of replicas"},{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_410251bb","line":59,"range":{"start_line":59,"start_character":19,"end_line":59,"end_character":22},"updated":"2020-02-06 15:24:09.000000000","message":"I would expect status code 400","commit_id":"98de9a8e7203b8101cd60bce8c8b7af51314b256"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5c134325588eb169b2b9bba9007839ba6931857","unresolved":false,"context_lines":[{"line_number":56,"context_line":"           - REST API Impact."},{"line_number":57,"context_line":"               - When creating a share replica, if the share has already reached"},{"line_number":58,"context_line":"                 the number of allowed share replicas, the API will return"},{"line_number":59,"context_line":"                 ``404 BadRequest`` with the following message: \"The share with"},{"line_number":60,"context_line":"                 the id \u0027share_id\u0027 already reached the limit of replicas"},{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_65baf6ba","line":59,"range":{"start_line":59,"start_character":19,"end_line":59,"end_character":22},"in_reply_to":"3fa7e38b_410251bb","updated":"2020-02-06 17:46:48.000000000","message":"You\u0027re right. Thanks for pointing this out. I\u0027ve added the right name but added 404 instead of 400.","commit_id":"98de9a8e7203b8101cd60bce8c8b7af51314b256"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"5777848b48c755965240d2e238afbaf0fd07cf31","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                 the id \u0027share_id\u0027 already reached the limit of replicas"},{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"},{"line_number":63,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise the it will"},{"line_number":64,"context_line":"                 return ``422 UnprocessableEntity`` with the following message:"},{"line_number":65,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":66,"context_line":"                 an integer and greater than 1\"."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_21b635fe","line":63,"range":{"start_line":63,"start_character":65,"end_line":63,"end_character":68},"updated":"2020-02-06 15:24:09.000000000","message":"nit: word can be removed","commit_id":"98de9a8e7203b8101cd60bce8c8b7af51314b256"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5c134325588eb169b2b9bba9007839ba6931857","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                 the id \u0027share_id\u0027 already reached the limit of replicas"},{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"},{"line_number":63,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise the it will"},{"line_number":64,"context_line":"                 return ``422 UnprocessableEntity`` with the following message:"},{"line_number":65,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":66,"context_line":"                 an integer and greater than 1\"."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_25e63e4b","line":63,"range":{"start_line":63,"start_character":65,"end_line":63,"end_character":68},"in_reply_to":"3fa7e38b_21b635fe","updated":"2020-02-06 17:46:48.000000000","message":"Done","commit_id":"98de9a8e7203b8101cd60bce8c8b7af51314b256"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"5777848b48c755965240d2e238afbaf0fd07cf31","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise the it will"},{"line_number":64,"context_line":"                 return ``422 UnprocessableEntity`` with the following message:"},{"line_number":65,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":66,"context_line":"                 an integer and greater than 1\"."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"           - Documentation Impact"},{"line_number":69,"context_line":"               - Admin guide"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_e1533ddd","line":66,"range":{"start_line":66,"start_character":32,"end_line":66,"end_character":46},"updated":"2020-02-06 15:24:09.000000000","message":"I may want to set exactly 1 (or even 0). Where does this come from?","commit_id":"98de9a8e7203b8101cd60bce8c8b7af51314b256"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5c134325588eb169b2b9bba9007839ba6931857","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise the it will"},{"line_number":64,"context_line":"                 return ``422 UnprocessableEntity`` with the following message:"},{"line_number":65,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":66,"context_line":"                 an integer and greater than 1\"."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"           - Documentation Impact"},{"line_number":69,"context_line":"               - Admin guide"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_c5e3aa9f","line":66,"range":{"start_line":66,"start_character":32,"end_line":66,"end_character":46},"in_reply_to":"3fa7e38b_e1533ddd","updated":"2020-02-06 17:46:48.000000000","message":"This is a possibility. I don\u0027t see any problem coming if we allow the user set this value as 0.","commit_id":"98de9a8e7203b8101cd60bce8c8b7af51314b256"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"452f8860e64516ffa89a392b10e73cd425b9d877","unresolved":false,"context_lines":[{"line_number":27,"context_line":"           A database migration will be created in order to add the"},{"line_number":28,"context_line":"           new share type extra spec for all existent share types. In the"},{"line_number":29,"context_line":"           database migration, a default of two replicas will be set due to"},{"line_number":30,"context_line":"           some backends capacity. All administrators will need to update the"},{"line_number":31,"context_line":"           share type according to their backend capacity, and will set the"},{"line_number":32,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":33,"context_line":"           under the given share type are able to have. When creating a new"},{"line_number":34,"context_line":"           share type, if the user does not specify the new extra spec, the"},{"line_number":35,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":36,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":37,"context_line":"           the extra spec."},{"line_number":38,"context_line":"           The administrator will also be able to provide a new configuration"},{"line_number":39,"context_line":"           option called ``supported_replicas_per_share`` for each backend. The"},{"line_number":40,"context_line":"           scheduler will be improved in order to filter backends considering"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_959339a4","line":37,"range":{"start_line":30,"start_character":35,"end_line":37,"end_character":26},"updated":"2020-02-13 12:02:31.000000000","message":"I still miss some place saying that the default value for max_replica_per_share could be configured by the admin (instead of 2). In this way the admin that don\u0027t have this limitation wont need to care about this new extra-spec, and set a different value all the time that will create a new share-type or modify all already created share-types.","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0f14bb57a99d14c32af7e355df993bb5b3b2d5e7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"           A database migration will be created in order to add the"},{"line_number":28,"context_line":"           new share type extra spec for all existent share types. In the"},{"line_number":29,"context_line":"           database migration, a default of two replicas will be set due to"},{"line_number":30,"context_line":"           some backends capacity. All administrators will need to update the"},{"line_number":31,"context_line":"           share type according to their backend capacity, and will set the"},{"line_number":32,"context_line":"           extra spec according to the number of replicas that shares created"},{"line_number":33,"context_line":"           under the given share type are able to have. When creating a new"},{"line_number":34,"context_line":"           share type, if the user does not specify the new extra spec, the"},{"line_number":35,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":36,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":37,"context_line":"           the extra spec."},{"line_number":38,"context_line":"           The administrator will also be able to provide a new configuration"},{"line_number":39,"context_line":"           option called ``supported_replicas_per_share`` for each backend. The"},{"line_number":40,"context_line":"           scheduler will be improved in order to filter backends considering"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_aeddc63f","line":37,"range":{"start_line":30,"start_character":35,"end_line":37,"end_character":26},"in_reply_to":"3fa7e38b_959339a4","updated":"2020-02-13 14:49:37.000000000","message":"Done","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"452f8860e64516ffa89a392b10e73cd425b9d877","unresolved":false,"context_lines":[{"line_number":35,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":36,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":37,"context_line":"           the extra spec."},{"line_number":38,"context_line":"           The administrator will also be able to provide a new configuration"},{"line_number":39,"context_line":"           option called ``supported_replicas_per_share`` for each backend. The"},{"line_number":40,"context_line":"           scheduler will be improved in order to filter backends considering"},{"line_number":41,"context_line":"           this configuration option."},{"line_number":42,"context_line":"           This solution can be combined with an improvement, which"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_35d12557","line":39,"range":{"start_line":38,"start_character":64,"end_line":39,"end_character":17},"updated":"2020-02-13 12:02:31.000000000","message":"backend property?","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0f14bb57a99d14c32af7e355df993bb5b3b2d5e7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"           service will automatically set this value to ``2`` and in case the"},{"line_number":36,"context_line":"           administrators need to change the value, they will need to update"},{"line_number":37,"context_line":"           the extra spec."},{"line_number":38,"context_line":"           The administrator will also be able to provide a new configuration"},{"line_number":39,"context_line":"           option called ``supported_replicas_per_share`` for each backend. The"},{"line_number":40,"context_line":"           scheduler will be improved in order to filter backends considering"},{"line_number":41,"context_line":"           this configuration option."},{"line_number":42,"context_line":"           This solution can be combined with an improvement, which"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_f8670422","line":39,"range":{"start_line":38,"start_character":64,"end_line":39,"end_character":17},"in_reply_to":"3fa7e38b_35d12557","updated":"2020-02-13 14:49:37.000000000","message":"Done","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"452f8860e64516ffa89a392b10e73cd425b9d877","unresolved":false,"context_lines":[{"line_number":40,"context_line":"           scheduler will be improved in order to filter backends considering"},{"line_number":41,"context_line":"           this configuration option."},{"line_number":42,"context_line":"           This solution can be combined with an improvement, which"},{"line_number":43,"context_line":"           consists in defining tenant quotas for share sizes, and share"},{"line_number":44,"context_line":"           replicas using the existent quota system. So at the end,"},{"line_number":45,"context_line":"           the whole solution would have a way to avoid this bug, alongside"},{"line_number":46,"context_line":"           with an improvement that will help administrators to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_b541950a","line":43,"range":{"start_line":43,"start_character":50,"end_line":43,"end_character":61},"updated":"2020-02-13 12:02:31.000000000","message":"only replicas for now?","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0f14bb57a99d14c32af7e355df993bb5b3b2d5e7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"           scheduler will be improved in order to filter backends considering"},{"line_number":41,"context_line":"           this configuration option."},{"line_number":42,"context_line":"           This solution can be combined with an improvement, which"},{"line_number":43,"context_line":"           consists in defining tenant quotas for share sizes, and share"},{"line_number":44,"context_line":"           replicas using the existent quota system. So at the end,"},{"line_number":45,"context_line":"           the whole solution would have a way to avoid this bug, alongside"},{"line_number":46,"context_line":"           with an improvement that will help administrators to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_787314e6","line":43,"range":{"start_line":43,"start_character":50,"end_line":43,"end_character":61},"in_reply_to":"3fa7e38b_b541950a","updated":"2020-02-13 14:49:37.000000000","message":"Done","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"452f8860e64516ffa89a392b10e73cd425b9d877","unresolved":false,"context_lines":[{"line_number":56,"context_line":"           - REST API Impact."},{"line_number":57,"context_line":"               - When creating a share replica, if the share has already reached"},{"line_number":58,"context_line":"                 the number of allowed share replicas, the API will return"},{"line_number":59,"context_line":"                 ``400 BadRequest`` with the following message: \"The share with"},{"line_number":60,"context_line":"                 the id \u0027share_id\u0027 already reached the limit of replicas"},{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_556f0160","line":59,"range":{"start_line":59,"start_character":17,"end_line":59,"end_character":35},"updated":"2020-02-13 12:02:31.000000000","message":"I think that a 403 Forbidden will fit better since the user request is correct, but the limit of replicas was reached.","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0f14bb57a99d14c32af7e355df993bb5b3b2d5e7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"           - REST API Impact."},{"line_number":57,"context_line":"               - When creating a share replica, if the share has already reached"},{"line_number":58,"context_line":"                 the number of allowed share replicas, the API will return"},{"line_number":59,"context_line":"                 ``400 BadRequest`` with the following message: \"The share with"},{"line_number":60,"context_line":"                 the id \u0027share_id\u0027 already reached the limit of replicas"},{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_cb1fd408","line":59,"range":{"start_line":59,"start_character":17,"end_line":59,"end_character":35},"in_reply_to":"3fa7e38b_556f0160","updated":"2020-02-13 14:49:37.000000000","message":"Yeah, that makes sense.","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"452f8860e64516ffa89a392b10e73cd425b9d877","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"},{"line_number":63,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise it will return"},{"line_number":64,"context_line":"                 ``422 UnprocessableEntity`` with the following message:"},{"line_number":65,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":66,"context_line":"                 an integer and greater than or equal to 0.\"."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_b5c7553d","line":64,"range":{"start_line":64,"start_character":19,"end_line":64,"end_character":42},"updated":"2020-02-13 12:02:31.000000000","message":"This should be a 400 BadRequest since the user sent an invalid request/value.","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0f14bb57a99d14c32af7e355df993bb5b3b2d5e7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"},{"line_number":63,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise it will return"},{"line_number":64,"context_line":"                 ``422 UnprocessableEntity`` with the following message:"},{"line_number":65,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":66,"context_line":"                 an integer and greater than or equal to 0.\"."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_cbd4b420","line":64,"range":{"start_line":64,"start_character":19,"end_line":64,"end_character":42},"in_reply_to":"3fa7e38b_b5c7553d","updated":"2020-02-13 14:49:37.000000000","message":"Makes sense.","commit_id":"af70826a874b4b607ce872af8ad5b25f60bffdc7"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fb9e42004bf71e91f2e4bb16aaabecd2df0c7ee6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"           The scheduler will be improved in order to filter backends"},{"line_number":41,"context_line":"           considering this backend property."},{"line_number":42,"context_line":"           This solution can be combined with improvements, which"},{"line_number":43,"context_line":"           consists in defining a tenant for quota share replicas using the"},{"line_number":44,"context_line":"           existent quota system, and allow the administrator to set a default"},{"line_number":45,"context_line":"           value for the ``max_replica_per_share`` extra spec. So at the end,"},{"line_number":46,"context_line":"           the whole solution would have a way to avoid this bug, alongside"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_89d6c4c3","line":43,"range":{"start_line":43,"start_character":11,"end_line":43,"end_character":65},"updated":"2020-02-13 15:57:36.000000000","message":"consist of defining a project quota for share replicas","commit_id":"c2f70d78b625ed3cb775d5fe3a4018cbc624a9d9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e5c47a2de03cf2896fa847cddeaf988e5151f514","unresolved":false,"context_lines":[{"line_number":40,"context_line":"           The scheduler will be improved in order to filter backends"},{"line_number":41,"context_line":"           considering this backend property."},{"line_number":42,"context_line":"           This solution can be combined with improvements, which"},{"line_number":43,"context_line":"           consists in defining a tenant for quota share replicas using the"},{"line_number":44,"context_line":"           existent quota system, and allow the administrator to set a default"},{"line_number":45,"context_line":"           value for the ``max_replica_per_share`` extra spec. So at the end,"},{"line_number":46,"context_line":"           the whole solution would have a way to avoid this bug, alongside"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_3fdc9ee0","line":43,"range":{"start_line":43,"start_character":11,"end_line":43,"end_character":65},"in_reply_to":"3fa7e38b_89d6c4c3","updated":"2020-02-13 17:11:59.000000000","message":"Done","commit_id":"c2f70d78b625ed3cb775d5fe3a4018cbc624a9d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"794e52c10ee7ce81daefdcc05a50cb1ef48963e9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"           existent share replicas during a new replica creation request, and"},{"line_number":17,"context_line":"           be able to fail faster and synchronously."},{"line_number":18,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":19,"context_line":"           called ``max_replica_per_share``. Then, when creating a share"},{"line_number":20,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":21,"context_line":"           of the source share\u0027s share type, and will verify the number"},{"line_number":22,"context_line":"           of existent replicas of the source share. If the number of existent"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_7409d426","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":41},"updated":"2020-02-13 21:48:00.000000000","message":"max_replicas_per_share","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6686ce4ac4b652240b24336b5251d66b0c9cd67a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"           existent share replicas during a new replica creation request, and"},{"line_number":17,"context_line":"           be able to fail faster and synchronously."},{"line_number":18,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":19,"context_line":"           called ``max_replica_per_share``. Then, when creating a share"},{"line_number":20,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":21,"context_line":"           of the source share\u0027s share type, and will verify the number"},{"line_number":22,"context_line":"           of existent replicas of the source share. If the number of existent"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_5832bf0f","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":41},"in_reply_to":"3fa7e38b_7409d426","updated":"2020-02-14 20:25:06.000000000","message":"Done","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"794e52c10ee7ce81daefdcc05a50cb1ef48963e9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"           of existent replicas of the source share. If the number of existent"},{"line_number":23,"context_line":"           share replicas has already reached the ``max_replica_per_share``"},{"line_number":24,"context_line":"           value, the request to create a new replica will be denied."},{"line_number":25,"context_line":"           While creating the new extra-spec for the share type the user must"},{"line_number":26,"context_line":"           specify an integer value."},{"line_number":27,"context_line":"           A database migration will be created in order to add the"},{"line_number":28,"context_line":"           new share type extra spec for all existent share types. In the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_d423e8a8","line":25,"range":{"start_line":25,"start_character":68,"end_line":25,"end_character":72},"updated":"2020-02-13 21:48:00.000000000","message":"administrator","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6686ce4ac4b652240b24336b5251d66b0c9cd67a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"           of existent replicas of the source share. If the number of existent"},{"line_number":23,"context_line":"           share replicas has already reached the ``max_replica_per_share``"},{"line_number":24,"context_line":"           value, the request to create a new replica will be denied."},{"line_number":25,"context_line":"           While creating the new extra-spec for the share type the user must"},{"line_number":26,"context_line":"           specify an integer value."},{"line_number":27,"context_line":"           A database migration will be created in order to add the"},{"line_number":28,"context_line":"           new share type extra spec for all existent share types. In the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_381b4384","line":25,"range":{"start_line":25,"start_character":68,"end_line":25,"end_character":72},"in_reply_to":"3fa7e38b_d423e8a8","updated":"2020-02-14 20:25:06.000000000","message":"Done","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"794e52c10ee7ce81daefdcc05a50cb1ef48963e9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"           resources."},{"line_number":49,"context_line":"           The solution for the bug will require the administrator"},{"line_number":50,"context_line":"           intervention, since the database migration script will update all"},{"line_number":51,"context_line":"           the share types with a default value, and it may block the"},{"line_number":52,"context_line":"           administrator while creating new share replicas after migrating the"},{"line_number":53,"context_line":"           database."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":":impacts:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_944ed06a","line":52,"range":{"start_line":51,"start_character":66,"end_line":52,"end_character":24},"updated":"2020-02-13 21:48:00.000000000","message":"users","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6686ce4ac4b652240b24336b5251d66b0c9cd67a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"           resources."},{"line_number":49,"context_line":"           The solution for the bug will require the administrator"},{"line_number":50,"context_line":"           intervention, since the database migration script will update all"},{"line_number":51,"context_line":"           the share types with a default value, and it may block the"},{"line_number":52,"context_line":"           administrator while creating new share replicas after migrating the"},{"line_number":53,"context_line":"           database."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":":impacts:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_9815974e","line":52,"range":{"start_line":51,"start_character":66,"end_line":52,"end_character":24},"in_reply_to":"3fa7e38b_944ed06a","updated":"2020-02-14 20:25:06.000000000","message":"Done","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"794e52c10ee7ce81daefdcc05a50cb1ef48963e9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise it will return"},{"line_number":65,"context_line":"                 ``400 BadRequest`` with the following message:"},{"line_number":66,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":67,"context_line":"                 an integer and greater than or equal to 0.\"."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"           - Documentation Impact"},{"line_number":70,"context_line":"               - Admin guide"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_7460f4d0","line":67,"range":{"start_line":67,"start_character":32,"end_line":67,"end_character":59},"updated":"2020-02-13 21:48:00.000000000","message":"Interesting, setting this to 0 can turn off replication? What does setting this to 1 mean?\n\nMy thinking is that we\u0027d allow setting this value to \u00272\u0027 because we\u0027d consider a replicated share to have 1 active replica and 1 passive/inactive replica in simple dr cases.","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6686ce4ac4b652240b24336b5251d66b0c9cd67a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise it will return"},{"line_number":65,"context_line":"                 ``400 BadRequest`` with the following message:"},{"line_number":66,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":67,"context_line":"                 an integer and greater than or equal to 0.\"."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"           - Documentation Impact"},{"line_number":70,"context_line":"               - Admin guide"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_3bbc9d05","line":67,"range":{"start_line":67,"start_character":32,"end_line":67,"end_character":59},"in_reply_to":"3fa7e38b_555b7253","updated":"2020-02-14 20:25:06.000000000","message":"Thanks for your opinion here, Maurice.","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"b81251bc38ba91b6b5d7cb862c6e6a106388668f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise it will return"},{"line_number":65,"context_line":"                 ``400 BadRequest`` with the following message:"},{"line_number":66,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":67,"context_line":"                 an integer and greater than or equal to 0.\"."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"           - Documentation Impact"},{"line_number":70,"context_line":"               - Admin guide"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_555b7253","line":67,"range":{"start_line":67,"start_character":32,"end_line":67,"end_character":59},"in_reply_to":"3fa7e38b_7460f4d0","updated":"2020-02-14 05:28:38.000000000","message":"Thanks for that explanation, I never used replication tbh thus I asked why this can\u0027t be 1 or even 0 (in an earlier patch set).\n\nBoth values would mean turning off replication (I realize just now that the share itself automatically gets an active replica representation), which already can be done easier by omitting the replication_type extra spec.\n\ntl;dr: I agree with \u0027greater than 1\u0027","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6686ce4ac4b652240b24336b5251d66b0c9cd67a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise it will return"},{"line_number":65,"context_line":"                 ``400 BadRequest`` with the following message:"},{"line_number":66,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":67,"context_line":"                 an integer and greater than or equal to 0.\"."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"           - Documentation Impact"},{"line_number":70,"context_line":"               - Admin guide"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_9bcd91bb","line":67,"range":{"start_line":67,"start_character":32,"end_line":67,"end_character":59},"in_reply_to":"3fa7e38b_7460f4d0","updated":"2020-02-14 20:25:06.000000000","message":"Yeah, thinking again I also think that 0 would turn off replication.\nAnd about the max_replica_per_share min value, being greater than or equal to 2 makes more sense.","commit_id":"5451a2c513195e28cedb6437475179560e8a9e5c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f05ef12e99d826e79a0dde598e992f75669e2e56","unresolved":false,"context_lines":[{"line_number":17,"context_line":"           be able to fail faster and synchronously."},{"line_number":18,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":19,"context_line":"           called ``max_replicas_per_share``. Then, when creating a share"},{"line_number":20,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":21,"context_line":"           of the source share\u0027s share type, and will verify the number"},{"line_number":22,"context_line":"           of existent replicas of the source share. If the number of existent"},{"line_number":23,"context_line":"           share replicas has already reached the ``max_replica_per_share``"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_bb040d7e","line":20,"range":{"start_line":20,"start_character":44,"end_line":20,"end_character":65},"updated":"2020-02-14 20:36:02.000000000","message":"max_replicas_per_share","commit_id":"fdf46eb34a3c38d55c129e399169ce49f77f20b0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f82fc06bfa703f302e84e7fca79ea0e58522ec72","unresolved":false,"context_lines":[{"line_number":17,"context_line":"           be able to fail faster and synchronously."},{"line_number":18,"context_line":"           The proposed solution is to add a new extra spec to the share types"},{"line_number":19,"context_line":"           called ``max_replicas_per_share``. Then, when creating a share"},{"line_number":20,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":21,"context_line":"           of the source share\u0027s share type, and will verify the number"},{"line_number":22,"context_line":"           of existent replicas of the source share. If the number of existent"},{"line_number":23,"context_line":"           share replicas has already reached the ``max_replica_per_share``"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_8648d861","line":20,"range":{"start_line":20,"start_character":44,"end_line":20,"end_character":65},"in_reply_to":"3fa7e38b_bb040d7e","updated":"2020-02-14 21:23:05.000000000","message":"Done","commit_id":"fdf46eb34a3c38d55c129e399169ce49f77f20b0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f05ef12e99d826e79a0dde598e992f75669e2e56","unresolved":false,"context_lines":[{"line_number":20,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":21,"context_line":"           of the source share\u0027s share type, and will verify the number"},{"line_number":22,"context_line":"           of existent replicas of the source share. If the number of existent"},{"line_number":23,"context_line":"           share replicas has already reached the ``max_replica_per_share``"},{"line_number":24,"context_line":"           value, the request to create a new replica will be denied."},{"line_number":25,"context_line":"           While creating the new extra-spec for the share type the"},{"line_number":26,"context_line":"           administrator must specify an integer value."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_5bf7198f","line":23,"range":{"start_line":23,"start_character":52,"end_line":23,"end_character":73},"updated":"2020-02-14 20:36:02.000000000","message":"max_replicas_per_share","commit_id":"fdf46eb34a3c38d55c129e399169ce49f77f20b0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f82fc06bfa703f302e84e7fca79ea0e58522ec72","unresolved":false,"context_lines":[{"line_number":20,"context_line":"           replica, Manila will check the ``max_replica_per_share`` value"},{"line_number":21,"context_line":"           of the source share\u0027s share type, and will verify the number"},{"line_number":22,"context_line":"           of existent replicas of the source share. If the number of existent"},{"line_number":23,"context_line":"           share replicas has already reached the ``max_replica_per_share``"},{"line_number":24,"context_line":"           value, the request to create a new replica will be denied."},{"line_number":25,"context_line":"           While creating the new extra-spec for the share type the"},{"line_number":26,"context_line":"           administrator must specify an integer value."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_a64b945b","line":23,"range":{"start_line":23,"start_character":52,"end_line":23,"end_character":73},"in_reply_to":"3fa7e38b_5bf7198f","updated":"2020-02-14 21:23:05.000000000","message":"Done","commit_id":"fdf46eb34a3c38d55c129e399169ce49f77f20b0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f05ef12e99d826e79a0dde598e992f75669e2e56","unresolved":false,"context_lines":[{"line_number":42,"context_line":"           This solution can be combined with improvements, which"},{"line_number":43,"context_line":"           consists of defining a project quota for share replicas using the"},{"line_number":44,"context_line":"           existent quota system, and allow the administrator to set a default"},{"line_number":45,"context_line":"           value for the ``max_replica_per_share`` extra spec. So at the end,"},{"line_number":46,"context_line":"           the whole solution would have a way to avoid this bug, alongside"},{"line_number":47,"context_line":"           with an improvement that will help administrators to manage their"},{"line_number":48,"context_line":"           resources."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_dbea299f","line":45,"range":{"start_line":45,"start_character":27,"end_line":45,"end_character":48},"updated":"2020-02-14 20:36:02.000000000","message":"max_replicas_per_share","commit_id":"fdf46eb34a3c38d55c129e399169ce49f77f20b0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f82fc06bfa703f302e84e7fca79ea0e58522ec72","unresolved":false,"context_lines":[{"line_number":42,"context_line":"           This solution can be combined with improvements, which"},{"line_number":43,"context_line":"           consists of defining a project quota for share replicas using the"},{"line_number":44,"context_line":"           existent quota system, and allow the administrator to set a default"},{"line_number":45,"context_line":"           value for the ``max_replica_per_share`` extra spec. So at the end,"},{"line_number":46,"context_line":"           the whole solution would have a way to avoid this bug, alongside"},{"line_number":47,"context_line":"           with an improvement that will help administrators to manage their"},{"line_number":48,"context_line":"           resources."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_464e606d","line":45,"range":{"start_line":45,"start_character":27,"end_line":45,"end_character":48},"in_reply_to":"3fa7e38b_dbea299f","updated":"2020-02-14 21:23:05.000000000","message":"Done","commit_id":"fdf46eb34a3c38d55c129e399169ce49f77f20b0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f05ef12e99d826e79a0dde598e992f75669e2e56","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                 the id \u0027share_id\u0027 already reached the limit of replicas"},{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"},{"line_number":63,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise it will return"},{"line_number":64,"context_line":"                 ``400 BadRequest`` with the following message:"},{"line_number":65,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":66,"context_line":"                 an integer and greater than or equal to 2.\"."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_3bf01d92","line":63,"range":{"start_line":63,"start_character":19,"end_line":63,"end_character":40},"updated":"2020-02-14 20:36:02.000000000","message":"max_replicas_per_share","commit_id":"fdf46eb34a3c38d55c129e399169ce49f77f20b0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f82fc06bfa703f302e84e7fca79ea0e58522ec72","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                 the id \u0027share_id\u0027 already reached the limit of replicas"},{"line_number":61,"context_line":"                 according to its share type\"."},{"line_number":62,"context_line":"               - The API will expect an integer value while setting the"},{"line_number":63,"context_line":"                 ``max_replica_per_share`` extra spec, otherwise it will return"},{"line_number":64,"context_line":"                 ``400 BadRequest`` with the following message:"},{"line_number":65,"context_line":"                 \"The specified max replicas value \u0027non_integer_value\u0027 must be"},{"line_number":66,"context_line":"                 an integer and greater than or equal to 2.\"."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_66511c0c","line":63,"range":{"start_line":63,"start_character":19,"end_line":63,"end_character":40},"in_reply_to":"3fa7e38b_3bf01d92","updated":"2020-02-14 21:23:05.000000000","message":"Done","commit_id":"fdf46eb34a3c38d55c129e399169ce49f77f20b0"}]}