)]}'
{"specs/unimplemented/share-group-replica.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The following are the changes to be made:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* A new extra-spec for share group \u0027group_support_replica\u0027 will be added"},{"line_number":42,"context_line":"  to allow groups to be replicated."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* A new property for share \u0027replica_unit\u0027 will be added to decide"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_608f6623","line":41,"range":{"start_line":41,"start_character":36,"end_line":41,"end_character":57},"updated":"2020-02-28 00:24:34.000000000","message":"\"group_replication_support\"\n\nto be consistent with the other extra-specs we have:\n\nGroup type extra-specs:\n- consistent_snapshot_support\n\nShare type extra-specs:\n- snapshot_support\n- create_share_from_snapshot_support\n- revert_to_snapshot_support\n- mount_snapshot_support","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"582589d256524c3910ed4803991372ab18b5f5da","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The following are the changes to be made:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* A new extra-spec for share group \u0027group_support_replica\u0027 will be added"},{"line_number":42,"context_line":"  to allow groups to be replicated."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* A new property for share \u0027replica_unit\u0027 will be added to decide"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_3738ce3b","line":41,"range":{"start_line":41,"start_character":36,"end_line":41,"end_character":57},"in_reply_to":"1fa4df85_608f6623","updated":"2020-02-28 09:17:17.000000000","message":"Plan to change the new extra-specs to ‘group_replication_type’ (may have values writable, readable, dr, None ) Like the ‘ replication_type’ on share.\n\nWith the new extra-specs ‘group_replication_type’, need compared the value with ‘replication_type’ on share types.\nBecause when creating group, it will involve share types it supports. Need make sure ‘group_replication_type’ can cover ‘replication_type’ .","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The following are the changes to be made:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* A new extra-spec for share group \u0027group_support_replica\u0027 will be added"},{"line_number":42,"context_line":"  to allow groups to be replicated."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* A new property for share \u0027replica_unit\u0027 will be added to decide"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_267e666b","line":41,"range":{"start_line":41,"start_character":36,"end_line":41,"end_character":57},"in_reply_to":"1fa4df85_608f6623","updated":"2020-02-28 03:48:37.000000000","message":"will change to \u0027group_replication_support\u0027","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"The following are the changes to be made:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* A new extra-spec for share group \u0027group_support_replica\u0027 will be added"},{"line_number":42,"context_line":"  to allow groups to be replicated."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* A new property for share \u0027replica_unit\u0027 will be added to decide"},{"line_number":45,"context_line":"  which level backend support to do replica: share or group or doesn\u0027t support."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_003a3233","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":35},"updated":"2020-02-28 00:24:34.000000000","message":"There are three acceptable values to \"replication_support\" right now [1]: dr, readable, writable. \n\nGroup replication should probably have the same types?\n\n[1] https://docs.openstack.org/manila/latest/admin/shared-file-systems-share-replication.html#replication-types-supported","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"582589d256524c3910ed4803991372ab18b5f5da","unresolved":false,"context_lines":[{"line_number":39,"context_line":"The following are the changes to be made:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* A new extra-spec for share group \u0027group_support_replica\u0027 will be added"},{"line_number":42,"context_line":"  to allow groups to be replicated."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* A new property for share \u0027replica_unit\u0027 will be added to decide"},{"line_number":45,"context_line":"  which level backend support to do replica: share or group or doesn\u0027t support."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_771726a5","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":35},"in_reply_to":"1fa4df85_003a3233","updated":"2020-02-28 09:17:17.000000000","message":"I mean there is no limitation for single group have shares from different vendors/drivers, right?\nIn this case it might have different replication_type also.","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":39,"context_line":"The following are the changes to be made:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* A new extra-spec for share group \u0027group_support_replica\u0027 will be added"},{"line_number":42,"context_line":"  to allow groups to be replicated."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* A new property for share \u0027replica_unit\u0027 will be added to decide"},{"line_number":45,"context_line":"  which level backend support to do replica: share or group or doesn\u0027t support."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_a6e6d643","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":35},"in_reply_to":"1fa4df85_003a3233","updated":"2020-02-28 03:48:37.000000000","message":"Is that possible the driver can have different replication way, like have both \u0027dr\u0027 and \u0027wirite\u0027?\nSo the shares in same group might have different replication_type?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* A new extra-spec for share group \u0027group_support_replica\u0027 will be added"},{"line_number":42,"context_line":"  to allow groups to be replicated."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* A new property for share \u0027replica_unit\u0027 will be added to decide"},{"line_number":45,"context_line":"  which level backend support to do replica: share or group or doesn\u0027t support."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Add new API to create share group replica. It will create replica"},{"line_number":48,"context_line":"  share group and shares in it, register them in manila services."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_00f55283","line":45,"range":{"start_line":44,"start_character":2,"end_line":45,"end_character":79},"updated":"2020-02-28 00:24:34.000000000","message":"There\u0027s already a \"replication_type\" property in the share model - won\u0027t this suffice? Maybe we can overload that parameter instead of introducing a new one?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* A new extra-spec for share group \u0027group_support_replica\u0027 will be added"},{"line_number":42,"context_line":"  to allow groups to be replicated."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* A new property for share \u0027replica_unit\u0027 will be added to decide"},{"line_number":45,"context_line":"  which level backend support to do replica: share or group or doesn\u0027t support."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Add new API to create share group replica. It will create replica"},{"line_number":48,"context_line":"  share group and shares in it, register them in manila services."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_a6bfb6f9","line":45,"range":{"start_line":44,"start_character":2,"end_line":45,"end_character":79},"in_reply_to":"1fa4df85_00f55283","updated":"2020-02-28 03:48:37.000000000","message":"ok, will remove \u0027replica_unit\u0027","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  share group and shares in it, register them in manila services."},{"line_number":49,"context_line":"  And there are some scenarios need to be considered:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    * The driver supports to do replica every share separately."},{"line_number":52,"context_line":"    * The driver only supports to do replica for share server, and the share"},{"line_number":53,"context_line":"      server\u0027s shares are all in this group."},{"line_number":54,"context_line":"    * The driver only supports to do replica for share server, but the share"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_00231207","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":63},"updated":"2020-02-28 00:24:34.000000000","message":"Does this mean that such a driver does not support group replication, or does it mean that it can do both: individual share replication and group replication?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  share group and shares in it, register them in manila services."},{"line_number":49,"context_line":"  And there are some scenarios need to be considered:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    * The driver supports to do replica every share separately."},{"line_number":52,"context_line":"    * The driver only supports to do replica for share server, and the share"},{"line_number":53,"context_line":"      server\u0027s shares are all in this group."},{"line_number":54,"context_line":"    * The driver only supports to do replica for share server, but the share"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_e6736e7f","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":63},"in_reply_to":"1fa4df85_00231207","updated":"2020-02-28 03:48:37.000000000","message":"It can do both.\nIf the driver (like NetApp) can do replication for individual share, then it can use share replication or group replication as customers wish","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    * The driver only supports to do replica for share server, and the share"},{"line_number":53,"context_line":"      server\u0027s shares are all in this group."},{"line_number":54,"context_line":"    * The driver only supports to do replica for share server, but the share"},{"line_number":55,"context_line":"      server\u0027s shares are part in this group, the rest are not in group."},{"line_number":56,"context_line":"      Some vendors doesn\u0027t support such case because the replica need"},{"line_number":57,"context_line":"      starting from whole share server. (They can reject the request in their"},{"line_number":58,"context_line":"      own driver, and raise some exception. Framework should accept the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_60620641","line":55,"range":{"start_line":55,"start_character":46,"end_line":55,"end_character":72},"updated":"2020-02-28 00:24:34.000000000","message":"Can we just avoid scheduling non replicated shares to a given share server?\n\nIf a share group is created with \"group_replication_support\" extra-spec, it can be scheduled to its dedicated own share server on the given share network -\n\nthe driver can then isolate this share server just to shares belonging to that particular share group. If new shares are created on the same share server, but they don\u0027t belong to a group, the driver can put them on a different share server \n\nWould this serve as a simple solution to these possibilities?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    * The driver only supports to do replica for share server, and the share"},{"line_number":53,"context_line":"      server\u0027s shares are all in this group."},{"line_number":54,"context_line":"    * The driver only supports to do replica for share server, but the share"},{"line_number":55,"context_line":"      server\u0027s shares are part in this group, the rest are not in group."},{"line_number":56,"context_line":"      Some vendors doesn\u0027t support such case because the replica need"},{"line_number":57,"context_line":"      starting from whole share server. (They can reject the request in their"},{"line_number":58,"context_line":"      own driver, and raise some exception. Framework should accept the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_c6c0b22d","line":55,"range":{"start_line":55,"start_character":46,"end_line":55,"end_character":72},"in_reply_to":"1fa4df85_60620641","updated":"2020-02-28 03:48:37.000000000","message":"You mean is when creating shares, we detect whether the share-network is belonged to a \u0027group_replication_support\u0027 group, and assign a different server to non replicated share?\nSo you mean one share-network can mapped with multiple share-server?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Data model impact"},{"line_number":78,"context_line":"-----------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Add a new extra-spec called ``group_support_replica`` to"},{"line_number":81,"context_line":"``manila.db.sqlalchemy.models.ShareGroup`` model."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Add a new property called ``replica_unit`` to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_0051d262","line":80,"range":{"start_line":80,"start_character":30,"end_line":80,"end_character":51},"updated":"2020-02-28 00:24:34.000000000","message":"group_replication_support","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Data model impact"},{"line_number":78,"context_line":"-----------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Add a new extra-spec called ``group_support_replica`` to"},{"line_number":81,"context_line":"``manila.db.sqlalchemy.models.ShareGroup`` model."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Add a new property called ``replica_unit`` to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_c6f8b24a","line":80,"range":{"start_line":80,"start_character":30,"end_line":80,"end_character":51},"in_reply_to":"1fa4df85_0051d262","updated":"2020-02-28 03:48:37.000000000","message":"will change it","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Add a new extra-spec called ``group_support_replica`` to"},{"line_number":81,"context_line":"``manila.db.sqlalchemy.models.ShareGroup`` model."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Add a new property called ``replica_unit`` to"},{"line_number":84,"context_line":"``manila.db.sqlalchemy.models.ShareGroup`` model. The value (group, share,"},{"line_number":85,"context_line":"None) will be set when create share group."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_c04adaaa","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":42},"updated":"2020-02-28 00:24:34.000000000","message":"Don\u0027t see a need for this - what would be the use case?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Add a new extra-spec called ``group_support_replica`` to"},{"line_number":81,"context_line":"``manila.db.sqlalchemy.models.ShareGroup`` model."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Add a new property called ``replica_unit`` to"},{"line_number":84,"context_line":"``manila.db.sqlalchemy.models.ShareGroup`` model. The value (group, share,"},{"line_number":85,"context_line":"None) will be set when create share group."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_06d6cac4","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":42},"in_reply_to":"1fa4df85_c04adaaa","updated":"2020-02-28 03:48:37.000000000","message":"will remove it.","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        {"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"                    \"project_id\": \"test_project_id\","},{"line_number":99,"context_line":"                    \"share_group_id\": \"test_share_group_id\","},{"line_number":100,"context_line":"                    \"availability_zone\": \"test_availability_zone\","},{"line_number":101,"context_line":"                    ...."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_80f38273","line":98,"range":{"start_line":98,"start_character":20,"end_line":98,"end_character":52},"updated":"2020-02-28 00:24:34.000000000","message":"This is already present in the URI, not required in the body.","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        {"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"                    \"project_id\": \"test_project_id\","},{"line_number":99,"context_line":"                    \"share_group_id\": \"test_share_group_id\","},{"line_number":100,"context_line":"                    \"availability_zone\": \"test_availability_zone\","},{"line_number":101,"context_line":"                    ...."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_66f0de68","line":98,"range":{"start_line":98,"start_character":20,"end_line":98,"end_character":52},"in_reply_to":"1fa4df85_80f38273","updated":"2020-02-28 03:48:37.000000000","message":"will remove it.","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                    \"project_id\": \"test_project_id\","},{"line_number":99,"context_line":"                    \"share_group_id\": \"test_share_group_id\","},{"line_number":100,"context_line":"                    \"availability_zone\": \"test_availability_zone\","},{"line_number":101,"context_line":"                    ...."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_20eace74","line":101,"range":{"start_line":101,"start_character":20,"end_line":101,"end_character":24},"updated":"2020-02-28 00:24:34.000000000","message":"What else is required?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                    \"project_id\": \"test_project_id\","},{"line_number":99,"context_line":"                    \"share_group_id\": \"test_share_group_id\","},{"line_number":100,"context_line":"                    \"availability_zone\": \"test_availability_zone\","},{"line_number":101,"context_line":"                    ...."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_26eae674","line":101,"range":{"start_line":101,"start_character":20,"end_line":101,"end_character":24},"in_reply_to":"1fa4df85_20eace74","updated":"2020-02-28 03:48:37.000000000","message":"Will add others after rest api investigation.","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86ea68095ec60618229df22076315b7497adb1d9","unresolved":false,"context_lines":[{"line_number":200,"context_line":"-----------"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Primary assignee:"},{"line_number":203,"context_line":"  |"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_40a26a4d","line":203,"range":{"start_line":203,"start_character":2,"end_line":203,"end_character":3},"updated":"2020-02-28 00:24:34.000000000","message":"Are you not expecting to implement this yourself?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29291,"name":"DingDong","email":"dong.ding@emc.com","username":"DingDong"},"change_message_id":"08fe9e3599ad7583c4ddc760d13e3a7adb397557","unresolved":false,"context_lines":[{"line_number":200,"context_line":"-----------"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Primary assignee:"},{"line_number":203,"context_line":"  |"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_a6fd763b","line":203,"range":{"start_line":203,"start_character":2,"end_line":203,"end_character":3},"in_reply_to":"1fa4df85_40a26a4d","updated":"2020-02-28 03:48:37.000000000","message":"Yes, planed for EMC Unity team.\nBecause without this feature, we cannot do replication in our driver.\nOr you got anyone interested in?","commit_id":"69cc48b008723c3a6b75d8fa05135c19904c868d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Add new API to create share group replica. It will create replica"},{"line_number":49,"context_line":"  share group and shares in it, register them in manila services."},{"line_number":50,"context_line":"  And there are some scenarios need to be considered:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    * The driver supports to do replica every share separately."},{"line_number":53,"context_line":"    * The driver only supports to do replica for share server, and the share"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_61e4c83c","line":50,"updated":"2020-07-15 17:21:38.000000000","message":"nit: which","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  share group and shares in it, register them in manila services."},{"line_number":50,"context_line":"  And there are some scenarios need to be considered:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    * The driver supports to do replica every share separately."},{"line_number":53,"context_line":"    * The driver only supports to do replica for share server, and the share"},{"line_number":54,"context_line":"      server\u0027s shares are all in this group."},{"line_number":55,"context_line":"    * The driver only supports to do replica for share server, but the share"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_615208e0","line":52,"range":{"start_line":52,"start_character":26,"end_line":52,"end_character":62},"updated":"2020-07-15 17:21:38.000000000","message":"individual share replication","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Data model impact"},{"line_number":79,"context_line":"-----------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Add property \"replica_state\" (possible values: active, in_sync,"},{"line_number":82,"context_line":"out_of_sync, error) and extra-spec called ``group_replication_type``"},{"line_number":83,"context_line":"(possible values: writable, readable, dr, None, like the ‘ replication_type’"},{"line_number":84,"context_line":"on share `[1]`_) to model in ``manila.db.sqlalchemy.models.ShareGroup`` and table"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_818e3c2b","line":81,"range":{"start_line":81,"start_character":28,"end_line":81,"end_character":30},"updated":"2020-07-15 17:21:38.000000000","message":"maybe it\u0027s important to mention that the `replica_state` property is going to be added to the new table called share_group_instance","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Data model impact"},{"line_number":79,"context_line":"-----------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Add property \"replica_state\" (possible values: active, in_sync,"},{"line_number":82,"context_line":"out_of_sync, error) and extra-spec called ``group_replication_type``"},{"line_number":83,"context_line":"(possible values: writable, readable, dr, None, like the ‘ replication_type’"},{"line_number":84,"context_line":"on share `[1]`_) to model in ``manila.db.sqlalchemy.models.ShareGroup`` and table"},{"line_number":85,"context_line":"share_groups in db."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_217f7015","line":82,"range":{"start_line":81,"start_character":47,"end_line":82,"end_character":18},"updated":"2020-07-15 17:21:38.000000000","message":"nit: surrounding this states with `` would be good for formatting purposes","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Add property \"replica_state\" (possible values: active, in_sync,"},{"line_number":82,"context_line":"out_of_sync, error) and extra-spec called ``group_replication_type``"},{"line_number":83,"context_line":"(possible values: writable, readable, dr, None, like the ‘ replication_type’"},{"line_number":84,"context_line":"on share `[1]`_) to model in ``manila.db.sqlalchemy.models.ShareGroup`` and table"},{"line_number":85,"context_line":"share_groups in db."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_6175e831","line":83,"range":{"start_line":83,"start_character":18,"end_line":83,"end_character":76},"updated":"2020-07-15 17:21:38.000000000","message":"same","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":82,"context_line":"out_of_sync, error) and extra-spec called ``group_replication_type``"},{"line_number":83,"context_line":"(possible values: writable, readable, dr, None, like the ‘ replication_type’"},{"line_number":84,"context_line":"on share `[1]`_) to model in ``manila.db.sqlalchemy.models.ShareGroup`` and table"},{"line_number":85,"context_line":"share_groups in db."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_4170a440","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":12},"updated":"2020-07-15 17:21:38.000000000","message":"same","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":84,"context_line":"on share `[1]`_) to model in ``manila.db.sqlalchemy.models.ShareGroup`` and table"},{"line_number":85,"context_line":"share_groups in db."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"REST API impact"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_21d2d000","line":87,"updated":"2020-07-15 17:21:38.000000000","message":"are there columns being moved from the share_groups table to the share_group_instance tables? if so, could you please mention them here?","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":89,"context_line":"REST API impact"},{"line_number":90,"context_line":"---------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"**Creating share group replication**"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    POST /v2/{project_id}/share-group-replicas"},{"line_number":95,"context_line":"    BODY::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_019fcc4f","line":92,"range":{"start_line":92,"start_character":23,"end_line":92,"end_character":34},"updated":"2020-07-15 17:21:38.000000000","message":"replica","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fde610c6eeda0615cbc4ac764ffe8aec303e14af","unresolved":false,"context_lines":[{"line_number":188,"context_line":"Driver impact"},{"line_number":189,"context_line":"-------------"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"The value of group_replication_type is inferred for each driver"},{"line_number":192,"context_line":"based on the methods it contains."},{"line_number":193,"context_line":"Drivers can use their own ways (from share or share server) to do the"},{"line_number":194,"context_line":"replication and promotion."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_c1b2f4e4","line":191,"range":{"start_line":191,"start_character":13,"end_line":191,"end_character":35},"updated":"2020-07-15 17:21:38.000000000","message":"`group_replication_type`","commit_id":"774bd584838a3b12784d45dc0aec9f90f391b381"}]}