)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"06660399e47de57ce4b93fd8c1e90ea5469052c6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Share server migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a specification for migrating shares servers"},{"line_number":10,"context_line":"and all its resources to a new destination. This spec proposes"},{"line_number":11,"context_line":"a mechanism similar to the existent share migration."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bf51134e_2629fcf1","line":9,"range":{"start_line":9,"start_character":46,"end_line":9,"end_character":60},"updated":"2020-07-21 08:41:54.000000000","message":"share servers","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8da83d2e66ea43ac9b84bc81b0ae1d3dddf3195c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Share server migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a specification for migrating shares servers"},{"line_number":10,"context_line":"and all its resources to a new destination. This spec proposes"},{"line_number":11,"context_line":"a mechanism similar to the existent share migration."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bf51134e_da00cfae","line":9,"range":{"start_line":9,"start_character":46,"end_line":9,"end_character":60},"in_reply_to":"bf51134e_2629fcf1","updated":"2020-07-21 12:00:23.000000000","message":"Done","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"}],"specs/victoria/share-server-migration.rst":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3aae634024a007fe40e3c480f8ff85c13661ee58","unresolved":false,"context_lines":[{"line_number":65,"context_line":"It is important to note that when migrating a share server, many share"},{"line_number":66,"context_line":"attributes won\u0027t be modified during the process, while share server attributes"},{"line_number":67,"context_line":"might change depending on the parameters, when provided by the"},{"line_number":68,"context_line":"administrator, in \u0027Share Network\u0027, \u0027Share Type\u0027 and \u0027Availability Zone\u0027"},{"line_number":69,"context_line":"entities."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Share API and Manager\u0027s Changes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_de3cd1c9","line":68,"range":{"start_line":68,"start_character":36,"end_line":68,"end_character":46},"updated":"2020-06-23 14:20:12.000000000","message":"Not sure how this should work with share server migration. We can\u0027t accept a new share type for a share server since its shares can have different share types, and retype all shares might not be a good idea for this operation. Maybe a share group retype makes more sense for this kind of change.","commit_id":"ab904a235ba403a9c16d17f3312bb1aea6d1b7e7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e77bccae58d3ba1c1b5ae299db7f342f5ff7f295","unresolved":false,"context_lines":[{"line_number":246,"context_line":"If the provided `share_server_id` doesn\u0027t exist, the API will respond with"},{"line_number":247,"context_line":"``404 Not Found``."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Driver impact"},{"line_number":250,"context_line":"-------------"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"Vendors that want to support share server migration must implement the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_07c0a729","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":13},"updated":"2020-06-24 15:52:33.000000000","message":"Add: \"choose_share_server_compatible_for_migration\"","commit_id":"ab904a235ba403a9c16d17f3312bb1aea6d1b7e7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* **Evacuation**: evacuate a back end that is too old or that is experiencing"},{"line_number":45,"context_line":"  failures;"},{"line_number":46,"context_line":"* **Maintenance**: move shares to a newer hardware version/model;"},{"line_number":47,"context_line":"* **Others**: change shares\u0027 configuration like: share type, share network,"},{"line_number":48,"context_line":"  availability zone, etc."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_6b8d34d2","line":47,"range":{"start_line":47,"start_character":49,"end_line":47,"end_character":59},"updated":"2020-07-08 13:22:58.000000000","message":"The share type won\u0027t be modified as said below, right? If so, I think you could remove this :)","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* **Evacuation**: evacuate a back end that is too old or that is experiencing"},{"line_number":45,"context_line":"  failures;"},{"line_number":46,"context_line":"* **Maintenance**: move shares to a newer hardware version/model;"},{"line_number":47,"context_line":"* **Others**: change shares\u0027 configuration like: share type, share network,"},{"line_number":48,"context_line":"  availability zone, etc."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_2774cb35","line":47,"range":{"start_line":47,"start_character":49,"end_line":47,"end_character":59},"in_reply_to":"bf51134e_6b8d34d2","updated":"2020-07-15 21:37:58.000000000","message":"Yes, thanks! Done!","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"It is important to note that when migrating a share server, many share"},{"line_number":66,"context_line":"attributes won\u0027t be modified during the process, while share server attributes"},{"line_number":67,"context_line":"might change depending on the provided parameters. Administrators will be able"},{"line_number":68,"context_line":"to provide a new \u0027Share Network\u0027 to associated to the new share server, but"},{"line_number":69,"context_line":"won\u0027t be able to change its shares\u0027 attributes like \u0027Share Type\u0027 since this"},{"line_number":70,"context_line":"is a share level entity and different \u0027Share Types\u0027 can live in the same share"},{"line_number":71,"context_line":"server."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_cb30c00a","line":68,"range":{"start_line":68,"start_character":36,"end_line":68,"end_character":46},"updated":"2020-07-08 13:22:58.000000000","message":"nit: associate","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":65,"context_line":"It is important to note that when migrating a share server, many share"},{"line_number":66,"context_line":"attributes won\u0027t be modified during the process, while share server attributes"},{"line_number":67,"context_line":"might change depending on the provided parameters. Administrators will be able"},{"line_number":68,"context_line":"to provide a new \u0027Share Network\u0027 to associated to the new share server, but"},{"line_number":69,"context_line":"won\u0027t be able to change its shares\u0027 attributes like \u0027Share Type\u0027 since this"},{"line_number":70,"context_line":"is a share level entity and different \u0027Share Types\u0027 can live in the same share"},{"line_number":71,"context_line":"server."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_0771c744","line":68,"range":{"start_line":68,"start_character":36,"end_line":68,"end_character":46},"in_reply_to":"bf51134e_cb30c00a","updated":"2020-07-15 21:37:58.000000000","message":"Done","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"is a share level entity and different \u0027Share Types\u0027 can live in the same share"},{"line_number":71,"context_line":"server."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Share API and Manager\u0027s Changes"},{"line_number":74,"context_line":"-------------------------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The share API will hold all validations needed before proceeding with driver\u0027s"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_6efd42b0","line":73,"range":{"start_line":73,"start_character":21,"end_line":73,"end_character":23},"updated":"2020-07-08 13:22:58.000000000","message":"could be removed","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Before starting the migration, the share server and all its shares will have"},{"line_number":83,"context_line":"their status updated to reflect the operation that is being executed and to"},{"line_number":84,"context_line":"block any other operation that could be triggered after this one started. By"},{"line_number":85,"context_line":"changing all shares\u0027 status, users will be able to identify that a group of"},{"line_number":86,"context_line":"shares are blocked for receiving any other operation."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"After running through all validations with success, the share server"},{"line_number":89,"context_line":"`task_state` will be updated to `MIGRATION_STARTING` and the scheduler will be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_6e170247","line":86,"range":{"start_line":85,"start_character":65,"end_line":86,"end_character":18},"updated":"2020-07-08 13:22:58.000000000","message":"a group of shares is blocked?","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"changing all shares\u0027 status, users will be able to identify that a group of"},{"line_number":86,"context_line":"shares are blocked for receiving any other operation."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"After running through all validations with success, the share server"},{"line_number":89,"context_line":"`task_state` will be updated to `MIGRATION_STARTING` and the scheduler will be"},{"line_number":90,"context_line":"invoked to validate if the host matches with the provided share types."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"By reaching share manager\u0027s migration start method, a driver\u0027s call will be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_2e36aae8","line":89,"range":{"start_line":88,"start_character":52,"end_line":89,"end_character":12},"updated":"2020-07-08 13:22:58.000000000","message":"Since there is no mention about this new attribute yet, this could be rephrased to: the share server\u0027s new atribbute called `task_state`...","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"`task_state` will be updated to `MIGRATION_STARTING` and the scheduler will be"},{"line_number":90,"context_line":"invoked to validate if the host matches with the provided share types."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"By reaching share manager\u0027s migration start method, a driver\u0027s call will be"},{"line_number":93,"context_line":"triggered to analyze if the destination back end can handle such operation"},{"line_number":94,"context_line":"before starting the migration. If one of the capabilities can\u0027t be satisfied,"},{"line_number":95,"context_line":"the migration will fail."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The share manager will update the share server\u0027s `task_state` to"},{"line_number":98,"context_line":"`MIGRATION_IN_PROGRESS` and all its instances\u0027 status to `MIGRATING`. A new"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_4e979e91","line":95,"range":{"start_line":92,"start_character":0,"end_line":95,"end_character":24},"updated":"2020-07-08 13:22:58.000000000","message":"This capabilities validation step isn\u0027t going to be performed by the scheduler?","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":89,"context_line":"`task_state` will be updated to `MIGRATION_STARTING` and the scheduler will be"},{"line_number":90,"context_line":"invoked to validate if the host matches with the provided share types."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"By reaching share manager\u0027s migration start method, a driver\u0027s call will be"},{"line_number":93,"context_line":"triggered to analyze if the destination back end can handle such operation"},{"line_number":94,"context_line":"before starting the migration. If one of the capabilities can\u0027t be satisfied,"},{"line_number":95,"context_line":"the migration will fail."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The share manager will update the share server\u0027s `task_state` to"},{"line_number":98,"context_line":"`MIGRATION_IN_PROGRESS` and all its instances\u0027 status to `MIGRATING`. A new"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_4edafee8","line":95,"range":{"start_line":92,"start_character":0,"end_line":95,"end_character":24},"in_reply_to":"bf51134e_4e979e91","updated":"2020-07-15 21:37:58.000000000","message":"there is also a validation at driver level to analyze if the requested migration can be made. Maybe \u0027capabilities\u0027 is the confusing word here, will try to rephrase","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"will be called to start the share server migration and to return"},{"line_number":103,"context_line":"asynchronously."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"A share manager\u0027s periodic task will continuously check share servers that have"},{"line_number":106,"context_line":"the status set to `MIGRATION_IN_PROGRESS` to invoke the driver\u0027s call"},{"line_number":107,"context_line":"`share_server_migration_continue` to track the progress of share servers that"},{"line_number":108,"context_line":"are in the 1st phase of the migration. After successfully finishing the 1st"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_0e41260c","line":105,"range":{"start_line":105,"start_character":15,"end_line":105,"end_character":17},"updated":"2020-07-08 13:22:58.000000000","message":"nit: could be removed","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"are in the 1st phase of the migration. After successfully finishing the 1st"},{"line_number":109,"context_line":"phase, the share server status will be updated to `MIGRATION_PHASE1_DONE`."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Finally, shares manager\u0027s `share_server_migration_complete` method can be"},{"line_number":112,"context_line":"invoked for share servers that already completed the 1st phase, to finish the"},{"line_number":113,"context_line":"migration. In this phase, the driver is called to finish the share server"},{"line_number":114,"context_line":"migration and perform the last steps in the back end and return the list of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_ce044ec9","line":111,"range":{"start_line":111,"start_character":9,"end_line":111,"end_character":15},"updated":"2020-07-08 13:22:58.000000000","message":"nit: share","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"operation will delete everything new that was created during the process, and"},{"line_number":123,"context_line":"the share server and all its shares will go back to the initial state."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Scheduler\u0027s Changes"},{"line_number":126,"context_line":"-------------------"},{"line_number":127,"context_line":"The scheduler\u0027s filters can be used to validate if the destination host can"},{"line_number":128,"context_line":"hold all shares associated to the share server being migrated. Share API will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_8e0256b3","line":125,"range":{"start_line":125,"start_character":9,"end_line":125,"end_character":11},"updated":"2020-07-08 13:22:58.000000000","message":"nit: could be removed","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":122,"context_line":"operation will delete everything new that was created during the process, and"},{"line_number":123,"context_line":"the share server and all its shares will go back to the initial state."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Scheduler\u0027s Changes"},{"line_number":126,"context_line":"-------------------"},{"line_number":127,"context_line":"The scheduler\u0027s filters can be used to validate if the destination host can"},{"line_number":128,"context_line":"hold all shares associated to the share server being migrated. Share API will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_e7a2d399","line":125,"range":{"start_line":125,"start_character":9,"end_line":125,"end_character":11},"in_reply_to":"bf51134e_8e0256b3","updated":"2020-07-15 21:37:58.000000000","message":"Done","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f522bc7111cddec9e2499845b12aa422701e953f","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Scheduler\u0027s Changes"},{"line_number":126,"context_line":"-------------------"},{"line_number":127,"context_line":"The scheduler\u0027s filters can be used to validate if the destination host can"},{"line_number":128,"context_line":"hold all shares associated to the share server being migrated. Share API will"},{"line_number":129,"context_line":"need to provide the share server\u0027s total size along with all associated share"},{"line_number":130,"context_line":"types\u0027 capabilities in order to validate if the destination host is suitable"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_aed59a1d","line":127,"range":{"start_line":127,"start_character":13,"end_line":127,"end_character":15},"updated":"2020-07-08 13:22:58.000000000","message":"ditto","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Scheduler\u0027s Changes"},{"line_number":126,"context_line":"-------------------"},{"line_number":127,"context_line":"The scheduler\u0027s filters can be used to validate if the destination host can"},{"line_number":128,"context_line":"hold all shares associated to the share server being migrated. Share API will"},{"line_number":129,"context_line":"need to provide the share server\u0027s total size along with all associated share"},{"line_number":130,"context_line":"types\u0027 capabilities in order to validate if the destination host is suitable"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_c79fcf4d","line":127,"range":{"start_line":127,"start_character":13,"end_line":127,"end_character":15},"in_reply_to":"bf51134e_aed59a1d","updated":"2020-07-15 21:37:58.000000000","message":"Done","commit_id":"866389deb1c0dee19c015342d5e848140a04062f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"415382fd92cafcaaea7f23d6fadc25dce568f451","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Before starting the migration, the share server and all its shares will have"},{"line_number":83,"context_line":"their status updated to reflect the operation that is being executed and to"},{"line_number":84,"context_line":"block any other operation that could be triggered after this one started. By"},{"line_number":85,"context_line":"changing all shares\u0027 status, users will be able to identify that a group of"},{"line_number":86,"context_line":"shares is blocked for receiving any other operation."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"After running through all validations with success, the share server\u0027s new"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_46d39a01","line":85,"updated":"2020-07-15 16:43:01.000000000","message":"What status will shares change to?  I think you need to prevent shares at the source and destination from deletion and modification while the migration is in process.  Do you need to prevent addition of other shares at the destination while the migration is in process in order to avoid it filling up part way through the migration?","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Before moving to the 2nd phase, during the data copy or at the 1st phase"},{"line_number":121,"context_line":"completed, administrators can cancel the operation by invoking the"},{"line_number":122,"context_line":"`share_server_migration_cancel` API. If supported by the driver, the cancel"},{"line_number":123,"context_line":"operation will delete everything new that was created during the process, and"},{"line_number":124,"context_line":"the share server and all its shares will go back to the initial state."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Scheduler Changes"},{"line_number":127,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_42527168","line":124,"range":{"start_line":122,"start_character":37,"end_line":124,"end_character":70},"updated":"2020-07-15 07:42:19.000000000","message":"What if drivers can\u0027t support cancelation? How do we signal this to an administrator?","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"415382fd92cafcaaea7f23d6fadc25dce568f451","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Before moving to the 2nd phase, during the data copy or at the 1st phase"},{"line_number":121,"context_line":"completed, administrators can cancel the operation by invoking the"},{"line_number":122,"context_line":"`share_server_migration_cancel` API. If supported by the driver, the cancel"},{"line_number":123,"context_line":"operation will delete everything new that was created during the process, and"},{"line_number":124,"context_line":"the share server and all its shares will go back to the initial state."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Scheduler Changes"},{"line_number":127,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_262946e5","line":124,"range":{"start_line":122,"start_character":37,"end_line":124,"end_character":70},"in_reply_to":"bf51134e_42527168","updated":"2020-07-15 16:43:01.000000000","message":"+1.  More error handling discussion is needed I think.  What if some but not all shares finish the first phase of migration?","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Before moving to the 2nd phase, during the data copy or at the 1st phase"},{"line_number":121,"context_line":"completed, administrators can cancel the operation by invoking the"},{"line_number":122,"context_line":"`share_server_migration_cancel` API. If supported by the driver, the cancel"},{"line_number":123,"context_line":"operation will delete everything new that was created during the process, and"},{"line_number":124,"context_line":"the share server and all its shares will go back to the initial state."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Scheduler Changes"},{"line_number":127,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_0c99cbc2","line":124,"range":{"start_line":122,"start_character":37,"end_line":124,"end_character":70},"in_reply_to":"bf51134e_42527168","updated":"2020-07-15 21:37:58.000000000","message":"Besides returning a 400 or a 405, also add documentation updates for drivers that implement such feature.\nI also considered your suggestion for adding a new check/validation API, to check the feasibility of starting a migration before actually starting it.\nIn this response we can also provide if it supports cancellation.","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Body::"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  {"},{"line_number":164,"context_line":"    \u0027migration_start\u0027: {"},{"line_number":165,"context_line":"      \u0027preserve_metadata\u0027: true,"},{"line_number":166,"context_line":"      \u0027writable\u0027: true,"},{"line_number":167,"context_line":"      \u0027nondisruptive\u0027: true,"},{"line_number":168,"context_line":"      \u0027preserve_snapshots\u0027: true,"},{"line_number":169,"context_line":"      \u0027host\u0027: \u0027host@dummy1#pool2\u0027,"},{"line_number":170,"context_line":"      \u0027new_share_network_id\u0027: \u0027new_share_network_id\u0027"},{"line_number":171,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_824809b3","line":168,"range":{"start_line":164,"start_character":24,"end_line":168,"end_character":33},"updated":"2020-07-15 07:42:19.000000000","message":"What do these mean?\n\nWill non disruptive migration mean that no new network allocations are necessary?\nWhat happens when a driver tells us it can\u0027t preserve snapshots? Do we ask that the administrator delete/unmanage all snapshots before migrating?\nWill writable mean that shares can continue to be written to through phase1?\n\npreserve_metadata was a way to allow host based migration - you\u0027re not proposing a host based migration solution for this feature, however.","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Body::"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  {"},{"line_number":164,"context_line":"    \u0027migration_start\u0027: {"},{"line_number":165,"context_line":"      \u0027preserve_metadata\u0027: true,"},{"line_number":166,"context_line":"      \u0027writable\u0027: true,"},{"line_number":167,"context_line":"      \u0027nondisruptive\u0027: true,"},{"line_number":168,"context_line":"      \u0027preserve_snapshots\u0027: true,"},{"line_number":169,"context_line":"      \u0027host\u0027: \u0027host@dummy1#pool2\u0027,"},{"line_number":170,"context_line":"      \u0027new_share_network_id\u0027: \u0027new_share_network_id\u0027"},{"line_number":171,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_67d7b524","line":168,"range":{"start_line":164,"start_character":24,"end_line":168,"end_character":33},"in_reply_to":"bf51134e_824809b3","updated":"2020-07-15 21:37:58.000000000","message":"Did a update in this API doc to explain in more details each of these options.\nAbout \u0027preserve_metadata\u0027, didn\u0027t know that any driver was using this info, so it was removed in the latest PS.","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":186,"context_line":"exist, the API will respond with ``400 Bad Request``. If during the initial"},{"line_number":187,"context_line":"validations in the Share API, one of the resources is busy or has an invalid"},{"line_number":188,"context_line":"status, the API will respond with ``409 Conflict``."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"2) `share-server-migration-complete`"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Start the 2nd phase of migration::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_c2cb211b","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":0},"updated":"2020-07-15 07:42:19.000000000","message":"Can you provide the state transitions for the affected resources?","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":186,"context_line":"exist, the API will respond with ``400 Bad Request``. If during the initial"},{"line_number":187,"context_line":"validations in the Share API, one of the resources is busy or has an invalid"},{"line_number":188,"context_line":"status, the API will respond with ``409 Conflict``."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"2) `share-server-migration-complete`"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Start the 2nd phase of migration::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_e7e2a500","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":0},"in_reply_to":"bf51134e_c2cb211b","updated":"2020-07-15 21:37:58.000000000","message":"Let me know if the new info provided fulfill your expectations. Thanks!","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"If the provided `share_server_id` doesn\u0027t exist, the API will respond with"},{"line_number":222,"context_line":"with ``404 Not Found``."},{"line_number":223,"context_line":"If the operation can\u0027t be performed due to unsupported migration state, the API"},{"line_number":224,"context_line":"will respond with ``400 Bad Request``."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"4) `share-server-migration-get-progress`"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_02d239d1","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":38},"updated":"2020-07-15 07:42:19.000000000","message":"How will we convey to the administrator whether migration can be canceled?","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"If the provided `share_server_id` doesn\u0027t exist, the API will respond with"},{"line_number":222,"context_line":"with ``404 Not Found``."},{"line_number":223,"context_line":"If the operation can\u0027t be performed due to unsupported migration state, the API"},{"line_number":224,"context_line":"will respond with ``400 Bad Request``."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"4) `share-server-migration-get-progress`"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_c7b32109","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":38},"in_reply_to":"bf51134e_02d239d1","updated":"2020-07-15 21:37:58.000000000","message":"We\u0027ll try to provide this info on the \u0027migration-check\u0027 API, let me know what do you think","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"* **share_server_migration_start**: called to start the first phase of"},{"line_number":279,"context_line":"  migration. The procedure should be started in the back end and return"},{"line_number":280,"context_line":"  asynchronously."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* **share_server_migration_continue**: will be called to monitor the progress"},{"line_number":283,"context_line":"  of a share server migration. Drivers will answer if the 1st phase was already"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_c2f4c15d","line":280,"range":{"start_line":280,"start_character":2,"end_line":280,"end_character":16},"updated":"2020-07-15 07:42:19.000000000","message":"you mean synchronously here I think","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"* **share_server_migration_start**: called to start the first phase of"},{"line_number":279,"context_line":"  migration. The procedure should be started in the back end and return"},{"line_number":280,"context_line":"  asynchronously."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* **share_server_migration_continue**: will be called to monitor the progress"},{"line_number":283,"context_line":"  of a share server migration. Drivers will answer if the 1st phase was already"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_47c71165","line":280,"range":{"start_line":280,"start_character":2,"end_line":280,"end_character":16},"in_reply_to":"bf51134e_4648bab1","updated":"2020-07-15 21:37:58.000000000","message":"\u0027immediately\u0027 fits better. Thanks for noticing!","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"415382fd92cafcaaea7f23d6fadc25dce568f451","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"* **share_server_migration_start**: called to start the first phase of"},{"line_number":279,"context_line":"  migration. The procedure should be started in the back end and return"},{"line_number":280,"context_line":"  asynchronously."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* **share_server_migration_continue**: will be called to monitor the progress"},{"line_number":283,"context_line":"  of a share server migration. Drivers will answer if the 1st phase was already"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_4648bab1","line":280,"range":{"start_line":280,"start_character":2,"end_line":280,"end_character":16},"in_reply_to":"bf51134e_c2f4c15d","updated":"2020-07-15 16:43:01.000000000","message":"suggest \u0027immediately\u0027 to avoid confusing language.  An asynchronous task is started by a call that returns immediately rather than waiting for the task to finish before returniing.","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":295,"context_line":"* **share_server_migration_get_progress**: drivers will implement this call to"},{"line_number":296,"context_line":"  provide the total progress of the migration."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"As implemented in share migration approach, drivers will be invoked to check"},{"line_number":299,"context_line":"the compatibility with the destination back end before starting the migration."},{"line_number":300,"context_line":"During this validation, driver will be able to return the capabilities"},{"line_number":301,"context_line":"supported for migrating a share server to the provided destination, such as"},{"line_number":302,"context_line":"remaining writable, preserving snapshots and others."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"After that, `share_server_migration_start` will take place and ask drivers to"},{"line_number":305,"context_line":"start the 1st phase of the migration, that should be answered asynchronously."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_8252c933","line":302,"range":{"start_line":298,"start_character":0,"end_line":302,"end_character":52},"updated":"2020-07-15 07:42:19.000000000","message":"It feels like we should allow a fact gathering API that will allow the administrator to:\n\n- Check whether the destination host can pass the migration\n- Check whether the driver finds the migration feasible\n- Assess whether the driver allows migration to be canceled. \n\nThis will solve multiple issues, wrt the discoverability aspect of the migration capabilities. What do you think?","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":295,"context_line":"* **share_server_migration_get_progress**: drivers will implement this call to"},{"line_number":296,"context_line":"  provide the total progress of the migration."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"As implemented in share migration approach, drivers will be invoked to check"},{"line_number":299,"context_line":"the compatibility with the destination back end before starting the migration."},{"line_number":300,"context_line":"During this validation, driver will be able to return the capabilities"},{"line_number":301,"context_line":"supported for migrating a share server to the provided destination, such as"},{"line_number":302,"context_line":"remaining writable, preserving snapshots and others."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"After that, `share_server_migration_start` will take place and ask drivers to"},{"line_number":305,"context_line":"start the 1st phase of the migration, that should be answered asynchronously."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_0796b94c","line":302,"range":{"start_line":298,"start_character":0,"end_line":302,"end_character":52},"in_reply_to":"bf51134e_8252c933","updated":"2020-07-15 21:37:58.000000000","message":"Thanks for the suggestion. Added a new API to check if the migration is feasible and that returns all the options currently supported by the driver.","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":325,"context_line":"Other end user impact"},{"line_number":326,"context_line":"---------------------"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"None"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"Performance Impact"},{"line_number":331,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_22393df1","line":328,"range":{"start_line":328,"start_character":0,"end_line":328,"end_character":4},"updated":"2020-07-15 07:42:19.000000000","message":"Users won\u0027t be able to:\n\n1) Stay connected in some cases, lose write access in some cases to shares that will undergo a migration\n2) Perform any management path operations on affected share while a server migration is in progress","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":325,"context_line":"Other end user impact"},{"line_number":326,"context_line":"---------------------"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"None"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"Performance Impact"},{"line_number":331,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_479c3169","line":328,"range":{"start_line":328,"start_character":0,"end_line":328,"end_character":4},"in_reply_to":"bf51134e_22393df1","updated":"2020-07-15 21:37:58.000000000","message":"Added, thanks for this feedback.","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":330,"context_line":"Performance Impact"},{"line_number":331,"context_line":"------------------"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"A minor performance impact is expected since all the data copy will be"},{"line_number":334,"context_line":"performed in the storage back end. Depending on how many shares are placed"},{"line_number":335,"context_line":"within a share server, the database updates can take some time to finish,"},{"line_number":336,"context_line":"blocking other updates."},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"Other deployer impact"},{"line_number":339,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_822769c7","line":336,"range":{"start_line":333,"start_character":2,"end_line":336,"end_character":23},"updated":"2020-07-15 07:42:19.000000000","message":"I think this section is about performance regressions, since this feature doesn\u0027t exist today, you don\u0027t need to discuss performance regressions - however, you could reword this calling out what is involved in \n\n1) validating whether migration request is valid (all resources must be pulled up, and this could potentially mean hundreds of shares, snapshots, groups, replicas)\n2) updating the status of these resources at various intervals - task state updates, status updates to each resource and to the affected share server itself\n3) Outage could last several days in case there\u0027s a large amount of data to copy","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":330,"context_line":"Performance Impact"},{"line_number":331,"context_line":"------------------"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"A minor performance impact is expected since all the data copy will be"},{"line_number":334,"context_line":"performed in the storage back end. Depending on how many shares are placed"},{"line_number":335,"context_line":"within a share server, the database updates can take some time to finish,"},{"line_number":336,"context_line":"blocking other updates."},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"Other deployer impact"},{"line_number":339,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_47755131","line":336,"range":{"start_line":333,"start_character":2,"end_line":336,"end_character":23},"in_reply_to":"bf51134e_822769c7","updated":"2020-07-15 21:37:58.000000000","message":"hum, makes sense. \nStill, I decided to let the performance impacted in the database due to high number of queries and status updates, that might be considered. Thanks!","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82e157a0081c7ae934246a141ac78c123dad3141","unresolved":false,"context_lines":[{"line_number":369,"context_line":"* Update python-manilaclient with new share server\u0027s CLI commands."},{"line_number":370,"context_line":"* For testing:"},{"line_number":371,"context_line":"    * Improve and implement the container driver to support share server"},{"line_number":372,"context_line":"      migration across different back ends."},{"line_number":373,"context_line":"    * New functional tests in manila-tempest-plugin."},{"line_number":374,"context_line":"* Documentation updates."},{"line_number":375,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_e21bc57d","line":372,"range":{"start_line":372,"start_character":42,"end_line":372,"end_character":43},"updated":"2020-07-15 07:42:19.000000000","message":"and the dummy driver?","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b4d47238e53b414693d8be845962d6eb40730f32","unresolved":false,"context_lines":[{"line_number":369,"context_line":"* Update python-manilaclient with new share server\u0027s CLI commands."},{"line_number":370,"context_line":"* For testing:"},{"line_number":371,"context_line":"    * Improve and implement the container driver to support share server"},{"line_number":372,"context_line":"      migration across different back ends."},{"line_number":373,"context_line":"    * New functional tests in manila-tempest-plugin."},{"line_number":374,"context_line":"* Documentation updates."},{"line_number":375,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_c796813e","line":372,"range":{"start_line":372,"start_character":42,"end_line":372,"end_character":43},"in_reply_to":"bf51134e_e21bc57d","updated":"2020-07-15 21:37:58.000000000","message":"Was part of the plan too. Added. Thanks!","commit_id":"b5313e8de9af7e17acf24124da6b5ca0652ffd84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"their status updated to reflect the operation that is being executed and to"},{"line_number":84,"context_line":"block any other operation that could be triggered after this one started."},{"line_number":85,"context_line":"The source share server and all its shares will have their status updated to"},{"line_number":86,"context_line":"`STATUS_SERVER_MIGRATING` while the destination share server will be updated to"},{"line_number":87,"context_line":"`STATUS_SERVER_MIGRATING_TO`. By changing all shares\u0027 status, users will be"},{"line_number":88,"context_line":"able to identify that a group of shares is blocked for receiving any other"},{"line_number":89,"context_line":"operation."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_d1027f6f","line":86,"range":{"start_line":86,"start_character":1,"end_line":86,"end_character":24},"updated":"2020-07-20 21:09:19.000000000","message":"this is the name of a variable in manila code?\ndo you mean just ``server_migrating``?","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"their status updated to reflect the operation that is being executed and to"},{"line_number":84,"context_line":"block any other operation that could be triggered after this one started."},{"line_number":85,"context_line":"The source share server and all its shares will have their status updated to"},{"line_number":86,"context_line":"`STATUS_SERVER_MIGRATING` while the destination share server will be updated to"},{"line_number":87,"context_line":"`STATUS_SERVER_MIGRATING_TO`. By changing all shares\u0027 status, users will be"},{"line_number":88,"context_line":"able to identify that a group of shares is blocked for receiving any other"},{"line_number":89,"context_line":"operation."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_548dbdd1","line":86,"range":{"start_line":86,"start_character":1,"end_line":86,"end_character":24},"in_reply_to":"bf51134e_d1027f6f","updated":"2020-07-20 22:47:46.000000000","message":"my mistake, fixed! converting all status to lowercase.","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"block any other operation that could be triggered after this one started."},{"line_number":85,"context_line":"The source share server and all its shares will have their status updated to"},{"line_number":86,"context_line":"`STATUS_SERVER_MIGRATING` while the destination share server will be updated to"},{"line_number":87,"context_line":"`STATUS_SERVER_MIGRATING_TO`. By changing all shares\u0027 status, users will be"},{"line_number":88,"context_line":"able to identify that a group of shares is blocked for receiving any other"},{"line_number":89,"context_line":"operation."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_31f77b8f","line":87,"range":{"start_line":87,"start_character":1,"end_line":87,"end_character":27},"updated":"2020-07-20 21:09:19.000000000","message":"``server_migrating_to``","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"operation."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"After running through all validations with success, the share server\u0027s new"},{"line_number":92,"context_line":"attribute called `task_state` will be updated to `MIGRATION_STARTING` and the"},{"line_number":93,"context_line":"scheduler will be invoked to validate if the host matches with the provided"},{"line_number":94,"context_line":"share types."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_912da7ff","line":92,"range":{"start_line":92,"start_character":50,"end_line":92,"end_character":68},"updated":"2020-07-20 21:09:19.000000000","message":"wouldn\u0027t it be better to separate the task state from the share migration feature? Currently \"migration_starting\" is an indication that host assisted migration is about to begin.. \n\n\"server_migration_starting\" perhaps?","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"satisfied, the migration will fail."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The share manager will update the share server\u0027s `task_state` to"},{"line_number":102,"context_line":"`MIGRATION_IN_PROGRESS` and all its instances\u0027 status to `MIGRATING`. A new"},{"line_number":103,"context_line":"share server might be requested in the destination back end to hold all the"},{"line_number":104,"context_line":"data from source. It is expected that drivers will be able to identify that a"},{"line_number":105,"context_line":"new server is being requested for migration purposes. After that, the driver"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_3125bb0b","line":102,"range":{"start_line":102,"start_character":1,"end_line":102,"end_character":22},"updated":"2020-07-20 21:09:19.000000000","message":"``migration_in_progress``","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"satisfied, the migration will fail."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The share manager will update the share server\u0027s `task_state` to"},{"line_number":102,"context_line":"`MIGRATION_IN_PROGRESS` and all its instances\u0027 status to `MIGRATING`. A new"},{"line_number":103,"context_line":"share server might be requested in the destination back end to hold all the"},{"line_number":104,"context_line":"data from source. It is expected that drivers will be able to identify that a"},{"line_number":105,"context_line":"new server is being requested for migration purposes. After that, the driver"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_511cafc0","line":102,"range":{"start_line":102,"start_character":58,"end_line":102,"end_character":67},"updated":"2020-07-20 21:09:19.000000000","message":"``server_migrating``","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"satisfied, the migration will fail."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The share manager will update the share server\u0027s `task_state` to"},{"line_number":102,"context_line":"`MIGRATION_IN_PROGRESS` and all its instances\u0027 status to `MIGRATING`. A new"},{"line_number":103,"context_line":"share server might be requested in the destination back end to hold all the"},{"line_number":104,"context_line":"data from source. It is expected that drivers will be able to identify that a"},{"line_number":105,"context_line":"new server is being requested for migration purposes. After that, the driver"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_b4bb7973","line":102,"range":{"start_line":102,"start_character":58,"end_line":102,"end_character":67},"in_reply_to":"bf51134e_511cafc0","updated":"2020-07-20 22:47:46.000000000","message":"Done","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"data from source. It is expected that drivers will be able to identify that a"},{"line_number":105,"context_line":"new server is being requested for migration purposes. After that, the driver"},{"line_number":106,"context_line":"will be called to start the share server migration and to return"},{"line_number":107,"context_line":"asynchronously."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"A share manager periodic task will continuously check share servers that have"},{"line_number":110,"context_line":"the `task_state` set to `MIGRATION_IN_PROGRESS` to invoke the driver\u0027s call"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_917be7f2","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":14},"updated":"2020-07-20 21:09:19.000000000","message":"immediately","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"data from source. It is expected that drivers will be able to identify that a"},{"line_number":105,"context_line":"new server is being requested for migration purposes. After that, the driver"},{"line_number":106,"context_line":"will be called to start the share server migration and to return"},{"line_number":107,"context_line":"asynchronously."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"A share manager periodic task will continuously check share servers that have"},{"line_number":110,"context_line":"the `task_state` set to `MIGRATION_IN_PROGRESS` to invoke the driver\u0027s call"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_94c0f5e2","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":14},"in_reply_to":"bf51134e_917be7f2","updated":"2020-07-20 22:47:46.000000000","message":"Done","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"asynchronously."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"A share manager periodic task will continuously check share servers that have"},{"line_number":110,"context_line":"the `task_state` set to `MIGRATION_IN_PROGRESS` to invoke the driver\u0027s call"},{"line_number":111,"context_line":"`share_server_migration_continue` to track the progress of share servers that"},{"line_number":112,"context_line":"are in the 1st phase of the migration. After successfully finishing the 1st"},{"line_number":113,"context_line":"phase, the share server `task_state` will be updated to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_b15f0b74","line":110,"range":{"start_line":110,"start_character":25,"end_line":110,"end_character":46},"updated":"2020-07-20 21:09:19.000000000","message":"nit: switch from caps here, and all other status/task_state values below","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"asynchronously."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"A share manager periodic task will continuously check share servers that have"},{"line_number":110,"context_line":"the `task_state` set to `MIGRATION_IN_PROGRESS` to invoke the driver\u0027s call"},{"line_number":111,"context_line":"`share_server_migration_continue` to track the progress of share servers that"},{"line_number":112,"context_line":"are in the 1st phase of the migration. After successfully finishing the 1st"},{"line_number":113,"context_line":"phase, the share server `task_state` will be updated to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_d4ba6d6c","line":110,"range":{"start_line":110,"start_character":25,"end_line":110,"end_character":46},"in_reply_to":"bf51134e_b15f0b74","updated":"2020-07-20 22:47:46.000000000","message":"ok, all status were updated.","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"invoked for share servers that already completed the 1st phase, to finish the"},{"line_number":118,"context_line":"migration. In this phase, the driver is called to finish the share server"},{"line_number":119,"context_line":"migration and perform the last steps in the back end and return the list of"},{"line_number":120,"context_line":"export locations for all its shares. The `task_state` is set to"},{"line_number":121,"context_line":"`MIGRATION_SUCCESS` and all its shares have their export paths updated before"},{"line_number":122,"context_line":"they become `available` again."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_51df8fd5","line":120,"range":{"start_line":120,"start_character":53,"end_line":120,"end_character":54},"updated":"2020-07-20 21:09:19.000000000","message":"of the share server?","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"invoked for share servers that already completed the 1st phase, to finish the"},{"line_number":118,"context_line":"migration. In this phase, the driver is called to finish the share server"},{"line_number":119,"context_line":"migration and perform the last steps in the back end and return the list of"},{"line_number":120,"context_line":"export locations for all its shares. The `task_state` is set to"},{"line_number":121,"context_line":"`MIGRATION_SUCCESS` and all its shares have their export paths updated before"},{"line_number":122,"context_line":"they become `available` again."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_34af692c","line":120,"range":{"start_line":120,"start_character":53,"end_line":120,"end_character":54},"in_reply_to":"bf51134e_51df8fd5","updated":"2020-07-20 22:47:46.000000000","message":"Done","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"migration. In this phase, the driver is called to finish the share server"},{"line_number":119,"context_line":"migration and perform the last steps in the back end and return the list of"},{"line_number":120,"context_line":"export locations for all its shares. The `task_state` is set to"},{"line_number":121,"context_line":"`MIGRATION_SUCCESS` and all its shares have their export paths updated before"},{"line_number":122,"context_line":"they become `available` again."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Before moving to the 2nd phase, during the data copy or at the 1st phase"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_3153fb6e","line":121,"range":{"start_line":121,"start_character":1,"end_line":121,"end_character":18},"updated":"2020-07-20 21:09:19.000000000","message":"\"server_migration_completed\" as a task state for the shares perhaps?","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"migration. In this phase, the driver is called to finish the share server"},{"line_number":119,"context_line":"migration and perform the last steps in the back end and return the list of"},{"line_number":120,"context_line":"export locations for all its shares. The `task_state` is set to"},{"line_number":121,"context_line":"`MIGRATION_SUCCESS` and all its shares have their export paths updated before"},{"line_number":122,"context_line":"they become `available` again."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Before moving to the 2nd phase, during the data copy or at the 1st phase"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_14ace533","line":121,"range":{"start_line":121,"start_character":1,"end_line":121,"end_character":18},"in_reply_to":"bf51134e_3153fb6e","updated":"2020-07-20 22:47:46.000000000","message":"sure! thanks!","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Before moving to the 2nd phase, during the data copy or at the 1st phase"},{"line_number":125,"context_line":"completed, administrators can cancel the operation by invoking the"},{"line_number":126,"context_line":"`share_server_migration_cancel` API. If supported by the driver, the cancel"},{"line_number":127,"context_line":"operation will delete everything new that was created during the process, and"},{"line_number":128,"context_line":"the share server and all its shares will go back to the initial state."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_91c92727","line":126,"range":{"start_line":126,"start_character":37,"end_line":126,"end_character":64},"updated":"2020-07-20 21:09:19.000000000","message":"Since there\u0027ll be an API to validate this now, can we respond to \"migration_cancel\" APIs with 400 if this operation is unsupported?","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Before moving to the 2nd phase, during the data copy or at the 1st phase"},{"line_number":125,"context_line":"completed, administrators can cancel the operation by invoking the"},{"line_number":126,"context_line":"`share_server_migration_cancel` API. If supported by the driver, the cancel"},{"line_number":127,"context_line":"operation will delete everything new that was created during the process, and"},{"line_number":128,"context_line":"the share server and all its shares will go back to the initial state."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_94659520","line":126,"range":{"start_line":126,"start_character":37,"end_line":126,"end_character":64},"in_reply_to":"bf51134e_91c92727","updated":"2020-07-20 22:47:46.000000000","message":"Added into \u0027share-server-migration-cancel\u0027 API section.","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"status, the API will respond with ``409 Conflict``."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Upon a failure, the share server and all its share will have their status"},{"line_number":211,"context_line":"updated to `available` and their `task_state` set to `MIGRATION_ERROR`."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"2) `share-server-migration-complete`"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_f1afc37a","line":211,"range":{"start_line":211,"start_character":54,"end_line":211,"end_character":69},"updated":"2020-07-20 21:09:19.000000000","message":"SHA","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":208,"context_line":"status, the API will respond with ``409 Conflict``."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Upon a failure, the share server and all its share will have their status"},{"line_number":211,"context_line":"updated to `available` and their `task_state` set to `MIGRATION_ERROR`."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"2) `share-server-migration-complete`"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_f46a11eb","line":211,"range":{"start_line":211,"start_character":54,"end_line":211,"end_character":69},"in_reply_to":"bf51134e_f1afc37a","updated":"2020-07-20 22:47:46.000000000","message":"Done","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"  {"},{"line_number":305,"context_line":"    \"migration_check\": {"},{"line_number":306,"context_line":"      \"host\": \"host@dummy1#pool2\","},{"line_number":307,"context_line":"    }"},{"line_number":308,"context_line":"  }"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_f19ce30f","line":306,"range":{"start_line":306,"start_character":6,"end_line":306,"end_character":34},"updated":"2020-07-20 21:09:19.000000000","message":"Why not have the same exact parameters as the migration_start API, so that you can perform network validation as well? The other parameters can be validated as well, by the driver if necessary, the same way as the validation check would be","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"  {"},{"line_number":305,"context_line":"    \"migration_check\": {"},{"line_number":306,"context_line":"      \"host\": \"host@dummy1#pool2\","},{"line_number":307,"context_line":"    }"},{"line_number":308,"context_line":"  }"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_147185df","line":306,"range":{"start_line":306,"start_character":6,"end_line":306,"end_character":34},"in_reply_to":"bf51134e_f19ce30f","updated":"2020-07-20 22:47:46.000000000","message":"Make sense after all. Done","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4477c52e1e1256942f9f480a4a7ab4268ba0c74a","unresolved":false,"context_lines":[{"line_number":310,"context_line":"Response::"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  Body: {"},{"line_number":313,"context_line":"      \"compatible\": true,"},{"line_number":314,"context_line":"      \"writable\": true,"},{"line_number":315,"context_line":"      \"nondisruptive\": false,"},{"line_number":316,"context_line":"      \"preserve_snapshots\": true,"},{"line_number":317,"context_line":"      \"migration_cancel\": true,"},{"line_number":318,"context_line":"      \"migration_progress\" false,"},{"line_number":319,"context_line":"  }"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"Checks the feasibility of migrating a share server to a destination host."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_517b0fbd","line":318,"range":{"start_line":313,"start_character":6,"end_line":318,"end_character":33},"updated":"2020-07-20 21:09:19.000000000","message":"maybe:\n\n  {\n\n    \"compatible\": \"true\", \n    \"requested_capabilities\": {\n        \"writable\": \"true\",\n        \"nondisruptive\": \"false\",\n        \"preserve_snapshots\": \"true\",\n        \"new_share_network_id\": \"new_share_network_id\",\n    }\n    \"supported_capabilities\": {\n         \"writable\": \"true\",\n        \"nondisruptive\": \"false\",\n        \"preserve_snapshots\": \"true\",\n        \"new_share_network_id\": \"new_share_network_id\",\n        \"migration_cancel\": \"true\",\n        \"migration_get_progress\": \"false\",\n    }    \n  }\n\n\nA bit more verbose, and presents a more complete picture, no?","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23c2c157008dc3db489496d7831d501920d18b2c","unresolved":false,"context_lines":[{"line_number":310,"context_line":"Response::"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  Body: {"},{"line_number":313,"context_line":"      \"compatible\": true,"},{"line_number":314,"context_line":"      \"writable\": true,"},{"line_number":315,"context_line":"      \"nondisruptive\": false,"},{"line_number":316,"context_line":"      \"preserve_snapshots\": true,"},{"line_number":317,"context_line":"      \"migration_cancel\": true,"},{"line_number":318,"context_line":"      \"migration_progress\" false,"},{"line_number":319,"context_line":"  }"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"Checks the feasibility of migrating a share server to a destination host."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_547bfdbc","line":318,"range":{"start_line":313,"start_character":6,"end_line":318,"end_character":33},"in_reply_to":"bf51134e_517b0fbd","updated":"2020-07-20 22:47:46.000000000","message":"yes, a bit more verbose, but works better. Done!","commit_id":"50f39dfa0c4e0f90aa434388f1b04f7ebb56981d"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"06660399e47de57ce4b93fd8c1e90ea5469052c6","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"By setting `writable` to ``true`` it\u0027s expected that all shares remain writable"},{"line_number":186,"context_line":"during the first phase of the migration, where the data copy usually occurs."},{"line_number":187,"context_line":"However it doesn\u0027t guarantee that will remain ``writable`` during the second"},{"line_number":188,"context_line":"phase, where the cutover usually happens."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"By specifying `nondisruptive` equal to ``true``, the migration will be"},{"line_number":191,"context_line":"performed without disrupting clients during the entire process, which usually"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_865a884d","line":188,"range":{"start_line":187,"start_character":0,"end_line":188,"end_character":41},"updated":"2020-07-21 08:41:54.000000000","message":"How would I request to have my shares writable during all phases?","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8da83d2e66ea43ac9b84bc81b0ae1d3dddf3195c","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"By setting `writable` to ``true`` it\u0027s expected that all shares remain writable"},{"line_number":186,"context_line":"during the first phase of the migration, where the data copy usually occurs."},{"line_number":187,"context_line":"However it doesn\u0027t guarantee that will remain ``writable`` during the second"},{"line_number":188,"context_line":"phase, where the cutover usually happens."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"By specifying `nondisruptive` equal to ``true``, the migration will be"},{"line_number":191,"context_line":"performed without disrupting clients during the entire process, which usually"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_3ae0ebfa","line":188,"range":{"start_line":187,"start_character":0,"end_line":188,"end_character":41},"in_reply_to":"bf51134e_865a884d","updated":"2020-07-21 12:00:23.000000000","message":"The shares\u0027 access won\u0027t change during the second phase, but for disruptive migrations, users will loose access. That what I was trying to say here. But for \u0027nondisruptive\u0027 migrations, the share might remain writable.","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"06660399e47de57ce4b93fd8c1e90ea5469052c6","unresolved":false,"context_lines":[{"line_number":201,"context_line":"provided to fit destination network requirements."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"If the provided `share_server_id` doesn\u0027t exist, the API will respond with"},{"line_number":204,"context_line":"``404 Not Found``. If one of the optional parameters are invalid or doesn\u0027t"},{"line_number":205,"context_line":"exist, the API will respond with ``400 Bad Request``. If during the initial"},{"line_number":206,"context_line":"validations in the Share API, one of the resources is busy or has an invalid"},{"line_number":207,"context_line":"status, the API will respond with ``409 Conflict``."}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_66b6548d","line":204,"range":{"start_line":204,"start_character":53,"end_line":204,"end_character":56},"updated":"2020-07-21 08:41:54.000000000","message":"is","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8da83d2e66ea43ac9b84bc81b0ae1d3dddf3195c","unresolved":false,"context_lines":[{"line_number":201,"context_line":"provided to fit destination network requirements."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"If the provided `share_server_id` doesn\u0027t exist, the API will respond with"},{"line_number":204,"context_line":"``404 Not Found``. If one of the optional parameters are invalid or doesn\u0027t"},{"line_number":205,"context_line":"exist, the API will respond with ``400 Bad Request``. If during the initial"},{"line_number":206,"context_line":"validations in the Share API, one of the resources is busy or has an invalid"},{"line_number":207,"context_line":"status, the API will respond with ``409 Conflict``."}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_9ae49710","line":204,"range":{"start_line":204,"start_character":53,"end_line":204,"end_character":56},"in_reply_to":"bf51134e_66b6548d","updated":"2020-07-21 12:00:23.000000000","message":"Done","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"06660399e47de57ce4b93fd8c1e90ea5469052c6","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Upon a failure in the second phase of the migration, the share server and all"},{"line_number":232,"context_line":"its shares will have their status updated to ``error`` and their `task_state`"},{"line_number":233,"context_line":"set to ``server_migration_error``. At this point, won\u0027t be possible to"},{"line_number":234,"context_line":"determine the status of the share server and its shares, and will be up to the"},{"line_number":235,"context_line":"administrator to manually fix this problem."},{"line_number":236,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_e62c24ae","line":233,"range":{"start_line":233,"start_character":49,"end_line":233,"end_character":55},"updated":"2020-07-21 08:41:54.000000000","message":"it won\u0027t","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8da83d2e66ea43ac9b84bc81b0ae1d3dddf3195c","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Upon a failure in the second phase of the migration, the share server and all"},{"line_number":232,"context_line":"its shares will have their status updated to ``error`` and their `task_state`"},{"line_number":233,"context_line":"set to ``server_migration_error``. At this point, won\u0027t be possible to"},{"line_number":234,"context_line":"determine the status of the share server and its shares, and will be up to the"},{"line_number":235,"context_line":"administrator to manually fix this problem."},{"line_number":236,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_7ae1c3fc","line":233,"range":{"start_line":233,"start_character":49,"end_line":233,"end_character":55},"in_reply_to":"bf51134e_e62c24ae","updated":"2020-07-21 12:00:23.000000000","message":"Done","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"06660399e47de57ce4b93fd8c1e90ea5469052c6","unresolved":false,"context_lines":[{"line_number":231,"context_line":"Upon a failure in the second phase of the migration, the share server and all"},{"line_number":232,"context_line":"its shares will have their status updated to ``error`` and their `task_state`"},{"line_number":233,"context_line":"set to ``server_migration_error``. At this point, won\u0027t be possible to"},{"line_number":234,"context_line":"determine the status of the share server and its shares, and will be up to the"},{"line_number":235,"context_line":"administrator to manually fix this problem."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"3) `share-server-migration-cancel`"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_2618dc82","line":234,"range":{"start_line":234,"start_character":57,"end_line":234,"end_character":65},"updated":"2020-07-21 08:41:54.000000000","message":"and it will","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8da83d2e66ea43ac9b84bc81b0ae1d3dddf3195c","unresolved":false,"context_lines":[{"line_number":231,"context_line":"Upon a failure in the second phase of the migration, the share server and all"},{"line_number":232,"context_line":"its shares will have their status updated to ``error`` and their `task_state`"},{"line_number":233,"context_line":"set to ``server_migration_error``. At this point, won\u0027t be possible to"},{"line_number":234,"context_line":"determine the status of the share server and its shares, and will be up to the"},{"line_number":235,"context_line":"administrator to manually fix this problem."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"3) `share-server-migration-cancel`"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_daee0fec","line":234,"range":{"start_line":234,"start_character":57,"end_line":234,"end_character":65},"in_reply_to":"bf51134e_2618dc82","updated":"2020-07-21 12:00:23.000000000","message":"Done","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"06660399e47de57ce4b93fd8c1e90ea5469052c6","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"As implemented in share migration approach, drivers will be invoked to check"},{"line_number":387,"context_line":"the compatibility with the destination back end before starting the migration."},{"line_number":388,"context_line":"During this validation, driver will be able to return the capabilities"},{"line_number":389,"context_line":"supported for migrating a share server to the provided destination, such as"},{"line_number":390,"context_line":"remaining writable, preserving snapshots and others."},{"line_number":391,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_696e27ca","line":388,"range":{"start_line":388,"start_character":24,"end_line":388,"end_character":30},"updated":"2020-07-21 08:41:54.000000000","message":"drivers","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8da83d2e66ea43ac9b84bc81b0ae1d3dddf3195c","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"As implemented in share migration approach, drivers will be invoked to check"},{"line_number":387,"context_line":"the compatibility with the destination back end before starting the migration."},{"line_number":388,"context_line":"During this validation, driver will be able to return the capabilities"},{"line_number":389,"context_line":"supported for migrating a share server to the provided destination, such as"},{"line_number":390,"context_line":"remaining writable, preserving snapshots and others."},{"line_number":391,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_baeb5bda","line":388,"range":{"start_line":388,"start_character":24,"end_line":388,"end_character":30},"in_reply_to":"bf51134e_696e27ca","updated":"2020-07-21 12:00:23.000000000","message":"Done","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"06660399e47de57ce4b93fd8c1e90ea5469052c6","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Finally, the driver will need to perform the last steps to complete the share"},{"line_number":399,"context_line":"server migration when the `share_server_migration_complete` is invoked. At this"},{"line_number":400,"context_line":"moment, the access to the source share server shares should be interrupted"},{"line_number":401,"context_line":"and moved to the new destination."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_a9679fea","line":400,"range":{"start_line":400,"start_character":53,"end_line":400,"end_character":74},"updated":"2020-07-21 08:41:54.000000000","message":"I think it should be up to the driver if this is disruptive or not?","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8da83d2e66ea43ac9b84bc81b0ae1d3dddf3195c","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Finally, the driver will need to perform the last steps to complete the share"},{"line_number":399,"context_line":"server migration when the `share_server_migration_complete` is invoked. At this"},{"line_number":400,"context_line":"moment, the access to the source share server shares should be interrupted"},{"line_number":401,"context_line":"and moved to the new destination."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_bac4fb60","line":400,"range":{"start_line":400,"start_character":53,"end_line":400,"end_character":74},"in_reply_to":"bf51134e_a9679fea","updated":"2020-07-21 12:00:23.000000000","message":"yes! thanks for noticing.","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"06660399e47de57ce4b93fd8c1e90ea5469052c6","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"During the migration process users won\u0027t be able to perform any management"},{"line_number":417,"context_line":"operation in all shares that belong to the share server being migrated."},{"line_number":418,"context_line":"Depending on driver\u0027s capabilities, users may also loose write access to those"},{"line_number":419,"context_line":"shares."},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_2999cfcf","line":418,"range":{"start_line":418,"start_character":51,"end_line":418,"end_character":56},"updated":"2020-07-21 08:41:54.000000000","message":"lose","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8da83d2e66ea43ac9b84bc81b0ae1d3dddf3195c","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"During the migration process users won\u0027t be able to perform any management"},{"line_number":417,"context_line":"operation in all shares that belong to the share server being migrated."},{"line_number":418,"context_line":"Depending on driver\u0027s capabilities, users may also loose write access to those"},{"line_number":419,"context_line":"shares."},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_1a9fe765","line":418,"range":{"start_line":418,"start_character":51,"end_line":418,"end_character":56},"in_reply_to":"bf51134e_2999cfcf","updated":"2020-07-21 12:00:23.000000000","message":"Done","commit_id":"db6a000cc6c838816a7ac33d2443ba4be812fdf5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2f8a3cb52a3a22abe95ba014b03fb40482a71251","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Response::"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"  Body: {"},{"line_number":274,"context_line":"    \"total_progress\": 30,"},{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf51134e_3720f99b","line":273,"range":{"start_line":273,"start_character":0,"end_line":273,"end_character":8},"updated":"2020-07-21 19:47:19.000000000","message":"remove","commit_id":"2d6018f40f474b15c7d20ea1e030a541ba9bbe26"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"05b6b70f89d38bc269c79491c0f6733b839be78c","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Response::"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"  Body: {"},{"line_number":274,"context_line":"    \"total_progress\": 30,"},{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf51134e_1238633b","line":273,"range":{"start_line":273,"start_character":0,"end_line":273,"end_character":8},"in_reply_to":"bf51134e_3720f99b","updated":"2020-07-21 21:36:21.000000000","message":"Fixed!","commit_id":"2d6018f40f474b15c7d20ea1e030a541ba9bbe26"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"05b6b70f89d38bc269c79491c0f6733b839be78c","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"Response::"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"  Body: {"},{"line_number":319,"context_line":"      \"compatible\": true,"},{"line_number":320,"context_line":"      \"requested_capabilities\": {"},{"line_number":321,"context_line":"        \"writable\": true,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf51134e_723c3f30","line":318,"range":{"start_line":318,"start_character":2,"end_line":318,"end_character":7},"updated":"2020-07-21 21:36:21.000000000","message":"removed","commit_id":"2d6018f40f474b15c7d20ea1e030a541ba9bbe26"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2f8a3cb52a3a22abe95ba014b03fb40482a71251","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"The migration operations `migration_cancel` and `migration_get_progress` may"},{"line_number":350,"context_line":"also be available depending on the driver implementation."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Driver impact"},{"line_number":353,"context_line":"-------------"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf51134e_978c6580","line":351,"range":{"start_line":351,"start_character":0,"end_line":351,"end_character":0},"updated":"2020-07-21 19:47:19.000000000","message":"A few things that I\u0027m unclear about:\n\n- Will the \"migration-check\" results be cached anywhere in the DB so that you can validate them on \"migration-start\"? Or is this API just informational, and is for best practice\n- How will a failed migration (due to validation failures) be reflected in terms of statuses of share servers, shares, snapshots, groups?\n- A share server is utmost attached to a single share network subnet. What if users use the share network during an ongoing migration?","commit_id":"2d6018f40f474b15c7d20ea1e030a541ba9bbe26"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b40bcfb3befe02b157539cc1ed7fea7e0ed4d64a","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"The migration operations `migration_cancel` and `migration_get_progress` may"},{"line_number":350,"context_line":"also be available depending on the driver implementation."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Driver impact"},{"line_number":353,"context_line":"-------------"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf51134e_97a745a8","line":351,"range":{"start_line":351,"start_character":0,"end_line":351,"end_character":0},"in_reply_to":"bf51134e_978c6580","updated":"2020-07-21 20:21:57.000000000","message":"1) I\u0027m not expecting to cache this info. We might use \u0027check_compatibility\u0027 to also validate the \u0027capacity\u0027 of the destination host, due to Scheduler limitations on working only with pool capacities and not backend capacities. .\n\n2) I thought on using the same approach of share-migration for now. In the initial validations, there is no status changes for these resource, so only error messages are provided at this moment if one check fails. All status are updated before sending the request to the scheduler or to the destination share manager. If it still before the 2nd phase, these resources will become \u0027available\u0027 again and the \u0027task_state\u0027 updated to \u0027server_migration_error\u0027. Is there a better way of providing a better feedback to admins?\n\n3) I still can\u0027t see issues here. The process of reusing or creating a new share server in the destination will be the same as stand for share creation. It is expected that users can\u0027t change the share network if one or more share servers are attached to it. Share manager won\u0027t let new shares be placed in a share server that is a migration destination. Am I not seeing other issues here?\n\nThanks for raising these points Goutham!","commit_id":"2d6018f40f474b15c7d20ea1e030a541ba9bbe26"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"423102ed1c8ab0a2caab211c579d3c47f3443c4b","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"The migration operations `migration_cancel` and `migration_get_progress` may"},{"line_number":350,"context_line":"also be available depending on the driver implementation."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Driver impact"},{"line_number":353,"context_line":"-------------"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf51134e_1281834b","line":351,"range":{"start_line":351,"start_character":0,"end_line":351,"end_character":0},"in_reply_to":"bf51134e_97a745a8","updated":"2020-07-21 21:07:18.000000000","message":"Okay, so without caching this info, we expect the validation to occur again, and if it fails, we set the statuses back to \"available\" and indicate via task state that the server migration failed. I\u0027m okay with this approach, because validation info can get out of date with reality when cached.","commit_id":"2d6018f40f474b15c7d20ea1e030a541ba9bbe26"}]}