)]}'
{"spec-lite-add-max-shares-on-share-server-limit.rst":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa339bff02eff124d994a1cef0ebc208aa273c8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":":problem: An administrator is not able to specify how many shares can be"},{"line_number":2,"context_line":"          created in a given share server, nor the maximum size that a share"},{"line_number":3,"context_line":"          server can hit. The current behavior allows the system to allocate"},{"line_number":4,"context_line":"          a bunch of shares in a single share server and it allows the share"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_26b02643","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":72},"updated":"2020-07-15 16:18:19.000000000","message":"This doc needs a title, and probably should have the standard copyright header.","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c436f5735a266f2d316c723e2e7dd9fe8a71e8a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":":problem: An administrator is not able to specify how many shares can be"},{"line_number":2,"context_line":"          created in a given share server, nor the maximum size that a share"},{"line_number":3,"context_line":"          server can hit. The current behavior allows the system to allocate"},{"line_number":4,"context_line":"          a bunch of shares in a single share server and it allows the share"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_a11b807e","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":72},"in_reply_to":"bf51134e_26b02643","updated":"2020-07-20 20:38:02.000000000","message":"+1","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8714efd6e3b96aef9d4e903f0b52afed1c7564","unresolved":false,"context_lines":[{"line_number":1,"context_line":":problem: An administrator is not able to specify how many shares can be"},{"line_number":2,"context_line":"          created in a given share server, nor the maximum size that a share"},{"line_number":3,"context_line":"          server can hit. The current behavior allows the system to allocate"},{"line_number":4,"context_line":"          a bunch of shares in a single share server and it allows the share"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_33eea3ec","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":72},"in_reply_to":"bf51134e_26b02643","updated":"2020-07-15 19:44:29.000000000","message":"That\u0027s right. Don\u0027t know how I forgot the title for this. Thanks for reminding me, Tom","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa339bff02eff124d994a1cef0ebc208aa273c8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"          a bunch of shares in a single share server and it allows the share"},{"line_number":5,"context_line":"          server to reach a huge size, making it a bit harder to manage."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":solution: We could add a limit for the amount of shares that a share"},{"line_number":8,"context_line":"           server can hold. Administrators can configure this limit for each"},{"line_number":9,"context_line":"           backend, and have more control over the size of shares servers,"},{"line_number":10,"context_line":"           which helps them to manage the cloud resources. The proposed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_a638b69f","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":20},"updated":"2020-07-15 16:18:19.000000000","message":"\u0027should\u0027 or \u0027will\u0027","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8714efd6e3b96aef9d4e903f0b52afed1c7564","unresolved":false,"context_lines":[{"line_number":4,"context_line":"          a bunch of shares in a single share server and it allows the share"},{"line_number":5,"context_line":"          server to reach a huge size, making it a bit harder to manage."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":solution: We could add a limit for the amount of shares that a share"},{"line_number":8,"context_line":"           server can hold. Administrators can configure this limit for each"},{"line_number":9,"context_line":"           backend, and have more control over the size of shares servers,"},{"line_number":10,"context_line":"           which helps them to manage the cloud resources. The proposed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_33c7c366","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":20},"in_reply_to":"bf51134e_a638b69f","updated":"2020-07-15 19:44:29.000000000","message":"Done","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa339bff02eff124d994a1cef0ebc208aa273c8b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"           whereby the administrators are able to determine the amount of"},{"line_number":14,"context_line":"           shares that can be created upon a given share server."},{"line_number":15,"context_line":"           Configuring the ``max_shares_per_share_server`` property means"},{"line_number":16,"context_line":"           that after hitting the limit of shares in a share server, it will"},{"line_number":17,"context_line":"           be filtered out from the compatible share server list."},{"line_number":18,"context_line":"           For the ``max_share_server_size`` backend capability, the service"},{"line_number":19,"context_line":"           will understand that when a given share server hits the specified"},{"line_number":20,"context_line":"           amount of gigabytes, the share server will be filtered out and a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_e6546e00","line":17,"range":{"start_line":16,"start_character":69,"end_line":17,"end_character":65},"updated":"2020-07-15 16:18:19.000000000","message":"I think you need to be more explicit about which service is doing the filtering.","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8714efd6e3b96aef9d4e903f0b52afed1c7564","unresolved":false,"context_lines":[{"line_number":13,"context_line":"           whereby the administrators are able to determine the amount of"},{"line_number":14,"context_line":"           shares that can be created upon a given share server."},{"line_number":15,"context_line":"           Configuring the ``max_shares_per_share_server`` property means"},{"line_number":16,"context_line":"           that after hitting the limit of shares in a share server, it will"},{"line_number":17,"context_line":"           be filtered out from the compatible share server list."},{"line_number":18,"context_line":"           For the ``max_share_server_size`` backend capability, the service"},{"line_number":19,"context_line":"           will understand that when a given share server hits the specified"},{"line_number":20,"context_line":"           amount of gigabytes, the share server will be filtered out and a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_5366b752","line":17,"range":{"start_line":16,"start_character":69,"end_line":17,"end_character":65},"in_reply_to":"bf51134e_e6546e00","updated":"2020-07-15 19:44:29.000000000","message":"Yeah, makes sense. Tried to be a bit more specific now :)","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa339bff02eff124d994a1cef0ebc208aa273c8b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"           final gigabytes amount, but share replicas and snapshots will be"},{"line_number":24,"context_line":"           considered as well."},{"line_number":25,"context_line":"           If one of these backend capabilities is not set in the chosen"},{"line_number":26,"context_line":"           backend, the service will understand that there is no limit for"},{"line_number":27,"context_line":"           shares or gigabytes in that backend share servers."},{"line_number":28,"context_line":"           The share manager ``provide_share_server_for_share`` and"},{"line_number":29,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_46155a3c","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":32},"updated":"2020-07-15 16:18:19.000000000","message":"Which service?","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8714efd6e3b96aef9d4e903f0b52afed1c7564","unresolved":false,"context_lines":[{"line_number":23,"context_line":"           final gigabytes amount, but share replicas and snapshots will be"},{"line_number":24,"context_line":"           considered as well."},{"line_number":25,"context_line":"           If one of these backend capabilities is not set in the chosen"},{"line_number":26,"context_line":"           backend, the service will understand that there is no limit for"},{"line_number":27,"context_line":"           shares or gigabytes in that backend share servers."},{"line_number":28,"context_line":"           The share manager ``provide_share_server_for_share`` and"},{"line_number":29,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_7663e942","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":32},"in_reply_to":"bf51134e_46155a3c","updated":"2020-07-15 19:44:29.000000000","message":"To be precise, I decided to replace this for \"the share manager will understand...\"","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa339bff02eff124d994a1cef0ebc208aa273c8b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"           shares or gigabytes in that backend share servers."},{"line_number":28,"context_line":"           The share manager ``provide_share_server_for_share`` and"},{"line_number":29,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"},{"line_number":30,"context_line":"           to also check if there is a configured limit in the correspondent"},{"line_number":31,"context_line":"           backend session in the Manila configuration file."},{"line_number":32,"context_line":"           If at least one of the properties was specified, the service will"},{"line_number":33,"context_line":"           query the amount of existent share server resources using the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_862c9299","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":76},"updated":"2020-07-15 16:18:19.000000000","message":"corresponding","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8714efd6e3b96aef9d4e903f0b52afed1c7564","unresolved":false,"context_lines":[{"line_number":27,"context_line":"           shares or gigabytes in that backend share servers."},{"line_number":28,"context_line":"           The share manager ``provide_share_server_for_share`` and"},{"line_number":29,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"},{"line_number":30,"context_line":"           to also check if there is a configured limit in the correspondent"},{"line_number":31,"context_line":"           backend session in the Manila configuration file."},{"line_number":32,"context_line":"           If at least one of the properties was specified, the service will"},{"line_number":33,"context_line":"           query the amount of existent share server resources using the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_73a2dbaf","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":76},"in_reply_to":"bf51134e_862c9299","updated":"2020-07-15 19:44:29.000000000","message":"Done","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa339bff02eff124d994a1cef0ebc208aa273c8b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"           database layer for performance purposes, and finally, if needed,"},{"line_number":35,"context_line":"           request the creation of a new share server to place the received"},{"line_number":36,"context_line":"           request."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":":impacts: This implementation slightly impacts performance only when at least"},{"line_number":39,"context_line":"          one of the backend capabilities was set, but there is no expectation"},{"line_number":40,"context_line":"          to increase significantly the share creation time, specially compared"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_66bdfe00","line":37,"updated":"2020-07-15 16:18:19.000000000","message":"Should cover what sort of error the user will experience if there is no backend with capacity for new shares and enough spare space.","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8714efd6e3b96aef9d4e903f0b52afed1c7564","unresolved":false,"context_lines":[{"line_number":34,"context_line":"           database layer for performance purposes, and finally, if needed,"},{"line_number":35,"context_line":"           request the creation of a new share server to place the received"},{"line_number":36,"context_line":"           request."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":":impacts: This implementation slightly impacts performance only when at least"},{"line_number":39,"context_line":"          one of the backend capabilities was set, but there is no expectation"},{"line_number":40,"context_line":"          to increase significantly the share creation time, specially compared"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_2948f659","line":37,"in_reply_to":"bf51134e_66bdfe00","updated":"2020-07-15 19:44:29.000000000","message":"I think these new limits won\u0027t raise new errors or something like that, considering that when a share server reachs the limits, a new share server will be provided and if the backend doesn\u0027t have enough space, the share wouldn\u0027t be created as it currently happens. But I think worth mentioning it here :).","commit_id":"00e43b865b24cfac55175957b27615d5dbf285ad"}],"specs/victoria/spec-lite-add-max-shares-on-share-server-limit.rst":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"59e23214e78931335b935e85e47757a3a66cf094","unresolved":false,"context_lines":[{"line_number":38,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"},{"line_number":39,"context_line":"           to also check if there is a configured limit in the corresponding"},{"line_number":40,"context_line":"           backend session in the Manila configuration file."},{"line_number":41,"context_line":"           If at least one of the properties was specified, the service will"},{"line_number":42,"context_line":"           query the amount of existent share server resources using the"},{"line_number":43,"context_line":"           database layer for performance purposes, and finally, if needed,"},{"line_number":44,"context_line":"           request the creation of a new share server to place the received"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_47f1d194","line":41,"range":{"start_line":41,"start_character":60,"end_line":41,"end_character":71},"updated":"2020-07-15 21:51:35.000000000","message":"share manager","commit_id":"0525228881a3894537070d30eb40acd94202afea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"64a69507798ea7643bed34e20e929a1a32e76a8e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"},{"line_number":39,"context_line":"           to also check if there is a configured limit in the corresponding"},{"line_number":40,"context_line":"           backend session in the Manila configuration file."},{"line_number":41,"context_line":"           If at least one of the properties was specified, the service will"},{"line_number":42,"context_line":"           query the amount of existent share server resources using the"},{"line_number":43,"context_line":"           database layer for performance purposes, and finally, if needed,"},{"line_number":44,"context_line":"           request the creation of a new share server to place the received"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_18e44f3b","line":41,"range":{"start_line":41,"start_character":60,"end_line":41,"end_character":71},"in_reply_to":"bf51134e_47f1d194","updated":"2020-07-16 18:55:03.000000000","message":"Done","commit_id":"0525228881a3894537070d30eb40acd94202afea"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"59e23214e78931335b935e85e47757a3a66cf094","unresolved":false,"context_lines":[{"line_number":59,"context_line":":alternative: As an alternative we could use share type extra specs to provide"},{"line_number":60,"context_line":"              driver specific limits for share server shares and max share"},{"line_number":61,"context_line":"              server size in gigabytes. This approach would work in a project"},{"line_number":62,"context_line":"              level, but we should consider that it may require the share"},{"line_number":63,"context_line":"              manager to forward more information to the driver than we do"},{"line_number":64,"context_line":"              today, in order to avoid driver calls to the storage which would"},{"line_number":65,"context_line":"              cause a performance deterioration."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":":timeline: Include in Victoria release."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_4746f1c1","line":65,"range":{"start_line":62,"start_character":25,"end_line":65,"end_character":48},"updated":"2020-07-15 21:51:35.000000000","message":"+1, I believe that this is the main reason for implementing this together with the share manager and avoid unnecessary calls to the backend.","commit_id":"0525228881a3894537070d30eb40acd94202afea"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"2f0adedb5fc616e388ac1c48d07bef7df7380df3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":":solution: We should add a limit for the amount of shares that a share"},{"line_number":17,"context_line":"           server can hold. Administrators can configure this limit for each"},{"line_number":18,"context_line":"           backend, and have more control over the size of shares servers,"},{"line_number":19,"context_line":"           which helps them to manage the cloud resources. The proposed"},{"line_number":20,"context_line":"           solution introduces two new backend properties called"},{"line_number":21,"context_line":"           ``max_shares_per_share_server`` and ``max_share_server_size``,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_c6c48062","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":73},"updated":"2020-07-21 08:02:40.000000000","message":"share servers","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8090bf58f89e3bb38154279b907588dd414a3df9","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":":solution: We should add a limit for the amount of shares that a share"},{"line_number":17,"context_line":"           server can hold. Administrators can configure this limit for each"},{"line_number":18,"context_line":"           backend, and have more control over the size of shares servers,"},{"line_number":19,"context_line":"           which helps them to manage the cloud resources. The proposed"},{"line_number":20,"context_line":"           solution introduces two new backend properties called"},{"line_number":21,"context_line":"           ``max_shares_per_share_server`` and ``max_share_server_size``,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_1aba47e0","line":18,"range":{"start_line":18,"start_character":59,"end_line":18,"end_character":73},"in_reply_to":"bf51134e_c6c48062","updated":"2020-07-21 13:29:24.000000000","message":"Done","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"2f0adedb5fc616e388ac1c48d07bef7df7380df3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"           whereby the administrators are able to determine the amount of"},{"line_number":23,"context_line":"           shares that can be created upon a given share server."},{"line_number":24,"context_line":"           Configuring the ``max_shares_per_share_server`` property means"},{"line_number":25,"context_line":"           that a share server who reached the limit of shares will filtered"},{"line_number":26,"context_line":"           out of the compatible share servers list in the share manager."},{"line_number":27,"context_line":"           For the ``max_share_server_size`` backend capability, when a given"},{"line_number":28,"context_line":"           share server hits the specified amount of gigabytes, the share"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_868f282d","line":25,"range":{"start_line":25,"start_character":31,"end_line":25,"end_character":34},"updated":"2020-07-21 08:02:40.000000000","message":"which","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"2f0adedb5fc616e388ac1c48d07bef7df7380df3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"           whereby the administrators are able to determine the amount of"},{"line_number":23,"context_line":"           shares that can be created upon a given share server."},{"line_number":24,"context_line":"           Configuring the ``max_shares_per_share_server`` property means"},{"line_number":25,"context_line":"           that a share server who reached the limit of shares will filtered"},{"line_number":26,"context_line":"           out of the compatible share servers list in the share manager."},{"line_number":27,"context_line":"           For the ``max_share_server_size`` backend capability, when a given"},{"line_number":28,"context_line":"           share server hits the specified amount of gigabytes, the share"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_e69c246c","line":25,"range":{"start_line":25,"start_character":63,"end_line":25,"end_character":76},"updated":"2020-07-21 08:02:40.000000000","message":"will be filtered","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8090bf58f89e3bb38154279b907588dd414a3df9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"           whereby the administrators are able to determine the amount of"},{"line_number":23,"context_line":"           shares that can be created upon a given share server."},{"line_number":24,"context_line":"           Configuring the ``max_shares_per_share_server`` property means"},{"line_number":25,"context_line":"           that a share server who reached the limit of shares will filtered"},{"line_number":26,"context_line":"           out of the compatible share servers list in the share manager."},{"line_number":27,"context_line":"           For the ``max_share_server_size`` backend capability, when a given"},{"line_number":28,"context_line":"           share server hits the specified amount of gigabytes, the share"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_5ab4bff2","line":25,"range":{"start_line":25,"start_character":31,"end_line":25,"end_character":34},"in_reply_to":"bf51134e_868f282d","updated":"2020-07-21 13:29:24.000000000","message":"Done","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8090bf58f89e3bb38154279b907588dd414a3df9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"           whereby the administrators are able to determine the amount of"},{"line_number":23,"context_line":"           shares that can be created upon a given share server."},{"line_number":24,"context_line":"           Configuring the ``max_shares_per_share_server`` property means"},{"line_number":25,"context_line":"           that a share server who reached the limit of shares will filtered"},{"line_number":26,"context_line":"           out of the compatible share servers list in the share manager."},{"line_number":27,"context_line":"           For the ``max_share_server_size`` backend capability, when a given"},{"line_number":28,"context_line":"           share server hits the specified amount of gigabytes, the share"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_3ab90be9","line":25,"range":{"start_line":25,"start_character":63,"end_line":25,"end_character":76},"in_reply_to":"bf51134e_e69c246c","updated":"2020-07-21 13:29:24.000000000","message":"Done","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bdeb56f2b2d87908a87fcd358c765b3d86097cb6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"           The share manager ``provide_share_server_for_share`` and"},{"line_number":38,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"},{"line_number":39,"context_line":"           to also check if there is a configured limit in the corresponding"},{"line_number":40,"context_line":"           backend session in the Manila configuration file."},{"line_number":41,"context_line":"           If at least one of the properties was specified, the share manager"},{"line_number":42,"context_line":"           will query the amount of existent share server resources using the"},{"line_number":43,"context_line":"           database layer for performance purposes, and finally, if needed,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_4e08ac90","line":40,"updated":"2020-07-17 15:43:38.000000000","message":"I understand that, if this is a config option, then in order to update it to a new value (say you get more storage and you have a bigger limit now) you need to restart the m-shr service in order to reflect the change, right?","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fa997631afc6e3bb827196f4d7e203058cc85820","unresolved":false,"context_lines":[{"line_number":37,"context_line":"           The share manager ``provide_share_server_for_share`` and"},{"line_number":38,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"},{"line_number":39,"context_line":"           to also check if there is a configured limit in the corresponding"},{"line_number":40,"context_line":"           backend session in the Manila configuration file."},{"line_number":41,"context_line":"           If at least one of the properties was specified, the share manager"},{"line_number":42,"context_line":"           will query the amount of existent share server resources using the"},{"line_number":43,"context_line":"           database layer for performance purposes, and finally, if needed,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_504de2c2","line":40,"in_reply_to":"bf51134e_4e08ac90","updated":"2020-07-17 21:10:22.000000000","message":"Yes. I think worth mentioning it here. Thanks for asking :)","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c436f5735a266f2d316c723e2e7dd9fe8a71e8a2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"           The share manager ``provide_share_server_for_share`` and"},{"line_number":38,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"},{"line_number":39,"context_line":"           to also check if there is a configured limit in the corresponding"},{"line_number":40,"context_line":"           backend session in the Manila configuration file."},{"line_number":41,"context_line":"           If at least one of the properties was specified, the share manager"},{"line_number":42,"context_line":"           will query the amount of existent share server resources using the"},{"line_number":43,"context_line":"           database layer for performance purposes, and finally, if needed,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_d12a7f2a","line":40,"in_reply_to":"bf51134e_504de2c2","updated":"2020-07-20 20:38:02.000000000","message":"You can make these options mutable from the get-go: https://docs.openstack.org/oslo.config/latest/reference/mutable.html\n\nManila supports mutable config, as long as you\u0027re coding such that the option is re-read each time, both the options you\u0027re adding can be changed without a service restart/","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8090bf58f89e3bb38154279b907588dd414a3df9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"           The share manager ``provide_share_server_for_share`` and"},{"line_number":38,"context_line":"           ``provide_share_server_for_share_group`` methods will be modified"},{"line_number":39,"context_line":"           to also check if there is a configured limit in the corresponding"},{"line_number":40,"context_line":"           backend session in the Manila configuration file."},{"line_number":41,"context_line":"           If at least one of the properties was specified, the share manager"},{"line_number":42,"context_line":"           will query the amount of existent share server resources using the"},{"line_number":43,"context_line":"           database layer for performance purposes, and finally, if needed,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_95c3c88a","line":40,"in_reply_to":"bf51134e_d12a7f2a","updated":"2020-07-21 13:29:24.000000000","message":"Awesome. Thanks for pointing it out, Goutham. Let\u0027s mention that these config options can be implemented as mutable then :)","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bdeb56f2b2d87908a87fcd358c765b3d86097cb6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"          to another possible approach where we ask the drivers to calculate"},{"line_number":55,"context_line":"          the amount of resources in a given share server."},{"line_number":56,"context_line":"          Administrators must be aware that when configuring one of these"},{"line_number":57,"context_line":"          limits more network allocations may be needed."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":":alternative: As an alternative we could use share type extra specs to provide"},{"line_number":60,"context_line":"              driver specific limits for share server shares and max share"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_ce9cbc5d","line":57,"updated":"2020-07-17 15:43:38.000000000","message":"Why is this?","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fa997631afc6e3bb827196f4d7e203058cc85820","unresolved":false,"context_lines":[{"line_number":54,"context_line":"          to another possible approach where we ask the drivers to calculate"},{"line_number":55,"context_line":"          the amount of resources in a given share server."},{"line_number":56,"context_line":"          Administrators must be aware that when configuring one of these"},{"line_number":57,"context_line":"          limits more network allocations may be needed."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":":alternative: As an alternative we could use share type extra specs to provide"},{"line_number":60,"context_line":"              driver specific limits for share server shares and max share"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_f0f3569e","line":57,"in_reply_to":"bf51134e_ce9cbc5d","updated":"2020-07-17 21:10:22.000000000","message":"Just mentioning this little detail. I mean, when this limits are configured, the number of allocated addresses can grow faster. Previously we didn\u0027t have some sort of limits, and regardless the amount of shares or resource gigabytes in a share server, it would keep growing and manila wouldn\u0027t provide a new share server if there is one who could be reused. So with this, admins would need to be aware that the number of allocations could grow a bit faster when these limits configured.","commit_id":"2c2e680e107b8400ffdcff07e920d2e8892431f9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b18c633a2c44285d4c1fc16678606cdde0b59bd8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"           request the creation of a new share server to place the received"},{"line_number":49,"context_line":"           request."},{"line_number":50,"context_line":"           When the limits are reached, no exceptions are being raised and"},{"line_number":51,"context_line":"           the users or admins won\u0027t be impacted by this. The share manager"},{"line_number":52,"context_line":"           itself will handle with the situation by providing a new share"},{"line_number":53,"context_line":"           server."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":":impacts: This implementation slightly impacts performance only when at least"},{"line_number":56,"context_line":"          one of the backend capabilities was set, but there is no expectation"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_19b4e0d0","line":53,"range":{"start_line":51,"start_character":58,"end_line":53,"end_character":18},"updated":"2020-07-23 12:28:23.000000000","message":"What if the back end doesn\u0027t have the capability to provide  yet one more share server -- e.g. it has hit some limit on the number of these that it can offer?","commit_id":"ed1c6aaad80778b2be2ac14b705aa1f40d5344e3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ab4cb434954ef30281d03ca9848dd8fbf90c5d7d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"           request the creation of a new share server to place the received"},{"line_number":49,"context_line":"           request."},{"line_number":50,"context_line":"           When the limits are reached, no exceptions are being raised and"},{"line_number":51,"context_line":"           the users or admins won\u0027t be impacted by this. The share manager"},{"line_number":52,"context_line":"           itself will handle with the situation by providing a new share"},{"line_number":53,"context_line":"           server."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":":impacts: This implementation slightly impacts performance only when at least"},{"line_number":56,"context_line":"          one of the backend capabilities was set, but there is no expectation"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_9c161e49","line":53,"range":{"start_line":51,"start_character":58,"end_line":53,"end_character":18},"in_reply_to":"bf51134e_19b4e0d0","updated":"2020-07-23 13:09:43.000000000","message":"In this case, when creating a new share server, backend itself is going to deny the request (as it would happen even if these new limits were not implemented and manila tried to provide a new share server).\nBut a good option to the administrator in this case would be to set higher values to these share server limits or even set -1 (no limit), so manila woudn\u0027t request the creation of a new share server and would reuse the existent ones.","commit_id":"ed1c6aaad80778b2be2ac14b705aa1f40d5344e3"}]}