)]}'
{"specs/wallaby/add-security-service-in-use-share-network.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b892fdf_36fc2bd2","updated":"2020-11-24 00:55:37.000000000","message":"Is it possible to combine this specification with the other one that seeks to allow updating a security service? If not, why?\n\nthree actions that aren\u0027t supported today, but could be evolved with a consistent user experience can be:\n\n1) Adding one or more security services to a share network in use, and\n2) Updating an existing security service from a share network that\u0027s in use\n3) Removing a security service from a share network that\u0027s in use\n\n\nTo provide that consistent user experience, we also need to distinguish between backends that can and cannot support this feature so that expectations can be deterministic. That is:\n\nThe user could be allowed to know if they can or cannot update their share network security services before hand - perhaps through the share type as a capability? or by inspecting a used share network (the share type capability could be copied over to the share network).\n\nIf update can\u0027t be supported, we\u0027d fail all three operations above fast. We wouldn\u0027t allow user workloads from a given share network to span backends that have different levels of support for mutable security services - yet another aspect of deterministic design. WDYT?\n\nThese proposals (and associated changes) can stay separate if we believe backends actually can\u0027t offer security service configuration updates as well as new security service reconfigurations at the same time. I know you\u0027re not proposing a solution for problem (3), but I want to bring it up here for completeness.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e8116ce015692962c380b20d0bf55cbe204d967f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f60465e9_361f36c7","in_reply_to":"7b892fdf_36fc2bd2","updated":"2020-11-24 17:47:32.000000000","message":"Thank you Goutham for adding these notes and concerns.\n\nYes, it is possible to merge both specs, since they are converging to be share-network operations. \n\nAbout \u0027removing security service\u0027: - The idea was to not include the removal operation, since it can be dangerous and lead to scenario that can be hard to be reverted; Admins may not be able to recover from this failure so easily. Make sense? Do you think that is mandatory to have this operation too? Both Add and Update should cover almost all user scenarios so far. \n\nCapabilities: I believe that we can rely in a single back end capability, since update and add are very analogous operations.\n\nI will start to merge and fix all comments within this spec and will get back to you guys if I found any gap with the new \u0027share-network\u0027 approach for both updating and adding security service.\n\nBy allowing the update at share-network granularity we may mitigate lots of share server updates at once and have a more phased operation.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"network starts being used by a share server."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This spec proposes an improvement on share network association with security"},{"line_number":26,"context_line":"service that will allows users to add new security services, which can reflect"},{"line_number":27,"context_line":"on modifications in all related share servers."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_7b8461d3","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":24},"updated":"2020-11-17 11:56:28.000000000","message":"nit: allow","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"network starts being used by a share server."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This spec proposes an improvement on share network association with security"},{"line_number":26,"context_line":"service that will allows users to add new security services, which can reflect"},{"line_number":27,"context_line":"on modifications in all related share servers."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_7b5d8177","line":26,"range":{"start_line":26,"start_character":61,"end_line":26,"end_character":78},"updated":"2020-11-17 11:56:28.000000000","message":"reflecting?\nI mean, as far as I understood, everytime a security service is added to a share network that has share servers, all of its share servers are being modified, right?","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":false,"context_lines":[{"line_number":23,"context_line":"network starts being used by a share server."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This spec proposes an improvement on share network association with security"},{"line_number":26,"context_line":"service that will allows users to add new security services, which can reflect"},{"line_number":27,"context_line":"on modifications in all related share servers."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2174884f_61d7c145","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":24},"in_reply_to":"1f621f24_7b8461d3","updated":"2020-11-30 12:16:31.000000000","message":"done","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Share network association with security services can\u0027t be changed after a share"},{"line_number":33,"context_line":"server has been provisioned, and new authentication server configuration can\u0027t"},{"line_number":34,"context_line":"be added to the already deployed share servers. In this scenario, manila"},{"line_number":35,"context_line":"doesn\u0027t provide an easy path for users to associate new security services, and"},{"line_number":36,"context_line":"new share networks need to be created to fulfil that purpose."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_1b4e0dc0","line":33,"range":{"start_line":33,"start_character":59,"end_line":33,"end_character":72},"updated":"2020-11-17 11:56:28.000000000","message":"nit: configurations","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Share network association with security services can\u0027t be changed after a share"},{"line_number":33,"context_line":"server has been provisioned, and new authentication server configuration can\u0027t"},{"line_number":34,"context_line":"be added to the already deployed share servers. In this scenario, manila"},{"line_number":35,"context_line":"doesn\u0027t provide an easy path for users to associate new security services, and"},{"line_number":36,"context_line":"new share networks need to be created to fulfil that purpose."}],"source_content_type":"text/x-rst","patch_set":1,"id":"d3669bf2_18781913","line":33,"range":{"start_line":33,"start_character":59,"end_line":33,"end_character":72},"in_reply_to":"1f621f24_1b4e0dc0","updated":"2020-11-30 12:16:31.000000000","message":"Done","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"server has been provisioned, and new authentication server configuration can\u0027t"},{"line_number":34,"context_line":"be added to the already deployed share servers. In this scenario, manila"},{"line_number":35,"context_line":"doesn\u0027t provide an easy path for users to associate new security services, and"},{"line_number":36,"context_line":"new share networks need to be created to fulfil that purpose."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_3bcca933","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":47},"updated":"2020-11-17 11:56:28.000000000","message":"fulfill","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":false,"context_lines":[{"line_number":33,"context_line":"server has been provisioned, and new authentication server configuration can\u0027t"},{"line_number":34,"context_line":"be added to the already deployed share servers. In this scenario, manila"},{"line_number":35,"context_line":"doesn\u0027t provide an easy path for users to associate new security services, and"},{"line_number":36,"context_line":"new share networks need to be created to fulfil that purpose."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c41c06e4_25863106","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":47},"in_reply_to":"1f621f24_3bcca933","updated":"2020-11-30 12:16:31.000000000","message":"removed in the newest PS.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    association between these resources."},{"line_number":56,"context_line":"3.  User wants to associate a new security service with a share network that is"},{"line_number":57,"context_line":"    being used by at least one share server. Manila will validate if all share"},{"line_number":58,"context_line":"    servers have support for such capability. If any share server doesn\u0027t"},{"line_number":59,"context_line":"    support it, the operation will fail, otherwise, all shares servers will"},{"line_number":60,"context_line":"    enter in modification state and have their security service configuration"},{"line_number":61,"context_line":"    updated."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_7b6e2100","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":44},"updated":"2020-11-17 11:56:28.000000000","message":"maybe: support updating such capability?","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    association between these resources."},{"line_number":56,"context_line":"3.  User wants to associate a new security service with a share network that is"},{"line_number":57,"context_line":"    being used by at least one share server. Manila will validate if all share"},{"line_number":58,"context_line":"    servers have support for such capability. If any share server doesn\u0027t"},{"line_number":59,"context_line":"    support it, the operation will fail, otherwise, all shares servers will"},{"line_number":60,"context_line":"    enter in modification state and have their security service configuration"},{"line_number":61,"context_line":"    updated."}],"source_content_type":"text/x-rst","patch_set":1,"id":"232992e3_8c67003c","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":44},"in_reply_to":"1f621f24_7b6e2100","updated":"2020-11-30 12:16:31.000000000","message":"this sentence was removed in the newest PS","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"service associations, the following changes are being proposed:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Change API semantic to allow share network and security service association"},{"line_number":77,"context_line":"  to eb updated, even when they are being used by share servers;"},{"line_number":78,"context_line":"* Update share server model to include a new capability, for supporting"},{"line_number":79,"context_line":"  association of new security services;"},{"line_number":80,"context_line":"* Add a new share server state, indicating that it\u0027s under network"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_bb5c394b","line":77,"range":{"start_line":77,"start_character":5,"end_line":77,"end_character":7},"updated":"2020-11-17 11:56:28.000000000","message":"be","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":false,"context_lines":[{"line_number":74,"context_line":"service associations, the following changes are being proposed:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Change API semantic to allow share network and security service association"},{"line_number":77,"context_line":"  to eb updated, even when they are being used by share servers;"},{"line_number":78,"context_line":"* Update share server model to include a new capability, for supporting"},{"line_number":79,"context_line":"  association of new security services;"},{"line_number":80,"context_line":"* Add a new share server state, indicating that it\u0027s under network"}],"source_content_type":"text/x-rst","patch_set":1,"id":"27820bc3_a6eac7f6","line":77,"range":{"start_line":77,"start_character":5,"end_line":77,"end_character":7},"in_reply_to":"1f621f24_bb5c394b","updated":"2020-11-30 12:16:31.000000000","message":"Done","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Change API semantic to allow share network and security service association"},{"line_number":77,"context_line":"  to eb updated, even when they are being used by share servers;"},{"line_number":78,"context_line":"* Update share server model to include a new capability, for supporting"},{"line_number":79,"context_line":"  association of new security services;"},{"line_number":80,"context_line":"* Add a new share server state, indicating that it\u0027s under network"},{"line_number":81,"context_line":"  modification;"},{"line_number":82,"context_line":"* Add a new driver interface for share server update;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fcb8ff48_5db99256","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":39},"updated":"2020-11-24 00:55:37.000000000","message":"Instead of having this capability in the share server model, I suppose it could make sense in the share network database model - that way, you can expose it to end users, and infer it in the share server model via ORM, and its association to the share network model.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Change API semantic to allow share network and security service association"},{"line_number":77,"context_line":"  to eb updated, even when they are being used by share servers;"},{"line_number":78,"context_line":"* Update share server model to include a new capability, for supporting"},{"line_number":79,"context_line":"  association of new security services;"},{"line_number":80,"context_line":"* Add a new share server state, indicating that it\u0027s under network"},{"line_number":81,"context_line":"  modification;"},{"line_number":82,"context_line":"* Add a new driver interface for share server update;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ec59f323_ddc87d26","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":39},"in_reply_to":"fcb8ff48_5db99256","updated":"2020-11-30 12:16:31.000000000","message":"I think that this capability should stay in share server model, that is always associated with a single back end/driver that supports or not this functionality.\nWe can expose this capability via share network, that can be inferred from all its current share servers, since share network and share servers are a dynamic relationship that may have heterogeneous back ends.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":77,"context_line":"  to eb updated, even when they are being used by share servers;"},{"line_number":78,"context_line":"* Update share server model to include a new capability, for supporting"},{"line_number":79,"context_line":"  association of new security services;"},{"line_number":80,"context_line":"* Add a new share server state, indicating that it\u0027s under network"},{"line_number":81,"context_line":"  modification;"},{"line_number":82,"context_line":"* Add a new driver interface for share server update;"},{"line_number":83,"context_line":"* Add a new back end capability to identify drivers that support such"},{"line_number":84,"context_line":"  functionality."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5dfa97c9_edb29912","line":81,"range":{"start_line":80,"start_character":2,"end_line":81,"end_character":15},"updated":"2020-11-24 00:55:37.000000000","message":"Could you please provide some notes on state transitions for share networks?","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":true,"context_lines":[{"line_number":77,"context_line":"  to eb updated, even when they are being used by share servers;"},{"line_number":78,"context_line":"* Update share server model to include a new capability, for supporting"},{"line_number":79,"context_line":"  association of new security services;"},{"line_number":80,"context_line":"* Add a new share server state, indicating that it\u0027s under network"},{"line_number":81,"context_line":"  modification;"},{"line_number":82,"context_line":"* Add a new driver interface for share server update;"},{"line_number":83,"context_line":"* Add a new back end capability to identify drivers that support such"},{"line_number":84,"context_line":"  functionality."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5df6a419_a9664a67","line":81,"range":{"start_line":80,"start_character":2,"end_line":81,"end_character":15},"in_reply_to":"5dfa97c9_edb29912","updated":"2020-11-30 12:16:31.000000000","message":"Done","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":80,"context_line":"* Add a new share server state, indicating that it\u0027s under network"},{"line_number":81,"context_line":"  modification;"},{"line_number":82,"context_line":"* Add a new driver interface for share server update;"},{"line_number":83,"context_line":"* Add a new back end capability to identify drivers that support such"},{"line_number":84,"context_line":"  functionality."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"API\u0027s Semantic Change"},{"line_number":87,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"55b38232_4d4d88f1","line":84,"range":{"start_line":83,"start_character":2,"end_line":84,"end_character":16},"updated":"2020-11-24 00:55:37.000000000","message":"You intend to funnel this out as an end user visible share type extra-spec, or a \"common capability\"?","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":92,"context_line":"need to check the new share server\u0027s capability,"},{"line_number":93,"context_line":"``new_security_service_association_support``, to see if the request can be"},{"line_number":94,"context_line":"completed or not, and fail earlier if at least one of the share servers"},{"line_number":95,"context_line":"doesn\u0027t support it."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Share API and Manager Changes"},{"line_number":98,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6536536e_48ea53cb","line":95,"range":{"start_line":95,"start_character":18,"end_line":95,"end_character":19},"updated":"2020-11-24 00:55:37.000000000","message":"Per suggestions above, this check will become straightforward if you can add this capability directly to the share network. \n\nWhen creating a share from a new share network, if the share network doesn\u0027t have this capability flag, we can infer it from the share type if it is set, else rely on the capability of the backend that the workload gets provisioned to.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":97,"context_line":"Share API and Manager Changes"},{"line_number":98,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Share API will start to handle security service updates, changing all"},{"line_number":101,"context_line":"affected share servers\u0027 status to ``network_change``, updating the share"},{"line_number":102,"context_line":"network association with the new security service in the database and calling"},{"line_number":103,"context_line":"the respective share services to initiate back end updates. In order to bring"},{"line_number":104,"context_line":"user visibility and block any new operation to happen while share servers are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"48a0ebc8_67cedaf1","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":52},"updated":"2020-11-24 00:55:37.000000000","message":"Instead of making bulk changes to shares, share servers, snapshots, replicas, groups, access rules and all other resources. We can add an ORM property to each of these resources to point back to the share network\u0027s status - that way, you won\u0027t have to update the database state of each of these dependent resources.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":98,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Share API will start to handle security service updates, changing all"},{"line_number":101,"context_line":"affected share servers\u0027 status to ``network_change``, updating the share"},{"line_number":102,"context_line":"network association with the new security service in the database and calling"},{"line_number":103,"context_line":"the respective share services to initiate back end updates. In order to bring"},{"line_number":104,"context_line":"user visibility and block any new operation to happen while share servers are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_9b121d61","line":101,"range":{"start_line":101,"start_character":36,"end_line":101,"end_character":50},"updated":"2020-11-17 11:56:28.000000000","message":"don\u0027t know if we should keep this name as `network_chage`. To me, it can sound as a share network change and sound kind of misleading. Wdyt?","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e8116ce015692962c380b20d0bf55cbe204d967f","unresolved":true,"context_lines":[{"line_number":97,"context_line":"Share API and Manager Changes"},{"line_number":98,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Share API will start to handle security service updates, changing all"},{"line_number":101,"context_line":"affected share servers\u0027 status to ``network_change``, updating the share"},{"line_number":102,"context_line":"network association with the new security service in the database and calling"},{"line_number":103,"context_line":"the respective share services to initiate back end updates. In order to bring"},{"line_number":104,"context_line":"user visibility and block any new operation to happen while share servers are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7816055f_1c3016e8","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":52},"in_reply_to":"48a0ebc8_67cedaf1","updated":"2020-11-24 17:47:32.000000000","message":"It is a good approach. We just need to make sure that all resource\u0027s operations will check that property before proceeding. We can think in a better way of doing that during the development.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":100,"context_line":"Share API will start to handle security service updates, changing all"},{"line_number":101,"context_line":"affected share servers\u0027 status to ``network_change``, updating the share"},{"line_number":102,"context_line":"network association with the new security service in the database and calling"},{"line_number":103,"context_line":"the respective share services to initiate back end updates. In order to bring"},{"line_number":104,"context_line":"user visibility and block any new operation to happen while share servers are"},{"line_number":105,"context_line":"being modified, all associated shares will have their status changed to"},{"line_number":106,"context_line":"``network_change``."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"The share manager will be responsible for updating share servers\u0027 backend"},{"line_number":109,"context_line":"details, and for calling the new driver\u0027s interface with the corresponding"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d4400210_9d5a3cfe","line":106,"range":{"start_line":103,"start_character":60,"end_line":106,"end_character":19},"updated":"2020-11-24 00:55:37.000000000","message":"We can expose this ORM property instead of performing a status change - for visibility, wdyt?\n\nOfcourse interacting with the resources themselves should be denied with HTTP 400, and the reasoning that the share network is busy with a \"network_change\"","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":106,"context_line":"``network_change``."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"The share manager will be responsible for updating share servers\u0027 backend"},{"line_number":109,"context_line":"details, and for calling the new driver\u0027s interface with the corresponding"},{"line_number":110,"context_line":"network modification. If the update ends up on a failure, the share server"},{"line_number":111,"context_line":"status will be set to ``error``, and all shares will be reverted to"},{"line_number":112,"context_line":"``available`` again. The share server\u0027s backend details will remain with the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2f7d8734_9bd8f367","line":109,"range":{"start_line":109,"start_character":29,"end_line":109,"end_character":51},"updated":"2020-11-24 00:55:37.000000000","message":"remove \"new\" - it is implied that this driver interface is brand new - but this sentence can be misconstrued as there being a \"new driver\"","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":true,"context_lines":[{"line_number":106,"context_line":"``network_change``."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"The share manager will be responsible for updating share servers\u0027 backend"},{"line_number":109,"context_line":"details, and for calling the new driver\u0027s interface with the corresponding"},{"line_number":110,"context_line":"network modification. If the update ends up on a failure, the share server"},{"line_number":111,"context_line":"status will be set to ``error``, and all shares will be reverted to"},{"line_number":112,"context_line":"``available`` again. The share server\u0027s backend details will remain with the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e2b35019_ba22df2b","line":109,"range":{"start_line":109,"start_character":29,"end_line":109,"end_character":51},"in_reply_to":"2f7d8734_9bd8f367","updated":"2020-11-30 12:16:31.000000000","message":"Done","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":109,"context_line":"details, and for calling the new driver\u0027s interface with the corresponding"},{"line_number":110,"context_line":"network modification. If the update ends up on a failure, the share server"},{"line_number":111,"context_line":"status will be set to ``error``, and all shares will be reverted to"},{"line_number":112,"context_line":"``available`` again. The share server\u0027s backend details will remain with the"},{"line_number":113,"context_line":"updated security service information, but will be up to the administrator to"},{"line_number":114,"context_line":"check in the storage system if the configuration is correct, before reset the"},{"line_number":115,"context_line":"status back to ``active``, using the ``share-server-reset-state`` API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_16b7043c","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":13},"updated":"2020-11-17 11:56:28.000000000","message":"Is there any way we can ensure the share is available if the share server is in an error state?\n\nI might be missing something and this may be a dumb question but, I mean, if something happens with the access to the share server, in my head, shares might be unreachable as well, depending on the failure...\nAnd if this scenario becomes true, shares\u0027 status are going to be available but users won\u0027t be able to do anything with it. So it might be misleading, right?\n\nI can think that it would be a pain to the administrator to have all of the share server shares updated to error or any other state, and then if the admin realizes nothing is wrong, change all shares to another state again, but if there is a contrary scenario, might be ok.\n\nSo, what are your thoughts on this?","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":false,"context_lines":[{"line_number":109,"context_line":"details, and for calling the new driver\u0027s interface with the corresponding"},{"line_number":110,"context_line":"network modification. If the update ends up on a failure, the share server"},{"line_number":111,"context_line":"status will be set to ``error``, and all shares will be reverted to"},{"line_number":112,"context_line":"``available`` again. The share server\u0027s backend details will remain with the"},{"line_number":113,"context_line":"updated security service information, but will be up to the administrator to"},{"line_number":114,"context_line":"check in the storage system if the configuration is correct, before reset the"},{"line_number":115,"context_line":"status back to ``active``, using the ``share-server-reset-state`` API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"aab02792_3fd22cca","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":13},"in_reply_to":"1f621f24_16b7043c","updated":"2020-11-24 00:55:37.000000000","message":"The implications can be on share access for sure. Would setting an error state on the \"access_rules_status\" be an option? \n\nWe need to spend some thought in this spec on how to recover from this sort of error. Besides Admins reading the logs, can this action be retried by the user?","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":false,"context_lines":[{"line_number":109,"context_line":"details, and for calling the new driver\u0027s interface with the corresponding"},{"line_number":110,"context_line":"network modification. If the update ends up on a failure, the share server"},{"line_number":111,"context_line":"status will be set to ``error``, and all shares will be reverted to"},{"line_number":112,"context_line":"``available`` again. The share server\u0027s backend details will remain with the"},{"line_number":113,"context_line":"updated security service information, but will be up to the administrator to"},{"line_number":114,"context_line":"check in the storage system if the configuration is correct, before reset the"},{"line_number":115,"context_line":"status back to ``active``, using the ``share-server-reset-state`` API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c9d14cbc_b5a1d65b","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":13},"in_reply_to":"aab02792_3fd22cca","updated":"2020-11-30 12:16:31.000000000","message":"Updated the spec to reset share access to \u0027error\u0027. But for sure, this is something that we still need to spend some time investigating.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":153,"context_line":"* Semantic changes are expected in the share network API. Associating new"},{"line_number":154,"context_line":"  security services for in use share networks will require that all share"},{"line_number":155,"context_line":"  servers affected by the change support such operation, or the API will"},{"line_number":156,"context_line":"  continue to respond with ``403 Forbidden``. If the destination share service"},{"line_number":157,"context_line":"  is unavailable, the API will respond with ``409 Conflict``."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5320bffc_be5095c9","line":156,"range":{"start_line":156,"start_character":29,"end_line":156,"end_character":42},"updated":"2020-11-24 00:55:37.000000000","message":"sigh - weird response - we don\u0027t allow _anyone_ to update in use share networks today.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":true,"context_lines":[{"line_number":153,"context_line":"* Semantic changes are expected in the share network API. Associating new"},{"line_number":154,"context_line":"  security services for in use share networks will require that all share"},{"line_number":155,"context_line":"  servers affected by the change support such operation, or the API will"},{"line_number":156,"context_line":"  continue to respond with ``403 Forbidden``. If the destination share service"},{"line_number":157,"context_line":"  is unavailable, the API will respond with ``409 Conflict``."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"44467e4e_25a85181","line":156,"range":{"start_line":156,"start_character":29,"end_line":156,"end_character":42},"in_reply_to":"5320bffc_be5095c9","updated":"2020-11-30 12:16:31.000000000","message":"removed \u0027continue\u0027. But today the API answers 403 when users try to update security services that are in use by share networks.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"198b7b249253b8d0df59ad12de06b0f05110c8dd","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    configuration;"},{"line_number":228,"context_line":"  * New back end capability for supporting security service association will be"},{"line_number":229,"context_line":"    added to share driver."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"* Implementation in a first party driver"},{"line_number":232,"context_line":"* Add new functional test in manila-tempest-plugin"},{"line_number":233,"context_line":"* Update manila documentation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f621f24_960dd4e9","line":230,"updated":"2020-11-17 11:56:28.000000000","message":"Is a topic for updating the manila-manage command necessary?","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    configuration;"},{"line_number":228,"context_line":"  * New back end capability for supporting security service association will be"},{"line_number":229,"context_line":"    added to share driver."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"* Implementation in a first party driver"},{"line_number":232,"context_line":"* Add new functional test in manila-tempest-plugin"},{"line_number":233,"context_line":"* Update manila documentation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e7829afa_987d4aa5","line":230,"in_reply_to":"1f621f24_960dd4e9","updated":"2020-11-30 12:16:31.000000000","message":"Done thanks","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47ce92bc47453e81473cc045168ea84ebad1e6ef","unresolved":true,"context_lines":[{"line_number":235,"context_line":"Dependencies"},{"line_number":236,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"None."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"Testing"},{"line_number":241,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"71b9f53d_c1d2d95a","line":238,"range":{"start_line":238,"start_character":0,"end_line":238,"end_character":5},"updated":"2020-11-24 00:55:37.000000000","message":"If the specifications cannot be combined, i\u0027m interested to know in what order they\u0027ll be implemented.","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c99b30cfc4775fdfae2f0b7cbfc455eb918ba857","unresolved":false,"context_lines":[{"line_number":235,"context_line":"Dependencies"},{"line_number":236,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"None."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"Testing"},{"line_number":241,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b34fcc27_794a719e","line":238,"range":{"start_line":238,"start_character":0,"end_line":238,"end_character":5},"in_reply_to":"71b9f53d_c1d2d95a","updated":"2020-11-30 12:16:31.000000000","message":"Done","commit_id":"d76eceabdd5835cb8274de73863d577b0ca7da79"}],"specs/wallaby/security-service-updates-in-use-share-network.rst":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1722e3271e40427827b4315e296d354ce8adaddf","unresolved":true,"context_lines":[{"line_number":147,"context_line":"affected by errors raised by back end drivers, and will have its status"},{"line_number":148,"context_line":"updated to ``active`` again at the end of the security service update."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Scheduler Capability"},{"line_number":151,"context_line":"--------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Describe scheduler capability."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Manila Manage"},{"line_number":156,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fa9e01b_e6cba546","line":153,"range":{"start_line":150,"start_character":0,"end_line":153,"end_character":30},"updated":"2020-12-07 20:35:00.000000000","message":"Please describe the changes that will be necessary in the scheduler...","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4e02b939ed6fbf0eed752878468d3308cb202588","unresolved":false,"context_lines":[{"line_number":147,"context_line":"affected by errors raised by back end drivers, and will have its status"},{"line_number":148,"context_line":"updated to ``active`` again at the end of the security service update."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Scheduler Capability"},{"line_number":151,"context_line":"--------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Describe scheduler capability."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Manila Manage"},{"line_number":156,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"25354ac6_9eda5b9f","line":153,"range":{"start_line":150,"start_character":0,"end_line":153,"end_character":30},"in_reply_to":"5fa9e01b_e6cba546","updated":"2020-12-23 19:44:05.000000000","message":"Totally forgot. Just added a few lines about this capability.","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1722e3271e40427827b4315e296d354ce8adaddf","unresolved":true,"context_lines":[{"line_number":180,"context_line":"A new ``security_service_update_support`` capability field will be added to"},{"line_number":181,"context_line":"``manila.db.sqlalchemy.models.ShareServer`` indicating if the driver and the"},{"line_number":182,"context_line":"back end where this share server resides support the new security service"},{"line_number":183,"context_line":"update operations. In database migration upgrade the new column will be"},{"line_number":184,"context_line":"added with a default value set to ``False``, meaning that all share servers"},{"line_number":185,"context_line":"already deployed won\u0027t be able to update their security service configuration"},{"line_number":186,"context_line":"even if the driver supports it. In database migration downgrade the column will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"75af8985_d485cef1","line":183,"range":{"start_line":183,"start_character":48,"end_line":183,"end_character":52},"updated":"2020-12-07 20:35:00.000000000","message":", the new ...","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4e02b939ed6fbf0eed752878468d3308cb202588","unresolved":false,"context_lines":[{"line_number":180,"context_line":"A new ``security_service_update_support`` capability field will be added to"},{"line_number":181,"context_line":"``manila.db.sqlalchemy.models.ShareServer`` indicating if the driver and the"},{"line_number":182,"context_line":"back end where this share server resides support the new security service"},{"line_number":183,"context_line":"update operations. In database migration upgrade the new column will be"},{"line_number":184,"context_line":"added with a default value set to ``False``, meaning that all share servers"},{"line_number":185,"context_line":"already deployed won\u0027t be able to update their security service configuration"},{"line_number":186,"context_line":"even if the driver supports it. In database migration downgrade the column will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f59a2a2b_426ae259","line":183,"range":{"start_line":183,"start_character":48,"end_line":183,"end_character":52},"in_reply_to":"75af8985_d485cef1","updated":"2020-12-23 19:44:05.000000000","message":"Done","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1722e3271e40427827b4315e296d354ce8adaddf","unresolved":true,"context_lines":[{"line_number":189,"context_line":"A new ``status`` field will be added to the"},{"line_number":190,"context_line":"``manila.db.sqlalchemy.models.ShareNetwork`` to hold new states that will"},{"line_number":191,"context_line":"assist on different share network operations. At this moment, only three status"},{"line_number":192,"context_line":"will be assigned to share networks: ``active``, ``error`` and"},{"line_number":193,"context_line":"``network_change``. The share network is considered healthy and is available"},{"line_number":194,"context_line":"to be used only if its status is ``active``. The status ``network_change``"},{"line_number":195,"context_line":"represents a share network that is under modification and can\u0027t be changed or"}],"source_content_type":"text/x-rst","patch_set":3,"id":"34854a4f_00c85377","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":4},"updated":"2020-12-07 20:35:00.000000000","message":"could","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4e02b939ed6fbf0eed752878468d3308cb202588","unresolved":false,"context_lines":[{"line_number":189,"context_line":"A new ``status`` field will be added to the"},{"line_number":190,"context_line":"``manila.db.sqlalchemy.models.ShareNetwork`` to hold new states that will"},{"line_number":191,"context_line":"assist on different share network operations. At this moment, only three status"},{"line_number":192,"context_line":"will be assigned to share networks: ``active``, ``error`` and"},{"line_number":193,"context_line":"``network_change``. The share network is considered healthy and is available"},{"line_number":194,"context_line":"to be used only if its status is ``active``. The status ``network_change``"},{"line_number":195,"context_line":"represents a share network that is under modification and can\u0027t be changed or"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c65d07b3_8758a9f3","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":4},"in_reply_to":"34854a4f_00c85377","updated":"2020-12-23 19:44:05.000000000","message":"Done","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1722e3271e40427827b4315e296d354ce8adaddf","unresolved":true,"context_lines":[{"line_number":197,"context_line":"can\u0027t be recovered without administrator intervention, the share network"},{"line_number":198,"context_line":"will receive an ``error`` status."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"A new ``security_service_update_support`` property will be added to"},{"line_number":201,"context_line":"``manila.db.sqlalchemy.models.ShareNetwork`` to indicate when a share network"},{"line_number":202,"context_line":"supports the new security service update operations. This property is inherited"},{"line_number":203,"context_line":"from all associated share servers, which must support the capability, otherwise"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a1754630_f553557e","line":200,"range":{"start_line":200,"start_character":6,"end_line":200,"end_character":41},"updated":"2020-12-07 20:35:00.000000000","message":"what value will be the default for this field?","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4e02b939ed6fbf0eed752878468d3308cb202588","unresolved":false,"context_lines":[{"line_number":197,"context_line":"can\u0027t be recovered without administrator intervention, the share network"},{"line_number":198,"context_line":"will receive an ``error`` status."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"A new ``security_service_update_support`` property will be added to"},{"line_number":201,"context_line":"``manila.db.sqlalchemy.models.ShareNetwork`` to indicate when a share network"},{"line_number":202,"context_line":"supports the new security service update operations. This property is inherited"},{"line_number":203,"context_line":"from all associated share servers, which must support the capability, otherwise"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9c3edabb_7e85fb82","line":200,"range":{"start_line":200,"start_character":6,"end_line":200,"end_character":41},"in_reply_to":"a1754630_f553557e","updated":"2020-12-23 19:44:05.000000000","message":"I changed the end of this sentence, and I think that now is more clear when this property will be True or False.","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1722e3271e40427827b4315e296d354ce8adaddf","unresolved":true,"context_lines":[{"line_number":200,"context_line":"A new ``security_service_update_support`` property will be added to"},{"line_number":201,"context_line":"``manila.db.sqlalchemy.models.ShareNetwork`` to indicate when a share network"},{"line_number":202,"context_line":"supports the new security service update operations. This property is inherited"},{"line_number":203,"context_line":"from all associated share servers, which must support the capability, otherwise"},{"line_number":204,"context_line":"the share network update won\u0027t be available."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"589f25e7_7b7fbeaa","line":203,"range":{"start_line":203,"start_character":34,"end_line":203,"end_character":45},"updated":"2020-12-07 20:35:00.000000000","message":"so in a scenario where I do have 20 share servers and 19 of them can hold security service updates but 1 of them can\u0027t, the `security_service_update_support` will be set to `False`, right?","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4e02b939ed6fbf0eed752878468d3308cb202588","unresolved":false,"context_lines":[{"line_number":200,"context_line":"A new ``security_service_update_support`` property will be added to"},{"line_number":201,"context_line":"``manila.db.sqlalchemy.models.ShareNetwork`` to indicate when a share network"},{"line_number":202,"context_line":"supports the new security service update operations. This property is inherited"},{"line_number":203,"context_line":"from all associated share servers, which must support the capability, otherwise"},{"line_number":204,"context_line":"the share network update won\u0027t be available."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df25d0d5_e7afea17","line":203,"range":{"start_line":203,"start_character":34,"end_line":203,"end_character":45},"in_reply_to":"589f25e7_7b7fbeaa","updated":"2020-12-23 19:44:05.000000000","message":"Yes, you are correct. The new PS might be more clear about those values.","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1722e3271e40427827b4315e296d354ce8adaddf","unresolved":true,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"REST API impact"},{"line_number":207,"context_line":"---------------"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Both share server and share network view will include a new response"},{"line_number":210,"context_line":"  parameter, the ``security_service_update_support`` that will indicate if the"},{"line_number":211,"context_line":"  share server (or share network) is capable of updating security service"}],"source_content_type":"text/x-rst","patch_set":3,"id":"87444f50_91462370","line":208,"updated":"2020-12-07 20:35:00.000000000","message":"when the share network status is different from active, will other operations that can lead to driver calls in the future be blocked?\n\ne.g. share extension, shrink and possible others\n\nI\u0027m asking because the share server could be under modification and some backends perhaps make it unacessible to operations like this, or something may fail even if it wasn\u0027t supposed to, just because in that specific moment the share server was being modified.\n\nif so, I guess it would be important to mention it here and somehow in the previous paragraphs...\n\nwhat are your thoughts on this?","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4e02b939ed6fbf0eed752878468d3308cb202588","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"REST API impact"},{"line_number":207,"context_line":"---------------"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Both share server and share network view will include a new response"},{"line_number":210,"context_line":"  parameter, the ``security_service_update_support`` that will indicate if the"},{"line_number":211,"context_line":"  share server (or share network) is capable of updating security service"}],"source_content_type":"text/x-rst","patch_set":3,"id":"45da39c5_abc0254b","line":208,"in_reply_to":"87444f50_91462370","updated":"2020-12-23 19:44:05.000000000","message":"Yes, all operations that are related to share networks and do backend changes will need to be blocked in the API, by checking the share network \u0027status\u0027\nThis behavior was included here and a sentence in the \u0027API Changes\u0027 section was modified to better clarify this intention.","commit_id":"1a79b29722d8f7f0a8534d1b2abea2c45cb9b0b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40ab938a9148c31ebdea712146fe4adede188704","unresolved":true,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Backends that support this functionality will be able to report the"},{"line_number":155,"context_line":"`security_service_update_support` capability as `True` to the scheduler, which"},{"line_number":156,"context_line":"can further be used to select backend pools that support it."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Manila Manage"},{"line_number":159,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ecef5b7f_3858134c","line":156,"range":{"start_line":156,"start_character":59,"end_line":156,"end_character":60},"updated":"2021-01-13 04:04:43.000000000","message":"Will help if we add:\n\nIf the ability to add/replace security services is always desired, this capability must be set as an extra-spec on the share type used. If it isn\u0027t, during provisioning, it is possible that the scheduler will cause the creation of share servers in disparate backends, some of which may allow updating the security service, and some that may not.","commit_id":"afb0f5aeb675e2f09b2364af88c2cc261cddb6e7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40ab938a9148c31ebdea712146fe4adede188704","unresolved":true,"context_lines":[{"line_number":301,"context_line":"Security impact"},{"line_number":302,"context_line":"---------------"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"None."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"Notifications impact"},{"line_number":307,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c63a288f_3802ca84","line":304,"range":{"start_line":304,"start_character":0,"end_line":304,"end_character":5},"updated":"2021-01-13 04:04:43.000000000","message":"There is a security impact to end users, isn\u0027t there: You\u0027re allowing them to effectively replace the authentication domain, so, there\u0027s still a risk that existing access rules may not work on the new authentication service. So in theory, this could become an attack vector to remove authorized access if a user on your project performs this operation maliciously. \n\nSo, the new API policy must be adjusted accordingly if there are untrusted users in the project.","commit_id":"afb0f5aeb675e2f09b2364af88c2cc261cddb6e7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40ab938a9148c31ebdea712146fe4adede188704","unresolved":true,"context_lines":[{"line_number":306,"context_line":"Notifications impact"},{"line_number":307,"context_line":"--------------------"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"None."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"Other end user impact"},{"line_number":312,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cae75e17_477867d8","line":309,"range":{"start_line":309,"start_character":0,"end_line":309,"end_character":5},"updated":"2021-01-13 04:04:43.000000000","message":"You could send a telemetry notification when a security service has been updated.","commit_id":"afb0f5aeb675e2f09b2364af88c2cc261cddb6e7"}]}