)]}'
{"specs/wallaby/share-size-limited-by-share-type.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c22e307e22ccc6dcbeef1cea6eac80765e7cec","unresolved":true,"context_lines":[{"line_number":43,"context_line":"* Two new extra_specs keys of share type are added for support set the minimum"},{"line_number":44,"context_line":"  share size and maximum share size."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  * **min_share_size** Set the minimum size of share by the share type."},{"line_number":47,"context_line":"  * **max_share_size** Set the maximum size of share by the share type."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* The value of these keys is a positive integer, the unit defaults to GB."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b87a8f9b_e27dc39b","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":0},"updated":"2020-11-30 23:04:47.000000000","message":"Should these two extra specifications be user visible?\n\nAlso, \n\nThese aren\u0027t scoped in any way, so you\u0027ll have to take extra-care to discard them in the capabilities filtering. In contrast, in cinder, they\u0027re scoping extra-specs like this with a \"provisioning:\" [1]\nShould we do the same, so the scheduler filters automatically discard these keys?\n\n[1] https://review.opendev.org/c/openstack/cinder/+/713710","commit_id":"792d37a156f167f115a973b9df9c30bdec75a6c1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1e8e27a6c61b9ee440da48901d8df97f205b394a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"* Two new extra_specs keys of share type are added for support set the minimum"},{"line_number":44,"context_line":"  share size and maximum share size."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  * **min_share_size** Set the minimum size of share by the share type."},{"line_number":47,"context_line":"  * **max_share_size** Set the maximum size of share by the share type."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* The value of these keys is a positive integer, the unit defaults to GB."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8fbdfb24_aa5fbdd6","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":0},"in_reply_to":"b87a8f9b_e27dc39b","updated":"2020-12-01 09:15:04.000000000","message":"1:i think it can be user visible, even in the name of share type, can indicate its restriction rule, such as backend1_max_10_min_2.\n2:yes, we\u0027d better scoping extra-specs with a \"provisioning:\", scheduler will automatically ignore them.i will add it.","commit_id":"792d37a156f167f115a973b9df9c30bdec75a6c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd13adc4daa2b8888842c5aedfe76ecfe3831897","unresolved":true,"context_lines":[{"line_number":43,"context_line":"* Two new extra_specs keys of share type are added for support set the minimum"},{"line_number":44,"context_line":"  share size and maximum share size."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  * **provisioning:min_share_size** Set the minimum size of share by the"},{"line_number":47,"context_line":"    share type."},{"line_number":48,"context_line":"  * **provisioning:max_share_size** Set the maximum size of share by the"},{"line_number":49,"context_line":"    share type."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* The value of these keys is a positive integer, the unit defaults to GB."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"17db5a5d_56b2b59f","line":49,"range":{"start_line":46,"start_character":1,"end_line":49,"end_character":15},"updated":"2020-12-01 17:48:38.000000000","message":"Great, thanks. \n\nIf you make another patchset, please clarify that:\n\nthese two extra specifications will be visible to end users. If they\u0027re not set, it is assumed that there are no share size limits enforced by the share type; but limits may be enforced by the service and the user\u0027s quotas.","commit_id":"ab3657f92a2feaebc7c6fe4ebf5f165bad07a2b7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0d06114492d9f0caab0d2a27ed1fb0be383f9268","unresolved":true,"context_lines":[{"line_number":43,"context_line":"* Two new extra_specs keys of share type are added for support set the minimum"},{"line_number":44,"context_line":"  share size and maximum share size."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  * **provisioning:min_share_size** Set the minimum size of share by the"},{"line_number":47,"context_line":"    share type."},{"line_number":48,"context_line":"  * **provisioning:max_share_size** Set the maximum size of share by the"},{"line_number":49,"context_line":"    share type."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* The value of these keys is a positive integer, the unit defaults to GB."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"8e562c7b_e47bc2b2","line":49,"range":{"start_line":46,"start_character":1,"end_line":49,"end_character":15},"in_reply_to":"17db5a5d_56b2b59f","updated":"2020-12-02 01:27:59.000000000","message":"yes, it is necessary to clarify it here.","commit_id":"ab3657f92a2feaebc7c6fe4ebf5f165bad07a2b7"}]}