)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"425aa1dd855b9e9ee10d5a2c752f8b335674dab7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68dd0993_70f73105","updated":"2021-12-15 13:20:59.000000000","message":"Thank you, Felipe!\nAdded just a few issues\n","commit_id":"0046a3be9a03d441bed5948ff39be833406031eb"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ca0e99c_f13a653b","updated":"2021-12-15 15:59:16.000000000","message":"Hi Felipe, I added some comments, but most of them are minor issues or just suggestions. In general, the spec looks good to me.","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"}],"specs/yoga/share-network-multiple-subnets-per-az.rst":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"425aa1dd855b9e9ee10d5a2c752f8b335674dab7","unresolved":true,"context_lines":[{"line_number":21,"context_line":"same share network, being one, and only one, for each Availability Zone"},{"line_number":22,"context_line":"(AZ) [1]. It solved the isolation problem of network resources for replication"},{"line_number":23,"context_line":"scenario over availability zones as **failure domains** within an OpenStack"},{"line_number":24,"context_line":"cloud. However, it does not allow more than one subnet per AZ. Second the spec"},{"line_number":25,"context_line":"for this feature, it avoids the indeterminate behavior,  Manila would have no"},{"line_number":26,"context_line":"way of picking the right subnet of the choices it would have [2]."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5289966f_07ccf09f","line":24,"range":{"start_line":24,"start_character":63,"end_line":24,"end_character":70},"updated":"2021-12-15 13:20:59.000000000","message":"\"According to\"","commit_id":"0046a3be9a03d441bed5948ff39be833406031eb"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"425aa1dd855b9e9ee10d5a2c752f8b335674dab7","unresolved":true,"context_lines":[{"line_number":23,"context_line":"scenario over availability zones as **failure domains** within an OpenStack"},{"line_number":24,"context_line":"cloud. However, it does not allow more than one subnet per AZ. Second the spec"},{"line_number":25,"context_line":"for this feature, it avoids the indeterminate behavior,  Manila would have no"},{"line_number":26,"context_line":"way of picking the right subnet of the choices it would have [2]."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The previous problem makes sense when it is dealing with different networks,"},{"line_number":29,"context_line":"for the same network segment with several subnets the indeterminate behavior"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2915f5eb_26069a56","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":60},"updated":"2021-12-15 13:20:59.000000000","message":"\"from available choices\"","commit_id":"0046a3be9a03d441bed5948ff39be833406031eb"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"425aa1dd855b9e9ee10d5a2c752f8b335674dab7","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Currently, a cloud facing issues with lack of IPs should allocate a new subnet"},{"line_number":57,"context_line":"and configuring a router between them. It is less scalable, efficient and user"},{"line_number":58,"context_line":"friendly then adding the new subnet to the same network using the broadcast"},{"line_number":59,"context_line":"domain segment."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"71d6bbd6_c429c095","line":58,"range":{"start_line":58,"start_character":9,"end_line":58,"end_character":14},"updated":"2021-12-15 13:20:59.000000000","message":"just a typo: \"than\"","commit_id":"0046a3be9a03d441bed5948ff39be833406031eb"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"425aa1dd855b9e9ee10d5a2c752f8b335674dab7","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    To avoid any indeterminate (and hence wrong) behavior, we will not allow"},{"line_number":76,"context_line":"    more than than one network per availability zone. Only subnets from same"},{"line_number":77,"context_line":"    network."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Things that will not change:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"aab719d7_f30e8a03","line":76,"range":{"start_line":76,"start_character":9,"end_line":76,"end_character":18},"updated":"2021-12-15 13:20:59.000000000","message":"duplicated word","commit_id":"0046a3be9a03d441bed5948ff39be833406031eb"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/share-network-multiple-subnets-per-az"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In Manila, the provision of share is done either by drivers handling the share"},{"line_number":14,"context_line":"server (DHSS) or not. For DHSS, the Manila requires the network configuration"},{"line_number":15,"context_line":"(called share network) in order to setup the new share server. The share"},{"line_number":16,"context_line":"network is created by supplying the neutron network and neutron subnet IDs."}],"source_content_type":"text/x-rst","patch_set":2,"id":"c82ad278_e60b24c6","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":33},"updated":"2021-12-15 15:59:16.000000000","message":"\"provision of *a* share\"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":14,"context_line":"server (DHSS) or not. For DHSS, the Manila requires the network configuration"},{"line_number":15,"context_line":"(called share network) in order to setup the new share server. The share"},{"line_number":16,"context_line":"network is created by supplying the neutron network and neutron subnet IDs."},{"line_number":17,"context_line":"Then, for each new share server, it is requested to Neutron service one port"},{"line_number":18,"context_line":"in the share network subnet."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"With the Train release, the Manila started supporting several subnets to the"},{"line_number":21,"context_line":"same share network, being one, and only one, for each Availability Zone"}],"source_content_type":"text/x-rst","patch_set":2,"id":"57fb521a_639d0c8c","line":18,"range":{"start_line":17,"start_character":33,"end_line":18,"end_character":28},"updated":"2021-12-15 15:59:16.000000000","message":"suggestion - invert the phrase: \"one port is requested to Neutron service in ...\"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":21,"context_line":"same share network, being one, and only one, for each Availability Zone"},{"line_number":22,"context_line":"(AZ) [1]. It solved the isolation problem of network resources for replication"},{"line_number":23,"context_line":"scenario over availability zones as **failure domains** within an OpenStack"},{"line_number":24,"context_line":"cloud. However, it does not allow more than one subnet per AZ. Second the spec"},{"line_number":25,"context_line":"for this feature, it avoids the indeterminate behavior,  Manila would have no"},{"line_number":26,"context_line":"way of picking the right subnet of the choices it would have [2]."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"c73eb01d_0555b95f","line":24,"range":{"start_line":24,"start_character":63,"end_line":24,"end_character":70},"updated":"2021-12-15 15:59:16.000000000","message":"Please add a comma: \"Second, \"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":22,"context_line":"(AZ) [1]. It solved the isolation problem of network resources for replication"},{"line_number":23,"context_line":"scenario over availability zones as **failure domains** within an OpenStack"},{"line_number":24,"context_line":"cloud. However, it does not allow more than one subnet per AZ. Second the spec"},{"line_number":25,"context_line":"for this feature, it avoids the indeterminate behavior,  Manila would have no"},{"line_number":26,"context_line":"way of picking the right subnet of the choices it would have [2]."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The previous problem makes sense when it is dealing with different networks,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da23e776_ce6d5d34","line":25,"range":{"start_line":25,"start_character":55,"end_line":25,"end_character":57},"updated":"2021-12-15 15:59:16.000000000","message":"typo - remove 1 space","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The previous problem makes sense when it is dealing with different networks,"},{"line_number":29,"context_line":"for the same network segment with several subnets the indeterminate behavior"},{"line_number":30,"context_line":"does not exist, though. The Manila can request the port from any subnet in the"},{"line_number":31,"context_line":"AZ, the first that has available IP will be used. Therefore, this spec proposes"},{"line_number":32,"context_line":"adding the support for multiple subnets per AZ from a same network, requesting"},{"line_number":33,"context_line":"only one IP from any of available subnet."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7dee88c3_96dce310","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":28},"updated":"2021-12-15 15:59:16.000000000","message":"I\u0027d remove the \"The\"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":28,"context_line":"The previous problem makes sense when it is dealing with different networks,"},{"line_number":29,"context_line":"for the same network segment with several subnets the indeterminate behavior"},{"line_number":30,"context_line":"does not exist, though. The Manila can request the port from any subnet in the"},{"line_number":31,"context_line":"AZ, the first that has available IP will be used. Therefore, this spec proposes"},{"line_number":32,"context_line":"adding the support for multiple subnets per AZ from a same network, requesting"},{"line_number":33,"context_line":"only one IP from any of available subnet."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"c56a36aa_cc7dbc7b","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":35},"updated":"2021-12-15 15:59:16.000000000","message":"suggestion: \"the first one that has an available IP...\"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In some OpenStack deployments, the user may want to add different subnets"},{"line_number":40,"context_line":"in the same network segment. Currently, this is not possible to be applied"},{"line_number":41,"context_line":"in the Manila service, because the Manila requires from the user a specific"},{"line_number":42,"context_line":"subnet. Likewise, the Nova requests a port from a network, leaving to the"},{"line_number":43,"context_line":"Neutron service the selection of one of available subnets, the Manila could"},{"line_number":44,"context_line":"have support to setup share networks with several subnets from same network"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2c4c720c_79f6c407","line":41,"range":{"start_line":41,"start_character":31,"end_line":41,"end_character":34},"updated":"2021-12-15 15:59:16.000000000","message":"I\u0027d remove the \"the\"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":39,"context_line":"In some OpenStack deployments, the user may want to add different subnets"},{"line_number":40,"context_line":"in the same network segment. Currently, this is not possible to be applied"},{"line_number":41,"context_line":"in the Manila service, because the Manila requires from the user a specific"},{"line_number":42,"context_line":"subnet. Likewise, the Nova requests a port from a network, leaving to the"},{"line_number":43,"context_line":"Neutron service the selection of one of available subnets, the Manila could"},{"line_number":44,"context_line":"have support to setup share networks with several subnets from same network"},{"line_number":45,"context_line":"in the same AZ."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d67ef32a_4f329dcc","line":45,"range":{"start_line":42,"start_character":8,"end_line":45,"end_character":15},"updated":"2021-12-15 15:59:16.000000000","message":"This sentence is not clear to me. Did you mean something like \"The same way Nova leaves the selection of available subnets to the Neturon service, Manila could ...\" ? \n\nI think it you could rewrite the sentence to make it clear.","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Things that will not change:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- Share network API keeps the same, it already enables user to add more than"},{"line_number":82,"context_line":"  one subnet per share network."},{"line_number":83,"context_line":"- A share would still only be associated with one share network."},{"line_number":84,"context_line":"- A share server would still be allocated IPs from a single subnet\u0027s"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6f526fef_f85201e5","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":26},"updated":"2021-12-15 15:59:16.000000000","message":"remains ?","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":81,"context_line":"- Share network API keeps the same, it already enables user to add more than"},{"line_number":82,"context_line":"  one subnet per share network."},{"line_number":83,"context_line":"- A share would still only be associated with one share network."},{"line_number":84,"context_line":"- A share server would still be allocated IPs from a single subnet\u0027s"},{"line_number":85,"context_line":"  allocation pool."},{"line_number":86,"context_line":"- A security service would continue to be associated with the share"},{"line_number":87,"context_line":"  network. When share servers are created on new subnets, they will derive"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8c4af7e8_6b652ee4","line":84,"range":{"start_line":84,"start_character":17,"end_line":84,"end_character":45},"updated":"2021-12-15 15:59:16.000000000","message":"suggestion: \"would still allocate IPs...\"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":85,"context_line":"  allocation pool."},{"line_number":86,"context_line":"- A security service would continue to be associated with the share"},{"line_number":87,"context_line":"  network. When share servers are created on new subnets, they will derive"},{"line_number":88,"context_line":"  all the security server information from the share network."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Work-flows affected"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3565bd10_1b3d27a7","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":25},"updated":"2021-12-15 15:59:16.000000000","message":"did you mean \"service\"?","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Share servers will still be created by manila-share service with network"},{"line_number":103,"context_line":"allocations from a single subnet. However, it will not fail if the requested"},{"line_number":104,"context_line":"port from Neutron fails by exhausting available IPs, instead of it, the Manila"},{"line_number":105,"context_line":"will try another configured subnet in the same network and AZ. It only fails"},{"line_number":106,"context_line":"in case all subnets are exhausted."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f86d4a67_862d4902","line":104,"range":{"start_line":104,"start_character":67,"end_line":104,"end_character":72},"updated":"2021-12-15 15:59:16.000000000","message":"I\u0027d remove the \"the\"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":102,"context_line":"Share servers will still be created by manila-share service with network"},{"line_number":103,"context_line":"allocations from a single subnet. However, it will not fail if the requested"},{"line_number":104,"context_line":"port from Neutron fails by exhausting available IPs, instead of it, the Manila"},{"line_number":105,"context_line":"will try another configured subnet in the same network and AZ. It only fails"},{"line_number":106,"context_line":"in case all subnets are exhausted."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"**Creating a share**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"316ebffa_def3a206","line":105,"range":{"start_line":105,"start_character":63,"end_line":105,"end_character":76},"updated":"2021-12-15 15:59:16.000000000","message":"suggestion: \"It will only fail...\"","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":120,"context_line":"Alternatives"},{"line_number":121,"context_line":"------------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Keeping the same design of Manila makes the users, who is running out of IPs"},{"line_number":124,"context_line":"in the share network, create a new share network with the new Neutron subnet."},{"line_number":125,"context_line":"Quotas are currently enforced on the number of share networks. If a user"},{"line_number":126,"context_line":"needs to deal with lacking of IPs per AZ as multiple share networks, quota"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e831f291_8d086dc3","line":123,"range":{"start_line":123,"start_character":44,"end_line":123,"end_character":49},"updated":"2021-12-15 15:59:16.000000000","message":"\"user\" (singular) ?","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0c28146033dd4d389511472d2ea2435b33c6d5bc","unresolved":true,"context_lines":[{"line_number":325,"context_line":"Performance impact"},{"line_number":326,"context_line":"------------------"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Validating that users provide the correct network and availability zone will"},{"line_number":329,"context_line":"be performed at the API layer. However, the validation of the availability zone"},{"line_number":330,"context_line":"with respect to their configured networks will be done at the network plugin"},{"line_number":331,"context_line":"layer, as existing network checks are done today. This check might cause"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a2eb2c29_b1e2c0db","line":328,"range":{"start_line":328,"start_character":0,"end_line":328,"end_character":11},"updated":"2021-12-15 15:59:16.000000000","message":"Did you mean \"The validation\" ?","commit_id":"2ffec1c245ef6abfec3cff055afcfa850b1324ba"}]}