)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bef3cfc3_e070ac03","updated":"2021-12-30 05:45:05.000000000","message":"Thank you Kiran! I added some comments, mostly trying to understand better the proposal.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"168ada21a16af89ffd6d7228cb279abc73ee2ea9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f0bd1b9f_68337ee2","updated":"2022-01-17 10:06:25.000000000","message":"As per initial approach there will be four metadata items for each share\n1. auto-snapshot-create-interval\n2. auto-snapshot-delete-interval\n3. last-auto-snapshot-create-time\n4. last-auto-snapshot-delete-time\n\nWe will make it less granular e.g periodic task for snapshot creation will invoke every hour and periodic task for snapshot deletion will invoke every 6 hours.\n\n1. During snapshot creation periodic task\n  a. get share metadata and check for value 1 and 3\n  b. if current_time- last-auto-snapshot-create-time \u003e\u003d auto-snapshot-create-interval\n     create new snapshot and update last-auto-snapshot-create-time\n  c. do a and b for all shares in system, if metadata does not exist move to next share.\n\n2. During snapshot creation periodic task\n  a. get share metadata and check for value 2 and 4\n  b. if current_time- last-auto-snapshot-delete-time \u003e\u003d auto-snapshot-delete-interval\n     delete all snapshot with auto_share_xxxx name and update last-auto-snapshot-delete-time \n\nUser specified time for create should be multiple of hour (if not adjusted by manila to nearest possible) and delete should be multiple of 6 hours (if not adjusted by manila to nearest possible).\n\nIn addition, we can have separate service for all periodic tasks in Manila. This will give more control to start individual threads in case more periodic tasks generated. It can be separate blueprint as well.\n\n@Goutham\nWDYT ?","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"164262da346b378c87c5b6bd16a1a0c1c93795f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c56776d9_aae80832","updated":"2022-01-10 02:27:09.000000000","message":"Thks Kiran. Let wait for other reviewers.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93364b7d_d610ecf9","updated":"2022-01-18 07:28:15.000000000","message":"thanks for your change, Kiran.\nHere are some of my comments. ","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"37f995737a75e065251dce7c51fcd116cc3dbfd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1c9d37ca_e4a33985","updated":"2022-01-26 20:04:35.000000000","message":"Hi, the spec submission deadline for features to land in the yoga cycle has passed. As we discussed at the last IRC meeting, we\u0027re happy to consider this spec for the \u0027Z\u0027 cycle. Would you be able to re-target this? You\u0027ll need to create a \"zorilla\" directory to house this spec. I\u0027ll adjust the blueprint once we create the release milestones on Launchpad. \n\nFor the spec to show up correctly in the docs here, we\u0027d need to add a reference for the directory to the index page like: https://raw.githubusercontent.com/openstack/manila-specs/master/doc/source/index.rst","commit_id":"0ea64cc0d05835b74a3bf3addf646f71f6c4f258"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4d96f0b581a067dd8ac924ba215c6fa0cc70bfd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b3b39deb_80be79fa","updated":"2022-01-26 20:05:55.000000000","message":"procedural -1. \n\nYoga schedule: https://releases.openstack.org/yoga/schedule.html\nIRC meeting logs: https://meetings.opendev.org/meetings/manila/2022/manila.2022-01-20-15.03.log.html#l-67","commit_id":"0ea64cc0d05835b74a3bf3addf646f71f6c4f258"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f79663261dfb1b7b76dedc76194134097210b7f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1056e9de_3aa72778","in_reply_to":"1c9d37ca_e4a33985","updated":"2022-01-29 10:57:16.000000000","message":"Fixed","commit_id":"0ea64cc0d05835b74a3bf3addf646f71f6c4f258"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1d06ff0c_c83d749e","updated":"2022-03-11 19:09:43.000000000","message":"Thank you for the spec; i\u0027ve added some comments and questions inline","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"32ccdb10f1691b02d61144f8e80102a049c414a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ff1ebb14_fa22bb61","updated":"2022-04-30 13:35:10.000000000","message":"Hi Goutham,\nAfter PTG call, I tried to look if something similar exist in other cloud solutions e.g.\n\n1. Azure has recommendation of auto-backup of shares (https://docs.microsoft.com/en-us/azure/storage/files/storage-snapshots-files)\n2. AWS EFS has auto backups (https://docs.aws.amazon.com/efs/latest/ug/awsbackup.html#automatic-backups)\n\nSo we can either have separate service doing auto snapshots for Manila (and can be extended to Cinder) or can have it as part of Manila (current PR). The second approach gives single unified solution instead each user doing this manually e.g. (for cinder I can find this https://github.com/StackOps/cinder-scheduled-snapshots). WDYT ?","commit_id":"58f9a035e10524ddeb2d83051309df5754d9a0e1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6805ab27fe91129ce367989ed4da25aa483f1f7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d6885870_a563ffc3","in_reply_to":"ff1ebb14_fa22bb61","updated":"2022-05-02 18:35:16.000000000","message":"Thanks for getting back to me on this Kiran. \nI agree this feature exists on other cloud platforms, and its extremely useful. \n\nHowever, given the limitations we highlighted during he PTG (such as the uncertainty of the periodic threads in the manager service), i think the latter approach, i.e., building outside manila/cinder as a third party script/service makes a lot of sense...","commit_id":"58f9a035e10524ddeb2d83051309df5754d9a0e1"}],"specs/yoga/automatic-snapshots.rst":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Add two new options to share create as well as share update command i.e."},{"line_number":40,"context_line":"--automatic-snapshot-policy and --automatic-snapshot-deletion-policy."},{"line_number":41,"context_line":"--automatic-snapshot-deletion-policy is valid only of"},{"line_number":42,"context_line":"--automatic-snapshot-policy is set."}],"source_content_type":"text/x-rst","patch_set":2,"id":"36f7903a_4f0f2966","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":35},"updated":"2021-12-30 05:45:05.000000000","message":"is this the best solution for that end ?!\n\nIf the idea is to provide high availability and recovery, it seems that the admin has a small set of policies that would be used for a lot of created shares, reusing several time the raw cron text. Example, suppose I want to provide that feature by taking snapshot once a day. This configuration should be replicated to all shares taken in this env. Not only one by one. Thus, having to add always the option \"0 * * * *\" when creating the share may be error prone.\n\nIt would be better to have a separated object where you define the snapshot policy. Then, you pass it to create of the share. Actually, we could bind this policy to the entire share type, as an extra-specs. Or having a way to define the policy and reuse during share create/update.\n\nWDYT ?","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":true,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Add two new options to share create as well as share update command i.e."},{"line_number":40,"context_line":"--automatic-snapshot-policy and --automatic-snapshot-deletion-policy."},{"line_number":41,"context_line":"--automatic-snapshot-deletion-policy is valid only of"},{"line_number":42,"context_line":"--automatic-snapshot-policy is set."}],"source_content_type":"text/x-rst","patch_set":2,"id":"55e0da70_2ec19cb2","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":35},"in_reply_to":"36f7903a_4f0f2966","updated":"2022-01-04 11:27:30.000000000","message":"We want the individual policy for each share e.g. some scheduled to take snapshot every hour, some every day or other etc. The idea of having separate entity i.e. snapshot policy would be burden since there will be many combinations of snapshot create+delete. This was something similar reviewers thought of having share type extra_specs during scheduler affinity and then replaced it by parameters to share create command.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"164262da346b378c87c5b6bd16a1a0c1c93795f0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Add two new options to share create as well as share update command i.e."},{"line_number":40,"context_line":"--automatic-snapshot-policy and --automatic-snapshot-deletion-policy."},{"line_number":41,"context_line":"--automatic-snapshot-deletion-policy is valid only of"},{"line_number":42,"context_line":"--automatic-snapshot-policy is set."}],"source_content_type":"text/x-rst","patch_set":2,"id":"04b82bd2_a6d929d5","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":35},"in_reply_to":"55e0da70_2ec19cb2","updated":"2022-01-10 02:27:09.000000000","message":"Ack","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":41,"context_line":"--automatic-snapshot-deletion-policy is valid only of"},{"line_number":42,"context_line":"--automatic-snapshot-policy is set."},{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."}],"source_content_type":"text/x-rst","patch_set":2,"id":"e2a5ab3a_7aefba08","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":38},"updated":"2021-12-30 05:45:05.000000000","message":"cron format does not seem very user friendly. Even some computer folks are used to this format, others may not be, requiring learning it and being very error prone. I\u0027d prefer be away from \"hack notation\".\n\nJust to see how confuse this notation is, there are several applications to translate it [1]. However, I cannot see another better approach :(\n\n[1] notation:https://crontab.guru/","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"--automatic-snapshot-deletion-policy is valid only of"},{"line_number":42,"context_line":"--automatic-snapshot-policy is set."},{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."}],"source_content_type":"text/x-rst","patch_set":2,"id":"906913d2_01415d10","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":38},"in_reply_to":"6aa8fc74_5a7338c6","updated":"2022-01-18 14:33:35.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"164262da346b378c87c5b6bd16a1a0c1c93795f0","unresolved":true,"context_lines":[{"line_number":41,"context_line":"--automatic-snapshot-deletion-policy is valid only of"},{"line_number":42,"context_line":"--automatic-snapshot-policy is set."},{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."}],"source_content_type":"text/x-rst","patch_set":2,"id":"c8df6672_3fd4d56f","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":38},"in_reply_to":"7b265aa5_5f95e4c2","updated":"2022-01-10 02:27:09.000000000","message":"we need more people\u0027s opnion on that.\n\nI have no strong opnion here. I liked more the minutes idea than cron one. It seems less hacking mode. Maybe having the unit would avoid the math:\n\nPer hour: --automatic-snapshot-deletion-policy 1h\nPer day:  --automatic-snapshot-deletion-policy  1d\nPer half hour: --automatic-snapshot-deletion-policy 30m","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":41,"context_line":"--automatic-snapshot-deletion-policy is valid only of"},{"line_number":42,"context_line":"--automatic-snapshot-policy is set."},{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."}],"source_content_type":"text/x-rst","patch_set":2,"id":"6aa8fc74_5a7338c6","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":38},"in_reply_to":"c8df6672_3fd4d56f","updated":"2022-01-18 07:28:15.000000000","message":"I agree with Felipe Rodrigues, end user is hard to understand cron format.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":true,"context_lines":[{"line_number":41,"context_line":"--automatic-snapshot-deletion-policy is valid only of"},{"line_number":42,"context_line":"--automatic-snapshot-policy is set."},{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7b265aa5_5f95e4c2","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":38},"in_reply_to":"e2a5ab3a_7aefba08","updated":"2022-01-04 11:27:30.000000000","message":"Assuming its difficult to parse and specify as well, I am fine with replacing it by minutes e.g. per day snapshot will have 24x60 (i.e.1440) minutes of periodic callback.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":50,"context_line":"created during share create. The provided input values for both policies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b512e639_083f138e","line":47,"range":{"start_line":46,"start_character":1,"end_line":47,"end_character":44},"updated":"2021-12-30 05:45:05.000000000","message":"it is a bit confuse, what do you mean by \"automatic snapshot deletion\" ?! How does the manila know what snapshots it should delete ?! should it delete only the snapshot created by automatic task, or all share\u0027s snapshot ?","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":50,"context_line":"created during share create. The provided input values for both policies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"23a22e79_4d4f95c8","line":47,"range":{"start_line":46,"start_character":1,"end_line":47,"end_character":44},"in_reply_to":"009795b3_1b40eeee","updated":"2022-01-18 07:28:15.000000000","message":"In another case, the user manually updates the snapshot name, will also lead to miss delete snapshot.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":50,"context_line":"created during share create. The provided input values for both policies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bbb3927c_a39c4ce5","line":47,"range":{"start_line":46,"start_character":1,"end_line":47,"end_character":44},"in_reply_to":"23a22e79_4d4f95c8","updated":"2022-01-18 14:33:35.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"164262da346b378c87c5b6bd16a1a0c1c93795f0","unresolved":true,"context_lines":[{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":50,"context_line":"created during share create. The provided input values for both policies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"009795b3_1b40eeee","line":47,"range":{"start_line":46,"start_character":1,"end_line":47,"end_character":44},"in_reply_to":"3794cf03_85e6dc46","updated":"2022-01-10 02:27:09.000000000","message":"Using the name to locate the automatic snapshots is not the best idea. It might end up retrieving a non automatic snapshot, since the name is a user field, so the user could name the snapshot with the auto_share-id_XXX pattern. \n\nThe correct solution here would be changing the db. Adding a boolean column \"is_automatic\", that would be \"True\" for manila created snapshots, otherwise \"False\". To upgrade db, all snapshots will be \"False\". \n\nWith the db change, it is pretty easy to retrieve the automatic snapshots. Also, the user can easily indentify which snapshots are automatic or not, just looking in this new field.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":true,"context_lines":[{"line_number":43,"context_line":"e.g."},{"line_number":44,"context_line":"`--automatic-snapshot-policy 0 * * * *` will specify that snapshots should"},{"line_number":45,"context_line":"be created for every hour at the beginning of the hour."},{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":50,"context_line":"created during share create. The provided input values for both policies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3794cf03_85e6dc46","line":47,"range":{"start_line":46,"start_character":1,"end_line":47,"end_character":44},"in_reply_to":"b512e639_083f138e","updated":"2022-01-04 11:27:30.000000000","message":"Ideally automatic snapshot deletion considers only automatic created snapshots. So we can name automatic snapshots as auto_share-id_{timestamp}. During share snapshot deletion callback, retrieve all snapshots of share and those named with auto_share-id_XXX will be deleted.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":53,"context_line":"In addition, if snapshot policies are not given during share creation, user"},{"line_number":54,"context_line":"have an option to create them during share update command. However, if"},{"line_number":55,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":56,"context_line":"be updated to new policies specificed in share update command. This means,"},{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"8efa9af8_8d1b7d50","line":56,"range":{"start_line":56,"start_character":1,"end_line":56,"end_character":38},"updated":"2021-12-30 05:45:05.000000000","message":"is the user able to unset those policies ?! Please, let it clear and why.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":true,"context_lines":[{"line_number":53,"context_line":"In addition, if snapshot policies are not given during share creation, user"},{"line_number":54,"context_line":"have an option to create them during share update command. However, if"},{"line_number":55,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":56,"context_line":"be updated to new policies specificed in share update command. This means,"},{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b6100064_697792bf","line":56,"range":{"start_line":56,"start_character":1,"end_line":56,"end_character":38},"in_reply_to":"8efa9af8_8d1b7d50","updated":"2022-01-04 11:27:30.000000000","message":"The policy unset should be possible. In share update command, user should specify automatic-snapshot-policy and automatic-snapshot-policy to 0 to unset it. If value is non-zero we should remove existing policies (and metadata and periodic tasks) and then create new policies.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"164262da346b378c87c5b6bd16a1a0c1c93795f0","unresolved":true,"context_lines":[{"line_number":53,"context_line":"In addition, if snapshot policies are not given during share creation, user"},{"line_number":54,"context_line":"have an option to create them during share update command. However, if"},{"line_number":55,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":56,"context_line":"be updated to new policies specificed in share update command. This means,"},{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dcbc989f_66d3520d","line":56,"range":{"start_line":56,"start_character":1,"end_line":56,"end_character":38},"in_reply_to":"b6100064_697792bf","updated":"2022-01-10 02:27:09.000000000","message":"nice, please, add this flow of unsetting by setting with \"0\".","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"In addition, if snapshot policies are not given during share creation, user"},{"line_number":54,"context_line":"have an option to create them during share update command. However, if"},{"line_number":55,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":56,"context_line":"be updated to new policies specificed in share update command. This means,"},{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"53c5f43b_aef41f29","line":56,"range":{"start_line":56,"start_character":1,"end_line":56,"end_character":38},"in_reply_to":"dcbc989f_66d3520d","updated":"2022-01-18 14:33:35.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":61,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":62,"context_line":"manually delete all snapshots and then delete share."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":65,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":66,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":67,"context_line":"and thus will be applicable for all shares."}],"source_content_type":"text/x-rst","patch_set":2,"id":"eed6b991_d2ec4fe4","line":64,"range":{"start_line":64,"start_character":21,"end_line":64,"end_character":60},"updated":"2021-12-30 05:45:05.000000000","message":"How would you control it ? Actually, taking snapshots with replication, the snapshots are passed to the replicas too. Do you plan to change this behavior ? For example, the NetApp driver uses the snapmirror policy that copies the taken snapshot to the non-active replicas by default. \n\nSee: https://docs.openstack.org/manila/latest/admin/shared-file-systems-share-replication.html#snapshots","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":true,"context_lines":[{"line_number":61,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":62,"context_line":"manually delete all snapshots and then delete share."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":65,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":66,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":67,"context_line":"and thus will be applicable for all shares."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ee8145e4_628ce036","line":64,"range":{"start_line":64,"start_character":21,"end_line":64,"end_character":60},"in_reply_to":"0feac5e3_00b6637d","updated":"2022-01-18 14:33:35.000000000","message":"We should not change the behaviour, if its default. May be we can set default to True.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"164262da346b378c87c5b6bd16a1a0c1c93795f0","unresolved":true,"context_lines":[{"line_number":61,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":62,"context_line":"manually delete all snapshots and then delete share."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":65,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":66,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":67,"context_line":"and thus will be applicable for all shares."}],"source_content_type":"text/x-rst","patch_set":2,"id":"0feac5e3_00b6637d","line":64,"range":{"start_line":64,"start_character":21,"end_line":64,"end_character":60},"in_reply_to":"4d2eec0f_937025fa","updated":"2022-01-10 02:27:09.000000000","message":"Yeah, but if you look how NetApp driver implements the method \"create_replicated_snapshot\", it\u0027s only checking if the replicated snapshot is already there. The replicas default behavior is to have same data (including snapshots) from the active one. Why do you want to change this behaviour and how in the drivers like netapp ?","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b6aef4f169f6561dca3d1b9f2faff8e81445ed","unresolved":false,"context_lines":[{"line_number":61,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":62,"context_line":"manually delete all snapshots and then delete share."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":65,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":66,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":67,"context_line":"and thus will be applicable for all shares."}],"source_content_type":"text/x-rst","patch_set":2,"id":"e37547d7_dca029ad","line":64,"range":{"start_line":64,"start_character":21,"end_line":64,"end_character":60},"in_reply_to":"ee8145e4_628ce036","updated":"2022-01-29 10:58:39.000000000","message":"Ack","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":true,"context_lines":[{"line_number":61,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":62,"context_line":"manually delete all snapshots and then delete share."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":65,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":66,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":67,"context_line":"and thus will be applicable for all shares."}],"source_content_type":"text/x-rst","patch_set":2,"id":"4d2eec0f_937025fa","line":64,"range":{"start_line":64,"start_character":21,"end_line":64,"end_character":60},"in_reply_to":"eed6b991_d2ec4fe4","updated":"2022-01-04 11:27:30.000000000","message":"If such case exist its indeed not controllable. I was considering https://github.com/openstack/manila/blob/5b04b9b1b68673873bb98c81b421f4f288f26276/manila/share/api.py#L1376\n\nwhere snapshot create function would not consider automatic snapshots for replica unless specified in config file","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policiess will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ca779e9b_405767d3","line":77,"range":{"start_line":77,"start_character":48,"end_line":77,"end_character":63},"updated":"2021-12-30 05:45:05.000000000","message":"I have some concers about it.\n\nFirst, is this automatic task fields real metadata ? It seems more like a useful configuration of the share, than a value that explains the data. Normally, metadata is not used by system, is used by the user.\n\nSecondly and more important, it\u0027s creating a new API fields that map another existent API. The \"metadata\" db is set/unset by \"metadata\" API. What it\u0027s proposing is to use that db field to cover two rest API, which sounds a bit confuse.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policiess will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f5f5a63_2c173375","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":19},"updated":"2021-12-30 05:45:05.000000000","message":"policies","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b97e21032748375cd1cb8a4de84ae5c5053e6dd8","unresolved":true,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policiess will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fcba7947_7cf8ca7d","line":77,"range":{"start_line":77,"start_character":48,"end_line":77,"end_character":63},"in_reply_to":"1752e173_6ce4ca5e","updated":"2022-01-13 18:16:25.000000000","message":"thank you Dimitry.\n\nI read the entire discussion now (a bit long one). It seems that it\u0027s been the selected designed.\n\nTherefore, keep the snap policy as metadata is fine","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policiess will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bcb7ca13_ab7c22d0","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":19},"in_reply_to":"3f5f5a63_2c173375","updated":"2022-01-04 11:27:30.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"164262da346b378c87c5b6bd16a1a0c1c93795f0","unresolved":true,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policiess will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c344634a_64ab831d","line":77,"range":{"start_line":77,"start_character":48,"end_line":77,"end_character":63},"in_reply_to":"c0f1f8c5_ceade8fc","updated":"2022-01-10 02:27:09.000000000","message":"I see. Particularly, the problem here is not about admin access, it\u0027s a design issue. Usability and code maintenance. I did not review the affinity implementation, if I did, I\u0027d warn about that design.\n\nExplaining better, since, metadata and this new field would be mapped to same db dict, they may conflict. Example, suppose the key of policy will be called \"snap-policy\":\n\nmanila create --automatic-snapshot-deletion-policy  10  --metadata snap-policy\u003d20\n\nIn the same direction, the REST update for metadata values could end up deleting/modifying the policies, which is not the desired flow. \n\nBesides that, there is a conceptual issue, in my view, that\u0027s not the purpose for metadata field. Metadata \u003d info about data. I can\u0027t see the \"snapshot policy\" as data information.\n\nIf we approve that, it means that all new share configs could be added as metadata just because metadata is a dict.\n\nFinally, we need more opnions here to reach an agreement :)","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"3949b26be256ef9d2169e6c1dc7db22ac68269ff","unresolved":true,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policiess will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1752e173_6ce4ca5e","line":77,"range":{"start_line":77,"start_character":48,"end_line":77,"end_character":63},"in_reply_to":"c344634a_64ab831d","updated":"2022-01-13 16:23:58.000000000","message":"Just my 2 cents here.\n\nIn the Affinity/Anti-affinity spec, after going back and forth, the final decision was in favor for Metadata to be used for storage: https://review.opendev.org/c/openstack/manila-specs/+/775198/11/specs/xena/affinity-antiaffinity-filter.rst#61\n\nAnd there is an Admin metadata spec as well: https://review.opendev.org/c/openstack/manila-specs/+/814678","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":true,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policiess will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c0f1f8c5_ceade8fc","line":77,"range":{"start_line":77,"start_character":48,"end_line":77,"end_character":63},"in_reply_to":"ca779e9b_405767d3","updated":"2022-01-04 11:27:30.000000000","message":"The metadata in this case would be admin-only something similar to share affinity metadata. So manila wont allow to modify it by users.","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b6aef4f169f6561dca3d1b9f2faff8e81445ed","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policiess will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"93c32d81_3f151b44","line":77,"range":{"start_line":77,"start_character":48,"end_line":77,"end_character":63},"in_reply_to":"fcba7947_7cf8ca7d","updated":"2022-01-29 10:58:39.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":83,"context_line":"added to share create and share update, for example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  `{"},{"line_number":86,"context_line":"      \"share\": {"},{"line_number":87,"context_line":"          \"automatic-snapshot-policy\": \"cron_format_1\""},{"line_number":88,"context_line":"          \"automatic-snapshot-deletion-policy\": \"crom_format_2\""},{"line_number":89,"context_line":"      }"},{"line_number":90,"context_line":"  }`"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"In this particular example, the share snapshots should be taken as per time"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a4d32c06_c349d867","line":89,"range":{"start_line":86,"start_character":6,"end_line":89,"end_character":7},"updated":"2021-12-30 05:45:05.000000000","message":"Please, add the entire REST API body and the REST endpoint","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":false,"context_lines":[{"line_number":83,"context_line":"added to share create and share update, for example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  `{"},{"line_number":86,"context_line":"      \"share\": {"},{"line_number":87,"context_line":"          \"automatic-snapshot-policy\": \"cron_format_1\""},{"line_number":88,"context_line":"          \"automatic-snapshot-deletion-policy\": \"crom_format_2\""},{"line_number":89,"context_line":"      }"},{"line_number":90,"context_line":"  }`"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"In this particular example, the share snapshots should be taken as per time"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0945efcf_704090ba","line":89,"range":{"start_line":86,"start_character":6,"end_line":89,"end_character":7},"in_reply_to":"a4d32c06_c349d867","updated":"2022-01-04 11:27:30.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":94,"context_line":"periodic time interval defined in cron_format_2."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"All given cron_formats will be validated against valid values and share"},{"line_number":97,"context_line":"creation will fail if at least one of the value is malformed."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The semantics for \"automatic-snapshot-deletion-policy\" is must defined"},{"line_number":100,"context_line":"\"automatic-snapshot-policy\", meaning that the share won\u0027t get created, if"}],"source_content_type":"text/x-rst","patch_set":2,"id":"69ae17bb_cd67c9a5","line":97,"range":{"start_line":97,"start_character":14,"end_line":97,"end_character":61},"updated":"2021-12-30 05:45:05.000000000","message":"which HTTP code ?","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"periodic time interval defined in cron_format_2."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"All given cron_formats will be validated against valid values and share"},{"line_number":97,"context_line":"creation will fail if at least one of the value is malformed."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The semantics for \"automatic-snapshot-deletion-policy\" is must defined"},{"line_number":100,"context_line":"\"automatic-snapshot-policy\", meaning that the share won\u0027t get created, if"}],"source_content_type":"text/x-rst","patch_set":2,"id":"04c2d61d_992aa6ac","line":97,"range":{"start_line":97,"start_character":14,"end_line":97,"end_character":61},"in_reply_to":"69ae17bb_cd67c9a5","updated":"2022-01-04 11:27:30.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":122,"context_line":"Performance Impact"},{"line_number":123,"context_line":"------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"This feature would query DB once per execution of periodic task, it only adds"},{"line_number":126,"context_line":"slightly latency to the system and the latency has nothing to do with the size"},{"line_number":127,"context_line":"of the system."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9d354d74_2f2e3639","line":125,"range":{"start_line":125,"start_character":24,"end_line":125,"end_character":64},"updated":"2021-12-30 05:45:05.000000000","message":"since the periodic taks grow with number of shares and can be set every minute (* * * * *), may it slow down the system abruptly ?","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Performance Impact"},{"line_number":123,"context_line":"------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"This feature would query DB once per execution of periodic task, it only adds"},{"line_number":126,"context_line":"slightly latency to the system and the latency has nothing to do with the size"},{"line_number":127,"context_line":"of the system."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"cede6ab3_ac3caf38","line":125,"range":{"start_line":125,"start_character":24,"end_line":125,"end_character":64},"in_reply_to":"9d354d74_2f2e3639","updated":"2022-01-04 11:27:30.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"31fc27a9a182a934d148fa0e3d3b50fbd5c62daf","unresolved":true,"context_lines":[{"line_number":175,"context_line":"   deletion of 35 seconds;"},{"line_number":176,"context_line":" * After 20 seconds, checks if share snapshot is taken;"},{"line_number":177,"context_line":" * After 40 seconds, checks if all snapshots are deleted;"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Documentation Impact"},{"line_number":180,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"98d74469_b93861e8","line":178,"updated":"2021-12-30 05:45:05.000000000","message":"will tempest tests be added ?","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d9b4450bd308c50915265fccd658335595d50fcb","unresolved":false,"context_lines":[{"line_number":175,"context_line":"   deletion of 35 seconds;"},{"line_number":176,"context_line":" * After 20 seconds, checks if share snapshot is taken;"},{"line_number":177,"context_line":" * After 40 seconds, checks if all snapshots are deleted;"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Documentation Impact"},{"line_number":180,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"09625064_56d960cc","line":178,"in_reply_to":"98d74469_b93861e8","updated":"2022-01-04 11:27:30.000000000","message":"Done","commit_id":"6366819235686c776b2ca4463e7004c2c582f764"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":50,"context_line":"created during share create. The provided input values for both policies"},{"line_number":51,"context_line":"will also be stored in share admin-only metadata."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"72b3b9d2_8c074c1b","line":49,"range":{"start_line":49,"start_character":55,"end_line":49,"end_character":69},"updated":"2022-01-18 07:28:15.000000000","message":"How do periodic tasks distinguish between manually created snapshots and automatically created snapshots? Will manually created snapshots be deleted by mistake when snapshots are automatically deleted?","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"`--automatic-snapshot-deletion-policy 0 0 * * *` will specify that snapshots"},{"line_number":47,"context_line":"should be deleted for once a day at midnight."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":50,"context_line":"created during share create. The provided input values for both policies"},{"line_number":51,"context_line":"will also be stored in share admin-only metadata."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"114bdef5_9a301c3b","line":49,"range":{"start_line":49,"start_character":55,"end_line":49,"end_character":69},"in_reply_to":"72b3b9d2_8c074c1b","updated":"2022-01-18 14:33:35.000000000","message":"Done","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":54,"context_line":"have an option to create them during share update command. However, if"},{"line_number":55,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":56,"context_line":"be updated to new policies specificed in share update command. This means,"},{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0ad932fe_bfdd9227","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":38},"updated":"2022-01-18 07:28:15.000000000","message":"(1)Is this existing periodic a separate process from Manila Share?\n(2)How do you implement this periodic task?\n   I know the current implementation is using:\n   from oslo_service import periodic_task\n   @periodic_task.periodic_task(spacing\u003dinterval)","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":true,"context_lines":[{"line_number":54,"context_line":"have an option to create them during share update command. However, if"},{"line_number":55,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":56,"context_line":"be updated to new policies specificed in share update command. This means,"},{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"}],"source_content_type":"text/x-rst","patch_set":3,"id":"44b2f903_3ce00bb5","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":38},"in_reply_to":"0ad932fe_bfdd9227","updated":"2022-01-18 14:33:35.000000000","message":"My plan is to use current implementation but we can have separate process as well for better control where we can have various instances running various periodic tasks. But that would be different blueprint I would say.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b6aef4f169f6561dca3d1b9f2faff8e81445ed","unresolved":false,"context_lines":[{"line_number":54,"context_line":"have an option to create them during share update command. However, if"},{"line_number":55,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":56,"context_line":"be updated to new policies specificed in share update command. This means,"},{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"}],"source_content_type":"text/x-rst","patch_set":3,"id":"286a64e6_6ffb53c8","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":38},"in_reply_to":"44b2f903_3ce00bb5","updated":"2022-01-29 10:58:39.000000000","message":"Ack","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"},{"line_number":61,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":62,"context_line":"manually delete all snapshots and then delete share."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bd7479ea_0f7dd91e","line":60,"range":{"start_line":60,"start_character":7,"end_line":60,"end_character":19},"updated":"2022-01-18 07:28:15.000000000","message":"(1)what about share unmange?\n(2)Do periodic tasks need to be killed before the share is deleted? how to kill it?","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b6aef4f169f6561dca3d1b9f2faff8e81445ed","unresolved":false,"context_lines":[{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"},{"line_number":61,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":62,"context_line":"manually delete all snapshots and then delete share."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8cd419f4_86852f9d","line":60,"range":{"start_line":60,"start_character":7,"end_line":60,"end_character":19},"in_reply_to":"b174f13f_744bfde2","updated":"2022-01-29 10:58:39.000000000","message":"Ack","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":true,"context_lines":[{"line_number":57,"context_line":"existing periodic tasks will be killed and new periodic tasks will be created."},{"line_number":58,"context_line":"The existing metadata will also be updated."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"},{"line_number":61,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":62,"context_line":"manually delete all snapshots and then delete share."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"b174f13f_744bfde2","line":60,"range":{"start_line":60,"start_character":7,"end_line":60,"end_character":19},"in_reply_to":"bd7479ea_0f7dd91e","updated":"2022-01-18 14:33:35.000000000","message":"1. added\n2. its tasks created during service start.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"de0f24a7_835860cc","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":4},"updated":"2022-01-18 07:28:15.000000000","message":"You can use a third-party periodic task management tool to periodically invoke the interface for creating or deleting snapshots.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b6aef4f169f6561dca3d1b9f2faff8e81445ed","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0041ef6e_227ad503","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":4},"in_reply_to":"716a970c_2888b7a3","updated":"2022-01-29 10:58:39.000000000","message":"Ack","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":true,"context_lines":[{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"716a970c_2888b7a3","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":4},"in_reply_to":"de0f24a7_835860cc","updated":"2022-01-18 14:33:35.000000000","message":"But this will make each cloud provider to manually create snapshots, keep track and then delete  .","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policies will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d0db7250_1dab6b56","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":6},"updated":"2022-01-18 07:28:15.000000000","message":"remove it.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Data model impact"},{"line_number":75,"context_line":"-----------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None. The policies will be saved as additional share metadata."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"REST API impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9835aa7a_5e6e3ea9","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":6},"in_reply_to":"d0db7250_1dab6b56","updated":"2022-01-18 14:33:35.000000000","message":"Done","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":116,"context_line":"      }"},{"line_number":117,"context_line":"  }`"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"If the operation can\u0027t be performed due to \"automatic-snapshot-deletion-policy\""},{"line_number":120,"context_line":"is specified but \"automatic-snapshot-policy\" is not specified, the API will"},{"line_number":121,"context_line":"respond with ``400 Bad Request``."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":124,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"}],"source_content_type":"text/x-rst","patch_set":3,"id":"be25be77_3577b3eb","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":33},"updated":"2022-01-18 07:28:15.000000000","message":"If the user sets \"automatic_snapshot_policy\": \"10\" first, then the user only set \"automatic_snapshot_deletion_policy\": \"30\" in the fllow another request, will get 400?\ni think we should check if the share have been set automatic_snapshot_policy, but not to check\nwhether automatic_snapshot_policy in request body.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9dcfcb8f015197408b165a14c208a8c27bf8a90f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"      }"},{"line_number":117,"context_line":"  }`"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"If the operation can\u0027t be performed due to \"automatic-snapshot-deletion-policy\""},{"line_number":120,"context_line":"is specified but \"automatic-snapshot-policy\" is not specified, the API will"},{"line_number":121,"context_line":"respond with ``400 Bad Request``."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":124,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ef177e03_0726c52b","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":33},"in_reply_to":"8301d26d_f4712a80","updated":"2022-01-29 10:58:53.000000000","message":"Done","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":true,"context_lines":[{"line_number":116,"context_line":"      }"},{"line_number":117,"context_line":"  }`"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"If the operation can\u0027t be performed due to \"automatic-snapshot-deletion-policy\""},{"line_number":120,"context_line":"is specified but \"automatic-snapshot-policy\" is not specified, the API will"},{"line_number":121,"context_line":"respond with ``400 Bad Request``."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":124,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8301d26d_f4712a80","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":33},"in_reply_to":"be25be77_3577b3eb","updated":"2022-01-18 14:33:35.000000000","message":"If user specify creation policy, we can assume deletion \u003d 12 X creation interval.\nBut if user specify only deletion during share __create__, we throw error.\nUser on the other hand can update either of policy using share update.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":121,"context_line":"respond with ``400 Bad Request``."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":124,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"},{"line_number":125,"context_line":"periodic time interval defined i.e. 30 minutes."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Microversion of the API is incremented."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dcdce36f_0900e9bc","line":125,"range":{"start_line":124,"start_character":33,"end_line":125,"end_character":47},"updated":"2022-01-18 07:28:15.000000000","message":"will this delete all the snapshots created by automatic_snapshot?\nfor example:\nat 10-minute mark, create an snapshot S1, \nat 20-minute mark, create an snapshot S2, \nat 30-minute mark, create an snapshot S3,\nat 30-minute mark, delete S1, S2, S3\nat 35-minute mark, user The user writes wrong data and wants to recover data from the snapshot,\n                   he found there is no snapshot to use.   :(","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"144589422f7eb4717abbb617e86b70756bcc205a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"respond with ``400 Bad Request``."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":124,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"},{"line_number":125,"context_line":"periodic time interval defined i.e. 30 minutes."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Microversion of the API is incremented."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5bdb78f3_40e3337b","line":125,"range":{"start_line":124,"start_character":33,"end_line":125,"end_character":47},"in_reply_to":"37eed356_91b7a59a","updated":"2022-02-07 09:07:09.000000000","message":"Although the first method is simple, I prefer the second method because even with the increased deletion interval, I still encounter a situation where the snapshot cannot be restored,","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"401a17d71f4c92fc9e38ece3aa076293f175495f","unresolved":true,"context_lines":[{"line_number":121,"context_line":"respond with ``400 Bad Request``."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":124,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"},{"line_number":125,"context_line":"periodic time interval defined i.e. 30 minutes."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Microversion of the API is incremented."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dea45332_cab45f50","line":125,"range":{"start_line":124,"start_character":33,"end_line":125,"end_character":47},"in_reply_to":"dcdce36f_0900e9bc","updated":"2022-01-18 14:33:35.000000000","message":"yes, currently plan is to delete all automatic snapshots so far. But we have two options\n1. increase delete interval\n2. partially delete automatic snapshots.\n\n1 would be easy for all.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b6aef4f169f6561dca3d1b9f2faff8e81445ed","unresolved":false,"context_lines":[{"line_number":121,"context_line":"respond with ``400 Bad Request``."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":124,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"},{"line_number":125,"context_line":"periodic time interval defined i.e. 30 minutes."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Microversion of the API is incremented."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"37eed356_91b7a59a","line":125,"range":{"start_line":124,"start_character":33,"end_line":125,"end_character":47},"in_reply_to":"dea45332_cab45f50","updated":"2022-01-29 10:58:39.000000000","message":"Done","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":181,"context_line":"2. Add snapshot policy parameters"},{"line_number":182,"context_line":"3. Add policy arguments for python-manilaclient"},{"line_number":183,"context_line":"4. Add policy support in manila-ui"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Dependencies"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"f38f5385_7646854b","line":184,"updated":"2022-01-18 07:28:15.000000000","message":"5: Update related documents.\n6: Update unit and tempest test.","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b6aef4f169f6561dca3d1b9f2faff8e81445ed","unresolved":false,"context_lines":[{"line_number":181,"context_line":"2. Add snapshot policy parameters"},{"line_number":182,"context_line":"3. Add policy arguments for python-manilaclient"},{"line_number":183,"context_line":"4. Add policy support in manila-ui"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Dependencies"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dbbd3aec_d236a0a4","line":184,"in_reply_to":"f38f5385_7646854b","updated":"2022-01-29 10:58:39.000000000","message":"Done","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e9cbc989ee6727a5aefc18ab06c530f7e45935fa","unresolved":true,"context_lines":[{"line_number":194,"context_line":"* Add the tempest test e.g. below"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Test against automatic-snapshot-policy:"},{"line_number":197,"context_line":" * Create share with periodic snapshot policy set to 15 seconds;"},{"line_number":198,"context_line":" * After 20 seconds, checks if snapshot is taken;"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Test against automatic-snapshot-deletion-policy:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"367e041e_137dbef3","line":197,"range":{"start_line":197,"start_character":53,"end_line":197,"end_character":63},"updated":"2022-01-18 07:28:15.000000000","message":"Isn\u0027t the default unit minutes? Or can users customize the units?","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b6aef4f169f6561dca3d1b9f2faff8e81445ed","unresolved":false,"context_lines":[{"line_number":194,"context_line":"* Add the tempest test e.g. below"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Test against automatic-snapshot-policy:"},{"line_number":197,"context_line":" * Create share with periodic snapshot policy set to 15 seconds;"},{"line_number":198,"context_line":" * After 20 seconds, checks if snapshot is taken;"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Test against automatic-snapshot-deletion-policy:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8779fda0_5e3cfefd","line":197,"range":{"start_line":197,"start_character":53,"end_line":197,"end_character":63},"in_reply_to":"367e041e_137dbef3","updated":"2022-01-29 10:58:39.000000000","message":"Done","commit_id":"d493fbad831c0db2cdcf0f29b24b4d5942ef0587"}],"specs/zorilla/automatic-snapshots.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Add two new options to share create as well as share update command i.e."},{"line_number":44,"context_line":"--auto-snapshot-create-policy and --auto-snapshot-delete-policy."},{"line_number":45,"context_line":"--auto-snapshot-delete-policy is valid only of"},{"line_number":46,"context_line":"--auto-snapshot-create-policy is set."},{"line_number":47,"context_line":"e.g."},{"line_number":48,"context_line":"`--auto-snapshot-create-policy 1h` will specify that snapshots should be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6b0706c9_2ffe1a4a","line":45,"range":{"start_line":45,"start_character":44,"end_line":45,"end_character":46},"updated":"2022-03-11 19:09:43.000000000","message":"if","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Add two new options to share create as well as share update command i.e."},{"line_number":44,"context_line":"--auto-snapshot-create-policy and --auto-snapshot-delete-policy."},{"line_number":45,"context_line":"--auto-snapshot-delete-policy is valid only of"},{"line_number":46,"context_line":"--auto-snapshot-create-policy is set."},{"line_number":47,"context_line":"e.g."},{"line_number":48,"context_line":"`--auto-snapshot-create-policy 1h` will specify that snapshots should be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fff9ebd_90107162","line":45,"range":{"start_line":45,"start_character":44,"end_line":45,"end_character":46},"in_reply_to":"6b0706c9_2ffe1a4a","updated":"2022-03-13 13:56:09.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":49,"context_line":"created for every hour."},{"line_number":50,"context_line":"`--auto-snapshot-delete-policy 12h` will specify that snapshots should be"},{"line_number":51,"context_line":"deleted for every 12 hours and all automatic snapshots available for that"},{"line_number":52,"context_line":"share at that time, will be deleted."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"In addition, if snapshot policies are not given during share creation, user"},{"line_number":55,"context_line":"have an option to create them during share update command. However, if"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ae89eecd_9453c2b8","line":52,"range":{"start_line":52,"start_character":35,"end_line":52,"end_character":36},"updated":"2022-03-11 19:09:43.000000000","message":"is it a valid combination to provide the \u0027auto-snapshot-create-policy\u0027 but not the \u0027auto-snapshot-delete-policy\u0027?","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":49,"context_line":"created for every hour."},{"line_number":50,"context_line":"`--auto-snapshot-delete-policy 12h` will specify that snapshots should be"},{"line_number":51,"context_line":"deleted for every 12 hours and all automatic snapshots available for that"},{"line_number":52,"context_line":"share at that time, will be deleted."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"In addition, if snapshot policies are not given during share creation, user"},{"line_number":55,"context_line":"have an option to create them during share update command. However, if"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c7905ce9_d6fd2e97","line":52,"range":{"start_line":52,"start_character":35,"end_line":52,"end_character":36},"in_reply_to":"ae89eecd_9453c2b8","updated":"2022-03-13 13:56:09.000000000","message":"Yes, its valid combination. In this case delete-interval \u003d 12 x create-interval.\nupdated spec","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":56,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":57,"context_line":"be updated to new policies specificed in share update command. The existing"},{"line_number":58,"context_line":"metadata will also be updated. If user specifies snapshot creation or deletion"},{"line_number":59,"context_line":"policy as 0x0 during share update, share will be excluded from automaric share"},{"line_number":60,"context_line":"creation and deletion."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f804497f_3ca6c94a","line":59,"range":{"start_line":59,"start_character":63,"end_line":59,"end_character":72},"updated":"2022-03-11 19:09:43.000000000","message":"automatic","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":56,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":57,"context_line":"be updated to new policies specificed in share update command. The existing"},{"line_number":58,"context_line":"metadata will also be updated. If user specifies snapshot creation or deletion"},{"line_number":59,"context_line":"policy as 0x0 during share update, share will be excluded from automaric share"},{"line_number":60,"context_line":"creation and deletion."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa2430b_305867a4","line":59,"range":{"start_line":59,"start_character":63,"end_line":59,"end_character":72},"in_reply_to":"f804497f_3ca6c94a","updated":"2022-03-13 13:56:09.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":56,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":57,"context_line":"be updated to new policies specificed in share update command. The existing"},{"line_number":58,"context_line":"metadata will also be updated. If user specifies snapshot creation or deletion"},{"line_number":59,"context_line":"policy as 0x0 during share update, share will be excluded from automaric share"},{"line_number":60,"context_line":"creation and deletion."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":63,"context_line":"created and they will run at minute interval. The provided input values for both"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9b1ab56a_2e960f74","line":60,"range":{"start_line":59,"start_character":35,"end_line":60,"end_character":22},"updated":"2022-03-11 19:09:43.000000000","message":"unsure i understand what this means\n\nDo you mean that updating with 0x0 would disable automatic snapshotting of the share?","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":56,"context_line":"snapshot policies are already present for given share, existing policies will"},{"line_number":57,"context_line":"be updated to new policies specificed in share update command. The existing"},{"line_number":58,"context_line":"metadata will also be updated. If user specifies snapshot creation or deletion"},{"line_number":59,"context_line":"policy as 0x0 during share update, share will be excluded from automaric share"},{"line_number":60,"context_line":"creation and deletion."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For handling automatic snapshot creation and deletion, periodic tasks will be"},{"line_number":63,"context_line":"created and they will run at minute interval. The provided input values for both"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a7fbd44_71763f7a","line":60,"range":{"start_line":59,"start_character":35,"end_line":60,"end_character":22},"in_reply_to":"9b1ab56a_2e960f74","updated":"2022-03-13 13:56:09.000000000","message":"Yes, setting 0x00 will disable automatic snapshotting for the share.","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":71,"context_line":"updated in share metadata. In order to differentiate between manual snapshots"},{"line_number":72,"context_line":"and automatic snapshots, the database will be updated. Share snapshot table"},{"line_number":73,"context_line":"will add boolean column \"is_automatic\", that would be \"True\" for manila"},{"line_number":74,"context_line":"created snapshots, otherwise \"False\". To upgrade db, all snapshots will be"},{"line_number":75,"context_line":"\"False\"."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a57a86b8_23df9052","line":74,"range":{"start_line":74,"start_character":72,"end_line":74,"end_character":74},"updated":"2022-03-11 19:09:43.000000000","message":"have their \"is_automatic\" attribute set to","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":71,"context_line":"updated in share metadata. In order to differentiate between manual snapshots"},{"line_number":72,"context_line":"and automatic snapshots, the database will be updated. Share snapshot table"},{"line_number":73,"context_line":"will add boolean column \"is_automatic\", that would be \"True\" for manila"},{"line_number":74,"context_line":"created snapshots, otherwise \"False\". To upgrade db, all snapshots will be"},{"line_number":75,"context_line":"\"False\"."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a919a162_f45417cb","line":74,"range":{"start_line":74,"start_character":72,"end_line":74,"end_character":74},"in_reply_to":"a57a86b8_23df9052","updated":"2022-03-13 13:56:09.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":75,"context_line":"\"False\"."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"},{"line_number":78,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":79,"context_line":"manually delete all snapshots and then delete share."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"During share unmanage, if automatic snapshots for share are present, they will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6c753d47_394f6371","line":78,"range":{"start_line":78,"start_character":60,"end_line":78,"end_character":73},"updated":"2022-03-11 19:09:43.000000000","message":"responsibility","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\"False\"."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"During share delete, if automatic snapshots are not deleted e.g. deletion"},{"line_number":78,"context_line":"periodic task is not executed yet, it would be user/admin-s responsibilty to"},{"line_number":79,"context_line":"manually delete all snapshots and then delete share."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"During share unmanage, if automatic snapshots for share are present, they will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"24feb19f_2de006f5","line":78,"range":{"start_line":78,"start_character":60,"end_line":78,"end_character":73},"in_reply_to":"6c753d47_394f6371","updated":"2022-03-13 13:56:09.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":79,"context_line":"manually delete all snapshots and then delete share."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"During share unmanage, if automatic snapshots for share are present, they will"},{"line_number":82,"context_line":"be deleted and share metadata regarding automatic snapshots will be removed."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":85,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a2948264_9213180c","line":82,"range":{"start_line":82,"start_character":75,"end_line":82,"end_character":76},"updated":"2022-03-11 19:09:43.000000000","message":"Can an automatic snapshot be unmanaged?","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":79,"context_line":"manually delete all snapshots and then delete share."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"During share unmanage, if automatic snapshots for share are present, they will"},{"line_number":82,"context_line":"be deleted and share metadata regarding automatic snapshots will be removed."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":85,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f3c69da5_eccda4f1","line":82,"range":{"start_line":82,"start_character":75,"end_line":82,"end_character":76},"in_reply_to":"a2948264_9213180c","updated":"2022-03-13 13:56:09.000000000","message":"No. We refer this as hidden from end user or Manila internal thing. So unmanage share should delete those snapshots.","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":81,"context_line":"During share unmanage, if automatic snapshots for share are present, they will"},{"line_number":82,"context_line":"be deleted and share metadata regarding automatic snapshots will be removed."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":85,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":86,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":87,"context_line":"and thus will be applicable for all shares."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"8e0719e5_98fa3493","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":50},"updated":"2022-03-11 19:09:43.000000000","message":"I\u0027m not sure this is technically feasible across different storage systems. When we designed the share replication feature, storage system vendors that we surveyed appeared to support replication of _all_ snapshots of the share... it may not be possible for a back end to selectively disable replication for some snapshots","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":81,"context_line":"During share unmanage, if automatic snapshots for share are present, they will"},{"line_number":82,"context_line":"be deleted and share metadata regarding automatic snapshots will be removed."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"We also need to set \"automatic_snapshot_for_replicas_enabled\" config option to"},{"line_number":85,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":86,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":87,"context_line":"and thus will be applicable for all shares."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"db9ddccc_aa586dcf","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":50},"in_reply_to":"8e0719e5_98fa3493","updated":"2022-03-13 13:56:09.000000000","message":"I am not sure as well. I better remove this section and let manila/share/api.py:create_snapshot() keep unmodified for this feature.","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":85,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":86,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":87,"context_line":"and thus will be applicable for all shares."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Alternatives"},{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"a86eb8c4_29713e4d","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":0},"updated":"2022-03-11 19:09:43.000000000","message":"Can you specify the impact to user+project or project-wide or share-type+project quotas associated with snapshots, snapshot_gigabytes, replica_snapshots and replica_snapshot_gigabytes?","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":85,"context_line":"True in order to consider share replicas for automatic snapshots otherwise"},{"line_number":86,"context_line":"automatic snapshots are only applicable to share. This is global config option"},{"line_number":87,"context_line":"and thus will be applicable for all shares."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Alternatives"},{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"35379e9c_b9392b3e","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":0},"in_reply_to":"a86eb8c4_29713e4d","updated":"2022-03-13 13:56:09.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":89,"context_line":"Alternatives"},{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Data model impact"},{"line_number":95,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"24065bc9_81b1cf21","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":4},"updated":"2022-03-11 19:09:43.000000000","message":"An alternative would be to trigger snapshots automatically outside of manila, using the manila API and delete them automatically on schedule - using perhaps a timer utility like crontab","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Alternatives"},{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Data model impact"},{"line_number":95,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"92a3488a_0a7ac4d0","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":4},"in_reply_to":"24065bc9_81b1cf21","updated":"2022-03-13 13:56:09.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Data model impact"},{"line_number":95,"context_line":"-----------------"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ca4e56c7_53244f71","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":0},"updated":"2022-03-11 19:09:43.000000000","message":"Also what other ideas have you considered to provide the automatic snapshot creation/deletion times?\n\nMaybe as share type extra specs?","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Data model impact"},{"line_number":95,"context_line":"-----------------"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fca3864_984a4cd2","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":0},"in_reply_to":"ca4e56c7_53244f71","updated":"2022-03-13 13:56:09.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":143,"context_line":"respond with ``400 Bad Request``."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":146,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"},{"line_number":147,"context_line":"periodic time interval defined i.e. 30 minutes."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Microversion of the API is incremented."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"f49e0073_f55aed6f","line":147,"range":{"start_line":146,"start_character":22,"end_line":147,"end_character":47},"updated":"2022-03-11 19:09:43.000000000","message":"nit: this text belongs to the \"create\" case above, rather than update - so perhaps move it under the earlier bullet point","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":143,"context_line":"respond with ``400 Bad Request``."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"In this particular examples, the share snapshots should be taken as per time"},{"line_number":146,"context_line":"interval defined i.e. 10 minutes and share snapshots should be deleted as per"},{"line_number":147,"context_line":"periodic time interval defined i.e. 30 minutes."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Microversion of the API is incremented."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9b7e4622_f9f88590","line":147,"range":{"start_line":146,"start_character":22,"end_line":147,"end_character":47},"in_reply_to":"f49e0073_f55aed6f","updated":"2022-03-13 13:56:09.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":157,"context_line":"Notifications impact"},{"line_number":158,"context_line":"--------------------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d70c2eb7_a5f534c4","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":4},"updated":"2022-03-11 19:09:43.000000000","message":"i suppose we want to set telemetry notifications when a snapshot has been created or deleted automatically. This can be done easily in manila - see https://github.com/openstack/manila/blob/2b57d15c641ff2a222c7d0af63853976b7e50f1f/manila/share/manager.py#L4909-L4913 for example that helps create notifications for shares.","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"32ccdb10f1691b02d61144f8e80102a049c414a3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Notifications impact"},{"line_number":158,"context_line":"--------------------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ec9a5ac3_d132f3f8","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":4},"in_reply_to":"d70c2eb7_a5f534c4","updated":"2022-04-30 13:35:10.000000000","message":"Done","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8327874e514216c16eb4af1038d22ebc84873bad","unresolved":true,"context_lines":[{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"None"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Performance Impact"},{"line_number":168,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7397bb16_926a0266","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":4},"updated":"2022-03-11 19:09:43.000000000","message":"Couple of things here:\n\nUsers could be provided with the approximate deletion time for an automatic snapshot when listing snapshots or retrieving details of a given snapshot - this may be helpful in planning for DR; and the visibility will allow users \nthe ability to adjust snapshot retention on need basis.\n\nRevert to snapshot will be affected by this feature - manila only allows reverting shares to the latest snapshot known to manila; so, this snapshot may be an automatic snapshot... and its possible the operations can race:\n\nAssume a share has two snapshots A1 and A2, created at times 1 and 2 respectively. User attempts to revert the share to A2, but, at the same time, automatic snapshot A3 is created -- how will this be handled by the code?\n\n\nThis sort of racy behavior is possible even when other operations are occurring, for example: assume a share has an automatic snapshot policy, and during the snapshotting activity, the user attempts to delete the share... \n\nFor a long time, we have noodled with the idea of introducing a share state called \"snapshotting\". Having a state allows us to prevent races.... maybe it is time to revive that thought..","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"64c0381e1c47acd2030afd4433596bfaac2fd998","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"None"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Performance Impact"},{"line_number":168,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e7d552d0_22d39282","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":4},"in_reply_to":"7397bb16_926a0266","updated":"2022-03-13 13:56:09.000000000","message":"I have added information about revert to snapshot and delete/unmanage scenario. Regarding \"snapshotting\" share, I am not sure as not aware of previous discussions about the same. But if it needed for automatic snapshot, I am fine with adding and handling that state as well","commit_id":"57b38d6660de9eea4391eb86ea99e4723c1d8446"}]}