)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a9e815d_63080189","updated":"2022-06-22 18:26:05.000000000","message":"Thanks a lot for writing this up Haixin! I\u0027d love to work with you on this; please see some comments inline with thoughts","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b6fb781c4a5e67567f3d2a13f06bbd62a68d960e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e72936a8_ee9570db","updated":"2022-06-23 08:02:38.000000000","message":"code patch link: https://review.opendev.org/c/openstack/manila/+/838672","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d435bb3_d3dae379","updated":"2022-06-23 07:08:57.000000000","message":"thanks for your review, Goutham Pacha Ravi.","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c08b963711d48e8bce643a1d9dee71ea286fbe56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c613222_c5087c22","updated":"2022-10-24 21:28:26.000000000","message":"Hey Haixin, \n\nThanks for your work on this; based on the PTG discussions, Lets move forward on this - a couple of points that we have discussed elsewhere that we need to note:\n\n1) We must try and build an efficient database query that returns the sum of allocated_capacity_gb for a given host -- unsure if we can add an index for the \"host\" attribute so this query is infact efficient. \n2) Cinder\u0027s got a concept of a \"Automatic Max Oversubscription Ratio\". That could be a further improvement to the way we do oversubscription... ","commit_id":"53f01c08ae84ec816bfa4fb76cf5ef1aa8724056"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"10d4a52d7fda810bd5b80bf8d72a662180b0f1ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3a0e1e30_1a72122b","updated":"2022-11-10 14:53:55.000000000","message":"LGTM, thanks Haixin!","commit_id":"53f01c08ae84ec816bfa4fb76cf5ef1aa8724056"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c768a31257dfaef3d9e7114df177cbed1703fa42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"310f47dc_fddf82dd","updated":"2022-06-28 21:25:38.000000000","message":"Looking good for the most part\nStill would like to see the closure for the discussion regarding the other comments :)","commit_id":"53f01c08ae84ec816bfa4fb76cf5ef1aa8724056"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d6514568_49aab040","updated":"2022-06-28 01:40:57.000000000","message":"hi, Carlos Eduardo.\nthanks for your review.","commit_id":"53f01c08ae84ec816bfa4fb76cf5ef1aa8724056"}],"specs/zed/manila-oversubscription-enhancements.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* for problem one, need to update driver code to report provisioned_capacity_gb"},{"line_number":90,"context_line":"  instead of allocated_capacity_gb, that means only report"},{"line_number":91,"context_line":"  provisioned_capacity_gb."},{"line_number":92,"context_line":"* for problem two,  Add a periodic task in Manila Share to periodically collect"},{"line_number":93,"context_line":"  allocated_capacity_gb statistics from the database and record it in"},{"line_number":94,"context_line":"  self._allocated_capacity_gb(a member variable of class ShareManager). Read"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fc0e6228_ad45f476","line":91,"range":{"start_line":91,"start_character":25,"end_line":91,"end_character":26},"updated":"2022-06-22 18:26:05.000000000","message":"where possible. For some drivers, getting this number may not be possible. \n\nSo I think what you\u0027re asking for is:\n\n1) If possible, drivers must report the ``provisioned_capacity_gb`` for each storage pool. They can report \"allocated_capacity_gb\" if the driver is capable of tracking it accurately. However, drivers must refrain from reporting just ``allocated_capacity_gb`` - if they do, it will be assumed that provisioned_capacity_gb is equal to ``allocated_capacity_gb``","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* for problem one, need to update driver code to report provisioned_capacity_gb"},{"line_number":90,"context_line":"  instead of allocated_capacity_gb, that means only report"},{"line_number":91,"context_line":"  provisioned_capacity_gb."},{"line_number":92,"context_line":"* for problem two,  Add a periodic task in Manila Share to periodically collect"},{"line_number":93,"context_line":"  allocated_capacity_gb statistics from the database and record it in"},{"line_number":94,"context_line":"  self._allocated_capacity_gb(a member variable of class ShareManager). Read"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c5b6a31c_15545d7e","line":91,"range":{"start_line":91,"start_character":25,"end_line":91,"end_character":26},"in_reply_to":"fc0e6228_ad45f476","updated":"2022-06-23 07:08:57.000000000","message":"yes, goutham.This solves the awkward situation where some drivers cannot report this value.\n\n\"allocated_capacity_gb\" reported by driver may be correct if the driver is capable of tracking it accurately, but \"allocated_capacity_gb\" calculated from database must be correct. so for uniformity, \"allocated_capacity_gb\" will use calculated by\ndatabase rather than reported by driver.\n\nWe strongly recommend that the driver report ``provisioned_capacity_gb``, if it is not reported, Manila is considered exclusive storage pool, will using allocated_capacity_gb as the provisioned_capacity_gb value.","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":true,"context_lines":[{"line_number":96,"context_line":"  share_stats[pools] when executing _report_driver_status. Because Manila"},{"line_number":97,"context_line":"  doesn\u0027t require very much real-time data for allocated_capacity_gb,"},{"line_number":98,"context_line":"  Therefore, the interval of periodic tasks can be set to 5 minutes to reduce"},{"line_number":99,"context_line":"  system and database pressure."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4edeeaae_cd3c6496","line":99,"updated":"2022-06-23 07:08:57.000000000","message":"Q:don\u0027t we still have the issue that multiple share managers running in active/active HA will be performing this calculation redundantly?and perhaps incorrectly?\nA: we calculate allocated_capacity_gb from database in share manager layer, get all share instances filter by host. so allocated_capacity_gb must be correct. then share manager report this to scheduler. This reporting process takes advantage of the HA of the share manager to ensure that when a share manager goes down, the report can be completed by other Share managers. so I don\u0027t think it\u0027s redundantly.\n\nQ: would this approach work?\nA: I thought about caching it in the database,However, in high concurrency scenarios,It\u0027s the same field in the database that needs to be changed. I am afraid of database performance and database deadlock phenomenon.This is a good idea if we don\u0027t have to worry about the database.","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":true,"context_lines":[{"line_number":89,"context_line":"* for problem one, need to update driver code to report provisioned_capacity_gb"},{"line_number":90,"context_line":"  instead of allocated_capacity_gb, that means only report"},{"line_number":91,"context_line":"  provisioned_capacity_gb."},{"line_number":92,"context_line":"* for problem two,  Add a periodic task in Manila Share to periodically collect"},{"line_number":93,"context_line":"  allocated_capacity_gb statistics from the database and record it in"},{"line_number":94,"context_line":"  self._allocated_capacity_gb(a member variable of class ShareManager). Read"},{"line_number":95,"context_line":"  self._allocated_capacity_gb and update allocated_capacity_gb in"},{"line_number":96,"context_line":"  share_stats[pools] when executing _report_driver_status. Because Manila"},{"line_number":97,"context_line":"  doesn\u0027t require very much real-time data for allocated_capacity_gb,"},{"line_number":98,"context_line":"  Therefore, the interval of periodic tasks can be set to 5 minutes to reduce"},{"line_number":99,"context_line":"  system and database pressure."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b06c329b_4f04a1a9","line":99,"range":{"start_line":92,"start_character":2,"end_line":99,"end_character":31},"updated":"2022-06-22 18:26:05.000000000","message":"With this, don\u0027t we effectively shift the calculation from the scheduler to the share manager process? If yes, don\u0027t we still have the issue that multiple share managers running in active/active HA will be performing this calculation redundantly; and perhaps incorrectly?\n\nWould it make sense for us to track this information somehow in the database? \n\n\n1) During driver initialization, kick off a thread to sum up sizes of all non errored shares for a given host, cache it in the database (we\u0027ll need a new table or can use driver private data for this) \n2) When a share creation (or extension) request comes, increment and rewrite to cache\n3) When a share deletion (or shrinking) request comes, decrement and rewrite to cache\n4) Every minute, re-read your own cached value from the database so you can remain in-sync\n\n\nwould this approach work?","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"737b32962d2c13b0b8561f3a830ac58e87c5bd0e","unresolved":true,"context_lines":[{"line_number":96,"context_line":"  share_stats[pools] when executing _report_driver_status. Because Manila"},{"line_number":97,"context_line":"  doesn\u0027t require very much real-time data for allocated_capacity_gb,"},{"line_number":98,"context_line":"  Therefore, the interval of periodic tasks can be set to 5 minutes to reduce"},{"line_number":99,"context_line":"  system and database pressure."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"71f5fef3_818c0300","line":99,"in_reply_to":"4edeeaae_cd3c6496","updated":"2022-10-20 23:40:40.000000000","message":"I agree with the aspect that cache writes will be expensive - the re-calculation is expensive too.. maybe we can do cache correction periodically?","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c08b963711d48e8bce643a1d9dee71ea286fbe56","unresolved":true,"context_lines":[{"line_number":96,"context_line":"  share_stats[pools] when executing _report_driver_status. Because Manila"},{"line_number":97,"context_line":"  doesn\u0027t require very much real-time data for allocated_capacity_gb,"},{"line_number":98,"context_line":"  Therefore, the interval of periodic tasks can be set to 5 minutes to reduce"},{"line_number":99,"context_line":"  system and database pressure."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4b54ab91_b38328fb","line":99,"in_reply_to":"71f5fef3_818c0300","updated":"2022-10-24 21:28:26.000000000","message":"We discussed this quite a bit at the Antelope PTG; and I agree with haixin\u0027s approach here for now until we figure out a way to reduce duplicate work across active/active services; \n\nWe must try to optimize the database query that sums up instances by host so this calculation isn\u0027t too expensive.","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Data model impact"},{"line_number":107,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0f43906f_988103cb","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":4},"updated":"2022-06-22 18:26:05.000000000","message":"The current model is an alternative, however, the calculation occuring in the scheduler is problematic because it\u0027s happening in each scheduler process for each backend and for each pool, which is inefficient and wrong","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Data model impact"},{"line_number":107,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"56abc3c1_eb673a4a","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":4},"in_reply_to":"0f43906f_988103cb","updated":"2022-06-23 07:08:57.000000000","message":"Done","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":true,"context_lines":[{"line_number":106,"context_line":"Data model impact"},{"line_number":107,"context_line":"-----------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"REST API impact"},{"line_number":112,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fd10a419_28eb6242","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":4},"updated":"2022-06-22 18:26:05.000000000","message":"If we use the database, we\u0027ll need to document this","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":true,"context_lines":[{"line_number":106,"context_line":"Data model impact"},{"line_number":107,"context_line":"-----------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"REST API impact"},{"line_number":112,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bc69fe59_e6edfd03","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":4},"in_reply_to":"fd10a419_28eb6242","updated":"2022-06-23 07:08:57.000000000","message":"As discussed above, I\u0027m not a big fan of using databases.","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":true,"context_lines":[{"line_number":111,"context_line":"REST API impact"},{"line_number":112,"context_line":"---------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Security impact"},{"line_number":117,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"734c549d_e3e0bc66","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":4},"updated":"2022-06-22 18:26:05.000000000","message":"I would really love to see an improvement to the get-pools API (GET /scheduler-stats/pools) to expose \"allocated_capacity_gb\" and \"provisioned_capacity_gb\"","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"REST API impact"},{"line_number":112,"context_line":"---------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Security impact"},{"line_number":117,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f1ebbe2a_c2997462","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":4},"in_reply_to":"734c549d_e3e0bc66","updated":"2022-06-23 07:08:57.000000000","message":"current manila pool-list --detail can expose  \"allocated_capacity_gb\" and \"provisioned_capacity_gb\" already.","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":true,"context_lines":[{"line_number":131,"context_line":"Performance Impact"},{"line_number":132,"context_line":"------------------"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"None"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Other deployer impact"},{"line_number":137,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"277319f6_ca992b8e","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":4},"updated":"2022-06-22 18:26:05.000000000","message":"There is a perf impact - we\u0027d be removing a huge performance bottleneck from the scheduler service!","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Performance Impact"},{"line_number":132,"context_line":"------------------"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"None"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Other deployer impact"},{"line_number":137,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"056e0afa_a15ed3a4","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":4},"in_reply_to":"277319f6_ca992b8e","updated":"2022-06-23 07:08:57.000000000","message":"Done","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":true,"context_lines":[{"line_number":158,"context_line":"Work Items"},{"line_number":159,"context_line":"----------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* Update Manager."},{"line_number":162,"context_line":"* Update unittest."},{"line_number":163,"context_line":"* Update related documents."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9c260790_64c2ed2a","line":161,"range":{"start_line":161,"start_character":9,"end_line":161,"end_character":17},"updated":"2022-06-22 18:26:05.000000000","message":"you mean share manager and scheduler\u0027s host manager?","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"Work Items"},{"line_number":159,"context_line":"----------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* Update Manager."},{"line_number":162,"context_line":"* Update unittest."},{"line_number":163,"context_line":"* Update related documents."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7c0dc1fb_f73cf2ac","line":161,"range":{"start_line":161,"start_character":9,"end_line":161,"end_character":17},"in_reply_to":"9c260790_64c2ed2a","updated":"2022-06-23 07:08:57.000000000","message":"both have. :)","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9edea1bfbe20e87ae237261616958bb8054d550c","unresolved":true,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"The following OpenStack documentations will be updated to reflect this change:"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* OpenStack Contributor Guide"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"References"},{"line_number":184,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"420a0ec5_4c66fe31","line":181,"range":{"start_line":181,"start_character":28,"end_line":181,"end_character":29},"updated":"2022-06-22 18:26:05.000000000","message":"It\u0027d be really good to include a documentation of how thin provisioning is expected to work in the administrator guide; for example like: https://docs.openstack.org/cinder/latest/admin/over-subscription.html","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"55a23d362d07c6ff60accb7056ed22dd6881709e","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"The following OpenStack documentations will be updated to reflect this change:"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* OpenStack Contributor Guide"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"References"},{"line_number":184,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"721d419d_f6955e13","line":181,"range":{"start_line":181,"start_character":28,"end_line":181,"end_character":29},"in_reply_to":"420a0ec5_4c66fe31","updated":"2022-06-23 07:08:57.000000000","message":"Done","commit_id":"c15a46506b307a632a52678e67efc65a0e65dbec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/manila-oversubscription-enhancements"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"About allocated_capacity_gb and provisioned_capacity_gb, allocated_capacity_gb"},{"line_number":14,"context_line":"is shares_gb created on a storage pool via manila. provisioned_capacity_gb is"},{"line_number":15,"context_line":"equal to the sum of allocated_capacity_gb add shares_gb_created_manually (or"},{"line_number":16,"context_line":"another manila) on the same storage pool. implies that provisioned_capacity_gb"},{"line_number":17,"context_line":"greater than or equal to allocated_capacity_gb. It is important for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f66e19c1_a39908e9","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"updated":"2022-06-24 18:22:26.000000000","message":"corresponds to","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/manila/+spec/manila-oversubscription-enhancements"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"About allocated_capacity_gb and provisioned_capacity_gb, allocated_capacity_gb"},{"line_number":14,"context_line":"is shares_gb created on a storage pool via manila. provisioned_capacity_gb is"},{"line_number":15,"context_line":"equal to the sum of allocated_capacity_gb add shares_gb_created_manually (or"},{"line_number":16,"context_line":"another manila) on the same storage pool. implies that provisioned_capacity_gb"},{"line_number":17,"context_line":"greater than or equal to allocated_capacity_gb. It is important for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"db448a21_baeb05b5","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"in_reply_to":"f66e19c1_a39908e9","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":13,"context_line":"About allocated_capacity_gb and provisioned_capacity_gb, allocated_capacity_gb"},{"line_number":14,"context_line":"is shares_gb created on a storage pool via manila. provisioned_capacity_gb is"},{"line_number":15,"context_line":"equal to the sum of allocated_capacity_gb add shares_gb_created_manually (or"},{"line_number":16,"context_line":"another manila) on the same storage pool. implies that provisioned_capacity_gb"},{"line_number":17,"context_line":"greater than or equal to allocated_capacity_gb. It is important for"},{"line_number":18,"context_line":"administrators to know these two values in order to obtain information about"},{"line_number":19,"context_line":"back-end allocated capacity."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dd4da842_b20ddc1c","line":16,"range":{"start_line":16,"start_character":42,"end_line":16,"end_character":49},"updated":"2022-06-24 18:22:26.000000000","message":"It implies","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"About allocated_capacity_gb and provisioned_capacity_gb, allocated_capacity_gb"},{"line_number":14,"context_line":"is shares_gb created on a storage pool via manila. provisioned_capacity_gb is"},{"line_number":15,"context_line":"equal to the sum of allocated_capacity_gb add shares_gb_created_manually (or"},{"line_number":16,"context_line":"another manila) on the same storage pool. implies that provisioned_capacity_gb"},{"line_number":17,"context_line":"greater than or equal to allocated_capacity_gb. It is important for"},{"line_number":18,"context_line":"administrators to know these two values in order to obtain information about"},{"line_number":19,"context_line":"back-end allocated capacity."}],"source_content_type":"text/x-rst","patch_set":3,"id":"8936d313_f112933e","line":16,"range":{"start_line":16,"start_character":42,"end_line":16,"end_character":49},"in_reply_to":"dd4da842_b20ddc1c","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":27,"context_line":"free_capacity_gb \u003d total_capacity_gb - Used physical disk capacity of the"},{"line_number":28,"context_line":"storage pool."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"provisioned_capacity_gb \u003d Total capacity allocated by all shares(include"},{"line_number":31,"context_line":"shares created manually or other manila) in the storage pool."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"allocated_capacity_gb \u003d Total capacity allocated by all shares created by"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ac715bd0_05794626","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":65},"updated":"2022-06-24 18:22:26.000000000","message":"nit: missing blank spaces between these characters","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"free_capacity_gb \u003d total_capacity_gb - Used physical disk capacity of the"},{"line_number":28,"context_line":"storage pool."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"provisioned_capacity_gb \u003d Total capacity allocated by all shares(include"},{"line_number":31,"context_line":"shares created manually or other manila) in the storage pool."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"allocated_capacity_gb \u003d Total capacity allocated by all shares created by"}],"source_content_type":"text/x-rst","patch_set":3,"id":"36222fee_60de5349","line":30,"range":{"start_line":30,"start_character":63,"end_line":30,"end_character":65},"in_reply_to":"ac715bd0_05794626","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Problem One:"},{"line_number":42,"context_line":"Here\u0027s an example. Storage pool pool_A physical disk capacity is 10G. here are"},{"line_number":43,"context_line":"four shares in this pool."},{"line_number":44,"context_line":"Share A created by openstack O_A(current manila), share size is 5G. There is a"},{"line_number":45,"context_line":"124MB file in this share."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5d3e5b81_f9d20d87","line":42,"range":{"start_line":42,"start_character":70,"end_line":42,"end_character":74},"updated":"2022-06-24 18:22:26.000000000","message":"There","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Problem One:"},{"line_number":42,"context_line":"Here\u0027s an example. Storage pool pool_A physical disk capacity is 10G. here are"},{"line_number":43,"context_line":"four shares in this pool."},{"line_number":44,"context_line":"Share A created by openstack O_A(current manila), share size is 5G. There is a"},{"line_number":45,"context_line":"124MB file in this share."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fe70738c_cdf93b20","line":42,"range":{"start_line":42,"start_character":70,"end_line":42,"end_character":74},"in_reply_to":"5d3e5b81_f9d20d87","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":43,"context_line":"four shares in this pool."},{"line_number":44,"context_line":"Share A created by openstack O_A(current manila), share size is 5G. There is a"},{"line_number":45,"context_line":"124MB file in this share."},{"line_number":46,"context_line":"Share B created by openstack O_A, share size is 4G. There is a 0MB file in"},{"line_number":47,"context_line":"this share."},{"line_number":48,"context_line":"Share C created by openstack O_B, share size is 3G. There is a 400MB file in"},{"line_number":49,"context_line":"this share."}],"source_content_type":"text/x-rst","patch_set":3,"id":"d3e56090_b2e8c057","line":46,"updated":"2022-06-24 18:22:26.000000000","message":"as you mentioned this to be current manila online 57 shouldn\u0027t we flag it here as well?","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"four shares in this pool."},{"line_number":44,"context_line":"Share A created by openstack O_A(current manila), share size is 5G. There is a"},{"line_number":45,"context_line":"124MB file in this share."},{"line_number":46,"context_line":"Share B created by openstack O_A, share size is 4G. There is a 0MB file in"},{"line_number":47,"context_line":"this share."},{"line_number":48,"context_line":"Share C created by openstack O_B, share size is 3G. There is a 400MB file in"},{"line_number":49,"context_line":"this share."}],"source_content_type":"text/x-rst","patch_set":3,"id":"240d8c71_68b7b443","line":46,"in_reply_to":"d3e56090_b2e8c057","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":59,"context_line":"In fact, the storage back end doesn\u0027t know how many Manila services are using"},{"line_number":60,"context_line":"the storage pool or whether the administrator has manually created shares in"},{"line_number":61,"context_line":"the pool. So the allocated_capacity_gb reported by backend storage driver is"},{"line_number":62,"context_line":"not correct. only provisioned_capacity_gb reported by backend storage driver is"},{"line_number":63,"context_line":"correct."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Currently, some drivers(inspur, huawei, netapp, qnap, zadara) report"}],"source_content_type":"text/x-rst","patch_set":3,"id":"27290ecd_12e8953e","line":62,"range":{"start_line":62,"start_character":13,"end_line":62,"end_character":17},"updated":"2022-06-24 18:22:26.000000000","message":"Only","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"In fact, the storage back end doesn\u0027t know how many Manila services are using"},{"line_number":60,"context_line":"the storage pool or whether the administrator has manually created shares in"},{"line_number":61,"context_line":"the pool. So the allocated_capacity_gb reported by backend storage driver is"},{"line_number":62,"context_line":"not correct. only provisioned_capacity_gb reported by backend storage driver is"},{"line_number":63,"context_line":"correct."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Currently, some drivers(inspur, huawei, netapp, qnap, zadara) report"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8a70a83b_6733c1e3","line":62,"range":{"start_line":62,"start_character":13,"end_line":62,"end_character":17},"in_reply_to":"27290ecd_12e8953e","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":62,"context_line":"not correct. only provisioned_capacity_gb reported by backend storage driver is"},{"line_number":63,"context_line":"correct."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Currently, some drivers(inspur, huawei, netapp, qnap, zadara) report"},{"line_number":66,"context_line":"allocated_capacity_gb and some drivers(infinibox, hpe_3par, nexenta)"},{"line_number":67,"context_line":"report provisioned_capacity_gb, which is chaotic."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"2a9ee265_ee4a8584","line":65,"range":{"start_line":65,"start_character":22,"end_line":65,"end_character":24},"updated":"2022-06-24 18:22:26.000000000","message":"please insert a blank space here","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"not correct. only provisioned_capacity_gb reported by backend storage driver is"},{"line_number":63,"context_line":"correct."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Currently, some drivers(inspur, huawei, netapp, qnap, zadara) report"},{"line_number":66,"context_line":"allocated_capacity_gb and some drivers(infinibox, hpe_3par, nexenta)"},{"line_number":67,"context_line":"report provisioned_capacity_gb, which is chaotic."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"871deefc_d07dbfbd","line":65,"range":{"start_line":65,"start_character":22,"end_line":65,"end_character":24},"in_reply_to":"2a9ee265_ee4a8584","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":63,"context_line":"correct."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Currently, some drivers(inspur, huawei, netapp, qnap, zadara) report"},{"line_number":66,"context_line":"allocated_capacity_gb and some drivers(infinibox, hpe_3par, nexenta)"},{"line_number":67,"context_line":"report provisioned_capacity_gb, which is chaotic."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Problem Two:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8013a292_0352227d","line":66,"range":{"start_line":66,"start_character":37,"end_line":66,"end_character":39},"updated":"2022-06-24 18:22:26.000000000","message":"please insert a blank space here","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"correct."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Currently, some drivers(inspur, huawei, netapp, qnap, zadara) report"},{"line_number":66,"context_line":"allocated_capacity_gb and some drivers(infinibox, hpe_3par, nexenta)"},{"line_number":67,"context_line":"report provisioned_capacity_gb, which is chaotic."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Problem Two:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0e64db3d_ad19b4cb","line":66,"range":{"start_line":66,"start_character":37,"end_line":66,"end_character":39},"in_reply_to":"8013a292_0352227d","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":69,"context_line":"Problem Two:"},{"line_number":70,"context_line":"About scheduler service supports Active/Active HA, The consume_from_share"},{"line_number":71,"context_line":"function is executed each time a share is created or extend, in this function"},{"line_number":72,"context_line":"allocated_capacity_gb and free_capacity_gb must be updated,Suppose 100 1gb"},{"line_number":73,"context_line":"shares are created, 50 of which are executed on node 1 and 30 on node 2 and 20"},{"line_number":74,"context_line":"on node 3. Since allocated_capacity_gb is maintained in the memory of the"},{"line_number":75,"context_line":"scheduling service. As a result, the allocated_capacity_gb values of the three"}],"source_content_type":"text/x-rst","patch_set":3,"id":"86f36cc1_54971bb0","line":72,"range":{"start_line":72,"start_character":58,"end_line":72,"end_character":60},"updated":"2022-06-24 18:22:26.000000000","message":"Let\u0027s suppose","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Problem Two:"},{"line_number":70,"context_line":"About scheduler service supports Active/Active HA, The consume_from_share"},{"line_number":71,"context_line":"function is executed each time a share is created or extend, in this function"},{"line_number":72,"context_line":"allocated_capacity_gb and free_capacity_gb must be updated,Suppose 100 1gb"},{"line_number":73,"context_line":"shares are created, 50 of which are executed on node 1 and 30 on node 2 and 20"},{"line_number":74,"context_line":"on node 3. Since allocated_capacity_gb is maintained in the memory of the"},{"line_number":75,"context_line":"scheduling service. As a result, the allocated_capacity_gb values of the three"}],"source_content_type":"text/x-rst","patch_set":3,"id":"504ccd3f_1ae81f0e","line":72,"range":{"start_line":72,"start_character":58,"end_line":72,"end_character":60},"in_reply_to":"86f36cc1_54971bb0","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":73,"context_line":"shares are created, 50 of which are executed on node 1 and 30 on node 2 and 20"},{"line_number":74,"context_line":"on node 3. Since allocated_capacity_gb is maintained in the memory of the"},{"line_number":75,"context_line":"scheduling service. As a result, the allocated_capacity_gb values of the three"},{"line_number":76,"context_line":"scheduling nodes are inconsistent. This is problematic .We need to calibrate"},{"line_number":77,"context_line":"allocated_capacity_gb periodically."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df06430a_e751c874","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":57},"updated":"2022-06-24 18:22:26.000000000","message":". We","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"shares are created, 50 of which are executed on node 1 and 30 on node 2 and 20"},{"line_number":74,"context_line":"on node 3. Since allocated_capacity_gb is maintained in the memory of the"},{"line_number":75,"context_line":"scheduling service. As a result, the allocated_capacity_gb values of the three"},{"line_number":76,"context_line":"scheduling nodes are inconsistent. This is problematic .We need to calibrate"},{"line_number":77,"context_line":"allocated_capacity_gb periodically."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f16cd322_e64e8fe9","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":57},"in_reply_to":"df06430a_e751c874","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":80,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":81,"context_line":"* The administrator can view the capacity allocation of the back-end storage"},{"line_number":82,"context_line":"  by allocated_capacity_gb and provisioned_capacity_gb."},{"line_number":83,"context_line":"* Manila scheduler use provisioned_capacity_gb to filter and weigher back-end."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Proposed Change"},{"line_number":86,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1e11e796_96540e81","line":83,"range":{"start_line":83,"start_character":61,"end_line":83,"end_character":68},"updated":"2022-06-24 18:22:26.000000000","message":"weigh","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":81,"context_line":"* The administrator can view the capacity allocation of the back-end storage"},{"line_number":82,"context_line":"  by allocated_capacity_gb and provisioned_capacity_gb."},{"line_number":83,"context_line":"* Manila scheduler use provisioned_capacity_gb to filter and weigher back-end."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Proposed Change"},{"line_number":86,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d454fc14_2eae2ae7","line":83,"range":{"start_line":83,"start_character":61,"end_line":83,"end_character":68},"in_reply_to":"1e11e796_96540e81","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* allocated_capacity_gb reported by driver may be correct if the driver is"},{"line_number":90,"context_line":"  capable of tracking it accurately, but allocated_capacity_gb calculated"},{"line_number":91,"context_line":"  from database must be correct. so for uniformity, allocated_capacity_gb"},{"line_number":92,"context_line":"  will use calculated by database rather than reported by driver."},{"line_number":93,"context_line":"* we strongly recommend that the driver report provisioned_capacity_gb, if"},{"line_number":94,"context_line":"  it is not reported, Manila is considered exclusive storage pool, will using"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a73e295f_9fb9b02f","line":91,"range":{"start_line":91,"start_character":31,"end_line":91,"end_character":34},"updated":"2022-06-24 18:22:26.000000000","message":". So","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* allocated_capacity_gb reported by driver may be correct if the driver is"},{"line_number":90,"context_line":"  capable of tracking it accurately, but allocated_capacity_gb calculated"},{"line_number":91,"context_line":"  from database must be correct. so for uniformity, allocated_capacity_gb"},{"line_number":92,"context_line":"  will use calculated by database rather than reported by driver."},{"line_number":93,"context_line":"* we strongly recommend that the driver report provisioned_capacity_gb, if"},{"line_number":94,"context_line":"  it is not reported, Manila is considered exclusive storage pool, will using"}],"source_content_type":"text/x-rst","patch_set":3,"id":"db51bf32_bbb2c78e","line":91,"range":{"start_line":91,"start_character":31,"end_line":91,"end_character":34},"in_reply_to":"a73e295f_9fb9b02f","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":91,"context_line":"  from database must be correct. so for uniformity, allocated_capacity_gb"},{"line_number":92,"context_line":"  will use calculated by database rather than reported by driver."},{"line_number":93,"context_line":"* we strongly recommend that the driver report provisioned_capacity_gb, if"},{"line_number":94,"context_line":"  it is not reported, Manila is considered exclusive storage pool, will using"},{"line_number":95,"context_line":"  allocated_capacity_gb as the provisioned_capacity_gb value."},{"line_number":96,"context_line":"* for problem two,  Add a periodic task in Manila Share to periodically collect"},{"line_number":97,"context_line":"  allocated_capacity_gb statistics from the database and record it in"}],"source_content_type":"text/x-rst","patch_set":3,"id":"532f04c9_deb21cac","line":94,"range":{"start_line":94,"start_character":72,"end_line":94,"end_character":77},"updated":"2022-06-24 18:22:26.000000000","message":"use","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  from database must be correct. so for uniformity, allocated_capacity_gb"},{"line_number":92,"context_line":"  will use calculated by database rather than reported by driver."},{"line_number":93,"context_line":"* we strongly recommend that the driver report provisioned_capacity_gb, if"},{"line_number":94,"context_line":"  it is not reported, Manila is considered exclusive storage pool, will using"},{"line_number":95,"context_line":"  allocated_capacity_gb as the provisioned_capacity_gb value."},{"line_number":96,"context_line":"* for problem two,  Add a periodic task in Manila Share to periodically collect"},{"line_number":97,"context_line":"  allocated_capacity_gb statistics from the database and record it in"}],"source_content_type":"text/x-rst","patch_set":3,"id":"efa4c443_ba934bec","line":94,"range":{"start_line":94,"start_character":72,"end_line":94,"end_character":77},"in_reply_to":"532f04c9_deb21cac","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c73e0b5ac890f697a29a3f8fe71db45065c3c6e6","unresolved":true,"context_lines":[{"line_number":95,"context_line":"  allocated_capacity_gb as the provisioned_capacity_gb value."},{"line_number":96,"context_line":"* for problem two,  Add a periodic task in Manila Share to periodically collect"},{"line_number":97,"context_line":"  allocated_capacity_gb statistics from the database and record it in"},{"line_number":98,"context_line":"  self._allocated_capacity_gb(a member variable of class ShareManager). Read"},{"line_number":99,"context_line":"  self._allocated_capacity_gb and update allocated_capacity_gb in"},{"line_number":100,"context_line":"  share_stats[pools] when executing _report_driver_status. Because Manila"},{"line_number":101,"context_line":"  doesn\u0027t require very much real-time data for allocated_capacity_gb,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6066bbd0_e4e504b2","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":30},"updated":"2022-06-24 18:22:26.000000000","message":"nit: missing a blank space between these two","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"afa09933392a2ee37e8f91ba5569385bebac8af5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  allocated_capacity_gb as the provisioned_capacity_gb value."},{"line_number":96,"context_line":"* for problem two,  Add a periodic task in Manila Share to periodically collect"},{"line_number":97,"context_line":"  allocated_capacity_gb statistics from the database and record it in"},{"line_number":98,"context_line":"  self._allocated_capacity_gb(a member variable of class ShareManager). Read"},{"line_number":99,"context_line":"  self._allocated_capacity_gb and update allocated_capacity_gb in"},{"line_number":100,"context_line":"  share_stats[pools] when executing _report_driver_status. Because Manila"},{"line_number":101,"context_line":"  doesn\u0027t require very much real-time data for allocated_capacity_gb,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d3a8f41c_2395389e","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":30},"in_reply_to":"6066bbd0_e4e504b2","updated":"2022-06-28 01:40:57.000000000","message":"Done","commit_id":"ee062556fa6b30655ee81663f8261acf877771e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"737b32962d2c13b0b8561f3a830ac58e87c5bd0e","unresolved":true,"context_lines":[{"line_number":21,"context_line":"For a storage backend that supports thin provisioning,The following describes"},{"line_number":22,"context_line":"the reported capacity information."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"total_capacity_gb \u003d Total physical disk capacity of the storage pool used by"},{"line_number":25,"context_line":"Manila."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"free_capacity_gb \u003d total_capacity_gb - Used physical disk capacity of the"},{"line_number":28,"context_line":"storage pool."}],"source_content_type":"text/x-rst","patch_set":4,"id":"d3a1e821_fe3e94a8","line":25,"range":{"start_line":24,"start_character":69,"end_line":25,"end_character":7},"updated":"2022-10-20 23:40:40.000000000","message":"removing this will preserve the meaning of the sentence without confusion that the capacity is somehow \"used\".","commit_id":"53f01c08ae84ec816bfa4fb76cf5ef1aa8724056"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"737b32962d2c13b0b8561f3a830ac58e87c5bd0e","unresolved":true,"context_lines":[{"line_number":56,"context_line":"provisioned_capacity_gb \u003d 14G (5G+4G+3G+2G)"},{"line_number":57,"context_line":"allocated_capacity_gb \u003d 9G (5G+4G, only share A and B is created by current manila)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"In fact, the storage back end doesn\u0027t know how many Manila services are using"},{"line_number":60,"context_line":"the storage pool or whether the administrator has manually created shares in"},{"line_number":61,"context_line":"the pool. So the allocated_capacity_gb reported by backend storage driver is"},{"line_number":62,"context_line":"not correct. Only provisioned_capacity_gb reported by backend storage driver is"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fe451d0d_eb67f742","line":59,"range":{"start_line":59,"start_character":30,"end_line":59,"end_character":37},"updated":"2022-10-20 23:40:40.000000000","message":"may not","commit_id":"53f01c08ae84ec816bfa4fb76cf5ef1aa8724056"}]}