)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"781faf20eea430b6c6d48c4e913679888bba56b0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for share/share-snapshot deferred deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During delete, free the used share/share-snapshot quotas immediately"},{"line_number":10,"context_line":"and process deferred share/share-snapshot deletion in share manager."},{"line_number":11,"context_line":"This will reduce the waiting time of new share/share-snapshot creation"},{"line_number":12,"context_line":"blocked on quota limit."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"59593f69_4c4547f0","line":9,"updated":"2023-12-07 11:31:24.000000000","message":"@kinpaa@gmail.com, Thank you for taking up this feature. I am not able to find any ONTAP side limitation regarding quota assignment to share when quota associated volume being deleted. Also, ONTAP support Volume deletion in background. Command line has foregroud attribute which tell volume to delete in backgroud. Also, ZAPI volume-destroy-async can be used to delete volume in non-blocking way. I didn\u0027t find mirror implementation in Manila. Can you check if this helps. Also, Can you point to issue you are trying to solve(i.e. BUG or any other resources you have).","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34f450120446f57ecc810a998eba6028ce04f773","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for share/share-snapshot deferred deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During delete, free the used share/share-snapshot quotas immediately"},{"line_number":10,"context_line":"and process deferred share/share-snapshot deletion in share manager."},{"line_number":11,"context_line":"This will reduce the waiting time of new share/share-snapshot creation"},{"line_number":12,"context_line":"blocked on quota limit."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9ede2d9_a69eda05","line":9,"in_reply_to":"0081c896_27d70a8a","updated":"2023-12-18 12:13:19.000000000","message":"Done","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9b9598d9821378626d2faad16caaad40409bd446","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for share/share-snapshot deferred deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During delete, free the used share/share-snapshot quotas immediately"},{"line_number":10,"context_line":"and process deferred share/share-snapshot deletion in share manager."},{"line_number":11,"context_line":"This will reduce the waiting time of new share/share-snapshot creation"},{"line_number":12,"context_line":"blocked on quota limit."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8d0d859b_21f19311","line":9,"in_reply_to":"55b9fd73_93ba56a9","updated":"2023-12-11 04:45:20.000000000","message":"Thank you! Kiran for replay. I am not able to find any issue where quota s not available for share when other share is using or deleting. Also, find all quotas associated with volume and issue \"quota-off\" before deleting volume. This way quota will be available immediately. I am thinking this will be simple solution instead of creating new ecosystem. May to check if it solves your problem. Please find below documentations for quota delete.\nquota-off\nTurns the quota subsystem off for a volume.\nFor clustered volumes, a jobid will also be returned. The progress of the job can be tracked using the job APIs.","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4354bbc1ea5eece11ac0a05132daa99ce98b9f7a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for share/share-snapshot deferred deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During delete, free the used share/share-snapshot quotas immediately"},{"line_number":10,"context_line":"and process deferred share/share-snapshot deletion in share manager."},{"line_number":11,"context_line":"This will reduce the waiting time of new share/share-snapshot creation"},{"line_number":12,"context_line":"blocked on quota limit."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"55b9fd73_93ba56a9","line":9,"in_reply_to":"59593f69_4c4547f0","updated":"2023-12-08 11:12:52.000000000","message":"An automated workflow where share deletion takes time on backend and quota is not available for user to create new shares. So we are freeing quota ASAP and performing deferred deletion in periodic callback.","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6b6433db3cef333ffc77536865dba389dd74f159","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for share/share-snapshot deferred deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During delete, free the used share/share-snapshot quotas immediately"},{"line_number":10,"context_line":"and process deferred share/share-snapshot deletion in share manager."},{"line_number":11,"context_line":"This will reduce the waiting time of new share/share-snapshot creation"},{"line_number":12,"context_line":"blocked on quota limit."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0081c896_27d70a8a","line":9,"in_reply_to":"8d0d859b_21f19311","updated":"2023-12-11 14:38:19.000000000","message":"The quota we are considering is Manila quota and not NetApp quota.\n\nwhen share is deleted from API and then from share backend, we wait for driver to confirm successful deletion and then only remove claimed quota of share. Since deletion of share on backend driver takes time and also sometimes goes in error state, the quota remain as it is and we wont be able to create new shares.\n\nTo solve this, we free the quota first and move the share to \u0027deleting_in_driver\u0027 state and then periodic function will delete those shares in backend driver. If all goes well, we are good since quota is already freed. If anything goes wrong, share will goes into \u0027deleting_in_driver_error\u0027 state which are visible to admin only. Then admin can cleanup those share from backend storage and delete via Manila API where they will be removed from DB.","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"a994b07389fe52afd870ea742500183eeed167a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9c6e1fa7_f7744061","updated":"2023-11-29 14:22:39.000000000","message":"Hi @Kiran, Thanks for working on the specs. Please see my comments inline. Cheers, Chuan","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"781faf20eea430b6c6d48c4e913679888bba56b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3015454_b84b7a2a","updated":"2023-12-07 11:31:24.000000000","message":"Thank you for taking up this feature. I am not able to find any ONTAP side limitation regarding quota assignment to share when quota associated volume being deleted. Also, ONTAP support Volume deletion in background. Command line has foregroud attribute which tell volume to delete in backgroud. Also, ZAPI volume-destroy-async can be used to delete volume in non-blocking way. I didn\u0027t find mirror implementation in Manila. Can you check if this helps. Also, Can you point to issue you are trying to solve(i.e. BUG or any other resources you have).","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9b9598d9821378626d2faad16caaad40409bd446","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"05ffc2ed_61e7f811","updated":"2023-12-11 04:45:20.000000000","message":"Thank you! Kiran for replay. I am not able to find any issue where quota s not available for share when other share is using or deleting. Also, find all quotas associated with volume and issue \"quota-off\" before deleting volume. This way quota will be available immediately. I am thinking this will be simple solution instead of creating new ecosystem. May to check if it solves your problem. Please find below documentations for quota delete.\nquota-off\nTurns the quota subsystem off for a volume.\nFor clustered volumes, a jobid will also be returned. The progress of the job can be tracked using the job APIs.","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c355f3668d694e60ce552c5e7d1fc2f7ba4a7341","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c4b65081_42cb8d2a","updated":"2023-12-14 08:48:58.000000000","message":"thanks for your change.\nLooks good, only two comments.","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34f450120446f57ecc810a998eba6028ce04f773","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a2876e6a_f4c51b9f","in_reply_to":"05ffc2ed_61e7f811","updated":"2023-12-18 12:13:19.000000000","message":"Done","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1128d9d5d1d83153dce5d1748d841c6bf0b347fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2a22b768_4b218942","updated":"2024-01-09 14:06:54.000000000","message":"Kiran, thank you for the spec... Added some minor comments inline, but lgtm overall","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"58abfc1b03d44f5e2190eba425986c09520faf87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3706aa01_69c08009","updated":"2024-01-21 21:03:21.000000000","message":"I\u0027m late to provide feedback here, but still noting this for posterity. Please feel free to address comments, or changes with a follow up patch, or during code reviews","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bee33ce6b3c31d153ad679f7349dc56f0e50478b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0ca56e4d_b7153c4e","updated":"2024-01-15 17:09:36.000000000","message":"LGTM, thank you for the updates","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d329ffa3ba0089125bf0b58173b3cf09cf0b5a1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0cd17f5c_285896c9","updated":"2024-01-16 01:01:28.000000000","message":"thanks for your change. let\u0027s merge this.","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"}],"specs/caracal/deferred_deletion.rst":[{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"a994b07389fe52afd870ea742500183eeed167a3","unresolved":true,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Manila share deferred deletion"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Blueprint: https://blueprints.launchpad.net/manila/+spec/deferred-deletion"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0122947c_b863cd65","line":8,"updated":"2023-11-29 14:22:39.000000000","message":"Can we extend the specs to other type of objects? For instance, share snapshots.","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f46b2008915f1fffb986041bb1f4d79ccfb87fd1","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Manila share deferred deletion"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Blueprint: https://blueprints.launchpad.net/manila/+spec/deferred-deletion"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cdb7a9d8_8c1ea5ef","line":8,"in_reply_to":"0122947c_b863cd65","updated":"2023-11-30 15:28:56.000000000","message":"Done","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"a994b07389fe52afd870ea742500183eeed167a3","unresolved":true,"context_lines":[{"line_number":21,"context_line":"share. The share deletion procedure finishes quickly in manila API service, on"},{"line_number":22,"context_line":"the other hand the backend driver takes time. The quota allocated to the share"},{"line_number":23,"context_line":"is not freed until share is deleted completely. This increases waiting time"},{"line_number":24,"context_line":"for creation of new share. Providing a way to release the quota immediately"},{"line_number":25,"context_line":"and perform deferred deletion will solve this issue."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c6097320_07623ebf","line":24,"updated":"2023-11-29 14:22:39.000000000","message":"I think that \"This increases waiting time of creation of new share\" is inaccurate. Creating a new share can be executed in parallel (as long as there is enough quota).","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"bbc71ab769beee464fc336fdb26d20a00a68ae98","unresolved":false,"context_lines":[{"line_number":21,"context_line":"share. The share deletion procedure finishes quickly in manila API service, on"},{"line_number":22,"context_line":"the other hand the backend driver takes time. The quota allocated to the share"},{"line_number":23,"context_line":"is not freed until share is deleted completely. This increases waiting time"},{"line_number":24,"context_line":"for creation of new share. Providing a way to release the quota immediately"},{"line_number":25,"context_line":"and perform deferred deletion will solve this issue."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e18f5eff_bff2d1d1","line":24,"in_reply_to":"6a1543da_b759097e","updated":"2023-12-06 13:12:57.000000000","message":"Done","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f46b2008915f1fffb986041bb1f4d79ccfb87fd1","unresolved":true,"context_lines":[{"line_number":21,"context_line":"share. The share deletion procedure finishes quickly in manila API service, on"},{"line_number":22,"context_line":"the other hand the backend driver takes time. The quota allocated to the share"},{"line_number":23,"context_line":"is not freed until share is deleted completely. This increases waiting time"},{"line_number":24,"context_line":"for creation of new share. Providing a way to release the quota immediately"},{"line_number":25,"context_line":"and perform deferred deletion will solve this issue."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fea965d4_30ad069e","line":24,"in_reply_to":"c6097320_07623ebf","updated":"2023-11-30 15:28:56.000000000","message":"yes, but if its quota is full and you delete+create share parallel, this will block until delete finishes successfully and release quota. the deferred deletion will release quota immediately so that create wont block on quota availability.","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"4ee578099f4d2d8ac0b0348a50ef11437cd88414","unresolved":true,"context_lines":[{"line_number":21,"context_line":"share. The share deletion procedure finishes quickly in manila API service, on"},{"line_number":22,"context_line":"the other hand the backend driver takes time. The quota allocated to the share"},{"line_number":23,"context_line":"is not freed until share is deleted completely. This increases waiting time"},{"line_number":24,"context_line":"for creation of new share. Providing a way to release the quota immediately"},{"line_number":25,"context_line":"and perform deferred deletion will solve this issue."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6a1543da_b759097e","line":24,"in_reply_to":"fea965d4_30ad069e","updated":"2023-11-30 15:54:07.000000000","message":"I agree that deferring deletion will accelerate the deletion. But creating share would fail if quota is full. That\u0027s why I think it is not accurate to say \"waiting time of creation\", because the creating requests are either accepted or rejected immediately.","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"a994b07389fe52afd870ea742500183eeed167a3","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* The user want to delete share and check the available share and share"},{"line_number":34,"context_line":"  gigabytes quota."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8dae8fee_1b11b284","line":35,"updated":"2023-11-29 14:22:39.000000000","message":"The use case affected us is the automated workflows, where deleting a share is an intermediate step. Usually the process is to trigger the share deletion and waits until it is deleted. Defer deletion allows automation to proceed without waiting for driver.","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f46b2008915f1fffb986041bb1f4d79ccfb87fd1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* The user want to delete share and check the available share and share"},{"line_number":34,"context_line":"  gigabytes quota."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2c45ecdb_05663eb2","line":35,"in_reply_to":"8dae8fee_1b11b284","updated":"2023-11-30 15:28:56.000000000","message":"Done","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"a994b07389fe52afd870ea742500183eeed167a3","unresolved":true,"context_lines":[{"line_number":51,"context_line":"  will be moved to \u0027DELETING_IN_DRIVER\u0027 state. A periodic task will be added"},{"line_number":52,"context_line":"  in share manager, which gets all share instances in \u0027DELETING_IN_DRIVER\u0027"},{"line_number":53,"context_line":"  state. The share manager then calls backend driver to delete the share"},{"line_number":54,"context_line":"  instance. Any failure during deletion, will move share instance in the"},{"line_number":55,"context_line":"  \u0027DELETING_IN_DRIVER_ERROR\u0027 state. User can delete the shares in"},{"line_number":56,"context_line":"  \u0027DELETING_IN_DRIVER_ERROR\u0027 state, but this time quota will not be reclaimed."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"20070283_ffea9bd8","line":54,"updated":"2023-11-29 14:22:39.000000000","message":"suggestion:\nThe share manager then ... to delete the share instance and move it to \u0027DELETED\u0027 state.","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f46b2008915f1fffb986041bb1f4d79ccfb87fd1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  will be moved to \u0027DELETING_IN_DRIVER\u0027 state. A periodic task will be added"},{"line_number":52,"context_line":"  in share manager, which gets all share instances in \u0027DELETING_IN_DRIVER\u0027"},{"line_number":53,"context_line":"  state. The share manager then calls backend driver to delete the share"},{"line_number":54,"context_line":"  instance. Any failure during deletion, will move share instance in the"},{"line_number":55,"context_line":"  \u0027DELETING_IN_DRIVER_ERROR\u0027 state. User can delete the shares in"},{"line_number":56,"context_line":"  \u0027DELETING_IN_DRIVER_ERROR\u0027 state, but this time quota will not be reclaimed."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"269a318d_58cac12d","line":54,"in_reply_to":"20070283_ffea9bd8","updated":"2023-11-30 15:28:56.000000000","message":"Done","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"a994b07389fe52afd870ea742500183eeed167a3","unresolved":true,"context_lines":[{"line_number":86,"context_line":"REST API impact"},{"line_number":87,"context_line":"---------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"None"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Driver impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4811dd99_ad4764d1","line":89,"updated":"2023-11-29 14:22:39.000000000","message":"we could exclude the shares in \u0027DELETING_IN_DRIVER[_ERROR]\u0027 while listing for ordinary users, and include them for admins?","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f46b2008915f1fffb986041bb1f4d79ccfb87fd1","unresolved":true,"context_lines":[{"line_number":86,"context_line":"REST API impact"},{"line_number":87,"context_line":"---------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"None"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Driver impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d585e445_7195d02e","line":89,"in_reply_to":"4811dd99_ad4764d1","updated":"2023-11-30 15:28:56.000000000","message":"if we are showing shares in DELETING_ERROR state to ordinary users, I believe we should be ok with \u0027DELETING_IN_DRIVER_ERROR\u0027 to ordinary user as well.","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"bbc71ab769beee464fc336fdb26d20a00a68ae98","unresolved":false,"context_lines":[{"line_number":86,"context_line":"REST API impact"},{"line_number":87,"context_line":"---------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"None"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Driver impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"645ebd55_5ab0748a","line":89,"in_reply_to":"92aedada_a8a109c8","updated":"2023-12-06 13:12:57.000000000","message":"Done","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"4ee578099f4d2d8ac0b0348a50ef11437cd88414","unresolved":true,"context_lines":[{"line_number":86,"context_line":"REST API impact"},{"line_number":87,"context_line":"---------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"None"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Driver impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"92aedada_a8a109c8","line":89,"in_reply_to":"d585e445_7195d02e","updated":"2023-11-30 15:54:07.000000000","message":"yes, shares in \u0027DELETING_ERROR\u0027 states should be shown to all users, because they can react to such errors, like cleaning up them. But for those in \u0027DELETING_IN_DRIVER_ERROR\u0027, non-admin users can\u0027t really do anything to fix them. So I feel it might be reasonable to hide them. But that\u0027s just my 2ct.","commit_id":"3691dc36b3d8a06effb18c7e2e438a534ce6f124"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"13814b02cc3099f50a21e0a2a8b07ebef66f1784","unresolved":true,"context_lines":[{"line_number":27,"context_line":"share snapshot. Providing a way to release the quota immediately and perform"},{"line_number":28,"context_line":"deferred deletion will solve this issue. Also automated workflows face problem"},{"line_number":29,"context_line":"in creation of new shares and/or share snapshots where they have to wait until"},{"line_number":30,"context_line":"qupta is available after share or share snapshot is deleted by backend driver."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Use Cases"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"81697240_ca863d1d","line":30,"updated":"2023-12-08 08:49:13.000000000","message":"\"qupta\", change it to \"quota\"","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4354bbc1ea5eece11ac0a05132daa99ce98b9f7a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"share snapshot. Providing a way to release the quota immediately and perform"},{"line_number":28,"context_line":"deferred deletion will solve this issue. Also automated workflows face problem"},{"line_number":29,"context_line":"in creation of new shares and/or share snapshots where they have to wait until"},{"line_number":30,"context_line":"qupta is available after share or share snapshot is deleted by backend driver."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Use Cases"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"38bed00a_e5e54fde","line":30,"in_reply_to":"81697240_ca863d1d","updated":"2023-12-08 11:12:52.000000000","message":"Done","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"13814b02cc3099f50a21e0a2a8b07ebef66f1784","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted, the quota will be reclaimed"},{"line_number":57,"context_line":"  and share/share-snapshot instance will be moved to \u0027DELETING_IN_DRIVER\u0027"},{"line_number":58,"context_line":"  state. A periodic task will be added in share manager, which gets all share"},{"line_number":59,"context_line":"  instances in \u0027DELETING_IN_DRIVER\u0027 state. The share manager then calls backend"},{"line_number":60,"context_line":"  driver to delete the share/share-snapshot instance and move it to \u0027DELETED\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dcffade6_59223d79","line":57,"updated":"2023-12-08 08:49:13.000000000","message":"Once share or share snapshot is in \u0027DELETING_IN_DRIVER\u0027 state, in this case delete API or CLI should be failed with proper error (API or CLI should be failed while validating the the API or CLI at API layer). Hope this will be handled in code.","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4354bbc1ea5eece11ac0a05132daa99ce98b9f7a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted, the quota will be reclaimed"},{"line_number":57,"context_line":"  and share/share-snapshot instance will be moved to \u0027DELETING_IN_DRIVER\u0027"},{"line_number":58,"context_line":"  state. A periodic task will be added in share manager, which gets all share"},{"line_number":59,"context_line":"  instances in \u0027DELETING_IN_DRIVER\u0027 state. The share manager then calls backend"},{"line_number":60,"context_line":"  driver to delete the share/share-snapshot instance and move it to \u0027DELETED\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8dd94107_ef3c9a6d","line":57,"in_reply_to":"dcffade6_59223d79","updated":"2023-12-08 11:12:52.000000000","message":"mentioned.","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"13814b02cc3099f50a21e0a2a8b07ebef66f1784","unresolved":true,"context_lines":[{"line_number":60,"context_line":"  driver to delete the share/share-snapshot instance and move it to \u0027DELETED\u0027"},{"line_number":61,"context_line":"  state. Any failure during deletion, will move share/share-snapshot instance"},{"line_number":62,"context_line":"  in the \u0027DELETING_IN_DRIVER_ERROR\u0027 state. Admin can delete the shares"},{"line_number":63,"context_line":"  and share-snapshots in \u0027DELETING_IN_DRIVER_ERROR\u0027 state, but this time quota"},{"line_number":64,"context_line":"  will not be reclaimed."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* No change in backend driver."}],"source_content_type":"text/x-rst","patch_set":3,"id":"df177322_fff89acf","line":63,"updated":"2023-12-08 08:49:13.000000000","message":"Once share or share snapshot status is in \u0027DELETING_IN_DRIVER_ERROR\u0027 state, so in that case admin can delete share/snapshot by running the OpenStack delete API or admin has to login into storage device and clean these backend storage, and then later on periodic job in share manager remove the these share/snapshot entry from db...?","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4354bbc1ea5eece11ac0a05132daa99ce98b9f7a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  driver to delete the share/share-snapshot instance and move it to \u0027DELETED\u0027"},{"line_number":61,"context_line":"  state. Any failure during deletion, will move share/share-snapshot instance"},{"line_number":62,"context_line":"  in the \u0027DELETING_IN_DRIVER_ERROR\u0027 state. Admin can delete the shares"},{"line_number":63,"context_line":"  and share-snapshots in \u0027DELETING_IN_DRIVER_ERROR\u0027 state, but this time quota"},{"line_number":64,"context_line":"  will not be reclaimed."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* No change in backend driver."}],"source_content_type":"text/x-rst","patch_set":3,"id":"a3caf6a8_e1adfe20","line":63,"in_reply_to":"df177322_fff89acf","updated":"2023-12-08 11:12:52.000000000","message":"Done","commit_id":"edc83ae0ebdbd7451dff4ff873c268daccae9fdb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c355f3668d694e60ce552c5e7d1fc2f7ba4a7341","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"},{"line_number":58,"context_line":"  \u0027DELETING_IN_DRIVER\u0027 state. Any delete request on share/share-snapshot while"},{"line_number":59,"context_line":"  it is in \u0027DELETING_IN_DRIVER\u0027 state, will return error."},{"line_number":60,"context_line":"  A periodic task will be added in share manager, which gets all share"},{"line_number":61,"context_line":"  instances in \u0027DELETING_IN_DRIVER\u0027 state. The share manager, will then call"},{"line_number":62,"context_line":"  backend driver to delete the share/share-snapshot instance and move it"},{"line_number":63,"context_line":"  to \u0027DELETED\u0027 state on successful deletion. Any failure during deletion, will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"74b57657_65aeb1fc","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":17},"updated":"2023-12-14 08:48:58.000000000","message":"How long are you going to set the interval between periodic tasks?","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6986efe22fe6b8b2b0c1a419ca028aad6874d815","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"},{"line_number":58,"context_line":"  \u0027DELETING_IN_DRIVER\u0027 state. Any delete request on share/share-snapshot while"},{"line_number":59,"context_line":"  it is in \u0027DELETING_IN_DRIVER\u0027 state, will return error."},{"line_number":60,"context_line":"  A periodic task will be added in share manager, which gets all share"},{"line_number":61,"context_line":"  instances in \u0027DELETING_IN_DRIVER\u0027 state. The share manager, will then call"},{"line_number":62,"context_line":"  backend driver to delete the share/share-snapshot instance and move it"},{"line_number":63,"context_line":"  to \u0027DELETED\u0027 state on successful deletion. Any failure during deletion, will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fed35db_0dea5577","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":17},"in_reply_to":"2b14531f_219bf23c","updated":"2023-12-18 09:44:32.000000000","message":"In my opinion, backend storage cleanup is not particularly time-sensitive. I think 300s is fine.","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34f450120446f57ecc810a998eba6028ce04f773","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"},{"line_number":58,"context_line":"  \u0027DELETING_IN_DRIVER\u0027 state. Any delete request on share/share-snapshot while"},{"line_number":59,"context_line":"  it is in \u0027DELETING_IN_DRIVER\u0027 state, will return error."},{"line_number":60,"context_line":"  A periodic task will be added in share manager, which gets all share"},{"line_number":61,"context_line":"  instances in \u0027DELETING_IN_DRIVER\u0027 state. The share manager, will then call"},{"line_number":62,"context_line":"  backend driver to delete the share/share-snapshot instance and move it"},{"line_number":63,"context_line":"  to \u0027DELETED\u0027 state on successful deletion. Any failure during deletion, will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ef48968_0cf256d0","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":17},"in_reply_to":"3fed35db_0dea5577","updated":"2023-12-18 12:13:19.000000000","message":"Done","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"90fc0dbc36c197bf226a0b722334e92af5cb69fd","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"},{"line_number":58,"context_line":"  \u0027DELETING_IN_DRIVER\u0027 state. Any delete request on share/share-snapshot while"},{"line_number":59,"context_line":"  it is in \u0027DELETING_IN_DRIVER\u0027 state, will return error."},{"line_number":60,"context_line":"  A periodic task will be added in share manager, which gets all share"},{"line_number":61,"context_line":"  instances in \u0027DELETING_IN_DRIVER\u0027 state. The share manager, will then call"},{"line_number":62,"context_line":"  backend driver to delete the share/share-snapshot instance and move it"},{"line_number":63,"context_line":"  to \u0027DELETED\u0027 state on successful deletion. Any failure during deletion, will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"2b14531f_219bf23c","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":17},"in_reply_to":"74b57657_65aeb1fc","updated":"2023-12-14 11:20:11.000000000","message":"120 seconds. What do you suggest ?","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c355f3668d694e60ce552c5e7d1fc2f7ba4a7341","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  backend driver to delete the share/share-snapshot instance and move it"},{"line_number":63,"context_line":"  to \u0027DELETED\u0027 state on successful deletion. Any failure during deletion, will"},{"line_number":64,"context_line":"  move share/share-snapshot instance in the \u0027DELETING_IN_DRIVER_ERROR\u0027 state."},{"line_number":65,"context_line":"  Only admin can list those shares and then delete/cleaup on stroeage. Admin"},{"line_number":66,"context_line":"  need to then the share/share-snapshot in \u0027DELETING_IN_DRIVER_ERROR\u0027 state,"},{"line_number":67,"context_line":"  where they are marked as \u0027DELETED\u0027."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* No change in backend driver."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"81498204_34214912","line":67,"range":{"start_line":65,"start_character":71,"end_line":67,"end_character":37},"updated":"2023-12-14 08:48:58.000000000","message":"Sometimes, the deletion of a share instance fails due to network fluctuations or the temporary offline restart of the back-end storage. If the periodic task can retry to delete the share instance in the \u0027DELETING_IN_DRIVER_ERROR\u0027 state, the deletion may be successful. We can\u0027t just try to delete once and then not try again, which would increase the workload of the administrator. The administrator can handle only the share instance that the driver cannot delete for many times.","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"90fc0dbc36c197bf226a0b722334e92af5cb69fd","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  backend driver to delete the share/share-snapshot instance and move it"},{"line_number":63,"context_line":"  to \u0027DELETED\u0027 state on successful deletion. Any failure during deletion, will"},{"line_number":64,"context_line":"  move share/share-snapshot instance in the \u0027DELETING_IN_DRIVER_ERROR\u0027 state."},{"line_number":65,"context_line":"  Only admin can list those shares and then delete/cleaup on stroeage. Admin"},{"line_number":66,"context_line":"  need to then the share/share-snapshot in \u0027DELETING_IN_DRIVER_ERROR\u0027 state,"},{"line_number":67,"context_line":"  where they are marked as \u0027DELETED\u0027."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* No change in backend driver."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"f81c4acf_12bf4b11","line":67,"range":{"start_line":65,"start_character":71,"end_line":67,"end_character":37},"in_reply_to":"81498204_34214912","updated":"2023-12-14 11:20:11.000000000","message":"that is correct. but then how long we should keep trying for deletion ? May be at max 30 minutes after last \u0027updated_at\u0027 field of share/share-snapshot instance ?","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34f450120446f57ecc810a998eba6028ce04f773","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  backend driver to delete the share/share-snapshot instance and move it"},{"line_number":63,"context_line":"  to \u0027DELETED\u0027 state on successful deletion. Any failure during deletion, will"},{"line_number":64,"context_line":"  move share/share-snapshot instance in the \u0027DELETING_IN_DRIVER_ERROR\u0027 state."},{"line_number":65,"context_line":"  Only admin can list those shares and then delete/cleaup on stroeage. Admin"},{"line_number":66,"context_line":"  need to then the share/share-snapshot in \u0027DELETING_IN_DRIVER_ERROR\u0027 state,"},{"line_number":67,"context_line":"  where they are marked as \u0027DELETED\u0027."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* No change in backend driver."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"e172fb07_3431300e","line":67,"range":{"start_line":65,"start_character":71,"end_line":67,"end_character":37},"in_reply_to":"e660ec8f_84e80805","updated":"2023-12-18 12:13:19.000000000","message":"Done","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6986efe22fe6b8b2b0c1a419ca028aad6874d815","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  backend driver to delete the share/share-snapshot instance and move it"},{"line_number":63,"context_line":"  to \u0027DELETED\u0027 state on successful deletion. Any failure during deletion, will"},{"line_number":64,"context_line":"  move share/share-snapshot instance in the \u0027DELETING_IN_DRIVER_ERROR\u0027 state."},{"line_number":65,"context_line":"  Only admin can list those shares and then delete/cleaup on stroeage. Admin"},{"line_number":66,"context_line":"  need to then the share/share-snapshot in \u0027DELETING_IN_DRIVER_ERROR\u0027 state,"},{"line_number":67,"context_line":"  where they are marked as \u0027DELETED\u0027."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* No change in backend driver."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"e660ec8f_84e80805","line":67,"range":{"start_line":65,"start_character":71,"end_line":67,"end_character":37},"in_reply_to":"f81c4acf_12bf4b11","updated":"2023-12-18 09:44:32.000000000","message":"I think we can try to delete it after 30 minutes as you said.\n\n    if share[\u0027status\u0027]\u003d\u003d\u0027DELETING_IN_DRIVER_ERROR\u0027:\n       interval \u003d now_time - last_updata_at\n       if interval \u003e 30mins:\n           try to delete again.","commit_id":"004c31aa93ddb0057abd94dc79b992d4fa7cfcd6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1128d9d5d1d83153dce5d1748d841c6bf0b347fe","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  intermediate step, have to wait until share/share-snapshot is deleted. Defer"},{"line_number":37,"context_line":"  deletion allows automation to proceed without waiting for driver."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The user want to delete share and check the available share and share"},{"line_number":40,"context_line":"  gigabytes quota."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"41b61de4_a176c015","line":40,"range":{"start_line":39,"start_character":56,"end_line":40,"end_character":18},"updated":"2024-01-09 14:06:54.000000000","message":"share, snapshot and their corresponding gigabytes quota.","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"31565b96bb19a86fe52ad7f8e1820ee167546370","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  intermediate step, have to wait until share/share-snapshot is deleted. Defer"},{"line_number":37,"context_line":"  deletion allows automation to proceed without waiting for driver."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The user want to delete share and check the available share and share"},{"line_number":40,"context_line":"  gigabytes quota."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7eaefdc7_de499c75","line":40,"range":{"start_line":39,"start_character":56,"end_line":40,"end_character":18},"in_reply_to":"41b61de4_a176c015","updated":"2024-01-10 10:25:27.000000000","message":"Done","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1128d9d5d1d83153dce5d1748d841c6bf0b347fe","unresolved":true,"context_lines":[{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  share are deleted in deferred deletion manner else if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7db60b7e_41cc7765","line":53,"range":{"start_line":53,"start_character":41,"end_line":53,"end_character":52},"updated":"2024-01-09 14:06:54.000000000","message":"manner, and if FALSE...","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1128d9d5d1d83153dce5d1748d841c6bf0b347fe","unresolved":true,"context_lines":[{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  share are deleted in deferred deletion manner else if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8706c307_8e5f35be","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":7},"updated":"2024-01-09 14:06:54.000000000","message":"shares","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"31565b96bb19a86fe52ad7f8e1820ee167546370","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  share are deleted in deferred deletion manner else if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"}],"source_content_type":"text/x-rst","patch_set":5,"id":"74927074_20e60dce","line":53,"range":{"start_line":53,"start_character":41,"end_line":53,"end_character":52},"in_reply_to":"7db60b7e_41cc7765","updated":"2024-01-10 10:25:27.000000000","message":"Done","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"31565b96bb19a86fe52ad7f8e1820ee167546370","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  share are deleted in deferred deletion manner else if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2810a9d2_46fa2378","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":7},"in_reply_to":"8706c307_8e5f35be","updated":"2024-01-10 10:25:27.000000000","message":"Done","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"35d37d3c58bd9b5619cac151802e370e525f1741","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  be introduced to identify share instances which will be processed in"},{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  share are deleted in deferred deletion manner else if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"},{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fe125a03_4516d704","line":54,"range":{"start_line":52,"start_character":2,"end_line":54,"end_character":43},"updated":"2023-12-19 06:00:36.000000000","message":"If user want to change the deletion mode with global configuration, user need to restart the service for the deletion mode to take effect. I even recommend adding a new parameter to delete share so that the user can decide whether to delay deletion or not. add a new micversion to support this. for example:\n\n    usage: openstack share delete [-h] [--share-group \u003cshare-group\u003e] [--force]\n                                  [--defer]\n                                  \u003cshare\u003e [\u003cshare\u003e ...]\n                                \nwhat do you think?","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4aaa0be99f6a05650254e976986cc0dd2daa05e1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  be introduced to identify share instances which will be processed in"},{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  share are deleted in deferred deletion manner else if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"},{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0ca3e5d7_c41a5aa9","line":54,"range":{"start_line":52,"start_character":2,"end_line":54,"end_character":43},"in_reply_to":"fe125a03_4516d704","updated":"2023-12-20 13:38:12.000000000","message":"yes, we can add --defer\u003dTRUE/FALSE, this will overwrite global configuration option.\ne..g if global set, all shares will be deleted in deferred manner unless share delete API request comes with --defer\u003dFALSE. Lets keep this out of spec for now and I will implement it in later patches.","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1128d9d5d1d83153dce5d1748d841c6bf0b347fe","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  delete them again after 30 minutes of previous attempt."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* No change in backend driver."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"4fa67f65_489bb312","line":72,"updated":"2024-01-09 14:06:54.000000000","message":"I believe the soft delete periodic task also should be modified in case of the default being the deferred deletion, right? I mean, it should set the status to deleting_in_driver and so on...","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bee33ce6b3c31d153ad679f7349dc56f0e50478b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  delete them again after 30 minutes of previous attempt."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* No change in backend driver."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"e4e15c34_d8ac893f","line":72,"in_reply_to":"3e5bcc2c_a432c0c9","updated":"2024-01-15 17:09:36.000000000","message":"Ack, thanks :)","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"31565b96bb19a86fe52ad7f8e1820ee167546370","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  delete them again after 30 minutes of previous attempt."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* No change in backend driver."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3e5bcc2c_a432c0c9","line":72,"in_reply_to":"4fa67f65_489bb312","updated":"2024-01-10 10:25:27.000000000","message":"soft deleted shares are just marked as \u0027soft_deleted\u0027 in db and after retention time out, they are actually deleted. the actual deletion will consider deferred deletion or not, based on config or default value. But it does not affect the core logic of soft deletion. The share_API.delete() should handle it.","commit_id":"eb620542b3e75b689fbefd1d86fdb6505e38827c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"58abfc1b03d44f5e2190eba425986c09520faf87","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The following are the changes to be made:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* A new status values \u0027DELETING_IN_DRIVER\u0027 and \u0027DELETING_IN_DRIVER_ERROR\u0027 will"},{"line_number":49,"context_line":"  be introduced to identify share instances which will be processed in"},{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5cd97fc8_cbb74f7e","line":48,"range":{"start_line":48,"start_character":48,"end_line":48,"end_character":72},"updated":"2024-01-21 21:03:21.000000000","message":"is this status required? \"error_deleting\" exists, and suffices imo. How is this different?","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"58abfc1b03d44f5e2190eba425986c09520faf87","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The following are the changes to be made:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* A new status values \u0027DELETING_IN_DRIVER\u0027 and \u0027DELETING_IN_DRIVER_ERROR\u0027 will"},{"line_number":49,"context_line":"  be introduced to identify share instances which will be processed in"},{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"230559c4_1736bbd7","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":41},"updated":"2024-01-21 21:03:21.000000000","message":"perhaps \"deferred_deleting\" is better here?","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fff7ab2176f5113047096d24b99bd8b4b4c41751","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The following are the changes to be made:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* A new status values \u0027DELETING_IN_DRIVER\u0027 and \u0027DELETING_IN_DRIVER_ERROR\u0027 will"},{"line_number":49,"context_line":"  be introduced to identify share instances which will be processed in"},{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"c324013c_a5221ec5","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":41},"in_reply_to":"230559c4_1736bbd7","updated":"2024-01-22 05:40:08.000000000","message":"Done","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fff7ab2176f5113047096d24b99bd8b4b4c41751","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The following are the changes to be made:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* A new status values \u0027DELETING_IN_DRIVER\u0027 and \u0027DELETING_IN_DRIVER_ERROR\u0027 will"},{"line_number":49,"context_line":"  be introduced to identify share instances which will be processed in"},{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"a2a8b7fa_bcf64e02","line":48,"range":{"start_line":48,"start_character":48,"end_line":48,"end_character":72},"in_reply_to":"5cd97fc8_cbb74f7e","updated":"2024-01-22 05:40:08.000000000","message":"error_deleting is something user can see and reset to error and try for deletion again. Error_deferred_deleting shares wont be listed in share list command since their quota is already claimed.\n1. Admin can delete them where they will be removed directly from DB\n2. Or periodic task checking for shares deferred_deleting also will check for error_deferred_deleting (updated before \u003e 30 mins) and tries to ask driver to delete again.\n\nin short error_deferred_deleting is a state where only admin can see those shares and delete (if want else periodic task also take care of it)","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"58abfc1b03d44f5e2190eba425986c09520faf87","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  be introduced to identify share instances which will be processed in"},{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  shares are deleted in deferred deletion manner, and if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7803d3ad_55a8bb36","line":52,"range":{"start_line":52,"start_character":32,"end_line":52,"end_character":49},"updated":"2024-01-21 21:03:21.000000000","message":"a boolean configuration option like this should be named with a prefix \"is_\" and a suffix if the option is to turn something on\n\nperhaps:\n\n\"is_deferred_deletion_enabled\"","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fff7ab2176f5113047096d24b99bd8b4b4c41751","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  be introduced to identify share instances which will be processed in"},{"line_number":50,"context_line":"  deferred deletion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  shares are deleted in deferred deletion manner, and if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"efcc4fde_93a9d6d5","line":52,"range":{"start_line":52,"start_character":32,"end_line":52,"end_character":49},"in_reply_to":"7803d3ad_55a8bb36","updated":"2024-01-22 05:40:08.000000000","message":"Done","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"58abfc1b03d44f5e2190eba425986c09520faf87","unresolved":true,"context_lines":[{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  shares are deleted in deferred deletion manner, and if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"},{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"},{"line_number":58,"context_line":"  \u0027DELETING_IN_DRIVER\u0027 state. Any delete request on share/share-snapshot while"}],"source_content_type":"text/x-rst","patch_set":6,"id":"252e837c_f7d3aeb2","line":55,"updated":"2024-01-21 21:03:21.000000000","message":"what really is the advantage of not sending a deletion request to the backend right away? \n\ni don\u0027t mind the introduction of a loop.. but i thought the purpose of this originally was really about giving backends a way to take time on deletion without blocking the share manager\u0027s call. \n\n\ndeletion in the backend may be an asynchronous process.. today, we are expecting the drivers to delete shares and snapshots in a synchronous manner, or, atleast pretend to do that.. \n\n\nat the PTG, we discussed the following workflow:\n\n1) User deletes a share\n2) API request goes to the share manager, share manager asks the driver to process deletion\n3) Driver says it needs more time\n4) Share manager sets the share\u0027s status to an internal state (user still sees \"deleting\" in the API...)\n5) Quota is released\n6) share manager periodically asks the driver to delete the share, driver can continue to tell the share manager that it needs more time... eventually, if the driver sees that the share is deleted, it can tell the share manager so, and the share manager cleans up the database records.\n\n\n\nIn this spec, you\u0027re proposing a global config opt that allows users to immediately regain quota, and deferred deletions are still synchronous/atomic between the manager and the driver.\n\nI don\u0027t particularly have a problem with regaining quota immediately, but, I was hoping we\u0027d address the synchronicity issue of the deletion in the driver.","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d584ee265bd50a12664e982839e2e2c5a8d4e179","unresolved":true,"context_lines":[{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  shares are deleted in deferred deletion manner, and if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"},{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"},{"line_number":58,"context_line":"  \u0027DELETING_IN_DRIVER\u0027 state. Any delete request on share/share-snapshot while"}],"source_content_type":"text/x-rst","patch_set":6,"id":"94a15414_86235d69","line":55,"in_reply_to":"1116b838_7dbff72e","updated":"2024-01-23 00:55:36.000000000","message":"Yes; I get (and support) the aspect of releasing quota immediately. However, wouldn\u0027t it make your implementation easier too if you allowed for deferred deletion to be requested by the driver?\n\n\u003e 1. driver now first calculate/decide whether it needs more time or not.\n\nYes. This is crucial.. Today, there\u0027s no such mechanism. If a driver figures out that deletion will take time, it just has to implement a loop and wait. This causes a thread in the share manager/driver process to be wasted on waiting. An example is the NetApp driver canceling clone splits and waiting on clone split cancelation.. instead, if the driver saw that a share was busy with clone split, it could either return and wait for clone split to complete, or, cancel the clone split, and return to the share manager and wait for the deletion request to come again to retry deleting the share. \n\n\n\u003e 2. Even if driver replies that no more time is needed, there is no guarantee that driver wont take more time.\n\n\nHmm this is true. We improved the \"create_share\" workflow in a past release to optionally become a two-step workflow. This allowed drivers to become more efficient. For example, the NetApp and CephFS drivers create shares from snapshot in a deferred way using this two step approach. It\u0027s a design enhancement that we can reap benefits of, over time. \n\n\u003e 3. If driver says it needs more time, we are anyways releasing quota at point 5). then why wait for driver to respond for time, just release quota and let driver handle deletion in its own time.\n\n\nDoing this allows you to reuse existing code instead of adding code in the API layer to release quota.","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fff7ab2176f5113047096d24b99bd8b4b4c41751","unresolved":true,"context_lines":[{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  shares are deleted in deferred deletion manner, and if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"},{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"},{"line_number":58,"context_line":"  \u0027DELETING_IN_DRIVER\u0027 state. Any delete request on share/share-snapshot while"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1116b838_7dbff72e","line":55,"in_reply_to":"252e837c_f7d3aeb2","updated":"2024-01-22 05:40:08.000000000","message":"3) Driver says it needs more time\n\u003e The main motivation is to make share allocation available immediately which was blocked on availability of quota and also not block the share manager call. Share manager asking periodically status where driver needs more time to delete or not seems bit overhead to me. \n1. driver now first calculate/decide whether it needs more time or not. \n2. Even if driver replies that no more time is needed, there is no guarantee that driver wont take more time.\n3. If driver says it needs more time, we are anyways releasing quota at point 5). then why wait for driver to respond for time, just release quota and let driver handle deletion in its own time.\n\nOn the other hand, the process we are following here is simple, where quota will be available immediately and background periodic task will handle cleanup.","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c92ce719da74b85b698339128ebb869eb968ffaf","unresolved":true,"context_lines":[{"line_number":52,"context_line":"* Add new configuration option \u0027deferred_deletion\u0027, which means if TRUE the"},{"line_number":53,"context_line":"  shares are deleted in deferred deletion manner, and if FALSE the share will"},{"line_number":54,"context_line":"  be deleted the way it is happening today."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* As soon as share or share-snapshot is deleted by API request, the quota will"},{"line_number":57,"context_line":"  be reclaimed and share/share-snapshot instance will be moved to"},{"line_number":58,"context_line":"  \u0027DELETING_IN_DRIVER\u0027 state. Any delete request on share/share-snapshot while"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f38d2ba9_42acc51f","line":55,"in_reply_to":"94a15414_86235d69","updated":"2024-02-01 14:14:52.000000000","message":"This will be more like synchronised-deletion and not deferred deletion. We need to consider it as separate feature and implement accordingly i.e. two-step workflow for deletion. The actual use-case for us here is to free quota immediately and continue deletion in backgroud.","commit_id":"8521b194e420ef7de057ee72c52e531561230d65"}]}