)]}'
{"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9f47776b3be4019bdd220c2d56954df27ea1c96","unresolved":false,"context_lines":[{"line_number":30,"context_line":"               help\u003d\"The minimum api microversion is configured to be the \""},{"line_number":31,"context_line":"                    \"value of the minimum microversion supported by Manila.\"),"},{"line_number":32,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":33,"context_line":"               default\u003d\"2.43\","},{"line_number":34,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":35,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":36,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_60703109","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":28},"updated":"2018-04-24 22:13:51.000000000","message":"44","commit_id":"9c0819723a763184004e30f2ceb6a70c04da8457"}],"manila_tempest_tests/tests/api/test_security_services.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1ea34a064836672a3a2dc2699f130783b483874","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self.shares_client.delete_security_service(ss[\"id\"])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":155,"context_line":"    def test_get_security_service(self):"},{"line_number":156,"context_line":"        data \u003d self.generate_security_service_data()"},{"line_number":157,"context_line":"        ss \u003d self.create_security_service(**data)"},{"line_number":158,"context_line":"        self.assertDictContainsSubset(data, ss)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        get \u003d self.shares_client.get_security_service(ss[\"id\"])"},{"line_number":161,"context_line":"        self.assertDictContainsSubset(data, get)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":164,"context_line":"    @ddt.data(*set([\u00271.0\u0027, \u00272.42\u0027, \u00272.44\u0027, LATEST_MICROVERSION]))"},{"line_number":165,"context_line":"    def test_get_security_service_with_ou(self, version):"},{"line_number":166,"context_line":"        with_ou \u003d True if utils.is_microversion_ge(version, \u00272.44\u0027) else False"},{"line_number":167,"context_line":"        data \u003d self.generate_security_service_data(set_ou\u003dwith_ou)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_56671b25","line":165,"range":{"start_line":155,"start_character":0,"end_line":165,"end_character":57},"updated":"2018-06-25 02:24:49.000000000","message":"The test_get_security_service_with_ou test include test_get_security_service test, it looks like a little duplicate. The test_get_security_service test could just be removed.The test_get_security_service_with_ou test not only test \u0027ou\u0027,  we could change test_get_security_service_with_ou to test_get_security_service","commit_id":"b357c738b04a0cae193f702056726d5bfa62bf4f"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"e389ed4b22ab975c667923ef9f3614a239628695","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            self.shares_client.delete_security_service(ss[\"id\"])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":155,"context_line":"    def test_get_security_service(self):"},{"line_number":156,"context_line":"        data \u003d self.generate_security_service_data()"},{"line_number":157,"context_line":"        ss \u003d self.create_security_service(**data)"},{"line_number":158,"context_line":"        self.assertDictContainsSubset(data, ss)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        get \u003d self.shares_client.get_security_service(ss[\"id\"])"},{"line_number":161,"context_line":"        self.assertDictContainsSubset(data, get)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":164,"context_line":"    @ddt.data(*set([\u00271.0\u0027, \u00272.42\u0027, \u00272.44\u0027, LATEST_MICROVERSION]))"},{"line_number":165,"context_line":"    def test_get_security_service_with_ou(self, version):"},{"line_number":166,"context_line":"        with_ou \u003d True if utils.is_microversion_ge(version, \u00272.44\u0027) else False"},{"line_number":167,"context_line":"        data \u003d self.generate_security_service_data(set_ou\u003dwith_ou)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2f68fe1e","line":165,"range":{"start_line":155,"start_character":0,"end_line":165,"end_character":57},"in_reply_to":"5f7c97a3_56671b25","updated":"2018-06-25 06:06:34.000000000","message":"Done","commit_id":"b357c738b04a0cae193f702056726d5bfa62bf4f"}]}