)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b094c65dc01ad36423d5d15e6d317a625ecbf79d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-07-09 09:55:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest test for share access metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia794e1b13fec092b139c4859af48159869d6869e"},{"line_number":10,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_73c48592","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":0},"updated":"2018-07-09 16:07:12.000000000","message":"Depends-On: https://review.openstack.org/#/c/570708/","commit_id":"41e02d859bf5463bdb4059786fe0411eb47dde6f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b094c65dc01ad36423d5d15e6d317a625ecbf79d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add tempest test for share access metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia794e1b13fec092b139c4859af48159869d6869e"},{"line_number":10,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_13d43146","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":2},"updated":"2018-07-09 16:07:12.000000000","message":"Partially-implements?","commit_id":"41e02d859bf5463bdb4059786fe0411eb47dde6f"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"b5feac885e91f6145dc45a8ec30dc8382825913a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest test for share access metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.openstack.org/#/c/570708/"},{"line_number":10,"context_line":"Change-Id: Ia794e1b13fec092b139c4859af48159869d6869e"},{"line_number":11,"context_line":"Partially-implements bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f7c97a3_9700b1b3","line":9,"updated":"2018-07-14 01:16:56.000000000","message":"Shouldn\u0027t this be I2f2b3325a09e5af7f7c4e4fa3443259fb69f9771 ?","commit_id":"5461816b19cc21e4e4d482d9a58b4b8fa5e37cf5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d9f8e48bf3ac40c84aa6c5ffaf451e0655826cdf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest test for share access metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.openstack.org/#/c/570708/"},{"line_number":10,"context_line":"Change-Id: Ia794e1b13fec092b139c4859af48159869d6869e"},{"line_number":11,"context_line":"Partially-implements bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f7c97a3_6aafc47b","line":9,"in_reply_to":"5f7c97a3_1b3d9f8d","updated":"2018-07-18 23:21:15.000000000","message":"No, see: https://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies\n\nand \n\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-January/126535.html","commit_id":"5461816b19cc21e4e4d482d9a58b4b8fa5e37cf5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8e893d241968e3a2020aef9e41033686633cf0f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest test for share access metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.openstack.org/#/c/570708/"},{"line_number":10,"context_line":"Change-Id: Ia794e1b13fec092b139c4859af48159869d6869e"},{"line_number":11,"context_line":"Partially-implements bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5f7c97a3_1b3d9f8d","line":9,"in_reply_to":"5f7c97a3_9700b1b3","updated":"2018-07-16 01:30:38.000000000","message":"Done","commit_id":"5461816b19cc21e4e4d482d9a58b4b8fa5e37cf5"}],"manila_tempest_tests/services/__init__.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"ae06dd12b0d94d67cc7316500d606b42e9d055d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5f7c97a3_176fc193","line":1,"updated":"2018-07-14 01:15:54.000000000","message":"I don\u0027t think this file needs the +x mode","commit_id":"5461816b19cc21e4e4d482d9a58b4b8fa5e37cf5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8e893d241968e3a2020aef9e41033686633cf0f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5f7c97a3_bbdd8b6e","line":1,"in_reply_to":"5f7c97a3_176fc193","updated":"2018-07-16 01:30:38.000000000","message":"Done","commit_id":"5461816b19cc21e4e4d482d9a58b4b8fa5e37cf5"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":741,"context_line":"            }"},{"line_number":742,"context_line":"        }"},{"line_number":743,"context_line":"        if metadata is not None:"},{"line_number":744,"context_line":"            post_body[self._get_access_action_name("},{"line_number":745,"context_line":"                version, \u0027os-allow_access\u0027)][\u0027metadata\u0027] \u003d metadata"},{"line_number":746,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":747,"context_line":"        resp, body \u003d self.post("},{"line_number":748,"context_line":"            \"shares/%s/action\" % share_id, body, version\u003dversion,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_48a70baa","line":745,"range":{"start_line":744,"start_character":22,"end_line":745,"end_character":44},"updated":"2018-07-12 06:22:19.000000000","message":"os-allow_access is only allowed in API version \u003c\u003d 2.6\n\nSince metadata is being added in version 2.45, this should really say \u0027allow_access\u0027","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":741,"context_line":"            }"},{"line_number":742,"context_line":"        }"},{"line_number":743,"context_line":"        if metadata is not None:"},{"line_number":744,"context_line":"            post_body[self._get_access_action_name("},{"line_number":745,"context_line":"                version, \u0027os-allow_access\u0027)][\u0027metadata\u0027] \u003d metadata"},{"line_number":746,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":747,"context_line":"        resp, body \u003d self.post("},{"line_number":748,"context_line":"            \"shares/%s/action\" % share_id, body, version\u003dversion,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_e2471352","line":745,"range":{"start_line":744,"start_character":22,"end_line":745,"end_character":44},"in_reply_to":"5f7c97a3_48a70baa","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":760,"context_line":"                \"shares/%s/action\" % share_id, json.dumps(body),"},{"line_number":761,"context_line":"                version\u003dversion)"},{"line_number":762,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":763,"context_line":"        else:"},{"line_number":764,"context_line":"            metadata \u003d metadata or {}"},{"line_number":765,"context_line":"            params \u003d sorted("},{"line_number":766,"context_line":"                [(k, v) for (k, v) in list(metadata.items()) if v])"},{"line_number":767,"context_line":"            query_string \u003d \u0027\u0027"},{"line_number":768,"context_line":"            if params:"},{"line_number":769,"context_line":"                query_string \u003d \"\u0026%s\" % urlparse.urlencode(params)"},{"line_number":770,"context_line":"            url \u003d \u0027share-access-rules?share_id\u003d%s\u0027 % share_id + query_string"},{"line_number":771,"context_line":"            resp, body \u003d self.get(url, version\u003dversion)"},{"line_number":772,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":773,"context_line":"            return self._parse_resp(body)"},{"line_number":774,"context_line":"        return self._parse_resp(body)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def delete_access_rule(self, share_id, rule_id,"},{"line_number":777,"context_line":"                           version\u003dLATEST_MICROVERSION, action_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_28064f87","line":774,"range":{"start_line":763,"start_character":0,"end_line":774,"end_character":37},"updated":"2018-07-12 06:22:19.000000000","message":"a bit confusing what the intent is here, so please separate this into its own method and invoke that method from list_access_rules","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":760,"context_line":"                \"shares/%s/action\" % share_id, json.dumps(body),"},{"line_number":761,"context_line":"                version\u003dversion)"},{"line_number":762,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":763,"context_line":"        else:"},{"line_number":764,"context_line":"            metadata \u003d metadata or {}"},{"line_number":765,"context_line":"            params \u003d sorted("},{"line_number":766,"context_line":"                [(k, v) for (k, v) in list(metadata.items()) if v])"},{"line_number":767,"context_line":"            query_string \u003d \u0027\u0027"},{"line_number":768,"context_line":"            if params:"},{"line_number":769,"context_line":"                query_string \u003d \"\u0026%s\" % urlparse.urlencode(params)"},{"line_number":770,"context_line":"            url \u003d \u0027share-access-rules?share_id\u003d%s\u0027 % share_id + query_string"},{"line_number":771,"context_line":"            resp, body \u003d self.get(url, version\u003dversion)"},{"line_number":772,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":773,"context_line":"            return self._parse_resp(body)"},{"line_number":774,"context_line":"        return self._parse_resp(body)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def delete_access_rule(self, share_id, rule_id,"},{"line_number":777,"context_line":"                           version\u003dLATEST_MICROVERSION, action_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_82bdff04","line":774,"range":{"start_line":763,"start_character":0,"end_line":774,"end_character":37},"in_reply_to":"5f7c97a3_28064f87","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2cc449be8067eb99bfce79d60d8a924fb0585c6c","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                \"shares/%s/action\" % share_id, json.dumps(body),"},{"line_number":760,"context_line":"                version\u003dversion)"},{"line_number":761,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":762,"context_line":"        else:"},{"line_number":763,"context_line":"            url \u003d self._get_list_access_rules_url(share_id, metadata)"},{"line_number":764,"context_line":"            resp, body \u003d self.get(url, version\u003dversion)"},{"line_number":765,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":766,"context_line":"            return self._parse_resp(body)"},{"line_number":767,"context_line":"        return self._parse_resp(body)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def _get_list_access_rules_url(self, share_id, metadata):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_75c1694e","line":766,"range":{"start_line":762,"start_character":8,"end_line":766,"end_character":41},"updated":"2018-07-12 23:52:11.000000000","message":"moving this block into the method makes this cleaner:\n\n     else:\n         return list_access_rules_with_new_API(share_id, version\u003dversion,\n                          metadata\u003dmetadata, action_name\u003daction_name)\n      return self._parse_resp(body)","commit_id":"34b938eb08e35d73db081213e5598e5bf1092122"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b76aa5a381fa6697d2334180f0803843ddbd5523","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                \"shares/%s/action\" % share_id, json.dumps(body),"},{"line_number":760,"context_line":"                version\u003dversion)"},{"line_number":761,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":762,"context_line":"        else:"},{"line_number":763,"context_line":"            url \u003d self._get_list_access_rules_url(share_id, metadata)"},{"line_number":764,"context_line":"            resp, body \u003d self.get(url, version\u003dversion)"},{"line_number":765,"context_line":"            self.expected_success(200, resp.status)"},{"line_number":766,"context_line":"            return self._parse_resp(body)"},{"line_number":767,"context_line":"        return self._parse_resp(body)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def _get_list_access_rules_url(self, share_id, metadata):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_7d44ef73","line":766,"range":{"start_line":762,"start_character":8,"end_line":766,"end_character":41},"in_reply_to":"5f7c97a3_75c1694e","updated":"2018-07-13 01:56:49.000000000","message":"Done","commit_id":"34b938eb08e35d73db081213e5598e5bf1092122"}],"manila_tempest_tests/tests/api/test_access_rules_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a7c64656255c539838cefff2241302a0156df47b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        cls.access_to \u003d {"},{"line_number":62,"context_line":"            # list of unique values is required for ability to create lots"},{"line_number":63,"context_line":"            # of access rules for one share using different API microversions."},{"line_number":64,"context_line":"            \u0027ip\u0027: [\u002710.88.77.%d\u0027 % i for i in int_range],"},{"line_number":65,"context_line":"            # following users are fakes and access rules that use it are"},{"line_number":66,"context_line":"            # expected to fail, but they are used only for API testing."},{"line_number":67,"context_line":"            \u0027user\u0027: [\u0027foo_user_%d\u0027 % i for i in int_range],"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_6a0b447b","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":57},"updated":"2018-07-18 23:39:50.000000000","message":"use non-routable prefix, like the method added in Ica242007e77a7e21b2151e5fc32401b501d961b2","commit_id":"27f799ad67ef74e92cd6a5faddaee3c69ff6781a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4ba05898edd1d8ef9456aa2148c062ff8ace9d63","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        cls.access_to \u003d {"},{"line_number":62,"context_line":"            # list of unique values is required for ability to create lots"},{"line_number":63,"context_line":"            # of access rules for one share using different API microversions."},{"line_number":64,"context_line":"            \u0027ip\u0027: [\u002710.88.77.%d\u0027 % i for i in int_range],"},{"line_number":65,"context_line":"            # following users are fakes and access rules that use it are"},{"line_number":66,"context_line":"            # expected to fail, but they are used only for API testing."},{"line_number":67,"context_line":"            \u0027user\u0027: [\u0027foo_user_%d\u0027 % i for i in int_range],"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_fa929c54","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":57},"in_reply_to":"5f7c97a3_6a0b447b","updated":"2018-07-20 10:02:07.000000000","message":"Done","commit_id":"27f799ad67ef74e92cd6a5faddaee3c69ff6781a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a7c64656255c539838cefff2241302a0156df47b","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":78,"context_line":"    def test_set_get_delete_access_metadata(self):"},{"line_number":79,"context_line":"        data \u003d {u\"key1\": u\"v\" * 255, u\"k\" * 255: u\"value2\"}"},{"line_number":80,"context_line":"        # set metadata"},{"line_number":81,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("},{"line_number":82,"context_line":"            self.share[\"id\"], self.access_type,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_aa7abcec","line":79,"range":{"start_line":79,"start_character":16,"end_line":79,"end_character":58},"updated":"2018-07-18 23:39:50.000000000","message":"any particular reason for these to be unicode constants?","commit_id":"27f799ad67ef74e92cd6a5faddaee3c69ff6781a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4ba05898edd1d8ef9456aa2148c062ff8ace9d63","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":78,"context_line":"    def test_set_get_delete_access_metadata(self):"},{"line_number":79,"context_line":"        data \u003d {u\"key1\": u\"v\" * 255, u\"k\" * 255: u\"value2\"}"},{"line_number":80,"context_line":"        # set metadata"},{"line_number":81,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("},{"line_number":82,"context_line":"            self.share[\"id\"], self.access_type,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_658d9233","line":79,"range":{"start_line":79,"start_character":16,"end_line":79,"end_character":58},"in_reply_to":"5f7c97a3_aa7abcec","updated":"2018-07-20 10:02:07.000000000","message":"Done","commit_id":"27f799ad67ef74e92cd6a5faddaee3c69ff6781a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e84c1a796b354fa9d3684e6b5e5c693e37dbeee9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cls.access_to \u003d {"},{"line_number":63,"context_line":"            # list of unique values is required for ability to create lots"},{"line_number":64,"context_line":"            # of access rules for one share using different API microversions."},{"line_number":65,"context_line":"            \u0027ip\u0027: [utils.rand_ipv6_ip() for i in int_range],"},{"line_number":66,"context_line":"            # following users are fakes and access rules that use it are"},{"line_number":67,"context_line":"            # expected to fail, but they are used only for API testing."},{"line_number":68,"context_line":"            \u0027user\u0027: [\u0027foo_user_%d\u0027 % i for i in int_range],"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_bfdf2d65","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":59},"updated":"2018-07-20 15:26:24.000000000","message":"{}","commit_id":"ae10d08d47e38a3aabd7ec527cd547048bffcf6e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"02e58b7486072d7286ff0103dfa8a5596149efde","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cls.access_to \u003d {"},{"line_number":63,"context_line":"            # list of unique values is required for ability to create lots"},{"line_number":64,"context_line":"            # of access rules for one share using different API microversions."},{"line_number":65,"context_line":"            \u0027ip\u0027: [utils.rand_ipv6_ip() for i in int_range],"},{"line_number":66,"context_line":"            # following users are fakes and access rules that use it are"},{"line_number":67,"context_line":"            # expected to fail, but they are used only for API testing."},{"line_number":68,"context_line":"            \u0027user\u0027: [\u0027foo_user_%d\u0027 % i for i in int_range],"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_42507e09","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":59},"in_reply_to":"5f7c97a3_bfdf2d65","updated":"2018-07-20 15:58:37.000000000","message":"Done","commit_id":"ae10d08d47e38a3aabd7ec527cd547048bffcf6e"}],"manila_tempest_tests/tests/api/test_accesses_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5f7c97a3_282bafea","updated":"2018-07-12 06:22:19.000000000","message":"file name suggestion \u003d test_access_rule_metadata.py","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5f7c97a3_6efa0fbb","in_reply_to":"5f7c97a3_282bafea","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from manila_tempest_tests import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@base.skip_if_microversion_lt(constants.MIN_SHARE_GROUP_MICROVERSION)"},{"line_number":25,"context_line":"@ddt.ddt"},{"line_number":26,"context_line":"class AccessesMetadataTest(base.BaseSharesTest):"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_c82f9bf3","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":68},"updated":"2018-07-12 06:22:19.000000000","message":"?","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from manila_tempest_tests import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@base.skip_if_microversion_lt(constants.MIN_SHARE_GROUP_MICROVERSION)"},{"line_number":25,"context_line":"@ddt.ddt"},{"line_number":26,"context_line":"class AccessesMetadataTest(base.BaseSharesTest):"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_4efdd3b0","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":68},"in_reply_to":"5f7c97a3_c82f9bf3","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@base.skip_if_microversion_lt(constants.MIN_SHARE_GROUP_MICROVERSION)"},{"line_number":25,"context_line":"@ddt.ddt"},{"line_number":26,"context_line":"class AccessesMetadataTest(base.BaseSharesTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_8839a341","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":14},"updated":"2018-07-12 06:22:19.000000000","message":"AccessRules","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@base.skip_if_microversion_lt(constants.MIN_SHARE_GROUP_MICROVERSION)"},{"line_number":25,"context_line":"@ddt.ddt"},{"line_number":26,"context_line":"class AccessesMetadataTest(base.BaseSharesTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_0e291b39","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":14},"in_reply_to":"5f7c97a3_8839a341","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":34,"context_line":"    def test_set_metadata_in_access_creation(self):"},{"line_number":35,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # allow access with metadata"},{"line_number":38,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_48438bb1","line":35,"range":{"start_line":35,"start_character":52,"end_line":35,"end_character":54},"updated":"2018-07-12 06:22:19.000000000","message":"trailing comma not necessary if dict is not wrapped","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":34,"context_line":"    def test_set_metadata_in_access_creation(self):"},{"line_number":35,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # allow access with metadata"},{"line_number":38,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_ce224355","line":35,"range":{"start_line":35,"start_character":52,"end_line":35,"end_character":54},"in_reply_to":"5f7c97a3_48438bb1","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # allow access with metadata"},{"line_number":38,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("},{"line_number":39,"context_line":"            self.share[\"id\"], \"ip\", utils.rand_ip(), \"rw\", metadata\u003dmd)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # get metadata of access"},{"line_number":42,"context_line":"        get_access \u003d self.shares_v2_client.get_access(access[\"id\"])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_28140f9f","line":39,"range":{"start_line":38,"start_character":8,"end_line":39,"end_character":71},"updated":"2018-07-12 06:22:19.000000000","message":"What about CIFS/CEPH/Gluster drivers, please see how these tests are separated in test_rules.py","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # allow access with metadata"},{"line_number":38,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("},{"line_number":39,"context_line":"            self.share[\"id\"], \"ip\", utils.rand_ip(), \"rw\", metadata\u003dmd)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # get metadata of access"},{"line_number":42,"context_line":"        get_access \u003d self.shares_v2_client.get_access(access[\"id\"])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_d8b208e9","line":39,"range":{"start_line":38,"start_character":8,"end_line":39,"end_character":71},"in_reply_to":"5f7c97a3_28140f9f","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":48,"context_line":"    def test_set_get_delete_access_metadata(self):"},{"line_number":49,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # set metadata"},{"line_number":52,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_481cebc1","line":49,"range":{"start_line":49,"start_character":52,"end_line":49,"end_character":53},"updated":"2018-07-12 06:22:19.000000000","message":"remove trailing comma","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":48,"context_line":"    def test_set_get_delete_access_metadata(self):"},{"line_number":49,"context_line":"        md \u003d {u\"key1\": u\"value1\", u\"key2\": u\"value2\", }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # set metadata"},{"line_number":52,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_ee27ff62","line":49,"range":{"start_line":49,"start_character":52,"end_line":49,"end_character":53},"in_reply_to":"5f7c97a3_481cebc1","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # set metadata"},{"line_number":52,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("},{"line_number":53,"context_line":"            self.share[\"id\"], \"ip\", utils.rand_ip(), \"rw\", metadata\u003dmd)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # read metadata"},{"line_number":56,"context_line":"        get_access \u003d self.shares_v2_client.get_access(access[\"id\"])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_c87d5be7","line":53,"range":{"start_line":53,"start_character":30,"end_line":53,"end_character":51},"updated":"2018-07-12 06:22:19.000000000","message":"same comment as above","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # set metadata"},{"line_number":52,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("},{"line_number":53,"context_line":"            self.share[\"id\"], \"ip\", utils.rand_ip(), \"rw\", metadata\u003dmd)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # read metadata"},{"line_number":56,"context_line":"        get_access \u003d self.shares_v2_client.get_access(access[\"id\"])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_98ac9089","line":53,"range":{"start_line":53,"start_character":30,"end_line":53,"end_character":51},"in_reply_to":"5f7c97a3_c87d5be7","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":70,"context_line":"    def test_set_and_update_metadata_by_key(self):"},{"line_number":71,"context_line":"        md1 \u003d {u\"key5\": u\"value5\", u\"key6\": u\"value6\", }"},{"line_number":72,"context_line":"        md2 \u003d {u\"key7\": u\"value7\", u\"key8\": u\"value8\", }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set metadata"},{"line_number":75,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_e8d057cb","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":56},"updated":"2018-07-12 06:22:19.000000000","message":"can you repeat one of the keys so we see the value being overwritten","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":70,"context_line":"    def test_set_and_update_metadata_by_key(self):"},{"line_number":71,"context_line":"        md1 \u003d {u\"key5\": u\"value5\", u\"key6\": u\"value6\", }"},{"line_number":72,"context_line":"        md2 \u003d {u\"key7\": u\"value7\", u\"key8\": u\"value8\", }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set metadata"},{"line_number":75,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_c856bb5f","line":72,"range":{"start_line":71,"start_character":8,"end_line":72,"end_character":56},"updated":"2018-07-12 06:22:19.000000000","message":"remove trailing commas","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":70,"context_line":"    def test_set_and_update_metadata_by_key(self):"},{"line_number":71,"context_line":"        md1 \u003d {u\"key5\": u\"value5\", u\"key6\": u\"value6\", }"},{"line_number":72,"context_line":"        md2 \u003d {u\"key7\": u\"value7\", u\"key8\": u\"value8\", }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set metadata"},{"line_number":75,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_8e1c4b15","line":72,"range":{"start_line":71,"start_character":8,"end_line":72,"end_character":56},"in_reply_to":"5f7c97a3_c856bb5f","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":70,"context_line":"    def test_set_and_update_metadata_by_key(self):"},{"line_number":71,"context_line":"        md1 \u003d {u\"key5\": u\"value5\", u\"key6\": u\"value6\", }"},{"line_number":72,"context_line":"        md2 \u003d {u\"key7\": u\"value7\", u\"key8\": u\"value8\", }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set metadata"},{"line_number":75,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_2ed3b739","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":56},"in_reply_to":"5f7c97a3_e8d057cb","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        md2 \u003d {u\"key7\": u\"value7\", u\"key8\": u\"value8\", }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set metadata"},{"line_number":75,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("},{"line_number":76,"context_line":"            self.share[\"id\"], \"ip\", utils.rand_ip(), \"rw\", metadata\u003dmd1)"},{"line_number":77,"context_line":"        # update metadata"},{"line_number":78,"context_line":"        self.shares_v2_client.update_access_metadata(access_id\u003daccess[\"id\"],"},{"line_number":79,"context_line":"                                                     metadata\u003dmd2)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_684767a5","line":76,"range":{"start_line":75,"start_character":8,"end_line":76,"end_character":72},"updated":"2018-07-12 06:22:19.000000000","message":"same comment as above","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        md2 \u003d {u\"key7\": u\"value7\", u\"key8\": u\"value8\", }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # set metadata"},{"line_number":75,"context_line":"        access \u003d self.shares_v2_client.create_access_rule("},{"line_number":76,"context_line":"            self.share[\"id\"], \"ip\", utils.rand_ip(), \"rw\", metadata\u003dmd1)"},{"line_number":77,"context_line":"        # update metadata"},{"line_number":78,"context_line":"        self.shares_v2_client.update_access_metadata(access_id\u003daccess[\"id\"],"},{"line_number":79,"context_line":"                                                     metadata\u003dmd2)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_b8b14ce3","line":76,"range":{"start_line":75,"start_character":8,"end_line":76,"end_character":72},"in_reply_to":"5f7c97a3_684767a5","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"}],"manila_tempest_tests/tests/api/test_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2171bc5796faaf08774e4577b85fff608bf0b427","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            self.assertRaises(lib_exc.NotFound,"},{"line_number":626,"context_line":"                              self.shares_client.list_access_rules,"},{"line_number":627,"context_line":"                              share[\u0027id\u0027])"},{"line_number":628,"context_line":"        else:"},{"line_number":629,"context_line":"            if utils.is_microversion_lt(version, \u00272.45\u0027):"},{"line_number":630,"context_line":"                self.assertRaises(lib_exc.NotFound,"},{"line_number":631,"context_line":"                                  self.shares_v2_client.list_access_rules,"},{"line_number":632,"context_line":"                                  share[\u0027id\u0027], version)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_48f86b49","line":629,"range":{"start_line":628,"start_character":8,"end_line":629,"end_character":14},"updated":"2018-07-12 06:22:19.000000000","message":"elif","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"143d0c670a007a2290c4b846d979fe36c5b1aefe","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            self.assertRaises(lib_exc.NotFound,"},{"line_number":626,"context_line":"                              self.shares_client.list_access_rules,"},{"line_number":627,"context_line":"                              share[\u0027id\u0027])"},{"line_number":628,"context_line":"        else:"},{"line_number":629,"context_line":"            if utils.is_microversion_lt(version, \u00272.45\u0027):"},{"line_number":630,"context_line":"                self.assertRaises(lib_exc.NotFound,"},{"line_number":631,"context_line":"                                  self.shares_v2_client.list_access_rules,"},{"line_number":632,"context_line":"                                  share[\u0027id\u0027], version)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_22baeb0a","line":629,"range":{"start_line":628,"start_character":8,"end_line":629,"end_character":14},"in_reply_to":"5f7c97a3_48f86b49","updated":"2018-07-12 09:39:07.000000000","message":"Done","commit_id":"075293f36c6030769cdaf5d5cc3258b644b71d0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a7c64656255c539838cefff2241302a0156df47b","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":491,"context_line":"    @ddt.data(*set([\u00271.0\u0027, \u00272.9\u0027, \u00272.27\u0027, \u00272.28\u0027, LATEST_MICROVERSION]))"},{"line_number":492,"context_line":"    def test_list_access_rules(self, version):"},{"line_number":493,"context_line":"        if (utils.is_microversion_lt(version, \u00272.13\u0027) and"},{"line_number":494,"context_line":"                CONF.share.enable_cephx_rules_for_protocols):"},{"line_number":495,"context_line":"            msg \u003d (\"API version %s does not support cephx access type, need \""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_2a70ecd9","line":492,"range":{"start_line":492,"start_character":0,"end_line":492,"end_character":46},"updated":"2018-07-18 23:39:50.000000000","message":"Please add \u0027metadata\u0027 key verification to this test.","commit_id":"27f799ad67ef74e92cd6a5faddaee3c69ff6781a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b8f96b8ac00fcecd22ec155e44bf007ef5e8b0c","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":491,"context_line":"    @ddt.data(*set([\u00271.0\u0027, \u00272.9\u0027, \u00272.27\u0027, \u00272.28\u0027, LATEST_MICROVERSION]))"},{"line_number":492,"context_line":"    def test_list_access_rules(self, version):"},{"line_number":493,"context_line":"        if (utils.is_microversion_lt(version, \u00272.13\u0027) and"},{"line_number":494,"context_line":"                CONF.share.enable_cephx_rules_for_protocols):"},{"line_number":495,"context_line":"            msg \u003d (\"API version %s does not support cephx access type, need \""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_1f62e1d9","line":492,"range":{"start_line":492,"start_character":0,"end_line":492,"end_character":46},"in_reply_to":"5f7c97a3_1a719877","updated":"2018-07-20 15:22:12.000000000","message":"GET /share-access-rules?share_id\u003dfoo with X-OpenStack-Manila-Api-Version: 2.45 gives you metadata as a key\n\nhttps://review.openstack.org/#/c/570708/29/manila/api/views/share_accesses.py@78","commit_id":"27f799ad67ef74e92cd6a5faddaee3c69ff6781a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"02e58b7486072d7286ff0103dfa8a5596149efde","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":491,"context_line":"    @ddt.data(*set([\u00271.0\u0027, \u00272.9\u0027, \u00272.27\u0027, \u00272.28\u0027, LATEST_MICROVERSION]))"},{"line_number":492,"context_line":"    def test_list_access_rules(self, version):"},{"line_number":493,"context_line":"        if (utils.is_microversion_lt(version, \u00272.13\u0027) and"},{"line_number":494,"context_line":"                CONF.share.enable_cephx_rules_for_protocols):"},{"line_number":495,"context_line":"            msg \u003d (\"API version %s does not support cephx access type, need \""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_dfd8e9ed","line":492,"range":{"start_line":492,"start_character":0,"end_line":492,"end_character":46},"in_reply_to":"5f7c97a3_1f62e1d9","updated":"2018-07-20 15:58:37.000000000","message":"Sorry, I mix it, I thought about the python-manilaclient project, we delete the metadata parameter in access-list command.","commit_id":"27f799ad67ef74e92cd6a5faddaee3c69ff6781a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4ba05898edd1d8ef9456aa2148c062ff8ace9d63","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":491,"context_line":"    @ddt.data(*set([\u00271.0\u0027, \u00272.9\u0027, \u00272.27\u0027, \u00272.28\u0027, LATEST_MICROVERSION]))"},{"line_number":492,"context_line":"    def test_list_access_rules(self, version):"},{"line_number":493,"context_line":"        if (utils.is_microversion_lt(version, \u00272.13\u0027) and"},{"line_number":494,"context_line":"                CONF.share.enable_cephx_rules_for_protocols):"},{"line_number":495,"context_line":"            msg \u003d (\"API version %s does not support cephx access type, need \""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_1a719877","line":492,"range":{"start_line":492,"start_character":0,"end_line":492,"end_character":46},"in_reply_to":"5f7c97a3_2a70ecd9","updated":"2018-07-20 10:02:07.000000000","message":"The list access rules command cannot get metadata response. So I only add metadata in create_access_rule, it will pass the metadata parameter when we create the the access rule.","commit_id":"27f799ad67ef74e92cd6a5faddaee3c69ff6781a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e84c1a796b354fa9d3684e6b5e5c693e37dbeee9","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            raise self.skipException(msg)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        metadata \u003d None"},{"line_number":501,"context_line":"        if utils.is_microversion_eq(version, \u00272.45\u0027):"},{"line_number":502,"context_line":"            metadata \u003d {\u0027key1\u0027: \u0027v1\u0027, \u0027key2\u0027: \u0027v2\u0027}"},{"line_number":503,"context_line":"        # create rule"},{"line_number":504,"context_line":"        if utils.is_microversion_eq(version, \u00271.0\u0027):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_bfb88d11","line":501,"range":{"start_line":501,"start_character":33,"end_line":501,"end_character":35},"updated":"2018-07-20 15:26:24.000000000","message":"ge","commit_id":"ae10d08d47e38a3aabd7ec527cd547048bffcf6e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"02e58b7486072d7286ff0103dfa8a5596149efde","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            raise self.skipException(msg)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        metadata \u003d None"},{"line_number":501,"context_line":"        if utils.is_microversion_eq(version, \u00272.45\u0027):"},{"line_number":502,"context_line":"            metadata \u003d {\u0027key1\u0027: \u0027v1\u0027, \u0027key2\u0027: \u0027v2\u0027}"},{"line_number":503,"context_line":"        # create rule"},{"line_number":504,"context_line":"        if utils.is_microversion_eq(version, \u00271.0\u0027):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_7fb515cf","line":501,"range":{"start_line":501,"start_character":33,"end_line":501,"end_character":35},"in_reply_to":"5f7c97a3_bfb88d11","updated":"2018-07-20 15:58:37.000000000","message":"Done","commit_id":"ae10d08d47e38a3aabd7ec527cd547048bffcf6e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e84c1a796b354fa9d3684e6b5e5c693e37dbeee9","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        if utils.is_microversion_eq(version, \u00271.0\u0027):"},{"line_number":539,"context_line":"            rules \u003d self.shares_client.list_access_rules(self.share[\"id\"])"},{"line_number":540,"context_line":"        else:"},{"line_number":541,"context_line":"            rules \u003d self.shares_v2_client.list_access_rules(self.share[\"id\"],"},{"line_number":542,"context_line":"                                                            version\u003dversion)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # verify keys"},{"line_number":545,"context_line":"        keys \u003d (\"id\", \"access_type\", \"access_to\", \"access_level\")"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_ff47e51c","line":542,"range":{"start_line":541,"start_character":12,"end_line":542,"end_character":76},"updated":"2018-07-20 15:26:24.000000000","message":"This API call should return the metadata for version \u003e\u003d 2.45","commit_id":"ae10d08d47e38a3aabd7ec527cd547048bffcf6e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"02e58b7486072d7286ff0103dfa8a5596149efde","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        if utils.is_microversion_eq(version, \u00271.0\u0027):"},{"line_number":539,"context_line":"            rules \u003d self.shares_client.list_access_rules(self.share[\"id\"])"},{"line_number":540,"context_line":"        else:"},{"line_number":541,"context_line":"            rules \u003d self.shares_v2_client.list_access_rules(self.share[\"id\"],"},{"line_number":542,"context_line":"                                                            version\u003dversion)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # verify keys"},{"line_number":545,"context_line":"        keys \u003d (\"id\", \"access_type\", \"access_to\", \"access_level\")"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_bfec0dbc","line":542,"range":{"start_line":541,"start_character":12,"end_line":542,"end_character":76},"in_reply_to":"5f7c97a3_ff47e51c","updated":"2018-07-20 15:58:37.000000000","message":"Done","commit_id":"ae10d08d47e38a3aabd7ec527cd547048bffcf6e"}]}