)]}'
{"manila_tempest_tests/tests/api/admin/test_admin_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b03d3fbb745326b1b3da6c31bfb568854aea1f70","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        # create share"},{"line_number":40,"context_line":"        cls.sh \u003d cls.create_share(share_type_id\u003dcls.share_type_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _reset_resource_available(self, id, type\u003d\"shares\"):"},{"line_number":43,"context_line":"        self.shares_v2_client.reset_state(id, s_type\u003dtype, status\u003d\"available\")"},{"line_number":44,"context_line":"        self.shares_v2_client.wait_for_share_status(self.sh[\"id\"], \"available\")"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_a0dcb818","line":42,"range":{"start_line":42,"start_character":40,"end_line":42,"end_character":48},"updated":"2019-01-03 18:16:42.000000000","message":"both \"id\", and \"type\" are keywords in python, so you don\u0027t want to override them - use \"resource_id\", \"resource_type\" instead","commit_id":"59fce18aaa0553e7fef857dc62db39ef9715aee2"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f010dbca29ba6e555945ec49bf3246cb855defff","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        # create share"},{"line_number":40,"context_line":"        cls.sh \u003d cls.create_share(share_type_id\u003dcls.share_type_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _reset_resource_available(self, id, type\u003d\"shares\"):"},{"line_number":43,"context_line":"        self.shares_v2_client.reset_state(id, s_type\u003dtype, status\u003d\"available\")"},{"line_number":44,"context_line":"        self.shares_v2_client.wait_for_share_status(self.sh[\"id\"], \"available\")"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_20b1a890","line":42,"range":{"start_line":42,"start_character":40,"end_line":42,"end_character":48},"in_reply_to":"ffd0ebdf_a0dcb818","updated":"2019-01-03 18:29:46.000000000","message":"Thanks for your comments\nDone","commit_id":"59fce18aaa0553e7fef857dc62db39ef9715aee2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b03d3fbb745326b1b3da6c31bfb568854aea1f70","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def test_reset_share_instance_state(self):"},{"line_number":55,"context_line":"        sh_instance \u003d self.shares_v2_client.get_instances_of_share("},{"line_number":56,"context_line":"            self.sh[\"id\"])[0]"},{"line_number":57,"context_line":"        id \u003d sh_instance[\"id\"]"},{"line_number":58,"context_line":"        for status in self.states:"},{"line_number":59,"context_line":"            self.shares_v2_client.reset_state("},{"line_number":60,"context_line":"                id, s_type\u003d\"share_instances\", status\u003dstatus)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_00d7c4ef","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":10},"updated":"2019-01-03 18:16:42.000000000","message":"share_instance_id","commit_id":"59fce18aaa0553e7fef857dc62db39ef9715aee2"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f010dbca29ba6e555945ec49bf3246cb855defff","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def test_reset_share_instance_state(self):"},{"line_number":55,"context_line":"        sh_instance \u003d self.shares_v2_client.get_instances_of_share("},{"line_number":56,"context_line":"            self.sh[\"id\"])[0]"},{"line_number":57,"context_line":"        id \u003d sh_instance[\"id\"]"},{"line_number":58,"context_line":"        for status in self.states:"},{"line_number":59,"context_line":"            self.shares_v2_client.reset_state("},{"line_number":60,"context_line":"                id, s_type\u003d\"share_instances\", status\u003dstatus)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_e0aac017","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":10},"in_reply_to":"ffd0ebdf_00d7c4ef","updated":"2019-01-03 18:29:46.000000000","message":"Done","commit_id":"59fce18aaa0553e7fef857dc62db39ef9715aee2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b03d3fbb745326b1b3da6c31bfb568854aea1f70","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":66,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":67,"context_line":"    def test_reset_snapshot_state(self):"},{"line_number":68,"context_line":"        sn \u003d self.create_snapshot_wait_for_active(self.sh[\"id\"])"},{"line_number":69,"context_line":"        for status in self.states:"},{"line_number":70,"context_line":"            self.shares_v2_client.reset_state("},{"line_number":71,"context_line":"                sn[\"id\"], s_type\u003d\"snapshots\", status\u003dstatus)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_a005987c","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":10},"updated":"2019-01-03 18:16:42.000000000","message":"snapshot","commit_id":"59fce18aaa0553e7fef857dc62db39ef9715aee2"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f010dbca29ba6e555945ec49bf3246cb855defff","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":66,"context_line":"                          \"Snapshot tests are disabled.\")"},{"line_number":67,"context_line":"    def test_reset_snapshot_state(self):"},{"line_number":68,"context_line":"        sn \u003d self.create_snapshot_wait_for_active(self.sh[\"id\"])"},{"line_number":69,"context_line":"        for status in self.states:"},{"line_number":70,"context_line":"            self.shares_v2_client.reset_state("},{"line_number":71,"context_line":"                sn[\"id\"], s_type\u003d\"snapshots\", status\u003dstatus)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_00a8241d","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":10},"in_reply_to":"ffd0ebdf_a005987c","updated":"2019-01-03 18:29:46.000000000","message":"Done","commit_id":"59fce18aaa0553e7fef857dc62db39ef9715aee2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"028d14250e919b38b7c6ce22881b5058fa3ff1a2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def _reset_resource_available(self, resource_id, resource_type\u003d\"shares\"):"},{"line_number":43,"context_line":"        self.shares_v2_client.reset_state("},{"line_number":44,"context_line":"            resource_id, s_type\u003dresource_type, status\u003d\"available\")"},{"line_number":45,"context_line":"        self.shares_v2_client.wait_for_share_status(self.sh[\"id\"], \"available\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":48,"context_line":"    def test_reset_share_state(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_c36466bc","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":79},"updated":"2019-01-03 18:54:50.000000000","message":"you\u0027re using this method to generically reset state for snapshots and share instances as well, so perhaps:\n\n wait_for_resource_status \u003d {\n     \u0027shares\u0027: self.shares_v2_client.wait_for_share_status,\n     \u0027snapshots\u0027: self.shares_v2_client.wait_for_snapshot_status,\n     \u0027share_instances\": self.shares_v2_client.wait_for_share_instance_status,\n }\n wait_for_resource_status[resource_type](resource_id, \"available\")","commit_id":"6792a8f99127f515d47a0ced586b0fe72e270d7b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3396d0548badb7c1e509113e313dace787ef2ca6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def _reset_resource_available(self, resource_id, resource_type\u003d\"shares\"):"},{"line_number":43,"context_line":"        self.shares_v2_client.reset_state("},{"line_number":44,"context_line":"            resource_id, s_type\u003dresource_type, status\u003d\"available\")"},{"line_number":45,"context_line":"        self.shares_v2_client.wait_for_share_status(self.sh[\"id\"], \"available\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":48,"context_line":"    def test_reset_share_state(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_c96487bc","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":79},"in_reply_to":"ffd0ebdf_c36466bc","updated":"2019-01-03 20:22:10.000000000","message":"Done","commit_id":"6792a8f99127f515d47a0ced586b0fe72e270d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd1248c63cf62637c95dd67c8f0030ccffcbea9f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def resource_setup(cls):"},{"line_number":30,"context_line":"        super(AdminActionsTest, cls).resource_setup()"},{"line_number":31,"context_line":"        cls.states \u003d [\"error\", \"available\", \"error_deleting\", \"deleting\","},{"line_number":32,"context_line":"                      \"creating\"]"},{"line_number":33,"context_line":"        cls.task_states \u003d [\"migration_starting\", \"data_copying_in_progress\","},{"line_number":34,"context_line":"                           \"migration_success\", None]"},{"line_number":35,"context_line":"        cls.bad_status \u003d \"error_deleting\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ffd0ebdf_c061b13b","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"updated":"2019-01-04 07:53:56.000000000","message":"actually, on second thought - running a loop within one single test case isn\u0027t good practice. Now that we\u0027re adding 3 more test scenarios, maybe we should consider using ddt on the existing cases instead.","commit_id":"aba8ec54df19324cee979488770377fe0edd6adb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"62548fe078862a2e1105aaf75a9f7e63a3013a84","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def resource_setup(cls):"},{"line_number":30,"context_line":"        super(AdminActionsTest, cls).resource_setup()"},{"line_number":31,"context_line":"        cls.states \u003d [\"error\", \"available\", \"error_deleting\", \"deleting\","},{"line_number":32,"context_line":"                      \"creating\"]"},{"line_number":33,"context_line":"        cls.task_states \u003d [\"migration_starting\", \"data_copying_in_progress\","},{"line_number":34,"context_line":"                           \"migration_success\", None]"},{"line_number":35,"context_line":"        cls.bad_status \u003d \"error_deleting\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_8b2f61f5","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"in_reply_to":"ffd0ebdf_c061b13b","updated":"2019-01-06 08:14:52.000000000","message":"Done","commit_id":"aba8ec54df19324cee979488770377fe0edd6adb"}]}