)]}'
{"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"652d99b36dd84447496235a04a83838c1d5d7b1e","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        extra_specs \u003d {}"},{"line_number":717,"context_line":"        for k, v in share_type[\u0027extra_specs\u0027].items():"},{"line_number":718,"context_line":"            extra_specs[k] \u003d ("},{"line_number":719,"context_line":"                True if six.text_type(v).lower() \u003d\u003d \u0027true\u0027"},{"line_number":720,"context_line":"                else False if six.text_type(v).lower() \u003d\u003d \u0027false\u0027 else v"},{"line_number":721,"context_line":"            )"},{"line_number":722,"context_line":"        return ["},{"line_number":723,"context_line":"            pool for pool in pools if all(y in pool[\u0027capabilities\u0027].items()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_0da32d51","line":720,"range":{"start_line":719,"start_character":0,"end_line":720,"end_character":72},"updated":"2019-01-16 10:14:20.000000000","message":"See oslo_utils.strutils.bool_from_string:\nhttps://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L114\n\nIn case I\u0027m not missing anything, you might then change this block to:\nextra_specs \u003d {k: bool_from_string(v, default\u003dv) for k,v in share_type[\u0027extra_specs\u0027].items()}","commit_id":"839c98b2c1b46c46274e61ead2ef0c55dde35549"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"078be34ae3a53601ac93c8c20f2eb3953d8deda9","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        extra_specs \u003d {}"},{"line_number":717,"context_line":"        for k, v in share_type[\u0027extra_specs\u0027].items():"},{"line_number":718,"context_line":"            extra_specs[k] \u003d ("},{"line_number":719,"context_line":"                True if six.text_type(v).lower() \u003d\u003d \u0027true\u0027"},{"line_number":720,"context_line":"                else False if six.text_type(v).lower() \u003d\u003d \u0027false\u0027 else v"},{"line_number":721,"context_line":"            )"},{"line_number":722,"context_line":"        return ["},{"line_number":723,"context_line":"            pool for pool in pools if all(y in pool[\u0027capabilities\u0027].items()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_e4aefb96","line":720,"range":{"start_line":719,"start_character":0,"end_line":720,"end_character":72},"in_reply_to":"bfdaf3ff_0da32d51","updated":"2019-01-16 16:35:40.000000000","message":"Thanks, don\u0027t need this third party lib because the extra-spec value in the share types is being set within the tests, we don\u0027t need to test against all values of truth/false.. I would have used it if oslo_utils was already in the requirements file..","commit_id":"839c98b2c1b46c46274e61ead2ef0c55dde35549"}]}
