)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b601c4ab3a53613a9b170e7df3a139c44e792a5","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch modifies the base test class tearDown method, to delete the"},{"line_number":19,"context_line":"share servers before the share network they belong to."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7d330b8b5fb3f08d3cbdae2c1735e266e75a70d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_3f9a05c5","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"updated":"2019-03-20 17:21:15.000000000","message":"LP Bug missing..","commit_id":"874bd7caa71cc49fa0fb44f6e2f5c4219e1bfd2b"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"26afb1cd595c9085ff1498909a60a0750efecf9a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch modifies the base test class tearDown method, to delete the"},{"line_number":19,"context_line":"share servers before the share network they belong to."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7d330b8b5fb3f08d3cbdae2c1735e266e75a70d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_df68a122","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"5fc1f717_3f9a05c5","updated":"2019-03-20 18:00:30.000000000","message":"Added it as Related-Bug because this patch doesn\u0027t fix the bug directly.","commit_id":"874bd7caa71cc49fa0fb44f6e2f5c4219e1bfd2b"}],"manila_tempest_tests/services/share/json/shares_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eda62b270d4ed351196cc40660349879deb37a80","unresolved":false,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def delete_share_servers_from_share_network(self, sn_id):"},{"line_number":741,"context_line":"        \"\"\"Delete share servers within the given share network.\"\"\""},{"line_number":742,"context_line":"        servers \u003d self.list_share_servers({\u0027share_network_id\u0027: sn_id})"},{"line_number":743,"context_line":"        for server in servers:"},{"line_number":744,"context_line":"            self.delete_share_server(server[\u0027id\u0027])"},{"line_number":745,"context_line":"            self.wait_for_resource_deletion(server_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5f51110e","line":742,"range":{"start_line":742,"start_character":43,"end_line":742,"end_character":69},"updated":"2019-03-20 17:20:54.000000000","message":"pass kwargs as kwargs.\n\nAlso don\u0027t you also want to specifically cleanup servers in is_autodeletable\u003dFalse?","commit_id":"874bd7caa71cc49fa0fb44f6e2f5c4219e1bfd2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"351abea8a825422ec94d0ccb88d14446f3a775ed","unresolved":false,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def delete_share_servers_from_share_network(self, sn_id):"},{"line_number":741,"context_line":"        \"\"\"Delete share servers within the given share network.\"\"\""},{"line_number":742,"context_line":"        servers \u003d self.list_share_servers({\u0027share_network_id\u0027: sn_id})"},{"line_number":743,"context_line":"        for server in servers:"},{"line_number":744,"context_line":"            self.delete_share_server(server[\u0027id\u0027])"},{"line_number":745,"context_line":"            self.wait_for_resource_deletion(server_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_627d52e6","line":742,"range":{"start_line":742,"start_character":43,"end_line":742,"end_character":69},"in_reply_to":"5fc1f717_22266ab9","updated":"2019-03-20 18:23:30.000000000","message":"you\u0027ll need to request a detailed list of share servers instead of the summary list that list_share_servers is currently fetching.","commit_id":"874bd7caa71cc49fa0fb44f6e2f5c4219e1bfd2b"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"26afb1cd595c9085ff1498909a60a0750efecf9a","unresolved":false,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def delete_share_servers_from_share_network(self, sn_id):"},{"line_number":741,"context_line":"        \"\"\"Delete share servers within the given share network.\"\"\""},{"line_number":742,"context_line":"        servers \u003d self.list_share_servers({\u0027share_network_id\u0027: sn_id})"},{"line_number":743,"context_line":"        for server in servers:"},{"line_number":744,"context_line":"            self.delete_share_server(server[\u0027id\u0027])"},{"line_number":745,"context_line":"            self.wait_for_resource_deletion(server_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_22266ab9","line":742,"range":{"start_line":742,"start_character":43,"end_line":742,"end_character":69},"in_reply_to":"5fc1f717_5f51110e","updated":"2019-03-20 18:00:30.000000000","message":"\u003e pass kwargs as kwargs.\nDone.\n\nTo specify `is_auto_deletable\u003dFalse`, I\u0027d need to add a step to call `show_share_server` for each share-server, because `list_share_servers` doesn\u0027t retrieve `is_auto_deletable` field.\nNot sure if it\u0027s worthy, because the `is_auto_deletable\u003dTrue` share-servers would be deleted anyway.","commit_id":"874bd7caa71cc49fa0fb44f6e2f5c4219e1bfd2b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b377315e06ead9636eb353312d3eb23f251f638a","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":737,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":738,"context_line":"        return self._parse_resp(body)"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def delete_share_servers_from_share_network(self, sn_id):"},{"line_number":741,"context_line":"        \"\"\"Delete share servers within the given share network.\"\"\""},{"line_number":742,"context_line":"        search_opts \u003d {\u0027share_network_id\u0027: sn_id}"},{"line_number":743,"context_line":"        servers \u003d self.list_share_servers(search_opts\u003dsearch_opts)"},{"line_number":744,"context_line":"        for server in servers:"},{"line_number":745,"context_line":"            self.delete_share_server(server[\u0027id\u0027])"},{"line_number":746,"context_line":"            self.wait_for_resource_deletion(server_id\u003dserver[\u0027id\u0027])"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"###############"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_e84273ab","line":746,"range":{"start_line":739,"start_character":0,"end_line":746,"end_character":67},"updated":"2019-03-21 12:33:59.000000000","message":"it looks like to me that this is now not being invoked anywhere","commit_id":"b5eed7a13b3f2342ff3a9b81ac9bfc420ac762c4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55d9f8ae0e729fdc9833ac8d508e0fc6c65a1c76","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":737,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":738,"context_line":"        return self._parse_resp(body)"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def delete_share_servers_from_share_network(self, sn_id):"},{"line_number":741,"context_line":"        \"\"\"Delete share servers within the given share network.\"\"\""},{"line_number":742,"context_line":"        search_opts \u003d {\u0027share_network_id\u0027: sn_id}"},{"line_number":743,"context_line":"        servers \u003d self.list_share_servers(search_opts\u003dsearch_opts)"},{"line_number":744,"context_line":"        for server in servers:"},{"line_number":745,"context_line":"            self.delete_share_server(server[\u0027id\u0027])"},{"line_number":746,"context_line":"            self.wait_for_resource_deletion(server_id\u003dserver[\u0027id\u0027])"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"###############"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_e8f7d358","line":746,"range":{"start_line":739,"start_character":0,"end_line":746,"end_character":67},"in_reply_to":"5fc1f717_e84273ab","updated":"2019-03-21 12:42:30.000000000","message":"Just forgot to remove. Thanks!","commit_id":"b5eed7a13b3f2342ff3a9b81ac9bfc420ac762c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cabd4a56c0add83c960d6672ce9f826bb19375b5","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":738,"context_line":"        return self._parse_resp(body)"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"###############"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"    def list_pools(self, detail\u003dFalse, search_opts\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_64e9c77e","line":740,"range":{"start_line":740,"start_character":0,"end_line":740,"end_character":0},"updated":"2019-03-21 17:49:07.000000000","message":"Unrelated change. Please remove if you make another patch.","commit_id":"ec2280fe5852f02aa8ad884e203ee83b6ffe768f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"081fb41e25525469ddfb6a14131a4b378bea9782","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":738,"context_line":"        return self._parse_resp(body)"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"###############"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"    def list_pools(self, detail\u003dFalse, search_opts\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_27cbc153","line":740,"range":{"start_line":740,"start_character":0,"end_line":740,"end_character":0},"in_reply_to":"5fc1f717_64e9c77e","updated":"2019-03-21 18:32:53.000000000","message":"Done","commit_id":"ec2280fe5852f02aa8ad884e203ee83b6ffe768f"}],"manila_tempest_tests/tests/api/admin/test_share_manage.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cabd4a56c0add83c960d6672ce9f826bb19375b5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._delete_share_and_wait(managed_share)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Delete share server"},{"line_number":135,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":136,"context_line":"            self.shares_v2_client.delete_share_server(share[\u0027share_server_id\u0027])"},{"line_number":137,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("},{"line_number":138,"context_line":"                server_id\u003dshare[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_e4585757","line":135,"range":{"start_line":135,"start_character":42,"end_line":135,"end_character":43},"updated":"2019-03-21 17:49:07.000000000","message":"I wonder if we should have \u0027and CONF.share.share_network_id !\u003d \"\"\u0027 \n\nBecause, this might potentially delete a share server we may not have caused the creation of, with the tests.","commit_id":"ec2280fe5852f02aa8ad884e203ee83b6ffe768f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"081fb41e25525469ddfb6a14131a4b378bea9782","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._delete_share_and_wait(managed_share)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Delete share server"},{"line_number":135,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":136,"context_line":"            self.shares_v2_client.delete_share_server(share[\u0027share_server_id\u0027])"},{"line_number":137,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("},{"line_number":138,"context_line":"                server_id\u003dshare[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_a2247fb0","line":135,"range":{"start_line":135,"start_character":42,"end_line":135,"end_character":43},"in_reply_to":"5fc1f717_e4585757","updated":"2019-03-21 18:32:53.000000000","message":"Done","commit_id":"ec2280fe5852f02aa8ad884e203ee83b6ffe768f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bcb832b91f90d01264d4c849d4b0279934d6b1c0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._delete_share_and_wait(managed_share)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Delete share server"},{"line_number":135,"context_line":"        if (CONF.share.multitenancy_enabled"},{"line_number":136,"context_line":"                and CONF.share.share_network_id !\u003d \"\"):"},{"line_number":137,"context_line":"            self.shares_v2_client.delete_share_server(share[\u0027share_server_id\u0027])"},{"line_number":138,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("},{"line_number":139,"context_line":"                server_id\u003dshare[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_59d26d36","line":136,"range":{"start_line":135,"start_character":8,"end_line":136,"end_character":55},"updated":"2019-03-21 23:16:04.000000000","message":"This condition is wrong.. execution occurs left to right, so this gets interpreted wrongly.. \n\n\n         # Delete share server, since it can\u0027t be \"auto-deleted\"\n        if (CONF.share.multitenancy_enabled and\n                not CONF.share.share_network_id):\n            # For a pre-configured share_network_id, we don\u0027t\n            # delete the share server.\n\n\nworked for me locally.","commit_id":"37ab497178200a2bc16244391b4ca7cf5410611a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d615115d887501a303d1fa5c9d027f7603b5ecc3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._delete_share_and_wait(managed_share)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Delete share server"},{"line_number":135,"context_line":"        if (CONF.share.multitenancy_enabled"},{"line_number":136,"context_line":"                and CONF.share.share_network_id !\u003d \"\"):"},{"line_number":137,"context_line":"            self.shares_v2_client.delete_share_server(share[\u0027share_server_id\u0027])"},{"line_number":138,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("},{"line_number":139,"context_line":"                server_id\u003dshare[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_19dce544","line":136,"range":{"start_line":135,"start_character":8,"end_line":136,"end_character":55},"in_reply_to":"5fc1f717_59d26d36","updated":"2019-03-21 23:17:17.000000000","message":"Please add these comments, helpful to make folks understand why you\u0027re doing this cleanup. \n\nBonus points if you add them everywhere you\u0027re doing this :)","commit_id":"37ab497178200a2bc16244391b4ca7cf5410611a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13930a97b92bd4bfce576ab256b5b7bdbd7ca496","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # Delete share server"},{"line_number":135,"context_line":"        if (CONF.share.multitenancy_enabled"},{"line_number":136,"context_line":"                and CONF.share.share_network_id !\u003d \"\"):"},{"line_number":137,"context_line":"            self.shares_v2_client.delete_share_server(share[\u0027share_server_id\u0027])"},{"line_number":138,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("},{"line_number":139,"context_line":"                server_id\u003dshare[\u0027share_server_id\u0027]"},{"line_number":140,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_3ddaf2e8","line":137,"range":{"start_line":137,"start_character":54,"end_line":137,"end_character":59},"updated":"2019-03-21 19:53:43.000000000","message":"managed_share","commit_id":"37ab497178200a2bc16244391b4ca7cf5410611a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6eb817bff7acdafc4fdb6c476ced715ceccbeeaa","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # Delete share server"},{"line_number":135,"context_line":"        if (CONF.share.multitenancy_enabled"},{"line_number":136,"context_line":"                and CONF.share.share_network_id !\u003d \"\"):"},{"line_number":137,"context_line":"            self.shares_v2_client.delete_share_server(share[\u0027share_server_id\u0027])"},{"line_number":138,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("},{"line_number":139,"context_line":"                server_id\u003dshare[\u0027share_server_id\u0027]"},{"line_number":140,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_b6ea80d5","line":137,"range":{"start_line":137,"start_character":54,"end_line":137,"end_character":59},"in_reply_to":"5fc1f717_184f0435","updated":"2019-03-21 22:12:40.000000000","message":"Thanks, yes, I was confused when I saw it... for readability\u0027s sake we this should be \"managed_share\"...","commit_id":"37ab497178200a2bc16244391b4ca7cf5410611a"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"bfdfd9ef716fe610929a3d32b3d0c0f5417dc074","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # Delete share server"},{"line_number":135,"context_line":"        if (CONF.share.multitenancy_enabled"},{"line_number":136,"context_line":"                and CONF.share.share_network_id !\u003d \"\"):"},{"line_number":137,"context_line":"            self.shares_v2_client.delete_share_server(share[\u0027share_server_id\u0027])"},{"line_number":138,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("},{"line_number":139,"context_line":"                server_id\u003dshare[\u0027share_server_id\u0027]"},{"line_number":140,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_184f0435","line":137,"range":{"start_line":137,"start_character":54,"end_line":137,"end_character":59},"in_reply_to":"5fc1f717_3ddaf2e8","updated":"2019-03-21 19:58:12.000000000","message":"they are the same","commit_id":"37ab497178200a2bc16244391b4ca7cf5410611a"}],"manila_tempest_tests/tests/api/admin/test_share_manage_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cabd4a56c0add83c960d6672ce9f826bb19375b5","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        return valid_params"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _delete_share_server_and_wait(self, share_server_id):"},{"line_number":91,"context_line":"        self.shares_v2_client.delete_share_server(share_server_id)"},{"line_number":92,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":93,"context_line":"            server_id\u003dshare_server_id"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":97,"context_line":"    def test_manage_invalid_param_raises_exception(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_c7019d06","line":94,"range":{"start_line":90,"start_character":4,"end_line":94,"end_character":9},"updated":"2019-03-21 17:49:07.000000000","message":"if CONF.share.share_network_id !\u003d \"\"\n\nBecause we may be deleting a share server that the tests didn\u0027t create...","commit_id":"ec2280fe5852f02aa8ad884e203ee83b6ffe768f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"081fb41e25525469ddfb6a14131a4b378bea9782","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        return valid_params"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _delete_share_server_and_wait(self, share_server_id):"},{"line_number":91,"context_line":"        self.shares_v2_client.delete_share_server(share_server_id)"},{"line_number":92,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":93,"context_line":"            server_id\u003dshare_server_id"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":97,"context_line":"    def test_manage_invalid_param_raises_exception(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_c72d1dfe","line":94,"range":{"start_line":90,"start_character":4,"end_line":94,"end_character":9},"in_reply_to":"5fc1f717_c7019d06","updated":"2019-03-21 18:32:53.000000000","message":"Done","commit_id":"ec2280fe5852f02aa8ad884e203ee83b6ffe768f"}],"manila_tempest_tests/tests/api/admin/test_share_servers_manage_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"389f318c08c6b1091bfd2c4723140b6c7d857d0f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        invalid_params[\u0027identifier\u0027] \u003d \u0027invalid_id\u0027"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        self.assertRaises("},{"line_number":258,"context_line":"            lib_exc.BadRequest,"},{"line_number":259,"context_line":"            self._manage_share_server,"},{"line_number":260,"context_line":"            invalid_params"},{"line_number":261,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_2e271e15","line":258,"range":{"start_line":258,"start_character":12,"end_line":258,"end_character":30},"updated":"2019-03-21 16:28:13.000000000","message":"How is this BadRequest? i.e, the API actually can\u0027t know if a share server is identified by \"invalid_id\" on the backend...","commit_id":"beed08af53cfed06237a5e7f9d7dab4781bef91a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3f2502fcfe9ea377c337f947c6088249265ed7d3","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        invalid_params[\u0027identifier\u0027] \u003d \u0027invalid_id\u0027"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        self.assertRaises("},{"line_number":258,"context_line":"            lib_exc.BadRequest,"},{"line_number":259,"context_line":"            self._manage_share_server,"},{"line_number":260,"context_line":"            invalid_params"},{"line_number":261,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_91a7570c","line":258,"range":{"start_line":258,"start_character":12,"end_line":258,"end_character":30},"in_reply_to":"5fc1f717_2e271e15","updated":"2019-03-21 16:47:16.000000000","message":"Done","commit_id":"beed08af53cfed06237a5e7f9d7dab4781bef91a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cabd4a56c0add83c960d6672ce9f826bb19375b5","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        self._delete_share_and_wait(share)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        # delete share server"},{"line_number":328,"context_line":"        self._delete_share_server_and_wait(share_server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_0429e399","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":62},"updated":"2019-03-21 17:49:07.000000000","message":"Same comment as in the other file.. this test can be run on a share server that\u0027s not created by the result of our tests.. \n\nso, I wonder if we should prevent cleaning it up only if:\n\n  CONF.share.share_network_id !\u003d \"\"","commit_id":"ec2280fe5852f02aa8ad884e203ee83b6ffe768f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"081fb41e25525469ddfb6a14131a4b378bea9782","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        self._delete_share_and_wait(share)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        # delete share server"},{"line_number":328,"context_line":"        self._delete_share_server_and_wait(share_server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_276c2135","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":62},"in_reply_to":"5fc1f717_0429e399","updated":"2019-03-21 18:32:53.000000000","message":"Done","commit_id":"ec2280fe5852f02aa8ad884e203ee83b6ffe768f"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66e3568a18cb26fd266a683d50f21a3b8ada80cc","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                        client.wait_for_resource_deletion(snapshot_id\u003dres_id)"},{"line_number":954,"context_line":"                    elif (res[\"type\"] is \"share_network\" and"},{"line_number":955,"context_line":"                            res_id !\u003d CONF.share.share_network_id):"},{"line_number":956,"context_line":"                        client.delete_share_servers_from_share_network(res_id)"},{"line_number":957,"context_line":"                        client.delete_share_network(res_id)"},{"line_number":958,"context_line":"                        client.wait_for_resource_deletion(sn_id\u003dres_id)"},{"line_number":959,"context_line":"                    elif res[\"type\"] is \"security_service\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_a886ab64","line":956,"range":{"start_line":956,"start_character":23,"end_line":956,"end_character":78},"updated":"2019-03-21 12:13:14.000000000","message":"why is this still here?","commit_id":"d33f2ee5d9fe2b4b79bb792b0259473f47015141"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"16aec9d8aa773fbd1660943ae7a72664f136b830","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                        client.wait_for_resource_deletion(snapshot_id\u003dres_id)"},{"line_number":954,"context_line":"                    elif (res[\"type\"] is \"share_network\" and"},{"line_number":955,"context_line":"                            res_id !\u003d CONF.share.share_network_id):"},{"line_number":956,"context_line":"                        client.delete_share_servers_from_share_network(res_id)"},{"line_number":957,"context_line":"                        client.delete_share_network(res_id)"},{"line_number":958,"context_line":"                        client.wait_for_resource_deletion(sn_id\u003dres_id)"},{"line_number":959,"context_line":"                    elif res[\"type\"] is \"security_service\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_48838705","line":956,"range":{"start_line":956,"start_character":23,"end_line":956,"end_character":78},"in_reply_to":"5fc1f717_a886ab64","updated":"2019-03-21 12:28:44.000000000","message":"Done","commit_id":"d33f2ee5d9fe2b4b79bb792b0259473f47015141"}]}
