)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"5a50f20309676f55e6af2e18ceccb3e6bc50e2c8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"share shared by IP[1]. This patch causes the test to be skipped in such"},{"line_number":16,"context_line":"a case."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://opendev.org/openstack/manila/src/commit/35d327e4638aa4bfb2ba68fbc602a827816e782b/manila/share/drivers/helpers.py"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic30eaf3c2b7f75eb4bc62159faceb6bd30d7e03b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_3503a975","line":18,"updated":"2019-06-10 21:07:21.000000000","message":"Could you also specify the line number where the denial is configured, please?","commit_id":"24e53e08cae19af5c5e776173ba6db771feaa529"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f74d0252ffc1653d1ea05600628bd1ec3355818d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"share shared by IP[1]. This patch causes the test to be skipped in such"},{"line_number":16,"context_line":"a case."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://opendev.org/openstack/manila/src/commit/35d327e4638aa4bfb2ba68fbc602a827816e782b/manila/share/drivers/helpers.py"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic30eaf3c2b7f75eb4bc62159faceb6bd30d7e03b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_1539c5f0","line":18,"in_reply_to":"9fb8cfa7_3503a975","updated":"2019-06-10 21:28:46.000000000","message":"Oops, done","commit_id":"24e53e08cae19af5c5e776173ba6db771feaa529"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e783e88a8bb5d5dbe69732b682392910ade726b5","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  InvalidShareAccessLevel: Invalid or unsupported share access level: ro."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is because the RO access level is explicitly denied for a CIFS"},{"line_number":15,"context_line":"share shared by IP[1]. This patch causes the test to be skipped in such"},{"line_number":16,"context_line":"a case."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://opendev.org/openstack/manila/src/commit/35d327e4638aa4bfb2ba68fbc602a827816e782b/manila/share/drivers/helpers.py#L493-L494"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fb8cfa7_3e3a7898","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":23},"updated":"2019-06-12 22:10:12.000000000","message":"This code is only used by the Generic driver - there are several other backends in manila that certainly allow RO access to CIFS shares, however, they don\u0027t support IP based authentication . I would suggest re-writing this in a different way:\n\nThere are no Manila Share backends that support CIFS shares with read only access when authenticating with IP addresses.\n\n[1] https://docs.openstack.org/manila/latest/admin/share_back_ends_feature_support_mapping.html#mapping-of-share-drivers-and-share-access-rules-support","commit_id":"08e72ea197210c67040f17b01170333cf48e133d"}],"manila_tempest_tests/tests/scenario/test_share_basic_ops.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b7b2ca4a896a11e434fc44003aa6f270e0000927","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def test_write_with_ro_access(self):"},{"line_number":118,"context_line":"        \u0027\u0027\u0027Test if an instance with ro access can write on the share.\u0027\u0027\u0027"},{"line_number":119,"context_line":"        if self.protocol.upper() \u003d\u003d \u0027CIFS\u0027:"},{"line_number":120,"context_line":"            msg \u003d (\"Skipped for CIFS protocol because RO is not supported for \""},{"line_number":121,"context_line":"                   \"shares by IP.\")"},{"line_number":122,"context_line":"            raise self.skipException(msg)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_99162349","line":120,"range":{"start_line":120,"start_character":46,"end_line":120,"end_character":59},"updated":"2019-06-12 18:06:00.000000000","message":"What about:\n\"Skipped for CIFS protocol because RO access is not... \"","commit_id":"7f38e1146ace3f455ed832ad31c56ee4b91f1d8f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"49c5ce60ec4294972c9c9448c28a7b3ea10ea136","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def test_write_with_ro_access(self):"},{"line_number":118,"context_line":"        \u0027\u0027\u0027Test if an instance with ro access can write on the share.\u0027\u0027\u0027"},{"line_number":119,"context_line":"        if self.protocol.upper() \u003d\u003d \u0027CIFS\u0027:"},{"line_number":120,"context_line":"            msg \u003d (\"Skipped for CIFS protocol because RO is not supported for \""},{"line_number":121,"context_line":"                   \"shares by IP.\")"},{"line_number":122,"context_line":"            raise self.skipException(msg)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_1480ba45","line":120,"range":{"start_line":120,"start_character":46,"end_line":120,"end_character":59},"in_reply_to":"9fb8cfa7_99162349","updated":"2019-06-12 18:57:47.000000000","message":"Done","commit_id":"7f38e1146ace3f455ed832ad31c56ee4b91f1d8f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e783e88a8bb5d5dbe69732b682392910ade726b5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_BACKEND)"},{"line_number":117,"context_line":"    def test_write_with_ro_access(self):"},{"line_number":118,"context_line":"        \u0027\u0027\u0027Test if an instance with ro access can write on the share.\u0027\u0027\u0027"},{"line_number":119,"context_line":"        if self.protocol.upper() \u003d\u003d \u0027CIFS\u0027:"},{"line_number":120,"context_line":"            msg \u003d (\"Skipped for CIFS protocol because RO access is not \""},{"line_number":121,"context_line":"                   \"supported for shares by IP.\")"},{"line_number":122,"context_line":"            raise self.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_5eef2c1d","line":119,"range":{"start_line":119,"start_character":42,"end_line":119,"end_character":43},"updated":"2019-06-12 22:10:12.000000000","message":"if we add user based access in the future, we\u0027d need a check here: (This isn\u0027t needed right now)\n\n and \"CIFS\" not in CONF.enable_user_rules_for_protocols:","commit_id":"08e72ea197210c67040f17b01170333cf48e133d"}]}