)]}'
{"manila_tempest_tests/tests/api/admin/test_shares_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7b31c6f06c66b5c3b23880a6b1a66e0087abe57","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        for share in shares:"},{"line_number":156,"context_line":"            self.assertDictContainsSubset("},{"line_number":157,"context_line":"                filters[\u0027metadata\u0027], share[\u0027metadata\u0027])"},{"line_number":158,"context_line":"        if CONF.share.capability_create_share_from_snapshot_support:"},{"line_number":159,"context_line":"            self.assertFalse(self.shares[1][\u0027id\u0027] in [s[\u0027id\u0027] for s in shares])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":162,"context_line":"    def test_list_shares_with_detail_filter_by_extra_specs(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_29a462a5","side":"PARENT","line":159,"range":{"start_line":158,"start_character":0,"end_line":159,"end_character":79},"updated":"2019-08-06 07:02:00.000000000","message":"This seems to be verifying that, when filtering shares with self.metadata, you\u0027re not going to get a share that doesn\u0027t have self.metadata.\n\nI agree this is not readable - if anything, we should add a comment clarifying this.","commit_id":"267dd04fc7518a274622a9ff341db9ffe479f5ee"},{"author":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"change_message_id":"7eb474907afe3aace04c1c55638a2006cbcc03fe","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        for share in shares:"},{"line_number":156,"context_line":"            self.assertDictContainsSubset("},{"line_number":157,"context_line":"                filters[\u0027metadata\u0027], share[\u0027metadata\u0027])"},{"line_number":158,"context_line":"        if CONF.share.capability_create_share_from_snapshot_support:"},{"line_number":159,"context_line":"            self.assertFalse(self.shares[1][\u0027id\u0027] in [s[\u0027id\u0027] for s in shares])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":162,"context_line":"    def test_list_shares_with_detail_filter_by_extra_specs(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_0cfbb4bd","side":"PARENT","line":159,"range":{"start_line":158,"start_character":0,"end_line":159,"end_character":79},"in_reply_to":"7faddb67_29a462a5","updated":"2019-08-07 01:25:58.000000000","message":"I confused shares with self.shares! Thanks! Done","commit_id":"267dd04fc7518a274622a9ff341db9ffe479f5ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c75831e66c2c69fe1edb0f1717df9dd3f7bde5e","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                filters[\u0027share_network_id\u0027], share[\u0027share_network_id\u0027])"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":281,"context_line":"    @testtools.skipUnless("},{"line_number":282,"context_line":"        CONF.share.run_snapshot_tests,"},{"line_number":283,"context_line":"        \"Snapshot tests are disabled.\")"},{"line_number":284,"context_line":"    def test_list_shares_with_detail_filter_by_snapshot_id(self):"},{"line_number":285,"context_line":"        filters \u003d {\u0027snapshot_id\u0027: self.snap[\u0027id\u0027]}"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_8a61b9ab","line":283,"range":{"start_line":281,"start_character":4,"end_line":283,"end_character":39},"updated":"2019-08-06 17:49:35.000000000","message":"This is incorrect, the previous skip still makes sense; here\u0027s why:\n\n\"snapshot_support\" and \"create_share_from_snapshot_support\" are distinct features supported by share drivers/backends. There are drivers that allow creating snapshots, but don\u0027t allow cloning those snapshots into shares (\"create_share_from_snapshot_support\"). \n\n \n\nSo, while those drivers you can expect to set \"run_snapshot_tests\u003dTrue\", and \"capability_create_share_from_snapshot_support\u003dFalse\" in your tempest configuration. The inverse of this (setting \"capability_create_share_from_snapshot_support\u003dTrue and \"run_snapshot_tests\u003dFalse\") is not a valid configuration.\n\n \n\nThis test verifies that you\u0027re able to create shares with a snapshot, and filter only those shares - so, the skip here must be on \"capability_create_share_from_snapshot_support\"","commit_id":"eb73ad2aeced1e646f9c9fc841aa4f1758611c99"}]}