)]}'
{"id":"openstack%2Fmanila-tempest-plugin~674739","triplet_id":"openstack%2Fmanila-tempest-plugin~master~I5507295baa85bdf911732309d6c1876dc0d5a559","project":"openstack/manila-tempest-plugin","branch":"master","topic":"fix_gluster_ci","hashtags":[],"change_id":"I5507295baa85bdf911732309d6c1876dc0d5a559","subject":"Fix snapshot condition error","status":"ABANDONED","created":"2019-08-06 06:47:18.000000000","updated":"2019-08-07 21:32:21.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c04bc2603553eedf921b1c32f183009f7ff84788","_number":674739,"virtual_id_number":674739,"owner":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-08-06 10:14:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-08-06 11:39:38.000000000","_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"date":"2019-08-07 01:25:58.000000000","_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},{"value":-1,"date":"2019-08-06 17:49:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-06 10:14:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-06 11:39:38.000000000","updated_by":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"reviewer":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-06 17:49:35.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"}],"messages":[{"id":"cac7dfd120021772ef3e4d8334926ad579a29093","author":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"date":"2019-08-06 06:47:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d7b31c6f06c66b5c3b23880a6b1a66e0087abe57","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2019-08-06 07:02:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a75ac5879ede398587901464b6286c1b52b85dfa","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2019-08-06 07:03:02.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks, I\u0027m okay using \"run_snapshot_tests\" over the capability configuration flag - but the assert that you\u0027re modifying should be working. Where do you see this failure?","accounts_in_message":[],"_revision_number":1},{"id":"93db778324c45642a5dada226e61e888bcb5f24f","author":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"date":"2019-08-06 07:51:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1667342e2ea821557416136817e30721ecd373e7","author":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"date":"2019-08-06 07:52:06.000000000","message":"Patch Set 2:\n\n\u003e Thanks, I\u0027m okay using \"run_snapshot_tests\" over the capability\n \u003e configuration flag - but the assert that you\u0027re modifying should be\n \u003e working. Where do you see this failure?\n\nI added detail commit message about this! Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"cf1dcad097277d513e86ee3dd2a2814222eed201","author":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"date":"2019-08-06 08:31:35.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"b4a277772421649d68a2912834c79dc02255166f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 10:14:57.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/39/674739/3/check/openstack-tox-pep8/1c9059d/ : SUCCESS in 3m 09s\n- manila-tempest-dsvm-mysql-generic https://logs.opendev.org/39/674739/3/check/manila-tempest-dsvm-mysql-generic/2da0245/ : SUCCESS in 1h 31m 54s (non-voting)\n- manila-tempest-dsvm-postgres-container https://logs.opendev.org/39/674739/3/check/manila-tempest-dsvm-postgres-container/c60112a/ : SUCCESS in 58m 44s (non-voting)\n- manila-tempest-dsvm-postgres-zfsonlinux https://logs.opendev.org/39/674739/3/check/manila-tempest-dsvm-postgres-zfsonlinux/04fd1e2/ : SUCCESS in 1h 08m 35s (non-voting)\n- manila-tempest-dsvm-postgres-generic-singlebackend https://logs.opendev.org/39/674739/3/check/manila-tempest-dsvm-postgres-generic-singlebackend/2585a25/ : SUCCESS in 1h 04m 31s (non-voting)\n- manila-tempest-dsvm-generic-no-share-servers https://logs.opendev.org/39/674739/3/check/manila-tempest-dsvm-generic-no-share-servers/ef1a457/ : SUCCESS in 1h 27m 08s (non-voting)\n- manila-tempest-dsvm-scenario https://logs.opendev.org/39/674739/3/check/manila-tempest-dsvm-scenario/25e6742/ : SUCCESS in 1h 22m 47s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-native https://logs.opendev.org/39/674739/3/check/manila-tempest-minimal-dsvm-cephfs-native/c213dfd/ : SUCCESS in 26m 09s (non-voting)\n- manila-tempest-minimal-dsvm-cephfs-nfs https://logs.opendev.org/39/674739/3/check/manila-tempest-minimal-dsvm-cephfs-nfs/740e2ca/ : SUCCESS in 1h 27m 50s (non-voting)\n- manila-tempest-minimal-dsvm-dummy https://logs.opendev.org/39/674739/3/check/manila-tempest-minimal-dsvm-dummy/33f5639/ : SUCCESS in 41m 24s\n- manila-tempest-minimal-dsvm-lvm https://logs.opendev.org/39/674739/3/check/manila-tempest-minimal-dsvm-lvm/bafd26e/ : SUCCESS in 1h 04m 59s","accounts_in_message":[],"_revision_number":3},{"id":"9794265e0cfdf0763727bdb73ef6149d788c18fc","author":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"date":"2019-08-06 11:39:38.000000000","message":"Patch Set 3:\n\nBuild failed.\n\n- manila-cDOT-manila-tempest-plugin-ss http://13.56.161.150/logs/39/674739/3/upstream-check/manila-cDOT-manila-tempest-plugin-ss/f47b075/ : SUCCESS in 1h 24m 24s\n- manila-cDOT-manila-tempest-plugin-no-ss http://13.56.161.150/logs/39/674739/3/upstream-check/manila-cDOT-manila-tempest-plugin-no-ss/ae61890/ : FAILURE in 34m 20s\n\nComment \u0027run-netapp-ci\u0027 or \u0027netapp-ci-recheck\u0027 to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_CI","accounts_in_message":[],"_revision_number":3},{"id":"2c75831e66c2c69fe1edb0f1717df9dd3f7bde5e","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2019-08-06 17:49:35.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nHi, please see inline comment.","accounts_in_message":[],"_revision_number":3},{"id":"7eb474907afe3aace04c1c55638a2006cbcc03fe","author":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"date":"2019-08-07 01:25:58.000000000","message":"Patch Set 3:\n\n(1 comment)\n\n\u003e (1 comment)\n \u003e \n \u003e Hi, please see inline comment.\n\nThanks! It was my configuration problem. Does we have any routines for validate configuration? I think We can add this case (setting \"capability_create_share_from_snapshot_support\u003dTrue and \"run_snapshot_tests\u003dFalse\")","accounts_in_message":[],"_revision_number":3},{"id":"6c798a4e8424891f1a4ba25f4ab04ddb811a139e","author":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"date":"2019-08-07 13:54:55.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3},{"id":"ca13b64030c3699de0ba3b1f7b021e55a76c7074","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2019-08-07 21:32:21.000000000","message":"Patch Set 3:\n\n\u003e Thanks! It was my configuration problem. Does we have any routines for validate configuration? I think We can add this case (setting \"capability_create_share_from_snapshot_support\u003dTrue and \"run_snapshot_tests\u003dFalse\")\n\n\nYes, we can have this check in the config hook if that will make things fail fast and early: https://review.opendev.org/#/c/675206/","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"eb73ad2aeced1e646f9c9fc841aa4f1758611c99","revisions":{"738c34e1ebf48d7b7e72343c6b6a9926766cff32":{"kind":"REWORK","_number":1,"created":"2019-08-06 06:47:18.000000000","uploader":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"ref":"refs/changes/39/674739/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila-tempest-plugin","ref":"refs/changes/39/674739/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/1"}}},"commit":{"parents":[{"commit":"267dd04fc7518a274622a9ff341db9ffe479f5ee","subject":"Merge \"Comment test tags\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/267dd04fc7518a274622a9ff341db9ffe479f5ee"}]}],"author":{"name":"whhan91","email":"whhan91@gmail.com","date":"2019-08-06 06:41:03.000000000","tz":0},"committer":{"name":"whhan91","email":"whhan91@gmail.com","date":"2019-08-06 06:46:41.000000000","tz":0},"subject":"Fix gluster ci failure","message":"Fix gluster ci failure\n\n- Delete meaningless(and not working) assert\n- Do snapshot test when run_snapshot_tests is true, not\ncapability_create_share_from_snapshot_support is true.\n\nChange-Id: I5507295baa85bdf911732309d6c1876dc0d5a559\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/738c34e1ebf48d7b7e72343c6b6a9926766cff32"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/738c34e1ebf48d7b7e72343c6b6a9926766cff32"}]},"branch":"refs/heads/master"},"74a31dc08b4737d23ca830d02673d423e531df83":{"kind":"REWORK","_number":2,"created":"2019-08-06 07:51:09.000000000","uploader":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"ref":"refs/changes/39/674739/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila-tempest-plugin","ref":"refs/changes/39/674739/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/2"}}},"commit":{"parents":[{"commit":"267dd04fc7518a274622a9ff341db9ffe479f5ee","subject":"Merge \"Comment test tags\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/267dd04fc7518a274622a9ff341db9ffe479f5ee"}]}],"author":{"name":"whhan91","email":"whhan91@gmail.com","date":"2019-08-06 06:41:03.000000000","tz":0},"committer":{"name":"whhan91","email":"whhan91@gmail.com","date":"2019-08-06 07:40:34.000000000","tz":0},"subject":"Fix gluster ci failure","message":"Fix gluster ci failure\n\nWhen run_snapshot_tests\u003d\u003dfalse but CONF.share.capability_create\n_share_from_snapshot_support\u003d\u003dtrue, resource_setup() makes no\ncls.shares[1] and cls.snap. Check both conditions to make sure\nobject exists.\n\nChange-Id: I5507295baa85bdf911732309d6c1876dc0d5a559\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/74a31dc08b4737d23ca830d02673d423e531df83"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/74a31dc08b4737d23ca830d02673d423e531df83"}]},"branch":"refs/heads/master"},"eb73ad2aeced1e646f9c9fc841aa4f1758611c99":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2019-08-06 08:31:35.000000000","uploader":{"_account_id":30722,"name":"WooHyung Han","email":"techhanx@gmail.com","username":"whhan91"},"ref":"refs/changes/39/674739/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila-tempest-plugin","ref":"refs/changes/39/674739/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila-tempest-plugin refs/changes/39/674739/3"}}},"commit":{"parents":[{"commit":"267dd04fc7518a274622a9ff341db9ffe479f5ee","subject":"Merge \"Comment test tags\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/267dd04fc7518a274622a9ff341db9ffe479f5ee"}]}],"author":{"name":"whhan91","email":"whhan91@gmail.com","date":"2019-08-06 06:41:03.000000000","tz":0},"committer":{"name":"whhan91","email":"whhan91@gmail.com","date":"2019-08-06 07:56:04.000000000","tz":0},"subject":"Fix snapshot condition error","message":"Fix snapshot condition error\n\nWhen run_snapshot_tests\u003d\u003dfalse but CONF.share.capability_create\n_share_from_snapshot_support\u003d\u003dtrue, resource_setup() makes no\ncls.shares[1] and cls.snap. Check both conditions to make sure\nobject exists.\n\nChange-Id: I5507295baa85bdf911732309d6c1876dc0d5a559\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/eb73ad2aeced1e646f9c9fc841aa4f1758611c99"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila-tempest-plugin/commit/eb73ad2aeced1e646f9c9fc841aa4f1758611c99"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}