)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"65313b28a213dde1fd5452094c66ff4746b8869e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vhari \u003cvhariria@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-06 12:42:47 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deleted duplicate line 366"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7033d726c1119c20be492d489f58d257ab9e05e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_086ae0eb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":26},"updated":"2019-08-20 00:15:43.000000000","message":"this doesn\u0027t convey the meaning of this change, for example, it leads to ask the questions: Where is line 366? Which file? Which test?\n\nSee some guidelines regarding commit messages here: https://wiki.openstack.org/wiki/GitCommitMessages\n\nSomething like:\n\n \"Validate shares quota after updating it\" \n\nconveys the meaning of what you\u0027re trying to do","commit_id":"ea01a7400ba144cdbd6c88bea10e54c40885d268"}],"manila_tempest_tests/tests/api/admin/test_quotas_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2431b8e5b03aebf06ab9df1f5172ca43b27a05b8","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        self.shares_v2_client.update_quotas(self.tenant_id, shares\u003d1)"},{"line_number":361,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":362,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.assertRaises(lib_exc.OverLimit,"},{"line_number":366,"context_line":"                          self.create_share,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_9f881d71","side":"PARENT","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":57},"updated":"2019-08-06 16:59:35.000000000","message":"This probably helps in debugging - instead of deleting this line, can you add a verification step to verify the update on line 360?","commit_id":"267dd04fc7518a274622a9ff341db9ffe479f5ee"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"5a0b42c5bfb38f8594f93c70034fd85874075088","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        self.shares_v2_client.update_quotas(self.tenant_id, shares\u003d1)"},{"line_number":361,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":362,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.assertRaises(lib_exc.OverLimit,"},{"line_number":366,"context_line":"                          self.create_share,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5bcf9256","side":"PARENT","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":57},"in_reply_to":"7faddb67_9c2b4093","updated":"2019-08-19 13:17:19.000000000","message":"Done","commit_id":"267dd04fc7518a274622a9ff341db9ffe479f5ee"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d25aa4027c7dfe2f18bfc59a4b3f18d01a3e3927","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        self.shares_v2_client.update_quotas(self.tenant_id, shares\u003d1)"},{"line_number":361,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":362,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.assertRaises(lib_exc.OverLimit,"},{"line_number":366,"context_line":"                          self.create_share,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_7c1e8470","side":"PARENT","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":57},"in_reply_to":"7faddb67_9c2b4093","updated":"2019-08-07 03:53:14.000000000","message":"updated_quota \u003d self.shares_v2_client.show_quotas(self.tenant_id)\nself.assertEqual(1, updated_quota[\u0027shares\u0027])","commit_id":"267dd04fc7518a274622a9ff341db9ffe479f5ee"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"5a0b42c5bfb38f8594f93c70034fd85874075088","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        self.shares_v2_client.update_quotas(self.tenant_id, shares\u003d1)"},{"line_number":361,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":362,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.assertRaises(lib_exc.OverLimit,"},{"line_number":366,"context_line":"                          self.create_share,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_bbe806b3","side":"PARENT","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":57},"in_reply_to":"7faddb67_9f881d71","updated":"2019-08-19 13:17:19.000000000","message":"Done","commit_id":"267dd04fc7518a274622a9ff341db9ffe479f5ee"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f522b7f0e1adc2fe846ea1aeede41a160ee571b3","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        self.shares_v2_client.update_quotas(self.tenant_id, shares\u003d1)"},{"line_number":361,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":362,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.assertRaises(lib_exc.OverLimit,"},{"line_number":366,"context_line":"                          self.create_share,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_9c2b4093","side":"PARENT","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":57},"in_reply_to":"7faddb67_9f881d71","updated":"2019-08-07 03:51:53.000000000","message":"Hi Vida, you can add those two lines to verify the quota shares was updated appropriately:\nupdated_quota \u003d self.shares_v2_client.show_quotas(self.tenant_id)        self.assertEqual(1, updated_quota[\u0027shares\u0027])","commit_id":"267dd04fc7518a274622a9ff341db9ffe479f5ee"}]}
