)]}'
{"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[{"line_number":1973,"context_line":""},{"line_number":1974,"context_line":"###############"},{"line_number":1975,"context_line":""},{"line_number":1976,"context_line":"    def add_subnet(self, **kwargs):"},{"line_number":1977,"context_line":"        # kwargs: share_network_id"},{"line_number":1978,"context_line":"        # availability_zone or availability_zone_id"},{"line_number":1979,"context_line":"        # + for neutron: neutron_net_id, neutron_subnet_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_bd91fc9b","line":1976,"range":{"start_line":1976,"start_character":8,"end_line":1976,"end_character":11},"updated":"2019-09-11 03:32:48.000000000","message":"create","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[{"line_number":1973,"context_line":""},{"line_number":1974,"context_line":"###############"},{"line_number":1975,"context_line":""},{"line_number":1976,"context_line":"    def add_subnet(self, **kwargs):"},{"line_number":1977,"context_line":"        # kwargs: share_network_id"},{"line_number":1978,"context_line":"        # availability_zone or availability_zone_id"},{"line_number":1979,"context_line":"        # + for neutron: neutron_net_id, neutron_subnet_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_5df6c8fb","line":1976,"range":{"start_line":1976,"start_character":27,"end_line":1976,"end_character":33},"updated":"2019-09-11 03:32:48.000000000","message":"please expand this\n\nshare_network_id is always required, rest can be kwargs with None as default","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49bdc8b6cd8da932871cba0f54894a4db0e0451d","unresolved":false,"context_lines":[{"line_number":1973,"context_line":""},{"line_number":1974,"context_line":"###############"},{"line_number":1975,"context_line":""},{"line_number":1976,"context_line":"    def add_subnet(self, **kwargs):"},{"line_number":1977,"context_line":"        # kwargs: share_network_id"},{"line_number":1978,"context_line":"        # availability_zone or availability_zone_id"},{"line_number":1979,"context_line":"        # + for neutron: neutron_net_id, neutron_subnet_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_0bac7d9e","line":1976,"range":{"start_line":1976,"start_character":27,"end_line":1976,"end_character":33},"in_reply_to":"5faad753_5df6c8fb","updated":"2019-09-12 14:25:13.000000000","message":"Expanded this. Also, expanded the delete method name.","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49bdc8b6cd8da932871cba0f54894a4db0e0451d","unresolved":false,"context_lines":[{"line_number":1973,"context_line":""},{"line_number":1974,"context_line":"###############"},{"line_number":1975,"context_line":""},{"line_number":1976,"context_line":"    def add_subnet(self, **kwargs):"},{"line_number":1977,"context_line":"        # kwargs: share_network_id"},{"line_number":1978,"context_line":"        # availability_zone or availability_zone_id"},{"line_number":1979,"context_line":"        # + for neutron: neutron_net_id, neutron_subnet_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_404d7498","line":1976,"range":{"start_line":1976,"start_character":8,"end_line":1976,"end_character":11},"in_reply_to":"5faad753_bd91fc9b","updated":"2019-09-12 14:25:13.000000000","message":"Done","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[{"line_number":1974,"context_line":"###############"},{"line_number":1975,"context_line":""},{"line_number":1976,"context_line":"    def add_subnet(self, **kwargs):"},{"line_number":1977,"context_line":"        # kwargs: share_network_id"},{"line_number":1978,"context_line":"        # availability_zone or availability_zone_id"},{"line_number":1979,"context_line":"        # + for neutron: neutron_net_id, neutron_subnet_id"},{"line_number":1980,"context_line":"        body \u003d json.dumps({\"share-network-subnet\": kwargs})"},{"line_number":1981,"context_line":"        url \u003d \u0027/share-networks/%s/subnets\u0027 % kwargs[\u0027share_network_id\u0027]"},{"line_number":1982,"context_line":"        resp, body \u003d self.post(url, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_bde6dc43","line":1979,"range":{"start_line":1977,"start_character":8,"end_line":1979,"end_character":58},"updated":"2019-09-11 03:32:48.000000000","message":"No need for this if you expand the params above","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1984,"context_line":"        return self._parse_resp(body)"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    def get_subnet(self, sns_id, sn_id):"},{"line_number":1987,"context_line":"        url \u003d (\u0027share-networks/%(network)s/subnets/%(subnet)s\u0027 % {"},{"line_number":1988,"context_line":"            \u0027network\u0027: sn_id,"},{"line_number":1989,"context_line":"            \u0027subnet\u0027: sns_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_ddbab808","line":1986,"range":{"start_line":1986,"start_character":25,"end_line":1986,"end_character":31},"updated":"2019-09-11 03:32:48.000000000","message":"share_network_id","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1984,"context_line":"        return self._parse_resp(body)"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    def get_subnet(self, sns_id, sn_id):"},{"line_number":1987,"context_line":"        url \u003d (\u0027share-networks/%(network)s/subnets/%(subnet)s\u0027 % {"},{"line_number":1988,"context_line":"            \u0027network\u0027: sn_id,"},{"line_number":1989,"context_line":"            \u0027subnet\u0027: sns_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_bdbfbcf9","line":1986,"range":{"start_line":1986,"start_character":33,"end_line":1986,"end_character":38},"updated":"2019-09-11 03:32:48.000000000","message":"share_network_subnet_id","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49bdc8b6cd8da932871cba0f54894a4db0e0451d","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1984,"context_line":"        return self._parse_resp(body)"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    def get_subnet(self, sns_id, sn_id):"},{"line_number":1987,"context_line":"        url \u003d (\u0027share-networks/%(network)s/subnets/%(subnet)s\u0027 % {"},{"line_number":1988,"context_line":"            \u0027network\u0027: sn_id,"},{"line_number":1989,"context_line":"            \u0027subnet\u0027: sns_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_40325412","line":1986,"range":{"start_line":1986,"start_character":33,"end_line":1986,"end_character":38},"in_reply_to":"5faad753_bdbfbcf9","updated":"2019-09-12 14:25:13.000000000","message":"Done","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49bdc8b6cd8da932871cba0f54894a4db0e0451d","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1984,"context_line":"        return self._parse_resp(body)"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    def get_subnet(self, sns_id, sn_id):"},{"line_number":1987,"context_line":"        url \u003d (\u0027share-networks/%(network)s/subnets/%(subnet)s\u0027 % {"},{"line_number":1988,"context_line":"            \u0027network\u0027: sn_id,"},{"line_number":1989,"context_line":"            \u0027subnet\u0027: sns_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_603510f7","line":1986,"range":{"start_line":1986,"start_character":25,"end_line":1986,"end_character":31},"in_reply_to":"5faad753_ddbab808","updated":"2019-09-12 14:25:13.000000000","message":"Done","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[{"line_number":1992,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1993,"context_line":"        return self._parse_resp(body)"},{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"    def delete_subnet(self, sn_id, sns_id):"},{"line_number":1996,"context_line":"        url \u003d (\u0027share-networks/%(network)s/subnets/%(subnet)s\u0027 % {"},{"line_number":1997,"context_line":"            \u0027network\u0027: sn_id,"},{"line_number":1998,"context_line":"            \u0027subnet\u0027: sns_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_7d3704b2","line":1995,"range":{"start_line":1995,"start_character":28,"end_line":1995,"end_character":33},"updated":"2019-09-11 03:32:48.000000000","message":"share_network_id","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[{"line_number":1992,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1993,"context_line":"        return self._parse_resp(body)"},{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"    def delete_subnet(self, sn_id, sns_id):"},{"line_number":1996,"context_line":"        url \u003d (\u0027share-networks/%(network)s/subnets/%(subnet)s\u0027 % {"},{"line_number":1997,"context_line":"            \u0027network\u0027: sn_id,"},{"line_number":1998,"context_line":"            \u0027subnet\u0027: sns_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_9d3a0096","line":1995,"range":{"start_line":1995,"start_character":35,"end_line":1995,"end_character":41},"updated":"2019-09-11 03:32:48.000000000","message":"share_network_subnet_id","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49bdc8b6cd8da932871cba0f54894a4db0e0451d","unresolved":false,"context_lines":[{"line_number":1992,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1993,"context_line":"        return self._parse_resp(body)"},{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"    def delete_subnet(self, sn_id, sns_id):"},{"line_number":1996,"context_line":"        url \u003d (\u0027share-networks/%(network)s/subnets/%(subnet)s\u0027 % {"},{"line_number":1997,"context_line":"            \u0027network\u0027: sn_id,"},{"line_number":1998,"context_line":"            \u0027subnet\u0027: sns_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_003c5ce0","line":1995,"range":{"start_line":1995,"start_character":28,"end_line":1995,"end_character":33},"in_reply_to":"5faad753_7d3704b2","updated":"2019-09-12 14:25:13.000000000","message":"Done","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49bdc8b6cd8da932871cba0f54894a4db0e0451d","unresolved":false,"context_lines":[{"line_number":1992,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1993,"context_line":"        return self._parse_resp(body)"},{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"    def delete_subnet(self, sn_id, sns_id):"},{"line_number":1996,"context_line":"        url \u003d (\u0027share-networks/%(network)s/subnets/%(subnet)s\u0027 % {"},{"line_number":1997,"context_line":"            \u0027network\u0027: sn_id,"},{"line_number":1998,"context_line":"            \u0027subnet\u0027: sns_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_203f18d7","line":1995,"range":{"start_line":1995,"start_character":35,"end_line":1995,"end_character":41},"in_reply_to":"5faad753_9d3a0096","updated":"2019-09-12 14:25:13.000000000","message":"Done","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"}],"manila_tempest_tests/tests/api/admin/test_share_servers_manage.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                      \"share_network.\")"},{"line_number":150,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":151,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":152,"context_line":"    def test_manage_share_server_with_subnet(self):"},{"line_number":153,"context_line":"        # create a new share network to make sure that a new share server"},{"line_number":154,"context_line":"        # will be created"},{"line_number":155,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_56910752","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":51},"updated":"2019-09-17 19:20:42.000000000","message":"You can deduce this with the above test case with ddt..","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                      \"share_network.\")"},{"line_number":150,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":151,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":152,"context_line":"    def test_manage_share_server_with_subnet(self):"},{"line_number":153,"context_line":"        # create a new share network to make sure that a new share server"},{"line_number":154,"context_line":"        # will be created"},{"line_number":155,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_23bd1665","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":51},"in_reply_to":"3fa7e38b_56910752","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"0050837babc9ba5da6696662b5ec6bc49d193215","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                    net_info \u003d ("},{"line_number":365,"context_line":"                        utils.share_network_get_default_subnet(sn)"},{"line_number":366,"context_line":"                        if utils.share_network_subnet_support() else sn)"},{"line_number":367,"context_line":"                    if(net_info[\"neutron_net_id\"] is None and"},{"line_number":368,"context_line":"                            net_info[\"neutron_subnet_id\"] is None and"},{"line_number":369,"context_line":"                            sn[\"name\"] and search_word in sn[\"name\"]):"},{"line_number":370,"context_line":"                        share_network_id \u003d sn[\"id\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_9d5b8584","line":367,"range":{"start_line":367,"start_character":20,"end_line":367,"end_character":61},"updated":"2019-09-03 16:42:10.000000000","message":"It is good to check if net_info isn\u0027t None, before accessing its info. There are scenarios where the share-network may have only a subnet that is not the default:\n\nif not net_info:\n    continue","commit_id":"ffdf7b0f7365865407692bc4369b91335c26c88f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"0050837babc9ba5da6696662b5ec6bc49d193215","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                        net_info \u003d ("},{"line_number":408,"context_line":"                            utils.share_network_get_default_subnet(sn)"},{"line_number":409,"context_line":"                            if utils.share_network_subnet_support() else sn)"},{"line_number":410,"context_line":"                        if (net_id \u003d\u003d net_info[\"neutron_net_id\"] and"},{"line_number":411,"context_line":"                                subnet_id \u003d\u003d net_info[\"neutron_subnet_id\"] and"},{"line_number":412,"context_line":"                                sn[\"name\"] and search_word in sn[\"name\"]):"},{"line_number":413,"context_line":"                            share_network_id \u003d sn[\"id\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5d518d61","line":410,"range":{"start_line":410,"start_character":24,"end_line":410,"end_character":68},"updated":"2019-09-03 16:42:10.000000000","message":"Same as above.","commit_id":"ffdf7b0f7365865407692bc4369b91335c26c88f"}],"manila_tempest_tests/tests/api/test_share_network_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3fa7e38b_36f80bc3","updated":"2019-09-17 19:20:42.000000000","message":"Add a DHSS\u003dTrue test case to:\n\n - Create a share network without an AZ (i.e., ensure default subnet gets created)\n - Create a subnet with another AZ (skip the test if only one-AZ is present)\n - Create a share specifying the subnet\u0027s AZ and the share network\n\nYou need to assert that the share gets scheduled to the subnet\u0027s AZ and not any other AZ.","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3fa7e38b_c3b1a291","in_reply_to":"3fa7e38b_36f80bc3","updated":"2019-09-18 21:10:33.000000000","message":"Great. Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 NetApp Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_d632d7a7","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2019-09-17 19:20:42.000000000","message":"Add a DHSS\u003dTrue test case to:\n\n(Skip the test if there\u0027s only one AZ)\n\n- Create a share network with default subnet\n- Create a subnet for each of the available AZ except one \n- Create a share with the AZ excluded\n\nThis will prove that the default subnet is indeed working as expected.","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 NetApp Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_e3ae1e2d","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"in_reply_to":"3fa7e38b_d632d7a7","updated":"2019-09-18 21:10:33.000000000","message":"Good idea. Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # create share network"},{"line_number":48,"context_line":"        created \u003d self.create_share_network_subnet(**data)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertDictContainsSubset(data, created)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Delete the subnets"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_367d6b1c","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":0},"updated":"2019-09-17 19:20:42.000000000","message":"add \"share_network_name\" to data for verification... \n\nAlso, ensure only expected keys are present.","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # create share network"},{"line_number":48,"context_line":"        created \u003d self.create_share_network_subnet(**data)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertDictContainsSubset(data, created)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Delete the subnets"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_83abaa1b","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":0},"in_reply_to":"3fa7e38b_367d6b1c","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # Match new subnet content"},{"line_number":75,"context_line":"        self.assertDictContainsSubset(data, created)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        [self.assertIn(key, created.keys()) for key in keys]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Delete the subnets"},{"line_number":80,"context_line":"        self.shares_v2_client.delete_subnet(share_network[\u0027id\u0027], created[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_98cf7aaf","line":77,"range":{"start_line":77,"start_character":28,"end_line":77,"end_character":42},"updated":"2019-09-20 06:00:57.000000000","message":"list(created.keys())","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # Match new subnet content"},{"line_number":75,"context_line":"        self.assertDictContainsSubset(data, created)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        [self.assertIn(key, created.keys()) for key in keys]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Delete the subnets"},{"line_number":80,"context_line":"        self.shares_v2_client.delete_subnet(share_network[\u0027id\u0027], created[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_396d1e04","line":77,"range":{"start_line":77,"start_character":28,"end_line":77,"end_character":42},"in_reply_to":"3fa7e38b_98cf7aaf","updated":"2019-09-20 17:00:42.000000000","message":"Done","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertDictContainsSubset(data, created)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        [self.assertIn(key, created.keys()) for key in keys]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Delete the subnets"},{"line_number":80,"context_line":"        self.shares_v2_client.delete_subnet(share_network[\u0027id\u0027], created[\u0027id\u0027])"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_78ccfebb","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":0},"updated":"2019-09-20 06:00:57.000000000","message":"you can replace the above assert with:\n\n self.assertEqual(sorted(keys), sorted(list(created.keys())))\n\nThis strictly checks for keys so we can catch unversioned API schema changes.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertDictContainsSubset(data, created)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        [self.assertIn(key, created.keys()) for key in keys]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Delete the subnets"},{"line_number":80,"context_line":"        self.shares_v2_client.delete_subnet(share_network[\u0027id\u0027], created[\u0027id\u0027])"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_f90d463e","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":0},"in_reply_to":"3fa7e38b_78ccfebb","updated":"2019-09-20 17:00:42.000000000","message":"Done","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                                            created[\u0027id\u0027])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":108,"context_line":"    @testtools.skipIf("},{"line_number":109,"context_line":"        not CONF.share.multitenancy_enabled, \"Only for multitenancy.\")"},{"line_number":110,"context_line":"    def test_create_share_on_subnet_with_availability_zone(self):"},{"line_number":111,"context_line":"        compatible_azs \u003d self.get_availability_zones_matching_share_type("},{"line_number":112,"context_line":"            self.share_type)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_18bb8a0e","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":70},"updated":"2019-09-20 06:00:57.000000000","message":"also skip this test if a single share network is configured.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                                            created[\u0027id\u0027])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":108,"context_line":"    @testtools.skipIf("},{"line_number":109,"context_line":"        not CONF.share.multitenancy_enabled, \"Only for multitenancy.\")"},{"line_number":110,"context_line":"    def test_create_share_on_subnet_with_availability_zone(self):"},{"line_number":111,"context_line":"        compatible_azs \u003d self.get_availability_zones_matching_share_type("},{"line_number":112,"context_line":"            self.share_type)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_3409a32b","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":70},"in_reply_to":"3fa7e38b_18bb8a0e","updated":"2019-09-20 17:00:42.000000000","message":"Done","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        compatible_azs \u003d self.get_availability_zones_matching_share_type("},{"line_number":112,"context_line":"            self.share_type)"},{"line_number":113,"context_line":"        if len(compatible_azs) \u003c 2:"},{"line_number":114,"context_line":"            msg \u003d (\"Create a share using multiple subnets need at least 2 \""},{"line_number":115,"context_line":"                   \"compatible availability zones.\")"},{"line_number":116,"context_line":"            raise self.skipException(msg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_b837d6b0","line":115,"range":{"start_line":114,"start_character":20,"end_line":115,"end_character":50},"updated":"2019-09-20 06:00:57.000000000","message":"This test needs at least two compatible storage availability zones.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        compatible_azs \u003d self.get_availability_zones_matching_share_type("},{"line_number":112,"context_line":"            self.share_type)"},{"line_number":113,"context_line":"        if len(compatible_azs) \u003c 2:"},{"line_number":114,"context_line":"            msg \u003d (\"Create a share using multiple subnets need at least 2 \""},{"line_number":115,"context_line":"                   \"compatible availability zones.\")"},{"line_number":116,"context_line":"            raise self.skipException(msg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_f4122b58","line":115,"range":{"start_line":114,"start_character":20,"end_line":115,"end_character":50},"in_reply_to":"3fa7e38b_b837d6b0","updated":"2019-09-20 17:00:42.000000000","message":"Done","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        share_network \u003d self.create_share_network("},{"line_number":124,"context_line":"            neutron_net_id\u003dshare_net_info[\u0027neutron_net_id\u0027],"},{"line_number":125,"context_line":"            neutron_subnet_id\u003dshare_net_info[\u0027neutron_subnet_id\u0027],"},{"line_number":126,"context_line":"            cleanup_in_class\u003dTrue"},{"line_number":127,"context_line":"        )"},{"line_number":128,"context_line":"        share_network \u003d self.shares_v2_client.get_share_network("},{"line_number":129,"context_line":"            share_network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_5846e223","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":28},"updated":"2019-09-20 06:00:57.000000000","message":"why?","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        share_network \u003d self.create_share_network("},{"line_number":124,"context_line":"            neutron_net_id\u003dshare_net_info[\u0027neutron_net_id\u0027],"},{"line_number":125,"context_line":"            neutron_subnet_id\u003dshare_net_info[\u0027neutron_subnet_id\u0027],"},{"line_number":126,"context_line":"            cleanup_in_class\u003dTrue"},{"line_number":127,"context_line":"        )"},{"line_number":128,"context_line":"        share_network \u003d self.shares_v2_client.get_share_network("},{"line_number":129,"context_line":"            share_network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_94797794","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":28},"in_reply_to":"3fa7e38b_5846e223","updated":"2019-09-20 17:00:42.000000000","message":"Was a bad C\u0026P here, for sure we don\u0027t to delete it only in the class teardown.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        compatible_azs \u003d self.get_availability_zones_matching_share_type("},{"line_number":177,"context_line":"            self.share_type)"},{"line_number":178,"context_line":"        if len(compatible_azs) \u003c 2:"},{"line_number":179,"context_line":"            msg \u003d (\"Create a share using with multiple subnets need at least \""},{"line_number":180,"context_line":"                   \"2 availability zones.\")"},{"line_number":181,"context_line":"            raise self.skipException(msg)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_98445a1d","line":180,"range":{"start_line":179,"start_character":20,"end_line":180,"end_character":41},"updated":"2019-09-20 06:00:57.000000000","message":"This test needs atleast two compatible storage availability zones.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        compatible_azs \u003d self.get_availability_zones_matching_share_type("},{"line_number":177,"context_line":"            self.share_type)"},{"line_number":178,"context_line":"        if len(compatible_azs) \u003c 2:"},{"line_number":179,"context_line":"            msg \u003d (\"Create a share using with multiple subnets need at least \""},{"line_number":180,"context_line":"                   \"2 availability zones.\")"},{"line_number":181,"context_line":"            raise self.skipException(msg)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        original_share_network \u003d self.shares_v2_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_d45e0f11","line":180,"range":{"start_line":179,"start_character":20,"end_line":180,"end_character":41},"in_reply_to":"3fa7e38b_98445a1d","updated":"2019-09-20 17:00:42.000000000","message":"Done","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        share_network \u003d self.create_share_network("},{"line_number":189,"context_line":"            neutron_net_id\u003dshare_net_info[\u0027neutron_net_id\u0027],"},{"line_number":190,"context_line":"            neutron_subnet_id\u003dshare_net_info[\u0027neutron_subnet_id\u0027],"},{"line_number":191,"context_line":"            cleanup_in_class\u003dTrue"},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        share_network \u003d self.shares_v2_client.get_share_network("},{"line_number":194,"context_line":"            share_network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_f8546ecc","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":33},"updated":"2019-09-20 06:00:57.000000000","message":"why?","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        share_network \u003d self.create_share_network("},{"line_number":189,"context_line":"            neutron_net_id\u003dshare_net_info[\u0027neutron_net_id\u0027],"},{"line_number":190,"context_line":"            neutron_subnet_id\u003dshare_net_info[\u0027neutron_subnet_id\u0027],"},{"line_number":191,"context_line":"            cleanup_in_class\u003dTrue"},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        share_network \u003d self.shares_v2_client.get_share_network("},{"line_number":194,"context_line":"            share_network[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_347e836b","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":33},"in_reply_to":"3fa7e38b_f8546ecc","updated":"2019-09-20 17:00:42.000000000","message":"Removed. Same as above.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # Create a new share in the selected availability zone"},{"line_number":214,"context_line":"        share \u003d self.create_share("},{"line_number":215,"context_line":"            share_type_id\u003dself.share_type_id,"},{"line_number":216,"context_line":"            share_network_id\u003dshare_network[\u0027id\u0027],"},{"line_number":217,"context_line":"            availability_zone\u003ddefault_availability_zone)"},{"line_number":218,"context_line":"        # The \u0027status\u0027 of the share returned by the create API must be"},{"line_number":219,"context_line":"        # set and have value either \u0027creating\u0027 or \u0027available\u0027 (if share"},{"line_number":220,"context_line":"        # creation is really fast as in case of Dummy driver)."}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_d863b2b0","line":217,"range":{"start_line":216,"start_character":49,"end_line":217,"end_character":55},"updated":"2019-09-20 06:00:57.000000000","message":"No, don\u0027t provide the AZ\n\nThis share needs to end up on the default_availability_zone without being explicitly told to; i.e., we\u0027re testing the API/scheduler action in figuring out the AZ here...","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # Create a new share in the selected availability zone"},{"line_number":214,"context_line":"        share \u003d self.create_share("},{"line_number":215,"context_line":"            share_type_id\u003dself.share_type_id,"},{"line_number":216,"context_line":"            share_network_id\u003dshare_network[\u0027id\u0027],"},{"line_number":217,"context_line":"            availability_zone\u003ddefault_availability_zone)"},{"line_number":218,"context_line":"        # The \u0027status\u0027 of the share returned by the create API must be"},{"line_number":219,"context_line":"        # set and have value either \u0027creating\u0027 or \u0027available\u0027 (if share"},{"line_number":220,"context_line":"        # creation is really fast as in case of Dummy driver)."}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_ef69f8bd","line":217,"range":{"start_line":216,"start_character":49,"end_line":217,"end_character":55},"in_reply_to":"3fa7e38b_d863b2b0","updated":"2019-09-20 17:00:42.000000000","message":"Got it. I uploaded a updated version of this test, so we can have both scenarios, passing an AZ that is associated to a fallback subnet or not providing an AZ at all.\nBy not setting the AZ on share creation, we end up with the share being scheduled to any compatible AZ, not to the one associated to the default subnet. The scheduler will choose a suitable AZ to place the share, and we need to guarantee that the subnet associated to this AZ is that same that is assigned to the share\u0027s share-server.\nLet me know if this is the expected behavior for you. For us, the behavior should be the same as was before adding the subnets feature.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f5ea8bb405b0034cbb7000b3933f6724d239ad18","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.assertDictContainsSubset(data, subnet)"},{"line_number":164,"context_line":"        # Match share server subnet"},{"line_number":165,"context_line":"        self.assertEqual(subnet[\u0027id\u0027],"},{"line_number":166,"context_line":"                         share_server[\u0027share_network_subnet_id\u0027])"},{"line_number":167,"context_line":"        # Delete share"},{"line_number":168,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":169,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_aff3009e","line":166,"range":{"start_line":166,"start_character":64,"end_line":166,"end_character":65},"updated":"2019-09-20 17:34:03.000000000","message":"add assert for AZ too...","commit_id":"b7e27e7719a2319e8df9a170456d605619af7008"}],"manila_tempest_tests/tests/api/test_share_network_subnets_negative.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"dc7abdc198bd1cce219084cc13281705f637312a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_76840a5e","updated":"2019-08-27 20:22:23.000000000","message":"What about adding more tests like:\n - Add a second subnet using the same az\n - Add a second default subnet","commit_id":"e35adc33b1b98e3863b6aa47cf81cece841cc1c0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0c1edc9c9085703dd6f1b77268576e68622f15f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_016f3d92","in_reply_to":"7faddb67_76840a5e","updated":"2019-09-02 18:32:28.000000000","message":"Done","commit_id":"e35adc33b1b98e3863b6aa47cf81cece841cc1c0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.shares_v2_client.delete_subnet(self.share_network_id,"},{"line_number":118,"context_line":"                                            subnet[\u0027id\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":121,"context_line":"                          self.shares_v2_client.get_subnet,"},{"line_number":122,"context_line":"                          subnet[\u0027id\u0027],"},{"line_number":123,"context_line":"                          self.share_network[\u0027id\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.share.multitenancy_enabled,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_16514fd9","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":51},"updated":"2019-09-17 19:20:42.000000000","message":"add an assert that the share network still exists.","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.shares_v2_client.delete_subnet(self.share_network_id,"},{"line_number":118,"context_line":"                                            subnet[\u0027id\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":121,"context_line":"                          self.shares_v2_client.get_subnet,"},{"line_number":122,"context_line":"                          subnet[\u0027id\u0027],"},{"line_number":123,"context_line":"                          self.share_network[\u0027id\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.share.multitenancy_enabled,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_a3a8261f","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":51},"in_reply_to":"3fa7e38b_16514fd9","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                          self.share_network[\u0027id\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.share.multitenancy_enabled,"},{"line_number":127,"context_line":"                      \u0027Can run only with drivers that do handle share servers \u0027"},{"line_number":128,"context_line":"                      \u0027creation. Skipping.\u0027)"},{"line_number":129,"context_line":"    def test_delete_contains_share_servers(self):"},{"line_number":130,"context_line":"        # Get a compatible availability zone"},{"line_number":131,"context_line":"        az \u003d self.get_availability_zones_matching_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_56e34706","line":128,"range":{"start_line":126,"start_character":0,"end_line":128,"end_character":44},"updated":"2019-09-17 19:20:42.000000000","message":"Skip when manage_unmanage tests are disabled","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                          self.share_network[\u0027id\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.share.multitenancy_enabled,"},{"line_number":127,"context_line":"                      \u0027Can run only with drivers that do handle share servers \u0027"},{"line_number":128,"context_line":"                      \u0027creation. Skipping.\u0027)"},{"line_number":129,"context_line":"    def test_delete_contains_share_servers(self):"},{"line_number":130,"context_line":"        # Get a compatible availability zone"},{"line_number":131,"context_line":"        az \u003d self.get_availability_zones_matching_share_type("}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_4363721b","line":128,"range":{"start_line":126,"start_character":0,"end_line":128,"end_character":44},"in_reply_to":"3fa7e38b_56e34706","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.share.multitenancy_enabled,"},{"line_number":127,"context_line":"                      \u0027Can run only with drivers that do handle share servers \u0027"},{"line_number":128,"context_line":"                      \u0027creation. Skipping.\u0027)"},{"line_number":129,"context_line":"    def test_delete_contains_share_servers(self):"},{"line_number":130,"context_line":"        # Get a compatible availability zone"},{"line_number":131,"context_line":"        az \u003d self.get_availability_zones_matching_share_type("},{"line_number":132,"context_line":"            self.share_type)[0]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_965e9fe4","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":42},"updated":"2019-09-17 19:20:42.000000000","message":"...contains_unmanaged_share_servers","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    @testtools.skipIf(not CONF.share.multitenancy_enabled,"},{"line_number":127,"context_line":"                      \u0027Can run only with drivers that do handle share servers \u0027"},{"line_number":128,"context_line":"                      \u0027creation. Skipping.\u0027)"},{"line_number":129,"context_line":"    def test_delete_contains_share_servers(self):"},{"line_number":130,"context_line":"        # Get a compatible availability zone"},{"line_number":131,"context_line":"        az \u003d self.get_availability_zones_matching_share_type("},{"line_number":132,"context_line":"            self.share_type)[0]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_6368eef4","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":42},"in_reply_to":"3fa7e38b_965e9fe4","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self._delete_share_server_and_wait(share[\u0027share_server_id\u0027])"},{"line_number":192,"context_line":"        self.shares_v2_client.delete_subnet(share_network_id,"},{"line_number":193,"context_line":"                                            subnet[\u0027id\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":196,"context_line":"    def test_delete_subnet_share_network_not_found(self):"},{"line_number":197,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_f66cb39d","line":194,"range":{"start_line":194,"start_character":0,"end_line":194,"end_character":0},"updated":"2019-09-17 19:20:42.000000000","message":"Can you add a test case that prevents deletion of a subnet \u0026 a share network if a share exists?","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self._delete_share_server_and_wait(share[\u0027share_server_id\u0027])"},{"line_number":192,"context_line":"        self.shares_v2_client.delete_subnet(share_network_id,"},{"line_number":193,"context_line":"                                            subnet[\u0027id\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":196,"context_line":"    def test_delete_subnet_share_network_not_found(self):"},{"line_number":197,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_2372f6e6","line":194,"range":{"start_line":194,"start_character":0,"end_line":194,"end_character":0},"in_reply_to":"3fa7e38b_f66cb39d","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"}],"manila_tempest_tests/tests/api/test_share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                \"network_type\", \"cidr\", \"ip_version\", \"neutron_net_id\","},{"line_number":84,"context_line":"                \"neutron_subnet_id\", \"segmentation_id\", \"gateway\", \"mtu\""},{"line_number":85,"context_line":"            ]"},{"line_number":86,"context_line":"            [keys.remove(key) for key in subnet_keys]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_d6889772","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":53},"updated":"2019-09-17 19:20:42.000000000","message":"keys \u003d list(set(keys) - set(subnet_keys))","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                \"network_type\", \"cidr\", \"ip_version\", \"neutron_net_id\","},{"line_number":84,"context_line":"                \"neutron_subnet_id\", \"segmentation_id\", \"gateway\", \"mtu\""},{"line_number":85,"context_line":"            ]"},{"line_number":86,"context_line":"            [keys.remove(key) for key in subnet_keys]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_c37682d9","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":53},"in_reply_to":"3fa7e38b_d6889772","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                \"neutron_subnet_id\", \"segmentation_id\", \"gateway\", \"mtu\""},{"line_number":85,"context_line":"            ]"},{"line_number":86,"context_line":"            [keys.remove(key) for key in subnet_keys]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_3669ebbd","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":0},"updated":"2019-09-17 19:20:42.000000000","message":"with 2.51 you should have \"subnets\"","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                \"neutron_subnet_id\", \"segmentation_id\", \"gateway\", \"mtu\""},{"line_number":85,"context_line":"            ]"},{"line_number":86,"context_line":"            [keys.remove(key) for key in subnet_keys]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_f6e59339","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":0},"updated":"2019-09-17 19:20:42.000000000","message":"with 2.51, this API includes these \"subnet_keys\" in \"subnets\", so:\n\n  for subnet in sn[\u0027subnets\u0027]:\n      [self.assertIn(key, subnet.keys()) for key in subnet_keys]","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                \"neutron_subnet_id\", \"segmentation_id\", \"gateway\", \"mtu\""},{"line_number":85,"context_line":"            ]"},{"line_number":86,"context_line":"            [keys.remove(key) for key in subnet_keys]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_e3737ee6","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":0},"in_reply_to":"3fa7e38b_3669ebbd","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                \"neutron_subnet_id\", \"segmentation_id\", \"gateway\", \"mtu\""},{"line_number":85,"context_line":"            ]"},{"line_number":86,"context_line":"            [keys.remove(key) for key in subnet_keys]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_83808a8d","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":0},"in_reply_to":"3fa7e38b_f6e59339","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            keys \u003d list(set(keys) - set(subnet_keys))"},{"line_number":87,"context_line":"            keys.append(\u0027share_network_subnets\u0027)"},{"line_number":88,"context_line":"            for sn in listed:"},{"line_number":89,"context_line":"                [self.assertIn(key, subnet.keys()) for key in subnet_keys"},{"line_number":90,"context_line":"                 for subnet in sn[\u0027share_network_subnets\u0027]]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_38f9a6c7","line":89,"range":{"start_line":89,"start_character":36,"end_line":89,"end_character":49},"updated":"2019-09-20 06:00:57.000000000","message":"list(subnet.keys())\n\n\nhttps://www.python.org/dev/peps/pep-3106/","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            keys \u003d list(set(keys) - set(subnet_keys))"},{"line_number":87,"context_line":"            keys.append(\u0027share_network_subnets\u0027)"},{"line_number":88,"context_line":"            for sn in listed:"},{"line_number":89,"context_line":"                [self.assertIn(key, subnet.keys()) for key in subnet_keys"},{"line_number":90,"context_line":"                 for subnet in sn[\u0027share_network_subnets\u0027]]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        [self.assertIn(key, sn.keys()) for sn in listed for key in keys]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_2fa5d004","line":89,"range":{"start_line":89,"start_character":36,"end_line":89,"end_character":49},"in_reply_to":"3fa7e38b_38f9a6c7","updated":"2019-09-20 17:00:42.000000000","message":"Done. Thanks for pointing this out.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"}],"manila_tempest_tests/tests/api/test_share_networks_negative.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"dc7abdc198bd1cce219084cc13281705f637312a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_56022ebc","updated":"2019-08-27 20:22:23.000000000","message":"What about adding more tests like:\n - Create a share network in an invalid az","commit_id":"e35adc33b1b98e3863b6aa47cf81cece841cc1c0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0c1edc9c9085703dd6f1b77268576e68622f15f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_e9af6ddd","in_reply_to":"7faddb67_56022ebc","updated":"2019-09-02 18:32:28.000000000","message":"Done","commit_id":"e35adc33b1b98e3863b6aa47cf81cece841cc1c0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.assertEqual(0, len(share_networks))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":146,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":147,"context_line":"    def test_delete_share_network_contains_more_than_one_subnet(self):"},{"line_number":148,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":149,"context_line":"        az \u003d self.shares_v2_client.list_availability_zones()[0]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_5647c71e","line":146,"range":{"start_line":146,"start_character":37,"end_line":146,"end_character":57},"updated":"2019-09-17 19:20:42.000000000","message":"TAG_API","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.assertEqual(0, len(share_networks))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":146,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":147,"context_line":"    def test_delete_share_network_contains_more_than_one_subnet(self):"},{"line_number":148,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":149,"context_line":"        az \u003d self.shares_v2_client.list_availability_zones()[0]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_a37d86b2","line":146,"range":{"start_line":146,"start_character":37,"end_line":146,"end_character":57},"in_reply_to":"3fa7e38b_5647c71e","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        )"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        self.shares_v2_client.delete_subnet(share_network[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":170,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":171,"context_line":"    def test_create_share_network_inexistent_az(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_603d5dba","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":0},"updated":"2019-09-17 19:20:42.000000000","message":"After this, can you assert that the default subnet, created on line 148, is still present?","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        )"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        self.shares_v2_client.delete_subnet(share_network[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":170,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":171,"context_line":"    def test_create_share_network_inexistent_az(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_434cd29d","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":0},"in_reply_to":"3fa7e38b_603d5dba","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.shares_v2_client.delete_subnet(share_network[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":170,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":171,"context_line":"    def test_create_share_network_inexistent_az(self):"},{"line_number":172,"context_line":"        self.assertRaises("},{"line_number":173,"context_line":"            lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_a00d9538","line":170,"range":{"start_line":170,"start_character":37,"end_line":170,"end_character":57},"updated":"2019-09-17 19:20:42.000000000","message":"TAG_API","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.shares_v2_client.delete_subnet(share_network[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":170,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":171,"context_line":"    def test_create_share_network_inexistent_az(self):"},{"line_number":172,"context_line":"        self.assertRaises("},{"line_number":173,"context_line":"            lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_6351ce36","line":170,"range":{"start_line":170,"start_character":37,"end_line":170,"end_character":57},"in_reply_to":"3fa7e38b_a00d9538","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a18314d1bedd333c3ff2394b2265a1003cf4e6a9","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.assertRaises("},{"line_number":173,"context_line":"            lib_exc.BadRequest,"},{"line_number":174,"context_line":"            self.shares_v2_client.create_share_network,"},{"line_number":175,"context_line":"            availability_zone\u003d\u0027az_name\u0027,"},{"line_number":176,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_2019a578","line":175,"range":{"start_line":175,"start_character":31,"end_line":175,"end_character":38},"updated":"2019-09-17 19:20:42.000000000","message":"use something more bizarre, like \"inexistent-availability-zone\"","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b83350ac6fab32e61263933d09e741d4f895257f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.assertRaises("},{"line_number":173,"context_line":"            lib_exc.BadRequest,"},{"line_number":174,"context_line":"            self.shares_v2_client.create_share_network,"},{"line_number":175,"context_line":"            availability_zone\u003d\u0027az_name\u0027,"},{"line_number":176,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_0346da7d","line":175,"range":{"start_line":175,"start_character":31,"end_line":175,"end_character":38},"in_reply_to":"3fa7e38b_2019a578","updated":"2019-09-18 21:10:33.000000000","message":"Done","commit_id":"9141c23902f75881d2916e29fa8d63a06ee70794"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.assertEqual(0, len(share_networks))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":146,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":147,"context_line":"    def test_delete_share_network_contains_more_than_one_subnet(self):"},{"line_number":148,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":149,"context_line":"        az \u003d self.shares_v2_client.list_availability_zones()[0]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_b82ef640","line":146,"range":{"start_line":146,"start_character":37,"end_line":146,"end_character":44},"updated":"2019-09-20 06:00:57.000000000","message":"actually, I\u0027m sorry - TAG_API can be used to test manila API in isolation - So the idea is that you can turn off all manila services except manila-api, and run these API-only tests..\n\nSince you\u0027re reading the AZs in this test, there won\u0027t be any if you aren\u0027t running the scheduler and share service... so, TAG_API_WITH_BACKEND was correct.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.assertEqual(0, len(share_networks))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":146,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":147,"context_line":"    def test_delete_share_network_contains_more_than_one_subnet(self):"},{"line_number":148,"context_line":"        share_network \u003d self.create_share_network()"},{"line_number":149,"context_line":"        az \u003d self.shares_v2_client.list_availability_zones()[0]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_8f872462","line":146,"range":{"start_line":146,"start_character":37,"end_line":146,"end_character":44},"in_reply_to":"3fa7e38b_b82ef640","updated":"2019-09-20 17:00:42.000000000","message":"Np, moved back to TAG_API_WITH_BACKEND.","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c024951ba14f39f6b0e52c0bb9c53bff53c6c4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.assertIsNone(default_subnet[\u0027availability_zone\u0027])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":174,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":175,"context_line":"    def test_create_share_network_inexistent_az(self):"},{"line_number":176,"context_line":"        self.assertRaises("},{"line_number":177,"context_line":"            lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_d83172a4","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":44},"updated":"2019-09-20 06:00:57.000000000","message":"same comment as above","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb698d97358130d33acca52d8f93d386f631a138","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.assertIsNone(default_subnet[\u0027availability_zone\u0027])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @base.skip_if_microversion_lt(\"2.51\")"},{"line_number":174,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":175,"context_line":"    def test_create_share_network_inexistent_az(self):"},{"line_number":176,"context_line":"        self.assertRaises("},{"line_number":177,"context_line":"            lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_4f812c4a","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":44},"in_reply_to":"3fa7e38b_d83172a4","updated":"2019-09-20 17:00:42.000000000","message":"Done","commit_id":"d6e79c4b0c4592769f821aaed35cdb0ed6c53e63"}],"manila_tempest_tests/tests/api/test_shares_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5faad753_9d63e0b1","updated":"2019-09-11 03:32:48.000000000","message":"revert whitespace changes to this file..","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49bdc8b6cd8da932871cba0f54894a4db0e0451d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5faad753_2018787f","in_reply_to":"5faad753_9d63e0b1","updated":"2019-09-12 14:25:13.000000000","message":"Done","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"}],"manila_tempest_tests/utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2050f21319f4820c24c4c0e887cc3bff6460221","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            \"microversion \u003c 2.49\")"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"def share_network_subnet_support():"},{"line_number":184,"context_line":"    return is_microversion_supported(SHARE_NETWORK_SUBNETS_MICROVERSION)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_1d461023","line":183,"range":{"start_line":183,"start_character":4,"end_line":183,"end_character":32},"updated":"2019-09-11 03:32:48.000000000","message":"share_network_subnets_are_supported","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49bdc8b6cd8da932871cba0f54894a4db0e0451d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            \"microversion \u003c 2.49\")"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"def share_network_subnet_support():"},{"line_number":184,"context_line":"    return is_microversion_supported(SHARE_NETWORK_SUBNETS_MICROVERSION)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_ebd80180","line":183,"range":{"start_line":183,"start_character":4,"end_line":183,"end_character":32},"in_reply_to":"5faad753_1d461023","updated":"2019-09-12 14:25:13.000000000","message":"Done","commit_id":"34396e69c40846411fbcd7be29398d8ef5a5ec43"}]}