)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"30f07182e73e15a28ee6972c2f66c4227ac9d1de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vhari \u003cvhariria@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-20 19:47:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added code, line 362-362, to verify shares quota after updating it."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idd3396834ca204b51671e4422a6223754342e21f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_c2cd7130","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":29},"updated":"2019-08-20 19:57:15.000000000","message":"Please remove - line numbers do not convey much meaning to tests","commit_id":"21f80562900c0155fcf466f7407b008894144637"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"30f07182e73e15a28ee6972c2f66c4227ac9d1de","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-08-20 19:47:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added code, line 362-362, to verify shares quota after updating it."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idd3396834ca204b51671e4422a6223754342e21f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_e29e6d04","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":0},"updated":"2019-08-20 19:57:15.000000000","message":"Please take a look at commit message conventions here: https://wiki.openstack.org/wiki/GitCommitMessages\n\nThe header line of the commit message should be \u003c50 characters when possible. It allows short logs to be more meaningful.. It\u0027s usually a challenge to limit something to 50 characters, especially if the change is harder to implement or explain - but this convention tries to reimpose the project\u0027s development ideology - simple, single-intent changes :)","commit_id":"21f80562900c0155fcf466f7407b008894144637"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82b3319973e03077eb2fd23d570f7070319577fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vhari \u003cvhariria@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-22 07:57:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moved resource cleanup after changing share quota"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idd3396834ca204b51671e4422a6223754342e21f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_0359215a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"updated":"2019-08-22 16:56:24.000000000","message":"This isn\u0027t the content of the commit though :(\n\n \n\nIt should still be \"Validate share quota after updating\"\n\n \n\nWith Gerrit, you don\u0027t need to make intermediate commits and squash-and-merge like is usually the workflow with pull requests - you can amend/overwrite your previous commits; when the change merges, it is done as a single commit, and your intermediate patches aren\u0027t merged into the repository. \n\nTake a look at the diff in the UI, between \"Base\" and the latest patchset, that\u0027s what merging this change will update the repository with.","commit_id":"1dda0dd2b55c27e6529937308f4bbdcf4d156ca5"}],"manila_tempest_tests/tests/api/admin/test_quotas_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"30f07182e73e15a28ee6972c2f66c4227ac9d1de","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        self.assertEqual(1, updated_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":364,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":365,"context_line":"        self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        self.assertRaises(lib_exc.OverLimit,"},{"line_number":368,"context_line":"                          self.create_share,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_02bf0961","line":365,"range":{"start_line":365,"start_character":0,"end_line":365,"end_character":57},"updated":"2019-08-20 19:57:15.000000000","message":"You may delete this line..","commit_id":"21f80562900c0155fcf466f7407b008894144637"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"16a3ed6190451d55020feb923e4091ddd2c4fc38","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        self.assertEqual(1, updated_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":364,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":365,"context_line":"        self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        self.assertRaises(lib_exc.OverLimit,"},{"line_number":368,"context_line":"                          self.create_share,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_6b90154f","line":365,"range":{"start_line":365,"start_character":0,"end_line":365,"end_character":57},"in_reply_to":"7faddb67_02bf0961","updated":"2019-08-22 11:46:31.000000000","message":"Done","commit_id":"21f80562900c0155fcf466f7407b008894144637"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d9c4320e1558d46b8d4dc9267e1c73a012d49a74","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            self.tenant_id)"},{"line_number":359,"context_line":"        self.create_share(share_type_id\u003dself.share_type_id)"},{"line_number":360,"context_line":"        self.shares_v2_client.update_quotas(self.tenant_id, shares\u003d1)"},{"line_number":361,"context_line":"        updated_quota \u003d self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":362,"context_line":"        self.assertEqual(1, updated_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":364,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_18420e3c","line":362,"range":{"start_line":361,"start_character":0,"end_line":362,"end_character":52},"updated":"2019-08-21 13:39:40.000000000","message":"Hi, just noticed this - can you move this below the addCleanup?\n\nlogically, it makes sense to queue up cleanup for a resource as soon as you create/change the resource.... now, it sort of feels disconnected from the \"update_quota\"","commit_id":"fb12e1eea441a7306d72b6297f79eeab34bbc6cf"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"16a3ed6190451d55020feb923e4091ddd2c4fc38","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            self.tenant_id)"},{"line_number":359,"context_line":"        self.create_share(share_type_id\u003dself.share_type_id)"},{"line_number":360,"context_line":"        self.shares_v2_client.update_quotas(self.tenant_id, shares\u003d1)"},{"line_number":361,"context_line":"        updated_quota \u003d self.shares_v2_client.show_quotas(self.tenant_id)"},{"line_number":362,"context_line":"        self.assertEqual(1, updated_quota[\u0027shares\u0027])"},{"line_number":363,"context_line":"        self.addCleanup(self.shares_v2_client.update_quotas,"},{"line_number":364,"context_line":"                        self.tenant_id, shares\u003doriginal_quota[\u0027shares\u0027])"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_af5cb919","line":362,"range":{"start_line":361,"start_character":0,"end_line":362,"end_character":52},"in_reply_to":"7faddb67_18420e3c","updated":"2019-08-22 11:46:31.000000000","message":"Done","commit_id":"fb12e1eea441a7306d72b6297f79eeab34bbc6cf"}]}