)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4d53cdc85084553e37250ce3100d9d95bdea7354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"98d1fa83_1b50ded3","updated":"2022-01-17 18:28:09.000000000","message":"Thanks Vida!","commit_id":"bec02357013d5c8ac9b18a50ae149bc0d74a0ea8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bb82ec67d921543ee6ca5278289c69a57382b354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0c5336f0_eb322909","updated":"2022-01-20 13:53:11.000000000","message":"LGTM. Thank you, Vida!","commit_id":"73e0b6fdc450b7539bf6a97349f5774177ffb24a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"49aa791649326d0c30c2323d9a4759e2f31e5d71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fd3ca8a8_771c0a90","updated":"2022-01-18 18:31:33.000000000","message":"Thanks Vida!","commit_id":"73e0b6fdc450b7539bf6a97349f5774177ffb24a"}],"manila_tempest_tests/tests/api/test_share_networks.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3dd46e0f1cb71e220b40699312c9a84ed349ba22","unresolved":true,"context_lines":[{"line_number":332,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron, \"Only with neutron.\")"},{"line_number":333,"context_line":"    @base.skip_if_microversion_lt(\"2.20\")"},{"line_number":334,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":335,"context_line":"    def test_neutron_net_id_with_neutron(self):"},{"line_number":336,"context_line":"        network_client \u003d self.networks_client"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        self.create_share(share_type_id\u003dself.share_type_id,"},{"line_number":339,"context_line":"                          cleanup_in_class\u003dFalse)"},{"line_number":340,"context_line":"        share_net_details \u003d self.shares_v2_client.get_share_network("},{"line_number":341,"context_line":"            self.shares_v2_client.share_network_id)"},{"line_number":342,"context_line":"        share_net_info \u003d ("},{"line_number":343,"context_line":"            utils.share_network_get_default_subnet(share_net_details)"},{"line_number":344,"context_line":"            if utils.share_network_subnets_are_supported()"},{"line_number":345,"context_line":"            else share_net_details)"},{"line_number":346,"context_line":"        network_details \u003d network_client.show_network("},{"line_number":347,"context_line":"            share_net_info[\u0027neutron_net_id\u0027])"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        self.assertEqual(network_details[\u0027network\u0027][\u0027neutron_net_id\u0027],"},{"line_number":350,"context_line":"                         share_net_info[\u0027neutron_net_id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"ae1eaaa2_d63b4b88","line":350,"range":{"start_line":335,"start_character":4,"end_line":350,"end_character":58},"updated":"2022-01-14 13:35:16.000000000","message":"That\u0027s a useful test case, that\u0027s for sure... But IMHO these could be combined into single tests... Could be either using Liron\u0027s suggested approach or separating them by microversion, for example:\nThe 2.18 test would test only what was added in that microversion\nAnd the 2.20 would test the fields added in that microversion.","commit_id":"75c774c3cfdf434dbbeff5f197dbb9db46dc7bd2"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"29d90fd541d78588e2a23616dbfc31d09e7b8902","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"727d30a0_b7ebb4bc","line":351,"range":{"start_line":281,"start_character":0,"end_line":351,"end_character":0},"updated":"2022-01-02 09:30:30.000000000","message":"You can consolidate these three tests to only one test, as bellow:\n\nif utils.is_microversion_supported(\u00272.18\u0027):\n   subnet_details \u003d subnet_client.show_subnet(\n      share_net_info[\u0027neutron_subnet_id\u0027])\n   self.assertEqual(subnet_details[\u0027subnet\u0027][\u0027gateway_ip\u0027],\n                    share_net_info[\u0027gateway\u0027])\n   \nif utils.is_microversion_supported(\u00272.20\u0027):\n        network_details \u003d network_client.show_network(\n            share_net_info[\u0027neutron_net_id\u0027])\n        self.assertEqual(network_details[\u0027network\u0027][\u0027mtu\u0027],\n                         share_net_info[\u0027mtu\u0027])\n        self.assertEqual(network_details[\u0027network\u0027][\u0027neutron_net_id\u0027],\n                         share_net_info[\u0027neutron_net_id\u0027])","commit_id":"75c774c3cfdf434dbbeff5f197dbb9db46dc7bd2"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"952e5eb02cdbed1621837430790de1e88e0b08b8","unresolved":true,"context_lines":[{"line_number":316,"context_line":"            else share_net_details)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        if utils.is_microversion_supported(\u00272.18\u0027):"},{"line_number":319,"context_line":"            subnet_details \u003d self.subnet_client.show_subnet("},{"line_number":320,"context_line":"                share_net_info[\u0027neutron_subnet_id\u0027])"},{"line_number":321,"context_line":"            self.assertEqual(subnet_details[\u0027subnet\u0027][\u0027gateway_ip\u0027],"},{"line_number":322,"context_line":"                             share_net_info[\u0027gateway\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"39e818df_c6202085","line":319,"range":{"start_line":319,"start_character":34,"end_line":319,"end_character":40},"updated":"2022-01-18 08:31:05.000000000","message":"It should be subnets.\nThis is the reason for the failure here:\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a82/695244/9/check/manila-tempest-plugin-container/a8203ea/testr_results.html","commit_id":"bec02357013d5c8ac9b18a50ae149bc0d74a0ea8"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"b765c3b78f0812a2574900bc9fd584273a4711a5","unresolved":true,"context_lines":[{"line_number":316,"context_line":"            else share_net_details)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        if utils.is_microversion_supported(\u00272.18\u0027):"},{"line_number":319,"context_line":"            subnet_details \u003d self.subnet_client.show_subnet("},{"line_number":320,"context_line":"                share_net_info[\u0027neutron_subnet_id\u0027])"},{"line_number":321,"context_line":"            self.assertEqual(subnet_details[\u0027subnet\u0027][\u0027gateway_ip\u0027],"},{"line_number":322,"context_line":"                             share_net_info[\u0027gateway\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"23897b75_4665260c","line":319,"range":{"start_line":319,"start_character":34,"end_line":319,"end_character":40},"in_reply_to":"39e818df_c6202085","updated":"2022-01-18 10:56:20.000000000","message":"Looks we missed this one, corrected typo. thanks!","commit_id":"bec02357013d5c8ac9b18a50ae149bc0d74a0ea8"}]}