)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f7453ac0ff1c4d9bc44d1ea20ff9fe0fe705036a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lkuchlan \u003clkuchlan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-07 14:12:43 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move all conditions skip under skip_checks method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"skip_checks methos is used to evaluate config early"},{"line_number":10,"context_line":"and skip all test methods based on these checks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_d76c5cd0","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":24},"updated":"2020-01-08 16:22:36.000000000","message":"skipped","commit_id":"e25e8c2c91c1d9d481e7a71d00d16981b233a410"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"ecb441f6b1dbb4bfb780a7ff22c4b139aa80c9f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lkuchlan \u003clkuchlan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-07 14:12:43 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move all conditions skip under skip_checks method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"skip_checks methos is used to evaluate config early"},{"line_number":10,"context_line":"and skip all test methods based on these checks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_40489a2c","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":24},"in_reply_to":"3fa7e38b_d76c5cd0","updated":"2020-01-09 08:08:48.000000000","message":"Done","commit_id":"e25e8c2c91c1d9d481e7a71d00d16981b233a410"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f7453ac0ff1c4d9bc44d1ea20ff9fe0fe705036a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move all conditions skip under skip_checks method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"skip_checks methos is used to evaluate config early"},{"line_number":10,"context_line":"and skip all test methods based on these checks."},{"line_number":11,"context_line":"This patch moves all conditions skip under this method."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_57586c23","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":18},"updated":"2020-01-08 16:22:36.000000000","message":"method","commit_id":"e25e8c2c91c1d9d481e7a71d00d16981b233a410"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"14a085c3bbdfdd750ef5bbd5a39f95c067bf5623","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move all conditions skipped under \"skip_checks\" method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila class structure should be compatible with tempest"},{"line_number":10,"context_line":"project as manila is a plugin of tempest."},{"line_number":11,"context_line":"In some cases incompatibility can cause problems."},{"line_number":12,"context_line":"For example: using \"check_uuid\" tool for generating UUIDs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_caf18a66","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":6},"updated":"2020-02-06 15:27:58.000000000","message":"Manila tempest plugin","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"910997c1c3d8a4afd810306ac478b46426ed733d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move all conditions skipped under \"skip_checks\" method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila class structure should be compatible with tempest"},{"line_number":10,"context_line":"project as manila is a plugin of tempest."},{"line_number":11,"context_line":"In some cases incompatibility can cause problems."},{"line_number":12,"context_line":"For example: using \"check_uuid\" tool for generating UUIDs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_9672c64a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":6},"in_reply_to":"3fa7e38b_caf18a66","updated":"2020-02-06 19:56:46.000000000","message":"Done","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"14a085c3bbdfdd750ef5bbd5a39f95c067bf5623","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move all conditions skipped under \"skip_checks\" method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila class structure should be compatible with tempest"},{"line_number":10,"context_line":"project as manila is a plugin of tempest."},{"line_number":11,"context_line":"In some cases incompatibility can cause problems."},{"line_number":12,"context_line":"For example: using \"check_uuid\" tool for generating UUIDs"},{"line_number":13,"context_line":"for tests does not work properly in manila, Because some"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_8a9152f9","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":17},"updated":"2020-02-06 15:27:58.000000000","message":"manila tempest plugin","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"910997c1c3d8a4afd810306ac478b46426ed733d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move all conditions skipped under \"skip_checks\" method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila class structure should be compatible with tempest"},{"line_number":10,"context_line":"project as manila is a plugin of tempest."},{"line_number":11,"context_line":"In some cases incompatibility can cause problems."},{"line_number":12,"context_line":"For example: using \"check_uuid\" tool for generating UUIDs"},{"line_number":13,"context_line":"for tests does not work properly in manila, Because some"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_36719246","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":17},"in_reply_to":"3fa7e38b_8a9152f9","updated":"2020-02-06 19:56:46.000000000","message":"Done","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"}],"manila_tempest_tests/tests/api/admin/test_replication_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"14a085c3bbdfdd750ef5bbd5a39f95c067bf5623","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(ReplicationActionsAdminTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if not CONF.share.run_replication_tests:"},{"line_number":33,"context_line":"            raise cls.skipException(\u0027Replication tests are disabled.\u0027)"},{"line_number":34,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":35,"context_line":"            raise cls.skipException("},{"line_number":36,"context_line":"                \u0027Only for driver_handles_share_servers \u003d False driver mode.\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        utils.check_skip_if_microversion_lt(_MIN_SUPPORTED_MICROVERSION)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_1054b0fc","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":77},"updated":"2020-02-06 15:27:58.000000000","message":"Hmmm, this check should have been removed after we added support for replication DHSS\u003dTrue.. .","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"910997c1c3d8a4afd810306ac478b46426ed733d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(ReplicationActionsAdminTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if not CONF.share.run_replication_tests:"},{"line_number":33,"context_line":"            raise cls.skipException(\u0027Replication tests are disabled.\u0027)"},{"line_number":34,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":35,"context_line":"            raise cls.skipException("},{"line_number":36,"context_line":"                \u0027Only for driver_handles_share_servers \u003d False driver mode.\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        utils.check_skip_if_microversion_lt(_MIN_SUPPORTED_MICROVERSION)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_5611ae4f","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":77},"in_reply_to":"3fa7e38b_1054b0fc","updated":"2020-02-06 19:56:46.000000000","message":"Done","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"382b9e6c7451e6d5b9e3e14c86fbea92ab7109d2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(ReplicationActionsAdminTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if not CONF.share.run_replication_tests:"},{"line_number":33,"context_line":"            raise cls.skipException(\u0027Replication tests are disabled.\u0027)"},{"line_number":34,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":35,"context_line":"            raise cls.skipException("},{"line_number":36,"context_line":"                \u0027Only for driver_handles_share_servers \u003d False driver mode.\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        utils.check_skip_if_microversion_lt(_MIN_SUPPORTED_MICROVERSION)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_deada283","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":77},"in_reply_to":"3fa7e38b_5611ae4f","updated":"2020-02-07 21:41:18.000000000","message":"Liron: This observation was me typing out loud - to alert Douglas and Carlos about this test class - removing this check alone won\u0027t suffice I guess, the tests may need to be modified to support DHSS\u003dTrue...","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"eb1c78d87ae80190a16c58c412a990f77dc5f92b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(ReplicationActionsAdminTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if not CONF.share.run_replication_tests:"},{"line_number":33,"context_line":"            raise cls.skipException(\u0027Replication tests are disabled.\u0027)"},{"line_number":34,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":35,"context_line":"            raise cls.skipException("},{"line_number":36,"context_line":"                \u0027Only for driver_handles_share_servers \u003d False driver mode.\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        utils.check_skip_if_microversion_lt(_MIN_SUPPORTED_MICROVERSION)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_6022c7b9","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":77},"in_reply_to":"3fa7e38b_deada283","updated":"2020-02-09 08:41:47.000000000","message":"Got you","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4ee1253b9782a86b277cd1ed738635447e922b28","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"},{"line_number":42,"context_line":"        super(ReplicationActionsAdminTest, cls).resource_setup()"},{"line_number":43,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":44,"context_line":"        cls.member_client \u003d cls.shares_v2_client"},{"line_number":45,"context_line":"        cls.replication_type \u003d CONF.share.backend_replication_type"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_a731f95a","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":42},"updated":"2020-02-04 22:08:10.000000000","message":"Thanks for noticing and fixing.","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"}],"manila_tempest_tests/tests/api/admin/test_snapshot_manage.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"14a085c3bbdfdd750ef5bbd5a39f95c067bf5623","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def resource_setup(cls):"},{"line_number":48,"context_line":"        if cls.protocol not in CONF.share.enable_protocols:"},{"line_number":49,"context_line":"            message \u003d \"%s tests are disabled\" % cls.protocol"},{"line_number":50,"context_line":"            raise cls.skipException(message)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        utils.skip_if_manage_not_supported_for_version()"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_332216a8","line":50,"range":{"start_line":48,"start_character":7,"end_line":50,"end_character":44},"updated":"2020-02-06 15:27:58.000000000","message":"Can this be moved into the skip checks as well? \n\nWondering if the class setup for unrelated/untestable protocols can be avoided with this mechanism","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"910997c1c3d8a4afd810306ac478b46426ed733d","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def resource_setup(cls):"},{"line_number":48,"context_line":"        if cls.protocol not in CONF.share.enable_protocols:"},{"line_number":49,"context_line":"            message \u003d \"%s tests are disabled\" % cls.protocol"},{"line_number":50,"context_line":"            raise cls.skipException(message)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        utils.skip_if_manage_not_supported_for_version()"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_f621baa2","line":50,"range":{"start_line":48,"start_character":7,"end_line":50,"end_character":44},"in_reply_to":"3fa7e38b_332216a8","updated":"2020-02-06 19:56:46.000000000","message":"Good catch, it should be under skip checks.\nThanks.","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"382b9e6c7451e6d5b9e3e14c86fbea92ab7109d2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if not CONF.service_available.manila:"},{"line_number":259,"context_line":"            raise cls.skipException(\"Manila support is required\")"},{"line_number":260,"context_line":"        if not (any(p in CONF.share.enable_protocols"},{"line_number":261,"context_line":"                    for p in cls.protocols) and"},{"line_number":262,"context_line":"                CONF.service_available.manila):"},{"line_number":263,"context_line":"            skip_msg \u003d \"Manila is disabled\""},{"line_number":264,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_dee282d3","line":263,"range":{"start_line":261,"start_character":43,"end_line":263,"end_character":43},"updated":"2020-02-07 21:41:18.000000000","message":"This condition is covered above.. \n\nMaybe this skip should just check that the config option \"enable_protocols\" has at least has one protocol specified.","commit_id":"e5a45f6d1d86824aebe2da26463f2e5a0fa286e6"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"eb1c78d87ae80190a16c58c412a990f77dc5f92b","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if not CONF.service_available.manila:"},{"line_number":259,"context_line":"            raise cls.skipException(\"Manila support is required\")"},{"line_number":260,"context_line":"        if not (any(p in CONF.share.enable_protocols"},{"line_number":261,"context_line":"                    for p in cls.protocols) and"},{"line_number":262,"context_line":"                CONF.service_available.manila):"},{"line_number":263,"context_line":"            skip_msg \u003d \"Manila is disabled\""},{"line_number":264,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_801fc36f","line":263,"range":{"start_line":261,"start_character":43,"end_line":263,"end_character":43},"in_reply_to":"3fa7e38b_dee282d3","updated":"2020-02-09 08:41:47.000000000","message":"Right\nDone","commit_id":"e5a45f6d1d86824aebe2da26463f2e5a0fa286e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1846e463b58e852ac1a365904212efa1392045bc","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        super(BaseSharesTest, cls).skip_checks()"},{"line_number":258,"context_line":"        if not CONF.service_available.manila:"},{"line_number":259,"context_line":"            raise cls.skipException(\"Manila support is required\")"},{"line_number":260,"context_line":"        if not (any(p in CONF.share.enable_protocols for p in cls.protocols)):"},{"line_number":261,"context_line":"            skip_msg \u003d \"%s tests are disabled\" % CONF.share.enable_protocols"},{"line_number":262,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_ff7f1cb9","line":260,"range":{"start_line":260,"start_character":15,"end_line":260,"end_character":16},"updated":"2020-02-11 22:44:20.000000000","message":"redundant parentheses","commit_id":"8813b191105cad57630a9bc9a688ea406ff4e026"}],"manila_tempest_tests/tests/api/test_access_rules_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"14a085c3bbdfdd750ef5bbd5a39f95c067bf5623","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        # The share access rule metadata doesn\u0027t care about the value of"},{"line_number":40,"context_line":"        # access type, access protocol, access_to, so we only get one of"},{"line_number":41,"context_line":"        # the value that the driver support."},{"line_number":42,"context_line":"        if not (any(p in CONF.share.enable_ip_rules_for_protocols"},{"line_number":43,"context_line":"                    for p in cls.protocols) or"},{"line_number":44,"context_line":"                any(p in CONF.share.enable_user_rules_for_protocols"},{"line_number":45,"context_line":"                    for p in cls.protocols) or"},{"line_number":46,"context_line":"                any(p in CONF.share.enable_cert_rules_for_protocols"},{"line_number":47,"context_line":"                    for p in cls.protocols) or"},{"line_number":48,"context_line":"                any(p in CONF.share.enable_cephx_rules_for_protocols"},{"line_number":49,"context_line":"                    for p in cls.protocols)):"},{"line_number":50,"context_line":"            cls.message \u003d \"Rule tests are disabled\""},{"line_number":51,"context_line":"            raise cls.skipException(cls.message)"},{"line_number":52,"context_line":"        if CONF.share.enable_ip_rules_for_protocols:"},{"line_number":53,"context_line":"            cls.protocol \u003d CONF.share.enable_ip_rules_for_protocols[0]"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_b338463c","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":51},"updated":"2020-02-06 15:27:58.000000000","message":"Can this condition be moved into skip_checks as well?","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"910997c1c3d8a4afd810306ac478b46426ed733d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        # The share access rule metadata doesn\u0027t care about the value of"},{"line_number":40,"context_line":"        # access type, access protocol, access_to, so we only get one of"},{"line_number":41,"context_line":"        # the value that the driver support."},{"line_number":42,"context_line":"        if not (any(p in CONF.share.enable_ip_rules_for_protocols"},{"line_number":43,"context_line":"                    for p in cls.protocols) or"},{"line_number":44,"context_line":"                any(p in CONF.share.enable_user_rules_for_protocols"},{"line_number":45,"context_line":"                    for p in cls.protocols) or"},{"line_number":46,"context_line":"                any(p in CONF.share.enable_cert_rules_for_protocols"},{"line_number":47,"context_line":"                    for p in cls.protocols) or"},{"line_number":48,"context_line":"                any(p in CONF.share.enable_cephx_rules_for_protocols"},{"line_number":49,"context_line":"                    for p in cls.protocols)):"},{"line_number":50,"context_line":"            cls.message \u003d \"Rule tests are disabled\""},{"line_number":51,"context_line":"            raise cls.skipException(cls.message)"},{"line_number":52,"context_line":"        if CONF.share.enable_ip_rules_for_protocols:"},{"line_number":53,"context_line":"            cls.protocol \u003d CONF.share.enable_ip_rules_for_protocols[0]"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_b61b426d","line":50,"range":{"start_line":42,"start_character":0,"end_line":50,"end_character":51},"in_reply_to":"3fa7e38b_b338463c","updated":"2020-02-06 19:56:46.000000000","message":"Done","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"}],"manila_tempest_tests/tests/api/test_access_rules_metadata_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"14a085c3bbdfdd750ef5bbd5a39f95c067bf5623","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def resource_setup(cls):"},{"line_number":39,"context_line":"        super(AccessesMetadataNegativeTest, cls).resource_setup()"},{"line_number":40,"context_line":"        if not (any(p in CONF.share.enable_ip_rules_for_protocols"},{"line_number":41,"context_line":"                    for p in cls.protocols) or"},{"line_number":42,"context_line":"                any(p in CONF.share.enable_user_rules_for_protocols"},{"line_number":43,"context_line":"                    for p in cls.protocols) or"},{"line_number":44,"context_line":"                any(p in CONF.share.enable_cert_rules_for_protocols"},{"line_number":45,"context_line":"                    for p in cls.protocols) or"},{"line_number":46,"context_line":"                any(p in CONF.share.enable_cephx_rules_for_protocols"},{"line_number":47,"context_line":"                    for p in cls.protocols)):"},{"line_number":48,"context_line":"            cls.message \u003d \"Rule tests are disabled\""},{"line_number":49,"context_line":"            raise cls.skipException(cls.message)"},{"line_number":50,"context_line":"        if CONF.share.enable_ip_rules_for_protocols:"},{"line_number":51,"context_line":"            cls.protocol \u003d CONF.share.enable_ip_rules_for_protocols[0]"},{"line_number":52,"context_line":"            cls.access_type \u003d \"ip\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_5328f2eb","line":49,"range":{"start_line":40,"start_character":0,"end_line":49,"end_character":48},"updated":"2020-02-06 15:27:58.000000000","message":"Can this skip condition be moved into skip_checks as well?","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"910997c1c3d8a4afd810306ac478b46426ed733d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def resource_setup(cls):"},{"line_number":39,"context_line":"        super(AccessesMetadataNegativeTest, cls).resource_setup()"},{"line_number":40,"context_line":"        if not (any(p in CONF.share.enable_ip_rules_for_protocols"},{"line_number":41,"context_line":"                    for p in cls.protocols) or"},{"line_number":42,"context_line":"                any(p in CONF.share.enable_user_rules_for_protocols"},{"line_number":43,"context_line":"                    for p in cls.protocols) or"},{"line_number":44,"context_line":"                any(p in CONF.share.enable_cert_rules_for_protocols"},{"line_number":45,"context_line":"                    for p in cls.protocols) or"},{"line_number":46,"context_line":"                any(p in CONF.share.enable_cephx_rules_for_protocols"},{"line_number":47,"context_line":"                    for p in cls.protocols)):"},{"line_number":48,"context_line":"            cls.message \u003d \"Rule tests are disabled\""},{"line_number":49,"context_line":"            raise cls.skipException(cls.message)"},{"line_number":50,"context_line":"        if CONF.share.enable_ip_rules_for_protocols:"},{"line_number":51,"context_line":"            cls.protocol \u003d CONF.share.enable_ip_rules_for_protocols[0]"},{"line_number":52,"context_line":"            cls.access_type \u003d \"ip\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_d61efe5c","line":49,"range":{"start_line":40,"start_character":0,"end_line":49,"end_character":48},"in_reply_to":"3fa7e38b_5328f2eb","updated":"2020-02-06 19:56:46.000000000","message":"Done","commit_id":"98bd0eb625ffacd6398bdd66f218183c1a0cc859"}],"manila_tempest_tests/tests/api/test_share_type_availability_zones_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"478cd1296c1fe4b6eb797cdb2b533b1eeb7b41cc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            client\u003dself.admin_shares_v2_client)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":60,"context_line":"    @base.skip_if_microversion_not_supported(\"2.48\")"},{"line_number":61,"context_line":"    def test_share_type_azs_filter_by_invalid_azs_extra_spec(self):"},{"line_number":62,"context_line":"        self.admin_shares_v2_client.update_share_type_extra_spec("},{"line_number":63,"context_line":"            self.share_type_id, self.az_spec, self.valid_azs_spec)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_faba8ddd","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":52},"updated":"2020-02-14 01:40:50.000000000","message":"Redundant skip decorator","commit_id":"8813b191105cad57630a9bc9a688ea406ff4e026"}],"manila_tempest_tests/tests/api/test_snapshot_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"478cd1296c1fe4b6eb797cdb2b533b1eeb7b41cc","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"},{"line_number":78,"context_line":"    def resource_setup(cls):"},{"line_number":79,"context_line":"        if not (cls.protocol in CONF.share.enable_protocols and"},{"line_number":80,"context_line":"                cls.protocol in CONF.share.enable_ip_rules_for_protocols):"},{"line_number":81,"context_line":"            msg \u003d \"IP rule tests for %s protocol are disabled.\" % cls.protocol"},{"line_number":82,"context_line":"            raise cls.skipException(msg)"},{"line_number":83,"context_line":"        super(ShareSnapshotIpRulesForNFSTest, cls).resource_setup()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        cls.access_type \u003d \"ip\""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_7add3d3d","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":40},"updated":"2020-02-14 01:40:50.000000000","message":"Can be moved to skip_checks","commit_id":"8813b191105cad57630a9bc9a688ea406ff4e026"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"478cd1296c1fe4b6eb797cdb2b533b1eeb7b41cc","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def resource_setup(cls):"},{"line_number":107,"context_line":"        if not (cls.protocol in CONF.share.enable_protocols and"},{"line_number":108,"context_line":"                cls.protocol in CONF.share.enable_user_rules_for_protocols):"},{"line_number":109,"context_line":"            msg \u003d (\"User rule tests for %s protocol are \""},{"line_number":110,"context_line":"                   \"disabled.\" % cls.protocol)"},{"line_number":111,"context_line":"            raise cls.skipException(msg)"},{"line_number":112,"context_line":"        super(ShareSnapshotUserRulesForCIFSTest, cls).resource_setup()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        cls.access_type \u003d \"user\""}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_1ae8c9dd","line":111,"range":{"start_line":107,"start_character":0,"end_line":111,"end_character":40},"updated":"2020-02-14 01:40:50.000000000","message":"can be moved to skip_checks","commit_id":"8813b191105cad57630a9bc9a688ea406ff4e026"}],"manila_tempest_tests/tests/api/test_snapshot_rules_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"478cd1296c1fe4b6eb797cdb2b533b1eeb7b41cc","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def resource_setup(cls):"},{"line_number":45,"context_line":"        if not (cls.protocol in CONF.share.enable_protocols and"},{"line_number":46,"context_line":"                cls.protocol in CONF.share.enable_ip_rules_for_protocols):"},{"line_number":47,"context_line":"            msg \u003d \"IP rule tests for %s protocol are disabled.\" % cls.protocol"},{"line_number":48,"context_line":"            raise cls.skipException(msg)"},{"line_number":49,"context_line":"        super(SnapshotIpRulesForNFSNegativeTest, cls).resource_setup()"},{"line_number":50,"context_line":"        # create share type"},{"line_number":51,"context_line":"        extra_specs \u003d {\u0027mount_snapshot_support\u0027: \u0027True\u0027}"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_5ae2c103","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":40},"updated":"2020-02-14 01:40:50.000000000","message":"This can be moved to skip_checks","commit_id":"8813b191105cad57630a9bc9a688ea406ff4e026"}],"manila_tempest_tests/utils.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d72f93feb6e7ee615386beeb0279b79cf9d4b69","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    return bottom \u003c\u003d microversion \u003c\u003d top"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def skip_if_microversion_not_supported(microversion):"},{"line_number":79,"context_line":"    \"\"\"Decorator for tests that are microversion-specific.\"\"\""},{"line_number":80,"context_line":"    if not is_microversion_supported(microversion):"},{"line_number":81,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \u0027%s\u0027.\" % microversion)"},{"line_number":82,"context_line":"        return testtools.skip(reason)"},{"line_number":83,"context_line":"    return lambda f: f"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def skip_if_microversion_lt(microversion):"},{"line_number":87,"context_line":"    \"\"\"Decorator for tests that are microversion-specific.\"\"\""},{"line_number":88,"context_line":"    if is_microversion_lt(CONF.share.max_api_microversion, microversion):"},{"line_number":89,"context_line":"        reason \u003d (\"Skipped. Test requires microversion greater than or \""},{"line_number":90,"context_line":"                  \"equal to \u0027%s\u0027.\" % microversion)"},{"line_number":91,"context_line":"        return testtools.skip(reason)"},{"line_number":92,"context_line":"    return lambda f: f"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def check_skip_with_microversion(microversion):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_6ce0f6cc","line":92,"range":{"start_line":78,"start_character":0,"end_line":92,"end_character":22},"updated":"2020-01-14 13:22:05.000000000","message":"Can we delete this now? Or are being used in other places?","commit_id":"c19ef60c8df79f9a2f60fabce3eb0e0f0cc28bc3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4a6e4e11065080eef4a406410cca403a23ca74d0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    return bottom \u003c\u003d microversion \u003c\u003d top"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def skip_if_microversion_not_supported(microversion):"},{"line_number":79,"context_line":"    \"\"\"Decorator for tests that are microversion-specific.\"\"\""},{"line_number":80,"context_line":"    if not is_microversion_supported(microversion):"},{"line_number":81,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \u0027%s\u0027.\" % microversion)"},{"line_number":82,"context_line":"        return testtools.skip(reason)"},{"line_number":83,"context_line":"    return lambda f: f"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def skip_if_microversion_lt(microversion):"},{"line_number":87,"context_line":"    \"\"\"Decorator for tests that are microversion-specific.\"\"\""},{"line_number":88,"context_line":"    if is_microversion_lt(CONF.share.max_api_microversion, microversion):"},{"line_number":89,"context_line":"        reason \u003d (\"Skipped. Test requires microversion greater than or \""},{"line_number":90,"context_line":"                  \"equal to \u0027%s\u0027.\" % microversion)"},{"line_number":91,"context_line":"        return testtools.skip(reason)"},{"line_number":92,"context_line":"    return lambda f: f"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def check_skip_with_microversion(microversion):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_0c25c2bf","line":92,"range":{"start_line":78,"start_character":0,"end_line":92,"end_character":22},"in_reply_to":"3fa7e38b_6ce0f6cc","updated":"2020-01-14 13:44:41.000000000","message":"Hi Douglas,\nIt is used in other places for skipping a specific test.","commit_id":"c19ef60c8df79f9a2f60fabce3eb0e0f0cc28bc3"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d72f93feb6e7ee615386beeb0279b79cf9d4b69","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    return lambda f: f"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def check_skip_with_microversion(microversion):"},{"line_number":96,"context_line":"    if is_microversion_lt(CONF.share.max_api_microversion, microversion):"},{"line_number":97,"context_line":"        reason \u003d (\"Skipped. Test requires microversion greater than or \""},{"line_number":98,"context_line":"                  \"equal to \u0027%s\u0027.\" % microversion)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_0c6e2264","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":32},"updated":"2020-01-14 13:22:05.000000000","message":"IMHO should be \u0027check_skip_if_microversion_lt(microversion)\u0027, which says exactly what the check is doing.","commit_id":"c19ef60c8df79f9a2f60fabce3eb0e0f0cc28bc3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4a6e4e11065080eef4a406410cca403a23ca74d0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    return lambda f: f"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def check_skip_with_microversion(microversion):"},{"line_number":96,"context_line":"    if is_microversion_lt(CONF.share.max_api_microversion, microversion):"},{"line_number":97,"context_line":"        reason \u003d (\"Skipped. Test requires microversion greater than or \""},{"line_number":98,"context_line":"                  \"equal to \u0027%s\u0027.\" % microversion)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_a7cb67a5","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":32},"in_reply_to":"3fa7e38b_0c6e2264","updated":"2020-01-14 13:44:41.000000000","message":"Done","commit_id":"c19ef60c8df79f9a2f60fabce3eb0e0f0cc28bc3"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d72f93feb6e7ee615386beeb0279b79cf9d4b69","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        raise testtools.TestCase.skipException(reason)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def check_skip_with_microversion_not_supported(microversion):"},{"line_number":103,"context_line":"    if not is_microversion_lt(CONF.share.max_api_microversion, microversion):"},{"line_number":104,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \u0027%s\u0027.\" % microversion)"},{"line_number":105,"context_line":"        raise testtools.TestCase.skipException(reason)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_0ca3829d","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":46},"updated":"2020-01-14 13:22:05.000000000","message":"same here: \u0027check_skip_if_microversion_not_supported\u0027","commit_id":"c19ef60c8df79f9a2f60fabce3eb0e0f0cc28bc3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4a6e4e11065080eef4a406410cca403a23ca74d0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        raise testtools.TestCase.skipException(reason)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def check_skip_with_microversion_not_supported(microversion):"},{"line_number":103,"context_line":"    if not is_microversion_lt(CONF.share.max_api_microversion, microversion):"},{"line_number":104,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \u0027%s\u0027.\" % microversion)"},{"line_number":105,"context_line":"        raise testtools.TestCase.skipException(reason)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_c7d0e355","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":46},"in_reply_to":"3fa7e38b_0ca3829d","updated":"2020-01-14 13:44:41.000000000","message":"Done","commit_id":"c19ef60c8df79f9a2f60fabce3eb0e0f0cc28bc3"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9d72f93feb6e7ee615386beeb0279b79cf9d4b69","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def check_skip_with_microversion_not_supported(microversion):"},{"line_number":103,"context_line":"    if not is_microversion_lt(CONF.share.max_api_microversion, microversion):"},{"line_number":104,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \u0027%s\u0027.\" % microversion)"},{"line_number":105,"context_line":"        raise testtools.TestCase.skipException(reason)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_6c555652","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":29},"updated":"2020-01-14 13:22:05.000000000","message":"In the original skip method was checking: \n\u0027if not is_microversion_supported(microversion):\u0027","commit_id":"c19ef60c8df79f9a2f60fabce3eb0e0f0cc28bc3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4a6e4e11065080eef4a406410cca403a23ca74d0","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def check_skip_with_microversion_not_supported(microversion):"},{"line_number":103,"context_line":"    if not is_microversion_lt(CONF.share.max_api_microversion, microversion):"},{"line_number":104,"context_line":"        reason \u003d (\"Skipped. Test requires microversion \u0027%s\u0027.\" % microversion)"},{"line_number":105,"context_line":"        raise testtools.TestCase.skipException(reason)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_67c56f90","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":29},"in_reply_to":"3fa7e38b_6c555652","updated":"2020-01-14 13:44:41.000000000","message":"Wow thanks","commit_id":"c19ef60c8df79f9a2f60fabce3eb0e0f0cc28bc3"}]}