)]}'
{"manila_tempest_tests/tests/scenario/test_share_shrink.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e70baa42562234d9761405baa5376bc4fce9bc75","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def skip_checks(cls):"},{"line_number":51,"context_line":"        super(ShareShrinkBase, cls).skip_checks()"},{"line_number":52,"context_line":"        if cls.protocol not in CONF.share.enable_ip_rules_for_protocols:"},{"line_number":53,"context_line":"            message \u003d (\"%s tests for access rules other than IP are disabled\" %"},{"line_number":54,"context_line":"                       cls.protocol)"},{"line_number":55,"context_line":"            raise cls.skipException(message)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":58,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4c43b2_1f3cb1e0","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":44},"updated":"2020-04-18 00:35:33.000000000","message":"This skip is applicable to all scenario tests right now, so probably just add it in the base class (ShareScenarioTest): https://review.opendev.org/#/c/715679/5/manila_tempest_tests/tests/scenario/manager_share.py@60","commit_id":"5608f1bc70faed221bdbe9a4288a897a109700ea"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a482fe42ecd9cd0cb4c6f66a55d4b57397ce7eab","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def skip_checks(cls):"},{"line_number":51,"context_line":"        super(ShareShrinkBase, cls).skip_checks()"},{"line_number":52,"context_line":"        if cls.protocol not in CONF.share.enable_ip_rules_for_protocols:"},{"line_number":53,"context_line":"            message \u003d (\"%s tests for access rules other than IP are disabled\" %"},{"line_number":54,"context_line":"                       cls.protocol)"},{"line_number":55,"context_line":"            raise cls.skipException(message)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":58,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4c43b2_ec6ddbcc","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":44},"in_reply_to":"3f4c43b2_1f3cb1e0","updated":"2020-04-19 04:51:59.000000000","message":"You\u0027re right, but I did it on purpose.\nOur downstream plugin(tempest_storage_plugin) inherits from \"manager_share\" class.\nSo in case we want to test \"CephFS\" protocol  in \"tempest_storage_plugin\" this condition \nwill skip the test.","commit_id":"5608f1bc70faed221bdbe9a4288a897a109700ea"}]}