)]}'
{"manila_tempest_tests/tests/scenario/test_share_shrink.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40e3849b4667a65bfb75e39c4c1813353fd4bf84","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        if share[\"status\"] \u003d\u003d constants.STATUS_AVAILABLE:"},{"line_number":92,"context_line":"            messages \u003d self.shares_v2_client.list_messages()"},{"line_number":93,"context_line":"            self.assertTrue(\u0027009\u0027,"},{"line_number":94,"context_line":"                            [message[\u0027action_id\u0027] for message in messages])"},{"line_number":95,"context_line":"            self.assertEqual(share_size, int(share[\"size\"]))"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_5fb2b995","line":93,"range":{"start_line":93,"start_character":17,"end_line":93,"end_character":27},"updated":"2020-04-18 00:25:26.000000000","message":"You mean assertIn?","commit_id":"c53deffba809feb6b33427617872ffd4ee913aa4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40e3849b4667a65bfb75e39c4c1813353fd4bf84","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        if share[\"status\"] \u003d\u003d constants.STATUS_AVAILABLE:"},{"line_number":92,"context_line":"            messages \u003d self.shares_v2_client.list_messages()"},{"line_number":93,"context_line":"            self.assertTrue(\u0027009\u0027,"},{"line_number":94,"context_line":"                            [message[\u0027action_id\u0027] for message in messages])"},{"line_number":95,"context_line":"            self.assertEqual(share_size, int(share[\"size\"]))"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        LOG.debug(\u0027Step 9 - delete data\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_1fb95179","line":94,"range":{"start_line":93,"start_character":28,"end_line":94,"end_character":75},"updated":"2020-04-18 00:25:26.000000000","message":"Ensure that this message is for this specific share.. you can filter list_messages on line 92 with \"resource_id\"","commit_id":"c53deffba809feb6b33427617872ffd4ee913aa4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40e3849b4667a65bfb75e39c4c1813353fd4bf84","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        LOG.debug(\u0027Step 12 - unmount\u0027)"},{"line_number":117,"context_line":"        self.unmount_share(remote_client)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def share_shrink_retry_until_success(self, share_id, share_size,"},{"line_number":120,"context_line":"                                         status_attr\u003d\u0027status\u0027):"},{"line_number":121,"context_line":"        \"\"\"Try share reset, followed by shrink, until timeout\"\"\""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_3f724de4","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":40},"updated":"2020-04-18 00:25:26.000000000","message":"This loop was written to accommodate backends that will take a while to garbage collect and release the space previously occupied by file /mnt/t1 (deleted on line 98). Why change this behavior?","commit_id":"c53deffba809feb6b33427617872ffd4ee913aa4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b4217a0dd5399474999be5fcd978b2319b77bd59","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ShareShrinkBase(manager.ShareScenarioTest):"},{"line_number":31,"context_line":"    \"\"\"This test case uses the following flow:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"     * Launch an instance"},{"line_number":34,"context_line":"     * Create share (Configured size + 1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_68a8c5da","line":31,"updated":"2020-04-23 17:45:32.000000000","message":"nit: I think that there is no need to remove this blank line","commit_id":"01d109f9134e3a7694905ef7954b4960cf99b7f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b4217a0dd5399474999be5fcd978b2319b77bd59","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if share[\"status\"] \u003d\u003d constants.STATUS_AVAILABLE:"},{"line_number":91,"context_line":"            messages \u003d self.shares_v2_client.list_messages()"},{"line_number":92,"context_line":"            self.assertIn(\u0027009\u0027,"},{"line_number":93,"context_line":"                          [message[\u0027action_id\u0027] for message in messages])"},{"line_number":94,"context_line":"            self.assertEqual(share_size, int(share[\"size\"]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_c588e4c7","line":91,"range":{"start_line":91,"start_character":12,"end_line":91,"end_character":60},"updated":"2020-04-23 17:45:32.000000000","message":"I think you could filter this using the resource_id as Goutham suggested... So the queried messages would only be related to the resource id you\u0027re dealing with.","commit_id":"01d109f9134e3a7694905ef7954b4960cf99b7f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b4217a0dd5399474999be5fcd978b2319b77bd59","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        check_interval \u003d CONF.share.build_interval * 2"},{"line_number":123,"context_line":"        # share_status will be None to enter in shrink retry loop"},{"line_number":124,"context_line":"        share_status \u003d None"},{"line_number":125,"context_line":"        start \u003d int(time.time())"},{"line_number":126,"context_line":"        while share_status !\u003d constants.STATUS_AVAILABLE:"},{"line_number":127,"context_line":"            body \u003d self.shares_v2_client.get_share(share_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_e8c4d561","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":27},"updated":"2020-04-23 17:45:32.000000000","message":"Is there a specific reason to set this value to None?\nIf not, i think this could remain as it was:\nbody \u003d self.shares_v2_client.get_share(share_id)\nshare_status \u003d body[status_attr]\nSince at this point the share will possibly be in a state different from available.\n\nThen the get_share request would only be executed once by each while iteration and we would avoid it being called at the very beginning and at the end. :). What do you think?","commit_id":"01d109f9134e3a7694905ef7954b4960cf99b7f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b4217a0dd5399474999be5fcd978b2319b77bd59","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        while share_status !\u003d constants.STATUS_AVAILABLE:"},{"line_number":127,"context_line":"            body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":128,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":129,"context_line":"            if share_status \u003d\u003d \\"},{"line_number":130,"context_line":"                    constants.STATUS_SHRINKING_POSSIBLE_DATA_LOSS_ERROR:"},{"line_number":131,"context_line":"                self.shares_admin_v2_client.reset_state("},{"line_number":132,"context_line":"                    share_id, status\u003dconstants.STATUS_AVAILABLE)"},{"line_number":133,"context_line":"            if share_status !\u003d constants.STATUS_SHRINKING:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_c83bd9ce","line":130,"range":{"start_line":129,"start_character":15,"end_line":130,"end_character":71},"updated":"2020-04-23 17:45:32.000000000","message":"please surround this with (), then you\u0027ll not need to use the \\","commit_id":"01d109f9134e3a7694905ef7954b4960cf99b7f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b4217a0dd5399474999be5fcd978b2319b77bd59","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                    self.shares_v2_client.shrink_share(share_id,"},{"line_number":136,"context_line":"                                                       new_size\u003dshare_size)"},{"line_number":137,"context_line":"                except exceptions.BadRequest as e:"},{"line_number":138,"context_line":"                    if (\u0027New size for shrink must be less than current size\u0027)\\"},{"line_number":139,"context_line":"                            in six.text_type(e):"},{"line_number":140,"context_line":"                        break"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"            time.sleep(check_interval)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_a83bedc5","line":139,"range":{"start_line":138,"start_character":20,"end_line":139,"end_character":48},"updated":"2020-04-23 17:45:32.000000000","message":"same as above","commit_id":"01d109f9134e3a7694905ef7954b4960cf99b7f7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c9525c0f7bca2aec16899d99de5fdb671f648256","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        if share[\"status\"] \u003d\u003d constants.STATUS_AVAILABLE:"},{"line_number":92,"context_line":"            messages \u003d self.shares_v2_client.list_messages()"},{"line_number":93,"context_line":"            messages_from_share \u003d []"},{"line_number":94,"context_line":"            for message in messages:"},{"line_number":95,"context_line":"                messages_from_share +\u003d (message[\u0027action_id\u0027] if"},{"line_number":96,"context_line":"                                        message[\u0027resource_id\u0027] \u003d\u003d"},{"line_number":97,"context_line":"                                        share[\"id\"] else [])"},{"line_number":98,"context_line":"            self.assertIn(\u00279\u0027, messages_from_share)"},{"line_number":99,"context_line":"            self.assertEqual(share_size, int(share[\"size\"]))"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_cc310da5","line":97,"range":{"start_line":92,"start_character":12,"end_line":97,"end_character":60},"updated":"2020-04-24 21:17:20.000000000","message":"Hey Daniel, please take a look here[1]\n\n[1] https://opendev.org/openstack/manila-tempest-plugin/src/branch/master/manila_tempest_tests/tests/api/admin/test_user_messages.py#L82-L83","commit_id":"eb40d3515081c2e2ecd50e93961dc0a990f77571"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ac06550e569dc4dcdcfc75ffd5a7966947447b3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            time.sleep(check_interval)"},{"line_number":147,"context_line":"            body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":148,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":149,"context_line":"            share_current_size \u003d body[\"size\"]"},{"line_number":150,"context_line":"            if int(time.time()) - start \u003e\u003d CONF.share.build_timeout:"},{"line_number":151,"context_line":"                message \u003d (\"Share %(share_id)s failed to shrink within the \""},{"line_number":152,"context_line":"                           \"required time %(seconds)s.\" %"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_5e13db5c","line":149,"updated":"2020-04-25 13:22:21.000000000","message":"I think that you still need to check the sizes here and return if they are equal. It may happen that even with a successful share shrinking, an time exception could be raised due timeouts in the following validation.","commit_id":"4bb86e2bcc7bb5baed50b6f80f0a0c008e2d7034"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85f4265d3c99b09cf74eb634546b759e5c4f3133","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        LOG.debug(\u0027Step 12 - unmount\u0027)"},{"line_number":118,"context_line":"        self.unmount_share(remote_client)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def share_shrink_retry_until_success(self, share_id, share_size,"},{"line_number":121,"context_line":"                                         status_attr\u003d\u0027status\u0027):"},{"line_number":122,"context_line":"        \"\"\"Try share reset, followed by shrink, until timeout\"\"\""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_469dba08","line":120,"range":{"start_line":120,"start_character":57,"end_line":120,"end_character":67},"updated":"2020-04-27 16:19:54.000000000","message":"can you rename this to \"new_size\" for readability","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":31528,"name":"Daniel Tapia","email":"danielarthurt@gmail.com","username":"danielarthurt"},"change_message_id":"e151f244d0d10cc6de432d3e27104603e4d2eed9","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        LOG.debug(\u0027Step 12 - unmount\u0027)"},{"line_number":118,"context_line":"        self.unmount_share(remote_client)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def share_shrink_retry_until_success(self, share_id, share_size,"},{"line_number":121,"context_line":"                                         status_attr\u003d\u0027status\u0027):"},{"line_number":122,"context_line":"        \"\"\"Try share reset, followed by shrink, until timeout\"\"\""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_d23d0090","line":120,"range":{"start_line":120,"start_character":57,"end_line":120,"end_character":67},"in_reply_to":"1f493fa4_469dba08","updated":"2020-04-27 18:38:26.000000000","message":"Hi Goutham, thank you for your review! Done!","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85f4265d3c99b09cf74eb634546b759e5c4f3133","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \"\"\"Try share reset, followed by shrink, until timeout\"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        check_interval \u003d CONF.share.build_interval * 2"},{"line_number":125,"context_line":"        # share_status will be None to enter in shrink retry loop"},{"line_number":126,"context_line":"        body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":127,"context_line":"        share_current_size \u003d body[\"size\"]"},{"line_number":128,"context_line":"        share_status \u003d body[status_attr]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_a6f8fe48","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":65},"updated":"2020-04-27 16:19:54.000000000","message":"What does this comment mean? Why will it be None?","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":31528,"name":"Daniel Tapia","email":"danielarthurt@gmail.com","username":"danielarthurt"},"change_message_id":"e151f244d0d10cc6de432d3e27104603e4d2eed9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \"\"\"Try share reset, followed by shrink, until timeout\"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        check_interval \u003d CONF.share.build_interval * 2"},{"line_number":125,"context_line":"        # share_status will be None to enter in shrink retry loop"},{"line_number":126,"context_line":"        body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":127,"context_line":"        share_current_size \u003d body[\"size\"]"},{"line_number":128,"context_line":"        share_status \u003d body[status_attr]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_5249f02e","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":65},"in_reply_to":"1f493fa4_a6f8fe48","updated":"2020-04-27 18:38:26.000000000","message":"I forgot to erase this part. It was from previous patch updates. (Patch 5/6)","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85f4265d3c99b09cf74eb634546b759e5c4f3133","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        check_interval \u003d CONF.share.build_interval * 2"},{"line_number":125,"context_line":"        # share_status will be None to enter in shrink retry loop"},{"line_number":126,"context_line":"        body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":127,"context_line":"        share_current_size \u003d body[\"size\"]"},{"line_number":128,"context_line":"        share_status \u003d body[status_attr]"},{"line_number":129,"context_line":"        start \u003d int(time.time())"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_86b34298","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":12},"updated":"2020-04-27 16:19:54.000000000","message":"share","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":31528,"name":"Daniel Tapia","email":"danielarthurt@gmail.com","username":"danielarthurt"},"change_message_id":"e151f244d0d10cc6de432d3e27104603e4d2eed9","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        check_interval \u003d CONF.share.build_interval * 2"},{"line_number":125,"context_line":"        # share_status will be None to enter in shrink retry loop"},{"line_number":126,"context_line":"        body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":127,"context_line":"        share_current_size \u003d body[\"size\"]"},{"line_number":128,"context_line":"        share_status \u003d body[status_attr]"},{"line_number":129,"context_line":"        start \u003d int(time.time())"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_b252f4dc","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":12},"in_reply_to":"1f493fa4_86b34298","updated":"2020-04-27 18:38:26.000000000","message":"Done!","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85f4265d3c99b09cf74eb634546b759e5c4f3133","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        share_status \u003d body[status_attr]"},{"line_number":129,"context_line":"        start \u003d int(time.time())"},{"line_number":130,"context_line":"        while share_current_size !\u003d share_size:"},{"line_number":131,"context_line":"            body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":132,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":133,"context_line":"            if (share_status \u003d\u003d"},{"line_number":134,"context_line":"                    constants.STATUS_SHRINKING_POSSIBLE_DATA_LOSS_ERROR):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_c6a9ca24","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":16},"updated":"2020-04-27 16:19:54.000000000","message":"share\n\nIs this retrieval required? Wouldn\u0027t the retrievals on line 126 and line 147 suffice?","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":31528,"name":"Daniel Tapia","email":"danielarthurt@gmail.com","username":"danielarthurt"},"change_message_id":"e151f244d0d10cc6de432d3e27104603e4d2eed9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        share_status \u003d body[status_attr]"},{"line_number":129,"context_line":"        start \u003d int(time.time())"},{"line_number":130,"context_line":"        while share_current_size !\u003d share_size:"},{"line_number":131,"context_line":"            body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":132,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":133,"context_line":"            if (share_status \u003d\u003d"},{"line_number":134,"context_line":"                    constants.STATUS_SHRINKING_POSSIBLE_DATA_LOSS_ERROR):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_92689887","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":16},"in_reply_to":"1f493fa4_c6a9ca24","updated":"2020-04-27 18:38:26.000000000","message":"Not anymore, before it was necessary because I put the state at None in the patch 5/6. Thanks for warning me.","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85f4265d3c99b09cf74eb634546b759e5c4f3133","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":133,"context_line":"            if (share_status \u003d\u003d"},{"line_number":134,"context_line":"                    constants.STATUS_SHRINKING_POSSIBLE_DATA_LOSS_ERROR):"},{"line_number":135,"context_line":"                self.shares_admin_v2_client.reset_state("},{"line_number":136,"context_line":"                    share_id, status\u003dconstants.STATUS_AVAILABLE)"},{"line_number":137,"context_line":"            if share_status !\u003d constants.STATUS_SHRINKING:"},{"line_number":138,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_b148365c","line":135,"range":{"start_line":135,"start_character":15,"end_line":135,"end_character":16},"updated":"2020-04-27 16:19:54.000000000","message":"Can you add a comment either here, or on line 104\n\n # Deletion of files can be an asynchronous activity on the backend, and\n # we\u0027ll wait until timeout for the space to be reclaimed by repeating the \n # shrink request","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":31528,"name":"Daniel Tapia","email":"danielarthurt@gmail.com","username":"danielarthurt"},"change_message_id":"e151f244d0d10cc6de432d3e27104603e4d2eed9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":133,"context_line":"            if (share_status \u003d\u003d"},{"line_number":134,"context_line":"                    constants.STATUS_SHRINKING_POSSIBLE_DATA_LOSS_ERROR):"},{"line_number":135,"context_line":"                self.shares_admin_v2_client.reset_state("},{"line_number":136,"context_line":"                    share_id, status\u003dconstants.STATUS_AVAILABLE)"},{"line_number":137,"context_line":"            if share_status !\u003d constants.STATUS_SHRINKING:"},{"line_number":138,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_92fd38b3","line":135,"range":{"start_line":135,"start_character":15,"end_line":135,"end_character":16},"in_reply_to":"1f493fa4_b148365c","updated":"2020-04-27 18:38:26.000000000","message":"I\u0027ve added at the line 104.","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85f4265d3c99b09cf74eb634546b759e5c4f3133","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                        break"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            time.sleep(check_interval)"},{"line_number":147,"context_line":"            body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":148,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":149,"context_line":"            share_current_size \u003d body[\"size\"]"},{"line_number":150,"context_line":"            if share_current_size \u003d\u003d share_size:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_11cf6ab0","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":16},"updated":"2020-04-27 16:19:54.000000000","message":"share","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":31528,"name":"Daniel Tapia","email":"danielarthurt@gmail.com","username":"danielarthurt"},"change_message_id":"e151f244d0d10cc6de432d3e27104603e4d2eed9","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                        break"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            time.sleep(check_interval)"},{"line_number":147,"context_line":"            body \u003d self.shares_v2_client.get_share(share_id)"},{"line_number":148,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":149,"context_line":"            share_current_size \u003d body[\"size\"]"},{"line_number":150,"context_line":"            if share_current_size \u003d\u003d share_size:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_3226e469","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":16},"in_reply_to":"1f493fa4_11cf6ab0","updated":"2020-04-27 18:38:26.000000000","message":"Done!","commit_id":"945c308eada3d8360a39976a6912e7471d78afa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50d72035a6b55170d951151b55c37ae6ad6da01a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        LOG.debug(\u0027Step 10 - reset and shrink\u0027)"},{"line_number":108,"context_line":"        self.share_shrink_retry_until_success(share[\"id\"],"},{"line_number":109,"context_line":"                                              new_size\u003ddefault_share_size"},{"line_number":110,"context_line":"                                              )"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":113,"context_line":"        self.assertEqual(default_share_size, int(share[\"size\"]))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f493fa4_c630a5eb","line":110,"range":{"start_line":110,"start_character":46,"end_line":110,"end_character":47},"updated":"2020-04-27 18:58:52.000000000","message":"nit: pull to previous line, https://docs.openstack.org/hacking/latest/user/hacking.html#calling-methods","commit_id":"24024433fd0329134c6e447356a2de58f1a89170"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50d72035a6b55170d951151b55c37ae6ad6da01a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                    constants.STATUS_SHRINKING_POSSIBLE_DATA_LOSS_ERROR):"},{"line_number":136,"context_line":"                self.shares_admin_v2_client.reset_state("},{"line_number":137,"context_line":"                    share_id, status\u003dconstants.STATUS_AVAILABLE)"},{"line_number":138,"context_line":"            if share_status !\u003d constants.STATUS_SHRINKING:"},{"line_number":139,"context_line":"                try:"},{"line_number":140,"context_line":"                    self.shares_v2_client.shrink_share(share_id,"},{"line_number":141,"context_line":"                                                       new_size\u003dnew_size"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f493fa4_12176853","line":138,"range":{"start_line":138,"start_character":12,"end_line":138,"end_character":14},"updated":"2020-04-27 18:58:52.000000000","message":"nit: elif","commit_id":"24024433fd0329134c6e447356a2de58f1a89170"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50d72035a6b55170d951151b55c37ae6ad6da01a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                try:"},{"line_number":140,"context_line":"                    self.shares_v2_client.shrink_share(share_id,"},{"line_number":141,"context_line":"                                                       new_size\u003dnew_size"},{"line_number":142,"context_line":"                                                       )"},{"line_number":143,"context_line":"                except exceptions.BadRequest as e:"},{"line_number":144,"context_line":"                    if (\u0027New size for shrink must be less than current size\u0027"},{"line_number":145,"context_line":"                            in six.text_type(e)):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f493fa4_c6170545","line":142,"range":{"start_line":142,"start_character":55,"end_line":142,"end_character":56},"updated":"2020-04-27 18:58:52.000000000","message":"nit: this bracket belongs in the previous line, https://docs.openstack.org/hacking/latest/user/hacking.html#calling-methods","commit_id":"24024433fd0329134c6e447356a2de58f1a89170"}]}