)]}'
{"manila_tempest_tests/tests/api/admin/test_user_messages.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"da477cd91628be5338fe86775f6cabe151a1f6eb","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    @decorators.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":119,"context_line":"    @base.skip_if_microversion_not_supported(QUERY_BY_TIMESTAMP_MICROVERSION)"},{"line_number":120,"context_line":"    def test_list_messages_with_since_and_before_filters(self):"},{"line_number":121,"context_line":"        created_at \u003d timeutils.parse_strtime(self.message[\u0027created_at\u0027])"},{"line_number":122,"context_line":"        time_since \u003d created_at - datetime.timedelta(seconds\u003d1)"},{"line_number":123,"context_line":"        time_before \u003d created_at + datetime.timedelta(seconds\u003d1)"},{"line_number":124,"context_line":"        params \u003d {\u0027created_since\u0027: str(time_since),"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_27892c74","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":8},"updated":"2020-04-02 23:13:17.000000000","message":"Can you create one or two more messages and assert that you receive a subset through your queries with these combinations:\n\n - since self.message[\u0027created_at\u0027] (should return\n   all user messages created by this test including self.message)\n - since self.message[\u0027created_at\u0027] -1 but before\n    created_at + datetime.timedelta(seconds\u003d1) (should not\n   return messages created in this test, but return a list that is\n   greater than or equal to 1 and include self.message)\n - before created_at + datetime.timedelta(seconds\u003d1) - should\n   not include self.message","commit_id":"ebe9884b97cd1b529db7438ec6b38f6dd7dec6fd"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1e0ba8565e46592e992eceaf4b3af56fe9630561","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    @decorators.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":119,"context_line":"    @base.skip_if_microversion_not_supported(QUERY_BY_TIMESTAMP_MICROVERSION)"},{"line_number":120,"context_line":"    def test_list_messages_with_since_and_before_filters(self):"},{"line_number":121,"context_line":"        created_at \u003d timeutils.parse_strtime(self.message[\u0027created_at\u0027])"},{"line_number":122,"context_line":"        time_since \u003d created_at - datetime.timedelta(seconds\u003d1)"},{"line_number":123,"context_line":"        time_before \u003d created_at + datetime.timedelta(seconds\u003d1)"},{"line_number":124,"context_line":"        params \u003d {\u0027created_since\u0027: str(time_since),"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_add99b83","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":8},"in_reply_to":"df33271e_27892c74","updated":"2020-04-03 02:00:32.000000000","message":"hi, goutham, i change the last two test case like below:\n\n- since self.message[\u0027created_at\u0027] -1 but before\n   created_at - datetime.timedelta(seconds\u003d1) (should not\n   return messages created in this test, but return a list \n   that is greater than or equal to 1 and include \n   self.message)\n - before created_at - datetime.timedelta(seconds\u003d1) - should\n   include self.message, but not include message created in \n   this test.","commit_id":"ebe9884b97cd1b529db7438ec6b38f6dd7dec6fd"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"40bf1d6c094a91d0f3bc39fa76fa9ba47288fa4e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        params1 \u003d {\u0027created_since\u0027: str(created_at_1)}"},{"line_number":128,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":129,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":130,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":131,"context_line":"        self.assertIn(msg[\u0027id\u0027], ids)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_ded7544f","line":130,"updated":"2020-04-03 21:15:09.000000000","message":"Shall we assert that the length of the list is 2? All the messages (the one created on setUp and the one created in the test) should be retrieved in this case, so we should have exactly two messages at this point","commit_id":"bd4a9cf858cf51c7eafa2616f7d1ac43b45906de"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0baf3abcedd8fbca0149fd0530c5ae9d5f4bdcca","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        params1 \u003d {\u0027created_since\u0027: str(created_at_1)}"},{"line_number":128,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":129,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":130,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":131,"context_line":"        self.assertIn(msg[\u0027id\u0027], ids)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_5562fed9","line":130,"in_reply_to":"df33271e_ded7544f","updated":"2020-04-04 10:50:05.000000000","message":"yes, the length of the list should be 2,we can assertEqual heer.","commit_id":"bd4a9cf858cf51c7eafa2616f7d1ac43b45906de"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"40bf1d6c094a91d0f3bc39fa76fa9ba47288fa4e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":136,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":137,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":138,"context_line":"        self.assertTrue(len(body) \u003e\u003d 1)"},{"line_number":139,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":140,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_7ed0c854","line":138,"updated":"2020-04-03 21:15:09.000000000","message":"Same here maybe, just make it assertEqual","commit_id":"bd4a9cf858cf51c7eafa2616f7d1ac43b45906de"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0baf3abcedd8fbca0149fd0530c5ae9d5f4bdcca","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":136,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":137,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":138,"context_line":"        self.assertTrue(len(body) \u003e\u003d 1)"},{"line_number":139,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":140,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_959926d2","line":138,"in_reply_to":"df33271e_7ed0c854","updated":"2020-04-04 10:50:05.000000000","message":"yes, i will add assertEqual.","commit_id":"bd4a9cf858cf51c7eafa2616f7d1ac43b45906de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04263f40c22cc862c5d36d97d3c558b72187026c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    @decorators.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":119,"context_line":"    @base.skip_if_microversion_not_supported(QUERY_BY_TIMESTAMP_MICROVERSION)"},{"line_number":120,"context_line":"    def test_list_messages_with_since_and_before_filters(self):"},{"line_number":121,"context_line":"        msg \u003d self.create_user_message()"},{"line_number":122,"context_line":"        created_at_1 \u003d timeutils.parse_strtime(self.message[\u0027created_at\u0027])"},{"line_number":123,"context_line":"        created_at_2 \u003d timeutils.parse_strtime(msg[\u0027created_at\u0027])"},{"line_number":124,"context_line":"        time_1 \u003d created_at_1 - datetime.timedelta(seconds\u003d1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_462dedfb","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":11},"updated":"2020-04-07 23:54:23.000000000","message":"nit: call this \"new_message\" perhaps, to make this test more readable","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    @decorators.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":119,"context_line":"    @base.skip_if_microversion_not_supported(QUERY_BY_TIMESTAMP_MICROVERSION)"},{"line_number":120,"context_line":"    def test_list_messages_with_since_and_before_filters(self):"},{"line_number":121,"context_line":"        msg \u003d self.create_user_message()"},{"line_number":122,"context_line":"        created_at_1 \u003d timeutils.parse_strtime(self.message[\u0027created_at\u0027])"},{"line_number":123,"context_line":"        created_at_2 \u003d timeutils.parse_strtime(msg[\u0027created_at\u0027])"},{"line_number":124,"context_line":"        time_1 \u003d created_at_1 - datetime.timedelta(seconds\u003d1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_d5c9a078","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":11},"in_reply_to":"df33271e_462dedfb","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"5a568979da2c421cc83754626fcd8d0ea32510c2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        time_1 \u003d created_at_1 - datetime.timedelta(seconds\u003d1)"},{"line_number":125,"context_line":"        time_2 \u003d created_at_2 - datetime.timedelta(seconds\u003d1)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        params1 \u003d {\u0027created_since\u0027: str(created_at_1)}"},{"line_number":128,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":129,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":130,"context_line":"        self.assertEqual(len(ids), 2)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_38df38d7","line":127,"updated":"2020-04-07 13:41:51.000000000","message":"NIT. Add # Should return all user messages created by this test including self.message","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04263f40c22cc862c5d36d97d3c558b72187026c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        time_1 \u003d created_at_1 - datetime.timedelta(seconds\u003d1)"},{"line_number":125,"context_line":"        time_2 \u003d created_at_2 - datetime.timedelta(seconds\u003d1)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        params1 \u003d {\u0027created_since\u0027: str(created_at_1)}"},{"line_number":128,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":129,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":130,"context_line":"        self.assertEqual(len(ids), 2)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_c6ca9d44","line":127,"in_reply_to":"df33271e_38df38d7","updated":"2020-04-07 23:54:23.000000000","message":"+1","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        time_1 \u003d created_at_1 - datetime.timedelta(seconds\u003d1)"},{"line_number":125,"context_line":"        time_2 \u003d created_at_2 - datetime.timedelta(seconds\u003d1)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        params1 \u003d {\u0027created_since\u0027: str(created_at_1)}"},{"line_number":128,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":129,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":130,"context_line":"        self.assertEqual(len(ids), 2)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_35872c12","line":127,"in_reply_to":"df33271e_38df38d7","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        time_1 \u003d created_at_1 - datetime.timedelta(seconds\u003d1)"},{"line_number":125,"context_line":"        time_2 \u003d created_at_2 - datetime.timedelta(seconds\u003d1)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        params1 \u003d {\u0027created_since\u0027: str(created_at_1)}"},{"line_number":128,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":129,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":130,"context_line":"        self.assertEqual(len(ids), 2)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_d577e039","line":127,"in_reply_to":"df33271e_c6ca9d44","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04263f40c22cc862c5d36d97d3c558b72187026c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        time_2 \u003d created_at_2 - datetime.timedelta(seconds\u003d1)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        params1 \u003d {\u0027created_since\u0027: str(created_at_1)}"},{"line_number":128,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":129,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":130,"context_line":"        self.assertEqual(len(ids), 2)"},{"line_number":131,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_6605917a","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":12},"updated":"2020-04-07 23:54:23.000000000","message":"nit: messages","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        time_2 \u003d created_at_2 - datetime.timedelta(seconds\u003d1)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        params1 \u003d {\u0027created_since\u0027: str(created_at_1)}"},{"line_number":128,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":129,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":130,"context_line":"        self.assertEqual(len(ids), 2)"},{"line_number":131,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_b5a7bca7","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":12},"in_reply_to":"df33271e_6605917a","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"5a568979da2c421cc83754626fcd8d0ea32510c2","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":132,"context_line":"        self.assertIn(msg[\u0027id\u0027], ids)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"},{"line_number":135,"context_line":"                   \u0027created_before\u0027: str(time_2)}"},{"line_number":136,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":137,"context_line":"        self.assertIsInstance(body, list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_b8ece88f","line":134,"updated":"2020-04-07 13:41:51.000000000","message":"NIT. Add # should not return messages created in this test, but return a list that is greater than or equal to 1 and include self.message","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":132,"context_line":"        self.assertIn(msg[\u0027id\u0027], ids)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"},{"line_number":135,"context_line":"                   \u0027created_before\u0027: str(time_2)}"},{"line_number":136,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":137,"context_line":"        self.assertIsInstance(body, list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_f5df8409","line":134,"in_reply_to":"df33271e_8637f54d","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04263f40c22cc862c5d36d97d3c558b72187026c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":132,"context_line":"        self.assertIn(msg[\u0027id\u0027], ids)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"},{"line_number":135,"context_line":"                   \u0027created_before\u0027: str(time_2)}"},{"line_number":136,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":137,"context_line":"        self.assertIsInstance(body, list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_8637f54d","line":134,"in_reply_to":"df33271e_b8ece88f","updated":"2020-04-07 23:54:23.000000000","message":"+1\n\nI agree these comments could be added for readability\n\nYou can make this succinct, \n\n # should not return new_message","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":132,"context_line":"        self.assertIn(msg[\u0027id\u0027], ids)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"},{"line_number":135,"context_line":"                   \u0027created_before\u0027: str(time_2)}"},{"line_number":136,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":137,"context_line":"        self.assertIsInstance(body, list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_15ddc813","line":134,"in_reply_to":"df33271e_b8ece88f","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04263f40c22cc862c5d36d97d3c558b72187026c","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"},{"line_number":135,"context_line":"                   \u0027created_before\u0027: str(time_2)}"},{"line_number":136,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":137,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":138,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":139,"context_line":"        self.assertEqual(len(ids), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_e63d212d","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":12},"updated":"2020-04-07 23:54:23.000000000","message":"nit: messages","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"},{"line_number":135,"context_line":"                   \u0027created_before\u0027: str(time_2)}"},{"line_number":136,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":137,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":138,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":139,"context_line":"        self.assertEqual(len(ids), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_95d0b8f9","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":12},"in_reply_to":"df33271e_e63d212d","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"5a568979da2c421cc83754626fcd8d0ea32510c2","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":141,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        params3 \u003d {\u0027created_before\u0027: str(time_2)}"},{"line_number":144,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams3)"},{"line_number":145,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":146,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_f8fdd03b","line":143,"updated":"2020-04-07 13:41:51.000000000","message":"NIT. Add # should not include self.message","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":141,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        params3 \u003d {\u0027created_before\u0027: str(time_2)}"},{"line_number":144,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams3)"},{"line_number":145,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":146,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_75cb7449","line":143,"in_reply_to":"df33271e_f8fdd03b","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04263f40c22cc862c5d36d97d3c558b72187026c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        params3 \u003d {\u0027created_before\u0027: str(time_2)}"},{"line_number":144,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams3)"},{"line_number":145,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":146,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":147,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_861095aa","line":144,"range":{"start_line":144,"start_character":8,"end_line":144,"end_character":12},"updated":"2020-04-07 23:54:23.000000000","message":"messages","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        params3 \u003d {\u0027created_before\u0027: str(time_2)}"},{"line_number":144,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams3)"},{"line_number":145,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":146,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":147,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_d5da4015","line":144,"range":{"start_line":144,"start_character":8,"end_line":144,"end_character":12},"in_reply_to":"df33271e_861095aa","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"5a568979da2c421cc83754626fcd8d0ea32510c2","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        params3 \u003d {\u0027created_before\u0027: str(time_2)}"},{"line_number":144,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams3)"},{"line_number":145,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":146,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":147,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_18cb5453","line":146,"updated":"2020-04-07 13:41:51.000000000","message":"NIT. add self.assertEqual(len(ids), 1) here","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8facec4146eba0d591fc1432e7a65c906615972d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        params3 \u003d {\u0027created_before\u0027: str(time_2)}"},{"line_number":144,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams3)"},{"line_number":145,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"},{"line_number":146,"context_line":"        self.assertNotIn(msg[\u0027id\u0027], ids)"},{"line_number":147,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_f5082492","line":146,"in_reply_to":"df33271e_18cb5453","updated":"2020-04-08 01:56:50.000000000","message":"Done","commit_id":"296442ab22112f818a36756217289f6b33b0dd79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de477dfe5b1d07694ba43d3700530fcd948563cc","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # self.message"},{"line_number":130,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":131,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in messages]"},{"line_number":132,"context_line":"        self.assertEqual(len(ids), 2)"},{"line_number":133,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":134,"context_line":"        self.assertIn(new_message[\u0027id\u0027], ids)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_db026fb4","line":132,"range":{"start_line":132,"start_character":13,"end_line":132,"end_character":24},"updated":"2020-04-08 04:36:15.000000000","message":"assertGreaterEqual\n\n\nHere and below.. \n\nThe problem here is this, tests run concurrently, and other tests may be causing the creation of user messages. So you can\u0027t determine that you\u0027ll receive exactly one or two messages. \n\nSo, please assert on the minimum number of messages you expect your search to return.\n\nAnd, if you want further clarification, you can do this:\n\n for message in messages:\n     time_difference \u003d timeutils.delta_seconds(\n             time_1,   timeutils.parse_strtime(message[\u0027created_at\u0027]))\n     self.assertGreater(time_difference, 0)\n                           \n\n\n\nhttps://docs.openstack.org/oslo.utils/latest/reference/timeutils.html","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd1bfa5b85e2cce0dcf51796afd9ffe3ff824bc0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # self.message"},{"line_number":130,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":131,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in messages]"},{"line_number":132,"context_line":"        self.assertEqual(len(ids), 2)"},{"line_number":133,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":134,"context_line":"        self.assertIn(new_message[\u0027id\u0027], ids)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_a5364602","line":132,"range":{"start_line":132,"start_character":13,"end_line":132,"end_character":24},"in_reply_to":"df33271e_1e7685a5","updated":"2020-04-08 23:29:45.000000000","message":"Thanks, Haixin.. What do you think of adding that further test? We\u0027re in no rush to merge this right now; if you wanted to add that assertion suggested, we can hold off..","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"89db459aead177a4b2571b3d5143eb6a4ea4cf00","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # self.message"},{"line_number":130,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams1)"},{"line_number":131,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in messages]"},{"line_number":132,"context_line":"        self.assertEqual(len(ids), 2)"},{"line_number":133,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":134,"context_line":"        self.assertIn(new_message[\u0027id\u0027], ids)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_1e7685a5","line":132,"range":{"start_line":132,"start_character":13,"end_line":132,"end_character":24},"in_reply_to":"df33271e_db026fb4","updated":"2020-04-08 05:50:11.000000000","message":"yes, Goutham Pacha Ravi, \ni think we better to use assertGreaterEqual","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de477dfe5b1d07694ba43d3700530fcd948563cc","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"},{"line_number":137,"context_line":"                   \u0027created_before\u0027: str(time_2)}"},{"line_number":138,"context_line":"        # should not return new_message, but return a list that is equal to 1"},{"line_number":139,"context_line":"        # and include self.message"},{"line_number":140,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":141,"context_line":"        self.assertIsInstance(messages, list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_9b210751","line":138,"range":{"start_line":138,"start_character":67,"end_line":138,"end_character":75},"updated":"2020-04-08 04:36:15.000000000","message":"equal to or greater than 1 message","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"89db459aead177a4b2571b3d5143eb6a4ea4cf00","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        params2 \u003d {\u0027created_since\u0027: str(time_1),"},{"line_number":137,"context_line":"                   \u0027created_before\u0027: str(time_2)}"},{"line_number":138,"context_line":"        # should not return new_message, but return a list that is equal to 1"},{"line_number":139,"context_line":"        # and include self.message"},{"line_number":140,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":141,"context_line":"        self.assertIsInstance(messages, list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_5e700da6","line":138,"range":{"start_line":138,"start_character":67,"end_line":138,"end_character":75},"in_reply_to":"df33271e_9b210751","updated":"2020-04-08 05:50:11.000000000","message":"Done","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de477dfe5b1d07694ba43d3700530fcd948563cc","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":141,"context_line":"        self.assertIsInstance(messages, list)"},{"line_number":142,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in messages]"},{"line_number":143,"context_line":"        self.assertEqual(len(ids), 1)"},{"line_number":144,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":145,"context_line":"        self.assertNotIn(new_message[\u0027id\u0027], ids)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_1b2e9742","line":143,"range":{"start_line":143,"start_character":13,"end_line":143,"end_character":24},"updated":"2020-04-08 04:36:15.000000000","message":"assertGreaterEqual","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"89db459aead177a4b2571b3d5143eb6a4ea4cf00","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams2)"},{"line_number":141,"context_line":"        self.assertIsInstance(messages, list)"},{"line_number":142,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in messages]"},{"line_number":143,"context_line":"        self.assertEqual(len(ids), 1)"},{"line_number":144,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"},{"line_number":145,"context_line":"        self.assertNotIn(new_message[\u0027id\u0027], ids)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_3e7389b3","line":143,"range":{"start_line":143,"start_character":13,"end_line":143,"end_character":24},"in_reply_to":"df33271e_1b2e9742","updated":"2020-04-08 05:50:11.000000000","message":"Done","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de477dfe5b1d07694ba43d3700530fcd948563cc","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # should not include self.message"},{"line_number":149,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams3)"},{"line_number":150,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in messages]"},{"line_number":151,"context_line":"        self.assertEqual(len(ids), 1)"},{"line_number":152,"context_line":"        self.assertNotIn(new_message[\u0027id\u0027], ids)"},{"line_number":153,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_fb3013a1","line":151,"range":{"start_line":151,"start_character":13,"end_line":151,"end_character":24},"updated":"2020-04-08 04:36:15.000000000","message":"assertGreaterEqual","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"89db459aead177a4b2571b3d5143eb6a4ea4cf00","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # should not include self.message"},{"line_number":149,"context_line":"        messages \u003d self.shares_v2_client.list_messages(params\u003dparams3)"},{"line_number":150,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in messages]"},{"line_number":151,"context_line":"        self.assertEqual(len(ids), 1)"},{"line_number":152,"context_line":"        self.assertNotIn(new_message[\u0027id\u0027], ids)"},{"line_number":153,"context_line":"        self.assertIn(self.message[\u0027id\u0027], ids)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_9e69f5bf","line":151,"range":{"start_line":151,"start_character":13,"end_line":151,"end_character":24},"in_reply_to":"df33271e_fb3013a1","updated":"2020-04-08 05:50:11.000000000","message":"Done","commit_id":"043d146a10d001c4c681bf0ef747ed74dc6e1a9b"}],"manila_tempest_tests/tests/api/admin/test_user_messages_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6845def40e3f341cdf829f66464b9c66f35d6fdd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @decorators.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API])"},{"line_number":67,"context_line":"    @base.skip_if_microversion_not_supported(QUERY_BY_TIMESTAMP_MICROVERSION)"},{"line_number":68,"context_line":"    def test_list_messages_with_invalid_time_format(self):"},{"line_number":69,"context_line":"        params \u003d {\u0027created_since\u0027: \u0027invalid_time\u0027}"},{"line_number":70,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":71,"context_line":"                          self.shares_v2_client.list_messages,"},{"line_number":72,"context_line":"                          params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_27ee4c21","line":69,"range":{"start_line":69,"start_character":19,"end_line":69,"end_character":32},"updated":"2020-04-02 23:14:09.000000000","message":"use ddt, and include \"created_before\" as well, and a combination of \"created_since\" and \"created_before\"","commit_id":"ebe9884b97cd1b529db7438ec6b38f6dd7dec6fd"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1e0ba8565e46592e992eceaf4b3af56fe9630561","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @decorators.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API])"},{"line_number":67,"context_line":"    @base.skip_if_microversion_not_supported(QUERY_BY_TIMESTAMP_MICROVERSION)"},{"line_number":68,"context_line":"    def test_list_messages_with_invalid_time_format(self):"},{"line_number":69,"context_line":"        params \u003d {\u0027created_since\u0027: \u0027invalid_time\u0027}"},{"line_number":70,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":71,"context_line":"                          self.shares_v2_client.list_messages,"},{"line_number":72,"context_line":"                          params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_421c1e77","line":69,"range":{"start_line":69,"start_character":19,"end_line":69,"end_character":32},"in_reply_to":"df33271e_27ee4c21","updated":"2020-04-03 02:00:32.000000000","message":"Done","commit_id":"ebe9884b97cd1b529db7438ec6b38f6dd7dec6fd"}]}