)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06f338347401d710acf7912621bbaea8cf0c369c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Specifies ip address in case of multi-networking"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CephFS-Native and CephFS-NFS backends require storage network"},{"line_number":10,"context_line":"in addition to the private project network."},{"line_number":11,"context_line":"This causes failure in floating ip creation, since multiple IPv4"},{"line_number":12,"context_line":"addresses are found. This leads to inability to determine"},{"line_number":13,"context_line":"which port to target."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_c9706475","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":43},"updated":"2020-04-30 18:55:59.000000000","message":"Provide a bit more context, or make it generic - these backends can surely be configured without a storage network, but they are done so in Triple-O deployments, perhaps:\n\n\n When connecting a storage_network to VMs, the tests may try\n to associate a FloatingIP to the storage network instead of the\n project network.","commit_id":"e58e83b46f62204bb21a4fe55d0342370ec981c4"}],"manila_tempest_tests/tests/scenario/manager_share.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"fa8850b0d92757d3ba15dafab58545b32ba98075","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            if self.storage_network:"},{"line_number":165,"context_line":"                server \u003d self.os_primary.servers_client.show_server("},{"line_number":166,"context_line":"                    instance[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":167,"context_line":"                ip_addr \u003d server[\u0027addresses\u0027][self.network[\u0027name\u0027]][0][\u0027addr\u0027]"},{"line_number":168,"context_line":"            # Obtain a floating IP"},{"line_number":169,"context_line":"            floating_ip \u003d self.create_floating_ip(instance, ip_addr\u003dip_addr)"},{"line_number":170,"context_line":"            self.floating_ips[instance[\u0027id\u0027]] \u003d floating_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_36ea0ad7","line":167,"updated":"2020-04-30 14:34:57.000000000","message":"Are we guaranteed that the ip_addr that we want to use as the base for the floating IP will always be the first one in the list?","commit_id":"e58e83b46f62204bb21a4fe55d0342370ec981c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b412c9d5faa0d0f8a1d06f7b093d429fe92b3ce","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            if self.storage_network:"},{"line_number":165,"context_line":"                server \u003d self.os_primary.servers_client.show_server("},{"line_number":166,"context_line":"                    instance[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":167,"context_line":"                ip_addr \u003d server[\u0027addresses\u0027][self.network[\u0027name\u0027]][0][\u0027addr\u0027]"},{"line_number":168,"context_line":"            # Obtain a floating IP"},{"line_number":169,"context_line":"            floating_ip \u003d self.create_floating_ip(instance, ip_addr\u003dip_addr)"},{"line_number":170,"context_line":"            self.floating_ips[instance[\u0027id\u0027]] \u003d floating_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_73df7f0c","line":167,"in_reply_to":"1f493fa4_36ea0ad7","updated":"2020-04-30 17:32:00.000000000","message":"Not always.. we don\u0027t need this if statement either, we can always use the network we created to assign the floating ip.. \n\nTake a look at how we grab the ipv6 address we need in the method invoked above:\n\nhttps://opendev.org/openstack/manila-tempest-plugin/src/commit/d3432669d2e782734017cc9308e9fd34768f5bb7/manila_tempest_tests/tests/scenario/manager_share.py#L382-L390\n\n\nyou can create an identical method for filtering out an ipv4 address to use from the instance\u0027s addresses. \n\nIf none is found, line 184 will raise an error and bail out.","commit_id":"e58e83b46f62204bb21a4fe55d0342370ec981c4"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"aa2ee6833f839f077572a69d92798f82f7b35ccc","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            if self.storage_network:"},{"line_number":165,"context_line":"                server \u003d self.os_primary.servers_client.show_server("},{"line_number":166,"context_line":"                    instance[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":167,"context_line":"                ip_addr \u003d server[\u0027addresses\u0027][self.network[\u0027name\u0027]][0][\u0027addr\u0027]"},{"line_number":168,"context_line":"            # Obtain a floating IP"},{"line_number":169,"context_line":"            floating_ip \u003d self.create_floating_ip(instance, ip_addr\u003dip_addr)"},{"line_number":170,"context_line":"            self.floating_ips[instance[\u0027id\u0027]] \u003d floating_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_9f3fa585","line":167,"in_reply_to":"1f493fa4_73df7f0c","updated":"2020-05-01 03:57:17.000000000","message":"Can we consolidate the methods and not create a separated one for ipv4,\nby using self.protocol variable?","commit_id":"e58e83b46f62204bb21a4fe55d0342370ec981c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c95afd135d50323021ee9d8143d8f6e7724483a8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            if self.storage_network:"},{"line_number":165,"context_line":"                server \u003d self.os_primary.servers_client.show_server("},{"line_number":166,"context_line":"                    instance[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":167,"context_line":"                ip_addr \u003d server[\u0027addresses\u0027][self.network[\u0027name\u0027]][0][\u0027addr\u0027]"},{"line_number":168,"context_line":"            # Obtain a floating IP"},{"line_number":169,"context_line":"            floating_ip \u003d self.create_floating_ip(instance, ip_addr\u003dip_addr)"},{"line_number":170,"context_line":"            self.floating_ips[instance[\u0027id\u0027]] \u003d floating_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_bfd701bf","line":167,"in_reply_to":"1f493fa4_9f3fa585","updated":"2020-05-01 06:18:50.000000000","message":"sure what would that look like? Feel free to refactor as you find fit..","commit_id":"e58e83b46f62204bb21a4fe55d0342370ec981c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"67dfcdceceea99bd3caacc519a532afbe0186e6c","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        return locations"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    def _get_ip_server_ip(self, instance, ip_version\u003d4):"},{"line_number":384,"context_line":"        ip_addrs \u003d []"},{"line_number":385,"context_line":"        for network_name, nic_list in instance[\u0027addresses\u0027].items():"},{"line_number":386,"context_line":"            if network_name \u003d\u003d self.storage_network_name:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_4f9a666e","line":383,"range":{"start_line":383,"start_character":8,"end_line":383,"end_character":25},"updated":"2020-05-04 17:28:40.000000000","message":"_get_server_ip","commit_id":"7636a1fce4c2b49a03338097f110fadbb3f81206"}]}