)]}'
{"manila_tempest_tests/tests/api/admin/test_admin_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"080b5c463161a67105b3a0a7f0d9982a1fe3656e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                self.sh[\"id\"], task_state, \u0027task_state\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class AdminActionsCephFSTest(base.BaseSharesMixedTest):"},{"line_number":151,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":154,"context_line":"    def test_different_users_in_same_tenant_can_use_same_cephx_id(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_16f3580c","line":151,"range":{"start_line":150,"start_character":0,"end_line":151,"end_character":23},"updated":"2020-05-11 20:01:10.000000000","message":"This isn\u0027t an \"admin action\", those include force-delete, reset-*state APIs on resources.. \n\nyou can move this to API rules tests under this class manila_tempest_tests.tests.api.test_rules.ShareCephxRulesForCephFSTest","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1416326453544ff839d78c445a4fcd380c3776e0","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                self.sh[\"id\"], task_state, \u0027task_state\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class AdminActionsCephFSTest(base.BaseSharesMixedTest):"},{"line_number":151,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":154,"context_line":"    def test_different_users_in_same_tenant_can_use_same_cephx_id(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_5dfa0842","line":151,"range":{"start_line":150,"start_character":0,"end_line":151,"end_character":23},"in_reply_to":"ff570b3c_16f3580c","updated":"2020-05-12 04:41:20.000000000","message":"Right, thanks","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"080b5c463161a67105b3a0a7f0d9982a1fe3656e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":154,"context_line":"    def test_different_users_in_same_tenant_can_use_same_cephx_id(self):"},{"line_number":155,"context_line":"        access_type, access_to \u003d self._get_access_rule_data_from_config()"},{"line_number":156,"context_line":"        share_type \u003d self._create_share_type()"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_966da89a","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":65},"updated":"2020-05-11 20:01:10.000000000","message":"What is the intention of this test?","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1416326453544ff839d78c445a4fcd380c3776e0","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    protocol \u003d \"cephfs\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":154,"context_line":"    def test_different_users_in_same_tenant_can_use_same_cephx_id(self):"},{"line_number":155,"context_line":"        access_type, access_to \u003d self._get_access_rule_data_from_config()"},{"line_number":156,"context_line":"        share_type \u003d self._create_share_type()"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_5d7de8af","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":65},"in_reply_to":"ff570b3c_966da89a","updated":"2020-05-12 04:41:20.000000000","message":"Vida can answer better than me the purpose of this test.\nThis is one of the tests from the list that have not yet been automated \nand need to be automated.\nAnd also this is one of the tests for verifying CephFS Native RFE.","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"080b5c463161a67105b3a0a7f0d9982a1fe3656e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        share_type \u003d self._create_share_type()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # Create the first share"},{"line_number":159,"context_line":"        share1 \u003d self.shares_v2_client.create_share("},{"line_number":160,"context_line":"            share_protocol\u003dself.protocol, share_type_id\u003dshare_type[\u0027id\u0027])"},{"line_number":161,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share, share1[\u0027id\u0027])"},{"line_number":162,"context_line":"        self.shares_v2_client.wait_for_share_status(share1[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_d6d1e059","line":159,"range":{"start_line":159,"start_character":22,"end_line":159,"end_character":51},"updated":"2020-05-11 20:01:10.000000000","message":"create_share\n\nUse the method in the base class, it takes care of cleanup and waiting for share status.","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1416326453544ff839d78c445a4fcd380c3776e0","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        share_type \u003d self._create_share_type()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # Create the first share"},{"line_number":159,"context_line":"        share1 \u003d self.shares_v2_client.create_share("},{"line_number":160,"context_line":"            share_protocol\u003dself.protocol, share_type_id\u003dshare_type[\u0027id\u0027])"},{"line_number":161,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share, share1[\u0027id\u0027])"},{"line_number":162,"context_line":"        self.shares_v2_client.wait_for_share_status(share1[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_3d5f5442","line":159,"range":{"start_line":159,"start_character":22,"end_line":159,"end_character":51},"in_reply_to":"ff570b3c_d6d1e059","updated":"2020-05-12 04:41:20.000000000","message":"Yes, thanks\nI don\u0027t know how I missed this method.","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"080b5c463161a67105b3a0a7f0d9982a1fe3656e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        user_client \u003d self.create_user_and_get_client(project)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # Create second share by the new user"},{"line_number":176,"context_line":"        share2 \u003d user_client.shares_v2_client.create_share("},{"line_number":177,"context_line":"            share_protocol\u003dself.protocol, share_type_id\u003dshare_type[\u0027id\u0027])"},{"line_number":178,"context_line":"        self.addCleanup("},{"line_number":179,"context_line":"            user_client.shares_v2_client.delete_share, share2[\u0027id\u0027])"},{"line_number":180,"context_line":"        user_client.shares_v2_client.wait_for_share_status(share2[\u0027id\u0027],"},{"line_number":181,"context_line":"                                                           \u0027available\u0027)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        # Grant access to the second share using the same cephx ID that was"},{"line_number":184,"context_line":"        # used in access1"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_56731081","line":181,"range":{"start_line":176,"start_character":0,"end_line":181,"end_character":71},"updated":"2020-05-11 20:01:10.000000000","message":"same comment as above","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1416326453544ff839d78c445a4fcd380c3776e0","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        user_client \u003d self.create_user_and_get_client(project)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # Create second share by the new user"},{"line_number":176,"context_line":"        share2 \u003d user_client.shares_v2_client.create_share("},{"line_number":177,"context_line":"            share_protocol\u003dself.protocol, share_type_id\u003dshare_type[\u0027id\u0027])"},{"line_number":178,"context_line":"        self.addCleanup("},{"line_number":179,"context_line":"            user_client.shares_v2_client.delete_share, share2[\u0027id\u0027])"},{"line_number":180,"context_line":"        user_client.shares_v2_client.wait_for_share_status(share2[\u0027id\u0027],"},{"line_number":181,"context_line":"                                                           \u0027available\u0027)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        # Grant access to the second share using the same cephx ID that was"},{"line_number":184,"context_line":"        # used in access1"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_bd4b6485","line":181,"range":{"start_line":176,"start_character":0,"end_line":181,"end_character":71},"in_reply_to":"ff570b3c_56731081","updated":"2020-05-12 04:41:20.000000000","message":"Done","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"080b5c463161a67105b3a0a7f0d9982a1fe3656e","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        access2 \u003d user_client.shares_v2_client.create_access_rule("},{"line_number":186,"context_line":"            share2[\u0027id\u0027], access_type, access_to, \u0027rw\u0027)"},{"line_number":187,"context_line":"        user_client.shares_v2_client.wait_for_access_rule_status("},{"line_number":188,"context_line":"            share2[\u0027id\u0027], access2[\u0027id\u0027], \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_d65f20e3","line":188,"range":{"start_line":188,"start_character":0,"end_line":188,"end_character":12},"updated":"2020-05-11 20:01:10.000000000","message":"There are no asserts here, what did you mean to test?","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1416326453544ff839d78c445a4fcd380c3776e0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        access2 \u003d user_client.shares_v2_client.create_access_rule("},{"line_number":186,"context_line":"            share2[\u0027id\u0027], access_type, access_to, \u0027rw\u0027)"},{"line_number":187,"context_line":"        user_client.shares_v2_client.wait_for_access_rule_status("},{"line_number":188,"context_line":"            share2[\u0027id\u0027], access2[\u0027id\u0027], \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9d35c0fa","line":188,"range":{"start_line":188,"start_character":0,"end_line":188,"end_character":12},"in_reply_to":"ff570b3c_d65f20e3","updated":"2020-05-12 04:41:20.000000000","message":"We need to test that the access is in \u0027active\u0027 state and it\u0027s done by \n\"wait_for_access_rule_status\" method.","commit_id":"34a2bd3c2aa61e5b4e0df8677fac53704ab9c3fb"}]}