)]}'
{"manila_tempest_tests/tests/api/admin/test_shares_actions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8a1fc323ba5f57a8e7ef95a0d97d88c1071ff5a5","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        self.assertEqual(1, len(gen), msg)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":404,"context_line":"    def test_share_server_is_created_or_not_created(self):"},{"line_number":405,"context_line":"        # This test will ensure that when a share creation request is handled,"},{"line_number":406,"context_line":"        # if the driver has the \"driver handles share servers\" option enabled,"},{"line_number":407,"context_line":"        # that a share server will be created, otherwise, not."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5c729f7c","line":404,"range":{"start_line":404,"start_character":0,"end_line":404,"end_character":58},"updated":"2020-08-03 17:48:25.000000000","message":"This test case isn\u0027t all that much different from this: https://github.com/openstack/manila-tempest-plugin/blob/1753a59b43448a77165103558d8d7a318b83f173/manila_tempest_tests/tests/api/admin/test_share_servers.py#L73","commit_id":"6a9eddf4ed84bda9c76bafa3301d4600ef85fd91"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0ba6f29a267759eb7012db60971ba8e1710cad39","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        self.assertEqual(1, len(gen), msg)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":404,"context_line":"    def test_share_server_is_created_or_not_created(self):"},{"line_number":405,"context_line":"        # This test will ensure that when a share creation request is handled,"},{"line_number":406,"context_line":"        # if the driver has the \"driver handles share servers\" option enabled,"},{"line_number":407,"context_line":"        # that a share server will be created, otherwise, not."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bcaadb6d","line":404,"range":{"start_line":404,"start_character":0,"end_line":404,"end_character":58},"in_reply_to":"9f560f44_5c729f7c","updated":"2020-08-03 18:10:36.000000000","message":"But the test runs only when multitenancy_enabled is enabled.\nThis test covers both cases and verifies that share server\nis not created when multitenancy_enabled is not enabled.","commit_id":"6a9eddf4ed84bda9c76bafa3301d4600ef85fd91"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4faf54439afa8b56ce3b76d57b3ee4b945a63dea","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        self.assertEqual(1, len(gen), msg)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":404,"context_line":"    def test_share_server_is_created_or_not_created(self):"},{"line_number":405,"context_line":"        # This test will ensure that when a share creation request is handled,"},{"line_number":406,"context_line":"        # if the driver has the \"driver handles share servers\" option enabled,"},{"line_number":407,"context_line":"        # that a share server will be created, otherwise, not."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2ee84d7a","line":404,"range":{"start_line":404,"start_character":0,"end_line":404,"end_character":58},"in_reply_to":"9f560f44_5fcf3155","updated":"2020-08-04 05:15:26.000000000","message":"Right, thanks.\nWe just need to add this validation to the test.","commit_id":"6a9eddf4ed84bda9c76bafa3301d4600ef85fd91"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"56b216afdf3960ea87f0b1225c865e5dd7e72ac5","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        self.assertEqual(1, len(gen), msg)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":404,"context_line":"    def test_share_server_is_created_or_not_created(self):"},{"line_number":405,"context_line":"        # This test will ensure that when a share creation request is handled,"},{"line_number":406,"context_line":"        # if the driver has the \"driver handles share servers\" option enabled,"},{"line_number":407,"context_line":"        # that a share server will be created, otherwise, not."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5fcf3155","line":404,"range":{"start_line":404,"start_character":0,"end_line":404,"end_character":58},"in_reply_to":"9f560f44_bcaadb6d","updated":"2020-08-03 19:37:36.000000000","message":"True, but, as cloud administrator (which this test case runs as), you will be able to list all available share servers in the cloud - even those not created by tempest tests\n\n\nso if this test case runs on a deployment with both DHSS\u003dTrue and DHSS\u003dFalse backends with some shares, the test can fail.\n\nIt looks like what you want to test is to add an admin test to create/delete share (like https://github.com/openstack/manila-tempest-plugin/blob/3b4d4850a9dc13fda5e92d621f750634eabcf44e/manila_tempest_tests/tests/api/test_shares.py#L45) and verify the admin only field \"share_server_id\" is present and has a valid share server in case \"CONF.share.multitenancy_enabled\" is set to True; and if the config value is False, you\u0027ll want to check that share_server_id is present, but empty.","commit_id":"6a9eddf4ed84bda9c76bafa3301d4600ef85fd91"}],"manila_tempest_tests/tests/api/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2e052bd451098198a1e949d4878e317c57ac2da","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # that a share server will be created, otherwise, not."},{"line_number":116,"context_line":"        share_get \u003d self.admin_shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":117,"context_line":"        share_server \u003d share_get[\u0027share_server_id\u0027]"},{"line_number":118,"context_line":"        extra_spec \u003d self.admin_shares_v2_client.get_share_type_extra_spec("},{"line_number":119,"context_line":"            self.share_type_id, \"driver_handles_share_servers\")"},{"line_number":120,"context_line":"        if str(extra_spec[\u0027driver_handles_share_servers\u0027]) \u003d\u003d \u0027True\u0027:"},{"line_number":121,"context_line":"            self.assertNotEmpty(share_server)"},{"line_number":122,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_68763841","line":119,"range":{"start_line":118,"start_character":21,"end_line":119,"end_character":63},"updated":"2020-08-12 23:56:26.000000000","message":"this call is unnecessary, since you have this info, and its not going to change.. \n\n self.share_type[\u0027required_extra_specs\u0027][\u0027driver_handles_share_servers\u0027]\n\nor just\n\n CONF.share.multitenancy_enabled","commit_id":"9ec92ce05f6aa9196f5cb3799b2ed691da9d871b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"02ba177f78586840e8c87f8c9f0745f4bdfd6015","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # that a share server will be created, otherwise, not."},{"line_number":116,"context_line":"        share_get \u003d self.admin_shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":117,"context_line":"        share_server \u003d share_get[\u0027share_server_id\u0027]"},{"line_number":118,"context_line":"        extra_spec \u003d self.admin_shares_v2_client.get_share_type_extra_spec("},{"line_number":119,"context_line":"            self.share_type_id, \"driver_handles_share_servers\")"},{"line_number":120,"context_line":"        if str(extra_spec[\u0027driver_handles_share_servers\u0027]) \u003d\u003d \u0027True\u0027:"},{"line_number":121,"context_line":"            self.assertNotEmpty(share_server)"},{"line_number":122,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_dff3939e","line":119,"range":{"start_line":118,"start_character":21,"end_line":119,"end_character":63},"in_reply_to":"9f560f44_68763841","updated":"2020-08-17 06:01:31.000000000","message":"Done","commit_id":"9ec92ce05f6aa9196f5cb3799b2ed691da9d871b"}]}