)]}'
{"manila_tempest_tests/tests/api/test_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4665e2fc80a5c411b555bfc0859c5b4af9ba5ec","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        self.assertEqual(md, get_md)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key in md.keys():"},{"line_number":72,"context_line":"            get_item \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":73,"context_line":"            self.assertIn(key, get_item.keys())"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c7007c3f_97f864f2","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":29},"updated":"2021-04-12 20:50:32.000000000","message":"instead of verifying just presence of the key, verify the value perhaps?\n\n for key, value in md.items():\n    get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)\n    self.assertEqual(md[key], get_value)","commit_id":"f43c41b387ab7a9b6a1fd0b5fddf2a7a66a0a79c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b0817afdc60fbdc6a09fb3cdd73061bf107ad239","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        self.assertEqual(md, get_md)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key, value in md.items():"},{"line_number":72,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":73,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"272ebd15_9c62faf1","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":22},"updated":"2021-06-22 04:49:18.000000000","message":"If this is unused variable please change it to \"_\"","commit_id":"978eaea9f81b0d61f1b2389bdf4f8e1230d8fe6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4b100f77954b36f29a13483d8f795930d6c4842","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key, value in md.items():"},{"line_number":72,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":73,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # delete metadata"},{"line_number":76,"context_line":"        for key in md.keys():"}],"source_content_type":"text/x-python","patch_set":6,"id":"06eda595_cea4ec8f","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":36},"updated":"2021-06-21 22:17:05.000000000","message":"value","commit_id":"978eaea9f81b0d61f1b2389bdf4f8e1230d8fe6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"db3ee21ba378a9cb7cb614648a3f166fc63d05cb","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        self.assertEqual(md, get_md)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key, _value in md.items():"},{"line_number":72,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":73,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ca21e157_ad62a505","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":23},"updated":"2021-06-24 19:14:36.000000000","message":"I think Liron meant to update this to \"_\" because it\u0027s an unused variable.. \nIf you want to avoid the unused variable issue, you can rewrite this in two ways:\n\n for key in md:\n   get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)\n   self.assertEqual(md[key], get_value[key])\n\nor\n\n for key, value in md.items():\n   get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)\n   self.assertEqual(value, get_value[key])","commit_id":"98492b22d618214bac3bf6f48604dfdd67a66c5b"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"851f0c0ca9ab594d9d0396dd6e88bb9d82a9eacf","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertEqual(md, get_md)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # verify metadata items"},{"line_number":71,"context_line":"        for key, _value in md.items():"},{"line_number":72,"context_line":"            get_value \u003d self.shares_client.get_metadata_item(share[\"id\"], key)"},{"line_number":73,"context_line":"            self.assertEqual(md[key], get_value[key])"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba733f90_b3aa9b4b","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":23},"in_reply_to":"ca21e157_ad62a505","updated":"2021-06-24 20:02:47.000000000","message":"Done","commit_id":"98492b22d618214bac3bf6f48604dfdd67a66c5b"}]}