)]}'
{"manila_tempest_tests/tests/scenario/manager_share.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"01877f1b4ef72b07c2f686ab1ff4c22a45b7920e","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                                                     oc_size\u003d20971520):"},{"line_number":386,"context_line":"        \"\"\"Provide an access to a client identified by cephx authentication"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param: share: An existed share."},{"line_number":389,"context_line":"        :param: access: An existed access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existed access rule."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_4f9355fb","line":388,"range":{"start_line":388,"start_character":26,"end_line":388,"end_character":33},"updated":"2020-11-02 16:41:26.000000000","message":"nit: s/existed/existing/","commit_id":"87918e98c6a6b7321d2f73af05db9c4d50e375df"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"77f10626d2b33d2e6ccdb42ca56376f3e65d8cff","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                                                     oc_size\u003d20971520):"},{"line_number":386,"context_line":"        \"\"\"Provide an access to a client identified by cephx authentication"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param: share: An existed share."},{"line_number":389,"context_line":"        :param: access: An existed access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existed access rule."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_5581248f","line":388,"range":{"start_line":388,"start_character":26,"end_line":388,"end_character":33},"in_reply_to":"1f621f24_4f9355fb","updated":"2020-11-02 19:15:15.000000000","message":"Done","commit_id":"87918e98c6a6b7321d2f73af05db9c4d50e375df"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"01877f1b4ef72b07c2f686ab1ff4c22a45b7920e","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        \"\"\"Provide an access to a client identified by cephx authentication"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param: share: An existed share."},{"line_number":389,"context_line":"        :param: access: An existed access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existed access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_4facf533","line":389,"range":{"start_line":389,"start_character":27,"end_line":389,"end_character":34},"updated":"2020-11-02 16:41:26.000000000","message":"ditto","commit_id":"87918e98c6a6b7321d2f73af05db9c4d50e375df"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"77f10626d2b33d2e6ccdb42ca56376f3e65d8cff","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        \"\"\"Provide an access to a client identified by cephx authentication"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param: share: An existed share."},{"line_number":389,"context_line":"        :param: access: An existed access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existed access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_954c5c9f","line":389,"range":{"start_line":389,"start_character":27,"end_line":389,"end_character":34},"in_reply_to":"1f621f24_4facf533","updated":"2020-11-02 19:15:15.000000000","message":"Done","commit_id":"87918e98c6a6b7321d2f73af05db9c4d50e375df"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"01877f1b4ef72b07c2f686ab1ff4c22a45b7920e","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        :param: share: An existed share."},{"line_number":389,"context_line":"        :param: access: An existed access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existed access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."},{"line_number":393,"context_line":"        :param: access_to: Authorized ID."},{"line_number":394,"context_line":"        :param: remote_client: An SSH client connection to the Nova instance."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_8f63ad1a","line":391,"range":{"start_line":391,"start_character":24,"end_line":391,"end_character":31},"updated":"2020-11-02 16:41:26.000000000","message":"ditto","commit_id":"87918e98c6a6b7321d2f73af05db9c4d50e375df"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"77f10626d2b33d2e6ccdb42ca56376f3e65d8cff","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        :param: share: An existed share."},{"line_number":389,"context_line":"        :param: access: An existed access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existed access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."},{"line_number":393,"context_line":"        :param: access_to: Authorized ID."},{"line_number":394,"context_line":"        :param: remote_client: An SSH client connection to the Nova instance."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_754f0092","line":391,"range":{"start_line":391,"start_character":24,"end_line":391,"end_character":31},"in_reply_to":"1f621f24_8f63ad1a","updated":"2020-11-02 19:15:15.000000000","message":"Done","commit_id":"87918e98c6a6b7321d2f73af05db9c4d50e375df"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"01877f1b4ef72b07c2f686ab1ff4c22a45b7920e","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        :return: Share access."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        client \u003d client or self.shares_v2_client"},{"line_number":402,"context_line":"        if not access:"},{"line_number":403,"context_line":"            share \u003d share or self.share"},{"line_number":404,"context_line":"            access_to \u003d access_to or data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_0f779dd6","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":48},"updated":"2020-11-02 16:41:26.000000000","message":"Can this be set after the following line?  Unless I\u0027m missing something, it\u0027s only used at line 415, inside the scope of the \u0027if\u0027 at line 402.","commit_id":"87918e98c6a6b7321d2f73af05db9c4d50e375df"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"77f10626d2b33d2e6ccdb42ca56376f3e65d8cff","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        :return: Share access."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        client \u003d client or self.shares_v2_client"},{"line_number":402,"context_line":"        if not access:"},{"line_number":403,"context_line":"            share \u003d share or self.share"},{"line_number":404,"context_line":"            access_to \u003d access_to or data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_352aa88f","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":48},"in_reply_to":"1f621f24_0f779dd6","updated":"2020-11-02 19:15:15.000000000","message":"Actually, it was supposed to be used in other places.","commit_id":"87918e98c6a6b7321d2f73af05db9c4d50e375df"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bdc8d2d1d3595f7f082e80a3058fbb02aa9543c2","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        \"\"\"Provide an access to a client identified by cephx authentication"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param: share: An existing share."},{"line_number":389,"context_line":"        :param: access: An existing access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existing access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_70c1cee4","line":389,"range":{"start_line":389,"start_character":16,"end_line":389,"end_character":22},"updated":"2020-11-02 20:39:17.000000000","message":"suggest using \"access_rule\" to clarify the meaning further, and separate concerns with the other access rule data in the signature: access_level and access_to","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d2a9e9ec2498ddc15f905de75c688599b3f823cd","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        \"\"\"Provide an access to a client identified by cephx authentication"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param: share: An existing share."},{"line_number":389,"context_line":"        :param: access: An existing access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existing access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_781c1012","line":389,"range":{"start_line":389,"start_character":16,"end_line":389,"end_character":22},"in_reply_to":"1f621f24_70c1cee4","updated":"2020-11-03 06:21:59.000000000","message":"Done","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bdc8d2d1d3595f7f082e80a3058fbb02aa9543c2","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        :param: access: An existing access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existing access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."},{"line_number":393,"context_line":"        :param: access_to: Authorized ID."},{"line_number":394,"context_line":"        :param: remote_client: An SSH client connection to the Nova instance."},{"line_number":395,"context_line":"        :param: locations: Export locations of shares."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_307c76b4","line":392,"range":{"start_line":392,"start_character":48,"end_line":392,"end_character":49},"updated":"2020-11-02 20:39:17.000000000","message":"Add - this is not required if \"access_rule\" is set.","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d2a9e9ec2498ddc15f905de75c688599b3f823cd","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        :param: access: An existing access rule. In case we want to create the"},{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existing access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."},{"line_number":393,"context_line":"        :param: access_to: Authorized ID."},{"line_number":394,"context_line":"        :param: remote_client: An SSH client connection to the Nova instance."},{"line_number":395,"context_line":"        :param: locations: Export locations of shares."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_581794ee","line":392,"range":{"start_line":392,"start_character":48,"end_line":392,"end_character":49},"in_reply_to":"1f621f24_307c76b4","updated":"2020-11-03 06:21:59.000000000","message":"Done","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bdc8d2d1d3595f7f082e80a3058fbb02aa9543c2","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existing access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."},{"line_number":393,"context_line":"        :param: access_to: Authorized ID."},{"line_number":394,"context_line":"        :param: remote_client: An SSH client connection to the Nova instance."},{"line_number":395,"context_line":"        :param: locations: Export locations of shares."},{"line_number":396,"context_line":"        :param: client: Client object."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_10605a01","line":393,"range":{"start_line":393,"start_character":27,"end_line":393,"end_character":41},"updated":"2020-11-02 20:39:17.000000000","message":"access_to: client to provide access to; this is not required if \"access_rule\" is set.","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d2a9e9ec2498ddc15f905de75c688599b3f823cd","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        configuration files in the instance according to an"},{"line_number":391,"context_line":"                        existing access rule."},{"line_number":392,"context_line":"        :param: access_level: Share access level."},{"line_number":393,"context_line":"        :param: access_to: Authorized ID."},{"line_number":394,"context_line":"        :param: remote_client: An SSH client connection to the Nova instance."},{"line_number":395,"context_line":"        :param: locations: Export locations of shares."},{"line_number":396,"context_line":"        :param: client: Client object."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_b8d34838","line":393,"range":{"start_line":393,"start_character":27,"end_line":393,"end_character":41},"in_reply_to":"1f621f24_10605a01","updated":"2020-11-03 06:21:59.000000000","message":"Done","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bdc8d2d1d3595f7f082e80a3058fbb02aa9543c2","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            access_to \u003d access_to or data_utils.rand_name("},{"line_number":405,"context_line":"                self.__class__.__name__ + \u0027-cephx-id\u0027)"},{"line_number":406,"context_line":"            # Check if access is already granted to the client"},{"line_number":407,"context_line":"            access \u003d client.list_access_rules("},{"line_number":408,"context_line":"                share[\u0027id\u0027], metadata\u003d{\u0027metadata\u0027: {\u0027access_to\u0027: access_to}})"},{"line_number":409,"context_line":"            access \u003d access[0] if access else None"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_1077bad6","line":407,"range":{"start_line":407,"start_character":12,"end_line":407,"end_character":18},"updated":"2020-11-02 20:39:17.000000000","message":"nit: access_rules_matching_client\n\nperhaps?","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d2a9e9ec2498ddc15f905de75c688599b3f823cd","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            access_to \u003d access_to or data_utils.rand_name("},{"line_number":405,"context_line":"                self.__class__.__name__ + \u0027-cephx-id\u0027)"},{"line_number":406,"context_line":"            # Check if access is already granted to the client"},{"line_number":407,"context_line":"            access \u003d client.list_access_rules("},{"line_number":408,"context_line":"                share[\u0027id\u0027], metadata\u003d{\u0027metadata\u0027: {\u0027access_to\u0027: access_to}})"},{"line_number":409,"context_line":"            access \u003d access[0] if access else None"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_98d64c27","line":407,"range":{"start_line":407,"start_character":12,"end_line":407,"end_character":18},"in_reply_to":"1f621f24_1077bad6","updated":"2020-11-03 06:21:59.000000000","message":"Done","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bdc8d2d1d3595f7f082e80a3058fbb02aa9543c2","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            # Check if access is already granted to the client"},{"line_number":407,"context_line":"            access \u003d client.list_access_rules("},{"line_number":408,"context_line":"                share[\u0027id\u0027], metadata\u003d{\u0027metadata\u0027: {\u0027access_to\u0027: access_to}})"},{"line_number":409,"context_line":"            access \u003d access[0] if access else None"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"            if not access:"},{"line_number":412,"context_line":"                access \u003d self._allow_access("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_3055961e","line":409,"range":{"start_line":409,"start_character":12,"end_line":409,"end_character":18},"updated":"2020-11-02 20:39:17.000000000","message":"access_rule","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d2a9e9ec2498ddc15f905de75c688599b3f823cd","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            # Check if access is already granted to the client"},{"line_number":407,"context_line":"            access \u003d client.list_access_rules("},{"line_number":408,"context_line":"                share[\u0027id\u0027], metadata\u003d{\u0027metadata\u0027: {\u0027access_to\u0027: access_to}})"},{"line_number":409,"context_line":"            access \u003d access[0] if access else None"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"            if not access:"},{"line_number":412,"context_line":"                access \u003d self._allow_access("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_f8ddc042","line":409,"range":{"start_line":409,"start_character":12,"end_line":409,"end_character":18},"in_reply_to":"1f621f24_3055961e","updated":"2020-11-03 06:21:59.000000000","message":"Done","commit_id":"be6cf37dd1fd75a5976ef7b169d334e18f2877a3"}]}